From patchwork Wed Oct 17 16:51:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Avri Altman X-Patchwork-Id: 10645937 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CE112112B for ; Wed, 17 Oct 2018 16:52:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BE3CD2875C for ; Wed, 17 Oct 2018 16:52:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B11C928760; Wed, 17 Oct 2018 16:52:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 57FC12875C for ; Wed, 17 Oct 2018 16:52:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727219AbeJRAsm (ORCPT ); Wed, 17 Oct 2018 20:48:42 -0400 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:46348 "EHLO esa3.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727053AbeJRAsl (ORCPT ); Wed, 17 Oct 2018 20:48:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1539795130; x=1571331130; h=from:to:cc:subject:date:message-id; bh=l6n/X7TS73OOJGnXafTF2whvAJrfRZgKlCG0SmXT66s=; b=Vnrfh1Yhkcr+qCDSbsYXZcIFJB8wNGHFoFxtBtyjOVif5dfZhjR1AzPC 9Odq595/Ya8jLiJXuTdzdjIkeFNbNPQ5dr8tuVg6kWekI7aYaHu3kdAZ4 L8IULQNkfNm0YDq/HReQloBIuhEbgfDwWaQs286z2afQGTGnxFi9514Pb bQKQXg+RgqQeEkGiSbQilpfuN+XDxZNJStt051oL/hXAgdrlmkzpgsd0F IUMrVfsLbZ57gvGI5uaUzvBc0vFHcdnr2++ASiogrVqxplfX5/esNwMvk enuQ2nkgFLe0u0h/9+gXoQ+pRIXQuQmgaNS9RoSrDUwRHYuoZnxB4d3ac w==; X-IronPort-AV: E=Sophos;i="5.54,393,1534780800"; d="scan'208";a="96799170" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 18 Oct 2018 00:52:10 +0800 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP; 17 Oct 2018 09:36:41 -0700 Received: from kfae422988.sdcorp.global.sandisk.com ([10.0.231.37]) by uls-op-cesaip02.wdc.com with ESMTP; 17 Oct 2018 09:52:08 -0700 From: Avri Altman To: Jens Axboe , linux-block@vger.kernel.org Cc: Avi Shchislowski , Alex Lemberg , Avri Altman Subject: [PATCH] block: Make write_hints[] big enough Date: Wed, 17 Oct 2018 19:51:21 +0300 Message-Id: <1539795081-2394-1-git-send-email-avri.altman@wdc.com> X-Mailer: git-send-email 1.9.1 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Just stumbled over this. Looks like the write hints array in the request queue is not allotted with the required space to accommodate all the write hint types. fixes: f793dfd3f39a (blk-mq: expose write hints through debugfs) Signed-off-by: Avri Altman --- include/linux/blkdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index d6869e0..0c8010d 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -665,7 +665,7 @@ struct request_queue { struct work_struct release_work; -#define BLK_MAX_WRITE_HINTS 5 +#define BLK_MAX_WRITE_HINTS 6 u64 write_hints[BLK_MAX_WRITE_HINTS]; };