From patchwork Mon Jul 20 19:41:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Modem, Bhanuprakash" X-Patchwork-Id: 11673573 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1DAC2913 for ; Mon, 20 Jul 2020 11:46:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06DE22070A for ; Mon, 20 Jul 2020 11:46:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06DE22070A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CC0F26E370; Mon, 20 Jul 2020 11:46:20 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id A7E976E0D2 for ; Mon, 20 Jul 2020 11:46:17 +0000 (UTC) IronPort-SDR: fsgdUvmNTRAH189fRw5dPgbtEswkHkcaVDqfRi1dceFTEwVY+JMFEH9VfoNiZzUAUx4DQtcJUO 8n9r6e4zDrhg== X-IronPort-AV: E=McAfee;i="6000,8403,9687"; a="168023695" X-IronPort-AV: E=Sophos;i="5.75,374,1589266800"; d="scan'208";a="168023695" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 04:46:17 -0700 IronPort-SDR: CalEX/Y7hn5JiCRjpjlob75ySiLmJtEIXs7BtOGfauxI2d3lbjo8iVi3K94DJLuzC2kqua47Vh MZPFAkN62lDg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,374,1589266800"; d="scan'208";a="487216427" Received: from bhanu-nuc8i7beh.iind.intel.com ([10.145.162.210]) by fmsmga006.fm.intel.com with ESMTP; 20 Jul 2020 04:46:16 -0700 From: Bhanuprakash Modem To: bhanuprakash.modem@intel.com, intel-gfx@lists.freedesktop.org Date: Tue, 21 Jul 2020 01:11:26 +0530 Message-Id: <20200720194127.24750-2-bhanuprakash.modem@intel.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200720194127.24750-1-bhanuprakash.modem@intel.com> References: <20200720194127.24750-1-bhanuprakash.modem@intel.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 1/2] i915/debug: Expose crtc dither state via debugfs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" [Why] It's useful to know the dithering state for IGT testing. [How] Expose the dithering state for the crtc via a debugfs file "dither". Example usage: cat /sys/kernel/debug/dri/0/crtc-0/dither Signed-off-by: Bhanuprakash Modem --- drivers/gpu/drm/i915/i915_debugfs.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 94ed442910d6..18646566f2ea 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -1902,13 +1902,30 @@ static const struct i915_debugfs_files { #endif }; +static int dither_state_show(struct seq_file *m, void *data) +{ + struct intel_crtc *crtc = to_intel_crtc(m->private); + struct intel_crtc_state *crtc_state = to_intel_crtc_state(crtc->base.state); + + seq_printf(m, "Dither: %u\n", crtc_state->dither); + + return 0; +} +DEFINE_SHOW_ATTRIBUTE(dither_state); + void i915_debugfs_register(struct drm_i915_private *dev_priv) { struct drm_minor *minor = dev_priv->drm.primary; + struct drm_device *dev = &dev_priv->drm; + struct drm_crtc *crtc; int i; i915_debugfs_params(dev_priv); + drm_for_each_crtc(crtc, dev) + debugfs_create_file("dither", S_IRUGO, crtc->debugfs_entry, crtc, + &dither_state_fops); + debugfs_create_file("i915_forcewake_user", S_IRUSR, minor->debugfs_root, to_i915(minor->dev), &i915_forcewake_fops); for (i = 0; i < ARRAY_SIZE(i915_debugfs_files); i++) { From patchwork Mon Jul 20 19:41:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Modem, Bhanuprakash" X-Patchwork-Id: 11673571 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 31012913 for ; Mon, 20 Jul 2020 11:46:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 181AC2080D for ; Mon, 20 Jul 2020 11:46:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 181AC2080D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8A17E6E174; Mon, 20 Jul 2020 11:46:20 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id D9A486E370 for ; Mon, 20 Jul 2020 11:46:18 +0000 (UTC) IronPort-SDR: L1691Y2aQpoDtpY7HBCn51x9fxgnO+hckD0NH3FoUzyw7QlwVCtfNaJimvCCgAAG6fAkD65tTO TZSe9vOWLeTA== X-IronPort-AV: E=McAfee;i="6000,8403,9687"; a="168023696" X-IronPort-AV: E=Sophos;i="5.75,374,1589266800"; d="scan'208";a="168023696" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 04:46:18 -0700 IronPort-SDR: ppvzyTx7Wlod67DrYXUwch/3m241TcxzgTGphT3tcOhMfdoK9MeDdMbjN9Cys4mSl7Pi6IIg/Y MgMlxKPu8wGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,374,1589266800"; d="scan'208";a="487216431" Received: from bhanu-nuc8i7beh.iind.intel.com ([10.145.162.210]) by fmsmga006.fm.intel.com with ESMTP; 20 Jul 2020 04:46:17 -0700 From: Bhanuprakash Modem To: bhanuprakash.modem@intel.com, intel-gfx@lists.freedesktop.org Date: Tue, 21 Jul 2020 01:11:27 +0530 Message-Id: <20200720194127.24750-3-bhanuprakash.modem@intel.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200720194127.24750-1-bhanuprakash.modem@intel.com> References: <20200720194127.24750-1-bhanuprakash.modem@intel.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 2/2] i915/debug: Expose Max BPC info via debugfs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" [Why] It's useful to know the max supported panel BPC for IGT testing. [How] Expose the max supported BPC for the panel via a debugfs file on the connector, "output_bpc". Example usage: cat /sys/kernel/debug/dri/0/DP-1/output_bpc Signed-off-by: Bhanuprakash Modem --- .../drm/i915/display/intel_display_debugfs.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c index 3644752cc5ec..0877d029af77 100644 --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c @@ -2185,6 +2185,20 @@ static const struct file_operations i915_dsc_fec_support_fops = { .write = i915_dsc_fec_support_write }; +/* + * Returns the maximum output bpc for the connector. + * Example usage: cat /sys/kernel/debug/dri/0/DP-1/output_bpc + */ +static int output_bpc_show(struct seq_file *m, void *data) +{ + struct drm_connector *connector = m->private; + + seq_printf(m, "Maximum: %u\n", connector->display_info.bpc); + + return 0; +} +DEFINE_SHOW_ATTRIBUTE(output_bpc); + /** * intel_connector_debugfs_add - add i915 specific connector debugfs files * @connector: pointer to a registered drm_connector @@ -2235,5 +2249,8 @@ int intel_connector_debugfs_add(struct drm_connector *connector) debugfs_create_file("i915_lpsp_capability", 0444, root, connector, &i915_lpsp_capability_fops); + debugfs_create_file("output_bpc", S_IRUGO, root, + connector, &output_bpc_fops); + return 0; }