From patchwork Thu Jul 23 12:24:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680865 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7651C13A4 for ; Thu, 23 Jul 2020 12:27:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D7752086A for ; Thu, 23 Jul 2020 12:27:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="x9xIRc8B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728787AbgGWMYx (ORCPT ); Thu, 23 Jul 2020 08:24:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728766AbgGWMYw (ORCPT ); Thu, 23 Jul 2020 08:24:52 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01209C0619DC for ; Thu, 23 Jul 2020 05:24:52 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id r12so4937876wrj.13 for ; Thu, 23 Jul 2020 05:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+9PaEaIsKMEWOx7bFf6DhjJ/McDAgdpRr9jNHocJ3y8=; b=x9xIRc8BVSrl8u01AVESZka58nbBj/IF2Fz01LeRW4iALYH5DCoZhDGPChOk3qObyy rOQ/9Nbg01O5qNl88YLq/bXG9CqzZrOFN9HsgQ8T3ziBms2XgeTqcg+6DC48zLBUfEDh byKy80r1fA+dzpmUJIIY88iP59VNpB44KOBGx4ksSAkW8BCmBNkYQym9U7W+5zkzcUaF eI2XEwK3Bc84JDcqut2qMkk0N3WnPTf18IkVx5hyv65PcUhyYZCrjl3HtBFLogOt+/ds 014uj/v92QKwNOJQOQAs4HUUlEwuVF9SSTMljevPGgYpfK2Y2ra/LqE6BcDHh6S5DzQ5 goWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+9PaEaIsKMEWOx7bFf6DhjJ/McDAgdpRr9jNHocJ3y8=; b=DPBL3uI0a3VKuCXkgNK63q4zECdIxQ7W05rHggNIQIWBOInieGWw8aDTdGDXnnxA8m kzT3ksvRmISlf8ZDRYOkg2M0Pcet/BmELQL9PTn8yUjAP7SeoGk/OPDHAjMA0wSpjD2C dr+7+Q8MecCrx76ODm3GPvc77wsb9OaovJqLheb6FyUPqGrajmsqO8PvV9hfuTwK/HTD guKCuLtMSvnUWkAtyG8oZQYJVHp2nxAM2E5hebFrzden4H4p2p0+B7/Syd3GorQaXIqc zUVlrlJMDjoWUgQXRDWy+xHyLANNUwi/8loeT2jBGMTq6CGFOtcVYnwI7qCm+03DgAaa bDZg== X-Gm-Message-State: AOAM530AFHSAI6tYeY/I4r6tN64yh2pBN2JBTiAYpr2l7xcEthgO28HX qzJSb4ncohe2sZIwu7nc1+g7JkIcibo= X-Google-Smtp-Source: ABdhPJy4rm9x5OFypqUgzUWnvxNthkU6Bnh96rSEPmDGgbkWO/TH4z9TD8CCUy9bDeZvExf70BCczQ== X-Received: by 2002:adf:e98c:: with SMTP id h12mr3772971wrm.3.1595507090720; Thu, 23 Jul 2020 05:24:50 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.24.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:24:50 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , James Smart , Dick Kennedy Subject: [PATCH 01/40] scsi: lpfc: lpfc_els: Fix some function parameter descriptions Date: Thu, 23 Jul 2020 13:24:07 +0100 Message-Id: <20200723122446.1329773-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/lpfc/lpfc_els.c:3619: warning: Function parameter or member 't' not described in 'lpfc_els_retry_delay' drivers/scsi/lpfc/lpfc_els.c:3619: warning: Excess function parameter 'ptr' description in 'lpfc_els_retry_delay' drivers/scsi/lpfc/lpfc_els.c:4877: warning: Function parameter or member 'rejectError' not described in 'lpfc_els_rsp_reject' drivers/scsi/lpfc/lpfc_els.c:7900: warning: Function parameter or member 't' not described in 'lpfc_els_timeout' drivers/scsi/lpfc/lpfc_els.c:7900: warning: Excess function parameter 'ptr' description in 'lpfc_els_timeout' drivers/scsi/lpfc/lpfc_els.c:8272: warning: Function parameter or member 'payload' not described in 'lpfc_send_els_event' drivers/scsi/lpfc/lpfc_els.c:8272: warning: Excess function parameter 'cmd' description in 'lpfc_send_els_event' drivers/scsi/lpfc/lpfc_els.c:8355: warning: Function parameter or member 'tlv' not described in 'lpfc_els_rcv_fpin_li' drivers/scsi/lpfc/lpfc_els.c:8355: warning: Excess function parameter 'lnk_not' description in 'lpfc_els_rcv_fpin_li' drivers/scsi/lpfc/lpfc_els.c:9688: warning: Function parameter or member 't' not described in 'lpfc_fabric_block_timeout' drivers/scsi/lpfc/lpfc_els.c:9688: warning: Excess function parameter 'ptr' description in 'lpfc_fabric_block_timeout' Cc: James Smart Cc: Dick Kennedy Signed-off-by: Lee Jones --- drivers/scsi/lpfc/lpfc_els.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 23adf76e9aa8b..85d4e4000c25f 100644 --- a/drivers/scsi/lpfc/lpfc_els.c +++ b/drivers/scsi/lpfc/lpfc_els.c @@ -3602,7 +3602,7 @@ lpfc_cancel_retry_delay_tmo(struct lpfc_vport *vport, struct lpfc_nodelist *nlp) /** * lpfc_els_retry_delay - Timer function with a ndlp delayed function timer - * @ptr: holder for the pointer to the timer function associated data (ndlp). + * @t: pointer to the timer function associated data (ndlp). * * This routine is invoked by the ndlp delayed-function timer to check * whether there is any pending ELS retry event(s) with the node. If not, it @@ -4851,7 +4851,7 @@ lpfc_els_rsp_acc(struct lpfc_vport *vport, uint32_t flag, /** * lpfc_els_rsp_reject - Propare and issue a rjt response iocb command * @vport: pointer to a virtual N_Port data structure. - * @rejectError: + * @rejectError: reject response to issue * @oldiocb: pointer to the original lpfc command iocb data structure. * @ndlp: pointer to a node-list data structure. * @mbox: pointer to the driver internal queue element for mailbox command. @@ -7887,7 +7887,7 @@ lpfc_els_rcv_fan(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb, /** * lpfc_els_timeout - Handler funciton to the els timer - * @ptr: holder for the timer function associated data. + * @t: timer context used to obtain the vport. * * This routine is invoked by the ELS timer after timeout. It posts the ELS * timer timeout event by setting the WORKER_ELS_TMO bit to the work port @@ -8260,7 +8260,7 @@ lpfc_send_els_failure_event(struct lpfc_hba *phba, * lpfc_send_els_event - Posts unsolicited els event * @vport: Pointer to vport object. * @ndlp: Pointer FC node object. - * @cmd: ELS command code. + * @payload: ELS command code type. * * This function posts an event when there is an incoming * unsolicited ELS command. @@ -8345,7 +8345,7 @@ DECLARE_ENUM2STR_LOOKUP(lpfc_get_fpin_li_event_nm, fc_fpin_li_event_types, /** * lpfc_els_rcv_fpin_li - Process an FPIN Link Integrity Event. * @vport: Pointer to vport object. - * @lnk_not: Pointer to the Link Integrity Notification Descriptor. + * @tlv: Pointer to the Link Integrity Notification Descriptor. * * This function processes a link integrity FPIN event by * logging a message @@ -9674,7 +9674,7 @@ lpfc_issue_els_npiv_logo(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp) /** * lpfc_fabric_block_timeout - Handler function to the fabric block timer - * @ptr: holder for the timer function associated data. + * @t: timer context used to obtain the lpfc hba. * * This routine is invoked by the fabric iocb block timer after * timeout. It posts the fabric iocb block timeout event by setting the From patchwork Thu Jul 23 12:24:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680867 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6845113A4 for ; Thu, 23 Jul 2020 12:27:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49E8020792 for ; Thu, 23 Jul 2020 12:27:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="C/HEfOZW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729390AbgGWM1q (ORCPT ); Thu, 23 Jul 2020 08:27:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728774AbgGWMYx (ORCPT ); Thu, 23 Jul 2020 08:24:53 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3081CC0619DC for ; Thu, 23 Jul 2020 05:24:53 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id f1so4425687wro.2 for ; Thu, 23 Jul 2020 05:24:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ihdeGdGpgFkIzdF2x6is+yRXhsZbdmE+baPKtamOODg=; b=C/HEfOZW2bHfFxf2HJjaIioq8YJFxQfJM9vjgsFwFUdLzkpjL8rfbLAnxrBChpmPhI a0T+h39nKigPiDEkcIk7vlXAEYtuZNW5NHe6B5WJPVm95D9SOoezAGi9g2rMYu7DzLni vX4jEccc5FiYXFLwoDQmOCrrVyYb0n7g05Q1mJ8l8Y7u36bdMXBzTkYNheQJ/VjntmCC vVjkpHQlptkv0kJMiB8QUId2YOPfVUw91XTyYT0icpUhSoASPXCvwZcXaTJEPchLK0J3 FeRZQxmPx+atTDIjngKPD4MnFLwNA/NX0Och4/1FwVrMwkdWvJ69mBp6y/PLXg3kS2yX NnJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ihdeGdGpgFkIzdF2x6is+yRXhsZbdmE+baPKtamOODg=; b=mqd4vOsvvDLp8A2xhzhtP95T6Bkn6GHS4Ih91FBweyQn2PD0KOWHf8XU3TZiCg6FEl W9me0wRX1xJqNv0iydHhgJjTqzxRxIDV6FNgv1PM+SENnVTXPNpxR5UxXAvObUt46lvJ PxSEwYz7wUa5Ev0LTLqlCILBblRmoX+wT/dAEhtEBuQeLeatLh/d41cMXw5toZ0FbYqW 9R4LywXBZb332tkgT3m/ypZRmqihXVqnRU9MdVSIFMnCyePTDbznsHedlOMFoWTk1eIM YsuEBNdgpfKhrXVp4X5QDomHPynEVwMGSlxD6aWzgRUfIboBul7tZchZREtDSRNzJVNE La8w== X-Gm-Message-State: AOAM532wAEkyRylrBYhSYnEfLCGB1FX7+skgOVsYmXk6kOaGjQ/a3kMY /EuaJJlmOt5CFlD3Y9Io2ZbYU6nLN7s= X-Google-Smtp-Source: ABdhPJx/bi8f9Iyz4dlcIsq3N8F+lCeAvevX1AjO5UazBsvSxdcZAB5/UjE/vWFIW63WtnKDl3oLoQ== X-Received: by 2002:adf:cc85:: with SMTP id p5mr3755171wrj.273.1595507091857; Thu, 23 Jul 2020 05:24:51 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.24.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:24:51 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , James Smart , Dick Kennedy Subject: [PATCH 02/40] scsi: lpfc: lpfc_hbadisc: Fix kerneldoc parameter formatting/misnaming/missing issues Date: Thu, 23 Jul 2020 13:24:08 +0100 Message-Id: <20200723122446.1329773-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/lpfc/lpfc_hbadisc.c:1209: warning: Function parameter or member 'phba' not described in 'lpfc_sli4_clear_fcf_rr_bmask' drivers/scsi/lpfc/lpfc_hbadisc.c:1309: warning: Function parameter or member 'sw_name' not described in 'lpfc_sw_name_match' drivers/scsi/lpfc/lpfc_hbadisc.c:1309: warning: Excess function parameter 'fab_name' description in 'lpfc_sw_name_match' drivers/scsi/lpfc/lpfc_hbadisc.c:1397: warning: Function parameter or member 'fcf_rec' not described in 'lpfc_copy_fcf_record' drivers/scsi/lpfc/lpfc_hbadisc.c:1397: warning: Excess function parameter 'fcf' description in 'lpfc_copy_fcf_record' drivers/scsi/lpfc/lpfc_hbadisc.c:1956: warning: Cannot understand lpfc_sli4_fcf_record_match - testing new FCF record for matching existing FCF on line 1956 - I thought it was a doc line drivers/scsi/lpfc/lpfc_hbadisc.c:2078: warning: Function parameter or member 'fcf_index' not described in 'lpfc_sli4_fcf_pri_list_del' drivers/scsi/lpfc/lpfc_hbadisc.c:2109: warning: Function parameter or member 'fcf_index' not described in 'lpfc_sli4_set_fcf_flogi_fail' drivers/scsi/lpfc/lpfc_hbadisc.c:2135: warning: Function parameter or member 'fcf_index' not described in 'lpfc_sli4_fcf_pri_list_add' drivers/scsi/lpfc/lpfc_hbadisc.c:2135: warning: Function parameter or member 'new_fcf_record' not described in 'lpfc_sli4_fcf_pri_list_add' Cc: James Smart Cc: Dick Kennedy Signed-off-by: Lee Jones --- drivers/scsi/lpfc/lpfc_hbadisc.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c index 1713349cec4f5..142a021144793 100644 --- a/drivers/scsi/lpfc/lpfc_hbadisc.c +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c @@ -1198,7 +1198,7 @@ lpfc_mbx_cmpl_local_config_link(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb) /** * lpfc_sli4_clear_fcf_rr_bmask - * @phba pointer to the struct lpfc_hba for this port. + * @phba: pointer to the struct lpfc_hba for this port. * This fucnction resets the round robin bit mask and clears the * fcf priority list. The list deletions are done while holding the * hbalock. The ON_LIST flag and the FLOGI_FAILED flags are cleared @@ -1297,7 +1297,7 @@ lpfc_fab_name_match(uint8_t *fab_name, struct fcf_record *new_fcf_record) /** * lpfc_sw_name_match - Check if the fcf switch name match. - * @fab_name: pointer to fabric name. + * @sw_name: pointer to switch name. * @new_fcf_record: pointer to fcf record. * * This routine compare the fcf record's switch name with provided @@ -1385,7 +1385,7 @@ __lpfc_update_fcf_record_pri(struct lpfc_hba *phba, uint16_t fcf_index, /** * lpfc_copy_fcf_record - Copy fcf information to lpfc_hba. - * @fcf: pointer to driver fcf record. + * @fcf_rec: pointer to driver fcf record. * @new_fcf_record: pointer to fcf record. * * This routine copies the FCF information from the FCF @@ -1953,7 +1953,7 @@ lpfc_sli4_log_fcf_record_info(struct lpfc_hba *phba, } /** - lpfc_sli4_fcf_record_match - testing new FCF record for matching existing FCF + * lpfc_sli4_fcf_record_match - testing new FCF record for matching existing FCF * @phba: pointer to lpfc hba data structure. * @fcf_rec: pointer to an existing FCF record. * @new_fcf_record: pointer to a new FCF record. @@ -2067,7 +2067,7 @@ int lpfc_sli4_fcf_rr_next_proc(struct lpfc_vport *vport, uint16_t fcf_index) /** * lpfc_sli4_fcf_pri_list_del * @phba: pointer to lpfc hba data structure. - * @fcf_index the index of the fcf record to delete + * @fcf_index: the index of the fcf record to delete * This routine checks the on list flag of the fcf_index to be deleted. * If it is one the list then it is removed from the list, and the flag * is cleared. This routine grab the hbalock before removing the fcf @@ -2097,7 +2097,7 @@ static void lpfc_sli4_fcf_pri_list_del(struct lpfc_hba *phba, /** * lpfc_sli4_set_fcf_flogi_fail * @phba: pointer to lpfc hba data structure. - * @fcf_index the index of the fcf record to update + * @fcf_index: the index of the fcf record to update * This routine acquires the hbalock and then set the LPFC_FCF_FLOGI_FAILED * flag so the the round robin slection for the particular priority level * will try a different fcf record that does not have this bit set. @@ -2117,7 +2117,8 @@ lpfc_sli4_set_fcf_flogi_fail(struct lpfc_hba *phba, uint16_t fcf_index) /** * lpfc_sli4_fcf_pri_list_add * @phba: pointer to lpfc hba data structure. - * @fcf_index the index of the fcf record to add + * @fcf_index: the index of the fcf record to add + * @new_fcf_record: pointer to a new FCF record. * This routine checks the priority of the fcf_index to be added. * If it is a lower priority than the current head of the fcf_pri list * then it is added to the list in the right order. From patchwork Thu Jul 23 12:24:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680861 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AFD2813A4 for ; Thu, 23 Jul 2020 12:27:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 962C820888 for ; Thu, 23 Jul 2020 12:27:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="r6ge4Ti8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728820AbgGWMY5 (ORCPT ); Thu, 23 Jul 2020 08:24:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728794AbgGWMYy (ORCPT ); Thu, 23 Jul 2020 08:24:54 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C545C0619E3 for ; Thu, 23 Jul 2020 05:24:54 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id f2so4964370wrp.7 for ; Thu, 23 Jul 2020 05:24:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w5l35wuUCv0+znhq/VnSUhgz/EG/YdhUiwAApvAIamk=; b=r6ge4Ti8+kXThHu3tpFrY2Ryo0k3bAW1ptY+IUg7BKnhP9feLqbB4Ki0VPkdi4Rfvh qiERb1MCbRVWRbqpr7Li7FdfNx7sNXcrZZKQ+ZYrZN9Q/wXNqcAOCgwy/xPcjVmHEwHS SjZDEHqnvq2ZirIeFiV8qz605QE95ZmTRcZHXYEmR8UknIZC1GxppBcSd1EAo+bXchNf p5TCHVosIiUnxOj1mPS2h0O9qK7hcFZu1MdueLtyLnnPUdd0Ld1xbJoIGkcmxW8osJbq OsFQnujym60qi7zEglAXs6H9nCYvCE7quvmqEBO9TWEnoz0xOy8mjr/cKra0Rcz4LUXV Mb/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w5l35wuUCv0+znhq/VnSUhgz/EG/YdhUiwAApvAIamk=; b=hDyyy2+yy3FY1w42QGJFZ280mmk7QEATCOpnOm0Kb5KHnJb3mMI+2cMGl0xUCprkPr PGf+5zlp1lx3T7H2be6S9LziIoqv7C57fXb1ngWX9PidSrxhCD5YcWDS3z6RFeJE5w/V d/ehT0HweJyOc9dvCAOPOTzCS1uKG3k0YIShK3wgxpZ9xrEqkj1xAMzsjBBIXAeopDms 3oDXSsUkuukNUothISYc9bezuAORWlLre37KDxSlpkH3LD6Ga79zBpJtXvSfYE2bvspX g2eRWCQFHz+DWAbngFsDSzfHu+Vp8Xgy+RaR0P6aDyFG3jQOHenflIr24WGT7tmmKIyj Y6Qw== X-Gm-Message-State: AOAM533uid5zTjeFp3HGSwlcBT9b7F9bLGq4g9uiLZ0gqxhu+WRCI8rM Tqb1TJ7ybmndCZZ5rIe7FFtZUQ== X-Google-Smtp-Source: ABdhPJw7cFW8uyR4m7st3tXI308gCTAkeFzpp+TnCDHQ3/qHkQMnoiCpCil6wZfPRUOhm/y+04iOjQ== X-Received: by 2002:a5d:6248:: with SMTP id m8mr181272wrv.317.1595507093339; Thu, 23 Jul 2020 05:24:53 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.24.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:24:52 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Andy Gross , Bjorn Andersson , Alim Akhtar , Avri Altman , Philipp Zabel , linux-arm-msm@vger.kernel.org Subject: [PATCH 03/40] scsi: ufs: ufs-qcom: Demote nonconformant kerneldoc headers Date: Thu, 23 Jul 2020 13:24:09 +0100 Message-Id: <20200723122446.1329773-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/ufs/ufs-qcom.c:253: warning: Function parameter or member 'hba' not described in 'ufs_qcom_host_reset' drivers/scsi/ufs/ufs-qcom.c:383: warning: Function parameter or member 'hba' not described in 'ufs_qcom_cfg_timers' drivers/scsi/ufs/ufs-qcom.c:383: warning: Function parameter or member 'gear' not described in 'ufs_qcom_cfg_timers' drivers/scsi/ufs/ufs-qcom.c:383: warning: Function parameter or member 'hs' not described in 'ufs_qcom_cfg_timers' drivers/scsi/ufs/ufs-qcom.c:383: warning: Function parameter or member 'rate' not described in 'ufs_qcom_cfg_timers' drivers/scsi/ufs/ufs-qcom.c:383: warning: Function parameter or member 'update_link_startup_timer' not described in 'ufs_qcom_cfg_timers' drivers/scsi/ufs/ufs-qcom.c:1738: error: Cannot parse struct or union! Cc: Andy Gross Cc: Bjorn Andersson Cc: Alim Akhtar Cc: Avri Altman Cc: Philipp Zabel Cc: linux-arm-msm@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/ufs/ufs-qcom.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c index 139c3ae05e956..d0d75527830e9 100644 --- a/drivers/scsi/ufs/ufs-qcom.c +++ b/drivers/scsi/ufs/ufs-qcom.c @@ -246,7 +246,7 @@ static void ufs_qcom_select_unipro_mode(struct ufs_qcom_host *host) mb(); } -/** +/* * ufs_qcom_host_reset - reset host controller and PHY */ static int ufs_qcom_host_reset(struct ufs_hba *hba) @@ -375,7 +375,7 @@ static int ufs_qcom_hce_enable_notify(struct ufs_hba *hba, return err; } -/** +/* * Returns zero for success and non-zero in case of a failure */ static int ufs_qcom_cfg_timers(struct ufs_hba *hba, u32 gear, @@ -1723,7 +1723,7 @@ static void ufs_qcom_config_scaling_param(struct ufs_hba *hba, } #endif -/** +/* * struct ufs_hba_qcom_vops - UFS QCOM specific variant operations * * The variant operations configure the necessary controller and PHY From patchwork Thu Jul 23 12:24:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680785 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1132F13A4 for ; Thu, 23 Jul 2020 12:24:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECEC320792 for ; Thu, 23 Jul 2020 12:24:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Qy0EsRHg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728828AbgGWMY5 (ORCPT ); Thu, 23 Jul 2020 08:24:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728824AbgGWMY4 (ORCPT ); Thu, 23 Jul 2020 08:24:56 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E231CC0619E2 for ; Thu, 23 Jul 2020 05:24:55 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id f1so4425834wro.2 for ; Thu, 23 Jul 2020 05:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7dnMCO3O7GWoEhpbi22iSF6SZebDl2BeuDMdc7cp9fI=; b=Qy0EsRHgGsQAG/Sjohwyb0UEINUjI26GTuGt0maBG/rSohVeuyGgXngFFOxD+uDcc9 JpUn/jP6ivol2esKfmNSeEMEbPDORThVBi6ZKA2DE1zm/mvjL3MYceytPPf9asN/ZsBt md9wB/BQrFkmcZh7pRodZLkBY80Vgl9dvoQCJa/h66Ug+75oTzYeZkPPcfUEirU1YkqR KFyGEC59BcksYRSYONQPHiW7dPaiMxEKHSphQ1yymwqvv5CsSGpfy2vBWi9bwncRoZsV IzCRABJPY/jfBK0N5GAfoTqF0I+RxdsRuU8uHwucusH1A5f+NUonnZor48KRQE0fDcWq A7WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7dnMCO3O7GWoEhpbi22iSF6SZebDl2BeuDMdc7cp9fI=; b=XaNTbAt1zA2g57YMQIrH172yg3QkZP0EZsVCaMThLgsvMUKQ/AofyI5Y2ifme14Opi nHrzXjYU8+DDLV2mtV3oCYwZVcDTEBUW2Ip/59i9pV4sdmdzF1HR96eKUCE/P+XK13mp +7FSIVpxa2ioxyfi6d5RV6dwILRMSHSV7U8kcwnbwU5VCMY6Ysy9HmwFrgGIxoJ+HS/D 072QtipI21OwS9sMf2elU3zS3nUOEMKxyfM1/UdfTPVpUbHym2JCxG99QQtlih0PA3bE Y+vXsijm7oKrEELnTWCqRx8wcLjc37tMQsyjtm47zpJ9aym3LZDC0Y8zwjU0/EUrNzt5 qFag== X-Gm-Message-State: AOAM533d7lv6nVgIv4EmnZfzLUTq89cY4gU39d6ysRNycfrb5UEYd5ud 0XKIJcJDksPuuZwcIFzBtu55jg== X-Google-Smtp-Source: ABdhPJxvJtb9jfW8iP6bc5G3PPp6fA3LbXTfHuuM3/YmpiAPWdEPQQh60ILfJ1qd8H/5g1F7ndgHxw== X-Received: by 2002:adf:8b1a:: with SMTP id n26mr4102997wra.182.1595507094598; Thu, 23 Jul 2020 05:24:54 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.24.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:24:53 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@qlogic.com, Anil Veerabhadrappa , Eddie Wai Subject: [PATCH 04/40] scsi: bnx2i: bnx2i_init: Fix parameter misnaming in function header Date: Thu, 23 Jul 2020 13:24:10 +0100 Message-Id: <20200723122446.1329773-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/bnx2i/bnx2i_init.c:83: warning: Function parameter or member 'dev' not described in 'bnx2i_identify_device' drivers/scsi/bnx2i/bnx2i_init.c:83: warning: Excess function parameter 'cnic' description in 'bnx2i_identify_device' Cc: QLogic-Storage-Upstream@qlogic.com Cc: Anil Veerabhadrappa Cc: Eddie Wai Signed-off-by: Lee Jones --- drivers/scsi/bnx2i/bnx2i_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c index 4ebcda8d95004..6018cdd177022 100644 --- a/drivers/scsi/bnx2i/bnx2i_init.c +++ b/drivers/scsi/bnx2i/bnx2i_init.c @@ -73,7 +73,7 @@ DEFINE_PER_CPU(struct bnx2i_percpu_s, bnx2i_percpu); /** * bnx2i_identify_device - identifies NetXtreme II device type * @hba: Adapter structure pointer - * @cnic: Corresponding cnic device + * @dev: Corresponding cnic device * * This function identifies the NX2 device type and sets appropriate * queue mailbox register access method, 5709 requires driver to From patchwork Thu Jul 23 12:24:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680859 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2507F13A4 for ; Thu, 23 Jul 2020 12:27:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DAFC20888 for ; Thu, 23 Jul 2020 12:27:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VLzuVAzw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728858AbgGWMY6 (ORCPT ); Thu, 23 Jul 2020 08:24:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728846AbgGWMY5 (ORCPT ); Thu, 23 Jul 2020 08:24:57 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DB40C0619DC for ; Thu, 23 Jul 2020 05:24:57 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id f18so4996085wrs.0 for ; Thu, 23 Jul 2020 05:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mCXO0Gr/A00l7Lne4sBK8Frz9I2gxXn2t7va3NQnE+k=; b=VLzuVAzwLVM/dZrwghui32Cthrp/jLIjGRFYoekwj6rOfYdWN+Ca8euH5j0gmIclVA DPGAmw1kGbUVZEsPzHiJS4mVA4nIS/w0UhXhvtODtvdzRx0u3R/sEMZwyCzDADT/E9iu vLDxEbeoH+2JdqhS/3o/A9XdzqzYaakIGrL8NYVb3/bFEM+CIqVptPUaom3/SoHEeGNy sLA228efpCsVu2LU5uwYHYJjtRMQQlQyjtUkunjK29dLPWUIqm6go4LnmxMhmQcTNcuN K+Bn4hm1c0VKWz+h46vh5QR8aI/QuPomXCz/us8WLkqhjS4TOlcTzxWt1lj0K1kR4iqs V2tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mCXO0Gr/A00l7Lne4sBK8Frz9I2gxXn2t7va3NQnE+k=; b=l9/71BVbeOgCageOYcPCLZmyVSfaeHshdhgSQAVQWwS/Lz/T68/o6nsRZ38NPoYtQ8 WzKvaIHMLE8YA44xocAgSXaHa6+PwVccGdxptm6TDF8y6CF1Ruz32UwUpDXxxCaH13UC /aoxmkY/eiSZs9iH+q6bUAe9X+p/Z5kuTCwYdpHnzVzLpnEFQ+4mXizsrxKIMON0YkuR xXVGkGhJYt9+SaBDBEf0kMLBVbDoTeRvSwHuFQ9i+6PZz6l3O5aIBaKfAc6MVcr50tfM MVlS+PvjQGvLSU1UlDRv8j6S7eT5BgG5gXcIquLTMIenWoGjPph7YYsWccWWJy2JtHPD VQZw== X-Gm-Message-State: AOAM5322ngDdQ7nSMkoOw8zNcWWPei1OJxHLepFDaoFDYF4K/W2F+9Sd sFs9kH2bC2xiG4cHEm0s3JQSbA== X-Google-Smtp-Source: ABdhPJyHdbt4arhYy1wxPK9DL4Wp99G0wUnJEmOEIFHYKnmyhpXMeS1JDOviOFALkqZ19VIiGO62Sw== X-Received: by 2002:adf:cf0c:: with SMTP id o12mr3829930wrj.265.1595507095851; Thu, 23 Jul 2020 05:24:55 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.24.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:24:55 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Alim Akhtar , Avri Altman , Kukjin Kim , Krzysztof Kozlowski , Kiwoong Kim , linux-samsung-soc@vger.kernel.org Subject: [PATCH 05/40] scsi: ufs: ufs-exynos: Make stubs 'static inline' Date: Thu, 23 Jul 2020 13:24:11 +0100 Message-Id: <20200723122446.1329773-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Else the compiler complains of missing prototypes. Fixes the following W=1 kernel build warning(s): In file included from drivers/scsi/ufs/ufs-exynos.c:23: drivers/scsi/ufs/ufs-exynos.h:302:6: warning: no previous prototype for ‘exynos_ufs_cmd_log_start’ [-Wmissing-prototypes] 302 | void exynos_ufs_cmd_log_start(struct ufs_exynos_handle *handle, | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/ufs/ufs-exynos.h:307:6: warning: no previous prototype for ‘exynos_ufs_cmd_log_end’ [-Wmissing-prototypes] 307 | void exynos_ufs_cmd_log_end(struct ufs_exynos_handle *handle, | ^~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/ufs/ufs-exynos.h:312:5: warning: no previous prototype for ‘exynos_ufs_init_dbg’ [-Wmissing-prototypes] 312 | int exynos_ufs_init_dbg(struct ufs_exynos_handle *handle, struct device *dev) | ^~~~~~~~~~~~~~~~~~~ drivers/scsi/ufs/ufs-exynos.h:317:6: warning: no previous prototype for ‘exynos_ufs_dump_info’ [-Wmissing-prototypes] 317 | void exynos_ufs_dump_info(struct ufs_exynos_handle *handle, struct device *dev) | ^~~~~~~~~~~~~~~~~~~~ Cc: Alim Akhtar Cc: Avri Altman Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: Kiwoong Kim Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/ufs/ufs-exynos.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/ufs/ufs-exynos.h b/drivers/scsi/ufs/ufs-exynos.h index d86d0a0f74780..0908283a76936 100644 --- a/drivers/scsi/ufs/ufs-exynos.h +++ b/drivers/scsi/ufs/ufs-exynos.h @@ -299,22 +299,22 @@ void exynos_ufs_cmd_log_end(struct ufs_exynos_handle *handle, int exynos_ufs_init_dbg(struct ufs_exynos_handle *handle, struct device *dev); void exynos_ufs_dump_info(struct ufs_exynos_handle *handle, struct device *dev); #else -void exynos_ufs_cmd_log_start(struct ufs_exynos_handle *handle, - struct ufs_hba *hba, int tag) +static inline void exynos_ufs_cmd_log_start(struct ufs_exynos_handle *handle, + struct ufs_hba *hba, int tag) { } -void exynos_ufs_cmd_log_end(struct ufs_exynos_handle *handle, - struct ufs_hba *hba, int tag) +static inline void exynos_ufs_cmd_log_end(struct ufs_exynos_handle *handle, + struct ufs_hba *hba, int tag) { } -int exynos_ufs_init_dbg(struct ufs_exynos_handle *handle, struct device *dev) +static inline int exynos_ufs_init_dbg(struct ufs_exynos_handle *handle, struct device *dev) { return 0; } -void exynos_ufs_dump_info(struct ufs_exynos_handle *handle, struct device *dev) +static inline void exynos_ufs_dump_info(struct ufs_exynos_handle *handle, struct device *dev) { } From patchwork Thu Jul 23 12:24:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680855 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 01BB213A4 for ; Thu, 23 Jul 2020 12:27:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD88B20888 for ; Thu, 23 Jul 2020 12:27:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TEW85Fn3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728872AbgGWMY7 (ORCPT ); Thu, 23 Jul 2020 08:24:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728865AbgGWMY6 (ORCPT ); Thu, 23 Jul 2020 08:24:58 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58293C0619E3 for ; Thu, 23 Jul 2020 05:24:58 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id a6so6396030wmm.0 for ; Thu, 23 Jul 2020 05:24:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iSQMgw7xYhZP3UZf5+lasa+UwlT/7rt+vW8/trm4LDo=; b=TEW85Fn3KvlR1/ox+9FOgeQrHl+00ZEyopmW1JEMK9KRKelWc5NrGfaJxN3lqQocjt /+ShTwf5bTX2B+t6pqrYrI0KFMv9Dy23MZNTSixscwlbOkK3Ho1pyXLoFWHN2C+ljKrq b88pJwHa3bXMFQivxA9BDoKSj78A328Fg4ZDi4/iXLEOi7kBWi31zoh1V9xLfyCXG4dZ ikvg9Gybxxno9+ZFPsTJsZxt8wucOKmp51JMFPFHcTNOlIxGRxLbe+aSTfm78e+cFxCK aRAMxjv/PwVmKYVTywGo+sOkMNKX0GngEhlkJgd6OCBvWN5t7Enh9PZTm+CaZezzer93 veOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iSQMgw7xYhZP3UZf5+lasa+UwlT/7rt+vW8/trm4LDo=; b=VA81j64ohCvvQKvjTwVxHR7+2XpxBtIvJ22w3EzuAmVqXUx7VPkCfF1rW2IN2rCoFb WlOav+FJpvKIUvc3x0ngUe2iN19EpN5eyrux/bxvARTjDO1yNjK+/hXLvY5/ZR8cWiA+ cvTz4j3AsgLbyw2ZijROwGG3ozDrFppV59MGmSM7cYNU+NAsaRYj86AZDC9xi4mb+XNX xZMPkfereb4Pt3iH4HkFoaV/dqMBfizeKKC7eFkQUO6BwsAaVgDQmuGMZ4gXRaAucF+B byrUVFx3HkroYfdnK3wk8cAo7aNSyqI5tnA1QFrSrs+Y+4G9rfST6+vK2eZnONfxIsN2 Ohkw== X-Gm-Message-State: AOAM533SMyMBjOnredXorC+ClAIfrOM2ILis1POK8bV5gyZCqoYxCd64 rzozbELIplT9mNavuLrZNhXZWA== X-Google-Smtp-Source: ABdhPJx+PZHTVIJ+E7nFbXTBN0DlXtTyzH9UQgfnehGYyyVKdjsGVbuV9soY3017Ateok39CNTwCIw== X-Received: by 2002:a1c:7719:: with SMTP id t25mr4164471wmi.144.1595507097059; Thu, 23 Jul 2020 05:24:57 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.24.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:24:56 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Alim Akhtar , Avri Altman , Kukjin Kim , Krzysztof Kozlowski , Seungwon Jeon , linux-samsung-soc@vger.kernel.org Subject: [PATCH 06/40] scsi: ufs: ufs-exynos: Demote seemingly unintentional kerneldoc header Date: Thu, 23 Jul 2020 13:24:12 +0100 Message-Id: <20200723122446.1329773-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org This is the only use of kerneldoc in the source file and no descriptions are provided. Fixes the following W=1 kernel build warning(s): In file included from drivers/scsi/ufs/ufs-exynos.c:23: drivers/scsi/ufs/ufs-exynos.c:234: warning: Function parameter or member 'ufs' not described in 'exynos_ufs_auto_ctrl_hcc' drivers/scsi/ufs/ufs-exynos.c:234: warning: Function parameter or member 'en' not described in 'exynos_ufs_auto_ctrl_hcc' Cc: Alim Akhtar Cc: Avri Altman Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: Seungwon Jeon Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/ufs/ufs-exynos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufs-exynos.c b/drivers/scsi/ufs/ufs-exynos.c index 3c0a50b7e3560..9151c7455acda 100644 --- a/drivers/scsi/ufs/ufs-exynos.c +++ b/drivers/scsi/ufs/ufs-exynos.c @@ -224,7 +224,7 @@ static int exynos7_ufs_post_pwr_change(struct exynos_ufs *ufs, return 0; } -/** +/* * exynos_ufs_auto_ctrl_hcc - HCI core clock control by h/w * Control should be disabled in the below cases * - Before host controller S/W reset From patchwork Thu Jul 23 12:24:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680853 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 104B413B4 for ; Thu, 23 Jul 2020 12:27:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA9342086A for ; Thu, 23 Jul 2020 12:27:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xaBW4zXU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728946AbgGWM1d (ORCPT ); Thu, 23 Jul 2020 08:27:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728874AbgGWMY7 (ORCPT ); Thu, 23 Jul 2020 08:24:59 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CC9FC0619DC for ; Thu, 23 Jul 2020 05:24:59 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id f2so4964622wrp.7 for ; Thu, 23 Jul 2020 05:24:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=80v1DBRW/qsu59LvyeMIeuQFI8l1Hk1nu3w4AijohsI=; b=xaBW4zXUzVy6HWSnFb8niReGfzTgkh/3kLRCus5uoYeWHhRGske4Gp63MyS/UpkOHr psb63W7tbz5Y4zOZD89k51FPGLkAaRW563Uayx4efO7OrzyZf/0G5CAL/LdlOpGNvUiI c7K6A6r3Nu+hwe7BJCJ21MZvB1Bcu7KJNPQzZqTHinItMf6ooHtSuANOGHy99tSDOlBA CwAVQJ5DJ9eNb4lyARBB3mNT2C+ZiTIJXgd0vxfit4c7uzWNEejenJAzHvRSr1sC77rh kDF8VKXBJ/LbcIn3jDun8mS2RKYuk2C7xGAB7f7byAhsRtYuX9ok27Oj+H3v47XO4lcS Dogw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=80v1DBRW/qsu59LvyeMIeuQFI8l1Hk1nu3w4AijohsI=; b=DFxYwJeS6m8mxGdFl3MX+DA5EP1X25VzAJ/7LvliA8Cp2JMYvG4LWqAvv1DIj2CouG 1OzlzYCXK0sUVuaWdubOi7ZF7WqQYy91YcChMoIGGOsP550htmVzcWn9Fc66BYL/xE2C J3WrD2CMCVEqH/zonGe2A1HZ2i4EwyzsN4kQHMxQkYsJAh/nwOIz6nz4Dh7P/I0VbSmp AtSFcuc8Kb85Vii+Cy/Wn7eYW8vQztwvM15imkiBIskgrFKwJLisO+jUqrjeKc835V8u HNR208Hlqu10Ldmd0u0k56bMARd53kysU1fnFA70CDFcdo68h4Vy01gIJGTfB5Agrl+r n9Ug== X-Gm-Message-State: AOAM530o+2M0LtdqGiYy9dg5BJwiyGPJ7ebBvq7w6LKr8qHXgJI1CB9s VIvYzJ+6PQPf5DNpHG9KRCbj0Q== X-Google-Smtp-Source: ABdhPJzKG1wmpdPfaLhJeYXeq9QB31CvRZqPSXRE5D6MdiQRM6Z5f3c5+XeahU4Q+ztWHyM9SxlqWA== X-Received: by 2002:adf:ec8b:: with SMTP id z11mr3735247wrn.51.1595507098335; Thu, 23 Jul 2020 05:24:58 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.24.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:24:57 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Anil Gurumurthy , Sudarsana Kalluru Subject: [PATCH 07/40] scsi: bfa: bfa_port: Staticify local functions Date: Thu, 23 Jul 2020 13:24:13 +0100 Message-Id: <20200723122446.1329773-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org These calls are not invoked externally. Fixes the following W=1 kernel build warning(s): drivers/scsi/bfa/bfa_port.c:760:1: warning: no previous prototype for ‘bfa_cee_isr’ [-Wmissing-prototypes] 760 | bfa_cee_isr(void *cbarg, struct bfi_mbmsg_s *m) | ^~~~~~~~~~~ drivers/scsi/bfa/bfa_port.c:796:1: warning: no previous prototype for ‘bfa_cee_notify’ [-Wmissing-prototypes] 796 | bfa_cee_notify(void *arg, enum bfa_ioc_event_e event) | ^~~~~~~~~~~~~~ Cc: Anil Gurumurthy Cc: Sudarsana Kalluru Signed-off-by: Lee Jones --- drivers/scsi/bfa/bfa_port.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/bfa/bfa_port.c b/drivers/scsi/bfa/bfa_port.c index 4511ec865f06a..cfe2c9c336bfd 100644 --- a/drivers/scsi/bfa/bfa_port.c +++ b/drivers/scsi/bfa/bfa_port.c @@ -756,7 +756,7 @@ bfa_cee_reset_stats(struct bfa_cee_s *cee, * @return void */ -void +static void bfa_cee_isr(void *cbarg, struct bfi_mbmsg_s *m) { union bfi_cee_i2h_msg_u *msg; @@ -792,7 +792,7 @@ bfa_cee_isr(void *cbarg, struct bfi_mbmsg_s *m) * @return void */ -void +static void bfa_cee_notify(void *arg, enum bfa_ioc_event_e event) { struct bfa_cee_s *cee = (struct bfa_cee_s *) arg; From patchwork Thu Jul 23 12:24:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680851 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id ECDBB13A4 for ; Thu, 23 Jul 2020 12:27:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5BF822BEF for ; Thu, 23 Jul 2020 12:27:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BB8oAg6w" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729369AbgGWM12 (ORCPT ); Thu, 23 Jul 2020 08:27:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728888AbgGWMZB (ORCPT ); Thu, 23 Jul 2020 08:25:01 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6CFCC0619DC for ; Thu, 23 Jul 2020 05:25:00 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id 88so4977414wrh.3 for ; Thu, 23 Jul 2020 05:25:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OWikrHcjIEL13jknWWaUiCgmVBPYjsVQNgOhFstQ6kk=; b=BB8oAg6wAh/txP2Zw6XlLsdMIMjiFCw3n8QNnz+5qnf/iAGYJvKlY8VFgS75Q/OPnW 0lhnnWlp8LgvU4zRh+u6mSS8gdNbN/fCyK6UC8LFWS7mC8bAJQ90U4rhEUTHLZr37zWY 0LQ7Es10351jkZU5W0m83pqKwZU8zj6e56ek1R76wpC9wa8HJAvrtfwDKeVOnnpTxNXz HOVQ8iAivYVb0FCcO0xMuA1T1bWbgrn4SuB2fqgWspRAVWfknGcxyy8wcH8zCM4XzHbk jxQfWwJXpOcAnH04XdrVg2G7KnMLip7J+DCE7A6Mutm9VOZ6qWqcdEd9957uDxpVIqGn AtAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OWikrHcjIEL13jknWWaUiCgmVBPYjsVQNgOhFstQ6kk=; b=f72zkOSCwCGn6NuGBc7dr6nMO7DF1fyOjwqsNN/P8E4lR/T3EsmHEtwR9uTt+AIt9T 9250leGG3SzZyvwLcpab4I0h5xjs6SaJXdxNYmcJMpQD4x9RYO3yFs/1xhpQzAG3B0Ts XkhQHs86fjVk07KrHqmo8UITrkJgXm0HPWJc8dZWP5q5A86xYXOnBhaTWzV/PaH1DDAR GV8a6+dPfKvIxSjCgT/4vAZ2GaOlTefdKLETTnTSp+owQg2pNx/ODva35ndmhjv/VFII /u9bInYzGUaSZ6wub+yTlgpdB6DyfdCPMam1S7jJCN5PjtnCIfX+1oJCFIhdn/l8O8ax NOMg== X-Gm-Message-State: AOAM532A57CzTGWzYHHYyLa12S643CO8X2bfkDQkk28mQMqwZWcuw3ED XEQ/8J3FqlSU/MwS378dZq+tgg== X-Google-Smtp-Source: ABdhPJxhEY7+qPHjPhuX5V9UXTKocEiF3ZgSgjLNy48r0c8fWe4GAkvPRAdVDSpqXvIYiB7pHa/2iw== X-Received: by 2002:adf:b34a:: with SMTP id k10mr3801954wrd.402.1595507099540; Thu, 23 Jul 2020 05:24:59 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.24.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:24:58 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@qlogic.com, Anil Veerabhadrappa , Eddie Wai Subject: [PATCH 08/40] scsi: bnx2i: bnx2i_sysfs: Add missing descriptions for 'attr' parameter Date: Thu, 23 Jul 2020 13:24:14 +0100 Message-Id: <20200723122446.1329773-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/bnx2i/bnx2i_sysfs.c:40: warning: Function parameter or member 'attr' not described in 'bnx2i_show_sq_info' drivers/scsi/bnx2i/bnx2i_sysfs.c:60: warning: Function parameter or member 'attr' not described in 'bnx2i_set_sq_info' drivers/scsi/bnx2i/bnx2i_sysfs.c:96: warning: Function parameter or member 'attr' not described in 'bnx2i_show_ccell_info' drivers/scsi/bnx2i/bnx2i_sysfs.c:114: warning: Function parameter or member 'attr' not described in 'bnx2i_set_ccell_info' Cc: QLogic-Storage-Upstream@qlogic.com Cc: Anil Veerabhadrappa Cc: Eddie Wai Signed-off-by: Lee Jones --- drivers/scsi/bnx2i/bnx2i_sysfs.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/bnx2i/bnx2i_sysfs.c b/drivers/scsi/bnx2i/bnx2i_sysfs.c index 6d56fd60cb2b2..3dc790089f0fc 100644 --- a/drivers/scsi/bnx2i/bnx2i_sysfs.c +++ b/drivers/scsi/bnx2i/bnx2i_sysfs.c @@ -30,6 +30,7 @@ static inline struct bnx2i_hba *bnx2i_dev_to_hba(struct device *dev) /** * bnx2i_show_sq_info - return(s currently configured send queue (SQ) size * @dev: device pointer + * @attr: device attribute (unused) * @buf: buffer to return current SQ size parameter * * Returns current SQ size parameter, this paramater determines the number @@ -47,6 +48,7 @@ static ssize_t bnx2i_show_sq_info(struct device *dev, /** * bnx2i_set_sq_info - update send queue (SQ) size parameter * @dev: device pointer + * @attr: device attribute (unused) * @buf: buffer to return current SQ size parameter * @count: parameter buffer size * @@ -87,6 +89,7 @@ static ssize_t bnx2i_set_sq_info(struct device *dev, /** * bnx2i_show_ccell_info - returns command cell (HQ) size * @dev: device pointer + * @attr: device attribute (unused) * @buf: buffer to return current SQ size parameter * * returns per-connection TCP history queue size parameter @@ -103,6 +106,7 @@ static ssize_t bnx2i_show_ccell_info(struct device *dev, /** * bnx2i_get_link_state - set command cell (HQ) size * @dev: device pointer + * @attr: device attribute (unused) * @buf: buffer to return current SQ size parameter * @count: parameter buffer size * From patchwork Thu Jul 23 12:24:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680787 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BA63C13A4 for ; Thu, 23 Jul 2020 12:25:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A167122B49 for ; Thu, 23 Jul 2020 12:25:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WubRW/8f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728904AbgGWMZE (ORCPT ); Thu, 23 Jul 2020 08:25:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728891AbgGWMZC (ORCPT ); Thu, 23 Jul 2020 08:25:02 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3AB6C0619E3 for ; Thu, 23 Jul 2020 05:25:01 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id a15so4961517wrh.10 for ; Thu, 23 Jul 2020 05:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yvmlSuND1dq+URT3Mh7aUGf3QKAqUJVZgTZGCZzRwW8=; b=WubRW/8fEDabiHlW0cMuIotrK98GcRuRKeWXglkuhpZe1tWedsUHyPTVTojGFSz8Dq 4saNu5qFOJVYnGfac5jVqjNGExz90ry3yTMabTVw/4WqWEzM6DzYrvYwaPhrEjfFbSBN oNrHXQnkSnJXTl7FY92M9bJ7o/+bavhe2EFmLWxyo8SUf2tU06D9TaEQUX8w4DrpDUl1 IN+ZpwmHQv+ZKVTfF0hC0nGYQ8XfBb7XCtZruHZdB37PTxgQC3hr1v5PasojgxGem+qf efl9/HvVw7lP8AT1bCoZdB+zJ0XH6lJC8i77HDg4pdmdofQA26UdgwUkHe8Lhd+NhSds 7p3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yvmlSuND1dq+URT3Mh7aUGf3QKAqUJVZgTZGCZzRwW8=; b=AdzMIkJAMYD+qGXrHg6PX4zWbGp6Qpf2OMiurACCC/UcniOYsNJu5nMs2n/vriDZtT i/Zko7DV2i35HtE1oM89fGB3NOS8Xfxi7ROW6UQE5+Q8TFz6ohtKga5COIQM8UxpTBGM 83URYso5gXjWqzdXfl4dtx5jgNQzv8+is/ZVLi2s5Wd01f9ptZlPArqHYwUZPtw9Ap3J VkChbkQmAjX3gshZHNQeI5r1LzTrSz1+xFJn1LbNVhNy3k7ITvslb7XeCLK7O6JnduVw 7Nyx5XmPoLPMS0MnGFT7i2AY4+HLzdQNzCah19gsoJjwQO4kZeHyJQEUulx7azZI0Fvt DG+w== X-Gm-Message-State: AOAM53391CkwWdXtOlAIN+AMd2aiZ4MFE163PhW4B7jYyh3/Eei69sHS aBLAK4Gl+SZ0CZUyI2kTiB8mVQ== X-Google-Smtp-Source: ABdhPJw3N7qcgpT6gajm5zonS2WuFVPLLqmli/V8c2MvjY9t7JgOZnqCzEswBphKqc91FCQWVqoW+A== X-Received: by 2002:a5d:4bc8:: with SMTP id l8mr3786426wrt.159.1595507100629; Thu, 23 Jul 2020 05:25:00 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:00 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Anil Gurumurthy , Sudarsana Kalluru Subject: [PATCH 09/40] scsi: bfa: bfa_fcpim: Remove set but unused variable 'rp' Date: Thu, 23 Jul 2020 13:24:15 +0100 Message-Id: <20200723122446.1329773-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org This change subsequently makes 'rp_fcs' unused also. Remove that too. Fixes the following W=1 kernel build warning(s): drivers/scsi/bfa/bfa_fcpim.c: In function ‘bfa_fcpim_lunmask_delete’: drivers/scsi/bfa/bfa_fcpim.c:2338:22: warning: variable ‘rp’ set but not used [-Wunused-but-set-variable] 2338 | struct bfa_rport_s *rp = NULL; | ^~ Cc: Anil Gurumurthy Cc: Sudarsana Kalluru Signed-off-by: Lee Jones --- drivers/scsi/bfa/bfa_fcpim.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/scsi/bfa/bfa_fcpim.c b/drivers/scsi/bfa/bfa_fcpim.c index 766f2b5ed2ab4..f6bf24084a47a 100644 --- a/drivers/scsi/bfa/bfa_fcpim.c +++ b/drivers/scsi/bfa/bfa_fcpim.c @@ -2335,9 +2335,7 @@ bfa_fcpim_lunmask_delete(struct bfa_s *bfa, u16 vf_id, wwn_t *pwwn, wwn_t rpwwn, struct scsi_lun lun) { struct bfa_lun_mask_s *lunm_list; - struct bfa_rport_s *rp = NULL; struct bfa_fcs_lport_s *port = NULL; - struct bfa_fcs_rport_s *rp_fcs; int i; /* in min cfg lunm_list could be NULL but no commands should run. */ @@ -2353,12 +2351,8 @@ bfa_fcpim_lunmask_delete(struct bfa_s *bfa, u16 vf_id, wwn_t *pwwn, port = bfa_fcs_lookup_port( &((struct bfad_s *)bfa->bfad)->bfa_fcs, vf_id, *pwwn); - if (port) { + if (port) *pwwn = port->port_cfg.pwwn; - rp_fcs = bfa_fcs_lport_get_rport_by_pwwn(port, rpwwn); - if (rp_fcs) - rp = rp_fcs->bfa_rport; - } } lunm_list = bfa_get_lun_mask_list(bfa); From patchwork Thu Jul 23 12:24:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680789 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4228414E3 for ; Thu, 23 Jul 2020 12:25:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 271F622B47 for ; Thu, 23 Jul 2020 12:25:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="m9JWVP+m" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728911AbgGWMZE (ORCPT ); Thu, 23 Jul 2020 08:25:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728898AbgGWMZD (ORCPT ); Thu, 23 Jul 2020 08:25:03 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E36CEC0619DC for ; Thu, 23 Jul 2020 05:25:02 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id f139so4997922wmf.5 for ; Thu, 23 Jul 2020 05:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RyWxawKp9Typ2OK2kYwM9lNUQGGOHxUK9uVUiznh4iw=; b=m9JWVP+mBsEvLIFtV/f+vnUB7TStzaLFXhdln3XW9MyO5nMKj0mhqVrEsOr3/72ZOg D/gGVJfmAT1LBe8gluCI9Rj5JyMXIy/ch7m3aFLuSg8qzbymEE8ZtshvIfPebbZmdVzH Guu3lK4HK0mbufcMXCqgHPttP6wxh6tQAxmyzvhsjKYcqx0zCuQppXVov3h8yhGIz0s4 9oZKNeheT38TzMxfXcm3DNYW2m010bQqp55Nz+KfdC2YevYApztjwcNRhISXpj+aNryK b8B4XTvhcKZF8wa8WHDgpqZ7eCVDFiIqlx/dKmcvgw3hk2PrgHXI7egNAByIHcbGXRwK zASw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RyWxawKp9Typ2OK2kYwM9lNUQGGOHxUK9uVUiznh4iw=; b=ttjYQiOuHeh4JkN1BZmpoReL/MiR/gwlpZz5Be1gQdfDTn18tKEL6pNlLUZutpQzlx 4yQ34Vi8tJ5UsdHHOHjm/ZXxaC2QephWQ2OlDZ+/ZE6arN2yiDcI5u11BzUUjJViGf3k W3eQXjTRmoZZmNAoAVoUBuD3oCRDzGRBUZh4bICV698hObCVmUdEj+pMQVMocvk6RYIn QNIGz+Gxld74FjPzA01j0GJN4+kU/wiMCy3bkqN9i65YJhLs0dJiaH4MWZmYR5qwZ0eH 8Yde28WtBdfoJQnLrlE8nyVC7wD0FgvtDNHDcrUnA4TWr4jW9nlpkzfn62Acg11fJSeg iDNQ== X-Gm-Message-State: AOAM531fK96LU7KE66zYgdoLdMYJikmSKDKHCM0qBHqGo+5crDXnBlGL Nqw6BKkl5no4DHggFpkNImD0fA== X-Google-Smtp-Source: ABdhPJyWYbvequ+SPWxMPfV21jB7z9+Xdz0970BgnkdBLiAkCSe0A8XOOpulClfgQGvnYSA5HZfnow== X-Received: by 2002:a1c:14e:: with SMTP id 75mr4153379wmb.151.1595507101637; Thu, 23 Jul 2020 05:25:01 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:01 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Anil Gurumurthy , Sudarsana Kalluru Subject: [PATCH 10/40] scsi: bfa: bfa_fcpim: Demote seemingly unintentional kerneldoc header Date: Thu, 23 Jul 2020 13:24:16 +0100 Message-Id: <20200723122446.1329773-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org This is the only use of kerneldoc in the source file and no descriptions are provided. Fixes the following W=1 kernel build warning(s): drivers/scsi/bfa/bfa_fcpim.c:3829: warning: Function parameter or member 'bfa' not described in 'bfa_fcpim_get_throttle_cfg' drivers/scsi/bfa/bfa_fcpim.c:3829: warning: Function parameter or member 'drv_cfg_param' not described in 'bfa_fcpim_get_throttle_cfg' Cc: Anil Gurumurthy Cc: Sudarsana Kalluru Signed-off-by: Lee Jones --- drivers/scsi/bfa/bfa_fcpim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bfa/bfa_fcpim.c b/drivers/scsi/bfa/bfa_fcpim.c index f6bf24084a47a..29f99561dfc3a 100644 --- a/drivers/scsi/bfa/bfa_fcpim.c +++ b/drivers/scsi/bfa/bfa_fcpim.c @@ -3812,7 +3812,7 @@ bfa_iotag_attach(struct bfa_fcp_mod_s *fcp) } -/** +/* * To send config req, first try to use throttle value from flash * If 0, then use driver parameter * We need to use min(flash_val, drv_val) because From patchwork Thu Jul 23 12:24:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680849 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2045313B4 for ; Thu, 23 Jul 2020 12:27:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 089AA22B47 for ; Thu, 23 Jul 2020 12:27:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WJkfBBhh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729354AbgGWM1T (ORCPT ); Thu, 23 Jul 2020 08:27:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728909AbgGWMZE (ORCPT ); Thu, 23 Jul 2020 08:25:04 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22F54C0619DC for ; Thu, 23 Jul 2020 05:25:04 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id 9so4773072wmj.5 for ; Thu, 23 Jul 2020 05:25:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7GXuG63I+zXiW2iHeDq1l75A8cqfuCvVf5oH88+KFWQ=; b=WJkfBBhhXpIiweagpu7YHnZJQkDUqh5Kgxr7h0JfR09J0THKrxTwLrDPG3qNeBF5+H IaYyNQ+m00fhuxZF5R+FcPBCB3ZWObUSnW1x2IULVBmAVFECIsnDSGhXgbhmeFicpqtj 98A2/p6zqBusuPVpMN9EC4INcbiKmdJ47v2tSIcD5J6CG6zypzMfufnW5GyLfasRvmD7 NTUHAV7TswgxUNokIWKvumdbieEcOx+3b2DVzGxhsFaVzu4l3ZSBqzJeKjnVcAl6Spjc JRaSp8E7RRxrEfLZYQ71AYXu6ZDcZNGloGlVcQI85RQ36CByWCmWbnBjZZ6obrfSJZK6 6Ang== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7GXuG63I+zXiW2iHeDq1l75A8cqfuCvVf5oH88+KFWQ=; b=PshFnbDL0uOxjqcsmoKP+TFl94pnELo6DdFKhXDCe+WImqB66Mu5awypt0Arf6/l2M CeVilshi759WJy6iAkOJdkf04e/Shqibijbxt1oTC89xs7v8t0ng63MuenE8agOgFJqb N39qDq4Zodx/eb7zsspMbw0VLmyjnAHlDIoNfi4ivua38sXMhtihARddx9BSig5v+gu4 ezRmT1Wmgb2VBjQVin5uUNCioh759IpUZJSHuCI714TNshZZhuJsIr8zCHcIgv9ebE39 Qyy+DthEnkkrCz7qQllZHo6X6yUxaUyfD4k7+pCxT3b9VkxhRHnOCu/jEAli4T9IOToE 2BIg== X-Gm-Message-State: AOAM530rQjMAONIU4c3/02es5QMIz9lP5+zk75QzagPkWrn54n60mneG +q+mw3juSB2IRiZXuijvu1hxF5RfmH8= X-Google-Smtp-Source: ABdhPJxU96+k6AAXNc4TzOnx/0IOTErBWda93TNlxgsOHGe2FcOFrrlYZvW48DUn0NkMAUlVtbl3AQ== X-Received: by 2002:a1c:2041:: with SMTP id g62mr3919099wmg.172.1595507102891; Thu, 23 Jul 2020 05:25:02 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:02 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@cavium.com Subject: [PATCH 11/40] scsi: qedi: qedi_main: Remove 2 set but unused variables Date: Thu, 23 Jul 2020 13:24:17 +0100 Message-Id: <20200723122446.1329773-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/qedi/qedi_main.c: In function ‘qedi_queue_cqe’: drivers/scsi/qedi/qedi_main.c:1158:21: warning: variable ‘conn’ set but not used [-Wunused-but-set-variable] 1158 | struct iscsi_conn *conn; | ^~~~ drivers/scsi/qedi/qedi_main.c: In function ‘__qedi_probe’: drivers/scsi/qedi/qedi_main.c:2432:6: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] 2432 | u16 tmp; | ^~~ Cc: QLogic-Storage-Upstream@cavium.com Signed-off-by: Lee Jones --- drivers/scsi/qedi/qedi_main.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index 81a307695cc91..1a7791164de8c 100644 --- a/drivers/scsi/qedi/qedi_main.c +++ b/drivers/scsi/qedi/qedi_main.c @@ -1155,7 +1155,6 @@ static int qedi_queue_cqe(struct qedi_ctx *qedi, union iscsi_cqe *cqe, { struct qedi_work *qedi_work; struct qedi_conn *q_conn; - struct iscsi_conn *conn; struct qedi_cmd *qedi_cmd; u32 iscsi_cid; int rc = 0; @@ -1168,7 +1167,6 @@ static int qedi_queue_cqe(struct qedi_ctx *qedi, union iscsi_cqe *cqe, iscsi_cid); return -1; } - conn = q_conn->cls_conn->dd_data; switch (cqe->cqe_common.cqe_type) { case ISCSI_CQE_TYPE_SOLICITED: @@ -2429,7 +2427,6 @@ static int __qedi_probe(struct pci_dev *pdev, int mode) struct qed_probe_params qed_params; void *task_start, *task_end; int rc; - u16 tmp; if (mode != QEDI_MODE_RECOVERY) { qedi = qedi_host_alloc(pdev); @@ -2528,9 +2525,9 @@ static int __qedi_probe(struct pci_dev *pdev, int mode) "Writing %d to primary and secondary BDQ doorbell registers.\n", qedi->bdq_prod_idx); writew(qedi->bdq_prod_idx, qedi->bdq_primary_prod); - tmp = readw(qedi->bdq_primary_prod); + readw(qedi->bdq_primary_prod); writew(qedi->bdq_prod_idx, qedi->bdq_secondary_prod); - tmp = readw(qedi->bdq_secondary_prod); + readw(qedi->bdq_secondary_prod); ether_addr_copy(qedi->mac, qedi->dev_info.common.hw_mac); QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_DISC, "MAC address is %pM.\n", From patchwork Thu Jul 23 12:24:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680791 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9A95413B4 for ; Thu, 23 Jul 2020 12:25:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DD9B20792 for ; Thu, 23 Jul 2020 12:25:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xLaMH7UF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728927AbgGWMZG (ORCPT ); Thu, 23 Jul 2020 08:25:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728919AbgGWMZF (ORCPT ); Thu, 23 Jul 2020 08:25:05 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E3B2C0619E2 for ; Thu, 23 Jul 2020 05:25:05 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id f18so5009788wml.3 for ; Thu, 23 Jul 2020 05:25:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EAO/H9oPsrENV00s3vT32VulXIxpsxrN3aKk7i47ICU=; b=xLaMH7UFnDh2rj+PFQo4eI/Sb/L7kbhOi+ek9Z/VDwxFR7R4iy2NCT8Wwa+Gmz47k3 bYXR1Gbvv5/hRs1WHXAlWP2LtOx+qsMUm4Okzb/+JTLGqSRnyiOJgKVn9nfOcb+n9F1q Jl6B/C3sktRHUiEfWDwmrwsF7SHg7QxovyroDW5iJsjc4mqe5RbaCh7HVnvtCkuPOEfM +B6TpEH8bcJOk/vDivsxIC1bBRRjTLjsgtinK5oYTclgu0vtCWvkb2vw20FlKXNvxZQb kSFqZnq2VNLgrjuX4FQw+sAnqODtWJ0KxJfJNdOLhu01aHmhOdU7hMQMpLpuBxMnj1k6 FkNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EAO/H9oPsrENV00s3vT32VulXIxpsxrN3aKk7i47ICU=; b=bPXUOO99lNWRAhVYcOuG4a25/O1p10HlemyBQQ88INXfYEKUPDlvNaJES7lHEOJ+85 BiiGCJ2o/O+9+Zn1xfCwLB/c11tgfRc9Pc0VG6bzRUH9JQ2r8hESz00qL6vt2i4UFmuT 1HXW5Is5zofPwE127mTIiY1yoqdjSrFUr+qF7cdfWGPwKT4jzsi43JsXZFXMLKUeJQHD OHj95kj/qHBvI2OcF4JEkk6K31LH/q310ng29djvSI6gRzNa4rTALK6zc7eo8npJO34T OmEFgCWAtO63S1yFYXSJswYWnXRoXW5Bl5/wQg2Z/g+fkJl1EcaRT5NS6otIi8gQUKDB uSsg== X-Gm-Message-State: AOAM530pi86BOubIIYCkMlreOtcX/NgZi4kM9ajgaN1Ubt+XLXBmDByi GiIQiU9DY9bibplEImkeac2aEg== X-Google-Smtp-Source: ABdhPJyT54qRwLWqt3v4hcD2iJ0I4ZhmsVGVv/ehJlWHfF0om4aY1yvS5M1xFh3lIoQf0jzqOOsJSQ== X-Received: by 2002:a7b:cd90:: with SMTP id y16mr3953271wmj.20.1595507104079; Thu, 23 Jul 2020 05:25:04 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:03 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Adaptec OEM Raid Solutions , ipslinux@adaptec.com, Christoph Hellwig Subject: [PATCH 12/40] scsi: ips: Remove some set but unused variables Date: Thu, 23 Jul 2020 13:24:18 +0100 Message-Id: <20200723122446.1329773-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Intentionally keeping all register reads/writes. Fixes the following W=1 kernel build warning(s): drivers/scsi/ips.c: In function ‘ips_init_copperhead’: drivers/scsi/ips.c:4700:10: warning: variable ‘ConfigByte’ set but not used [-Wunused-but-set-variable] 4700 | uint8_t ConfigByte[IPS_MAX_CONFIG_BYTES]; | ^~~~~~~~~~ drivers/scsi/ips.c: In function ‘ips_init_copperhead_memio’: drivers/scsi/ips.c:4794:10: warning: variable ‘ConfigByte’ set but not used [-Wunused-but-set-variable] 4794 | uint8_t ConfigByte[IPS_MAX_CONFIG_BYTES]; | ^~~~~~~~~~ drivers/scsi/ips.c: In function ‘ips_init_phase1’: drivers/scsi/ips.c:6839:10: warning: variable ‘func’ set but not used [-Wunused-but-set-variable] 6839 | uint8_t func; | ^~~~ drivers/scsi/ips.c:6838:10: warning: variable ‘bus’ set but not used [-Wunused-but-set-variable] 6838 | uint8_t bus; | ^~~ Cc: Adaptec OEM Raid Solutions Cc: ipslinux@adaptec.com Cc: Christoph Hellwig Signed-off-by: Lee Jones --- drivers/scsi/ips.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c index f25672982c5f3..ec85ccce96647 100644 --- a/drivers/scsi/ips.c +++ b/drivers/scsi/ips.c @@ -4697,7 +4697,6 @@ ips_init_copperhead(ips_ha_t * ha) uint8_t Isr; uint8_t Cbsp; uint8_t PostByte[IPS_MAX_POST_BYTES]; - uint8_t ConfigByte[IPS_MAX_CONFIG_BYTES]; int i, j; METHOD_TRACE("ips_init_copperhead", 1); @@ -4742,7 +4741,7 @@ ips_init_copperhead(ips_ha_t * ha) /* error occurred */ return (0); - ConfigByte[i] = inb(ha->io_addr + IPS_REG_ISPR); + inb(ha->io_addr + IPS_REG_ISPR); outb(Isr, ha->io_addr + IPS_REG_HISR); } @@ -4791,7 +4790,6 @@ ips_init_copperhead_memio(ips_ha_t * ha) uint8_t Isr = 0; uint8_t Cbsp; uint8_t PostByte[IPS_MAX_POST_BYTES]; - uint8_t ConfigByte[IPS_MAX_CONFIG_BYTES]; int i, j; METHOD_TRACE("ips_init_copperhead_memio", 1); @@ -4836,7 +4834,7 @@ ips_init_copperhead_memio(ips_ha_t * ha) /* error occurred */ return (0); - ConfigByte[i] = readb(ha->mem_ptr + IPS_REG_ISPR); + readb(ha->mem_ptr + IPS_REG_ISPR); writeb(Isr, ha->mem_ptr + IPS_REG_HISR); } @@ -6835,8 +6833,6 @@ ips_init_phase1(struct pci_dev *pci_dev, int *indexPtr) uint32_t mem_addr; uint32_t io_len; uint32_t mem_len; - uint8_t bus; - uint8_t func; int j; int index; dma_addr_t dma_address; @@ -6856,10 +6852,6 @@ ips_init_phase1(struct pci_dev *pci_dev, int *indexPtr) if (index >= IPS_MAX_ADAPTERS) return -1; - /* stuff that we get in dev */ - bus = pci_dev->bus->number; - func = pci_dev->devfn; - /* Init MEM/IO addresses to 0 */ mem_addr = 0; io_addr = 0; From patchwork Thu Jul 23 12:24:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680847 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F3E2E13A4 for ; Thu, 23 Jul 2020 12:27:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB5AA22B43 for ; Thu, 23 Jul 2020 12:27:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gPiSTZgQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728933AbgGWMZH (ORCPT ); Thu, 23 Jul 2020 08:25:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728928AbgGWMZG (ORCPT ); Thu, 23 Jul 2020 08:25:06 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8615EC0619E2 for ; Thu, 23 Jul 2020 05:25:06 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id 184so5021851wmb.0 for ; Thu, 23 Jul 2020 05:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=h63LOgt+Dy9g/r9ZLeRwkVpd9spngRolp7BRUfjs04E=; b=gPiSTZgQ6RVOnxc4T+m87zsgevXZ4/vwi6Yf3OWh3UnlrG/cYxRyuV8MqeTtANSA7V nTPngr5LxGg1E9sY/xI/ULZ0VKbIHJqPl5mtUSEdz9tqIzywwy61U5+ShcSBPALBQL5z lGWbxgDDdHb1OdvVc9Tya9fpObNJ4Bs/kP/DKylzQksw8IQqHt8g/g2sNQDmV+sLERNj n0yXuZfidePc2w2gaZ4gdwasSMoIt0Me7VTOHm+E4enkBrVAlHvplwxLABQFbAEycqVq bRxxmtcJewIv1+idmOiIFaeIv7CXcDrC6kVgs9bRTRdA/cR4wQMO7lq/AOYldXtTBHtV ribg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h63LOgt+Dy9g/r9ZLeRwkVpd9spngRolp7BRUfjs04E=; b=tA2TfnWelbrtwd39jDF/vzV3uf11Uyf/Q8uGNiwEruh1qqE8BCXDKU5pzDhKKI3LTA JqiG7shd08yks4AkYwnlqqDQ/zZvWBh7SY0Ya5gE3Ndh+9EP3qM80lPlKJlgpDQe9VSl yDFpLOaspMuCtRoZwSTGWLPP1RAupemDSh4BOpLOgDLlgwqocHw1YJLgoGdStU4DV1dm 3sEjjz23R2+T9KggXa/Xf5Zp7LpptBb34X5/kv4YiBkAz2IdEaAOtvD9indS80/a8SqU kmn/wP8e2zdxwlzuIDWyRHLLStEGuQtJ/Ta6xlDZX2Nz+TOy3Jcf3ZrhBrjT8B4UmbBn ePmw== X-Gm-Message-State: AOAM531o+wZeLKQ9rOYsY1v1jfLY3j3C9rhpZvd3FH9vh+QPm0WXFjUz OVVhaLiuHuIjzBI83wsqywY3+g== X-Google-Smtp-Source: ABdhPJwsIcwNe8dwuwe2OJqfzn2ZQ57y3/4mQvClR7t7daFL5f+jr6Jc5OuDYirzpKLdZtUGoAfWyw== X-Received: by 2002:a1c:7719:: with SMTP id t25mr4164947wmi.144.1595507105238; Thu, 23 Jul 2020 05:25:05 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:04 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Adaptec OEM Raid Solutions , ipslinux@adaptec.com, Christoph Hellwig Subject: [PATCH 13/40] scsi: ips: Convert strnlen() to memcpy() since result should not be NUL terminated Date: Thu, 23 Jul 2020 13:24:19 +0100 Message-Id: <20200723122446.1329773-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from arch/arm/include/asm/io.h:23, from drivers/scsi/ips.c:164: In function ‘strncpy’, inlined from ‘ips_send_cmd’ at drivers/scsi/ips.c:3522:6: include/linux/string.h:297:30: warning: ‘__builtin_strncpy’ output truncated before terminating nul cop ying 4 bytes from a string of the same length [-Wstringop-truncation] 297 | #define __underlying_strncpy __builtin_strncpy | ^ include/linux/string.h:307:9: note: in expansion of macro ‘__underlying_strncpy’ 307 | return __underlying_strncpy(p, q, size); | ^~~~~~~~~~~~~~~~~~~~ NB: Lots of these - snipping for brevity Cc: Adaptec OEM Raid Solutions Cc: ipslinux@adaptec.com Cc: Christoph Hellwig Signed-off-by: Lee Jones --- drivers/scsi/ips.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c index ec85ccce96647..2e6077c502fc7 100644 --- a/drivers/scsi/ips.c +++ b/drivers/scsi/ips.c @@ -2239,7 +2239,7 @@ ips_get_bios_version(ips_ha_t * ha, int intr) major = 0; minor = 0; - strncpy(ha->bios_version, " ?", 8); + memcpy(ha->bios_version, " ?", 8); if (ha->pcidev->device == IPS_DEVICEID_COPPERHEAD) { if (IPS_USE_MEMIO(ha)) { @@ -3515,11 +3515,11 @@ ips_send_cmd(ips_ha_t * ha, ips_scb_t * scb) inquiry.Flags[1] = IPS_SCSI_INQ_WBus16 | IPS_SCSI_INQ_Sync; - strncpy(inquiry.VendorId, "IBM ", + memcpy(inquiry.VendorId, "IBM ", 8); - strncpy(inquiry.ProductId, + memcpy(inquiry.ProductId, "SERVERAID ", 16); - strncpy(inquiry.ProductRevisionLevel, + memcpy(inquiry.ProductRevisionLevel, "1.00", 4); ips_scmd_buf_write(scb->scsi_cmd, @@ -4036,9 +4036,9 @@ ips_inquiry(ips_ha_t * ha, ips_scb_t * scb) inquiry.Flags[0] = IPS_SCSI_INQ_Address16; inquiry.Flags[1] = IPS_SCSI_INQ_WBus16 | IPS_SCSI_INQ_Sync | IPS_SCSI_INQ_CmdQue; - strncpy(inquiry.VendorId, "IBM ", 8); - strncpy(inquiry.ProductId, "SERVERAID ", 16); - strncpy(inquiry.ProductRevisionLevel, "1.00", 4); + memcpy(inquiry.VendorId, "IBM ", 8); + memcpy(inquiry.ProductId, "SERVERAID ", 16); + memcpy(inquiry.ProductRevisionLevel, "1.00", 4); ips_scmd_buf_write(scb->scsi_cmd, &inquiry, sizeof (inquiry)); @@ -5620,10 +5620,10 @@ ips_write_driver_status(ips_ha_t * ha, int intr) /* change values (as needed) */ ha->nvram->operating_system = IPS_OS_LINUX; ha->nvram->adapter_type = ha->ad_type; - strncpy((char *) ha->nvram->driver_high, IPS_VERSION_HIGH, 4); - strncpy((char *) ha->nvram->driver_low, IPS_VERSION_LOW, 4); - strncpy((char *) ha->nvram->bios_high, ha->bios_version, 4); - strncpy((char *) ha->nvram->bios_low, ha->bios_version + 4, 4); + memcpy((char *) ha->nvram->driver_high, IPS_VERSION_HIGH, 4); + memcpy((char *) ha->nvram->driver_low, IPS_VERSION_LOW, 4); + memcpy((char *) ha->nvram->bios_high, ha->bios_version, 4); + memcpy((char *) ha->nvram->bios_low, ha->bios_version + 4, 4); ha->nvram->versioning = 0; /* Indicate the Driver Does Not Support Versioning */ From patchwork Thu Jul 23 12:24:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680845 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6BCEB13A4 for ; Thu, 23 Jul 2020 12:27:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F2CB22B43 for ; Thu, 23 Jul 2020 12:27:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HB08PN5O" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729317AbgGWM06 (ORCPT ); Thu, 23 Jul 2020 08:26:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728940AbgGWMZI (ORCPT ); Thu, 23 Jul 2020 08:25:08 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E13D1C0619DC for ; Thu, 23 Jul 2020 05:25:07 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id f139so4998184wmf.5 for ; Thu, 23 Jul 2020 05:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/UGwSSOfVJ61ieGuJp/ke+Vy79kXqOUhlL6mzdoMYJw=; b=HB08PN5OpZSPQg8TKcCyb9s+OvOQTkDdUf13RCod8CSlkh4gkBoNHy7qbGNR5E5TO4 bxhN/ORl9XKEt9TAYCm8ePdCpHQfuRfreiRN0lraY+8t8nOYVI8xD+et9nuvfv6fPMRa O4NBBI0KQyJJ7iK5d1G2X/sjUq0ROZ2Wdd8XBzMmINzzs/dXTs3Azq/6GsXSZB9cuyfm DoxW05DgTVX04SVdwwCM+kvxJqJxb+UU6UZtWcg5Ivn5I1SZvYW9nSP+ksHgw3bNyj6+ RpdeMM0Ahh+aYDYmkwCPq5sbCf76U8OoqVaPtGXy60YTfg07xmJyHJHnGn/8KnO94LQf gQoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/UGwSSOfVJ61ieGuJp/ke+Vy79kXqOUhlL6mzdoMYJw=; b=dBYFgVlW4PJkX29JLq4+cAwIsbxQY339u2FuWlOIJFUr30LBjKLb+MuEBJBPw5VjXf 74RRIkWTa9GduAIdJyaLnoFM1aykoUNqd2gpLCbvGHdgrmYC/kr0+CVaLPXmjA9HPGnj 6anIZUqnhV/BCJqUrLMTUzgbJeEFN4Mwashup3S/UhphEuu30qj94kqfxZ4wF4l0B8T1 P7FH0Ouilp8pAWOMOHFpRZX020vxCOBflpGfZarJJNc6JM2noyjMs2WpYqFzC9Djix8v 1ETo9OHlXjSCtTocsfLLdITKbfTKRdFWF2XcZBC7LULJ2yHMDCxoLZaUOipeCKU2z5Ci 7/Dg== X-Gm-Message-State: AOAM533lkbTu77kkVd6RUhyjuWkai09Wr5mcNQ7c3AGaAHcG5bXkvsxJ Kb/Is+yq2NRDyNYVQ6vbaDb5WQ== X-Google-Smtp-Source: ABdhPJwkcZxfhjTTuWg1EVk/SSAtzNi4LdaonYB/co3209eDkArEedg76asRWzhwyDp3QgBLXYUkLg== X-Received: by 2002:a1c:2183:: with SMTP id h125mr4212886wmh.83.1595507106549; Thu, 23 Jul 2020 05:25:06 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:05 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@qlogic.com Subject: [PATCH 14/40] scsi: qla4xxx: ql4_83xx: Remove set but unused variable 'status' Date: Thu, 23 Jul 2020 13:24:20 +0100 Message-Id: <20200723122446.1329773-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/qla4xxx/ql4_83xx.c: In function ‘qla4_83xx_dump_pause_control_regs’: drivers/scsi/qla4xxx/ql4_83xx.c:1409:9: warning: variable ‘status’ set but not used [-Wunused-but-set-variable] 1409 | int i, status = QLA_SUCCESS; | ^~~~~~ Cc: QLogic-Storage-Upstream@qlogic.com Signed-off-by: Lee Jones --- drivers/scsi/qla4xxx/ql4_83xx.c | 34 ++++++++++++--------------------- 1 file changed, 12 insertions(+), 22 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_83xx.c b/drivers/scsi/qla4xxx/ql4_83xx.c index 638f72c5ab052..de10e67de8c01 100644 --- a/drivers/scsi/qla4xxx/ql4_83xx.c +++ b/drivers/scsi/qla4xxx/ql4_83xx.c @@ -1406,16 +1406,16 @@ int qla4_83xx_isp_reset(struct scsi_qla_host *ha) static void qla4_83xx_dump_pause_control_regs(struct scsi_qla_host *ha) { u32 val = 0, val1 = 0; - int i, status = QLA_SUCCESS; + int i; - status = qla4_83xx_rd_reg_indirect(ha, QLA83XX_SRE_SHIM_CONTROL, &val); + qla4_83xx_rd_reg_indirect(ha, QLA83XX_SRE_SHIM_CONTROL, &val); DEBUG2(ql4_printk(KERN_INFO, ha, "SRE-Shim Ctrl:0x%x\n", val)); /* Port 0 Rx Buffer Pause Threshold Registers. */ DEBUG2(ql4_printk(KERN_INFO, ha, "Port 0 Rx Buffer Pause Threshold Registers[TC7..TC0]:")); for (i = 0; i < 8; i++) { - status = qla4_83xx_rd_reg_indirect(ha, + qla4_83xx_rd_reg_indirect(ha, QLA83XX_PORT0_RXB_PAUSE_THRS + (i * 0x4), &val); DEBUG2(pr_info("0x%x ", val)); } @@ -1426,7 +1426,7 @@ static void qla4_83xx_dump_pause_control_regs(struct scsi_qla_host *ha) DEBUG2(ql4_printk(KERN_INFO, ha, "Port 1 Rx Buffer Pause Threshold Registers[TC7..TC0]:")); for (i = 0; i < 8; i++) { - status = qla4_83xx_rd_reg_indirect(ha, + qla4_83xx_rd_reg_indirect(ha, QLA83XX_PORT1_RXB_PAUSE_THRS + (i * 0x4), &val); DEBUG2(pr_info("0x%x ", val)); } @@ -1437,7 +1437,7 @@ static void qla4_83xx_dump_pause_control_regs(struct scsi_qla_host *ha) DEBUG2(ql4_printk(KERN_INFO, ha, "Port 0 RxB Traffic Class Max Cell Registers[3..0]:")); for (i = 0; i < 4; i++) { - status = qla4_83xx_rd_reg_indirect(ha, + qla4_83xx_rd_reg_indirect(ha, QLA83XX_PORT0_RXB_TC_MAX_CELL + (i * 0x4), &val); DEBUG2(pr_info("0x%x ", val)); } @@ -1448,7 +1448,7 @@ static void qla4_83xx_dump_pause_control_regs(struct scsi_qla_host *ha) DEBUG2(ql4_printk(KERN_INFO, ha, "Port 1 RxB Traffic Class Max Cell Registers[3..0]:")); for (i = 0; i < 4; i++) { - status = qla4_83xx_rd_reg_indirect(ha, + qla4_83xx_rd_reg_indirect(ha, QLA83XX_PORT1_RXB_TC_MAX_CELL + (i * 0x4), &val); DEBUG2(pr_info("0x%x ", val)); } @@ -1459,15 +1459,11 @@ static void qla4_83xx_dump_pause_control_regs(struct scsi_qla_host *ha) DEBUG2(ql4_printk(KERN_INFO, ha, "Port 0 RxB Rx Traffic Class Stats [TC7..TC0]")); for (i = 7; i >= 0; i--) { - status = qla4_83xx_rd_reg_indirect(ha, - QLA83XX_PORT0_RXB_TC_STATS, - &val); + qla4_83xx_rd_reg_indirect(ha, QLA83XX_PORT0_RXB_TC_STATS, &val); val &= ~(0x7 << 29); /* Reset bits 29 to 31 */ qla4_83xx_wr_reg_indirect(ha, QLA83XX_PORT0_RXB_TC_STATS, (val | (i << 29))); - status = qla4_83xx_rd_reg_indirect(ha, - QLA83XX_PORT0_RXB_TC_STATS, - &val); + qla4_83xx_rd_reg_indirect(ha, QLA83XX_PORT0_RXB_TC_STATS, &val); DEBUG2(pr_info("0x%x ", val)); } @@ -1477,24 +1473,18 @@ static void qla4_83xx_dump_pause_control_regs(struct scsi_qla_host *ha) DEBUG2(ql4_printk(KERN_INFO, ha, "Port 1 RxB Rx Traffic Class Stats [TC7..TC0]")); for (i = 7; i >= 0; i--) { - status = qla4_83xx_rd_reg_indirect(ha, - QLA83XX_PORT1_RXB_TC_STATS, - &val); + qla4_83xx_rd_reg_indirect(ha, QLA83XX_PORT1_RXB_TC_STATS, &val); val &= ~(0x7 << 29); /* Reset bits 29 to 31 */ qla4_83xx_wr_reg_indirect(ha, QLA83XX_PORT1_RXB_TC_STATS, (val | (i << 29))); - status = qla4_83xx_rd_reg_indirect(ha, - QLA83XX_PORT1_RXB_TC_STATS, - &val); + qla4_83xx_rd_reg_indirect(ha, QLA83XX_PORT1_RXB_TC_STATS, &val); DEBUG2(pr_info("0x%x ", val)); } DEBUG2(pr_info("\n")); - status = qla4_83xx_rd_reg_indirect(ha, QLA83XX_PORT2_IFB_PAUSE_THRS, - &val); - status = qla4_83xx_rd_reg_indirect(ha, QLA83XX_PORT3_IFB_PAUSE_THRS, - &val1); + qla4_83xx_rd_reg_indirect(ha, QLA83XX_PORT2_IFB_PAUSE_THRS, &val); + qla4_83xx_rd_reg_indirect(ha, QLA83XX_PORT3_IFB_PAUSE_THRS, &val1); DEBUG2(ql4_printk(KERN_INFO, ha, "IFB-Pause Thresholds: Port 2:0x%x, Port 3:0x%x\n", From patchwork Thu Jul 23 12:24:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680843 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3C10F13B4 for ; Thu, 23 Jul 2020 12:26:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 234D72086A for ; Thu, 23 Jul 2020 12:26:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S7iTBu6T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729128AbgGWM0r (ORCPT ); Thu, 23 Jul 2020 08:26:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728919AbgGWMZJ (ORCPT ); Thu, 23 Jul 2020 08:25:09 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EF6DC0619E4 for ; Thu, 23 Jul 2020 05:25:09 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id z15so4955758wrl.8 for ; Thu, 23 Jul 2020 05:25:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EocuI/v8dMGAgziexe3ETAgpgON59vWZbZOU+TdWcao=; b=S7iTBu6TIjSJT9lhyIg+YJr8IZo3qTqoKB4l1HwFH6Yxl5aaRRU4n+oBwQu130P2Ks sq2howsZNiIYBIUOPdPJjji/uqA574RfrXiW+g3GQgpongvY0tmmZ5j9GDJO5IP8N0sf aI+l6KjfNk3Yp+P6QIMHWINQKS94OLgynWUI4uLFXCwoovOEmUs+kLgPBMENG4jxPOQ2 3CMxtks+EOf+T7KV/anCeQJt+/p4LoiNftuqImi2Ua9LeFcD+rx96t2pCu5DOlD1Lkeg WuUvgX3aTE+a2OETnGp4WsXka1VhtlCAK8zisNcSsoNizljQjq4qG9Jp8RYPPBb2rn5a oX4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EocuI/v8dMGAgziexe3ETAgpgON59vWZbZOU+TdWcao=; b=OUKEvzkkQpDOTYN2GiqESfd1/lBoq+yO7FexGM9rhKdjhX65sdzyjKG0XV+USilyPs c/yRiK+P6xjmp5XHt7MZ5w67HCqxmSPkxpCzo4wvXDhDiEtu9Wxh8CP3xgXyXT4r9kXw 0bJnVwWSLUpHFlAgakUuuLry3UCK3fxzRd3hqe/Kzysa1KHrlm+4FuwxSrWZxG347dZY l8f6CzY8Sg9agx/pHa4gTQDjQUf4+poPe35OZrGqkRln2pVpw3sZuADaZI6vQpEmKoWY HlxDzB1D/u7t8URPjKtnssnIqPlfLfDLFp+Pvq94EKGBef/02uYqV37g6fDiba1ikipG p27Q== X-Gm-Message-State: AOAM533X4u1wSBNuExHlCjz5TQVc6cYtQQKD1dG+o9JcMWWWEmxvt7W7 Ds6f1SWwDw9uQzd9Yb2sskusow== X-Google-Smtp-Source: ABdhPJyJvzXQnTwZ1RNq92ZfHV+XpgztidF3x8njT7epkUJHrqMDSd6v6B+D1Xc4vP1zy5QOwPXs6w== X-Received: by 2002:adf:c401:: with SMTP id v1mr3678093wrf.379.1595507107890; Thu, 23 Jul 2020 05:25:07 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:07 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , James Smart , Dick Kennedy Subject: [PATCH 15/40] scsi: lpfc: lpfc_init: Use __printf() format notation Date: Thu, 23 Jul 2020 13:24:21 +0100 Message-Id: <20200723122446.1329773-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/lpfc/lpfc_init.c: In function ‘lpfc_dbg_print’: drivers/scsi/lpfc/lpfc_init.c:14212:6: warning: function ‘lpfc_dbg_print’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] 14212 | sizeof(phba->dbg_log[idx].log), fmt, args); | ^~~~~~ Cc: James Smart Cc: Dick Kennedy Signed-off-by: Lee Jones --- drivers/scsi/lpfc/lpfc_init.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 20edf001fdd97..ccfae1c0c0963 100644 --- a/drivers/scsi/lpfc/lpfc_init.c +++ b/drivers/scsi/lpfc/lpfc_init.c @@ -14187,6 +14187,7 @@ void lpfc_dmp_dbg(struct lpfc_hba *phba) atomic_set(&phba->dbg_log_dmping, 0); } +__printf(2, 3) void lpfc_dbg_print(struct lpfc_hba *phba, const char *fmt, ...) { unsigned int idx; From patchwork Thu Jul 23 12:24:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680793 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5B1DF13A4 for ; Thu, 23 Jul 2020 12:25:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3770122B43 for ; Thu, 23 Jul 2020 12:25:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="g8dXQTy8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728968AbgGWMZP (ORCPT ); Thu, 23 Jul 2020 08:25:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728918AbgGWMZN (ORCPT ); Thu, 23 Jul 2020 08:25:13 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 687B7C0619E6 for ; Thu, 23 Jul 2020 05:25:10 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id f7so4994713wrw.1 for ; Thu, 23 Jul 2020 05:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cFAwrJOlCaFEAVVXRM8LDqpbMDff7j2Fk+BIxfpepaE=; b=g8dXQTy8iWZ/pt+ut/TLsb7iSfAJcjVrkyf6QbrijskAnGR9/49VfRqguD6pCv4Z0T 1MhKE6RG8mLHO1UGPkiCJMj8RQX/RfycK/PExTKbIjLT9s9/lCO/tloSzxd4b/Iz1Qxg zWMP2pz014MHwwUHceBDQC5iLwJzMF9k/23yzMxQXTnr6tCDr/jfR5za7hfMzVWt8wj7 HsFQhJbLgAdqOrGjeFGjELXDbYNQqrsaXBRFie4tByCK9JsJRfZ/zNaHJaMXZ5RKFWjI dJBA/qVzG38Gh8WMqAOmfaK9xmTwdsl4b86COjmKUy5BO9Py2tj/xWc1sG57ehZohAcS k+iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cFAwrJOlCaFEAVVXRM8LDqpbMDff7j2Fk+BIxfpepaE=; b=PRx0b87iBa3NvkI3h4YvP85QaqPCr51Kla6sp42/qj/ltZHEiOOpFmgYC+1DISJYKI gbD199EgRzvvIv6/p0lACw98uAdO86NxUol74TzIeTjzvzju5b85OPWss7e1F86e2cQN wKUsuiJrXfAM7+XescUl6UEKiMhqMTWt69X+H+j3kH6iGBAQR6Jskd4BE6NGVjEOXhBc 6QhErJcmke+yiDt+DMVm5k8/jbqifBWb7Do7Z0vT2Qftn34hERMUAjj5Cwh0LeShGVW+ DiO47gzKDNGTqS9VC+Ed6b2OYC4NzxFj5CO/bUoyFOga+kPB4Q47Kas6mEixveXtewsb /fXw== X-Gm-Message-State: AOAM532zKwrYkPOyzMxdE3LqHCDaZ+QApfc3fmtQsLZ3vu78RA3I+DIE Z24lu5M/RRlzOekGDT+XfChNFC6pyyw= X-Google-Smtp-Source: ABdhPJzgX1K70aJ6Evdd74S501XGoQPyL6zPbkRybZlJlfOrxnM1Oy51c6xjZQ2vc5ko9lDy4ZvFHQ== X-Received: by 2002:a5d:4d8b:: with SMTP id b11mr3861082wru.341.1595507108920; Thu, 23 Jul 2020 05:25:08 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:08 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , James Smart , Dick Kennedy Subject: [PATCH 16/40] scsi: lpfc: lpfc_init: Add and rename a whole bunch of function parameter descriptions Date: Thu, 23 Jul 2020 13:24:22 +0100 Message-Id: <20200723122446.1329773-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/lpfc/lpfc_init.c:1136: warning: Function parameter or member 't' not described in 'lpfc_hb_timeout' drivers/scsi/lpfc/lpfc_init.c:1136: warning: Excess function parameter 'ptr' description in 'lpfc_hb_timeout' drivers/scsi/lpfc/lpfc_init.c:1170: warning: Function parameter or member 't' not described in 'lpfc_rrq_timeout' drivers/scsi/lpfc/lpfc_init.c:1170: warning: Excess function parameter 'ptr' description in 'lpfc_rrq_timeout' drivers/scsi/lpfc/lpfc_init.c:1232: warning: Function parameter or member 'work' not described in 'lpfc_idle_stat_delay_work' drivers/scsi/lpfc/lpfc_init.c:1817: warning: Function parameter or member 'en_rn_msg' not described in 'lpfc_sli4_port_sta_fn_reset' drivers/scsi/lpfc/lpfc_init.c:3033: warning: Function parameter or member 'mbx_action' not described in 'lpfc_block_mgmt_io' drivers/scsi/lpfc/lpfc_init.c:3481: warning: Function parameter or member 'mbx_action' not described in 'lpfc_offline_prep' drivers/scsi/lpfc/lpfc_init.c:4150: warning: Function parameter or member 'phba' not described in 'lpfc_new_io_buf' drivers/scsi/lpfc/lpfc_init.c:4150: warning: Function parameter or member 'num_to_alloc' not described in 'lpfc_new_io_buf' drivers/scsi/lpfc/lpfc_init.c:4150: warning: Excess function parameter 'vport' description in 'lpfc_new_io_buf' drivers/scsi/lpfc/lpfc_init.c:4150: warning: Excess function parameter 'num_to_allocate' description in 'lpfc_new_io_buf' drivers/scsi/lpfc/lpfc_init.c:4736: warning: Function parameter or member 't' not described in 'lpfc_sli4_fcf_redisc_wait_tmo' drivers/scsi/lpfc/lpfc_init.c:4736: warning: Excess function parameter 'ptr' description in 'lpfc_sli4_fcf_redisc_wait_tmo' drivers/scsi/lpfc/lpfc_init.c:5103: warning: Excess function parameter 'evt_code' description in 'lpfc_async_link_speed_to_read_top' drivers/scsi/lpfc/lpfc_init.c:5377: warning: Function parameter or member 'acqe_sli' not described in 'lpfc_sli4_async_sli_evt' drivers/scsi/lpfc/lpfc_init.c:5377: warning: Excess function parameter 'acqe_fc' description in 'lpfc_sli4_async_sli_evt' drivers/scsi/lpfc/lpfc_init.c:5634: warning: Function parameter or member 'phba' not described in 'lpfc_sli4_perform_all_vport_cvl' drivers/scsi/lpfc/lpfc_init.c:5634: warning: Excess function parameter 'vport' description in 'lpfc_sli4_perform_all_vport_cvl' drivers/scsi/lpfc/lpfc_init.c:5655: warning: Function parameter or member 'acqe_fip' not described in 'lpfc_sli4_async_fip_evt' drivers/scsi/lpfc/lpfc_init.c:5655: warning: Excess function parameter 'acqe_link' description in 'lpfc_sli4_async_fip_evt' drivers/scsi/lpfc/lpfc_init.c:5908: warning: Function parameter or member 'acqe_dcbx' not described in 'lpfc_sli4_async_dcbx_evt' drivers/scsi/lpfc/lpfc_init.c:5908: warning: Excess function parameter 'acqe_link' description in 'lpfc_sli4_async_dcbx_evt' drivers/scsi/lpfc/lpfc_init.c:5927: warning: Function parameter or member 'acqe_grp5' not described in 'lpfc_sli4_async_grp5_evt' drivers/scsi/lpfc/lpfc_init.c:5927: warning: Excess function parameter 'acqe_link' description in 'lpfc_sli4_async_grp5_evt' drivers/scsi/lpfc/lpfc_init.c:7279: warning: Function parameter or member 'iocb_count' not described in 'lpfc_init_iocb_list' drivers/scsi/lpfc/lpfc_init.c:8227: warning: Function parameter or member 'if_type' not described in 'lpfc_sli4_bar1_register_memmap' drivers/scsi/lpfc/lpfc_init.c:8414: warning: Excess function parameter 'phba' description in 'LINK_FLAGS_DEF' drivers/scsi/lpfc/lpfc_init.c:8414: warning: Excess function parameter 'rdconf' description in 'LINK_FLAGS_DEF' drivers/scsi/lpfc/lpfc_init.c:10734: warning: Function parameter or member 'cfg_mode' not described in 'lpfc_sli_enable_intr' drivers/scsi/lpfc/lpfc_init.c:11241: warning: Function parameter or member 'eqlist' not described in 'lpfc_cpuhp_get_eq' drivers/scsi/lpfc/lpfc_init.c:11726: warning: Function parameter or member 'cfg_mode' not described in 'lpfc_sli4_enable_intr' drivers/scsi/lpfc/lpfc_init.c:12997: warning: Excess function parameter 'ret' description in 'lpfc_write_firmware' drivers/scsi/lpfc/lpfc_init.c:13103: warning: Function parameter or member 'fw_upgrade' not described in 'lpfc_sli4_request_firmware_update' Cc: James Smart Cc: Dick Kennedy Signed-off-by: Lee Jones --- drivers/scsi/lpfc/lpfc_init.c | 45 +++++++++++++++++++---------------- 1 file changed, 24 insertions(+), 21 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index ccfae1c0c0963..c4a7e82d3ff24 100644 --- a/drivers/scsi/lpfc/lpfc_init.c +++ b/drivers/scsi/lpfc/lpfc_init.c @@ -993,7 +993,6 @@ lpfc_hba_clean_txcmplq(struct lpfc_hba *phba) /** * lpfc_hba_down_post_s3 - Perform lpfc uninitialization after HBA reset - int i; * @phba: pointer to lpfc HBA data structure. * * This routine will do uninitialization after the HBA is reset when bring @@ -1121,7 +1120,7 @@ lpfc_hba_down_post(struct lpfc_hba *phba) /** * lpfc_hb_timeout - The HBA-timer timeout handler - * @ptr: unsigned long holds the pointer to lpfc hba data structure. + * @t: timer context used to obtain the pointer to lpfc hba data structure. * * This is the HBA-timer timeout handler registered to the lpfc driver. When * this timer fires, a HBA timeout event shall be posted to the lpfc driver @@ -1155,7 +1154,7 @@ lpfc_hb_timeout(struct timer_list *t) /** * lpfc_rrq_timeout - The RRQ-timer timeout handler - * @ptr: unsigned long holds the pointer to lpfc hba data structure. + * @t: timer context used to obtain the pointer to lpfc hba data structure. * * This is the RRQ-timer timeout handler registered to the lpfc driver. When * this timer fires, a RRQ timeout event shall be posted to the lpfc driver @@ -1219,7 +1218,7 @@ lpfc_hb_mbox_cmpl(struct lpfc_hba * phba, LPFC_MBOXQ_t * pmboxq) return; } -/** +/* * lpfc_idle_stat_delay_work - idle_stat tracking * * This routine tracks per-cq idle_stat and determines polling decisions. @@ -1804,7 +1803,7 @@ lpfc_handle_eratt_s3(struct lpfc_hba *phba) * lpfc_sli4_port_sta_fn_reset - The SLI4 function reset due to port status reg * @phba: pointer to lpfc hba data structure. * @mbx_action: flag for mailbox shutdown action. - * + * @en_rn_msg: send reset/port recovery message. * This routine is invoked to perform an SLI4 port PCI function reset in * response to port status register polling attention. It waits for port * status register (ERR, RDY, RN) bits before proceeding with function reset. @@ -3021,6 +3020,7 @@ lpfc_stop_hba_timers(struct lpfc_hba *phba) /** * lpfc_block_mgmt_io - Mark a HBA's management interface as blocked * @phba: pointer to lpfc hba data structure. + * @mbx_action: flag for mailbox no wait action. * * This routine marks a HBA's management interface as blocked. Once the HBA's * management interface is marked as blocked, all the user space access to @@ -3471,6 +3471,7 @@ lpfc_unblock_mgmt_io(struct lpfc_hba * phba) /** * lpfc_offline_prep - Prepare a HBA to be brought offline * @phba: pointer to lpfc hba data structure. + * @mbx_action: flag for mailbox shutdown action. * * This routine is invoked to prepare a HBA to be brought offline. It performs * unregistration login to all the nodes on all vports and flushes the mailbox @@ -4133,8 +4134,8 @@ lpfc_sli4_io_sgl_update(struct lpfc_hba *phba) /** * lpfc_new_io_buf - IO buffer allocator for HBA with SLI4 IF spec - * @vport: The virtual port for which this call being executed. - * @num_to_allocate: The requested number of buffers to allocate. + * @phba: Pointer to lpfc hba data structure. + * @num_to_alloc: The requested number of buffers to allocate. * * This routine allocates nvme buffers for device with SLI-4 interface spec, * the nvme buffer contains all the necessary information needed to initiate @@ -4723,7 +4724,7 @@ lpfc_fcf_redisc_wait_start_timer(struct lpfc_hba *phba) /** * lpfc_sli4_fcf_redisc_wait_tmo - FCF table rediscover wait timeout - * @ptr: Map to lpfc_hba data structure pointer. + * @t: Timer context used to obtain the pointer to lpfc hba data structure. * * This routine is invoked when waiting for FCF table rediscover has been * timed out. If new FCF record(s) has (have) been discovered during the @@ -5090,7 +5091,6 @@ lpfc_sli4_async_link_evt(struct lpfc_hba *phba, * lpfc_async_link_speed_to_read_top - Parse async evt link speed code to read * topology. * @phba: pointer to lpfc hba data structure. - * @evt_code: asynchronous event code. * @speed_code: asynchronous event link speed code. * * This routine is to parse the giving SLI4 async event link speed code into @@ -5368,7 +5368,7 @@ lpfc_sli4_async_fc_evt(struct lpfc_hba *phba, struct lpfc_acqe_fc_la *acqe_fc) /** * lpfc_sli4_async_sli_evt - Process the asynchronous SLI link event * @phba: pointer to lpfc hba data structure. - * @acqe_fc: pointer to the async SLI completion queue entry. + * @acqe_sli: pointer to the async SLI completion queue entry. * * This routine is to handle the SLI4 asynchronous SLI events. **/ @@ -5624,7 +5624,7 @@ lpfc_sli4_perform_vport_cvl(struct lpfc_vport *vport) /** * lpfc_sli4_perform_all_vport_cvl - Perform clear virtual link on all vports - * @vport: pointer to lpfc hba data structure. + * @phba: pointer to lpfc hba data structure. * * This routine is to perform Clear Virtual Link (CVL) on all vports in * response to a FCF dead event. @@ -5645,7 +5645,7 @@ lpfc_sli4_perform_all_vport_cvl(struct lpfc_hba *phba) /** * lpfc_sli4_async_fip_evt - Process the asynchronous FCoE FIP event * @phba: pointer to lpfc hba data structure. - * @acqe_link: pointer to the async fcoe completion queue entry. + * @acqe_fip: pointer to the async fcoe completion queue entry. * * This routine is to handle the SLI4 asynchronous fcoe event. **/ @@ -5898,7 +5898,7 @@ lpfc_sli4_async_fip_evt(struct lpfc_hba *phba, /** * lpfc_sli4_async_dcbx_evt - Process the asynchronous dcbx event * @phba: pointer to lpfc hba data structure. - * @acqe_link: pointer to the async dcbx completion queue entry. + * @acqe_dcbx: pointer to the async dcbx completion queue entry. * * This routine is to handle the SLI4 asynchronous dcbx event. **/ @@ -5915,7 +5915,7 @@ lpfc_sli4_async_dcbx_evt(struct lpfc_hba *phba, /** * lpfc_sli4_async_grp5_evt - Process the asynchronous group5 event * @phba: pointer to lpfc hba data structure. - * @acqe_link: pointer to the async grp5 completion queue entry. + * @acqe_grp5: pointer to the async grp5 completion queue entry. * * This routine is to handle the SLI4 asynchronous grp5 event. A grp5 event * is an asynchronous notified of a logical link speed change. The Port @@ -7266,6 +7266,7 @@ lpfc_free_iocb_list(struct lpfc_hba *phba) /** * lpfc_init_iocb_list - Allocate and initialize iocb list. * @phba: pointer to lpfc hba data structure. + * @iocb_count: number of requested iocbs * * This routine is invoked to allocate and initizlize the driver's IOCB * list and set up the IOCB tag array accordingly. @@ -8219,6 +8220,7 @@ lpfc_sli4_bar0_register_memmap(struct lpfc_hba *phba, uint32_t if_type) /** * lpfc_sli4_bar1_register_memmap - Set up SLI4 BAR1 register memory map. * @phba: pointer to lpfc hba data structure. + * @if_type: sli if type to operate on. * * This routine is invoked to set up SLI4 BAR1 register memory map. **/ @@ -8400,20 +8402,19 @@ static const char * const lpfc_topo_to_str[] = { "P2P then Loop", }; +#define LINK_FLAGS_DEF 0x0 +#define LINK_FLAGS_P2P 0x1 +#define LINK_FLAGS_LOOP 0x2 /** * lpfc_map_topology - Map the topology read from READ_CONFIG * @phba: pointer to lpfc hba data structure. - * @rdconf: pointer to read config data + * @rd_config: pointer to read config data * * This routine is invoked to map the topology values as read * from the read config mailbox command. If the persistent * topology feature is supported, the firmware will provide the * saved topology information to be used in INIT_LINK - * **/ -#define LINK_FLAGS_DEF 0x0 -#define LINK_FLAGS_P2P 0x1 -#define LINK_FLAGS_LOOP 0x2 static void lpfc_map_topology(struct lpfc_hba *phba, struct lpfc_mbx_read_config *rd_config) { @@ -10716,6 +10717,7 @@ lpfc_sli_enable_msi(struct lpfc_hba *phba) /** * lpfc_sli_enable_intr - Enable device interrupt to SLI-3 device. * @phba: pointer to lpfc hba data structure. + * @cfg_mode: Interrupt configuration mode (INTx, MSI or MSI-X). * * This routine is invoked to enable device interrupt and associate driver's * interrupt handler(s) to interrupt vector(s) to device with SLI-3 interface @@ -11233,7 +11235,7 @@ lpfc_cpu_affinity_check(struct lpfc_hba *phba, int vectors) * * @phba: pointer to lpfc hba data structure. * @cpu: cpu going offline - * @eqlist: + * @eqlist: eq list to append to */ static int lpfc_cpuhp_get_eq(struct lpfc_hba *phba, unsigned int cpu, @@ -11708,6 +11710,7 @@ lpfc_sli4_enable_msi(struct lpfc_hba *phba) /** * lpfc_sli4_enable_intr - Enable device interrupt to SLI-4 device * @phba: pointer to lpfc hba data structure. + * @cfg_mode: Interrupt configuration mode (INTx, MSI or MSI-X). * * This routine is invoked to enable device interrupt and associate driver's * interrupt handler(s) to interrupt vector(s) to device with SLI-4 @@ -12989,7 +12992,6 @@ lpfc_log_write_firmware_error(struct lpfc_hba *phba, uint32_t offset, * lpfc_write_firmware - attempt to write a firmware image to the port * @fw: pointer to firmware image returned from request_firmware. * @context: pointer to firmware image returned from request_firmware. - * @ret: return value this routine provides to the caller. * **/ static void @@ -13094,6 +13096,7 @@ lpfc_write_firmware(const struct firmware *fw, void *context) /** * lpfc_sli4_request_firmware_update - Request linux generic firmware upgrade * @phba: pointer to lpfc hba data structure. + * @fw_upgrade: which firmware to update. * * This routine is called to perform Linux generic firmware upgrade on device * that supports such feature. From patchwork Thu Jul 23 12:24:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680837 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A9B8E13A4 for ; Thu, 23 Jul 2020 12:26:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E6A320888 for ; Thu, 23 Jul 2020 12:26:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ASk1pLpm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728974AbgGWMZQ (ORCPT ); Thu, 23 Jul 2020 08:25:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728959AbgGWMZN (ORCPT ); Thu, 23 Jul 2020 08:25:13 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1D00C0619E7 for ; Thu, 23 Jul 2020 05:25:11 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id f18so5010114wml.3 for ; Thu, 23 Jul 2020 05:25:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vvVihUnRFqMdxGLBXS9BPHUYjIV5Tt/WnThdFe3tGqE=; b=ASk1pLpmZPrxFOz/aAoD/Ta392mN6iPzej/2OLBJcHirDz4m4DiqrW5Rz8pnvQCg3b 4v1g2OLLCe8FpjQJnZbAmPuD2pF1PSDJsZK514iZvhY8Z6kiTMAG/BH9ixrHk6waYQzx ggrEIo1zyDBRcLeIGpoY2MvSAUuRDyZmxGPDMWr3jLGah+qTy04BkMCb6LVokUZaZ56L My+BJAHs3hylLRjrKDjgrECQ9WsWKYatXeURswCgJiF/6C4uEhK1mX6ODqqF4pv6hNWE DrdDaaHD92YqGw+fv5ny+LnMAm5fSxmOYdbY5EDb73V86wYzvhFb6GT8ElCfzuLgCQsW /nnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vvVihUnRFqMdxGLBXS9BPHUYjIV5Tt/WnThdFe3tGqE=; b=F0YnvI3mDIaUV5gHGc+CcbUICdR3CXHnV4QHrgG5/+NS7NL0Umw5OhVRWH2VfJBz7x x7GI2oqOjNV5T9xuUPa5uHkPAObnM2z5q7GSglVqgDWVKR3y0OztTMyCAF2ddCRpXEud TEbZKA1tcbpeP9Xq18v0VJCvPy1VgkWgttezDD2IQ9b8lUGrzToA1I1/aqmn6rBbTWhq FeoQH9s1QF2B+iBjK7xH0hKJzzfR5I9g6mYMO+qH+rDJ11wuBn7Uq7NKBSa31DduKHiT FXj1RZjx/YTDIewxGTcjFgJWkCTd1PgaoL9JPzjEGhIOrMCyoUgnoIjVXNMf5rEYNTnp TsAA== X-Gm-Message-State: AOAM530Y22Vo6F8id5ZaDgKp+pjzzcJF3BXY5TGES0b5kHIxtN/D5Kv+ YjLXxTAs24PuNfRCAlNWBlp2vw== X-Google-Smtp-Source: ABdhPJyKG4U0JmHyOzcwDHBhbjxqAF1cbPfZqUXMamtCsYAkdrJV/XwgD9FSh+MCWccrwNnLa0xp2A== X-Received: by 2002:a1c:a757:: with SMTP id q84mr1700943wme.1.1595507109953; Thu, 23 Jul 2020 05:25:09 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:09 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@qlogic.com Subject: [PATCH 17/40] scsi: qla4xxx: ql4_bsg: Rename function parameter descriptions Date: Thu, 23 Jul 2020 13:24:23 +0100 Message-Id: <20200723122446.1329773-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/qla4xxx/ql4_bsg.c:811: warning: Function parameter or member 'bsg_job' not described in 'qla4xxx_process_vendor_specific' drivers/scsi/qla4xxx/ql4_bsg.c:811: warning: Excess function parameter 'job' description in 'qla4xxx_process_vendor_specific' drivers/scsi/qla4xxx/ql4_bsg.c:858: warning: Function parameter or member 'bsg_job' not described in 'qla4xxx_bsg_request' drivers/scsi/qla4xxx/ql4_bsg.c:858: warning: Excess function parameter 'job' description in 'qla4xxx_bsg_request' Cc: QLogic-Storage-Upstream@qlogic.com Signed-off-by: Lee Jones --- drivers/scsi/qla4xxx/ql4_bsg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_bsg.c b/drivers/scsi/qla4xxx/ql4_bsg.c index 415ee5eb3fc7e..9231917066d3e 100644 --- a/drivers/scsi/qla4xxx/ql4_bsg.c +++ b/drivers/scsi/qla4xxx/ql4_bsg.c @@ -805,7 +805,7 @@ static int qla4xxx_execute_diag_test(struct bsg_job *bsg_job) /** * qla4xxx_process_vendor_specific - handle vendor specific bsg request - * @job: iscsi_bsg_job to handle + * @bsg_job: iscsi_bsg_job to handle **/ int qla4xxx_process_vendor_specific(struct bsg_job *bsg_job) { @@ -852,7 +852,7 @@ int qla4xxx_process_vendor_specific(struct bsg_job *bsg_job) /** * qla4xxx_bsg_request - handle bsg request from ISCSI transport - * @job: iscsi_bsg_job to handle + * @bsg_job: iscsi_bsg_job to handle */ int qla4xxx_bsg_request(struct bsg_job *bsg_job) { From patchwork Thu Jul 23 12:24:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680797 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 242E414E3 for ; Thu, 23 Jul 2020 12:25:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0229322B43 for ; Thu, 23 Jul 2020 12:25:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="y9/5H92V" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728981AbgGWMZQ (ORCPT ); Thu, 23 Jul 2020 08:25:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728961AbgGWMZO (ORCPT ); Thu, 23 Jul 2020 08:25:14 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81B0DC0698C4 for ; Thu, 23 Jul 2020 05:25:12 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id y3so4977615wrl.4 for ; Thu, 23 Jul 2020 05:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fFCkXG9YSXNm34wg4F+wGX5K4ez31ESofd03IW98OEg=; b=y9/5H92VbCA1egotNV9BA58XpjXdzU33aT3oGUcjZfBmDlpDVbbF3L5oth+TM4+oft LLsJa3FnzFeoDFjArzUyZhkCXcXOnwOlBsZ8xmvZquib1xqFDlxOQJzgvozOJ9BNkbh9 ds+ISMCJ45QDwEpbN/XFb5aZbnS2h8KzzD5QjQEMZSlXjDlebRw2UT1S63Udzvc7T6DP VKDlSzmGcVs7kG7++z+U/Xwi///G+AHZSBAZYL1B2SYOTk9Im/ecX+wcKU44M9Cqj3o+ HEJbpO+/Ro1oyUPOsr8IEbGlAcV5F2P2to7VA1MIpG2Qs2lEbPCvHX/TRY/TqKsbZ0Re tObA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fFCkXG9YSXNm34wg4F+wGX5K4ez31ESofd03IW98OEg=; b=Op5/TCH3LJPRacqCCq07iQGZhe22D/yiQvvQ4vwbai4eI1s4D6zatgFVN4ruvCECOU n2/LdVYa1wbpmRRN/PgEID4PxGfs7lGXK8ayswp2Z74glwJXsQXj/T/0MMXQQZwbl0nM 9/83FKympG6eu6LQOvWQkA6byjYqSPCF0GGIgpRMlQVaCvXNZtKECoCymp6ZNbMq+3Sz 8gpVtP5KA/NIif4SLBd55HwEGWs4QuVg3uIhqBPrTaSeIJCs6jxbnxVXEiY5+iMuuhgA jpuWus/EmCruGTUD97bRBmUUDkrbJPUaUNWWq1qMWOuh9fV1g6otgQwWcDizPgpGAVgg hnjg== X-Gm-Message-State: AOAM5304xApuujBDu0Ors3GI+K1Fd31QzIX20dfKd2SyXBl6KmHF09sK jJ/WR6BUjp/Vyr48UhIPOkw7pQ== X-Google-Smtp-Source: ABdhPJx3323BO+jDBKt8oJ/qAiv4vjAs5/wa0v5rDlaloTpI5IVv4LvTUQNYjvIiQGqEXA/vu8j6Bw== X-Received: by 2002:adf:92a1:: with SMTP id 30mr4196849wrn.56.1595507111228; Thu, 23 Jul 2020 05:25:11 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:10 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , James Smart , Dick Kennedy Subject: [PATCH 18/40] scsi: lpfc: lpfc_mbox: Fix a bunch of kerneldoc misdemeanours Date: Thu, 23 Jul 2020 13:24:24 +0100 Message-Id: <20200723122446.1329773-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Adding, removing and correcting function parameter descriptions. Fixes the following W=1 kernel build warning(s): drivers/scsi/lpfc/lpfc_mbox.c:886: warning: Function parameter or member 'vport' not described in 'lpfc_reg_vpi' drivers/scsi/lpfc/lpfc_mbox.c:886: warning: Excess function parameter 'phba' description in 'lpfc_reg_vpi' drivers/scsi/lpfc/lpfc_mbox.c:886: warning: Excess function parameter 'vpi' description in 'lpfc_reg_vpi' drivers/scsi/lpfc/lpfc_mbox.c:886: warning: Excess function parameter 'sid' description in 'lpfc_reg_vpi' drivers/scsi/lpfc/lpfc_mbox.c:1218: warning: Function parameter or member 'ring' not described in 'lpfc_config_ring' drivers/scsi/lpfc/lpfc_mbox.c:1626: warning: Function parameter or member 'mboxq' not described in 'lpfc_mbox_tmo_val' drivers/scsi/lpfc/lpfc_mbox.c:1626: warning: Excess function parameter 'cmd' description in 'lpfc_mbox_tmo_val' drivers/scsi/lpfc/lpfc_mbox.c:1710: warning: Function parameter or member 'sge' not described in 'lpfc_sli4_mbx_sge_get' drivers/scsi/lpfc/lpfc_mbox.c:1780: warning: Function parameter or member 'emb' not described in 'lpfc_sli4_config' drivers/scsi/lpfc/lpfc_mbox.c:2027: warning: Function parameter or member 'mboxq' not described in 'lpfc_sli4_mbx_read_fcf_rec' drivers/scsi/lpfc/lpfc_mbox.c:2078: warning: Function parameter or member 'phba' not described in 'lpfc_request_features' Cc: James Smart Cc: Dick Kennedy Signed-off-by: Lee Jones --- drivers/scsi/lpfc/lpfc_mbox.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_mbox.c b/drivers/scsi/lpfc/lpfc_mbox.c index e34e0f11bfdd5..3414ffcb26fed 100644 --- a/drivers/scsi/lpfc/lpfc_mbox.c +++ b/drivers/scsi/lpfc/lpfc_mbox.c @@ -868,9 +868,7 @@ lpfc_sli4_unreg_all_rpis(struct lpfc_vport *vport) /** * lpfc_reg_vpi - Prepare a mailbox command for registering vport identifier - * @phba: pointer to lpfc hba data structure. - * @vpi: virtual N_Port identifier. - * @sid: Fibre Channel S_ID (N_Port_ID assigned to a virtual N_Port). + * @vport: pointer to a vport object. * @pmb: pointer to the driver internal queue element for mailbox command. * * The registration vport identifier mailbox command is used to activate a @@ -1199,7 +1197,7 @@ lpfc_config_hbq(struct lpfc_hba *phba, uint32_t id, /** * lpfc_config_ring - Prepare a mailbox command for configuring an IOCB ring * @phba: pointer to lpfc hba data structure. - * @ring: + * @ring: ring number/index * @pmb: pointer to the driver internal queue element for mailbox command. * * The configure ring mailbox command is used to configure an IOCB ring. This @@ -1613,7 +1611,7 @@ lpfc_mbox_dev_check(struct lpfc_hba *phba) /** * lpfc_mbox_tmo_val - Retrieve mailbox command timeout value * @phba: pointer to lpfc hba data structure. - * @cmd: mailbox command code. + * @mboxq: pointer to the driver internal queue element for mailbox command. * * This routine retrieves the proper timeout value according to the mailbox * command code. @@ -1700,6 +1698,7 @@ lpfc_sli4_mbx_sge_set(struct lpfcMboxq *mbox, uint32_t sgentry, * lpfc_sli4_mbx_sge_get - Get a sge entry from non-embedded mailbox command * @mbox: pointer to lpfc mbox command. * @sgentry: sge entry index. + * @sge: pointer to lpfc mailbox sge to load into. * * This routine gets an entry from the non-embedded mailbox command at the sge * index location. @@ -1767,6 +1766,7 @@ lpfc_sli4_mbox_cmd_free(struct lpfc_hba *phba, struct lpfcMboxq *mbox) * @subsystem: The sli4 config sub mailbox subsystem. * @opcode: The sli4 config sub mailbox command opcode. * @length: Length of the sli4 config mailbox command (including sub-header). + * @emb: True if embedded mbox command should be setup. * * This routine sets up the header fields of SLI4 specific mailbox command * for sending IOCTL command. @@ -2012,6 +2012,7 @@ lpfc_sli_config_mbox_opcode_get(struct lpfc_hba *phba, LPFC_MBOXQ_t *mbox) /** * lpfc_sli4_mbx_read_fcf_rec - Allocate and construct read fcf mbox cmd * @phba: pointer to lpfc hba data structure. + * @mboxq: pointer to lpfc mbox command. * @fcf_index: index to fcf table. * * This routine routine allocates and constructs non-embedded mailbox command @@ -2068,6 +2069,7 @@ lpfc_sli4_mbx_read_fcf_rec(struct lpfc_hba *phba, /** * lpfc_request_features: Configure SLI4 REQUEST_FEATURES mailbox + * @phba: pointer to lpfc hba data structure. * @mboxq: pointer to lpfc mbox command. * * This routine sets up the mailbox for an SLI4 REQUEST_FEATURES From patchwork Thu Jul 23 12:24:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680795 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 80E3A13B4 for ; Thu, 23 Jul 2020 12:25:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 629A422B43 for ; Thu, 23 Jul 2020 12:25:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xTfiRk90" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728987AbgGWMZR (ORCPT ); Thu, 23 Jul 2020 08:25:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728963AbgGWMZO (ORCPT ); Thu, 23 Jul 2020 08:25:14 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD21BC0619DC for ; Thu, 23 Jul 2020 05:25:13 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id r4so2011015wrx.9 for ; Thu, 23 Jul 2020 05:25:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HAIXAoCGqRA6aXiEiRW1R66V0LVzLBw6uYtWpjQ05tI=; b=xTfiRk902Ux5z0iLg95e5TXWewYKIvXvL8/J/I5m9W04gEagMxuZuQUJqEglaXOHTD 8cO7dex6ejeb33Fr+JckVgaaRtP8237JEcRZpIQY/Kg+mGsdxQEVu07uxFb015X7f2L2 rg7Kd/6zmR4EcZtRYLpgqAEKcP4zECyy3QGjW8I25aefIKbakjBVSx1XP01mSSfX1gsW JFen4kOawaCoSco3oTdRoa4lBuO6gD1LM5ppqC+cQxWiCM/PlD///eCg93g3UG5qL9N2 Bg4/5JP+ffO/fSmzF3kjIJKYnDWMi3V9+ilhrYWmxxjpCwwtMJquB2RzqnloOvlzKU6q I9SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HAIXAoCGqRA6aXiEiRW1R66V0LVzLBw6uYtWpjQ05tI=; b=ecLTBNDXLODPMKN+nzAEZFlEWzLtDkgpqbk03xmz/BYOjxDSo9kBBl8tHQwJL5d8xr DuHVZh+itLcTV8rkA2JvK8XPXMYZ8W44wZso5GYQELW7Mm/Yoh9u6DVtvc7RQBcwwO+i yCTF0ssV8A/GH6BpFb18gLMglyIyXbqDH2YGqJIFf8wLx8q9eB8wbTWf+OJOzvingqZL zBtJ9BnvRmDwzbj/+b126oR4UKKqnnelUcSRLi5TakPJvbu1WkTHKiH1AK5kicg7Yovy S4cuqpQAMFDDQjE+IAQ9N93rjiTHiIMCu7fu8em6PxB/dHWx0GX/m/bMad9DNeSB8SwC nEvQ== X-Gm-Message-State: AOAM531N8IDfQq89hAS2q1+zC/JpRIDAydOMjdFI2n/KCUVJ4h4jniXv TQJOceHgF/NA535IJkRZI1EXaA== X-Google-Smtp-Source: ABdhPJw6c+4/R2KsXk5e1ke0zgJmSY+jh8jMKQMPrpTCdgWccXiEJ7HwuDP9IpkKqcDH7tGFistLXg== X-Received: by 2002:adf:eccc:: with SMTP id s12mr4269090wro.157.1595507112468; Thu, 23 Jul 2020 05:25:12 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:11 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , James Smart , Dick Kennedy Subject: [PATCH 19/40] scsi: lpfc: lpfc_nportdisc: Add description for lpfc_release_rpi()'s 'ndlpl param Date: Thu, 23 Jul 2020 13:24:25 +0100 Message-Id: <20200723122446.1329773-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/lpfc/lpfc_nportdisc.c:1079: warning: Function parameter or member 'ndlp' not described in 'lpfc_release_rpi' Cc: James Smart Cc: Dick Kennedy Signed-off-by: Lee Jones --- drivers/scsi/lpfc/lpfc_nportdisc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c index 5276bf5bd59bc..e4c710fe02451 100644 --- a/drivers/scsi/lpfc/lpfc_nportdisc.c +++ b/drivers/scsi/lpfc/lpfc_nportdisc.c @@ -1068,6 +1068,7 @@ lpfc_disc_set_adisc(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp) * lpfc_release_rpi - Release a RPI by issuing unreg_login mailbox cmd. * @phba : Pointer to lpfc_hba structure. * @vport: Pointer to lpfc_vport structure. + * @ndlp: Pointer to lpfc_nodelist structure. * @rpi : rpi to be release. * * This function will send a unreg_login mailbox command to the firmware From patchwork Thu Jul 23 12:24:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680841 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DAB3E13A4 for ; Thu, 23 Jul 2020 12:26:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1F11206D7 for ; Thu, 23 Jul 2020 12:26:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bW8Vzj2E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729264AbgGWM0j (ORCPT ); Thu, 23 Jul 2020 08:26:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728967AbgGWMZP (ORCPT ); Thu, 23 Jul 2020 08:25:15 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E65C5C0619E2 for ; Thu, 23 Jul 2020 05:25:14 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id y24so830460wma.1 for ; Thu, 23 Jul 2020 05:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Cf+NSCEl4l8fm6ZX+HEQTyPPFg3UkwN755ooy1CCQaI=; b=bW8Vzj2EJhdja/ubPDqRLsVuqa538TxXzPjSDWyOLPJlJlKHSuLh0e8AQTVjAQOsWj 5iY5rXElIn/muLPp4tHPfoqmOi7EMVbreljiZjBCUM0G8aeiKacpa3jkFA/pydW+IbP8 ihoL5Oih3uKUPrfWJo8Yb+dhthAzlM2nNUJlV0kogpD9ZPBThJV2+5S/uhGFAW8e6rvM drfBYTLbauHSb/LyA5UqaSOFajg5EzUiRifrWDiTxOJrqPUz04zLbLgoQVdmhmyL77Lh 6BpAfFg72ip+akmWhstJvvvQJ3KnRqXZzTHmcVh92g8GSSYz9hfEmtoOMikayWkuv6BD GrTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Cf+NSCEl4l8fm6ZX+HEQTyPPFg3UkwN755ooy1CCQaI=; b=kOQSHsCeeh5e1kCmGckNB0fQSUSYXUr5StcOa/lj8o9rtw8ASR37yYgQ+E8rMmJfBV BbDsX1WIQiz2H29dLW9ktCeEnkZ2uaStVeD/ScflSp6RnBqwZAOYEL1hJYebidUlR5OD K1Bp77aYPToZSaIz4qtuxZ5nYiSZrQnmuunNXtyKI25HfPYvSqRpX3kDxIqNnZQrM325 Ka5yck7FXEYhTIfgoGJzCOd9dTrlc+N9nMWcgQa6FreYMlXJBMeR+dIm0Wi3/6RLLimh hEqHa2gOlgfug2cZ7STZvKNkQWXY5bWNkT/m9pNatoiEK23+2zQFcO0aKIbZS9pFsxzi 7DZA== X-Gm-Message-State: AOAM533+mC4sKkjctIlS6RWCjmCvlehNK0ZUGYB5gyW0yCiryoWB8baF a33gxBOeJTtVxPAQ1ftzoLcr+Q== X-Google-Smtp-Source: ABdhPJxsnzHZiVUbnFjEJ5JYLdPuSU74e+dTLAPlg1MC2TgRbgk9mlshAJM1+n1kD9SuPzUxOE43SQ== X-Received: by 2002:a7b:cb46:: with SMTP id v6mr4176892wmj.73.1595507113681; Thu, 23 Jul 2020 05:25:13 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:13 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Anil Gurumurthy , Sudarsana Kalluru Subject: [PATCH 20/40] scsi: bfa: bfa_ioc: Remove a few unused variables 'pgoff' and 't' Date: Thu, 23 Jul 2020 13:24:26 +0100 Message-Id: <20200723122446.1329773-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/bfa/bfa_ioc.c: In function ‘bfa_iocpf_sm_fwcheck_entry’: drivers/scsi/bfa/bfa_ioc.c:704:27: warning: variable ‘pgoff’ set but not used [-Wunused-but-set-variable] drivers/scsi/bfa/bfa_ioc.c: In function ‘bfa_ioc_fwver_get’: drivers/scsi/bfa/bfa_ioc.c:1443:13: warning: variable ‘pgoff’ set but not used [-Wunused-but-set-variable] drivers/scsi/bfa/bfa_ioc.c: In function ‘bfa_ioc_fwsig_invalidate’: drivers/scsi/bfa/bfa_ioc.c:1665:13: warning: variable ‘pgoff’ set but not used [-Wunused-but-set-variable] drivers/scsi/bfa/bfa_ioc.c: In function ‘bfa_ioc_download_fw’: drivers/scsi/bfa/bfa_ioc.c:1866:13: warning: variable ‘pgoff’ set but not used [-Wunused-but-set-variable] drivers/scsi/bfa/bfa_ioc.c: In function ‘bfa_diag_memtest_done’: drivers/scsi/bfa/bfa_ioc.c:4766:13: warning: variable ‘pgoff’ set but not used [-Wunused-but-set-variable] drivers/scsi/bfa/bfa_ioc.c: In function ‘bfa_flash_fifo_flush’: drivers/scsi/bfa/bfa_ioc.c:6787:6: warning: variable ‘t’ set but not used [-Wunused-but-set-variable] Cc: Anil Gurumurthy Cc: Sudarsana Kalluru Signed-off-by: Lee Jones --- drivers/scsi/bfa/bfa_ioc.c | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/scsi/bfa/bfa_ioc.c index 93471d7c61d05..3ce281a02d5bb 100644 --- a/drivers/scsi/bfa/bfa_ioc.c +++ b/drivers/scsi/bfa/bfa_ioc.c @@ -701,7 +701,7 @@ static void bfa_iocpf_sm_fwcheck_entry(struct bfa_iocpf_s *iocpf) { struct bfi_ioc_image_hdr_s fwhdr; - u32 r32, fwstate, pgnum, pgoff, loff = 0; + u32 r32, fwstate, pgnum, loff = 0; int i; /* @@ -731,7 +731,6 @@ bfa_iocpf_sm_fwcheck_entry(struct bfa_iocpf_s *iocpf) * Clear fwver hdr */ pgnum = PSS_SMEM_PGNUM(iocpf->ioc->ioc_regs.smem_pg0, loff); - pgoff = PSS_SMEM_PGOFF(loff); writel(pgnum, iocpf->ioc->ioc_regs.host_page_num_fn); for (i = 0; i < sizeof(struct bfi_ioc_image_hdr_s) / sizeof(u32); i++) { @@ -1440,13 +1439,12 @@ bfa_ioc_lpu_stop(struct bfa_ioc_s *ioc) void bfa_ioc_fwver_get(struct bfa_ioc_s *ioc, struct bfi_ioc_image_hdr_s *fwhdr) { - u32 pgnum, pgoff; + u32 pgnum; u32 loff = 0; int i; u32 *fwsig = (u32 *) fwhdr; pgnum = PSS_SMEM_PGNUM(ioc->ioc_regs.smem_pg0, loff); - pgoff = PSS_SMEM_PGOFF(loff); writel(pgnum, ioc->ioc_regs.host_page_num_fn); for (i = 0; i < (sizeof(struct bfi_ioc_image_hdr_s) / sizeof(u32)); @@ -1662,7 +1660,7 @@ bfa_status_t bfa_ioc_fwsig_invalidate(struct bfa_ioc_s *ioc) { - u32 pgnum, pgoff; + u32 pgnum; u32 loff = 0; enum bfi_ioc_state ioc_fwstate; @@ -1671,7 +1669,6 @@ bfa_ioc_fwsig_invalidate(struct bfa_ioc_s *ioc) return BFA_STATUS_ADAPTER_ENABLED; pgnum = PSS_SMEM_PGNUM(ioc->ioc_regs.smem_pg0, loff); - pgoff = PSS_SMEM_PGOFF(loff); writel(pgnum, ioc->ioc_regs.host_page_num_fn); bfa_mem_write(ioc->ioc_regs.smem_page_start, loff, BFA_IOC_FW_INV_SIGN); @@ -1863,7 +1860,7 @@ bfa_ioc_download_fw(struct bfa_ioc_s *ioc, u32 boot_type, u32 boot_env) { u32 *fwimg; - u32 pgnum, pgoff; + u32 pgnum; u32 loff = 0; u32 chunkno = 0; u32 i; @@ -1892,8 +1889,6 @@ bfa_ioc_download_fw(struct bfa_ioc_s *ioc, u32 boot_type, pgnum = PSS_SMEM_PGNUM(ioc->ioc_regs.smem_pg0, loff); - pgoff = PSS_SMEM_PGOFF(loff); - writel(pgnum, ioc->ioc_regs.host_page_num_fn); for (i = 0; i < fwimg_size; i++) { @@ -4763,11 +4758,9 @@ bfa_diag_memtest_done(void *cbarg) struct bfa_ioc_s *ioc = diag->ioc; struct bfa_diag_memtest_result *res = diag->result; u32 loff = BFI_BOOT_MEMTEST_RES_ADDR; - u32 pgnum, pgoff, i; + u32 pgnum, i; pgnum = PSS_SMEM_PGNUM(ioc->ioc_regs.smem_pg0, loff); - pgoff = PSS_SMEM_PGOFF(loff); - writel(pgnum, ioc->ioc_regs.host_page_num_fn); for (i = 0; i < (sizeof(struct bfa_diag_memtest_result) / @@ -6784,7 +6777,6 @@ static u32 bfa_flash_fifo_flush(void __iomem *pci_bar) { u32 i; - u32 t; union bfa_flash_dev_status_reg_u dev_status; dev_status.i = readl(pci_bar + FLI_DEV_STATUS_REG); @@ -6794,7 +6786,7 @@ bfa_flash_fifo_flush(void __iomem *pci_bar) /* fifo counter in terms of words */ for (i = 0; i < dev_status.r.fifo_cnt; i++) - t = readl(pci_bar + FLI_RDDATA_REG); + readl(pci_bar + FLI_RDDATA_REG); /* * Check the device status. It may take some time. From patchwork Thu Jul 23 12:24:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680839 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2C47F13A4 for ; Thu, 23 Jul 2020 12:26:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1347A22BEF for ; Thu, 23 Jul 2020 12:26:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GrbtluSJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728987AbgGWM0f (ORCPT ); Thu, 23 Jul 2020 08:26:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728971AbgGWMZQ (ORCPT ); Thu, 23 Jul 2020 08:25:16 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8E5FC0619DC for ; Thu, 23 Jul 2020 05:25:15 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id o8so4783277wmh.4 for ; Thu, 23 Jul 2020 05:25:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Va/Ff5G2hEmAhvKYYGy2WjvjWoULU+Qfw6mOj+wkLgk=; b=GrbtluSJbKvXB3XVk94LANq0j8olHPMHyQJC8heK46kTGaizDW8xkyyCRV2sy9pwlO NasEXqqYQqCkCgZO0ZucEKCaIWJnxD/tqbrOLCncdpe4cvDbP7k6BQRTtUbG/NSQe+oT L83Mn0nJOjCPAmTCkeQMCxWoiPpP8Inh6/UGZZpWCOy25u2GUSx2WhoqplwC6orcnj0M aM9oFpQj+subQFcUjh2krxgDuvQf1dbVE6y1/+jQjR2YEbKkQoRikCw/CEL3QFjkPURz 0o1bHAHoxtzm8Huk5Gx3SI+LnKiR0z+DwrgcwFjez73AGGZ15h7Vy8jhvbTFO18BKka1 xTIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Va/Ff5G2hEmAhvKYYGy2WjvjWoULU+Qfw6mOj+wkLgk=; b=ebU6l5Li/u6jHU9TvFQVeQOw2QjrCU8zzMSqXyDEEp6YTq19DALsUYXT9mRhfDEh75 fYLYhvKcJLLUPXTbQLd9in+prrv0b+L+pCxNFLZwHbLLEU2OY3AmjHZNjsySd56kLQyQ i6h1pM14XvkbHhCZh7Q9zcWg6wYkppwMT7scXOGbxQgai9L4H9H3pKQPqD8I+CZxU1Qa z2sWc0X/XCEngGcDST23sRroK7FJHcHocoW2TeFvBirlWhv1Y47YcfO60rksqpw1saJD A5VKvUGYUGWbPjbpqZ0x2xCnL7a4AcEDrwvnQnTeQtkKOfoCYaoNjVyVEL7Ua9T0JlC8 wRoA== X-Gm-Message-State: AOAM531bpDhNYt6WDZeNwAy+NFRt5Zd2EVt6S2Nirhu9ejj7hzaBAD3U v6hnzxPwC60GuE3ILQ3SWR596Q== X-Google-Smtp-Source: ABdhPJxYMy4WI54kPr1zV3EGU+isVVMYiwRBNr7dqikp5ChiLWLv5GhFemXzv/nugVl78RxJzX5jXg== X-Received: by 2002:a1c:790c:: with SMTP id l12mr3922082wme.50.1595507114637; Thu, 23 Jul 2020 05:25:14 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:14 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Arkadiusz Drabczyk Subject: [PATCH 21/40] scsi: csiostor: csio_hw: Mark known unused variable as __always_unused Date: Thu, 23 Jul 2020 13:24:27 +0100 Message-Id: <20200723122446.1329773-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/csiostor/csio_hw.c: In function ‘csio_hw_get_vpd_params’: drivers/scsi/csiostor/csio_hw.c:309:8: warning: variable ‘s’ set but not used [-Wunused-but-set-variable] Cc: Arkadiusz Drabczyk Signed-off-by: Lee Jones --- drivers/scsi/csiostor/csio_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/csiostor/csio_hw.c b/drivers/scsi/csiostor/csio_hw.c index 950f9cdf0577f..98d4d39aaa572 100644 --- a/drivers/scsi/csiostor/csio_hw.c +++ b/drivers/scsi/csiostor/csio_hw.c @@ -306,7 +306,7 @@ csio_hw_get_vpd_params(struct csio_hw *hw, struct csio_vpd *p) uint8_t *vpd, csum; const struct t4_vpd_hdr *v; /* To get around compilation warning from strstrip */ - char *s; + char __always_unused *s; if (csio_is_valid_vpd(hw)) return 0; From patchwork Thu Jul 23 12:24:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680833 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 79E9E13B4 for ; Thu, 23 Jul 2020 12:26:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F7EA20888 for ; Thu, 23 Jul 2020 12:26:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xFC5+L6q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728989AbgGWMZS (ORCPT ); Thu, 23 Jul 2020 08:25:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728960AbgGWMZR (ORCPT ); Thu, 23 Jul 2020 08:25:17 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2D32C0619DC for ; Thu, 23 Jul 2020 05:25:16 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id 88so4978210wrh.3 for ; Thu, 23 Jul 2020 05:25:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KuXFDEYVsnsDfXIKt9wKPHYtC5k1C4IDk7HQmnmIHX4=; b=xFC5+L6qTksxCecGRt3nk4ZWSrIfiJ5KB8fRopA2KjkpV8FmkuJa0jtIZRe/PclS1a /4M87SpuupjQwVaqi01RBVgXJOs5dZDHD7Uuik52ZLmXYonwu+Hr2hgN20b8+D66Bqxh 2Zesy56tksWGu5NWopASjeu6yF+zoGxk0PRr5O6eYmqqGpl0i02ozM/sLvikCsSdKJ3K SNtVxe9K8vzqtiJRA595fYK+tDZ5N95wcXGNptCKciO7aSs34z5mGknLQAKaJ/T33nr+ QYSatN0QX3DXlIcbKV+D/IeXyMfxhJCd0e30ZyyDCJJu/v/tyMvmpnW706QoSu9E1XSu 823A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KuXFDEYVsnsDfXIKt9wKPHYtC5k1C4IDk7HQmnmIHX4=; b=Xvs2n3nOCFmZqu029Am//koTFr0uwUUJijC4xQGVjRIdlFaEoY5sLGeNCu9ugGZun8 19lrGxjm3GSkklebiHmM36/FYc9jmrL1nkI/etv7g9uFdE5y/Nyd0T7QhCTjsJWl5NT4 WT/4Mvgp8NVdcXJPyBNrsrebuwj1nv9pMRpxFn1d3HrNl12drzJ4VJQp1gMRvkZ9Utg+ xQOWGK6BFhIqDEY68RbW874WXX4RAOSkjzUnyXEWiDvFC8iVDRLfvz8uB1t41zU0S+lK UY9TJllBIO0+FVgnA20fBWXx/QnBu3b6aOnKXmF0VJUmQdtvj0E0mHHqkiXWnOxuEpK6 RO5g== X-Gm-Message-State: AOAM531FhhW+3hEcwSRCsKacHFCQET1j28VueJhbq4w5X1eENx6YWJM9 /GOQWZVKHBsofStwEbCvbo/Nkg== X-Google-Smtp-Source: ABdhPJxCnxCGnN7MmoQVRH8Z3jCjXBAJHu7Hl1DfZ7kT2ofsa6YfNX2BVf1YuitsN9T7DAfEI8Gn7w== X-Received: by 2002:adf:df06:: with SMTP id y6mr3706057wrl.89.1595507115674; Thu, 23 Jul 2020 05:25:15 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:15 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones Subject: [PATCH 22/40] scsi: csiostor: csio_hw_t5: Remove 2 unused variables {mc,edc}_bist_status_rdata_reg Date: Thu, 23 Jul 2020 13:24:28 +0100 Message-Id: <20200723122446.1329773-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/csiostor/csio_hw_t5.c: In function ‘csio_t5_mc_read’: drivers/scsi/csiostor/csio_hw_t5.c:151:11: warning: variable ‘mc_bist_status_rdata_reg’ set but not used [-Wunused-but-set-variable] 151 | uint32_t mc_bist_status_rdata_reg, mc_bist_data_pattern_reg; | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/csiostor/csio_hw_t5.c: In function ‘csio_t5_edc_read’: drivers/scsi/csiostor/csio_hw_t5.c:199:38: warning: variable ‘edc_bist_status_rdata_reg’ set but not used [-Wunused-but-set-variable] 199 | uint32_t edc_bist_cmd_data_pattern, edc_bist_status_rdata_reg; | ^~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Lee Jones --- drivers/scsi/csiostor/csio_hw_t5.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/csiostor/csio_hw_t5.c b/drivers/scsi/csiostor/csio_hw_t5.c index f24def6c6fd1e..1df8891d37251 100644 --- a/drivers/scsi/csiostor/csio_hw_t5.c +++ b/drivers/scsi/csiostor/csio_hw_t5.c @@ -148,12 +148,11 @@ csio_t5_mc_read(struct csio_hw *hw, int idx, uint32_t addr, __be32 *data, { int i; uint32_t mc_bist_cmd_reg, mc_bist_cmd_addr_reg, mc_bist_cmd_len_reg; - uint32_t mc_bist_status_rdata_reg, mc_bist_data_pattern_reg; + uint32_t mc_bist_data_pattern_reg; mc_bist_cmd_reg = MC_REG(MC_P_BIST_CMD_A, idx); mc_bist_cmd_addr_reg = MC_REG(MC_P_BIST_CMD_ADDR_A, idx); mc_bist_cmd_len_reg = MC_REG(MC_P_BIST_CMD_LEN_A, idx); - mc_bist_status_rdata_reg = MC_REG(MC_P_BIST_STATUS_RDATA_A, idx); mc_bist_data_pattern_reg = MC_REG(MC_P_BIST_DATA_PATTERN_A, idx); if (csio_rd_reg32(hw, mc_bist_cmd_reg) & START_BIST_F) @@ -196,7 +195,7 @@ csio_t5_edc_read(struct csio_hw *hw, int idx, uint32_t addr, __be32 *data, { int i; uint32_t edc_bist_cmd_reg, edc_bist_cmd_addr_reg, edc_bist_cmd_len_reg; - uint32_t edc_bist_cmd_data_pattern, edc_bist_status_rdata_reg; + uint32_t edc_bist_cmd_data_pattern; /* * These macro are missing in t4_regs.h file. @@ -208,7 +207,6 @@ csio_t5_edc_read(struct csio_hw *hw, int idx, uint32_t addr, __be32 *data, edc_bist_cmd_addr_reg = EDC_REG_T5(EDC_H_BIST_CMD_ADDR_A, idx); edc_bist_cmd_len_reg = EDC_REG_T5(EDC_H_BIST_CMD_LEN_A, idx); edc_bist_cmd_data_pattern = EDC_REG_T5(EDC_H_BIST_DATA_PATTERN_A, idx); - edc_bist_status_rdata_reg = EDC_REG_T5(EDC_H_BIST_STATUS_RDATA_A, idx); #undef EDC_REG_T5 #undef EDC_STRIDE_T5 From patchwork Thu Jul 23 12:24:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680835 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CC92C14E3 for ; Thu, 23 Jul 2020 12:26:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF75120888 for ; Thu, 23 Jul 2020 12:26:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NgTx2AQ5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729239AbgGWM01 (ORCPT ); Thu, 23 Jul 2020 08:26:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728992AbgGWMZT (ORCPT ); Thu, 23 Jul 2020 08:25:19 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA1C1C0619E3 for ; Thu, 23 Jul 2020 05:25:18 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id r12so4939087wrj.13 for ; Thu, 23 Jul 2020 05:25:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g7HEL4xrEwuTkMeUXu16IXZ1qnXvn6HqyFPGQLsjThQ=; b=NgTx2AQ5OQPVWBHc7CmEJc5GGfGEO/5DyHik2uTF6EgETZV6AdtbtCDj0FSiyR51Cn tTyhu3J3XVFcqJss3c0b5hiXkqP5m1YVDeNPujGQynIqxmFBRhI6h8LdSboYukfZS/4O yO3mINgrz51r4097D6OtYhLHPuZgvb0LTUwVhV2LxObdnlvyW5aivwp3UwkGe2+ABYEF 1mBn5mdSXsnfjbrrJwde9b2Kwxb2BhEtuXksHiDJEyJ1/xjjHtjuTOsKe4Q5EVcUqw7q Na8B/5PpPocWEXF2vzj/SYjLgRQaGXekwdU6mU2hYIRu1E4HPiOaVH/jyrKDjbjzTcZO m4Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g7HEL4xrEwuTkMeUXu16IXZ1qnXvn6HqyFPGQLsjThQ=; b=rL0U+h7orsJc2qNKYJFajbdJCVkjBKIrH4delLpYI5vsTDMnqLtc6V6mFbaLluTsLw TU3brbK9h9FeSy9+RACAPjOYJiJEFznRLrwHawbPMeaJTqy/gb6Qp/ggXMCx7vIB3/Tv J8Ns69ZxwS2YWSV5XGWWtAbp16SaDkluZERA5zR9DfeazrEMLluF64tSHTcWWUvSI5lp QqN5d5y7AFw8SIrxIhxhH2VOSpU5Am53WYhBp+NubGmSEQimXPgPXq0On8oHwX6BbXN1 RvkQgxPbAcFh/EiYNkpZF/4/9nTYVqo319V33UyfYM8s5LLbUfwlFjg1nqcnu7TGBVj+ NjqA== X-Gm-Message-State: AOAM5331UJWGP3/Hin2zRYhuouAXQ3drSIlScuzCKjuOYFAJvOxacohR Q/GE1atYUjNVPdQF+4YeN4sY7A== X-Google-Smtp-Source: ABdhPJyh4nBcbknxwuqgi6BDewjRtpccybnkpPvqru8OaJoltE93qD4sMfXoKyIid7IznS1CwxsnqA== X-Received: by 2002:adf:bc54:: with SMTP id a20mr3827338wrh.227.1595507117476; Thu, 23 Jul 2020 05:25:17 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:16 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Anil Gurumurthy , Sudarsana Kalluru Subject: [PATCH 23/40] scsi: bfa: bfa_ioc: Staticify non-external functions Date: Thu, 23 Jul 2020 13:24:29 +0100 Message-Id: <20200723122446.1329773-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/bfa/bfa_ioc.c:5023:1: warning: no previous prototype for ‘bfa_diag_intr’ [-Wmissing-prototypes] 5023 | bfa_diag_intr(void *diagarg, struct bfi_mbmsg_s *msg) | ^~~~~~~~~~~~~ drivers/scsi/bfa/bfa_ioc.c:6966:1: warning: no previous prototype for ‘bfa_flash_sem_get’ [-Wmissing-prototypes] 6966 | bfa_flash_sem_get(void __iomem *bar) | ^~~~~~~~~~~~~~~~~ drivers/scsi/bfa/bfa_ioc.c:6979:1: warning: no previous prototype for ‘bfa_flash_sem_put’ [-Wmissing-prototypes] 6979 | bfa_flash_sem_put(void __iomem *bar) | ^~~~~~~~~~~~~~~~~ Cc: Anil Gurumurthy Cc: Sudarsana Kalluru Signed-off-by: Lee Jones --- drivers/scsi/bfa/bfa_ioc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/scsi/bfa/bfa_ioc.c index 3ce281a02d5bb..10c12b5a36b84 100644 --- a/drivers/scsi/bfa/bfa_ioc.c +++ b/drivers/scsi/bfa/bfa_ioc.c @@ -5019,7 +5019,7 @@ diag_portbeacon_comp(struct bfa_diag_s *diag) /* * Diag hmbox handler */ -void +static void bfa_diag_intr(void *diagarg, struct bfi_mbmsg_s *msg) { struct bfa_diag_s *diag = diagarg; @@ -6962,7 +6962,7 @@ bfa_raw_sem_get(void __iomem *bar) } -bfa_status_t +static bfa_status_t bfa_flash_sem_get(void __iomem *bar) { u32 n = FLASH_BLOCKING_OP_MAX; @@ -6975,7 +6975,7 @@ bfa_flash_sem_get(void __iomem *bar) return BFA_STATUS_OK; } -void +static void bfa_flash_sem_put(void __iomem *bar) { writel(0, (bar + FLASH_SEM_LOCK_REG)); From patchwork Thu Jul 23 12:24:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680831 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E49C013A4 for ; Thu, 23 Jul 2020 12:26:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC4D322B43 for ; Thu, 23 Jul 2020 12:26:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JuFdS5y7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729010AbgGWMZX (ORCPT ); Thu, 23 Jul 2020 08:25:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728985AbgGWMZU (ORCPT ); Thu, 23 Jul 2020 08:25:20 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2675C0619DC for ; Thu, 23 Jul 2020 05:25:19 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id f7so4995154wrw.1 for ; Thu, 23 Jul 2020 05:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=euKwHTd5nmGQirdNec0wmJhbD/rOPWNyEyTyNJ+qI+A=; b=JuFdS5y710xg7RFc7xoZiCn3DzeYwplfD9eeT3fvU2DpPlQMshxBMlcev/VDriTtJJ lKufu0zDWWI/ezb59IYeT/E+7wBz15on/r6th+k5L/Za/YFBwe9mI6wtT3PSaU+s2T4G myg2wIS9618YPDyhloZNL2Shbjd+1eEqJswxvbHS0/zjY7xN5toWF1RZNhmbgURGYfQx kw6ANS46TLW3b31RdSdoX6gKzbPQ0T0n4/1CWWeM9GPx31A5eNNnvRyK+AHP8ml3YamA 6yAD7+vqbH+BOwdtHWk3Jbm36PhITyiTmBYNHVleZfKr/ZjjTHFRPNqhR1fS3xHhDtm/ pvLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=euKwHTd5nmGQirdNec0wmJhbD/rOPWNyEyTyNJ+qI+A=; b=skdbGjxnmBZrqSzMGJahbDLyCl0zUs1qd0piR99LfWffVL2pOPJK3XF+phwH3QxlNl QRa0RL0qwALAApkfY+C3QH4Edwto/OzKdMO84H0u4kob49uvhmDaSJTL7p41O/jMDslV ZxBVWT4co65WDSejL2GHwJBnTpD/Y50Y8EPdnzzADo9SlcCdyU+I7Yx4EwEynaJwtrkK ai8ctxIziR8DGs4yPpeCOhF3TA18aNeG/QJ+A4FBtk+OMzMEaleAdIMVrAE9OIZjx7iM /RvsaPSIGWqjy7mGpbW9nShC6rhZ8GVz5K9FRzmpKiJC5PUEdGc8c3p+LMetzwtE5Wpg iPVQ== X-Gm-Message-State: AOAM5316Y92LMYZaJL2xWyvK5sVeTLdum1FW5RP9frrfVFCGryBK6PO/ lbOsUbi1/DtjORGz5PscyYtoUg== X-Google-Smtp-Source: ABdhPJzSBVHJ88f6m8bQEuFIRyRwgvryu7g4a5wAFl3g7lEWHef74sdfGzIDj1FOc+h2tgj3hX3Itg== X-Received: by 2002:adf:ec8b:: with SMTP id z11mr3736372wrn.51.1595507118682; Thu, 23 Jul 2020 05:25:18 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:18 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones Subject: [PATCH 24/40] scsi: csiostor: csio_rnode: Add missing description for csio_rnode_fwevt_handler()'s 'fwevt' param Date: Thu, 23 Jul 2020 13:24:30 +0100 Message-Id: <20200723122446.1329773-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/csiostor/csio_rnode.c:869: warning: Function parameter or member 'fwevt' not described in 'csio_rnode_fwevt_handler' Signed-off-by: Lee Jones --- drivers/scsi/csiostor/csio_rnode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/csiostor/csio_rnode.c b/drivers/scsi/csiostor/csio_rnode.c index e9c3b045f5875..713e13adf4dcc 100644 --- a/drivers/scsi/csiostor/csio_rnode.c +++ b/drivers/scsi/csiostor/csio_rnode.c @@ -862,7 +862,7 @@ csio_rnode_devloss_handler(struct csio_rnode *rn) /** * csio_rnode_fwevt_handler - Event handler for firmware rnode events. * @rn: rnode - * + * @fwevt: firmware event to handle */ void csio_rnode_fwevt_handler(struct csio_rnode *rn, uint8_t fwevt) From patchwork Thu Jul 23 12:24:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680799 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 99A0913A4 for ; Thu, 23 Jul 2020 12:25:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F1E622B47 for ; Thu, 23 Jul 2020 12:25:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="K/pgA01j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729015AbgGWMZX (ORCPT ); Thu, 23 Jul 2020 08:25:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729000AbgGWMZV (ORCPT ); Thu, 23 Jul 2020 08:25:21 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D918C0619E5 for ; Thu, 23 Jul 2020 05:25:21 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id y3so4978011wrl.4 for ; Thu, 23 Jul 2020 05:25:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3pqGsbWZalxf7KD6RyeDaCfLDso/eIrkBstcO2+vgts=; b=K/pgA01jiliZZhOHrTKN8/Zxz79yXSGEiM6AmI+DmQHdjzWTJVTI6ok71y2wKeRqwa CxjUa/HChksPObKRNeCFic2v5Nby3SkIwvVOUNAtbwnpK0Nn6TjFEWeAFkTW5NYKRYQ4 9kng0uv0+/p3q4PPKqBneNXfvbmkYugMlhxqfqPM3PUOGwZuRQ6D2CG8mw0QB8cmx7nr TywdbyleGx5DHbaEBZJdD2FZ8gbxqxS7BjMuVpWMbvXb2t9OWFiTa17DBiX7jDOJkAUm 0iN/hQ2M5eT/CPWfy7XK/UX3W03y8Zg9jfMD3O0mA554r5EeeTVETiIXUjOOUSaqbxor v6ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3pqGsbWZalxf7KD6RyeDaCfLDso/eIrkBstcO2+vgts=; b=omVnTGGwjuOYsdVn9i8BPjF4Xz64Ib9aBv+8+Xin0pOWuNnV8fjI2iwX/DL1xjfy24 hSw6mnyvRdLFFvN7OlXN8MbKYy1HDktDscI3Yu4eSj683FGpUGsHIGO7fkpLZ07IoSSV Zt+ZSzZgeyswrymlufV/Ut4bDhNwgKsCZfhCqYxi6hAhtO2Xzx7idn7tyoA1lqicyuey +R+b4b3i9DqR3y8t931jV6E737uYGW1gcpmU1TMM5isgkpjPpQKhmtfZ9gHaobfIoSTj MoYT9MURjXaJcxq0tKGNuqc8QDm/5xW4CamNgqTpi1Wm/X3i+KHQj9+O2NFHD5dUoGCk C2tA== X-Gm-Message-State: AOAM531Ze/jeZETPMI4uMx1mk+R6g+TnNJLZyu6CKf2+THgQ4nJ3W+59 Ykpcyjv3N0Cq3Jfio+cCo0NoGg== X-Google-Smtp-Source: ABdhPJzsoSMrqlqygUNaU5qbgYVAr1Wofya/CH5bMUGwoO5FJdONJmyvmo/qMhP/CfRfi1y2LNMtmg== X-Received: by 2002:adf:e98c:: with SMTP id h12mr3774551wrm.3.1595507119836; Thu, 23 Jul 2020 05:25:19 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:19 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Anil Gurumurthy , Sudarsana Kalluru Subject: [PATCH 25/40] scsi: bfa: bfa_ioc_ct: Demote non-compliant kerneldoc headers to standard comments Date: Thu, 23 Jul 2020 13:24:31 +0100 Message-Id: <20200723122446.1329773-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/bfa/bfa_ioc_ct.c:504: warning: Function parameter or member 'ioc' not described in 'bfa_ioc_set_ctx_hwif' drivers/scsi/bfa/bfa_ioc_ct.c:504: warning: Function parameter or member 'hwif' not described in 'bfa_ioc_set_ctx_hwif' drivers/scsi/bfa/bfa_ioc_ct.c:525: warning: Function parameter or member 'ioc' not described in 'bfa_ioc_set_ct_hwif' drivers/scsi/bfa/bfa_ioc_ct.c:540: warning: Function parameter or member 'ioc' not described in 'bfa_ioc_set_ct2_hwif' Cc: Anil Gurumurthy Cc: Sudarsana Kalluru Signed-off-by: Lee Jones --- drivers/scsi/bfa/bfa_ioc_ct.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/bfa/bfa_ioc_ct.c b/drivers/scsi/bfa/bfa_ioc_ct.c index 6fd3383ee5381..fb748291676b6 100644 --- a/drivers/scsi/bfa/bfa_ioc_ct.c +++ b/drivers/scsi/bfa/bfa_ioc_ct.c @@ -496,7 +496,7 @@ bfa_ioc_ct_sync_complete(struct bfa_ioc_s *ioc) return BFA_FALSE; } -/** +/* * Called from bfa_ioc_attach() to map asic specific calls. */ static void @@ -517,7 +517,7 @@ bfa_ioc_set_ctx_hwif(struct bfa_ioc_s *ioc, struct bfa_ioc_hwif_s *hwif) hwif->ioc_get_alt_fwstate = bfa_ioc_ct_get_alt_ioc_fwstate; } -/** +/* * Called from bfa_ioc_attach() to map asic specific calls. */ void @@ -532,7 +532,7 @@ bfa_ioc_set_ct_hwif(struct bfa_ioc_s *ioc) ioc->ioc_hwif = &hwif_ct; } -/** +/* * Called from bfa_ioc_attach() to map asic specific calls. */ void From patchwork Thu Jul 23 12:24:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680829 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2708513A4 for ; Thu, 23 Jul 2020 12:26:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0EF9920888 for ; Thu, 23 Jul 2020 12:26:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n5oWnYYL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729022AbgGWMZY (ORCPT ); Thu, 23 Jul 2020 08:25:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729008AbgGWMZW (ORCPT ); Thu, 23 Jul 2020 08:25:22 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77F9AC0619E2 for ; Thu, 23 Jul 2020 05:25:22 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id o8so4783587wmh.4 for ; Thu, 23 Jul 2020 05:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BqthC3CkjpgCokdg5o2ILnbULpGQcoT03/Lw3SH2/KA=; b=n5oWnYYLwx2Uu3i0alq76U1+jMa5X1KgGKPO/TNSL8K0wCitWVNvpCZmEgRyCTF22e h+QUo9VHUERd2wQnBkOJ3k6VTgAw5A2dFbwJABl/FuRVTBPxCjlNnAA+f2o+1E+fJsJT NC+b82QbEKW/d8kVIilYYP2tOz6oE4BZzcrxrb9ar0oreWLlsrB6EFmwCO/Fm7fQanQg hTwY6y7bKzzKEWT2XgLSxGCHtR0VfB0Vbm4iESRb8sygG+CI2sQDIM7oA3GzMhJL6Q5l fzIoPpLdiKP1oXZL87RCDcfxpDeeWn0legNEtDCSSEItKTHt+FzTlh5iOYSlrv9YJuTC K1YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BqthC3CkjpgCokdg5o2ILnbULpGQcoT03/Lw3SH2/KA=; b=ZecaVGHvZ5K/PkAnLQG+ZS220y8gPKdAtpU9PJO8mI+RfH8O33/fD3Eg/prL/xGSSD KCR4MO8BAKfcdpoGnf/yPzwgQBie7/kB1zrl+EVWO8Vcf1lCaxL7YGTJLebog+dwizeI hFI5ilf8yQSnQFCkpQc6rrynBxEzIK971s5od45qg0Wa58qJrV61WTqM8Egm7CD43aAr dnZJi3nPyefst+hZYflLUYkL2iTTTF9a6seIN1G9b+Tnzi+rium8guo+tRFZshx889hC R/2yg7cQlL673pnGL5M76K3kFEG5A3AsT5qpUkhnXhhTo5CQyk5m8yQnWrsaUAEff7W0 xH4w== X-Gm-Message-State: AOAM53354hYV6kfSPxezyygwe7GFEnSvnquqzzo0kWTYKHbyfoi0oHq2 sq3qoB6tQ1xM2zIfDHfsYu6EA2BIXqs= X-Google-Smtp-Source: ABdhPJzZGFpzQjekGSiOCnQqa+8ff+FTdUMkmof33vvNKFnGPSmFf+6Fzjt+89if1+VbwoFioQwP+g== X-Received: by 2002:a1c:f407:: with SMTP id z7mr3953367wma.8.1595507121244; Thu, 23 Jul 2020 05:25:21 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:20 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones Subject: [PATCH 26/40] scsi: mvsas: mv_init: Place 'core_nr' inside correct clause Date: Thu, 23 Jul 2020 13:24:32 +0100 Message-Id: <20200723122446.1329773-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org 'core_nr' should be inside the 'ifndef' "if *not* defined", as it is utilised inside the 'else' of the following 'ifdef' "if *is* defined" clause. Signed-off-by: Lee Jones --- drivers/scsi/mvsas/mv_init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c index 3b450319cc11e..978f5283c8835 100644 --- a/drivers/scsi/mvsas/mv_init.c +++ b/drivers/scsi/mvsas/mv_init.c @@ -182,7 +182,6 @@ static irqreturn_t mvs_interrupt(int irq, void *opaque) struct sas_ha_struct *sha = opaque; #ifndef CONFIG_SCSI_MVSAS_TASKLET u32 i; -#else u32 core_nr; core_nr = ((struct mvs_prv_info *)sha->lldd_ha)->n_host; From patchwork Thu Jul 23 12:24:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680827 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 623F113A4 for ; Thu, 23 Jul 2020 12:26:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 488CD22D04 for ; Thu, 23 Jul 2020 12:26:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="firLoT+n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729227AbgGWM0U (ORCPT ); Thu, 23 Jul 2020 08:26:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729018AbgGWMZY (ORCPT ); Thu, 23 Jul 2020 08:25:24 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4D27C0619DC for ; Thu, 23 Jul 2020 05:25:23 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id c80so4795901wme.0 for ; Thu, 23 Jul 2020 05:25:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1PYc82QmZnWYyBRN6HjG0q6jn6xq3+jiiSrC8xShRHw=; b=firLoT+nF6NP5uE7+rwzyF0eexaFUX6j4RXoRWCBz6fwm1F9siOipBBu+l6A/SZAqN RzQOsrxZlyVMpnEbBw5+3PfgrZCHddC6oDGHkcwuNgkOV332k9wn+tamNuINOLQtP15h apcNbIt/16saNXZZTIcDVmM4flz759qo+WrrYDNv56xmVHDnITyjZFE79Rj3o1ANkBQE nFwmTw85LwCzCAXbhD0Sjbuh9WUjU0UNQOBcEfWiTZrj4eTdDeg2a6uq80zOtVEk6yEh SY4hbFsGjBJ+q8EuwsfkEsvLXs11S4efCbIrAQzgUdean0xxF9c0iAtbpRZtY8lFtwqm CGBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1PYc82QmZnWYyBRN6HjG0q6jn6xq3+jiiSrC8xShRHw=; b=EtfOroxgt/Mgpwk8pRX0SQSFmGdxeZaw8Oe5fUeE/v6U/SWYWXlUCLVpagwjsTlwfT 9af9iSfVcx3IPXohWp13BMv6DMdnv/0lcVTW0076/oUbAeptjbXZCmyGGeQIvN7wqodI nMWOOw7+pnZEb8zvshuV02mIHfwEPmQw98QUnJJH5DAoD7WQIjhB1QXPY/j398FIj8Rc QZ3DlvSfBD2H1MDlAkeIpYWQcKNYebAa+SDmKt0eG0zGnVzwb60YcrFNeP8MtfA3AZ8Y vT1p/WFn20KsL/lNjESc3/Qg56juCCkRk0PZpr0iSP44lwiKjO3Pd/JwlybevPC2GEaW Fd1w== X-Gm-Message-State: AOAM530qatxrukwgsDez/ZbpmGnkqqYHju1OYptTeE/W1iwGje1HyTgg uuzfMEmIu2lslyjztM7EdogE/Q== X-Google-Smtp-Source: ABdhPJwhScaiEIGilOpKYn2h+6SXYh8OlBq+1Bh9h3JTndjCEmfDrMIN2qZK+2SwNHeheXjeGFgsIw== X-Received: by 2002:a1c:5418:: with SMTP id i24mr3820464wmb.47.1595507122467; Thu, 23 Jul 2020 05:25:22 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:21 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Anil Gurumurthy , Sudarsana Kalluru Subject: [PATCH 27/40] scsi: bfa: bfa_fcs_rport: Remove unused variable 'adisc' Date: Thu, 23 Jul 2020 13:24:33 +0100 Message-Id: <20200723122446.1329773-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/bfa/bfa_fcs_rport.c: In function ‘bfa_fcs_rport_process_adisc’: drivers/scsi/bfa/bfa_fcs_rport.c:2243:21: warning: variable ‘adisc’ set but not used [-Wunused-but-set-variable] Cc: Anil Gurumurthy Cc: Sudarsana Kalluru Signed-off-by: Lee Jones --- drivers/scsi/bfa/bfa_fcs_rport.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/bfa/bfa_fcs_rport.c b/drivers/scsi/bfa/bfa_fcs_rport.c index fc294e1950a62..143c35bd668c2 100644 --- a/drivers/scsi/bfa/bfa_fcs_rport.c +++ b/drivers/scsi/bfa/bfa_fcs_rport.c @@ -2240,15 +2240,12 @@ bfa_fcs_rport_process_adisc(struct bfa_fcs_rport_s *rport, struct bfa_fcxp_s *fcxp; struct fchs_s fchs; struct bfa_fcs_lport_s *port = rport->port; - struct fc_adisc_s *adisc; bfa_trc(port->fcs, rx_fchs->s_id); bfa_trc(port->fcs, rx_fchs->d_id); rport->stats.adisc_rcvd++; - adisc = (struct fc_adisc_s *) (rx_fchs + 1); - /* * Accept if the itnim for this rport is online. * Else reject the ADISC. From patchwork Thu Jul 23 12:24:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680825 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2186C13B4 for ; Thu, 23 Jul 2020 12:26:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF39F208E4 for ; Thu, 23 Jul 2020 12:26:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L4NPiGsA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729224AbgGWM0Q (ORCPT ); Thu, 23 Jul 2020 08:26:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729027AbgGWMZZ (ORCPT ); Thu, 23 Jul 2020 08:25:25 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A41DC0619E4 for ; Thu, 23 Jul 2020 05:25:25 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id c80so4795971wme.0 for ; Thu, 23 Jul 2020 05:25:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AaZgBLVOS7q2pS/xZr9TUPVbAiWNyUa8nia5ipOZ1l8=; b=L4NPiGsAWDTD1nsJw/ag6ubha3NoEhKHTIsoQP9Z6ez8vCP9hdKkeHZfTo9OPSeI1b G77NktUZ2uR8mccWrmbf8raSXWOxfOG3fg82j+h1WEeIUjGuCEPt8foKFctz/SkQTXXB YDkLkSVNCK3Sp3t4bnlYPFtHwDrpXQ7P1oc2cfkpTXraoJothR1jEZNHpil1slPo4G98 oRohUZQWfvPlnz/FwZLgwcsJk8oOV6zFZ7m29xPr5tKu9+B4uE0LnTnw8fgWX11TZbmf DPrqNnQ9CF7m4gyy2xOAsZbVlpBqrySWbrqqf6VC83tCKlnwv7X7IEZJDpfOGqjKEk9T 4pSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AaZgBLVOS7q2pS/xZr9TUPVbAiWNyUa8nia5ipOZ1l8=; b=Kw2h4G+pWsLlgGnMiX5vRMtuHPPhNBIPvqEhH8PrJlXIpd4Rtckq0eMTyNGT51wreC zKKbTeqZPkjfAOFNQ/tchZXb+iQMjehV+KziHLJCze68H7RZUGrgoR7KeAH5bWnLPZuw asRdWTiPx/cnsaZRRHempc8z0PF/XeMq0DEVcHuiqvyxuOEPSCTNHAme2AoLFDLarbIn FEju5b/MYyh83UtWgmeoMHmcNq3Yurf/+exljtNjLC/gp0n3uSKai9DJkiAqqpwa3qWi va4UOCoSqymCs65JNYCcUsuWF39LmMXrIsjxB2xlBfbMTYm3TEkVvhK+IkQ3mijqQj2k jNHw== X-Gm-Message-State: AOAM532i5C4osuQ3t/OhcjliaGDEU9M/8s7R65bMGDyKviQoHIBsk47+ vfoqfzKWqmxxb9m7h54PLde67A== X-Google-Smtp-Source: ABdhPJyDuBDumRaByCmjSjCph47AToEM6UBkDJ1LMumMb1DZXuohHZ+MbmLdxN0BJoLL3vWs8XrORA== X-Received: by 2002:a1c:a757:: with SMTP id q84mr1701761wme.1.1595507124038; Thu, 23 Jul 2020 05:25:24 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:23 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@qlogic.com, Anil Veerabhadrappa , Eddie Wai Subject: [PATCH 28/40] scsi: bnx2i: bnx2i_hwi: Fix a whole host of kerneldoc issues Date: Thu, 23 Jul 2020 13:24:34 +0100 Message-Id: <20200723122446.1329773-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Mainly renames and docrot issues. Fixes the following W=1 kernel build warning(s): drivers/scsi/bnx2i/bnx2i_hwi.c:194: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_get_rq_buf' drivers/scsi/bnx2i/bnx2i_hwi.c:194: warning: Excess function parameter 'conn' description in 'bnx2i_get_rq_buf' drivers/scsi/bnx2i/bnx2i_hwi.c:232: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_put_rq_buf' drivers/scsi/bnx2i/bnx2i_hwi.c:232: warning: Excess function parameter 'conn' description in 'bnx2i_put_rq_buf' drivers/scsi/bnx2i/bnx2i_hwi.c:269: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_ring_sq_dbell' drivers/scsi/bnx2i/bnx2i_hwi.c:269: warning: Excess function parameter 'conn' description in 'bnx2i_ring_sq_dbell' drivers/scsi/bnx2i/bnx2i_hwi.c:293: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_ring_dbell_update_sq_params' drivers/scsi/bnx2i/bnx2i_hwi.c:293: warning: Excess function parameter 'conn' description in 'bnx2i_ring_dbell_update_sq_params' drivers/scsi/bnx2i/bnx2i_hwi.c:331: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_send_iscsi_login' drivers/scsi/bnx2i/bnx2i_hwi.c:331: warning: Function parameter or member 'task' not described in 'bnx2i_send_iscsi_login' drivers/scsi/bnx2i/bnx2i_hwi.c:331: warning: Excess function parameter 'conn' description in 'bnx2i_send_iscsi_login' drivers/scsi/bnx2i/bnx2i_hwi.c:331: warning: Excess function parameter 'cmd' description in 'bnx2i_send_iscsi_login' drivers/scsi/bnx2i/bnx2i_hwi.c:384: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_send_iscsi_tmf' drivers/scsi/bnx2i/bnx2i_hwi.c:384: warning: Excess function parameter 'conn' description in 'bnx2i_send_iscsi_tmf' drivers/scsi/bnx2i/bnx2i_hwi.c:458: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_send_iscsi_text' drivers/scsi/bnx2i/bnx2i_hwi.c:458: warning: Excess function parameter 'conn' description in 'bnx2i_send_iscsi_text' drivers/scsi/bnx2i/bnx2i_hwi.c:506: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_send_iscsi_scsicmd' drivers/scsi/bnx2i/bnx2i_hwi.c:506: warning: Excess function parameter 'conn' description in 'bnx2i_send_iscsi_scsicmd' drivers/scsi/bnx2i/bnx2i_hwi.c:533: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_send_iscsi_nopout' drivers/scsi/bnx2i/bnx2i_hwi.c:533: warning: Function parameter or member 'task' not described in 'bnx2i_send_iscsi_nopout' drivers/scsi/bnx2i/bnx2i_hwi.c:533: warning: Excess function parameter 'conn' description in 'bnx2i_send_iscsi_nopout' drivers/scsi/bnx2i/bnx2i_hwi.c:533: warning: Excess function parameter 'cmd' description in 'bnx2i_send_iscsi_nopout' drivers/scsi/bnx2i/bnx2i_hwi.c:590: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_send_iscsi_logout' drivers/scsi/bnx2i/bnx2i_hwi.c:590: warning: Function parameter or member 'task' not described in 'bnx2i_send_iscsi_logout' drivers/scsi/bnx2i/bnx2i_hwi.c:590: warning: Excess function parameter 'conn' description in 'bnx2i_send_iscsi_logout' drivers/scsi/bnx2i/bnx2i_hwi.c:590: warning: Excess function parameter 'cmd' description in 'bnx2i_send_iscsi_logout' drivers/scsi/bnx2i/bnx2i_hwi.c:686: warning: Function parameter or member 't' not described in 'bnx2i_ep_ofld_timer' drivers/scsi/bnx2i/bnx2i_hwi.c:686: warning: Excess function parameter 'data' description in 'bnx2i_ep_ofld_timer' drivers/scsi/bnx2i/bnx2i_hwi.c:1672: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_unsol_pdu_adjust_rq' drivers/scsi/bnx2i/bnx2i_hwi.c:1672: warning: Excess function parameter 'conn' description in 'bnx2i_unsol_pdu_adjust_rq' drivers/scsi/bnx2i/bnx2i_hwi.c:1900: warning: Function parameter or member 'session' not described in 'bnx2i_queue_scsi_cmd_resp' drivers/scsi/bnx2i/bnx2i_hwi.c:1900: warning: Function parameter or member 'cqe' not described in 'bnx2i_queue_scsi_cmd_resp' drivers/scsi/bnx2i/bnx2i_hwi.c:2476: warning: Function parameter or member 'context' not described in 'bnx2i_indicate_kcqe' drivers/scsi/bnx2i/bnx2i_hwi.c:2476: warning: Function parameter or member 'kcqe' not described in 'bnx2i_indicate_kcqe' drivers/scsi/bnx2i/bnx2i_hwi.c:2476: warning: Function parameter or member 'num_cqe' not described in 'bnx2i_indicate_kcqe' drivers/scsi/bnx2i/bnx2i_hwi.c:2476: warning: Excess function parameter 'hba' description in 'bnx2i_indicate_kcqe' drivers/scsi/bnx2i/bnx2i_hwi.c:2476: warning: Excess function parameter 'update_kcqe' description in 'bnx2i_indicate_kcqe' drivers/scsi/bnx2i/bnx2i_hwi.c:2624: warning: Function parameter or member 'cm_sk' not described in 'bnx2i_cm_remote_close' drivers/scsi/bnx2i/bnx2i_hwi.c:2624: warning: Excess function parameter 'hba' description in 'bnx2i_cm_remote_close' drivers/scsi/bnx2i/bnx2i_hwi.c:2624: warning: Excess function parameter 'update_kcqe' description in 'bnx2i_cm_remote_close' drivers/scsi/bnx2i/bnx2i_hwi.c:2641: warning: Function parameter or member 'cm_sk' not described in 'bnx2i_cm_remote_abort' drivers/scsi/bnx2i/bnx2i_hwi.c:2641: warning: Excess function parameter 'hba' description in 'bnx2i_cm_remote_abort' drivers/scsi/bnx2i/bnx2i_hwi.c:2641: warning: Excess function parameter 'update_kcqe' description in 'bnx2i_cm_remote_abort' drivers/scsi/bnx2i/bnx2i_hwi.c:2677: warning: cannot understand function prototype: 'struct cnic_ulp_ops bnx2i_cnic_cb = ' Cc: QLogic-Storage-Upstream@qlogic.com Cc: Anil Veerabhadrappa Cc: Eddie Wai Signed-off-by: Lee Jones --- drivers/scsi/bnx2i/bnx2i_hwi.c | 53 +++++++++++++++++----------------- 1 file changed, 27 insertions(+), 26 deletions(-) diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c b/drivers/scsi/bnx2i/bnx2i_hwi.c index e53ebc5eff85e..bad396e5c6014 100644 --- a/drivers/scsi/bnx2i/bnx2i_hwi.c +++ b/drivers/scsi/bnx2i/bnx2i_hwi.c @@ -181,7 +181,7 @@ int bnx2i_arm_cq_event_coalescing(struct bnx2i_endpoint *ep, u8 action) /** * bnx2i_get_rq_buf - copy RQ buffer contents to driver buffer - * @conn: iscsi connection on which RQ event occurred + * @bnx2i_conn: iscsi connection on which RQ event occurred * @ptr: driver buffer to which RQ buffer contents is to * be copied * @len: length of valid data inside RQ buf @@ -223,7 +223,7 @@ static void bnx2i_ring_577xx_doorbell(struct bnx2i_conn *conn) /** * bnx2i_put_rq_buf - Replenish RQ buffer, if required ring on chip doorbell - * @conn: iscsi connection on which event to post + * @bnx2i_conn: iscsi connection on which event to post * @count: number of RQ buffer being posted to chip * * No need to ring hardware doorbell for 57710 family of devices @@ -258,7 +258,7 @@ void bnx2i_put_rq_buf(struct bnx2i_conn *bnx2i_conn, int count) /** * bnx2i_ring_sq_dbell - Ring SQ doorbell to wake-up the processing engine - * @conn: iscsi connection to which new SQ entries belong + * @bnx2i_conn: iscsi connection to which new SQ entries belong * @count: number of SQ WQEs to post * * SQ DB is updated in host memory and TX Doorbell is rung for 57710 family @@ -283,7 +283,7 @@ static void bnx2i_ring_sq_dbell(struct bnx2i_conn *bnx2i_conn, int count) /** * bnx2i_ring_dbell_update_sq_params - update SQ driver parameters - * @conn: iscsi connection to which new SQ entries belong + * @bnx2i_conn: iscsi connection to which new SQ entries belong * @count: number of SQ WQEs to post * * this routine will update SQ driver parameters and ring the doorbell @@ -320,9 +320,9 @@ static void bnx2i_ring_dbell_update_sq_params(struct bnx2i_conn *bnx2i_conn, /** * bnx2i_send_iscsi_login - post iSCSI login request MP WQE to hardware - * @conn: iscsi connection - * @cmd: driver command structure which is requesting - * a WQE to sent to chip for further processing + * @bnx2i_conn: iscsi connection + * @task: transport layer's command structure pointer which is requesting + * a WQE to sent to chip for further processing * * prepare and post an iSCSI Login request WQE to CNIC firmware */ @@ -373,7 +373,7 @@ int bnx2i_send_iscsi_login(struct bnx2i_conn *bnx2i_conn, /** * bnx2i_send_iscsi_tmf - post iSCSI task management request MP WQE to hardware - * @conn: iscsi connection + * @bnx2i_conn: iscsi connection * @mtask: driver command structure which is requesting * a WQE to sent to chip for further processing * @@ -447,7 +447,7 @@ int bnx2i_send_iscsi_tmf(struct bnx2i_conn *bnx2i_conn, /** * bnx2i_send_iscsi_text - post iSCSI text WQE to hardware - * @conn: iscsi connection + * @bnx2i_conn: iscsi connection * @mtask: driver command structure which is requesting * a WQE to sent to chip for further processing * @@ -495,7 +495,7 @@ int bnx2i_send_iscsi_text(struct bnx2i_conn *bnx2i_conn, /** * bnx2i_send_iscsi_scsicmd - post iSCSI scsicmd request WQE to hardware - * @conn: iscsi connection + * @bnx2i_conn: iscsi connection * @cmd: driver command structure which is requesting * a WQE to sent to chip for further processing * @@ -517,9 +517,9 @@ int bnx2i_send_iscsi_scsicmd(struct bnx2i_conn *bnx2i_conn, /** * bnx2i_send_iscsi_nopout - post iSCSI NOPOUT request WQE to hardware - * @conn: iscsi connection - * @cmd: driver command structure which is requesting - * a WQE to sent to chip for further processing + * @bnx2i_conn: iscsi connection + * @task: transport layer's command structure pointer which is + * requesting a WQE to sent to chip for further processing * @datap: payload buffer pointer * @data_len: payload data length * @unsol: indicated whether nopout pdu is unsolicited pdu or @@ -579,9 +579,9 @@ int bnx2i_send_iscsi_nopout(struct bnx2i_conn *bnx2i_conn, /** * bnx2i_send_iscsi_logout - post iSCSI logout request WQE to hardware - * @conn: iscsi connection - * @cmd: driver command structure which is requesting - * a WQE to sent to chip for further processing + * @bnx2i_conn: iscsi connection + * @task: transport layer's command structure pointer which is + * requesting a WQE to sent to chip for further processing * * prepare and post logout request WQE to CNIC firmware */ @@ -678,7 +678,8 @@ void bnx2i_update_iscsi_conn(struct iscsi_conn *conn) /** * bnx2i_ep_ofld_timer - post iSCSI logout request WQE to hardware - * @data: endpoint (transport handle) structure pointer + * @t: timer context used to fetch the endpoint (transport + * handle) structure pointer * * routine to handle connection offload/destroy request timeout */ @@ -1662,7 +1663,7 @@ static void bnx2i_process_nopin_local_cmpl(struct iscsi_session *session, /** * bnx2i_unsol_pdu_adjust_rq - makes adjustments to RQ after unsol pdu is recvd - * @conn: iscsi connection + * @bnx2i_conn: iscsi connection * * Firmware advances RQ producer index for every unsolicited PDU even if * payload data length is '0'. This function makes corresponding @@ -1885,7 +1886,9 @@ int bnx2i_percpu_io_thread(void *arg) /** * bnx2i_queue_scsi_cmd_resp - queue cmd completion to the percpu thread + * @session: iscsi session * @bnx2i_conn: bnx2i connection + * @cqe: pointer to newly DMA'ed CQE entry for processing * * this function is called by generic KCQ handler to queue all pending cmd * completion CQEs @@ -2466,8 +2469,9 @@ static void bnx2i_process_ofld_cmpl(struct bnx2i_hba *hba, /** * bnx2i_indicate_kcqe - process iscsi conn update completion KCQE - * @hba: adapter structure pointer - * @update_kcqe: kcqe pointer + * @context: adapter structure pointer + * @kcqe: kcqe pointer + * @num_cqe: number of kcqes to process * * Generic KCQ event handler/dispatcher */ @@ -2614,8 +2618,7 @@ static void bnx2i_cm_abort_cmpl(struct cnic_sock *cm_sk) /** * bnx2i_cm_remote_close - process received TCP FIN - * @hba: adapter structure pointer - * @update_kcqe: kcqe pointer + * @cm_sk: cnic sock structure pointer * * function callback exported via bnx2i - cnic driver interface to indicate * async TCP events such as FIN @@ -2631,8 +2634,7 @@ static void bnx2i_cm_remote_close(struct cnic_sock *cm_sk) /** * bnx2i_cm_remote_abort - process TCP RST and start conn cleanup - * @hba: adapter structure pointer - * @update_kcqe: kcqe pointer + * @cm_sk: cnic sock structure pointer * * function callback exported via bnx2i - cnic driver interface to * indicate async TCP events (RST) sent by the peer. @@ -2669,10 +2671,9 @@ static int bnx2i_send_nl_mesg(void *context, u32 msg_type, } -/** +/* * bnx2i_cnic_cb - global template of bnx2i - cnic driver interface structure * carrying callback function pointers - * */ struct cnic_ulp_ops bnx2i_cnic_cb = { .cnic_init = bnx2i_ulp_init, From patchwork Thu Jul 23 12:24:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680821 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E2DF413A4 for ; Thu, 23 Jul 2020 12:26:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2F88208E4 for ; Thu, 23 Jul 2020 12:26:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Us3D32gP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729041AbgGWMZ2 (ORCPT ); Thu, 23 Jul 2020 08:25:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729032AbgGWMZ1 (ORCPT ); Thu, 23 Jul 2020 08:25:27 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CE8CC0619E6 for ; Thu, 23 Jul 2020 05:25:26 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id 9so4774084wmj.5 for ; Thu, 23 Jul 2020 05:25:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Y7MiQFR4MfIftYnbJz642q1pbyBNEj9l/lt1l++SzIE=; b=Us3D32gPY+JYnXjK++12vZVZDsA2wXNOc9+OYP8A3BePDPwztRgB5/Z/8IAizc97X8 nKosVGZ9N+dVKncBJjX433ecd0HYtaZ0zTUjtqgi2JAWtEIHEjrSDa1JZQCVzqMYHExW 2fTUrUmz7ey6c01MHFuKqbLY5uBwj3NKh+7F0pIrL0RsdKuXIpxlS7EvGmsa4P24aGWZ avIAkIAnxjVTvxYIF4cX3zHHwfitNVezEEnnRyzFNOsn1wXfCanvLpbtR7F6MP4gGsLK VeSUgNdufmcTSewKqZD1d1f91zqBK2q13hmqogTzrClLfFGeT1nYIgIt4KeVDJlreBKM SWsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y7MiQFR4MfIftYnbJz642q1pbyBNEj9l/lt1l++SzIE=; b=uPplsrHHn0vjGNQ85EmbcyL0/UuVmIIl9nt/5cvsP1LQ0XJJNTqQcI61xD1sXkl02y /Q5S38IKuGx1l+9zuqRFDyaJAQtGKKsZvbgzViJuu6kXXkKa9ivwp3NyyerB+BYRckG9 gYOqgczXiob3J++gb3RoMEBjCx6avJNyuIKDHZ31zUPJaV77VTwkGBaBvn48MjPpm3vV nF5EqFOYSQI338aiIZjS0uJRAJGdb6MhMR8JD8AWhB6G9DvhjWObDnovYIvrLu1/zR2o MZApzjUrqsywpmtbhlR4V+rY3mkqci1wwwgWopti08Hzcbisqv4YwBwKmkn5wLjTcEpK TpDg== X-Gm-Message-State: AOAM531XQPsOPlbqxShidpXBfIPIciZ4x/LA2Z17o7OwmyQ+VrNTZPLt y7Y/BdTiAMUJwTlfMSM15aCAJpc3CL8= X-Google-Smtp-Source: ABdhPJxyBGe1nMpgAfryelJs043nAKgZqFOm/9SzGkYtuj/ijflWgyidPoOtx4LGTcj4cCrr53AX1Q== X-Received: by 2002:a1c:750a:: with SMTP id o10mr4120196wmc.165.1595507125085; Thu, 23 Jul 2020 05:25:25 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:24 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@qlogic.com, Anil Veerabhadrappa , Eddie Wai Subject: [PATCH 29/40] scsi: bnx2i: bnx2i_iscsi: Add, remove and edit some function parameter descriptions Date: Thu, 23 Jul 2020 13:24:35 +0100 Message-Id: <20200723122446.1329773-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/bnx2i/bnx2i_iscsi.c:241: warning: Function parameter or member 'bnx2i_conn' not described in 'bnx2i_bind_conn_to_iscsi_cid' drivers/scsi/bnx2i/bnx2i_iscsi.c:241: warning: Excess function parameter 'conn' description in 'bnx2i_bind_conn_to_iscsi_cid' drivers/scsi/bnx2i/bnx2i_iscsi.c:470: warning: Excess function parameter 'cmd' description in 'bnx2i_destroy_cmd_pool' drivers/scsi/bnx2i/bnx2i_iscsi.c:595: warning: Function parameter or member 'cls_session' not described in 'bnx2i_drop_session' drivers/scsi/bnx2i/bnx2i_iscsi.c:595: warning: Excess function parameter 'hba' description in 'bnx2i_drop_session' drivers/scsi/bnx2i/bnx2i_iscsi.c:595: warning: Excess function parameter 'session' description in 'bnx2i_drop_session' drivers/scsi/bnx2i/bnx2i_iscsi.c:1290: warning: Function parameter or member 'ep' not described in 'bnx2i_session_create' drivers/scsi/bnx2i/bnx2i_iscsi.c:1979: warning: Function parameter or member 'bnx2i_ep' not described in 'bnx2i_ep_tcp_conn_active' drivers/scsi/bnx2i/bnx2i_iscsi.c:1979: warning: Excess function parameter 'ep' description in 'bnx2i_ep_tcp_conn_active' drivers/scsi/bnx2i/bnx2i_iscsi.c:2178: warning: Function parameter or member 'shost' not described in 'bnx2i_nl_set_path' drivers/scsi/bnx2i/bnx2i_iscsi.c:2178: warning: Function parameter or member 'params' not described in 'bnx2i_nl_set_path' drivers/scsi/bnx2i/bnx2i_iscsi.c:2178: warning: Excess function parameter 'buf' description in 'bnx2i_nl_set_path' Cc: QLogic-Storage-Upstream@qlogic.com Cc: Anil Veerabhadrappa Cc: Eddie Wai Signed-off-by: Lee Jones --- drivers/scsi/bnx2i/bnx2i_iscsi.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c index 0b28d44d35738..a9ffd89ec2c85 100644 --- a/drivers/scsi/bnx2i/bnx2i_iscsi.c +++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c @@ -228,7 +228,7 @@ static void bnx2i_setup_cmd_wqe_template(struct bnx2i_cmd *cmd) /** * bnx2i_bind_conn_to_iscsi_cid - bind conn structure to 'iscsi_cid' * @hba: pointer to adapter instance - * @conn: pointer to iscsi connection + * @bnx2i_conn: pointer to iscsi connection * @iscsi_cid: iscsi context ID, range 0 - (MAX_CONN - 1) * * update iscsi cid table entry with connection pointer. This enables @@ -463,7 +463,6 @@ static int bnx2i_alloc_bdt(struct bnx2i_hba *hba, struct iscsi_session *session, * bnx2i_destroy_cmd_pool - destroys iscsi command pool and release BD table * @hba: adapter instance pointer * @session: iscsi session pointer - * @cmd: iscsi command structure */ static void bnx2i_destroy_cmd_pool(struct bnx2i_hba *hba, struct iscsi_session *session) @@ -582,8 +581,7 @@ static void bnx2i_free_mp_bdt(struct bnx2i_hba *hba) /** * bnx2i_drop_session - notifies iscsid of connection error. - * @hba: adapter instance pointer - * @session: iscsi session pointer + * @cls_session: iscsi cls session pointer * * This notifies iscsid that there is a error, so it can initiate * recovery. @@ -1277,7 +1275,7 @@ static int bnx2i_task_xmit(struct iscsi_task *task) /** * bnx2i_session_create - create a new iscsi session - * @cmds_max: max commands supported + * @ep: pointer to iscsi endpoint * @qdepth: scsi queue depth to support * @initial_cmdsn: initial iscsi CMDSN to be used for this session * @@ -1971,7 +1969,7 @@ static int bnx2i_ep_poll(struct iscsi_endpoint *ep, int timeout_ms) /** * bnx2i_ep_tcp_conn_active - check EP state transition - * @ep: endpoint pointer + * @bnx2i_ep: endpoint pointer * * check if underlying TCP connection is active */ @@ -2014,9 +2012,9 @@ static int bnx2i_ep_tcp_conn_active(struct bnx2i_endpoint *bnx2i_ep) } -/* +/** * bnx2i_hw_ep_disconnect - executes TCP connection teardown process in the hw - * @ep: TCP connection (bnx2i endpoint) handle + * @bnx2i_ep: TCP connection (bnx2i endpoint) handle * * executes TCP connection teardown process */ @@ -2171,8 +2169,8 @@ static void bnx2i_ep_disconnect(struct iscsi_endpoint *ep) /** * bnx2i_nl_set_path - ISCSI_UEVENT_PATH_UPDATE user message handler + * @shost: scsi host pointer * @buf: pointer to buffer containing iscsi path message - * */ static int bnx2i_nl_set_path(struct Scsi_Host *shost, struct iscsi_path *params) { From patchwork Thu Jul 23 12:24:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680823 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E666A13B4 for ; Thu, 23 Jul 2020 12:26:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA6F7208E4 for ; Thu, 23 Jul 2020 12:26:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qGEL1ZmY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729215AbgGWM0O (ORCPT ); Thu, 23 Jul 2020 08:26:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729036AbgGWMZ1 (ORCPT ); Thu, 23 Jul 2020 08:25:27 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A5ABC0619E2 for ; Thu, 23 Jul 2020 05:25:27 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id y24so831018wma.1 for ; Thu, 23 Jul 2020 05:25:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dtzC5u0r7cORZLMw7eZngfMR6JkHvPGqNAQq20+N2tc=; b=qGEL1ZmYUfBiDZiWxlZxuB6qr6hQsxzYePUc+b8Gsvv87mWcVlT/clhtFrFRAOGujY VOgLg2Gtt7uLYioLPcdY2grEozYSe83Qysang7VzaNzaOD73ywv+4Fbpl9ouAxJhrVVt GHw31Ugsmn6ZOfHBQ2dT4Uumnn1dCvu6/K6TCq531Mw2aGelLDZDey1D2xeqjcIf1tx1 9GH1MgO79f/Vf9qN4Bmczgaf7aI66cZpEg0rl5Ku77vWoy68vJ4U6IgKIaDHzGT1LSoA jkBcxZXFYa0Qjlc5h2VxOuZeqaAsXfFlEy2cKRDK6mFO46KMdYXsjuDPYGjThoO4fDhO 4BqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dtzC5u0r7cORZLMw7eZngfMR6JkHvPGqNAQq20+N2tc=; b=hCvQi6XJA+PIryoseNsGQN2LUUn/eK9OtlDY7l4pVncrpDOodSqGT2S7DB7HbSFN5j ziEMaCMKS/Uvnudxh8V01im1EOZ02dJttZ53tz9q1hClXEgB0IfhqreFg8SlmC6FYkf0 6gRqP/vO9P7it76lDuIY2EdL3MOfyxnis0CXlzoRRExXkja5DSL/dcHE901nHK17cBnz cm1Iw/X2LibfDTRJ3CBrR/vwaeE6VoWjcrgbYqpMvQRs5C97YHAvrtJGAGGkIZO7Ks2u 1BqjQR3hSz5VcNev95exRg8S3ZhBfxFABRGRY3+3Bu/eJ2700oKM103Gvp1fuxwec/Kh 4DDw== X-Gm-Message-State: AOAM532aekRylHgudWP2xFrMhYEZJPznK9jtXZI5cr1woL3+eUvG0nep OiVk1aMj6lqnc9XurW6MqK2qWQ== X-Google-Smtp-Source: ABdhPJxlMYmTDD3cQQm650BaKwiiTRBZG+rIvReTeprEqxejxDZtonFFvCoZY7pci/I27R9z9gBvyw== X-Received: by 2002:a7b:cd90:: with SMTP id y16mr3954567wmj.20.1595507126399; Thu, 23 Jul 2020 05:25:26 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:25 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Subbu Seetharaman , Ketan Mukadam , Jitendra Bhivare , linux-drivers@broadcom.com Subject: [PATCH 30/40] scsi: be2iscsi: be_iscsi: Correct misdocumentation of function param 'ep' Date: Thu, 23 Jul 2020 13:24:36 +0100 Message-Id: <20200723122446.1329773-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/be2iscsi/be_iscsi.c:1042: warning: Function parameter or member 'ep' not described in 'beiscsi_open_conn' drivers/scsi/be2iscsi/be_iscsi.c:1042: warning: Excess function parameter 'beiscsi_ep' description in 'beiscsi_open_conn' Cc: Subbu Seetharaman Cc: Ketan Mukadam Cc: Jitendra Bhivare Cc: linux-drivers@broadcom.com Signed-off-by: Lee Jones --- drivers/scsi/be2iscsi/be_iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_iscsi.c b/drivers/scsi/be2iscsi/be_iscsi.c index fe10575bce7f0..93da6344424dd 100644 --- a/drivers/scsi/be2iscsi/be_iscsi.c +++ b/drivers/scsi/be2iscsi/be_iscsi.c @@ -1029,7 +1029,7 @@ static void beiscsi_free_ep(struct beiscsi_endpoint *beiscsi_ep) /** * beiscsi_open_conn - Ask FW to open a TCP connection - * @beiscsi_ep: pointer to device endpoint struct + * @ep: pointer to device endpoint struct * @src_addr: The source IP address * @dst_addr: The Destination IP address * @non_blocking: blocking or non-blocking call From patchwork Thu Jul 23 12:24:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680819 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DB4F213B4 for ; Thu, 23 Jul 2020 12:26:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2C2C208E4 for ; Thu, 23 Jul 2020 12:26:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="p6b8PeJs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729204AbgGWM0I (ORCPT ); Thu, 23 Jul 2020 08:26:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729048AbgGWMZ3 (ORCPT ); Thu, 23 Jul 2020 08:25:29 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05B3AC0619E2 for ; Thu, 23 Jul 2020 05:25:29 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id 184so5022898wmb.0 for ; Thu, 23 Jul 2020 05:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=duCZHMtFtzXyExTB0Q+GFLV/xuB9l4Kwhqee+hE7dLA=; b=p6b8PeJsRy24yesc+jDHDCth5H78oH46TXSpWJZbKpx2gl2sHbf6+G4Zf3tTMTd5wG felIDQJm3gax6G04NzCKrDn3bPW0GP/sdmSkdMNWcDQf21x66X5T7xQGe9sh2TQub5S5 BJE0FB+lKwSkoatc+Rl/X+vvcEZz9uDbV/g7WX5rWzcuO/qbZZ7GTxGYwvZBPvazZPVW R8842FCKWP7O2UtL3Zw0Hki5lNq/XRt/nVfLA9APCoLIrHLQEdUQet5LRcJDsfXwHEmo oUrP9MIaPgd2VY8yDP/KVBjjT0nGVVXk9aDYjnlFMdMVMrjVzXTS3Sa52EZ2386Qf6eO 7oRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=duCZHMtFtzXyExTB0Q+GFLV/xuB9l4Kwhqee+hE7dLA=; b=ukGJnL22oaWQgC8Wuw812ZK/cNXpcVmBRMre9tKLFKAjytTi0jBiL+PGv4z2MzRPGO AQmh9H6GvbLJq+94/tsLH4MfIAbYHb8xR1qolg0FOcouBxRPr3jCUasadPkDVjuPEU30 aJchoDpBVY4aNHHuLaPSe11VTyd8llYamTtC4ntwxnU1cxV6rHM6pbyxGP4uVbClFY9e CxIKQBGzi7dAb+IVbERqIh5DwEyNZls6Y1uiq+S47smmn5Sur1X03SiixWeXaalon0hR rLULnNToJi7E8DssBS1k37rltsG5hlMQPYM73RyKAPQaoxBGPMzaZ6eTiom+fPGniFao 08jA== X-Gm-Message-State: AOAM531PXNtD3tFadUvSYRyrtRcEE6/8VscVBYuLWALEsUS+cwGx6NEi CzAiT2BscZ949Sokwr2M6PhqdQ== X-Google-Smtp-Source: ABdhPJwoU/9ZYtQP3da4TAPZiJq17uJJDvfGmbb1oGeN6ilrPX5HaT+1czWksFkgqvlwrD0VhWgQQw== X-Received: by 2002:a1c:790c:: with SMTP id l12mr3922801wme.50.1595507127792; Thu, 23 Jul 2020 05:25:27 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:27 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@cavium.com Subject: [PATCH 31/40] scsi: qedi: qedi_fw: Remove set but unused variable 'tmp' Date: Thu, 23 Jul 2020 13:24:37 +0100 Message-Id: <20200723122446.1329773-32-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/qedi/qedi_fw.c: In function ‘qedi_put_rq_bdq_buf’: drivers/scsi/qedi/qedi_fw.c:355:6: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] Cc: QLogic-Storage-Upstream@cavium.com Signed-off-by: Lee Jones --- drivers/scsi/qedi/qedi_fw.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedi/qedi_fw.c b/drivers/scsi/qedi/qedi_fw.c index 946cebc4c9322..6ed74583b1b9b 100644 --- a/drivers/scsi/qedi/qedi_fw.c +++ b/drivers/scsi/qedi/qedi_fw.c @@ -352,7 +352,6 @@ static void qedi_put_rq_bdq_buf(struct qedi_ctx *qedi, struct iscsi_cqe_unsolicited *cqe, int count) { - u16 tmp; u16 idx = 0; struct scsi_bd *pbl; @@ -381,10 +380,10 @@ static void qedi_put_rq_bdq_buf(struct qedi_ctx *qedi, qedi->bdq_prod_idx += count; writew(qedi->bdq_prod_idx, qedi->bdq_primary_prod); - tmp = readw(qedi->bdq_primary_prod); + readw(qedi->bdq_primary_prod); writew(qedi->bdq_prod_idx, qedi->bdq_secondary_prod); - tmp = readw(qedi->bdq_secondary_prod); + readw(qedi->bdq_secondary_prod); } static void qedi_unsol_pdu_adjust_bdq(struct qedi_ctx *qedi, From patchwork Thu Jul 23 12:24:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680817 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0A5A113A4 for ; Thu, 23 Jul 2020 12:26:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E657022B43 for ; Thu, 23 Jul 2020 12:26:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DSA8Goh5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729201AbgGWM0I (ORCPT ); Thu, 23 Jul 2020 08:26:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729056AbgGWMZa (ORCPT ); Thu, 23 Jul 2020 08:25:30 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2715DC0619E2 for ; Thu, 23 Jul 2020 05:25:30 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id z15so4956723wrl.8 for ; Thu, 23 Jul 2020 05:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KfRjcVBQyIVpnmla/CO/rMmBV1Hu/Ib2qrKAPkp0wCE=; b=DSA8Goh5xSOvhp7gnzWJuGcX7RYXFFEc1KuCxdCEqA3DFTXzzlZCpu24uIQcE1ETxN WGqf7bnJ6O8tRMJh376Te3uLSd6JUNozEnnO4034E6o5Ay6++hq1s5zqCyzQMd0gIYQs LqQv2JY4Xe1KHsv4gbaN/LFGrH/MdgP7i06vAOKu4n8A7fCYCI60Kr+poaI20VmqmEV3 v9mEFsDfU5pE2WcIY2AOzc5L+r6BFDrDoT/6SBLLan4gqWQvtVab/CRb8gGemagLkVfM FEeYhuHITJqIkYfxwFAZGuTThQGZ7IwpHDjrfb5DBymj15B3uK2FxttvmVYeih+SAnX7 N+1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KfRjcVBQyIVpnmla/CO/rMmBV1Hu/Ib2qrKAPkp0wCE=; b=Mh6QA3AyOZIxi5Ag2+o05CtkqBAJpSUF5UlkmV8nXHTLdprdMx3W33rVVsrvrRDbZd OFYEGMXlgxyYj6cfUqHP3lurX9IHY2bfJo8PYJ6fOi9kyy33NyGp/ySDPkUQzCc6vK2n 4G8D7LtPFn9/qFuhFE9YAzuf9B1vuu1bf99hlka87hKFgR37I7YXMlXx3vTYopj4d0wl pg2TO1pUmbNMSGLYKR9hd7uta0uUmC59s7D1yCv19EbyTOM8CIj39o1jW4uWG4L3ekho /k1o0kxbbsUbmYm9zJmuPjmNhlhLJ5Rml6CHyD3808lI+i6OdKcZUaFaZUaEkz65TPdv sq4g== X-Gm-Message-State: AOAM531cWORgnF1QIqNodQre+WHRDinmqKDVSJpYCa7V6RxSyWMkw5lY vWCWMMG15BH9NS2fHyDP4GtcVT0hfGA= X-Google-Smtp-Source: ABdhPJwUDa3jAas4QHzpdFeBjvzWKbSJh44OokxCvtuT5rUq+RvFpNpBowdKGw7jam8C/fw0zKeLhg== X-Received: by 2002:adf:90ea:: with SMTP id i97mr3870556wri.102.1595507128920; Thu, 23 Jul 2020 05:25:28 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:28 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Bradley Grove Subject: [PATCH 32/40] scsi: esas2r: esas2r: Add braces around the one-line if() Date: Thu, 23 Jul 2020 13:24:38 +0100 Message-Id: <20200723122446.1329773-33-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org In certain configurations esas2r_bugon() is sometimes NULLed by the compiler. Fixes the following W=1 kernel build warning(s): In file included from drivers/scsi/esas2r/esas2r_log.c:44: drivers/scsi/esas2r/esas2r.h: In function ‘esas2r_rq_init_request’: drivers/scsi/esas2r/esas2r.h:1229:17: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] 1229 | esas2r_bugon(); | ^ NB: Lots of these - snipped for brevity Cc: Bradley Grove Signed-off-by: Lee Jones --- drivers/scsi/esas2r/esas2r.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/esas2r/esas2r.h b/drivers/scsi/esas2r/esas2r.h index 7f43b95f4e945..e30d2f1f53685 100644 --- a/drivers/scsi/esas2r/esas2r.h +++ b/drivers/scsi/esas2r/esas2r.h @@ -1225,8 +1225,9 @@ static inline void esas2r_rq_init_request(struct esas2r_request *rq, /* req_table entry should be NULL at this point - if not, halt */ - if (a->req_table[LOWORD(vrq->scsi.handle)]) + if (a->req_table[LOWORD(vrq->scsi.handle)]) { esas2r_bugon(); + } /* fill in the table for this handle so we can get back to the * request. From patchwork Thu Jul 23 12:24:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680815 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 817E213B4 for ; Thu, 23 Jul 2020 12:26:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 632E722D04 for ; Thu, 23 Jul 2020 12:26:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kyiVKBqF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729195AbgGWM0E (ORCPT ); Thu, 23 Jul 2020 08:26:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729079AbgGWMZb (ORCPT ); Thu, 23 Jul 2020 08:25:31 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59BCBC0619E5 for ; Thu, 23 Jul 2020 05:25:31 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id 9so4774272wmj.5 for ; Thu, 23 Jul 2020 05:25:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B2RqnTIG0uteLiyJB2KJla0FyHDSlH3XX5iZpJkogwU=; b=kyiVKBqFHyRIZ1JMpgAVtFSaEM23aouz0l5QQ49XYc2VCwG+/kgIftAS8DqXDBL5AU qd6V5yeI3N5++kJJJmHDEXW5XzlDzOX1DHnPr7NLQAktoJDF3hM1dro0LkJNM9WeVNva +BcwpmB1t2NLLGafuFKHrCF2cHKxiyC6AncSTxHOQrASL25IkuYpPuQzAdRtZ6zpWvGt zCxZ9yOUH9ZUCLSt7qrc2IwPEYpxxUeg703CkVjjWjGEkw90tzfXLIM1lLsgmskzaGwL uEruf6nUfzvy42sacxgrTTJ0r7+6fu39ReYjNpmtC5OYJcgypdXM5lHeAYropnacPtvs VRWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B2RqnTIG0uteLiyJB2KJla0FyHDSlH3XX5iZpJkogwU=; b=JdpYAghPMSpn+dD8wqtfA0s5W6VOTzkBDnp+mv6+jbT9fJzBBh17KEUQ8azdlfQ3xK cA7S53BaqMqVMHTC00u+f9TB9KFrtyodLj1LWcVPBNxxKpTpQhLXOO1tpt8IfiQ2QIv1 wxNmPD6BXuLNiTq6ldpHfKSuhXIcrYIXKy+hI3SGE17QeLaXxsrH7//6Ih3SU9AuzuaO AShh6K6ZhqTqMD0oB04lLLkUQmDI+SxU0RTd+sHhbCtXhbU9ra9+j+jZO9lTRGDrP2C6 KhWeIHQ7yLev6RGB7T2gSEQyqQINCbnKxakf/WStfJ6ZDtJDjaPKzyQk0trCCeySAgE6 /pVQ== X-Gm-Message-State: AOAM5316QaukFGWhLNhGDChvGehsUJRShEHGwnUzZSfSF6NdkPof7bgs bEYB/GvfH+Zktl7RBs44Kc8jyA== X-Google-Smtp-Source: ABdhPJy/2FZPI2tqrty53VNSn9/ithCZuQ+O91QiKWyLh6bBIfkjYia8sXFXtYA1gT9kiyO+t+M/qQ== X-Received: by 2002:a1c:7719:: with SMTP id t25mr4166425wmi.144.1595507130048; Thu, 23 Jul 2020 05:25:30 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:29 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Anil Gurumurthy , Sudarsana Kalluru Subject: [PATCH 33/40] scsi: bfa: bfa_ioc: Demote non-kerneldoc headers down to standard comment blocks Date: Thu, 23 Jul 2020 13:24:39 +0100 Message-Id: <20200723122446.1329773-34-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org This is probably historical (Doxygen?). Fixes the following W=1 kernel build warning(s): drivers/scsi/bfa/bfa_ioc.c:6646: warning: Cannot understand * @brief hardware error definition drivers/scsi/bfa/bfa_ioc.c:6661: warning: Cannot understand * @brief flash command register data structure drivers/scsi/bfa/bfa_ioc.c:6685: warning: Cannot understand * @brief flash device status register data structure drivers/scsi/bfa/bfa_ioc.c:6711: warning: Cannot understand * @brief flash address register data structure drivers/scsi/bfa/bfa_ioc.c:6732: warning: Function parameter or member 'pci_bar' not described in 'bfa_flash_set_cmd' drivers/scsi/bfa/bfa_ioc.c:6732: warning: Function parameter or member 'wr_cnt' not described in 'bfa_flash_set_cmd' drivers/scsi/bfa/bfa_ioc.c:6732: warning: Function parameter or member 'rd_cnt' not described in 'bfa_flash_set_cmd' drivers/scsi/bfa/bfa_ioc.c:6732: warning: Function parameter or member 'ad_cnt' not described in 'bfa_flash_set_cmd' drivers/scsi/bfa/bfa_ioc.c:6732: warning: Function parameter or member 'op' not described in 'bfa_flash_set_cmd' drivers/scsi/bfa/bfa_ioc.c:6768: warning: Cannot understand * @brief drivers/scsi/bfa/bfa_ioc.c:6807: warning: Cannot understand * @brief drivers/scsi/bfa/bfa_ioc.c:6852: warning: Cannot understand * @brief drivers/scsi/bfa/bfa_ioc.c:6898: warning: Cannot understand * @brief drivers/scsi/bfa/bfa_ioc.c:6914: warning: Cannot understand * @brief drivers/scsi/bfa/bfa_ioc.c:6940: warning: Cannot understand * @brief Cc: Anil Gurumurthy Cc: Sudarsana Kalluru Signed-off-by: Lee Jones --- drivers/scsi/bfa/bfa_ioc.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/scsi/bfa/bfa_ioc.c index 10c12b5a36b84..be48a7e31e803 100644 --- a/drivers/scsi/bfa/bfa_ioc.c +++ b/drivers/scsi/bfa/bfa_ioc.c @@ -6642,8 +6642,8 @@ enum bfa_flash_cmd { BFA_FLASH_READ_STATUS = 0x05, /* read status */ }; -/** - * @brief hardware error definition +/* + * Hardware error definition */ enum bfa_flash_err { BFA_FLASH_NOT_PRESENT = -1, /*!< flash not present */ @@ -6657,8 +6657,8 @@ enum bfa_flash_err { BFA_FLASH_ERR_LEN = -9, /*!< invalid length */ }; -/** - * @brief flash command register data structure +/* + * Flash command register data structure */ union bfa_flash_cmd_reg_u { struct { @@ -6681,8 +6681,8 @@ union bfa_flash_cmd_reg_u { u32 i; }; -/** - * @brief flash device status register data structure +/* + * Flash device status register data structure */ union bfa_flash_dev_status_reg_u { struct { @@ -6707,8 +6707,8 @@ union bfa_flash_dev_status_reg_u { u32 i; }; -/** - * @brief flash address register data structure +/* + * Flash address register data structure */ union bfa_flash_addr_reg_u { struct { @@ -6723,7 +6723,7 @@ union bfa_flash_addr_reg_u { u32 i; }; -/** +/* * dg flash_raw_private Flash raw private functions */ static void @@ -6764,7 +6764,7 @@ bfa_flash_cmd_act_check(void __iomem *pci_bar) return 0; } -/** +/* * @brief * Flush FLI data fifo. * @@ -6803,7 +6803,7 @@ bfa_flash_fifo_flush(void __iomem *pci_bar) return 0; } -/** +/* * @brief * Read flash status. * @@ -6848,7 +6848,7 @@ bfa_flash_status_read(void __iomem *pci_bar) return ret_status; } -/** +/* * @brief * Start flash read operation. * @@ -6894,7 +6894,7 @@ bfa_flash_read_start(void __iomem *pci_bar, u32 offset, u32 len, return 0; } -/** +/* * @brief * Check flash read operation. * @@ -6910,7 +6910,7 @@ bfa_flash_read_check(void __iomem *pci_bar) return 0; } -/** +/* * @brief * End flash read operation. * @@ -6936,7 +6936,7 @@ bfa_flash_read_end(void __iomem *pci_bar, u32 len, char *buf) bfa_flash_fifo_flush(pci_bar); } -/** +/* * @brief * Perform flash raw read. * From patchwork Thu Jul 23 12:24:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680813 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5F76B13A4 for ; Thu, 23 Jul 2020 12:26:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47E5C20792 for ; Thu, 23 Jul 2020 12:26:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EnCu+Wb3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728574AbgGWM0D (ORCPT ); Thu, 23 Jul 2020 08:26:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729085AbgGWMZc (ORCPT ); Thu, 23 Jul 2020 08:25:32 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57C8CC0619E6 for ; Thu, 23 Jul 2020 05:25:32 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id x5so4225555wmi.2 for ; Thu, 23 Jul 2020 05:25:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zeBAm1L7XVJ6IVI2TzsfeuXstruzEbtoUmoVsIn2ru8=; b=EnCu+Wb38b4dsqdsV/NDDN7jk4P11BTBfwFzIGhJwSa5HDLOreoGHFr+sZSji+0tgd +NcBdAvxWhDLzfVnrObozeGKSeU7mTKiRnnJx6DsiHNXmPxrR2yhvd86qUAPaio5LN+e R+Ug97vVFL4qvD8LKtWxN0JBVCS6yOl9exg04OsMljHZzlVq53mrlQRDuvffpYagfurV 9a6Ydcr1LePnkVSPYyAmqWQ0sSzGXxKkhOfL4Smnlbeif+OrtsW64tk+1WO1YaB60ec9 Vj7I/M0od+PGt3AUpVR+97u9fyO45j2/qXByvA0nfOepgtcgBBMM65/YXMh5iQ6VVpRU HLvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zeBAm1L7XVJ6IVI2TzsfeuXstruzEbtoUmoVsIn2ru8=; b=oOa7QCmin/tv1cAjDilGZdnxNF+zqV+BXX394PvCdsKVGB/QDM9Mj5/RgcHZi/wg76 XJldO1Iz5MLYQ+0TZhATXdVR5xhxmHclGVPDCMYQzR3nHzJt/x/88b8FLdYZm4wz0VdI NV0IouaLT61n+6Zs8evUIKy7joPlX2KlOqSTG79ZNWqwKFQmMdCgJSX4pxnenbwH9GRI +DKLMTYDpypa50GnT21q1jcpCU2BtRx1oQxWqdcMo+QZuVYIQAD1lNX5GtwAvATXM+/C FMTZIwGcFlRmEJpdU5qRZ4OwFc7D5VRjU8qkgSVaKLs9E9CLKIt9+QRHIqhXiZ0ayHS3 25eQ== X-Gm-Message-State: AOAM532Na/4XA3BAgQGsBUff2gxcWF8zN181zr2qJm8CWJcTjtxYF8FQ We30xRmq82eLkK0E7x/enjuoUA== X-Google-Smtp-Source: ABdhPJzLU3UY01dM0brcV0HKbf0KdBIOoTZNeWuxveErkT/5gB9xuWssPL6fEMHzlDUDTgRNjN48zA== X-Received: by 2002:a1c:68c2:: with SMTP id d185mr3847154wmc.24.1595507131102; Thu, 23 Jul 2020 05:25:31 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:30 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Anil Gurumurthy , Sudarsana Kalluru Subject: [PATCH 34/40] scsi: bfa: bfa_core: Demote seemingly unintentional kerneldoc header Date: Thu, 23 Jul 2020 13:24:40 +0100 Message-Id: <20200723122446.1329773-35-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org This is the only use of kerneldoc in the source file and no descriptions are provided. Fixes the following W=1 kernel build warning(s): drivers/scsi/bfa/bfa_core.c:1245: warning: Function parameter or member 'bfa' not described in 'bfa_iocfc_qreg' drivers/scsi/bfa/bfa_core.c:1245: warning: Function parameter or member 'qreg' not described in 'bfa_iocfc_qreg' Cc: Anil Gurumurthy Cc: Sudarsana Kalluru Signed-off-by: Lee Jones --- drivers/scsi/bfa/bfa_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bfa/bfa_core.c b/drivers/scsi/bfa/bfa_core.c index fb4c469bd89fc..6846ca8f7313c 100644 --- a/drivers/scsi/bfa/bfa_core.c +++ b/drivers/scsi/bfa/bfa_core.c @@ -1237,7 +1237,7 @@ bfa_iocfc_disable_cb(void *bfa_arg, bfa_boolean_t compl) complete(&bfad->disable_comp); } -/** +/* * configure queue registers from firmware response */ static void From patchwork Thu Jul 23 12:24:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680803 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EDD5A13A4 for ; Thu, 23 Jul 2020 12:25:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5B8720888 for ; Thu, 23 Jul 2020 12:25:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XMCdyQhV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729103AbgGWMZf (ORCPT ); Thu, 23 Jul 2020 08:25:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729089AbgGWMZe (ORCPT ); Thu, 23 Jul 2020 08:25:34 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C50FAC0619E2 for ; Thu, 23 Jul 2020 05:25:33 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id z15so4956890wrl.8 for ; Thu, 23 Jul 2020 05:25:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hLMOaM8iSqxASAI/AKDkn1rxF+S99dQlJ1Nf6t4G/bk=; b=XMCdyQhVFCi6/Umqy2BL5lvg3KZdsLZixNAGmFwN77HHlwBykzCjGpwPy9ESSXjVuT iTJxfXek7AOOcDSQn/MxjqdDCN4iacAy6i1ZwD/pWFX+hhVIygaZuE4aWYF7CsbwkvKT ifPsFUAb9HUS61VFI4qIeXx4LOCDA5cx9LiGC2TM+CX2yRjuYZTMaxQAInXAE/3XwngA H3yzgwUb0Zft8+3t0WskpYaGqxpVCt8eaSYKJrU29sVGAfdkn1huj4aGdp4QWuCuoxa3 nNz7wBE3E79WtUZ63p1ja7Ip2nOXuEwXc+pNnqL/reGlksaJ4pf1w/zOWIzb7n4QOEi1 8mmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hLMOaM8iSqxASAI/AKDkn1rxF+S99dQlJ1Nf6t4G/bk=; b=pDqyU7Lpp454H917eJJz5dksuF+ZxUvYYwZAvwGl1VVfr520HxtPBQvVor9+xdNddg Dkk8tPnZmNzlqSo2/sp920Egts9onnEeVWqX6r/7PlER/VNjlv2Fct3RYqmzn8xsoQC+ QXEDLH/xhHnZvDMarZWjwOuZoUuGH8s4KTdJOj2k9GAQwbz2UHMubciEjqJ0/5NUTRgy sRoUbwmC6fLn1KDzSOkF3NE3lcoCGb06kXgfY8TOW3JiRqJ8XZ6hHMDBgOz7BoHtNEZO 7mt63BrC4aeBwHDrWAMvSP2gXRWviMajWphpP6e9Y6z+NAS+1iBCcB0Fdmpe1ZsKxOCj FhlQ== X-Gm-Message-State: AOAM532GPvkdVGwpyZcLWw1zR6aFGbRd0kAC9JX44y5VqnMmYeS60Qvf 3EKnAJhJwTMvk1+Z4R5sey8N1g== X-Google-Smtp-Source: ABdhPJwrD6HEwKn697niOMA41eFD1GShOngUDeMgSw8bSj35wuHIB+IqpnbyrtRx58qcvunvIeLsOA== X-Received: by 2002:a5d:6a4a:: with SMTP id t10mr4105420wrw.360.1595507132577; Thu, 23 Jul 2020 05:25:32 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:31 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Anil Gurumurthy , Sudarsana Kalluru Subject: [PATCH 35/40] scsi: bfa: bfa_svc: Demote seemingly unintentional kerneldoc header Date: Thu, 23 Jul 2020 13:24:41 +0100 Message-Id: <20200723122446.1329773-36-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org This is the only use of kerneldoc in the source file and no descriptions are provided. Also demote standard comment. Fixes the following W=1 kernel build warning(s): drivers/scsi/bfa/bfa_svc.c:3847: warning: Function parameter or member 'bfa' not described in 'bfa_fcport_get_cfg_topology' Cc: Anil Gurumurthy Cc: Sudarsana Kalluru Signed-off-by: Lee Jones --- drivers/scsi/bfa/bfa_svc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/bfa/bfa_svc.c b/drivers/scsi/bfa/bfa_svc.c index 0b7d2e8f4a669..1e266c1ef7938 100644 --- a/drivers/scsi/bfa/bfa_svc.c +++ b/drivers/scsi/bfa/bfa_svc.c @@ -2718,7 +2718,7 @@ bfa_fcport_sm_ddport(struct bfa_fcport_s *fcport, case BFA_FCPORT_SM_DPORTDISABLE: case BFA_FCPORT_SM_ENABLE: case BFA_FCPORT_SM_START: - /** + /* * Ignore event for a port that is ddport */ break; @@ -3839,7 +3839,7 @@ bfa_fcport_get_topology(struct bfa_s *bfa) return fcport->topology; } -/** +/* * Get config topology. */ enum bfa_port_topology From patchwork Thu Jul 23 12:24:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680801 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8F05213B4 for ; Thu, 23 Jul 2020 12:25:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74968206D7 for ; Thu, 23 Jul 2020 12:25:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RJaDEqfJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729108AbgGWMZg (ORCPT ); Thu, 23 Jul 2020 08:25:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729097AbgGWMZf (ORCPT ); Thu, 23 Jul 2020 08:25:35 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFA3AC0619DC for ; Thu, 23 Jul 2020 05:25:34 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id c80so4796396wme.0 for ; Thu, 23 Jul 2020 05:25:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EOTsXsVyK9wcmeKRIO3GiUTJmLIvxWZfHkJHDdHCUzM=; b=RJaDEqfJS1fB0dS69jVVhKLiuoW/IXNro/szq1C73p+C7xny14Y60D1Eh50KTX2/OF I2GnpTiTJMsGomuvsmzlMSJgC8hokp26aKtPna/LTpvVFrD2h2zbzbizu5czgWUjlQt5 0Yu2BL1gOQNsr6+AhW/wKNTZKNexnJUoouybRMgbFtUKNInQS1RZDDCXPlHlyNu2a3FV 7gCWWU0dYqosFtOZAnZBlxVrqBmAqy7ZZ6uymz8MFo2kKqMfg+YZIPh5+MfZfMMYJxHY LAhK49eVMWDVugGh0rpeAojCA5T8BJMa3j+yawPQomQZ1xAtdD3Wa8QDFx0ujm+mD9Q2 9wFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EOTsXsVyK9wcmeKRIO3GiUTJmLIvxWZfHkJHDdHCUzM=; b=O3ow9cNCCU5cTVKgSnc/hGzRiH5uvFbJYIBvKlETeBcElpsLanacJOblAJyQ8hih2m vvxmJzsgoTQqg2o25jG+3f+/HOm8nm/22zWO+FKgBo5+860aBbitJa52A/XXAl6gPCgD rZrBHmn3lt/xLMAOZh3Bx00XQwyyPIfvT4Ll3KHMzAjRjGPf5BEL9hIe+QZ9SWK3bAsF do8+vthS2YqAqOthtjxVvU3UukW+fcV7J5keI9v7AWHVI/8vHtnbO0uyr+Cnt9FMc+oB URFcT8k0+sIYws6BxTMOwmGYo3Aj6QmA5YNH6dP/jRZdr3M+juLBOvwHTuCJkLsqsB6B 26ZQ== X-Gm-Message-State: AOAM5333WlS06S5WTMbDNPamQ2j1VlXQwd40Zs+g9Xrzuc5ct30sdgUa 0ttkb+VzYjHtuVN5vBg696oHKg== X-Google-Smtp-Source: ABdhPJwm1gFat1cUxTpp/ybspw0TU+G9ZDroDChK3K2K67K1pObv8zSnaL9bnABnPw+0YmQQxUANaA== X-Received: by 2002:a7b:c8c8:: with SMTP id f8mr4133869wml.142.1595507133733; Thu, 23 Jul 2020 05:25:33 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:33 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@cavium.com Subject: [PATCH 36/40] scsi: qedi: qedi_main: Demote seemingly unintentional kerneldoc header Date: Thu, 23 Jul 2020 13:24:42 +0100 Message-Id: <20200723122446.1329773-37-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org This is the only use of kerneldoc in the source file and no descriptions are provided. Fixes the following W=1 kernel build warning(s): drivers/scsi/qedi/qedi_main.c:1969: warning: Function parameter or member 'qedi' not described in 'qedi_get_nvram_block' Cc: QLogic-Storage-Upstream@cavium.com Signed-off-by: Lee Jones --- drivers/scsi/qedi/qedi_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index 1a7791164de8c..6f038ae5efcaf 100644 --- a/drivers/scsi/qedi/qedi_main.c +++ b/drivers/scsi/qedi/qedi_main.c @@ -1960,7 +1960,7 @@ void qedi_reset_host_mtu(struct qedi_ctx *qedi, u16 mtu) qedi_ops->ll2->start(qedi->cdev, ¶ms); } -/** +/* * qedi_get_nvram_block: - Scan through the iSCSI NVRAM block (while accounting * for gaps) for the matching absolute-pf-id of the QEDI device. */ From patchwork Thu Jul 23 12:24:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680811 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3C4CF13A4 for ; Thu, 23 Jul 2020 12:25:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 257F722BF3 for ; Thu, 23 Jul 2020 12:25:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cF/qDwLu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729123AbgGWMZi (ORCPT ); Thu, 23 Jul 2020 08:25:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729115AbgGWMZh (ORCPT ); Thu, 23 Jul 2020 08:25:37 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6E1AC0619DC for ; Thu, 23 Jul 2020 05:25:36 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id c80so4796473wme.0 for ; Thu, 23 Jul 2020 05:25:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lILTThezBBjt1SaEOrJ5cCFNVhfL0JgzA9PlnOUOSZ0=; b=cF/qDwLuZ3kSlDgfOjMgsjZ/zgg8VcNgh/irkdLg65eI4YGX/EJnsb6zFuWrudDys/ M+Qps5AKnfK3YYlKDNS+VwBMfIQr0SwE5OjAdl1Fql26eTQnrAJHSYv1V2OtKIMEvO4g q1p08Gl13ghVrzSOqppm1PkM0dWYOMdlvJyfaGZ7jobCoY7kFFT1Lxy2Jf7U/vmuB5Ge 6KK19t9Lyk8EnqbB9JQbR0ttlRt/4cXQfQn0l3Nw9VhS8hrciqJCSsFxnnCyXVJehcU6 Cez5bfFb7D8LD7OCQcmbjnMSqFcyHSczjFuITPE6ZISp99ig2Tcsug4kQ5rhA6Vp2Q8B 7qjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lILTThezBBjt1SaEOrJ5cCFNVhfL0JgzA9PlnOUOSZ0=; b=IkK/PausApbTmt5RI9MvghrImTA99zTk8TVhJY4OAl4HQi0nWVTdoktQL8k5g77jGo g7Zu6kD6CqoIyKHLkW6Rjv6/fyYA9JwPm+yDZc8Q2h3PMI3Pu/AmR8x13eTUEnZmLFk/ pFFxgbtCbHD+OuZK6UEmNempgTDVuqwMJofE7E1IsIyK8EkmQGD27Tdtf66zO3BlOZoK oh2+sChD9eJx5X4Fn6ob+UHzcEfPggaP16+e7Ne8fZoqADP8BLgGFCJa1ppY2r43JD0o lNaKOkiYip/MuqucbS78k89buDcSr21eEfHh5LKJBICVEDVPRJ2wRN/GvbctVg7GBciX Yxkw== X-Gm-Message-State: AOAM533Dsw0wMwz1EmoXEW7zQM6tydSww4cAqBmUdB43aK0zRcynk5TN GDhaGwO2UR6A0TfakeOvrPLbfg== X-Google-Smtp-Source: ABdhPJzgV5ygX039Y+Z439kdkBvpBcmVfcgyvPkdOSIQ9k2En1wPFl5q+32hVNnRToBdO79SrD6qVA== X-Received: by 2002:a1c:750a:: with SMTP id o10mr4120800wmc.165.1595507135701; Thu, 23 Jul 2020 05:25:35 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:35 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@cavium.com Subject: [PATCH 37/40] scsi: qedi: qedi_iscsi: Staticify non-external function 'qedi_get_iscsi_error' Date: Thu, 23 Jul 2020 13:24:43 +0100 Message-Id: <20200723122446.1329773-38-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/qedi/qedi_iscsi.c:1549:7: warning: no previous prototype for ‘qedi_get_iscsi_error’ [-Wmissing-prototypes] Cc: QLogic-Storage-Upstream@cavium.com Signed-off-by: Lee Jones --- drivers/scsi/qedi/qedi_iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedi/qedi_iscsi.c b/drivers/scsi/qedi/qedi_iscsi.c index 425e665ec08b2..c14ac7882afac 100644 --- a/drivers/scsi/qedi/qedi_iscsi.c +++ b/drivers/scsi/qedi/qedi_iscsi.c @@ -1546,7 +1546,7 @@ static const struct { }, }; -char *qedi_get_iscsi_error(enum iscsi_error_types err_code) +static char *qedi_get_iscsi_error(enum iscsi_error_types err_code) { int i; char *msg = NULL; From patchwork Thu Jul 23 12:24:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680809 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5B48B13A4 for ; Thu, 23 Jul 2020 12:25:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 410452086A for ; Thu, 23 Jul 2020 12:25:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Phg9qHMV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729128AbgGWMZj (ORCPT ); Thu, 23 Jul 2020 08:25:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729119AbgGWMZi (ORCPT ); Thu, 23 Jul 2020 08:25:38 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B7A8C0619DC for ; Thu, 23 Jul 2020 05:25:38 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id y3so4978809wrl.4 for ; Thu, 23 Jul 2020 05:25:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Zt4gQ5fBquDOsunevc+xn2q97qXGNvH/uHrfGiyo69A=; b=Phg9qHMV73qlHdXhbakwTt6Vb+7ozqNYazBc72hJL/WdpwWv+ovB7Llu1p8IIVxpt3 qSeAXsvji3rtYgDMJT+kESSiOxr/HYE8PLq4UpveLCEf2NBvWTmCHkuSWVgH34e5NXpn nxhFDKkQptRrXCFT7j1+Fpcf3CG6/cQAi9S5fJJlhJW1GbU37o5rT6rGyx44X4pnH1iE kYn2fVn0+Jfa74Qvn/Cl+jYSqWly6gPiel27OMYykJ1EkP7rciIe0IOOBaMHYoJxyF+b ShVbMaJVKAJNpjzXMgMZtwTzmdYTKYk+rqBSpG+EDKiIm3IIVmoA0/ONF2nflNJIHgjs 5K0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Zt4gQ5fBquDOsunevc+xn2q97qXGNvH/uHrfGiyo69A=; b=j79Ee3yR3yEVMBk4md9iC1N386KtL+EAaPU5yhQIqLvm2PCkyZKmM7ktxSVfgg2146 gPCafXfJmCwPVOfranqv1fnc4qn7J+QHqTlu+uwgIwk9AdX/42F4aal9lP1eazmrUxMz xGZY6o07wfw9YSXhHfSM/AXsRRD2hRTmfxdrGtQM63UPOCYHcwLbOmGDeNW+FiGcvpC4 GrBXiJOhofHZNUH59jUmsohOgh9cr/D61E4ibBXpZ3+jUSMcz20CHz2x2L9jq0oImeMT 20JOHYu66YIuORglUa3CYqd4NoFIMmvfrPZ4Sm06QidR/NTh2/Q7coUY1Yq+FvpYc4+u iXCw== X-Gm-Message-State: AOAM530RgI+RZiUPdh5oUylqbDWZnAdkPIwvi9DKFA/ocJlUYrBXssjm jsdcEscPsNHIylLWWO18HmVAnQ== X-Google-Smtp-Source: ABdhPJyfTicJl5ewFF503iUoLLoflgMDe4eIajSk2w6TXoQayLk/F7If1jxpAb/Ef4jZheNv4PAA4Q== X-Received: by 2002:adf:fd41:: with SMTP id h1mr4146529wrs.124.1595507137010; Thu, 23 Jul 2020 05:25:37 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:36 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Anil Gurumurthy , Sudarsana Kalluru Subject: [PATCH 38/40] scsi: bfa: bfa_ioc: Ensure a blank line precedes next function/header Date: Thu, 23 Jul 2020 13:24:44 +0100 Message-Id: <20200723122446.1329773-39-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following checkpatch warning: CHECK: Please use a blank line after function/struct/union/enum declarations #129: FILE: drivers/scsi/bfa/bfa_ioc.c:6913: } +/* Cc: Anil Gurumurthy Cc: Sudarsana Kalluru Signed-off-by: Lee Jones --- drivers/scsi/bfa/bfa_ioc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/scsi/bfa/bfa_ioc.c index be48a7e31e803..dd5821dfcac2d 100644 --- a/drivers/scsi/bfa/bfa_ioc.c +++ b/drivers/scsi/bfa/bfa_ioc.c @@ -6910,6 +6910,7 @@ bfa_flash_read_check(void __iomem *pci_bar) return 0; } + /* * @brief * End flash read operation. From patchwork Thu Jul 23 12:24:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680807 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2650713A4 for ; Thu, 23 Jul 2020 12:25:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DA3A22BEF for ; Thu, 23 Jul 2020 12:25:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rooYXweM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729162AbgGWMZt (ORCPT ); Thu, 23 Jul 2020 08:25:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729130AbgGWMZj (ORCPT ); Thu, 23 Jul 2020 08:25:39 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76C3FC0619E2 for ; Thu, 23 Jul 2020 05:25:39 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id 184so5023403wmb.0 for ; Thu, 23 Jul 2020 05:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m3mDnqSN+OOOTdmOXToIz9SwiUgUMLzbR5Yna7FHQ8M=; b=rooYXweMoSfvNUEFwqDddlh0k+h7mXrYANm1pHQMha0hxF4CfAHMhYrlhKwN8cfE2F jEsJYbcBqxFZrDqIbtmyuOj9LMfpPPg2uVl8FSnvPYTiQEORXFNwUewOBXmCIQxvAgt8 wIPUwbxyJq1JjjudqgEqcW8YlORJOqA52XqT454/xaTZy1wmfSivdgBpmCy49zQDSLyn xpFy7CJItOrmsDByW8eVSMmlOhh5RmUaDCn/wAGJwERbu4yn/ESYc3SeCgEgllYwTgMy RPDYKboBND6viaKyfFK0PXCEpJBaoIFM/Szhrfx46SMZWl5AZfnkKwJ5qi4tm/OdFP3D zv0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m3mDnqSN+OOOTdmOXToIz9SwiUgUMLzbR5Yna7FHQ8M=; b=doNQFV5Wee+v8FN7wWo4uxB5MG5u5HD1PhGelYpGXvgz5UTRy2cpNUzhrirfsBkONS dh1MIHYZYvjd40J1BuB973cIizoMFSbtsk23zBi760UW1XVFqaIemm9eMM4pWocbMObq jkegp6Hn+M8OJQ+q322YD+pnAfVchYBQjTiBpNf81yEC4KfrC2LKPueAxDcajGxCHdRI IkH2vCFmJH7lDywVFf5efs/wYMfoRZeNvJQtFfsPYfGx+iENYvQE8YFvGuncVqK1hG+3 R4OSeiW1GHy5zr4o4j7wr6Ldc3wqJFP/VkTlOTu1KJLv/4ZGbTQhJzK+tLAucAC0Hf8g iqLQ== X-Gm-Message-State: AOAM530p/fykMqMNvrjChqTF6xzUEDJD4N7wIl+z7dW4hC3GuNdafaTw 8uZn+0Dd8UCzXS/l59C4pX0DSQ== X-Google-Smtp-Source: ABdhPJz21F1hF0w8d/uGaxTFpi0mKtSscG/cstIbgprrV8ExxIOCeRxWE3/C74m+Haof5yb1KXRJqA== X-Received: by 2002:a1c:7717:: with SMTP id t23mr3870714wmi.75.1595507138244; Thu, 23 Jul 2020 05:25:38 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:37 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , QLogic-Storage-Upstream@qlogic.com, Anil Veerabhadrappa , Eddie Wai Subject: [PATCH 39/40] scsi: bnx2i: bnx2i_iscsi: Add parameter description and rename another Date: Thu, 23 Jul 2020 13:24:45 +0100 Message-Id: <20200723122446.1329773-40-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/bnx2i/bnx2i_iscsi.c:1288: warning: Function parameter or member 'cmds_max' not described in 'bnx2i_session_create' drivers/scsi/bnx2i/bnx2i_iscsi.c:2176: warning: Function parameter or member 'params' not described in 'bnx2i_nl_set_path' drivers/scsi/bnx2i/bnx2i_iscsi.c:2176: warning: Excess function parameter 'buf' description in 'bnx2i_nl_set_path' Cc: QLogic-Storage-Upstream@qlogic.com Cc: Anil Veerabhadrappa Cc: Eddie Wai Signed-off-by: Lee Jones --- drivers/scsi/bnx2i/bnx2i_iscsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c index a9ffd89ec2c85..fdd446765311a 100644 --- a/drivers/scsi/bnx2i/bnx2i_iscsi.c +++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c @@ -1276,6 +1276,7 @@ static int bnx2i_task_xmit(struct iscsi_task *task) /** * bnx2i_session_create - create a new iscsi session * @ep: pointer to iscsi endpoint + * @cmds_max: user specified maximum commands * @qdepth: scsi queue depth to support * @initial_cmdsn: initial iscsi CMDSN to be used for this session * @@ -2170,7 +2171,7 @@ static void bnx2i_ep_disconnect(struct iscsi_endpoint *ep) /** * bnx2i_nl_set_path - ISCSI_UEVENT_PATH_UPDATE user message handler * @shost: scsi host pointer - * @buf: pointer to buffer containing iscsi path message + * @params: pointer to buffer containing iscsi path message */ static int bnx2i_nl_set_path(struct Scsi_Host *shost, struct iscsi_path *params) { From patchwork Thu Jul 23 12:24:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11680805 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 17A4013B4 for ; Thu, 23 Jul 2020 12:25:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F19F0208E4 for ; Thu, 23 Jul 2020 12:25:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="U90SFM2X" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729083AbgGWMZo (ORCPT ); Thu, 23 Jul 2020 08:25:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729139AbgGWMZl (ORCPT ); Thu, 23 Jul 2020 08:25:41 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DFBCC0619E3 for ; Thu, 23 Jul 2020 05:25:41 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id y3so4978952wrl.4 for ; Thu, 23 Jul 2020 05:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e/a+n7xeT+4IypaMdZEOHPtxjDCXYhdWbia6WF8lJXM=; b=U90SFM2XfntMbbnKnpL8NIcPeMt35ipcq6Dn11/o5syJemNsgkTGwnAef33kj+uNTc DriqRPXhk78sPhGfpXjcZZS0kOou3ET6f+Fg46iKHmQFE6TldgHGr3BZLU39n7/6axET occ6OmfpC459wp/wuL3KZveW9siDSXs9DeDZDtxDAHdaPC+LA5Rk10BtDHusbCXXJD9N 5wyAabHHnCEHOtiq7veQY85rYVYHMf6M384luLNiB4AwwZVbh7zSDXTXY0KmshygRX4v b7QeGD4rVWoFSZZ/zITPdb8scodvtQdKCCVCQxmRvSru02xmEIUJRWhbH7lMrRH800as zh2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e/a+n7xeT+4IypaMdZEOHPtxjDCXYhdWbia6WF8lJXM=; b=BmDNLFE2jywRgsG9AeC0s7MubJzwv0mDORCKvmiDEGqj2yFtup5vRnSKc4n4+cEFws TCX1yi7ol4mQQsC7dqdrsLM7Xp8je8iZozi2ZbqD2KqKTGGBumtOMQQtiobHItW1thIH hH535KqYEdBS+X8ybr14H9oj8YEJfFWEu1Yri/Qi8IhFYAV7OTnOJfj55hXv7TVQMqaT IOQyempvc5tNI4V28MKTuKTW5zsjATj0HGUy3PfgcISyp+svhvOPj0syzS87yPto8MK8 xDlc+9GkexV4QGqkLum4bGeANuJoNvpiWNiqbHuzPBPYqqteOm5RoP64cULUZg2MhH11 3CtQ== X-Gm-Message-State: AOAM53145jeqPKtBZsBQqaCf6vXmsdIFriFfQ7WptRwdnNy+KwevllqK 4w5YFTq4p3OvYEEfyzPQFNty4w== X-Google-Smtp-Source: ABdhPJy4d9ZY4EAHaWXH/a0t/Z9kXHv2xcUkY8FSTT7ZehgX4cv+QGUBUbgxKGPINTm00P6AAbNzyA== X-Received: by 2002:adf:e704:: with SMTP id c4mr4196356wrm.81.1595507139735; Thu, 23 Jul 2020 05:25:39 -0700 (PDT) Received: from localhost.localdomain ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id j5sm3510651wma.45.2020.07.23.05.25.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:25:39 -0700 (PDT) From: Lee Jones To: jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Lee Jones , Bradley Grove Subject: [PATCH 40/40] scsi: esas2r: esas2r_log: Demote a few non-conformant kerneldoc headers Date: Thu, 23 Jul 2020 13:24:46 +0100 Message-Id: <20200723122446.1329773-41-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200723122446.1329773-1-lee.jones@linaro.org> References: <20200723122446.1329773-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/esas2r/esas2r_log.c:86: warning: Function parameter or member 'level' not described in 'translate_esas2r_event_level_to_kernel' drivers/scsi/esas2r/esas2r_log.c:120: warning: Function parameter or member 'level' not described in 'esas2r_log_master' drivers/scsi/esas2r/esas2r_log.c:120: warning: Function parameter or member 'dev' not described in 'esas2r_log_master' drivers/scsi/esas2r/esas2r_log.c:120: warning: Function parameter or member 'format' not described in 'esas2r_log_master' drivers/scsi/esas2r/esas2r_log.c:120: warning: Function parameter or member 'args' not described in 'esas2r_log_master' drivers/scsi/esas2r/esas2r_log.c:183: warning: Function parameter or member 'level' not described in 'esas2r_log' drivers/scsi/esas2r/esas2r_log.c:183: warning: Function parameter or member 'format' not described in 'esas2r_log' drivers/scsi/esas2r/esas2r_log.c:211: warning: Function parameter or member 'level' not described in 'esas2r_log_dev' drivers/scsi/esas2r/esas2r_log.c:211: warning: Function parameter or member 'dev' not described in 'esas2r_log_dev' drivers/scsi/esas2r/esas2r_log.c:211: warning: Function parameter or member 'format' not described in 'esas2r_log_dev' drivers/scsi/esas2r/esas2r_log.c:237: warning: Function parameter or member 'level' not described in 'esas2r_log_hexdump' drivers/scsi/esas2r/esas2r_log.c:237: warning: Function parameter or member 'buf' not described in 'esas2r_log_hexdump' drivers/scsi/esas2r/esas2r_log.c:237: warning: Function parameter or member 'len' not described in 'esas2r_log_hexdump' Cc: Bradley Grove Signed-off-by: Lee Jones --- drivers/scsi/esas2r/esas2r_log.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/esas2r/esas2r_log.c b/drivers/scsi/esas2r/esas2r_log.c index 65fdf22b0ba9a..b545798e400c4 100644 --- a/drivers/scsi/esas2r/esas2r_log.c +++ b/drivers/scsi/esas2r/esas2r_log.c @@ -75,7 +75,7 @@ static char event_buffer[EVENT_LOG_BUFF_SIZE]; /* A lock to protect the shared buffer used for formatting messages. */ static DEFINE_SPINLOCK(event_buffer_lock); -/** +/* * translates an esas2r-defined logging event level to a kernel logging level. * * @param [in] level the esas2r-defined logging event level to translate @@ -101,7 +101,7 @@ static const char *translate_esas2r_event_level_to_kernel(const long level) } } -/** +/* * the master logging function. this function will format the message as * outlined by the formatting string, the input device information and the * substitution arguments and output the resulting string to the system log. @@ -170,7 +170,7 @@ static int esas2r_log_master(const long level, return 0; } -/** +/* * formats and logs a message to the system log. * * @param [in] level the event level of the message @@ -193,7 +193,7 @@ int esas2r_log(const long level, const char *format, ...) return retval; } -/** +/* * formats and logs a message to the system log. this message will include * device information. * @@ -221,7 +221,7 @@ int esas2r_log_dev(const long level, return retval; } -/** +/* * formats and logs a message to the system log. this message will include * device information. *