From patchwork Wed Jul 29 16:29:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 11691357 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C70181575 for ; Wed, 29 Jul 2020 16:29:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A488A2084D for ; Wed, 29 Jul 2020 16:29:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="vJcZvSTE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726502AbgG2Q3g (ORCPT ); Wed, 29 Jul 2020 12:29:36 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:33632 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726365AbgG2Q3g (ORCPT ); Wed, 29 Jul 2020 12:29:36 -0400 Received: from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8EF72563; Wed, 29 Jul 2020 18:29:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1596040169; bh=WPUP2yatqQeW6/0Ji0JPJMGTvsstJemKEg5UIsIJNrQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vJcZvSTEcF3frPa0CK+u48UdNqqDg4M0DKGr2W4KOhXKpG2da9LRFUOHFju4ZQouX Jo4/U4S6EncZtXK+eqgEhdN9xBCs2OYYKIaEyWWqXiVfbpAGRWXYlihxYDG0pqVT1F eHjTESLvi5P4cmw2ng6tuHlGSrEbEMbK4Ga7MSwU= From: Laurent Pinchart To: dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org Cc: Randy Dunlap , Mark Brown , Liam Girdwood , Alexandre Bounine , Matt Porter , Michal Simek , Vinod Koul , Hyun Kwon Subject: [PATCH 1/3] rapidio: Replace 'select' DMAENGINES 'with depends on' Date: Wed, 29 Jul 2020 19:29:08 +0300 Message-Id: <20200729162910.13196-2-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200729162910.13196-1-laurent.pinchart@ideasonboard.com> References: <20200729162910.13196-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Enabling a whole subsystem from a single driver 'select' is frowned upon and won't be accepted in new drivers, that need to use 'depends on' instead. Existing selection of DMAENGINES will then cause circular dependencies. Replace them with a dependency. Signed-off-by: Laurent Pinchart Acked-by: Randy Dunlap --- drivers/rapidio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rapidio/Kconfig b/drivers/rapidio/Kconfig index e4c422d806be..b9f8514909bf 100644 --- a/drivers/rapidio/Kconfig +++ b/drivers/rapidio/Kconfig @@ -37,7 +37,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS config RAPIDIO_DMA_ENGINE bool "DMA Engine support for RapidIO" depends on RAPIDIO - select DMADEVICES + depends on DMADEVICES select DMA_ENGINE help Say Y here if you want to use DMA Engine frameork for RapidIO data From patchwork Wed Jul 29 16:29:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 11691359 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A73A613B1 for ; Wed, 29 Jul 2020 16:29:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8316D2075F for ; Wed, 29 Jul 2020 16:29:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="MrorK1v4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726365AbgG2Q3h (ORCPT ); Wed, 29 Jul 2020 12:29:37 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:33646 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726449AbgG2Q3h (ORCPT ); Wed, 29 Jul 2020 12:29:37 -0400 Received: from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 36A1F9BF; Wed, 29 Jul 2020 18:29:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1596040170; bh=KVM3J71ytG4aD9KCN56H16S59gG570Zxeid8qwLvghQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MrorK1v4V2um5AwG6qXGjqgSJTmsDChti1+9TrpbakkUYEz1nxVf79tXOZqvwlTQB 3hAW2qQLSrTilz+TsR0O4uJvJkUEG6ljvKqL7Rx38qKvg8VFW80d5TCF1oJ5pARQDf QnE56cnh+E8BvoR85+P0dyRUmyn6xXYzBMuUPcAc= From: Laurent Pinchart To: dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org Cc: Randy Dunlap , Mark Brown , Liam Girdwood , Alexandre Bounine , Matt Porter , Michal Simek , Vinod Koul , Hyun Kwon Subject: [PATCH 2/3] ASoC: sh: Replace 'select' DMAENGINES 'with depends on' Date: Wed, 29 Jul 2020 19:29:09 +0300 Message-Id: <20200729162910.13196-3-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200729162910.13196-1-laurent.pinchart@ideasonboard.com> References: <20200729162910.13196-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Enabling a whole subsystem from a single driver 'select' is frowned upon and won't be accepted in new drivers, that need to use 'depends on' instead. Existing selection of DMAENGINES will then cause circular dependencies. Replace them with a dependency. Signed-off-by: Laurent Pinchart Acked-by: Randy Dunlap --- sound/soc/sh/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sh/Kconfig b/sound/soc/sh/Kconfig index dc20f0f7080a..ef8a29b9f641 100644 --- a/sound/soc/sh/Kconfig +++ b/sound/soc/sh/Kconfig @@ -30,8 +30,8 @@ config SND_SOC_SH4_FSI config SND_SOC_SH4_SIU tristate depends on ARCH_SHMOBILE && HAVE_CLK + depends on DMADEVICES select DMA_ENGINE - select DMADEVICES select SH_DMAE select FW_LOADER From patchwork Wed Jul 29 16:29:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 11691363 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2E02913B1 for ; Wed, 29 Jul 2020 16:29:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C7492075F for ; Wed, 29 Jul 2020 16:29:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="IYYNQyec" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726772AbgG2Q3m (ORCPT ); Wed, 29 Jul 2020 12:29:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726707AbgG2Q3m (ORCPT ); Wed, 29 Jul 2020 12:29:42 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81294C061794 for ; Wed, 29 Jul 2020 09:29:42 -0700 (PDT) Received: from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E3EF0B8F; Wed, 29 Jul 2020 18:29:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1596040175; bh=xB0gUOPhwdLlAfoF9pG/5jwaKF4JCE2b9OyRj3KJvKY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IYYNQyechBS9DDJZD2f89/DwSMsDTMQ3EOFY0Zo2J5b9Ez0Eeli9dVGXtarDSmmfP DZtNq1L63JGMHdJuAQautBotENM041aBnjW12gqgtqKlpESRCbOndNPGHK8oWm0mZu IqmOzWXg0+r8yJJ75Z+57b2grBcvJ8C8GqYo8L8E= From: Laurent Pinchart To: dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org Cc: Randy Dunlap , Mark Brown , Liam Girdwood , Alexandre Bounine , Matt Porter , Michal Simek , Vinod Koul , Hyun Kwon Subject: [PATCH 3/3] drm: xlnx: dpsub: Fix DMADEVICES Kconfig dependency Date: Wed, 29 Jul 2020 19:29:10 +0300 Message-Id: <20200729162910.13196-4-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200729162910.13196-1-laurent.pinchart@ideasonboard.com> References: <20200729162910.13196-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org The dpsub driver uses the DMA engine API, and thus selects DMA_ENGINE to provide that API. DMA_ENGINE depends on DMADEVICES, which can be deselected by the user, creating a possibly unmet indirect dependency: WARNING: unmet direct dependencies detected for DMA_ENGINE Depends on [n]: DMADEVICES [=n] Selected by [m]: - DRM_ZYNQMP_DPSUB [=m] && HAS_IOMEM [=y] && (ARCH_ZYNQMP || COMPILE_TEST [=y]) && COMMON_CLK [=y] && DRM [=m] && OF [=y] Add a dependency on DMADEVICES to fix this. Reported-by: Randy Dunlap Signed-off-by: Laurent Pinchart Acked-by: Randy Dunlap --- drivers/gpu/drm/xlnx/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xlnx/Kconfig b/drivers/gpu/drm/xlnx/Kconfig index aa6cd889bd11..b52c6cdfc0b8 100644 --- a/drivers/gpu/drm/xlnx/Kconfig +++ b/drivers/gpu/drm/xlnx/Kconfig @@ -2,6 +2,7 @@ config DRM_ZYNQMP_DPSUB tristate "ZynqMP DisplayPort Controller Driver" depends on ARCH_ZYNQMP || COMPILE_TEST depends on COMMON_CLK && DRM && OF + depends on DMADEVICES select DMA_ENGINE select DRM_GEM_CMA_HELPER select DRM_KMS_CMA_HELPER