From patchwork Wed Aug 12 14:37:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bean Huo X-Patchwork-Id: 11710915 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6E6A41392 for ; Wed, 12 Aug 2020 14:37:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DDB420756 for ; Wed, 12 Aug 2020 14:37:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XRtzaReD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726518AbgHLOhS (ORCPT ); Wed, 12 Aug 2020 10:37:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726583AbgHLOhR (ORCPT ); Wed, 12 Aug 2020 10:37:17 -0400 Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D36BC061383; Wed, 12 Aug 2020 07:37:17 -0700 (PDT) Received: by mail-ed1-x544.google.com with SMTP id c10so1700729edk.6; Wed, 12 Aug 2020 07:37:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Gn7ZCZ5XA2EnBwutA3QyCJrGM4TBiILm4xq3LoAVuYo=; b=XRtzaReDSvg5kTrtGXPdqHmRTxsd1SfMl/OI4Nfo3UiWo6Z9qimPgLI1GviIdOrSAQ 9SXd89txWifead1bQWeppyUnPXISNO3fxHpHxS8Oj2hYb3S198vBBh9y1sLF0muN98eS RbPszq3gxDE+vmGkWS7DuGLcaxN8KaIWSebU2i7w2mJcMdJQ87GdAbknToJR/KZzGfdf Ygs2SGcRoASoob8agtkAcCMkchvrUaG3r7wq/DmUMheB8Fz9xOuUuzg0eKh7bKVZS/Z2 6bq3rh1ZMyugTH86ctTwCR23PsXFxh/E/A2o/mKwk2ed5k5LwIXo5llmD/JZZK//SaEO fr2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Gn7ZCZ5XA2EnBwutA3QyCJrGM4TBiILm4xq3LoAVuYo=; b=FY4UPG01YLlWI/u5o8xg4NqeLhnS4KIZf8m0kNWdS06NxPR05mVSbM8fNUvTtgyd9H FrzFnfgt+45lWWRrtYA0ZrBm84p6XYZNKxpED817P+WAqNnvOLk3ZPGmABynEbh88rlo fES6eqITiqJoyVW32XxcAgVg++/Z2zeMzhMkxhsam4KVQQ5K6UPmex4/F1rAWT4zijP2 vMHJ9uDQ63chGABmcyqnL+5IoP0jIZY7rt7HDBCkVi7D7IH9pVr3f4NSi8XlukNkx2wK vWO2TjAfItS1ki6Y81K+6pvCw5Gj2rm6Il9PgW/I2X+8/JzMzy45vU9QOdkfmZqKbLPl fpIw== X-Gm-Message-State: AOAM533Bq9zjU0SPOJHYD4Qdln86qo5VoBLJhT9lnLxI2I5dD494jHx9 Aw685EvYiYUJ5puJMgPeyFA= X-Google-Smtp-Source: ABdhPJwHUTCOq/7sG1xx2m0Srnm+e6Me9xBDEMaC0kGa0pCrpQaRo5JEga0wKCectWad1lQC9C+rag== X-Received: by 2002:aa7:ca0c:: with SMTP id y12mr178248eds.251.1597243036013; Wed, 12 Aug 2020 07:37:16 -0700 (PDT) Received: from localhost.localdomain ([2a01:598:b90f:8e5c:44c:d55b:5f94:2fc4]) by smtp.gmail.com with ESMTPSA id d20sm1661179ejj.10.2020.08.12.07.37.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 07:37:15 -0700 (PDT) From: Bean Huo To: alim.akhtar@samsung.com, avri.altman@wdc.com, asutoshd@codeaurora.org, jejb@linux.ibm.com, martin.petersen@oracle.com, stanley.chu@mediatek.com, beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com, cang@codeaurora.org Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] scsi: ufs: change ufshcd_comp_devman_upiu() to ufshcd_compose_devman_upiu() Date: Wed, 12 Aug 2020 16:37:03 +0200 Message-Id: <20200812143704.30245-2-huobean@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200812143704.30245-1-huobean@gmail.com> References: <20200812143704.30245-1-huobean@gmail.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org From: Bean Huo ufshcd_comp_devman_upiu() alwasy make me confuse that it is a request completion calling function. Change it to ufshcd_compose_devman_upiu(). Signed-off-by: Bean Huo Acked-by: Avri Altman Reviewed-by: Asutosh Das Reviewed-by: Can Guo --- drivers/scsi/ufs/ufshcd.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 5f09cda7b21c..e3663b85e8ee 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -2391,12 +2391,13 @@ static inline void ufshcd_prepare_utp_nop_upiu(struct ufshcd_lrb *lrbp) } /** - * ufshcd_comp_devman_upiu - UFS Protocol Information Unit(UPIU) + * ufshcd_compose_devman_upiu - UFS Protocol Information Unit(UPIU) * for Device Management Purposes * @hba: per adapter instance * @lrbp: pointer to local reference block */ -static int ufshcd_comp_devman_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) +static int ufshcd_compose_devman_upiu(struct ufs_hba *hba, + struct ufshcd_lrb *lrbp) { u8 upiu_flags; int ret = 0; @@ -2590,7 +2591,7 @@ static int ufshcd_compose_dev_cmd(struct ufs_hba *hba, ufshcd_prepare_lrbp_crypto(NULL, lrbp); hba->dev_cmd.type = cmd_type; - return ufshcd_comp_devman_upiu(hba, lrbp); + return ufshcd_compose_devman_upiu(hba, lrbp); } static int From patchwork Wed Aug 12 14:37:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bean Huo X-Patchwork-Id: 11710913 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4E3C516B1 for ; Wed, 12 Aug 2020 14:37:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B6D120756 for ; Wed, 12 Aug 2020 14:37:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nNIGnlJ4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726690AbgHLOhU (ORCPT ); Wed, 12 Aug 2020 10:37:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726678AbgHLOhT (ORCPT ); Wed, 12 Aug 2020 10:37:19 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85502C061383; Wed, 12 Aug 2020 07:37:18 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id kq25so2525248ejb.3; Wed, 12 Aug 2020 07:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=k0jt6enCU+k6/1ZLIPsFzlCB9yQOeFwEasaJxWTCsu4=; b=nNIGnlJ4cxzSXBBlnAdU22ZeY2sWhmhZUfKtM9/2nnn/li9/ertILnExUwm/EVvs49 hh/q/fu++uLyx/Ja+S57sIDuOpttKx0bRe0QiHnIBzDIQsVOfO0fcSrmCNpx6b+e8YL4 sqVdm/Bg3+0dtjyY/jiCan59vHfcakWNTZHQfTl0/SQOaL7TPRqzL8DHA/vrSYjtsyAa lMLCr4f0S97Yxm4Nye0p5C8ZiEHcoSs91dx9TINFHH7TE/8EamhqG7Zpiy0mgzQFfPuw ZU24VJRRRVRC1jHws2TWXqoLky473FUA6synd04/H7lop1nP35s/hEli0SKieJGTJBN8 I72A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=k0jt6enCU+k6/1ZLIPsFzlCB9yQOeFwEasaJxWTCsu4=; b=a3QHIXw6wiI71e4H4zMSAeDxAXgR9HHXToebiJXbvBfM05npOmpRaqMykzixO2AhPT dTw6KjgGtEVq56Ud1O2xROmxA2LDSZLNhpioqK8/mL8vVAHYxyeVYkm3Wl3q9fE/bHAd ZFEYDFvcMHJZ4OH/Br+TUVMLkGBpaeO6N1+V8TWMs01v36KEE1/5aV6jDgnuH5IiTErJ mK/jsJNVj3g/TjXu8XVbAJ+GLGPEGw9otzQyxtvAbCctYxVHxcqVEAdbmHBBMgLue3xW v0dHMoPlp8LkekAEFrXpIU/owlONx5ibQ6FFc9JHrhlijKzJmJ5CZEY2qAVz0d06Tzvl Gsiw== X-Gm-Message-State: AOAM532JPXQLLPiXBgtk4SDKNV9qEU1DYav+MpLy70vXiSM0EgfpX4kn RpR7afXBp03JzTgUYbm4c8A= X-Google-Smtp-Source: ABdhPJypeCnLUIuX2FrykbNFJM6Kdp/anVO6jkBnXd6M3Oh/7cvrXbhufq6pzC/kcuxFAFjbQVElFA== X-Received: by 2002:a17:906:e17:: with SMTP id l23mr79692eji.13.1597243037318; Wed, 12 Aug 2020 07:37:17 -0700 (PDT) Received: from localhost.localdomain ([2a01:598:b90f:8e5c:44c:d55b:5f94:2fc4]) by smtp.gmail.com with ESMTPSA id d20sm1661179ejj.10.2020.08.12.07.37.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 07:37:16 -0700 (PDT) From: Bean Huo To: alim.akhtar@samsung.com, avri.altman@wdc.com, asutoshd@codeaurora.org, jejb@linux.ibm.com, martin.petersen@oracle.com, stanley.chu@mediatek.com, beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com, cang@codeaurora.org Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] scsi: ufs: remove several redundant goto statements Date: Wed, 12 Aug 2020 16:37:04 +0200 Message-Id: <20200812143704.30245-3-huobean@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200812143704.30245-1-huobean@gmail.com> References: <20200812143704.30245-1-huobean@gmail.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org From: Bean Huo Signed-off-by: Bean Huo --- drivers/scsi/ufs/ufshcd.c | 26 +++++--------------------- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index e3663b85e8ee..cd742c4f78b6 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -4256,10 +4256,8 @@ int ufshcd_make_hba_operational(struct ufs_hba *hba) dev_err(hba->dev, "Host controller not ready to process requests"); err = -EIO; - goto out; } -out: return err; } EXPORT_SYMBOL_GPL(ufshcd_make_hba_operational); @@ -5542,10 +5540,8 @@ static bool ufshcd_quirk_dl_nac_errors(struct ufs_hba *hba) hba->saved_err &= ~UIC_ERROR; /* clear NAC error */ hba->saved_uic_err &= ~UFSHCD_UIC_DL_NAC_RECEIVED_ERROR; - if (!hba->saved_uic_err) { + if (!hba->saved_uic_err) err_handling = false; - goto out; - } } out: spin_unlock_irqrestore(hba->host->host_lock, flags); @@ -7604,12 +7600,10 @@ static int ufshcd_config_vreg(struct device *dev, if (vreg->min_uV && vreg->max_uV) { min_uV = on ? vreg->min_uV : 0; ret = regulator_set_voltage(reg, min_uV, vreg->max_uV); - if (ret) { + if (ret) dev_err(dev, "%s: %s set voltage failed, err=%d\n", __func__, name, ret); - goto out; - } } } out: @@ -7672,8 +7666,6 @@ static int ufshcd_setup_vreg(struct ufs_hba *hba, bool on) goto out; ret = ufshcd_toggle_vreg(dev, info->vccq2, on); - if (ret) - goto out; out: if (ret) { @@ -7719,10 +7711,8 @@ static int ufshcd_init_vreg(struct ufs_hba *hba) goto out; ret = ufshcd_get_vreg(dev, info->vccq); - if (ret) - goto out; - - ret = ufshcd_get_vreg(dev, info->vccq2); + if (!ret) + ret = ufshcd_get_vreg(dev, info->vccq2); out: return ret; } @@ -7866,12 +7856,7 @@ static int ufshcd_variant_hba_init(struct ufs_hba *hba) err = ufshcd_vops_setup_regulators(hba, true); if (err) - goto out_exit; - - goto out; - -out_exit: - ufshcd_vops_exit(hba); + ufshcd_vops_exit(hba); out: if (err) dev_err(hba->dev, "%s: variant %s init failed err %d\n", @@ -8036,7 +8021,6 @@ static int ufshcd_set_dev_pwr_mode(struct ufs_hba *hba, } cmd[4] = pwr_mode << 4; - /* * Current function would be generally called from the power management * callbacks hence set the RQF_PM flag so that it doesn't resume the