From patchwork Tue Aug 18 22:35:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 11722269 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 88B0F618 for ; Tue, 18 Aug 2020 22:35:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7058520709 for ; Tue, 18 Aug 2020 22:35:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eLGXHWAN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726985AbgHRWfe (ORCPT ); Tue, 18 Aug 2020 18:35:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726539AbgHRWfa (ORCPT ); Tue, 18 Aug 2020 18:35:30 -0400 Received: from mail-qv1-xf43.google.com (mail-qv1-xf43.google.com [IPv6:2607:f8b0:4864:20::f43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3CCBC061389 for ; Tue, 18 Aug 2020 15:35:29 -0700 (PDT) Received: by mail-qv1-xf43.google.com with SMTP id x6so10396432qvr.8 for ; Tue, 18 Aug 2020 15:35:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=FKW2AsEGrqOkUGisBBsOWQZvgPJeV2KTWyYv1yn5u8A=; b=eLGXHWANOpQrO7jl5NqdmdOcOIZMJkYDIR2raD0IHDoBLpfgUMlS02MCpWVmR4/mI9 X0gQYtqcfj89cVpksx8cJ5NMGdJnosKyQC8/pe4bjGlfzXYqD1D24/uZkJ9SQeuAFhQB BvCo6Arg0PRyks7pBSf3ceuuMLEyaA5xuTPK7HWbG+3gRjY3DFoKzALtINVL88h2C/pV dYZFfLyFBaKoz2gPlFuQX2X3ZuujDr3PAK6fAlw21Ks8edy0Xigp6muefDs/wRMCveDL i3sipuIynPmz2T5+IINIjt4GW1Uvz/1WXye/KgO6NWTD2/SEDYCbB32Vg/MrkXW/RpZi Fxpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=FKW2AsEGrqOkUGisBBsOWQZvgPJeV2KTWyYv1yn5u8A=; b=JZDk9mZ2aECT4nt2mJJGcynw3W41rIWr0eCazZKN2J0cdeA2q6/6exSCnz+hWKB3zu SsHjfYBCFtqp3KipWUOOXIOG7Zm2QUwdBscIHbnFRryCfwJuUpQU2bTOYZZaEoERmizq SAvEZlg5mdSe9SmC26kOG71vBw53mQ0jOpiYkMDz9EnN2cUY1D8qDdtLP50NEDt1if4k YpaSpIj+BASlI+ZM91/ZtdNpPC8q8FRsywHqtGUMk42+/17DMSicSTMWS5mGFz+gjcGv 2youGwhS3P95a8qAUCOhfiRLj5tAchRZ0zvU5PxWZK2WJZsz1EpCMTBypnDnzJu8zT/1 ZpJw== X-Gm-Message-State: AOAM532Qbv/OG3T8lKqdcMKp/cul26iOEXqFk0WrSdIzx+xwBzQumDdy gNSaRlzc14goVwoKcfJUBxI= X-Google-Smtp-Source: ABdhPJys7DviPVv1yFhFIwYvOnyMURKO0q33QD5nRC0Fy1snmdqy/IV4pP5hW7KpgHZcESqrq/nhog== X-Received: by 2002:a05:6214:1467:: with SMTP id c7mr21050041qvy.233.1597790128814; Tue, 18 Aug 2020 15:35:28 -0700 (PDT) Received: from localhost.localdomain ([2804:14c:482:4fb::1000]) by smtp.gmail.com with ESMTPSA id t25sm24459478qtp.22.2020.08.18.15.35.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2020 15:35:28 -0700 (PDT) From: Fabio Estevam To: broonie@kernel.org Cc: linux-spi@vger.kernel.org, Fabio Estevam Subject: [PATCH 1/2] spi: imx: Do not print an error when PIO is used Date: Tue, 18 Aug 2020 19:35:18 -0300 Message-Id: <20200818223519.8737-1-festevam@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org There are cases that DMA is not used and the driver gracefully falls back to PIO mode. Do not treat it like an error message and move it to debug level instead. Signed-off-by: Fabio Estevam --- drivers/spi/spi-imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index fdc25f549378..a06679ab64f9 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -1693,7 +1693,7 @@ static int spi_imx_probe(struct platform_device *pdev) goto out_clk_put; if (ret < 0) - dev_err(&pdev->dev, "dma setup error %d, use pio\n", + dev_dbg(&pdev->dev, "dma setup error %d, use pio\n", ret); } From patchwork Tue Aug 18 22:35:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 11722271 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CC8071744 for ; Tue, 18 Aug 2020 22:35:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB5F520786 for ; Tue, 18 Aug 2020 22:35:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aytCj721" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726539AbgHRWff (ORCPT ); Tue, 18 Aug 2020 18:35:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726807AbgHRWfc (ORCPT ); Tue, 18 Aug 2020 18:35:32 -0400 Received: from mail-qv1-xf41.google.com (mail-qv1-xf41.google.com [IPv6:2607:f8b0:4864:20::f41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D26C2C061342 for ; Tue, 18 Aug 2020 15:35:31 -0700 (PDT) Received: by mail-qv1-xf41.google.com with SMTP id dd12so10408097qvb.0 for ; Tue, 18 Aug 2020 15:35:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=oLuu4CbE9W3CLN17FQ58IjamALm9fwXvUmKYkx3ooJY=; b=aytCj721WKwh0ucOa7sxh9kODRFjtwKITtdYEmeMPZulm32FaQSTIOKh+6cJCkw0Ko 0bSygyvPGWXFrNUS7qsBMYuqpXPfAQPWd00EVzvn5lB63dDkbju4o/RJG4LkQRMIaGMN G30aGtAPvN8GRE+u3+1J1KF55+IPMmps2RkSZKGm019dca/dwFkvTuiyFlkg5qYxY78z +UQeaV8NhJ2F6SKXhQMK3ayKTeP6m5ZyU94kLqaxpBPj4BCULHmnwlnYY6g+qfrlu1sJ dZ77IId1LOv16zFm4MKf430wTh9XbH3skjv3oc1rHy8tXDLaUNIexL+0/+m3Dne8K8Cy KN2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=oLuu4CbE9W3CLN17FQ58IjamALm9fwXvUmKYkx3ooJY=; b=kAIZd927NvY9eC3jvufb5kTbQ/RyIQzzDv/B2b1HUwNyPx0F89dtHIGbS2ZGQmhsFa N0jAA9qVmf+sWT16Hodgfp0smI/nkT4J1MQZpdrpui+kG+33ak2nSa57L+xP1YZ7BQ3r vvL1G91PB3HirpK77WxTRzopTm/u6ZqKqVkSEGn1TmTe3gwJpe9knC4LiViaSP/yzIdQ IZJOKp/RBjdySwsZhyvhh2JddATK2sRcFlM2HP3gW3YnYMYU47dzGGAcrCtlLTEdQHBR WBxacWGxHhGg0pQE1OKg1iYbCOqMbqYNnP3jTcZ0UGLkQhOfep6yv1cu7jbPnsyFjbfR Kskg== X-Gm-Message-State: AOAM532NeTIdqCxcN8cs/FMys2fcffKrGo+whAA6v9xrIZEA0IXC3aKy 3nHmpJaR4x18rMce9s7eaNo= X-Google-Smtp-Source: ABdhPJyyythsPJHNwo7+KCmtfEQYkxX0wqXh5vH1MunRRrvptJ3bCA/OpfxRHTf5GscXthxcNKxlhw== X-Received: by 2002:a05:6214:612:: with SMTP id z18mr21700465qvw.25.1597790131110; Tue, 18 Aug 2020 15:35:31 -0700 (PDT) Received: from localhost.localdomain ([2804:14c:482:4fb::1000]) by smtp.gmail.com with ESMTPSA id t25sm24459478qtp.22.2020.08.18.15.35.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2020 15:35:30 -0700 (PDT) From: Fabio Estevam To: broonie@kernel.org Cc: linux-spi@vger.kernel.org, Fabio Estevam Subject: [PATCH 2/2] spi: imx: Remove unneeded probe message Date: Tue, 18 Aug 2020 19:35:19 -0300 Message-Id: <20200818223519.8737-2-festevam@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200818223519.8737-1-festevam@gmail.com> References: <20200818223519.8737-1-festevam@gmail.com> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org There is no point in printing a plain "probed" message on successful probe. Just remove it and make the kernel log a bit less noisier. Signed-off-by: Fabio Estevam --- drivers/spi/spi-imx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index a06679ab64f9..5f5c114ab935 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -1708,8 +1708,6 @@ static int spi_imx_probe(struct platform_device *pdev) goto out_clk_put; } - dev_info(&pdev->dev, "probed\n"); - clk_disable(spi_imx->clk_ipg); clk_disable(spi_imx->clk_per); return ret;