From patchwork Fri Sep 4 14:21:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Pieralisi X-Patchwork-Id: 11757401 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E7CAE14EB for ; Fri, 4 Sep 2020 14:22:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A28C1206B7 for ; Fri, 4 Sep 2020 14:22:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qI8lw/AG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A28C1206B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=FII+n/HhPfoV+WeqoR8RtJMMMaByPsU/z4pEKxmY/bE=; b=qI8lw/AG6JfIgxA4wVtiDH83/k IKthbbpbGgnBQJDUIlETi7P9MKPB5RMURJgoRdCANRKpdN1Tt4E0BvuiDyoAj6YoI6F0Nb2lISRDT jolM7YcZDzYpRUerW2HUVqMYwQXPqMXSrXkd9XkcTq7foZjbPcBQPIZSQj7AINGyrEQBhDiZW2l1V PfENMp2pLQe+KXZVn9X0+EUkw1KiP/cfTLgyeReufa11txUWMvvarU/tWuwF1lamIcVupvubBgLXB WxxABqtuW9PZ4Dv9tzP2DCmwMzWpnfEZwJsKGAXcmfLBIdUKDdoHoXXyerT1pbz4TenIPjXG2IrWt kzCuhKwg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kECb7-0000OX-Dl; Fri, 04 Sep 2020 14:21:49 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kECb4-0000NA-6k for linux-arm-kernel@lists.infradead.org; Fri, 04 Sep 2020 14:21:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DF5EB1045; Fri, 4 Sep 2020 07:21:43 -0700 (PDT) Received: from red-moon.arm.com (unknown [10.57.6.237]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0C2E33F71F; Fri, 4 Sep 2020 07:21:42 -0700 (PDT) From: Lorenzo Pieralisi To: linux-pci@vger.kernel.org Subject: [PATCH] PCI: mvebu: Remove useless msi_controller allocation/initialization Date: Fri, 4 Sep 2020 15:21:32 +0100 Message-Id: <20200904142132.6054-1-lorenzo.pieralisi@arm.com> X-Mailer: git-send-email 2.26.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200904_102146_327184_3766B77C X-CRM114-Status: GOOD ( 12.25 ) X-Spam-Score: -2.3 (--) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-2.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [217.140.110.172 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Lorenzo Pieralisi , linux-arm-kernel@lists.infradead.org, Thomas Petazzoni Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The mvebu host controller driver allocates an msi_controller structure without assigning its methods. This means that the PCI IRQ MSI layer ignores it and that after all it should not really be needed. Remove it. Signed-off-by: Lorenzo Pieralisi Cc: Rob Herring Cc: Thomas Petazzoni Reviewed-by: Rob Herring --- drivers/pci/controller/pci-mvebu.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c index c39978b750ec..eee82838f4ba 100644 --- a/drivers/pci/controller/pci-mvebu.c +++ b/drivers/pci/controller/pci-mvebu.c @@ -12,7 +12,6 @@ #include #include #include -#include #include #include #include @@ -70,7 +69,6 @@ struct mvebu_pcie_port; struct mvebu_pcie { struct platform_device *pdev; struct mvebu_pcie_port *ports; - struct msi_controller *msi; struct resource io; struct resource realio; struct resource mem; @@ -1127,7 +1125,6 @@ static int mvebu_pcie_probe(struct platform_device *pdev) bridge->sysdata = pcie; bridge->ops = &mvebu_pcie_ops; bridge->align_resource = mvebu_pcie_align_resource; - bridge->msi = pcie->msi; return mvebu_pci_host_probe(bridge); }