From patchwork Sat Sep 5 06:06:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kiwoong Kim X-Patchwork-Id: 11758801 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CDE02138E for ; Sat, 5 Sep 2020 06:16:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39C672145D for ; Sat, 5 Sep 2020 06:16:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="RYzUqtwJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726469AbgIEGP7 (ORCPT ); Sat, 5 Sep 2020 02:15:59 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:41679 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726261AbgIEGP4 (ORCPT ); Sat, 5 Sep 2020 02:15:56 -0400 Received: from epcas2p2.samsung.com (unknown [182.195.41.54]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20200905061554epoutp02a391380d5ca969c55a53fc00ee5ba4d2~xzqXBascj2144921449epoutp02f for ; Sat, 5 Sep 2020 06:15:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20200905061554epoutp02a391380d5ca969c55a53fc00ee5ba4d2~xzqXBascj2144921449epoutp02f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599286554; bh=bY5HPZ6KUVgZQzbpmndQlSwrROu7+JPKJ7q2qrajB3c=; h=From:To:Cc:Subject:Date:In-Reply-To:In-Reply-To:References:From; b=RYzUqtwJEgb40LicuDBBjunlp1t2etOXS/5Aa0ZAfJ6fTEhIANyiXQfmLQ10NmEln VKNpoi58g+yF6h1q1StseR/LaN2gpMlvWed/t5VyQxEd+8oCu4br4KfTD9rbxceQYN AxZFsyWBxr/4wx1+gU/fZCAMuiIRnACmxI1qQD1c= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas2p2.samsung.com (KnoxPortal) with ESMTP id 20200905061552epcas2p2c9020c7caa7a4c755549b2410c178484~xzqVx2J0l1088310883epcas2p2q; Sat, 5 Sep 2020 06:15:52 +0000 (GMT) Received: from epsmges2p2.samsung.com (unknown [182.195.40.188]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4Bk46Z3mpGzMqYkV; Sat, 5 Sep 2020 06:15:50 +0000 (GMT) Received: from epcas2p1.samsung.com ( [182.195.41.53]) by epsmges2p2.samsung.com (Symantec Messaging Gateway) with SMTP id A9.68.18874.61D235F5; Sat, 5 Sep 2020 15:15:50 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas2p3.samsung.com (KnoxPortal) with ESMTPA id 20200905061549epcas2p3e3554be6bb9737f3133529ebac4ce99a~xzqTPOJLy1024910249epcas2p3b; Sat, 5 Sep 2020 06:15:49 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200905061549epsmtrp1b9d9dc11be9202deb75a8e3fac238e34~xzqTLmTYk1722117221epsmtrp1S; Sat, 5 Sep 2020 06:15:49 +0000 (GMT) X-AuditID: b6c32a46-503ff700000049ba-05-5f532d162295 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 9E.EE.08303.51D235F5; Sat, 5 Sep 2020 15:15:49 +0900 (KST) Received: from ubuntu.dsn.sec.samsung.com (unknown [12.36.155.120]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200905061549epsmtip1ea7875d68d86142d54fa934adabdd9f7~xzqS9l43-1143111431epsmtip1P; Sat, 5 Sep 2020 06:15:49 +0000 (GMT) From: Kiwoong Kim To: linux-scsi@vger.kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com, martin.petersen@oracle.com, beanhuo@micron.com, asutoshd@codeaurora.org, cang@codeaurora.org, bvanassche@acm.org, grant.jung@samsung.com, sc.suh@samsung.com, hy50.seo@samsung.com, sh425.lee@samsung.com Cc: Kiwoong Kim Subject: [PATCH v4 1/2] ufs: introduce skipping manual flush for wb Date: Sat, 5 Sep 2020 15:06:51 +0900 Message-Id: <3cf3e93696510922b775d8887ca8408dd384648b.1599285983.git.kwmad.kim@samsung.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: In-Reply-To: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFJsWRmVeSWpSXmKPExsWy7bCmqa6YbnC8wf4p0hYP5m1js9jbdoLd 4uXPq2wWBx92slhM+/CT2eLT+mWsFr/+rme3WL34AYvFohvbmCxubjnKYtF9fQebxfLj/5gs uu7eYLRY+u8tiwOfx+Ur3h6X+3qZPCYsOsDo8X19B5vHx6e3WDz6tqxi9Pi8Sc6j/UA3UwBH VI5NRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtDdSgpl iTmlQKGAxOJiJX07m6L80pJUhYz84hJbpdSClJwCQ8MCveLE3OLSvHS95PxcK0MDAyNToMqE nIzHHy4wFVzkrfh+YxVLA+N27i5GTg4JAROJ85O2soHYQgI7GCWev87tYuQCsj8xSmyddIId wvkM5Nzdyw7TMfXVDVaIxC5GieY1BxkhnB+MEjP7XjGBVLEJaEo8vTmVCSQhIrCZSeLVgvvM IAlmAXWJXRNOgBUJCzhLLFxwDCzOIqAqMenNKrBDeAWiJT69XsgGsU5O4ua5TrAaTgFLiW+d q9lQ2VxANRM5JG6t3gM0lAPIcZFYPd0ToldY4tXxLVBnS0m87G+Dsusl9k1tYIXo7WGUeLrv HyNEwlhi1rN2RpA5zEAfrN+lDzFSWeLILRaI8/kkOg7/ZYcI80p0tAlBNCpL/Jo0GWqIpMTM m3egNnlIXP5+Fxo+QJuWrtrCOIFRfhbCggWMjKsYxVILinPTU4uNCoyQY28TIziRarntYJzy 9oPeIUYmDsZDjBIczEoivB7nAuOFeFMSK6tSi/Lji0pzUosPMZoCw3Eis5Rocj4wleeVxBua GpmZGViaWpiaGVkoifPWK16IExJITyxJzU5NLUgtgulj4uCUamByeKIVs+h1m9s/hnnWfVry W5vm3+CevuHeAxbf/A8H2hv3z4lp+G3ws3yHEq+1aly7jVHDp3Mntf4enBl7+cNm/oAzxveD j5bOYtE+uV1SVeChzdkP+ak5TVaPluYveTLPauLitxIh1p6epVYzBRwE263YFOI40ytFll7e 9TTIzb15z9siyw1b5O8kPnzt3SVhLn3Uyj9t6Wl9a+Ynr6yZSuoSGFuuO1bOMjfyjvloWcjm cdT76JYjrvPizikyTb53NOru5w8Hck/5m5cJPHBLl8z4KRxjkPErpz1q8pWCR5s75csm8WTs PaEzMXF9m79zScb+M++0Ww1vRjCFfVh8ZR9v7UI37S2xastMhZRYijMSDbWYi4oTAcwGrZYt BAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPLMWRmVeSWpSXmKPExsWy7bCSnK6obnC8Qfs1PYsH87axWextO8Fu 8fLnVTaLgw87WSymffjJbPFp/TJWi19/17NbrF78gMVi0Y1tTBY3txxlsei+voPNYvnxf0wW XXdvMFos/feWxYHP4/IVb4/Lfb1MHhMWHWD0+L6+g83j49NbLB59W1YxenzeJOfRfqCbKYAj issmJTUnsyy1SN8ugSvj8YcLTAUXeSu+31jF0sC4nbuLkZNDQsBEYuqrG6xdjFwcQgI7GCXu LJ7OCJGQlDix8zmULSxxv+UIVNE3RonjN5eCJdgENCWe3pzKBJIQETjMJPF/63N2kASzgLrE rgknmEBsYQFniYULjjGD2CwCqhKT3qxiA7F5BaIlPr1eyAaxQU7i5rlOsBpOAUuJb52rgeIc QNssJD4+UcUhPIFRYAEjwypGydSC4tz03GLDAqO81HK94sTc4tK8dL3k/NxNjOA40NLawbhn 1Qe9Q4xMHIyHGCU4mJVEeD3OBcYL8aYkVlalFuXHF5XmpBYfYpTmYFES5/06a2GckEB6Yklq dmpqQWoRTJaJg1OqgWl7jWXnrATXDdzO1xpn7KhLa/cW1H5Q0XYtWPhOw1/DkhvOrw+vN/yq s06tKc5T5rSYekJUqm7GxducpZNst5m+8QltrFk59wTTma6NUTr3U54I/JlhnrVJnceNUUr7 ycZaq+NLje/Ommd/8lTO5AkTgmx0PSp/9/ybdXhdZ/lWq2k1stVf3qn23r8yS3i17AHxZauV /Xil5O9zfP6reVNLzK22KbT0rJfTcYPixS4x6/kdDnUI3+i5xN/7X8DLeVpI5aqzkly3pXZl B3Gf4RUv+ynsm27HYvcw3Js73C1ubfYJJ0GpKhNv7rVn5TnvC4jwJyjfvqZRtob/WIYN/5I4 neje90HaB6t6jRWVWIozEg21mIuKEwGJkWqb8gIAAA== X-CMS-MailID: 20200905061549epcas2p3e3554be6bb9737f3133529ebac4ce99a X-Msg-Generator: CA X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20200905061549epcas2p3e3554be6bb9737f3133529ebac4ce99a References: Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org We have two knobs to flush for write booster, i.e. fWriteBoosterBufferFlushDuringHibernate and fWriteBoosterBufferFlushEn. However, many product makers uses only fWriteBoosterBufferFlushDuringHibernate, because this can reportedly cover most scenarios and there have been some reports that flush by fWriteBoosterBufferFlushEn could lead to raise power consumption thanks to unexpected internal operations. So we need a way to enable or disable fWriteBoosterEn operations. For those case, this quirk will allow to avoid manual flush Signed-off-by: Kiwoong Kim Reviewed-by: Avri Altman --- drivers/scsi/ufs/ufshcd.c | 3 +++ drivers/scsi/ufs/ufshcd.h | 5 +++++ 2 files changed, 8 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 64bd59c..54a2259 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -5307,6 +5307,9 @@ static int ufshcd_wb_toggle_flush_during_h8(struct ufs_hba *hba, bool set) static inline void ufshcd_wb_toggle_flush(struct ufs_hba *hba, bool enable) { + if (hba->quirks & UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL) + return; + if (enable) ufshcd_wb_buf_flush_enable(hba); else diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h index 02bd405..e99efee 100644 --- a/drivers/scsi/ufs/ufshcd.h +++ b/drivers/scsi/ufs/ufshcd.h @@ -531,6 +531,11 @@ enum ufshcd_quirks { * OCS FATAL ERROR with device error through sense data */ UFSHCD_QUIRK_BROKEN_OCS_FATAL_ERROR = 1 << 10, + + /* + * This quirk needs to disable manual flush for write booster + */ + UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL = 1 << 11, }; enum ufshcd_caps { From patchwork Sat Sep 5 06:06:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kiwoong Kim X-Patchwork-Id: 11758805 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B4E1692C for ; Sat, 5 Sep 2020 06:16:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9962E2145D for ; Sat, 5 Sep 2020 06:16:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="Nl48W+nS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726568AbgIEGQF (ORCPT ); Sat, 5 Sep 2020 02:16:05 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:55125 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726381AbgIEGP6 (ORCPT ); Sat, 5 Sep 2020 02:15:58 -0400 Received: from epcas2p2.samsung.com (unknown [182.195.41.54]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20200905061554epoutp01a0d0909a6addc1f966e351e2e60eab10~xzqXTiIBW1816118161epoutp01R for ; Sat, 5 Sep 2020 06:15:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20200905061554epoutp01a0d0909a6addc1f966e351e2e60eab10~xzqXTiIBW1816118161epoutp01R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599286554; bh=ozBcYL4GOFetvj3IzQDqG8OkSvnIuF3YAsvBlwvB578=; h=From:To:Cc:Subject:Date:In-Reply-To:In-Reply-To:References:From; b=Nl48W+nSYQOq9WGw1xnzMOJjvCgVuuddp0cQyI/s+PY7jsFQKxd7bzk9L/LMK1unZ Nqfa7IyGsb0/80pvOUPRW9Vq2WaFiRUlL5rrcPqqALHBZXaYTFcRPcg+VDIhzmebGi v/iOSvm6ClzQjKw11Si5ilLGfewPJk2ldvco9J1E= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas2p1.samsung.com (KnoxPortal) with ESMTP id 20200905061553epcas2p147abd0cc7db1315a67c5b0b6b0f6ee77~xzqW0JUlQ2988129881epcas2p1O; Sat, 5 Sep 2020 06:15:53 +0000 (GMT) Received: from epsmges2p3.samsung.com (unknown [182.195.40.185]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4Bk46b4jBKzMqYkW; Sat, 5 Sep 2020 06:15:51 +0000 (GMT) Received: from epcas2p1.samsung.com ( [182.195.41.53]) by epsmges2p3.samsung.com (Symantec Messaging Gateway) with SMTP id 29.96.27441.71D235F5; Sat, 5 Sep 2020 15:15:51 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas2p3.samsung.com (KnoxPortal) with ESMTPA id 20200905061551epcas2p39976167b31a737e4093f0a421c71ee12~xzqUS7y5p1024910249epcas2p3c; Sat, 5 Sep 2020 06:15:51 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200905061551epsmtrp2ea486131da8957c7e1d3a7bb6382839a~xzqURkoTC3004930049epsmtrp2K; Sat, 5 Sep 2020 06:15:51 +0000 (GMT) X-AuditID: b6c32a47-fafff70000006b31-1a-5f532d17ebc3 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 8F.EE.08303.61D235F5; Sat, 5 Sep 2020 15:15:50 +0900 (KST) Received: from ubuntu.dsn.sec.samsung.com (unknown [12.36.155.120]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200905061550epsmtip11bd0102bbad08d1f9cfd74cd3fcc84b3~xzqUCvbxa1142811428epsmtip1U; Sat, 5 Sep 2020 06:15:50 +0000 (GMT) From: Kiwoong Kim To: linux-scsi@vger.kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com, martin.petersen@oracle.com, beanhuo@micron.com, asutoshd@codeaurora.org, cang@codeaurora.org, bvanassche@acm.org, grant.jung@samsung.com, sc.suh@samsung.com, hy50.seo@samsung.com, sh425.lee@samsung.com Cc: Kiwoong Kim Subject: [PATCH v4 2/2] ufs: exynos: enable UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL Date: Sat, 5 Sep 2020 15:06:52 +0900 Message-Id: X-Mailer: git-send-email 2.7.4 In-Reply-To: In-Reply-To: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNJsWRmVeSWpSXmKPExsWy7bCmqa64bnC8wdQ9ihYP5m1js9jbdoLd 4uXPq2wWBx92slhM+/CT2eLT+mWsFr/+rme3WL34AYvFohvbmCxubjnKYtF9fQebxfLj/5gs uu7eYLRY+u8tiwOfx+Ur3h6X+3qZPCYsOsDo8X19B5vHx6e3WDz6tqxi9Pi8Sc6j/UA3UwBH VI5NRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtDdSgpl iTmlQKGAxOJiJX07m6L80pJUhYz84hJbpdSClJwCQ8MCveLE3OLSvHS95PxcK0MDAyNToMqE nIwjh28zFizmqLh6ej97A+Mbti5GTg4JAROJ/psnGbsYuTiEBHYwSsxadZsJwvnEKPH20klW COczo8Trtq9MMC2zDr9kBbGFBHYBJfZIQxT9YJS4t2A12Fw2AU2Jpzengo0SEdjMJPFqwX1m kASzgLrErgknwCYJC4RIvNwzH2wSi4CqxIm58xhBbF6BaImF266zQmyTk7h5rhOsl1PAUuJb J8QCBJsLqGYqh8Sue4eYIRpcJLbvb4E6VVji1fEt7BC2lMTnd3uhvq6X2De1gRWiuYdR4um+ f4wQCWOJWc/agWwOoEs1Jdbv0gcxJQSUJY7cYoG4n0+i4/Bfdogwr0RHmxBEo7LEr0mToYZI Ssy8eQdqq4fE3Pnt0FAE2rRj0Ry2CYzysxAWLGBkXMUollpQnJueWmxUYIwcfZsYwalUy30H 44y3H/QOMTJxMB5ilOBgVhLh9TgXGC/Em5JYWZValB9fVJqTWnyI0RQYkBOZpUST84HJPK8k 3tDUyMzMwNLUwtTMyEJJnLfY6kKckEB6YklqdmpqQWoRTB8TB6dUA5OM0UqR3Vwi+vuj9v/u PfNjkvJZPT2VV9/c9mxmk9L1mNr6Mbdgb2GstkVXufyXmu4LDJe61nx7+7CFl3Gt6kTPyK/M 9Sm7Fqxeukdvsteh5u+q4r2Rj1t/lHsubN//c5KetALfEuPj7xW11IWO3trLa7lvVUH2Ymmx Ouag/REMEVVtPtPrd/B9sfCuPO/R0/77wYP1IeYfDf+dXHlQoe/eG998C6PjnmpfTL6et1OL fLfRed/Txb8sFii8u8Ly9fGWC9HblIV3nU73rNjPLmTPwySn9qjNxif6zOrvvbpmdkKX5uwt UEncpP7nXMK1Yz3nT7OHHDdv/POTXWxOad6RdXJSguY21Z8n7Jy80FiJpTgj0VCLuag4EQDC +YWRLgQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPLMWRmVeSWpSXmKPExsWy7bCSnK6YbnC8wcpjVhYP5m1js9jbdoLd 4uXPq2wWBx92slhM+/CT2eLT+mWsFr/+rme3WL34AYvFohvbmCxubjnKYtF9fQebxfLj/5gs uu7eYLRY+u8tiwOfx+Ur3h6X+3qZPCYsOsDo8X19B5vHx6e3WDz6tqxi9Pi8Sc6j/UA3UwBH FJdNSmpOZllqkb5dAlfGkcO3GQsWc1RcPb2fvYHxDVsXIyeHhICJxKzDL1m7GLk4hAR2MErM uvsOKiEpcWLnc0YIW1jifssRqKJvjBK98/+xgCTYBDQlnt6cygSSEBE4zCTxf+tzdpAEs4C6 xK4JJ5hAbGGBIIk9XR/BprIIqEqcmDsPbCqvQLTEwm3XWSE2yEncPNfJDGJzClhKfOtcDVTP AbTNQuLjE1UcwhMYBRYwMqxilEwtKM5Nzy02LDDKSy3XK07MLS7NS9dLzs/dxAiOAy2tHYx7 Vn3QO8TIxMF4iFGCg1lJhNfjXGC8EG9KYmVValF+fFFpTmrxIUZpDhYlcd6vsxbGCQmkJ5ak ZqemFqQWwWSZODilGpgWn/Gr2xh4X076u2XgnMKKu++Nypc0Rs+a07p+5zqOiwd0nnPFHmpM M+aye/h6Rvv8eFaZ7KfvmCs8X1xa9a3VjCsqe/u7Hb1+bHI/w3b4n/X6/PS3g7iFf8zrBcIy DEZV/rxvn1R6hn9asbS8R/LuhFVNybtfnNk5+8Vp0w0iJQ5LHmm1BG1+4t/lOjNMVcHUcdrD n04uU144visp4crJnc5u9lj622PBdZ3zjG4tb5yzcPqOyfpXfYODw9c8+Hx9o8jEmIALHYde cx14Ftg4c3tKZPHh+QnZsz2mtLGLCLbeehau0rzqjYViQG2C5MFWfgUbsxlcvu/jzHhdv3JM 3dzVdP7not7dIjMOuFxXYinOSDTUYi4qTgQAhiGBH/ICAAA= X-CMS-MailID: 20200905061551epcas2p39976167b31a737e4093f0a421c71ee12 X-Msg-Generator: CA X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20200905061551epcas2p39976167b31a737e4093f0a421c71ee12 References: Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org For Exynos, only flush during hibern8 is enough for sustaining performance and I think that there is a possiblity of raising current thanks to an increase of internal operations for manual flush. Signed-off-by: Kiwoong Kim Reviewed-by: Avri Altman --- drivers/scsi/ufs/ufs-exynos.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufs-exynos.c b/drivers/scsi/ufs/ufs-exynos.c index 7d383e3..4584f5d 100644 --- a/drivers/scsi/ufs/ufs-exynos.c +++ b/drivers/scsi/ufs/ufs-exynos.c @@ -1290,7 +1290,8 @@ struct exynos_ufs_drv_data exynos_ufs_drvs = { UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR | UFSHCI_QUIRK_BROKEN_HCE | UFSHCI_QUIRK_SKIP_RESET_INTR_AGGR | - UFSHCD_QUIRK_BROKEN_OCS_FATAL_ERROR, + UFSHCD_QUIRK_BROKEN_OCS_FATAL_ERROR | + UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL, .opts = EXYNOS_UFS_OPT_HAS_APB_CLK_CTRL | EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL | EXYNOS_UFS_OPT_BROKEN_RX_SEL_IDX |