From patchwork Mon Sep 7 16:11:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761535 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 757B359D for ; Mon, 7 Sep 2020 16:25:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53963208C7 for ; Mon, 7 Sep 2020 16:25:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495938; bh=kA8UYqwwvl1jhQhlspmrYdcfKcMzh6l6VSdMPGeBWuE=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=g7g5UWS4T6asGAOv4Lf2220wfiEtRWKzQqDjOJVq3lu95IKXVkuFePcjOW5M8kF9z l+m5sXdnr1HqcVbO6KIfUGPUx1gmsJpOC6F4eqS/kg9AgNG3TQVh2lZM1eq+Up265B avY0SLz8rVRyjzKDZ0zjrHN0930GBsZz19J5r43w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730267AbgIGQMc (ORCPT ); Mon, 7 Sep 2020 12:12:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:60778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730259AbgIGQMU (ORCPT ); Mon, 7 Sep 2020 12:12:20 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C751820757; Mon, 7 Sep 2020 16:12:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495140; bh=kA8UYqwwvl1jhQhlspmrYdcfKcMzh6l6VSdMPGeBWuE=; h=From:To:Subject:Date:In-Reply-To:References:From; b=ZHzrPDfLcGKn97n0Gxq++gyxmTSFHfBIT21e2wfJZGkv3gY+Rj/jixhYdec2zzumj s0n9f4k8HFlLPZbhMIw5WfXBsnuDsDBJwdUGmLI6SDCyNrwZsYWgOlRz/n+sGIg9VB gazM7/e3slTF9HAs7T63IAcFbWvHNakMc958tqgs= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [PATCH 01/25] dt-bindings: samsung: pmu: document S5Pv210 Date: Mon, 7 Sep 2020 18:11:17 +0200 Message-Id: <20200907161141.31034-2-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Add compatible for the Samsung S5Pv210 SoC PMU. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml index edbe8c69387b..17678d9686c1 100644 --- a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml @@ -24,6 +24,7 @@ select: - samsung,exynos5420-pmu - samsung,exynos5433-pmu - samsung,exynos7-pmu + - samsung-s5pv210-pmu required: - compatible @@ -40,6 +41,7 @@ properties: - samsung,exynos5420-pmu - samsung,exynos5433-pmu - samsung,exynos7-pmu + - samsung-s5pv210-pmu - const: syscon reg: From patchwork Mon Sep 7 16:11:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761379 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3A21D138E for ; Mon, 7 Sep 2020 16:12:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1696A21775 for ; Mon, 7 Sep 2020 16:12:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495165; bh=mmrbMHMlywRamMbAoD8m1NVZ3xc1llmLdf9vpJqmSWo=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=X8483S+Aw72zf+OshcMzzJ/fElZSzspOXbXUH/kDOr3lW3H4vl2sn4BwI8D+Fooyd d18+cZo1FcY1SUjJH8yopYTtdpNZg1QsR3OU8FnpcSHpyPdSm3+2etc3ZRjh1op/m0 CNHJTs2mNy6PaOYvdfDApHvJuvqAPW4xctTnVoKE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730307AbgIGQMm (ORCPT ); Mon, 7 Sep 2020 12:12:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:60894 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729931AbgIGQMa (ORCPT ); Mon, 7 Sep 2020 12:12:30 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E9171206E6; Mon, 7 Sep 2020 16:12:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495149; bh=mmrbMHMlywRamMbAoD8m1NVZ3xc1llmLdf9vpJqmSWo=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Hxu6rgxfiW5iKv9B71dOEX1kzrSB+ZYt+jhvfDbkfRFnmnvS6eX2DH/XPC4N3lKpu /PgWsiwEnSuoQx8iUkpRVrFOYYn0uFjBMWSd1s4UXaTA9DNVQxGibJkseL5//NfLG9 Eyb3VQ6NgnRYkwyP7nrUpwzH/UwHSLEBjRIPMdzQ= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [PATCH 02/25] dt-bindings: iio: adc: exynos-adc: require second interrupt with touch screen Date: Mon, 7 Sep 2020 18:11:18 +0200 Message-Id: <20200907161141.31034-3-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The ADC in S3C/S5P/Exynos SoCs can be used also for handling touch screen. In such case the second interrupt is required. This second interrupt can be anyway provided, even without touch screens. This fixes dtbs_check warnings like: arch/arm/boot/dts/s5pv210-aquila.dt.yaml: adc@e1700000: interrupts: [[23], [24]] is too long Signed-off-by: Krzysztof Kozlowski Acked-by: Jonathan Cameron --- .../bindings/iio/adc/samsung,exynos-adc.yaml | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml index cc3c8ea6a894..89b4f9c252a6 100644 --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml @@ -41,7 +41,10 @@ properties: maxItems: 2 interrupts: - maxItems: 1 + description: + ADC interrupt followed by optional touchscreen interrupt. + minItems: 1 + maxItems: 2 "#io-channel-cells": const: 1 @@ -107,6 +110,16 @@ allOf: items: - const: adc + - if: + properties: + has-touchscreen: + true + then: + properties: + interrupts: + minItems: 2 + maxItems: 2 + examples: - | adc: adc@12d10000 { From patchwork Mon Sep 7 16:11:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761525 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2F0D359D for ; Mon, 7 Sep 2020 16:25:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12D4720757 for ; Mon, 7 Sep 2020 16:25:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495920; bh=huRRtVQAV4kXuTBNP9D6urMFzmt8KLZCSNdWyYF4x5A=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=2vNYDIm7tiykGFYY/SFEKXsdRTxGGSX1GShE0oh67SXx/xCFiAbTUHNR13nbhqa3G lV2O/fAh6lrOrEOgPOcN8aPg2zaSs70iyjE31tZq3ACwMbTglRbgb0Fz9DhBxfbd66 KUut+cfxIVHGOzJ2M/RtSqyElqomMI3G0CAkYTSo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730325AbgIGQMn (ORCPT ); Mon, 7 Sep 2020 12:12:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:60964 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729937AbgIGQMg (ORCPT ); Mon, 7 Sep 2020 12:12:36 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1270421789; Mon, 7 Sep 2020 16:12:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495155; bh=huRRtVQAV4kXuTBNP9D6urMFzmt8KLZCSNdWyYF4x5A=; h=From:To:Subject:Date:In-Reply-To:References:From; b=AAhaIjLCHPgSP4hTnbUU5WAX8BN7tc0jQNKZB7arK9c5SQ+dauvzHVbRJp1wFjsaD OfpmxIivh9T65EjT7ZKDeaMqKx2zM954N46rSbigDf7q82Vjb6kJUpOqXTWMMMOGt6 5iqhY+vqX8A2YEuZNS8SXqs9wlQWvLjBVGqvOOt0= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [PATCH 03/25] dt-bindings: iio: adc: exynos-adc: do not require syscon on S5Pv210 Date: Mon, 7 Sep 2020 18:11:19 +0200 Message-Id: <20200907161141.31034-4-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The ADC in S5Pv210 does not have ADC phy registers in separate block for which syscon would be needed. Remove this requirement to fix dtbs_check warnings like: arch/arm/boot/dts/s5pv210-fascinate4g.dt.yaml: adc@e1700000: 'samsung,syscon-phandle' is a required property Signed-off-by: Krzysztof Kozlowski Acked-by: Jonathan Cameron --- .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml index 89b4f9c252a6..75174af72288 100644 --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml @@ -81,7 +81,6 @@ allOf: - samsung,exynos-adc-v2 - samsung,exynos3250-adc - samsung,exynos4212-adc - - samsung,s5pv210-adc then: required: - samsung,syscon-phandle From patchwork Mon Sep 7 16:11:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761529 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8B4301599 for ; Mon, 7 Sep 2020 16:25:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69C122192A for ; Mon, 7 Sep 2020 16:25:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495926; bh=oQutU7eoT4DFfkecRuD/WmWdYMLZJlQ9/R4YqBUhAgU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=zdmwk866DNhEFCtY776OMwF1/fMQhl2WYHjWeBH9mLzpnjduBNNkr6t6WVMbHP64z lFYnueG64XYuFoAIysLKF8gvq0E/knY6tiHVhIVtDMH6sKFM4wKMJdAPz0qKU0Azzb 20Q7ChI382I4SbMflGyKGblE/tACrbCP3k/QYWQU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730362AbgIGQZR (ORCPT ); Mon, 7 Sep 2020 12:25:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:32814 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730333AbgIGQMn (ORCPT ); Mon, 7 Sep 2020 12:12:43 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 18BEF207DE; Mon, 7 Sep 2020 16:12:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495163; bh=oQutU7eoT4DFfkecRuD/WmWdYMLZJlQ9/R4YqBUhAgU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SHYWhNyqz/iY+3timtuojVIEZ3CNEAJ+Fr/n8RMz5apc1CZua9Lz/KBPEpWoebFc+ wqfw7dVGNSrjBREcVT7le9oozJm/yf9NOkC3Q8aCVrwq2/zxX2eXAqymf4ddfPDUAY 49a7cLoKYppZ3Wm0viNQsmDEMfAN10/9l+TW4jjw= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH 04/25] ARM: dts: s5pv210: fix pinctrl property of "vibrator-en" regulator in Aries Date: Mon, 7 Sep 2020 18:11:20 +0200 Message-Id: <20200907161141.31034-5-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Fix typo in pinctrl property of "vibrator-en" fixed regulator in Aries family of boards. The error caused lack of pin configuration for the GPIO used in vibrator. Fixes: 04568cb58a43 ("ARM: dts: s5pv210: Disable pull for vibrator enable GPIO on Aries boards") Cc: Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s5pv210-aries.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi index a3f83f668ce1..6ba23562da46 100644 --- a/arch/arm/boot/dts/s5pv210-aries.dtsi +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi @@ -59,7 +59,7 @@ gpio = <&gpj1 1 GPIO_ACTIVE_HIGH>; pinctrl-names = "default"; - pinctr-0 = <&vibrator_ena>; + pinctrl-0 = <&vibrator_ena>; }; touchkey_vdd: regulator-fixed-1 { From patchwork Mon Sep 7 16:11:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761521 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1337A59D for ; Mon, 7 Sep 2020 16:25:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF76721789 for ; Mon, 7 Sep 2020 16:25:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495917; bh=Bhn6KRdaULsG9pRYzH7uLvigiJIcrPVsqWuLDn7U+iA=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=WpxqvQ9oXKykBgdKXESIWAc/BEGC0ZuAF/wF1h6uw07I7KN6sladhW/nGmuI0wWTU iTFbkjNQ0G1Vj4jC1aL8QJpKRHR6uczjui0Dmg4qB8byZxRO5X0v3H4rj8owFHxNU8 Q9buYjrVyiD6zwyQFr6eGWNk2LfVEV+JnJiZ17Yc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729924AbgIGQZI (ORCPT ); Mon, 7 Sep 2020 12:25:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:32894 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730362AbgIGQMt (ORCPT ); Mon, 7 Sep 2020 12:12:49 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5FE4C20757; Mon, 7 Sep 2020 16:12:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495169; bh=Bhn6KRdaULsG9pRYzH7uLvigiJIcrPVsqWuLDn7U+iA=; h=From:To:Subject:Date:In-Reply-To:References:From; b=CefOpdUYTiwOy83U+E/kcagZtJuDYKM3vHG4RXnwsLRQKXLKzEfdM49z2gS2XzlIF 8GFAchq+g6UQcSx6eSYMSNlridJoSBjbflQgDK2echbPZEYMWPOgODBGgQDNGXRilG lTozH74eKjnnYv7+TRzUujQbXA4Z96ZZeNRqtCrA= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [RFT 05/25] ARM: dts: s5pv210: remove DMA controller bus node name to fix dtschema warnings Date: Mon, 7 Sep 2020 18:11:21 +0200 Message-Id: <20200907161141.31034-6-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org There is no need to keep DMA controller nodes under AMBA bus node. Remove the "amba" node to fix dtschema warnings like: amba: $nodename:0: 'amba' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' Signed-off-by: Krzysztof Kozlowski Tested-by: Jonathan Bakker --- arch/arm/boot/dts/s5pv210.dtsi | 49 +++++++++++++++------------------- 1 file changed, 21 insertions(+), 28 deletions(-) diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi index 1b0ee884e91d..84e4447931de 100644 --- a/arch/arm/boot/dts/s5pv210.dtsi +++ b/arch/arm/boot/dts/s5pv210.dtsi @@ -128,35 +128,28 @@ }; }; - amba { - #address-cells = <1>; - #size-cells = <1>; - compatible = "simple-bus"; - ranges; - - pdma0: dma@e0900000 { - compatible = "arm,pl330", "arm,primecell"; - reg = <0xe0900000 0x1000>; - interrupt-parent = <&vic0>; - interrupts = <19>; - clocks = <&clocks CLK_PDMA0>; - clock-names = "apb_pclk"; - #dma-cells = <1>; - #dma-channels = <8>; - #dma-requests = <32>; - }; + pdma0: dma@e0900000 { + compatible = "arm,pl330", "arm,primecell"; + reg = <0xe0900000 0x1000>; + interrupt-parent = <&vic0>; + interrupts = <19>; + clocks = <&clocks CLK_PDMA0>; + clock-names = "apb_pclk"; + #dma-cells = <1>; + #dma-channels = <8>; + #dma-requests = <32>; + }; - pdma1: dma@e0a00000 { - compatible = "arm,pl330", "arm,primecell"; - reg = <0xe0a00000 0x1000>; - interrupt-parent = <&vic0>; - interrupts = <20>; - clocks = <&clocks CLK_PDMA1>; - clock-names = "apb_pclk"; - #dma-cells = <1>; - #dma-channels = <8>; - #dma-requests = <32>; - }; + pdma1: dma@e0a00000 { + compatible = "arm,pl330", "arm,primecell"; + reg = <0xe0a00000 0x1000>; + interrupt-parent = <&vic0>; + interrupts = <20>; + clocks = <&clocks CLK_PDMA1>; + clock-names = "apb_pclk"; + #dma-cells = <1>; + #dma-channels = <8>; + #dma-requests = <32>; }; adc: adc@e1700000 { From patchwork Mon Sep 7 16:11:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761499 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3DDA71599 for ; Mon, 7 Sep 2020 16:24:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 259772080A for ; Mon, 7 Sep 2020 16:24:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495861; bh=qDYGfZ3RmLMzEdL/D31BVomLhzU4Yf8Q9HdCrkY+B7M=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=At1eJ3fcDZSKvGbN+I6PZy1cGw4yDww+4hNduR2bA2gkwvGM+eTvqNxIUE7dgGk7b +xK16CzjH5xZRIYO99CnzK8W2gX/DsYuVG41cdyyD4SC1haKBl4Hws9LX58b7B4WL9 BYF5VPX4MQgXXO7EqKQI3y+XloBrnns7ckqkiwFk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730380AbgIGQNH (ORCPT ); Mon, 7 Sep 2020 12:13:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:33014 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729937AbgIGQM4 (ORCPT ); Mon, 7 Sep 2020 12:12:56 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C4039206E6; Mon, 7 Sep 2020 16:12:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495175; bh=qDYGfZ3RmLMzEdL/D31BVomLhzU4Yf8Q9HdCrkY+B7M=; h=From:To:Subject:Date:In-Reply-To:References:From; b=2HlZYLGDXRkHSOlvKLZG4N1MYxjdg3kgFUw0boXQ+tQCu/eUQINFSNUd4gvaBfJml vQ6L90Mnr1qXXK/azSFdFF7j6CbTXhzC0BhYGaDIZ3Y0mVUtcRqRjt1z8GE8rjbEbu 3S3ak1/xNBLuZcOBZm8k3ASFgoZLMORPQTtLcF4Y= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [RFT 06/25] ARM: dts: s5pv210: move fixed clocks under root node Date: Mon, 7 Sep 2020 18:11:22 +0200 Message-Id: <20200907161141.31034-7-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The fixed clocks are kept under dedicated 'external-clocks' node, thus a fake 'reg' was added. This is not correct with dtschema as fixed-clock binding does not have a 'reg' property. Moving fixed clocks out of 'soc' to root node fixes multiple dtbs_check warnings: external-clocks: $nodename:0: 'external-clocks' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' external-clocks: #size-cells:0:0: 0 is not one of [1, 2] external-clocks: oscillator@0:reg:0: [0] is too short external-clocks: oscillator@1:reg:0: [1] is too short external-clocks: 'ranges' is a required property oscillator@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Tested-by: Jonathan Bakker --- arch/arm/boot/dts/s5pv210.dtsi | 36 +++++++++++++--------------------- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi index 84e4447931de..5c760a6d7955 100644 --- a/arch/arm/boot/dts/s5pv210.dtsi +++ b/arch/arm/boot/dts/s5pv210.dtsi @@ -52,34 +52,26 @@ }; }; + xxti: oscillator-0 { + compatible = "fixed-clock"; + clock-frequency = <0>; + clock-output-names = "xxti"; + #clock-cells = <0>; + }; + + xusbxti: oscillator-1 { + compatible = "fixed-clock"; + clock-frequency = <0>; + clock-output-names = "xusbxti"; + #clock-cells = <0>; + }; + soc { compatible = "simple-bus"; #address-cells = <1>; #size-cells = <1>; ranges; - external-clocks { - compatible = "simple-bus"; - #address-cells = <1>; - #size-cells = <0>; - - xxti: oscillator@0 { - compatible = "fixed-clock"; - reg = <0>; - clock-frequency = <0>; - clock-output-names = "xxti"; - #clock-cells = <0>; - }; - - xusbxti: oscillator@1 { - compatible = "fixed-clock"; - reg = <1>; - clock-frequency = <0>; - clock-output-names = "xusbxti"; - #clock-cells = <0>; - }; - }; - onenand: onenand@b0600000 { compatible = "samsung,s5pv210-onenand"; reg = <0xb0600000 0x2000>, From patchwork Mon Sep 7 16:11:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761517 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 96C2459D for ; Mon, 7 Sep 2020 16:25:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74F502080A for ; Mon, 7 Sep 2020 16:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495902; bh=GtKhtYeqhoFhkk4l+56UWm2i17dljFhd74agdK6C2Ew=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=2aJ/t0HpApzRHRRXvj0cI2DzN0+zk4/3BJvOoWV0EpZFE5SRmHypqJQF1GHRl8lsg dCOscnhiRbIDhkglNvN32cgMOqwEDG2V4TF27rtc92qzhEAXKIBtZnGbL2s/ZgD1wb O/eptG4mEcZE9X5My5CoHs+DjGOwMHsWXJ/CT7k0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730344AbgIGQYy (ORCPT ); Mon, 7 Sep 2020 12:24:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:33062 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729944AbgIGQNA (ORCPT ); Mon, 7 Sep 2020 12:13:00 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4A91021789; Mon, 7 Sep 2020 16:12:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495180; bh=GtKhtYeqhoFhkk4l+56UWm2i17dljFhd74agdK6C2Ew=; h=From:To:Subject:Date:In-Reply-To:References:From; b=1HtKxRs+iHnNOY6R6jfZ5BjznDhzhDljRmRFsaA+oDVT7biI+paXbhSVSYefBbH5c RWilAlgGup9PDTDvQF4NK/kbiRwvTiMby/9/r43rcNd/ygb08hYwoCtEZwqCxI73ZM qiX3bUrZveJfPjCkY/XQ3Q39CjSsqM1f0oCdurnI= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [RFT 07/25] ARM: dts: s5pv210: move PMU node out of clock controller Date: Mon, 7 Sep 2020 18:11:23 +0200 Message-Id: <20200907161141.31034-8-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The Power Management Unit (PMU) is a separate device which has little common with clock controller. Moving it to one level up (from clock controller child to SoC) allows to remove fake simple-bus compatible and dtbs_check warnings like: clock-controller@e0100000: $nodename:0: 'clock-controller@e0100000' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' Signed-off-by: Krzysztof Kozlowski Tested-by: Jonathan Bakker --- arch/arm/boot/dts/s5pv210.dtsi | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi index 5c760a6d7955..46221a5c8ce5 100644 --- a/arch/arm/boot/dts/s5pv210.dtsi +++ b/arch/arm/boot/dts/s5pv210.dtsi @@ -92,19 +92,16 @@ }; clocks: clock-controller@e0100000 { - compatible = "samsung,s5pv210-clock", "simple-bus"; + compatible = "samsung,s5pv210-clock"; reg = <0xe0100000 0x10000>; clock-names = "xxti", "xusbxti"; clocks = <&xxti>, <&xusbxti>; #clock-cells = <1>; - #address-cells = <1>; - #size-cells = <1>; - ranges; + }; - pmu_syscon: syscon@e0108000 { - compatible = "samsung-s5pv210-pmu", "syscon"; - reg = <0xe0108000 0x8000>; - }; + pmu_syscon: syscon@e0108000 { + compatible = "samsung-s5pv210-pmu", "syscon"; + reg = <0xe0108000 0x8000>; }; pinctrl0: pinctrl@e0200000 { From patchwork Mon Sep 7 16:11:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761509 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2FDC759D for ; Mon, 7 Sep 2020 16:24:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18C6D2080A for ; Mon, 7 Sep 2020 16:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495878; bh=6BAvdsAwxvGCRAvXMQZS4I59p4w7Bxsi3s+90oUZ7fI=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=CyVAifqwOgqEtRS/0osPF/3jQFj+hSsLROAAyOg3UGLkFD1lfZUuQI5LBrB/KEwcf kOCQ2j9vlXuvtbZWxKlZ4uTmXUWCajLqi+3/nhwvcVlat5um0ds0zzEouCniDM+1Ng EtvSRhXbKlvqWhf7iQOMyx1ZDRnNJDCWy5ds0/gY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730386AbgIGQYg (ORCPT ); Mon, 7 Sep 2020 12:24:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:33106 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730108AbgIGQNF (ORCPT ); Mon, 7 Sep 2020 12:13:05 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7D91221897; Mon, 7 Sep 2020 16:13:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495183; bh=6BAvdsAwxvGCRAvXMQZS4I59p4w7Bxsi3s+90oUZ7fI=; h=From:To:Subject:Date:In-Reply-To:References:From; b=PS5JkxRIrPd7Ju/BO352HryeQX+LeigF4gQJqq6SFtYYyZXZ36gr5RJXAT/G7vt0a UDBSvv6GElJyGrS5tUECja051Sec+VgMzLdnRHohw9WmXVaaN0AoJe8OB7cWxhiWtu PLdVMMWorm+EgEZ8x5XXcde5sFb0Bvw9cBLzk5Vs= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [RFT 08/25] ARM: dts: s5pv210: remove dedicated 'audio-subsystem' node Date: Mon, 7 Sep 2020 18:11:24 +0200 Message-Id: <20200907161141.31034-9-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The 'audio-subsystem' node is an artificial creation, not representing real hardware. The hardware is described by its nodes - AUDSS clock controller and I2S0. Remove the 'audio-subsystem' node along with its undocumented compatible to fix dtbs_check warnings like: audio-subsystem: $nodename:0: 'audio-subsystem' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' Signed-off-by: Krzysztof Kozlowski Tested-by: Jonathan Bakker --- arch/arm/boot/dts/s5pv210.dtsi | 65 +++++++++++++++------------------- 1 file changed, 29 insertions(+), 36 deletions(-) diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi index 46221a5c8ce5..2871351ab907 100644 --- a/arch/arm/boot/dts/s5pv210.dtsi +++ b/arch/arm/boot/dts/s5pv210.dtsi @@ -223,43 +223,36 @@ status = "disabled"; }; - audio-subsystem { - compatible = "samsung,s5pv210-audss", "simple-bus"; - #address-cells = <1>; - #size-cells = <1>; - ranges; - - clk_audss: clock-controller@eee10000 { - compatible = "samsung,s5pv210-audss-clock"; - reg = <0xeee10000 0x1000>; - clock-names = "hclk", "xxti", - "fout_epll", - "sclk_audio0"; - clocks = <&clocks DOUT_HCLKP>, <&xxti>, - <&clocks FOUT_EPLL>, - <&clocks SCLK_AUDIO0>; - #clock-cells = <1>; - }; + clk_audss: clock-controller@eee10000 { + compatible = "samsung,s5pv210-audss-clock"; + reg = <0xeee10000 0x1000>; + clock-names = "hclk", "xxti", + "fout_epll", + "sclk_audio0"; + clocks = <&clocks DOUT_HCLKP>, <&xxti>, + <&clocks FOUT_EPLL>, + <&clocks SCLK_AUDIO0>; + #clock-cells = <1>; + }; - i2s0: i2s@eee30000 { - compatible = "samsung,s5pv210-i2s"; - reg = <0xeee30000 0x1000>; - interrupt-parent = <&vic2>; - interrupts = <16>; - dma-names = "rx", "tx", "tx-sec"; - dmas = <&pdma1 9>, <&pdma1 10>, <&pdma1 11>; - clock-names = "iis", - "i2s_opclk0", - "i2s_opclk1"; - clocks = <&clk_audss CLK_I2S>, - <&clk_audss CLK_I2S>, - <&clk_audss CLK_DOUT_AUD_BUS>; - samsung,idma-addr = <0xc0010000>; - pinctrl-names = "default"; - pinctrl-0 = <&i2s0_bus>; - #sound-dai-cells = <0>; - status = "disabled"; - }; + i2s0: i2s@eee30000 { + compatible = "samsung,s5pv210-i2s"; + reg = <0xeee30000 0x1000>; + interrupt-parent = <&vic2>; + interrupts = <16>; + dma-names = "rx", "tx", "tx-sec"; + dmas = <&pdma1 9>, <&pdma1 10>, <&pdma1 11>; + clock-names = "iis", + "i2s_opclk0", + "i2s_opclk1"; + clocks = <&clk_audss CLK_I2S>, + <&clk_audss CLK_I2S>, + <&clk_audss CLK_DOUT_AUD_BUS>; + samsung,idma-addr = <0xc0010000>; + pinctrl-names = "default"; + pinctrl-0 = <&i2s0_bus>; + #sound-dai-cells = <0>; + status = "disabled"; }; i2s1: i2s@e2100000 { From patchwork Mon Sep 7 16:11:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761507 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3200F1599 for ; Mon, 7 Sep 2020 16:24:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18EDE2080A for ; Mon, 7 Sep 2020 16:24:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495877; bh=wpdHkjWJjuNWTZckDc5yTTA+zkcQQYAV5zyE6Evwps8=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=lTpxXSABV4ppAszCJS6iMfpzqHJ9trXf5WUTk4TNtkKulx1Tz8ZkiHO95eXpTvq6M dgnneXLq+w8fU31G90crmEB9XkLDPF/6iVDtcpVD9THoQOaPQUB5+iUMonr5Azl+0J jR5RjW6SPuXwB6HbZla5pTJpEW3VEm9ORp+ePYcs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729924AbgIGQYf (ORCPT ); Mon, 7 Sep 2020 12:24:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:33164 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730004AbgIGQNH (ORCPT ); Mon, 7 Sep 2020 12:13:07 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 51A2321919; Mon, 7 Sep 2020 16:13:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495187; bh=wpdHkjWJjuNWTZckDc5yTTA+zkcQQYAV5zyE6Evwps8=; h=From:To:Subject:Date:In-Reply-To:References:From; b=TheR5lpMgTv+Xg8ocpJ4CTPM7Q79eP4d8ReEvNyh5YjFsqaQ9FWLyRzZGUXjZHyQJ TVOIKnsNj2hHZN+7uFTJFWOwLKy70ecYn3neIezmhtMEVG4C+Zz3pt/dkVPXPh1UGl rhQ/drqMntAmiPoBvCb9OOiYy5i83tBFMEK5uHdg= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [RFT 09/25] ARM: dts: s5pv210: fix number of I2S DAI cells Date: Mon, 7 Sep 2020 18:11:25 +0200 Message-Id: <20200907161141.31034-10-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The bindings describe I2S DAI has 1 cells. This makes especially sense for i2s0 which registers two DAIs. Adjust the cells to fix dtbs_check warnings like: i2s@e2100000: #sound-dai-cells:0:0: 1 was expected Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s5pv210-fascinate4g.dts | 2 +- arch/arm/boot/dts/s5pv210-galaxys.dts | 2 +- arch/arm/boot/dts/s5pv210.dtsi | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/s5pv210-fascinate4g.dts b/arch/arm/boot/dts/s5pv210-fascinate4g.dts index ca064359dd30..a6dc8a173af1 100644 --- a/arch/arm/boot/dts/s5pv210-fascinate4g.dts +++ b/arch/arm/boot/dts/s5pv210-fascinate4g.dts @@ -102,7 +102,7 @@ pinctrl-0 = <&headset_det &earpath_sel>; cpu { - sound-dai = <&i2s0>, <&bt_codec>; + sound-dai = <&i2s0 0>, <&bt_codec>; }; codec { diff --git a/arch/arm/boot/dts/s5pv210-galaxys.dts b/arch/arm/boot/dts/s5pv210-galaxys.dts index 560f830b6f6b..0eba06f56ac7 100644 --- a/arch/arm/boot/dts/s5pv210-galaxys.dts +++ b/arch/arm/boot/dts/s5pv210-galaxys.dts @@ -132,7 +132,7 @@ pinctrl-0 = <&headset_det &earpath_sel>; cpu { - sound-dai = <&i2s0>, <&bt_codec>; + sound-dai = <&i2s0 0>, <&bt_codec>; }; codec { diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi index 2871351ab907..96e667ba1c3f 100644 --- a/arch/arm/boot/dts/s5pv210.dtsi +++ b/arch/arm/boot/dts/s5pv210.dtsi @@ -251,7 +251,7 @@ samsung,idma-addr = <0xc0010000>; pinctrl-names = "default"; pinctrl-0 = <&i2s0_bus>; - #sound-dai-cells = <0>; + #sound-dai-cells = <1>; status = "disabled"; }; @@ -266,7 +266,7 @@ clocks = <&clocks CLK_I2S1>, <&clocks SCLK_AUDIO1>; pinctrl-names = "default"; pinctrl-0 = <&i2s1_bus>; - #sound-dai-cells = <0>; + #sound-dai-cells = <1>; status = "disabled"; }; @@ -281,7 +281,7 @@ clocks = <&clocks CLK_I2S2>, <&clocks SCLK_AUDIO2>; pinctrl-names = "default"; pinctrl-0 = <&i2s2_bus>; - #sound-dai-cells = <0>; + #sound-dai-cells = <1>; status = "disabled"; }; From patchwork Mon Sep 7 16:11:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761503 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CB7C959D for ; Mon, 7 Sep 2020 16:24:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A797C20757 for ; Mon, 7 Sep 2020 16:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495873; bh=IvIoj2K7TIRgwMp4PonToROYopW9M5mo7TeBE51xjo0=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=DJTXt7CV9DYvmEnBd3P30aj8SBzCsIvHSinRXYrjrk9bzFrxH1Ib83kOHEm+lSCaT 7TzgoD+lLeCx+8/2XuPfqVenwbKuWbaCaA7ODtOST/XTQVTM8UIVroNcTYVlT7F0eq tq0jiHEmw8Gw+2HLelNPkZeqlj+NtvSeE+6L9GCI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730558AbgIGQYV (ORCPT ); Mon, 7 Sep 2020 12:24:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:33208 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729924AbgIGQNK (ORCPT ); Mon, 7 Sep 2020 12:13:10 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AE70221775; Mon, 7 Sep 2020 16:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495190; bh=IvIoj2K7TIRgwMp4PonToROYopW9M5mo7TeBE51xjo0=; h=From:To:Subject:Date:In-Reply-To:References:From; b=nAA805Fqp3EYfc9xrjR3f18Q6EcfDrLkpSJ0h2oGbmmVqtFRrdA4GXxl0ndhqjxDs LiDEMZm+2eokreabKhc1ESbH/NZVLBv7Ih4ocMKXz2k3Gm06fRoHkuu2GU/R5+RDde T9K4fsf4K9f3Po0qyFcoQj/+XglB1tXFqqpMDUH8= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [PATCH 10/25] ARM: dts: s5pv210: add RTC 32 KHz clock in Aquilla Date: Mon, 7 Sep 2020 18:11:26 +0200 Message-Id: <20200907161141.31034-11-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The S3C RTC requires 32768 Hz clock as input which is provided by PMIC. However there is no such clock provider but rather a regulator driver which registers the clock as a regulator. This is an old driver which will not be updated so add a workaround - a fixed-clock to fill missing clock phandle reference in S3C RTC. This fixes dtbs_check warnings: rtc@e2800000: clocks: [[2, 145]] is too short rtc@e2800000: clock-names: ['rtc'] is too short Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s5pv210-aquila.dts | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/arch/arm/boot/dts/s5pv210-aquila.dts b/arch/arm/boot/dts/s5pv210-aquila.dts index 14969b6529e8..eaeb0e921aaa 100644 --- a/arch/arm/boot/dts/s5pv210-aquila.dts +++ b/arch/arm/boot/dts/s5pv210-aquila.dts @@ -32,6 +32,13 @@ 0x40000000 0x18000000>; }; + pmic_ap_clk: clock-0 { + /* Workaround for missing clock on PMIC */ + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32768>; + }; + regulators { compatible = "simple-bus"; #address-cells = <1>; @@ -228,6 +235,11 @@ regulator-always-on; }; + ap32khz_reg: EN32KHz-AP { + regulator-name = "32KHz AP"; + regulator-always-on; + }; + vichg_reg: ENVICHG { regulator-name = "VICHG"; }; @@ -326,6 +338,11 @@ status = "okay"; }; +&rtc { + clocks = <&clocks CLK_RTC>, <&pmic_ap_clk>; + clock-names = "rtc", "rtc_src"; +}; + &sdhci0 { bus-width = <4>; non-removable; From patchwork Mon Sep 7 16:11:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761491 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CCD3B59D for ; Mon, 7 Sep 2020 16:24:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA7E02080A for ; Mon, 7 Sep 2020 16:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495844; bh=INsnJaELqRYsET4RRsxOzKJWpIsKuNPsUd4VuZL+kig=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=dWF/wjUYclhJGkYvSrXoUKc3HX4+tzc1SL1dIV8X/MyAJqQAUyjw70BckteKT9KZC EUoaFG8bXr8Axc989WLOs1Bqt8o9pWmqWb1SiVFjfm8FjcnEEnyHYBAEASC03kD9es mtfCdVGh3hi6NKk7uXxGgjtDNOjEofRSJiHScfhI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729970AbgIGQNS (ORCPT ); Mon, 7 Sep 2020 12:13:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:33244 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730386AbgIGQNO (ORCPT ); Mon, 7 Sep 2020 12:13:14 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0A703206E6; Mon, 7 Sep 2020 16:13:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495193; bh=INsnJaELqRYsET4RRsxOzKJWpIsKuNPsUd4VuZL+kig=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Z/xvc2E0pU0W7wifdwH6nXDDK8ZLaQVF/rtfD7l3/YbRIIv4MmQjtHbOq1pzT0vxg S3VFMWnUnNWGIJsMdsvlMyL81ZbDWE+ONNyxX1HXCnqttgNUzDX9gpj/uNgNXc3yOf 0I/Ce/wW1oqj/gjsaKhJcOpIpkjvCoHujfUXs1Xk= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [PATCH 11/25] ARM: dts: s5pv210: add RTC 32 KHz clock in Aries family Date: Mon, 7 Sep 2020 18:11:27 +0200 Message-Id: <20200907161141.31034-12-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The S3C RTC requires 32768 Hz clock as input which is provided by PMIC. However there is no such clock provider but rather a regulator driver which registers the clock as a regulator. This is an old driver which will not be updated so add a workaround - a fixed-clock to fill missing clock phandle reference in S3C RTC. This fixes dtbs_check warnings: rtc@e2800000: clocks: [[2, 145]] is too short rtc@e2800000: clock-names: ['rtc'] is too short Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s5pv210-aries.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi index 6ba23562da46..86c3b26fd21e 100644 --- a/arch/arm/boot/dts/s5pv210-aries.dtsi +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi @@ -47,6 +47,13 @@ }; }; + pmic_ap_clk: clock-0 { + /* Workaround for missing clock on PMIC */ + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32768>; + }; + bt_codec: bt_sco { compatible = "linux,bt-sco"; #sound-dai-cells = <0>; @@ -825,6 +832,11 @@ samsung,pwm-outputs = <1>; }; +&rtc { + clocks = <&clocks CLK_RTC>, <&pmic_ap_clk>; + clock-names = "rtc", "rtc_src"; +}; + &sdhci1 { #address-cells = <1>; #size-cells = <0>; From patchwork Mon Sep 7 16:11:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761493 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E2E6C13B1 for ; Mon, 7 Sep 2020 16:24:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C14462080A for ; Mon, 7 Sep 2020 16:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495853; bh=yx/xrKwi3d342OuVJ6+t5DVvoWKbXVtqclPlrgpbk3Y=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=k2HcbbtW3ukj9ecHy9dCW59sKfSjfP2DcHMvmSA25BMiK9AFJcSHDA77gWwJHQD3q Zbfg1zJOKgJSrI72ysXDIVBSj0OvkvLOrAW3OEBdjlt60cqNPpaINfAuOUhByAOPXX owSYyMVO48yoiOQnLYQrp/YDaI8nVbrJDGrCnX/Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730393AbgIGQYB (ORCPT ); Mon, 7 Sep 2020 12:24:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:33292 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729937AbgIGQNS (ORCPT ); Mon, 7 Sep 2020 12:13:18 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 39503207DE; Mon, 7 Sep 2020 16:13:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495197; bh=yx/xrKwi3d342OuVJ6+t5DVvoWKbXVtqclPlrgpbk3Y=; h=From:To:Subject:Date:In-Reply-To:References:From; b=AvZnRTKZawYE3HQooBh8Fj2d4hN/5dCV9Kt4ZgIPQouJdeq/+bazDiPaEgGeCW4V2 ZAPxuKbRNKpo88YfNvxNxs0DB2HO8xoKg2K9Yvv9rJ/EMc0EeuadiOKjDZxKkZJb3v EoDlBPgID3PfgjjKpnCeqwOFOa7Y0cgpEF6mPfNc= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [PATCH 12/25] ARM: dts: s5pv210: add RTC 32 KHz clock in Goni Date: Mon, 7 Sep 2020 18:11:28 +0200 Message-Id: <20200907161141.31034-13-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The S3C RTC requires 32768 Hz clock as input which is provided by PMIC. However there is no such clock provider but rather a regulator driver which registers the clock as a regulator. This is an old driver which will not be updated so add a workaround - a fixed-clock to fill missing clock phandle reference in S3C RTC. This fixes dtbs_check warnings: rtc@e2800000: clocks: [[2, 145]] is too short rtc@e2800000: clock-names: ['rtc'] is too short Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s5pv210-goni.dts | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/arch/arm/boot/dts/s5pv210-goni.dts b/arch/arm/boot/dts/s5pv210-goni.dts index fbbd93707404..c8714bf0b6e4 100644 --- a/arch/arm/boot/dts/s5pv210-goni.dts +++ b/arch/arm/boot/dts/s5pv210-goni.dts @@ -33,6 +33,13 @@ 0x50000000 0x08000000>; }; + pmic_ap_clk: clock-0 { + /* Workaround for missing clock on PMIC */ + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32768>; + }; + regulators { compatible = "simple-bus"; #address-cells = <1>; @@ -224,6 +231,11 @@ regulator-max-microvolt = <1200000>; regulator-always-on; }; + + ap32khz_reg: EN32KHz-AP { + regulator-name = "32KHz AP"; + regulator-always-on; + }; }; }; }; @@ -308,6 +320,11 @@ status = "okay"; }; +&rtc { + clocks = <&clocks CLK_RTC>, <&pmic_ap_clk>; + clock-names = "rtc", "rtc_src"; +}; + &sdhci0 { bus-width = <4>; non-removable; From patchwork Mon Sep 7 16:11:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761483 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1CD8E13B1 for ; Mon, 7 Sep 2020 16:22:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EEAE8208C7 for ; Mon, 7 Sep 2020 16:22:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495723; bh=ejtq/VIVsktLn4Dgw4vy86y+KtXeh8BqyiiI41C0oYM=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=K+PJT43KUGt5gFulT7i4yb4d/z/f4XJB9xoE8n7E3ZVH358ahAGncGZ2JADAVAB6C +MNGatFcaeXpctA0FyZPIaHYRTjjuytbGpljqTjGBlzeuKXaShZeR43ZiSBeApviz5 /sF3Kek9j/qhq90b9O4svOHHbMUkNrlMVhT44Jo8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730456AbgIGQV4 (ORCPT ); Mon, 7 Sep 2020 12:21:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:33378 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730389AbgIGQNV (ORCPT ); Mon, 7 Sep 2020 12:13:21 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DEDE921897; Mon, 7 Sep 2020 16:13:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495201; bh=ejtq/VIVsktLn4Dgw4vy86y+KtXeh8BqyiiI41C0oYM=; h=From:To:Subject:Date:In-Reply-To:References:From; b=nNkR14erhjM+1VUXixXRp1KJe6Zdmr2ez4f0PwcJ4p8eEzRNgNJ6DjxDty7fxYr+l 8fMvogRLvor3RRwwLPnT8HOvXMOTIYpMGsB37OvspsErCVf788XlVeXWIDYezWyeKm 0/5E7+5HVT2HJdrjsMXM7xpv07bIXaLPLVml5rjA= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [PATCH 13/25] ARM: dts: s5pv210: add RTC 32 KHz clock in SMDKC110 Date: Mon, 7 Sep 2020 18:11:29 +0200 Message-Id: <20200907161141.31034-14-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The S3C RTC requires 32768 Hz clock as input which is provided by PMIC. However the PMIC is not described in DTS at all so at least add a workaround to model its clock with a fixed-clock. This fixes dtbs_check warnings: rtc@e2800000: clocks: [[2, 145]] is too short rtc@e2800000: clock-names: ['rtc'] is too short Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s5pv210-smdkc110.dts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/s5pv210-smdkc110.dts b/arch/arm/boot/dts/s5pv210-smdkc110.dts index e5aec6c526fb..0c623b78af72 100644 --- a/arch/arm/boot/dts/s5pv210-smdkc110.dts +++ b/arch/arm/boot/dts/s5pv210-smdkc110.dts @@ -30,6 +30,13 @@ device_type = "memory"; reg = <0x20000000 0x20000000>; }; + + pmic_ap_clk: clock-0 { + /* Workaround for missing PMIC and its clock */ + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32768>; + }; }; &xusbxti { @@ -54,6 +61,8 @@ &rtc { status = "okay"; + clocks = <&clocks CLK_RTC>, <&pmic_ap_clk>; + clock-names = "rtc", "rtc_src"; }; &i2c0 { From patchwork Mon Sep 7 16:11:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761467 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A87FE13B1 for ; Mon, 7 Sep 2020 16:21:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85CE521532 for ; Mon, 7 Sep 2020 16:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495702; bh=hCa1lfqQh5Q/rKTvpN58exv+OgW3HLbegrw+Jx02Gwk=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=yrUg+E+HnI6nCLYeBw4Sf6UDiu+fd1Mt2/iEQstyANoCNNmWqpoyWTzuzWNbTQOEs 3pFn4WARUf+l5YnzbxGFlLDsLp09oGorbAaCydNCoO0NBC0A5JBNxVO7RbUIVbn8t1 Qdmi0v+oN/SFBF8i2UpeUnUtUtk5OPb0nUSCeXUE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730407AbgIGQNj (ORCPT ); Mon, 7 Sep 2020 12:13:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:33540 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730318AbgIGQN3 (ORCPT ); Mon, 7 Sep 2020 12:13:29 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8245A21919; Mon, 7 Sep 2020 16:13:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495208; bh=hCa1lfqQh5Q/rKTvpN58exv+OgW3HLbegrw+Jx02Gwk=; h=From:To:Subject:Date:In-Reply-To:References:From; b=11vf3Va/Vc9DRGOMYZamRit9H9IEaPFZlD4LAQsKbOuFnIgs5e3GtwewKW1I2oeKQ Rv1+ghFjyP0D0KoS1Nh6hWQQkny+TSvbF+7I929kpmq7paymYBltUWHIJYWoTfPDYZ o7meOrUnNo8D2v0hoBc360jr9zQY0BXQj10xehOU= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [PATCH 14/25] ARM: dts: s5pv210: add RTC 32 KHz clock in SMDKV210 Date: Mon, 7 Sep 2020 18:11:30 +0200 Message-Id: <20200907161141.31034-15-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The S3C RTC requires 32768 Hz clock as input which is provided by PMIC. However the PMIC is not described in DTS at all so at least add a workaround to model its clock with a fixed-clock. This fixes dtbs_check warnings: rtc@e2800000: clocks: [[2, 145]] is too short rtc@e2800000: clock-names: ['rtc'] is too short Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s5pv210-smdkv210.dts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/s5pv210-smdkv210.dts b/arch/arm/boot/dts/s5pv210-smdkv210.dts index 84b38f185199..1f20622da719 100644 --- a/arch/arm/boot/dts/s5pv210-smdkv210.dts +++ b/arch/arm/boot/dts/s5pv210-smdkv210.dts @@ -31,6 +31,13 @@ reg = <0x20000000 0x40000000>; }; + pmic_ap_clk: clock-0 { + /* Workaround for missing PMIC and its clock */ + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32768>; + }; + ethernet@18000000 { compatible = "davicom,dm9000"; reg = <0xA8000000 0x2 0xA8000002 0x2>; @@ -147,6 +154,8 @@ &rtc { status = "okay"; + clocks = <&clocks CLK_RTC>, <&pmic_ap_clk>; + clock-names = "rtc", "rtc_src"; }; &sdhci0 { From patchwork Mon Sep 7 16:11:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761391 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 810F6138E for ; Mon, 7 Sep 2020 16:13:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E848217A0 for ; Mon, 7 Sep 2020 16:13:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495220; bh=qgXqI4frisFwx8QzGcIa8tBsjc+jjvV/N85jzzXwX90=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=eKtRcv96wAV/7rLswBCV8U8tPI25Uva8hWXfQx29tzCBIaO0mBpOBl2P7uKV1OtKL hZU2q5wIlFyHrHqG1yW/YmmqfOWy5YpaNlhceRonbYYQkddTGjg4wZMAp4U9pX9yPb QSoJYKI60jYBC3WrlBh+XaOQr4kXZDTnknSB2SoE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730402AbgIGQNi (ORCPT ); Mon, 7 Sep 2020 12:13:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:33626 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729934AbgIGQNc (ORCPT ); Mon, 7 Sep 2020 12:13:32 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A70CC20757; Mon, 7 Sep 2020 16:13:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495211; bh=qgXqI4frisFwx8QzGcIa8tBsjc+jjvV/N85jzzXwX90=; h=From:To:Subject:Date:In-Reply-To:References:From; b=lhlP2atmwmPguVgSXCI4YIVL6tyzpJrfhphhFctmVThZToRl2T1f148DWmY1M5DQ0 lFOZ8f33+AhCk+PyHsR8HjoZZAIA92ghniWQ/nCufS+FPKNu0vuygIwsO+e3tPpgC2 44Z8Nnv673y51nyIV5Xlf0TGA1c22EEKDL7eYGVU= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [PATCH 15/25] ARM: dts: s5pv210: add RTC 32 KHz clock in Torbreck Date: Mon, 7 Sep 2020 18:11:31 +0200 Message-Id: <20200907161141.31034-16-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The S3C RTC requires 32768 Hz clock as input which is provided by PMIC. However the PMIC is not described in DTS at all so at least add a workaround to model its clock with a fixed-clock. This fixes dtbs_check warnings: rtc@e2800000: clocks: [[2, 145]] is too short rtc@e2800000: clock-names: ['rtc'] is too short Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s5pv210-torbreck.dts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/s5pv210-torbreck.dts b/arch/arm/boot/dts/s5pv210-torbreck.dts index cd25e72ccd84..e18259737684 100644 --- a/arch/arm/boot/dts/s5pv210-torbreck.dts +++ b/arch/arm/boot/dts/s5pv210-torbreck.dts @@ -30,6 +30,13 @@ device_type = "memory"; reg = <0x20000000 0x20000000>; }; + + pmic_ap_clk: clock-0 { + /* Workaround for missing PMIC and its clock */ + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32768>; + }; }; &xusbxti { @@ -54,6 +61,8 @@ &rtc { status = "okay"; + clocks = <&clocks CLK_RTC>, <&pmic_ap_clk>; + clock-names = "rtc", "rtc_src"; }; &sdhci0 { From patchwork Mon Sep 7 16:11:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761481 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9ED4613B1 for ; Mon, 7 Sep 2020 16:21:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BC5D208C7 for ; Mon, 7 Sep 2020 16:21:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495713; bh=mPBu7hsXZsbqx8IHuhKWUMJOlvFkEEFzPFZCMcnLurw=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=T3fLhPUOQE/uSn96czNon30/bk/TKVYaz0S2Lvv/5UbWFlSqr9dWaUUayBLlvRcgd zLnI8iGHOoKTmZtZQFQ133hvikop0p34uin5mZZcgbSnrr/uMn+H0aHPZmpk41J7K0 NoxFfYZHtMRZyF0D5z9ocBu7bVvC+oikcMFiT8oE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729946AbgIGQNi (ORCPT ); Mon, 7 Sep 2020 12:13:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:33672 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729814AbgIGQNf (ORCPT ); Mon, 7 Sep 2020 12:13:35 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2F3EB206E6; Mon, 7 Sep 2020 16:13:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495215; bh=mPBu7hsXZsbqx8IHuhKWUMJOlvFkEEFzPFZCMcnLurw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=wCaOj2h9hpMr9boPIVg6KkQvdLfyS8BGRA+fXMLu6yFE9pKmBpG2KV+ONyCz4bFh8 HvYqtUahZJjly+s1wzupb/JyO202CNQ2fnm5xUJhdQlhIXXRYqnCUxkoE9x1RW+NQ6 mBwtLolELwY5wxBKZjxAU48b1JSeEsdN4uW4MIIs= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [PATCH 16/25] ARM: dts: s5pv210: use defines for GPIO flags in Aquila Date: Mon, 7 Sep 2020 18:11:32 +0200 Message-Id: <20200907161141.31034-17-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Replace hard-coded flags with defines for readability. No functional change. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s5pv210-aquila.dts | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/s5pv210-aquila.dts b/arch/arm/boot/dts/s5pv210-aquila.dts index eaeb0e921aaa..25d4ab4a52c5 100644 --- a/arch/arm/boot/dts/s5pv210-aquila.dts +++ b/arch/arm/boot/dts/s5pv210-aquila.dts @@ -11,6 +11,7 @@ */ /dts-v1/; +#include #include #include "s5pv210.dtsi" @@ -50,7 +51,7 @@ regulator-name = "V_TF_2.8V"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; - gpio = <&mp05 4 0>; + gpio = <&mp05 4 GPIO_ACTIVE_HIGH>; enable-active-high; }; @@ -73,8 +74,8 @@ i2c_pmic: i2c-pmic { compatible = "i2c-gpio"; - gpios = <&gpj4 0 0>, /* sda */ - <&gpj4 3 0>; /* scl */ + gpios = <&gpj4 0 GPIO_ACTIVE_HIGH>, /* sda */ + <&gpj4 3 GPIO_ACTIVE_HIGH>; /* scl */ i2c-gpio,delay-us = <2>; /* ~100 kHz */ #address-cells = <1>; #size-cells = <0>; @@ -84,13 +85,13 @@ reg = <0x66>; max8998,pmic-buck1-default-dvs-idx = <0>; - max8998,pmic-buck1-dvs-gpios = <&gph0 3 0>, - <&gph0 4 0>; + max8998,pmic-buck1-dvs-gpios = <&gph0 3 GPIO_ACTIVE_HIGH>, + <&gph0 4 GPIO_ACTIVE_HIGH>; max8998,pmic-buck1-dvs-voltage = <1200000>, <1200000>, <1200000>, <1200000>; max8998,pmic-buck2-default-dvs-idx = <0>; - max8998,pmic-buck2-dvs-gpio = <&gph0 5 0>; + max8998,pmic-buck2-dvs-gpio = <&gph0 5 GPIO_ACTIVE_HIGH>; max8998,pmic-buck2-dvs-voltage = <1200000>, <1200000>; regulators { From patchwork Mon Sep 7 16:11:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761477 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3542659D for ; Mon, 7 Sep 2020 16:21:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18AAE21789 for ; Mon, 7 Sep 2020 16:21:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495706; bh=7bTN0f0lE7QfBgCe+mOlPQ+E9zInglLyP5r7Xld6UhA=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=DfhUjvOxpIcdhWGrRCSpqUse6TMS34vCL1nHltJqA5ovHSomRXVQF50kPSoUTOixw 8X2YNNymA4oc29Nm8yzRUnjp9iHtpY758PMKefdT5IaoOnGAb5pzz2Ed5VoXGCq9KV hdk/A/tJ43eL/ZLjeg/b659MiLsqmMKwPKqXQCLs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729996AbgIGQVn (ORCPT ); Mon, 7 Sep 2020 12:21:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:33708 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730400AbgIGQNi (ORCPT ); Mon, 7 Sep 2020 12:13:38 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A057207DE; Mon, 7 Sep 2020 16:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495218; bh=7bTN0f0lE7QfBgCe+mOlPQ+E9zInglLyP5r7Xld6UhA=; h=From:To:Subject:Date:In-Reply-To:References:From; b=JClYdcgN2y22FrpuQHSvBdXx3L0S6mI2Dz0D9YkIrYvStx0Yv9gP5p7yurTP2Xzkd uOfAC6yQ5TIQz3hBBKnTVtzx2sbIIfwiaNlhB4dpFH1+PJQO1kmb3zGgaXuNv/hGu4 ilhvHA6Zm1yGB+Cq/OhHSiTxdXdPsjzMcS4uye3U= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [PATCH 17/25] ARM: dts: s5pv210: use defines for GPIO flags in Goni Date: Mon, 7 Sep 2020 18:11:33 +0200 Message-Id: <20200907161141.31034-18-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Replace hard-coded flags with defines for readability. No functional change. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s5pv210-goni.dts | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/arch/arm/boot/dts/s5pv210-goni.dts b/arch/arm/boot/dts/s5pv210-goni.dts index c8714bf0b6e4..77d1c5144afd 100644 --- a/arch/arm/boot/dts/s5pv210-goni.dts +++ b/arch/arm/boot/dts/s5pv210-goni.dts @@ -11,6 +11,7 @@ */ /dts-v1/; +#include #include #include "s5pv210.dtsi" @@ -51,7 +52,7 @@ regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; reg = <0>; - gpio = <&mp05 4 0>; + gpio = <&mp05 4 GPIO_ACTIVE_HIGH>; enable-active-high; }; @@ -77,15 +78,15 @@ regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; reg = <3>; - gpio = <&gpj1 3 0>; + gpio = <&gpj1 3 GPIO_ACTIVE_HIGH>; enable-active-high; }; }; i2c_pmic: i2c-pmic { compatible = "i2c-gpio"; - gpios = <&gpj4 0 0>, /* sda */ - <&gpj4 3 0>; /* scl */ + gpios = <&gpj4 0 GPIO_ACTIVE_HIGH>, /* sda */ + <&gpj4 3 GPIO_ACTIVE_HIGH>; /* scl */ i2c-gpio,delay-us = <2>; /* ~100 kHz */ #address-cells = <1>; #size-cells = <0>; @@ -95,13 +96,13 @@ reg = <0x66>; max8998,pmic-buck1-default-dvs-idx = <0>; - max8998,pmic-buck1-dvs-gpios = <&gph0 3 0>, - <&gph0 4 0>; + max8998,pmic-buck1-dvs-gpios = <&gph0 3 GPIO_ACTIVE_HIGH>, + <&gph0 4 GPIO_ACTIVE_HIGH>; max8998,pmic-buck1-dvs-voltage = <1200000>, <1200000>, <1200000>, <1200000>; max8998,pmic-buck2-default-dvs-idx = <0>; - max8998,pmic-buck2-dvs-gpio = <&gph0 5 0>; + max8998,pmic-buck2-dvs-gpio = <&gph0 5 GPIO_ACTIVE_HIGH>; max8998,pmic-buck2-dvs-voltage = <1200000>, <1200000>; regulators { @@ -395,8 +396,8 @@ clock-frequency = <16000000>; clocks = <&camera 0>; clock-names = "mclk"; - nreset-gpios = <&gpb 2 0>; - nstby-gpios = <&gpb 0 0>; + nreset-gpios = <&gpb 2 GPIO_ACTIVE_HIGH>; + nstby-gpios = <&gpb 0 GPIO_ACTIVE_HIGH>; port { noon010pc30_ep: endpoint { From patchwork Mon Sep 7 16:11:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761465 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7C28A1599 for ; Mon, 7 Sep 2020 16:21:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5AA562080A for ; Mon, 7 Sep 2020 16:21:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495699; bh=d6nxgR6+j5Zbg+AO77PXZlBaFeLEf/v+AR96N8SGLtY=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=IFcXmbb22W/L5Mja0cQ2vcyMLofZYi+svRJgGh0sI+QyU7j0lM5sd+qGYKtrhBDJG qzOHyN/T1evBFyw0P8aV+8t85H5gmuIHIxoZCXKtQE3ZorOb8aRNH2MssLSkNu1+oj VMkkjgSRZAqM5G3d0VFBThuafdO0gfkuXedwgUW0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730411AbgIGQNp (ORCPT ); Mon, 7 Sep 2020 12:13:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:33784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729814AbgIGQNm (ORCPT ); Mon, 7 Sep 2020 12:13:42 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D9E0521556; Mon, 7 Sep 2020 16:13:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495222; bh=d6nxgR6+j5Zbg+AO77PXZlBaFeLEf/v+AR96N8SGLtY=; h=From:To:Subject:Date:In-Reply-To:References:From; b=wlKnIngE2WWDG6839i0blXgsE0TlBXqx138C9ZdkiD/Cz6DS292UAaPP1QMCpBiRc k3kJi32N4gxOigV+Ah2Bz5P/G5/KMyQnFL45sRkDwKQgh5tvCi3cJVEU0NMWWb7+Iw k0lPZhtEf95jRiU0nHUiNg8dA9IYo+wppUWb3Np0= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [PATCH 18/25] ARM: dts: s5pv210: use defines for IRQ flags in SMDKV210 Date: Mon, 7 Sep 2020 18:11:34 +0200 Message-Id: <20200907161141.31034-19-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Replace hard-coded flags with defines for readability. No functional change. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s5pv210-smdkv210.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/s5pv210-smdkv210.dts b/arch/arm/boot/dts/s5pv210-smdkv210.dts index 1f20622da719..1e1570d66d89 100644 --- a/arch/arm/boot/dts/s5pv210-smdkv210.dts +++ b/arch/arm/boot/dts/s5pv210-smdkv210.dts @@ -15,6 +15,7 @@ */ /dts-v1/; +#include #include #include "s5pv210.dtsi" @@ -42,7 +43,7 @@ compatible = "davicom,dm9000"; reg = <0xA8000000 0x2 0xA8000002 0x2>; interrupt-parent = <&gph1>; - interrupts = <1 4>; + interrupts = <1 IRQ_TYPE_LEVEL_HIGH>; local-mac-address = [00 00 de ad be ef]; davicom,no-eeprom; }; From patchwork Mon Sep 7 16:11:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761437 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1801559D for ; Mon, 7 Sep 2020 16:19:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2A7721532 for ; Mon, 7 Sep 2020 16:19:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495558; bh=XaZQTe1g93YjbbwMKI+XDVCFTgySS4Ksy5Om23OC0Sg=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=bQm0p+7cGFF7hZ9m0jtKrE5VqoFwJKtcCKO039qqwczfIHdLy8jGrcGbhUnCFntyX YnWCnrRGl1DP260tOsQHch6irixtSnu4fY8r/h+nG7rxXjP9tkU/HwoZQhr+u+dIZg f7bZW7gqosl9pHoVDQTr18xRrXKo8YrhApF+i7D8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730430AbgIGQNw (ORCPT ); Mon, 7 Sep 2020 12:13:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:33824 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730422AbgIGQNs (ORCPT ); Mon, 7 Sep 2020 12:13:48 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F05FA21775; Mon, 7 Sep 2020 16:13:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495225; bh=XaZQTe1g93YjbbwMKI+XDVCFTgySS4Ksy5Om23OC0Sg=; h=From:To:Subject:Date:In-Reply-To:References:From; b=cADlHFa1clb9r2CudarorQbJiQnfvy8IcyJTuV37YA6y1mAxT+rAm4gz+OWOUv0Lv 9+Z1xZtPk5tdhH8pY7JcoZOiAssfgP1mXbGt/qGsEIibtx2k42B0eJTEZT4B8d4gjg cDM2NpsUEhXBfmhPo0F2p0XxPan/kiuTVoNIk2h0= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [PATCH 19/25] ARM: dts: s5pv210: use defines for IRQ flags in Goni Date: Mon, 7 Sep 2020 18:11:35 +0200 Message-Id: <20200907161141.31034-20-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Replace hard-coded flags with defines for readability. No functional change. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s5pv210-goni.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/s5pv210-goni.dts b/arch/arm/boot/dts/s5pv210-goni.dts index 77d1c5144afd..20f1c2773805 100644 --- a/arch/arm/boot/dts/s5pv210-goni.dts +++ b/arch/arm/boot/dts/s5pv210-goni.dts @@ -12,6 +12,7 @@ /dts-v1/; #include +#include #include #include "s5pv210.dtsi" @@ -366,7 +367,7 @@ compatible = "atmel,maxtouch"; reg = <0x4a>; interrupt-parent = <&gpj0>; - interrupts = <5 2>; + interrupts = <5 IRQ_TYPE_EDGE_FALLING>; atmel,x-line = <17>; atmel,y-line = <11>; From patchwork Mon Sep 7 16:11:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761459 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D448E13B1 for ; Mon, 7 Sep 2020 16:21:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBBD621532 for ; Mon, 7 Sep 2020 16:21:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495680; bh=2r+P12MEW4n8TZv7IWA3L/5cznKkKx6Gr9KtqUPmiEk=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=zTIEFh5FthXyH4hcFNIzvC93r9Wuluc5o0dsb0lXfDvedPy0KlDah3hDeUpX3tWvW TveC0KGjHvuk7fqT/6UogtGDaC98BbTs3k0pfql2fddnJjM1Qv4OorUupiVFC4rej+ CFgt1NHonq2fK71xpY1mxZAk0x5gfewIAb62zq6E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730350AbgIGQTi (ORCPT ); Mon, 7 Sep 2020 12:19:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:33900 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730427AbgIGQNt (ORCPT ); Mon, 7 Sep 2020 12:13:49 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 06086217A0; Mon, 7 Sep 2020 16:13:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495228; bh=2r+P12MEW4n8TZv7IWA3L/5cznKkKx6Gr9KtqUPmiEk=; h=From:To:Subject:Date:In-Reply-To:References:From; b=oK+cr7fTgwPkYOEdgPxZMBnyzsrKXWDjUZ2s2Gz8eAdyX3WDPRMxcdVXWbYU+Q5Ub xNVqehm1Upzv5FOHtgfP4CcLU0xyB6DR/i/kDBUcLEc4IINL3a4zEDskzBiv2YFXhG kXc4KolRxMTZTXsr2+Xi7R3dTGYUf0ePCs/2Bx1M= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [RFT 20/25] ARM: dts: s5pv210: move fixed regulators under root node in Aquila Date: Mon, 7 Sep 2020 18:11:36 +0200 Message-Id: <20200907161141.31034-21-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The fixed regulators are kept under dedicated "regulators" node but this causes multiple dtschema warnings: regulators: $nodename:0: 'regulators' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' regulators: #size-cells:0:0: 0 is not one of [1, 2] regulators: fixed-regulator@0:reg:0: [0] is too short regulators: fixed-regulator@1:reg:0: [1] is too short regulators: fixed-regulator@2:reg:0: [2] is too short Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s5pv210-aquila.dts | 47 +++++++++++----------------- 1 file changed, 19 insertions(+), 28 deletions(-) diff --git a/arch/arm/boot/dts/s5pv210-aquila.dts b/arch/arm/boot/dts/s5pv210-aquila.dts index 25d4ab4a52c5..28e9e81bb2d1 100644 --- a/arch/arm/boot/dts/s5pv210-aquila.dts +++ b/arch/arm/boot/dts/s5pv210-aquila.dts @@ -40,36 +40,27 @@ clock-frequency = <32768>; }; - regulators { - compatible = "simple-bus"; - #address-cells = <1>; - #size-cells = <0>; - - vtf_reg: fixed-regulator@0 { - compatible = "regulator-fixed"; - reg = <0>; - regulator-name = "V_TF_2.8V"; - regulator-min-microvolt = <2800000>; - regulator-max-microvolt = <2800000>; - gpio = <&mp05 4 GPIO_ACTIVE_HIGH>; - enable-active-high; - }; + vtf_reg: regulator-0 { + compatible = "regulator-fixed"; + regulator-name = "V_TF_2.8V"; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + gpio = <&mp05 4 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; - pda_reg: fixed-regulator@1 { - compatible = "regulator-fixed"; - regulator-name = "VCC_1.8V_PDA"; - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <1800000>; - reg = <1>; - }; + pda_reg: regulator-1 { + compatible = "regulator-fixed"; + regulator-name = "VCC_1.8V_PDA"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; - bat_reg: fixed-regulator@2 { - compatible = "regulator-fixed"; - regulator-name = "V_BAT"; - regulator-min-microvolt = <3700000>; - regulator-max-microvolt = <3700000>; - reg = <2>; - }; + bat_reg: regulator-2 { + compatible = "regulator-fixed"; + regulator-name = "V_BAT"; + regulator-min-microvolt = <3700000>; + regulator-max-microvolt = <3700000>; }; i2c_pmic: i2c-pmic { From patchwork Mon Sep 7 16:11:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761445 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9BC3259D for ; Mon, 7 Sep 2020 16:19:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8059921789 for ; Mon, 7 Sep 2020 16:19:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495578; bh=LCZiNPIu8jZhAFtcfPg9X65S8kNcPL3i2BZfvFXvaVM=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=V95HbcTap09lPJM+jU1pX6KpR2uYyadCb2Dfr/PlU92P3DxyQR38r8WmCnImGCIvh W79W5JltWAM6UTYrqAqNbllapOAogaqfl1ONMOdrSDrg+K2hAdaCkI4OmhuDvoCgXY OZG6sOlld42FHDytLHS9SmNlBP9g7fxlqULWk6KA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729972AbgIGQTS (ORCPT ); Mon, 7 Sep 2020 12:19:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:33922 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729986AbgIGQNw (ORCPT ); Mon, 7 Sep 2020 12:13:52 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 21C0921789; Mon, 7 Sep 2020 16:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495232; bh=LCZiNPIu8jZhAFtcfPg9X65S8kNcPL3i2BZfvFXvaVM=; h=From:To:Subject:Date:In-Reply-To:References:From; b=MpNx5OKX8ND25kEGqAv67cBNVnPCrNRD5idk6KCBbLRucUK8v6NwfjLaiItYc7f0R yWFxB1O6hVraOXJsqOsncVQAjr+K/UyRUc4UIRvzhmg/q5laLEja1dkjQagxVvmlxV p6uDmMsFLwLyYWAqilto+JEOA9DaW//5zSxuBbuo= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [RFT 21/25] ARM: dts: s5pv210: move fixed regulators under root node in Goni Date: Mon, 7 Sep 2020 18:11:37 +0200 Message-Id: <20200907161141.31034-22-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The fixed regulators are kept under dedicated "regulators" node but this causes multiple dtschema warnings: regulators: $nodename:0: 'regulators' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' regulators: #size-cells:0:0: 0 is not one of [1, 2] regulators: fixed-regulator@0:reg:0: [0] is too short regulators: fixed-regulator@1:reg:0: [1] is too short regulators: fixed-regulator@2:reg:0: [2] is too short regulators: fixed-regulator@3:reg:0: [3] is too short Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s5pv210-goni.dts | 64 +++++++++++++----------------- 1 file changed, 27 insertions(+), 37 deletions(-) diff --git a/arch/arm/boot/dts/s5pv210-goni.dts b/arch/arm/boot/dts/s5pv210-goni.dts index 20f1c2773805..eec6531e6ef8 100644 --- a/arch/arm/boot/dts/s5pv210-goni.dts +++ b/arch/arm/boot/dts/s5pv210-goni.dts @@ -42,46 +42,36 @@ clock-frequency = <32768>; }; - regulators { - compatible = "simple-bus"; - #address-cells = <1>; - #size-cells = <0>; - - vtf_reg: fixed-regulator@0 { - compatible = "regulator-fixed"; - regulator-name = "V_TF_2.8V"; - regulator-min-microvolt = <2800000>; - regulator-max-microvolt = <2800000>; - reg = <0>; - gpio = <&mp05 4 GPIO_ACTIVE_HIGH>; - enable-active-high; - }; + vtf_reg: regulator-0 { + compatible = "regulator-fixed"; + regulator-name = "V_TF_2.8V"; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + gpio = <&mp05 4 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; - pda_reg: fixed-regulator@1 { - compatible = "regulator-fixed"; - regulator-name = "VCC_1.8V_PDA"; - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <1800000>; - reg = <1>; - }; + pda_reg: regulator-1 { + compatible = "regulator-fixed"; + regulator-name = "VCC_1.8V_PDA"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; - bat_reg: fixed-regulator@2 { - compatible = "regulator-fixed"; - regulator-name = "V_BAT"; - regulator-min-microvolt = <3700000>; - regulator-max-microvolt = <3700000>; - reg = <2>; - }; + bat_reg: regulator-2 { + compatible = "regulator-fixed"; + regulator-name = "V_BAT"; + regulator-min-microvolt = <3700000>; + regulator-max-microvolt = <3700000>; + }; - tsp_reg: fixed-regulator@3 { - compatible = "regulator-fixed"; - regulator-name = "TSP_VDD"; - regulator-min-microvolt = <2800000>; - regulator-max-microvolt = <2800000>; - reg = <3>; - gpio = <&gpj1 3 GPIO_ACTIVE_HIGH>; - enable-active-high; - }; + tsp_reg: regulator-3 { + compatible = "regulator-fixed"; + regulator-name = "TSP_VDD"; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + gpio = <&gpj1 3 GPIO_ACTIVE_HIGH>; + enable-active-high; }; i2c_pmic: i2c-pmic { From patchwork Mon Sep 7 16:11:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761429 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8F70113B1 for ; Mon, 7 Sep 2020 16:18:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B963208C7 for ; Mon, 7 Sep 2020 16:18:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495537; bh=lJTmDWXKg31GyIqyPqmh82OMpoVmcuqwnXsiJb+RucQ=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=sJA898PCETFVG65IQU+QOvgMCfDmqaa0Kelu7szZwrrCB87IAdd3xW2iEM6aqs25Y yBHlAXcgb4m/bosX9TgP3Ma3hpw82tVzQFRCbODTZ5use6AeTMN1BRZNCvP7Ayz341 5BFhhteVTozU06uaI18B9Krqbnr2iTGtd4JiAd4I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729995AbgIGQSz (ORCPT ); Mon, 7 Sep 2020 12:18:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:33966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730321AbgIGQN4 (ORCPT ); Mon, 7 Sep 2020 12:13:56 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 78C0621897; Mon, 7 Sep 2020 16:13:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495235; bh=lJTmDWXKg31GyIqyPqmh82OMpoVmcuqwnXsiJb+RucQ=; h=From:To:Subject:Date:In-Reply-To:References:From; b=apbLCJlXZDFOcqmNdYWKAzYQ5IYHMZM0fzUr/YBo4a3tCRD9ELwNdyRu2pOZh1vmg PGXKryJQ5bXeTX23Z8mt93I/IOYHBsKxh+gsZ7z1XcmdKyWd8kWHxk+eQcH5hU52Fj GCRVfGx0ID0YL6dibhHWAaIw3bhpNRPBD3lKLQBo= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [RFT 22/25] ARM: dts: s5pv210: replace deprecated "gpios" i2c-gpio property in Aquila Date: Mon, 7 Sep 2020 18:11:38 +0200 Message-Id: <20200907161141.31034-23-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org "gpios" property is deprecated. Update the Aquila DTS to fix dtbs_checks warnings like: i2c-pmic: 'sda-gpios' is a required property i2c-pmic: 'scl-gpios' is a required property Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s5pv210-aquila.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/s5pv210-aquila.dts b/arch/arm/boot/dts/s5pv210-aquila.dts index 28e9e81bb2d1..8e57e5a1f0c5 100644 --- a/arch/arm/boot/dts/s5pv210-aquila.dts +++ b/arch/arm/boot/dts/s5pv210-aquila.dts @@ -65,8 +65,8 @@ i2c_pmic: i2c-pmic { compatible = "i2c-gpio"; - gpios = <&gpj4 0 GPIO_ACTIVE_HIGH>, /* sda */ - <&gpj4 3 GPIO_ACTIVE_HIGH>; /* scl */ + sda-gpios = <&gpj4 0 GPIO_ACTIVE_HIGH>; + scl-gpios = <&gpj4 3 GPIO_ACTIVE_HIGH>; i2c-gpio,delay-us = <2>; /* ~100 kHz */ #address-cells = <1>; #size-cells = <0>; From patchwork Mon Sep 7 16:11:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761425 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 48EFD1599 for ; Mon, 7 Sep 2020 16:18:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2BE752080A for ; Mon, 7 Sep 2020 16:18:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495533; bh=jWL3HWcEEiNy/8rVC7of/uRNx5Tnyo1FPmlxmXCKRBs=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=hNsgAdkOl6FYNu0KUSKwc6BnbV2V8t8ZYJIm6nDmofPYKip34LFaycc+UCO4GS6na zXti9zfUNGdKLErCY7Jx8udXY4JlSGK3x3MwKPcG1ZZCQrkwl8nnIskIJdPSDaPGED FID8fJKKHVpp6XHDzbzOHYynFM5cUp+IXJf9sbhg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730448AbgIGQOE (ORCPT ); Mon, 7 Sep 2020 12:14:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:34004 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729893AbgIGQN7 (ORCPT ); Mon, 7 Sep 2020 12:13:59 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1641D2177B; Mon, 7 Sep 2020 16:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495238; bh=jWL3HWcEEiNy/8rVC7of/uRNx5Tnyo1FPmlxmXCKRBs=; h=From:To:Subject:Date:In-Reply-To:References:From; b=iKLcR5zfkqvnazuCXr9yn7VqbcERxdWOIZBqIz9YdCR//HQh5G4biLwQe9jpFkztW jMEzjpnJlJ09LOpX92V8MZ6uxOQ7HXBuNvSglz/haWLZZiiesc1yIr5eUFpWP9ChEc Fi6sj66RzV9aDkequXlALLdESWA+dvlG3DOOZrKs= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [RFT 23/25] ARM: dts: s5pv210: replace deprecated "gpios" i2c-gpio property in Goni Date: Mon, 7 Sep 2020 18:11:39 +0200 Message-Id: <20200907161141.31034-24-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org "gpios" property is deprecated. Update the Goni DTS to fix dtbs_checks warnings like: i2c-pmic: 'sda-gpios' is a required property i2c-pmic: 'scl-gpios' is a required property Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s5pv210-goni.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/s5pv210-goni.dts b/arch/arm/boot/dts/s5pv210-goni.dts index eec6531e6ef8..ad8d5d2fa32d 100644 --- a/arch/arm/boot/dts/s5pv210-goni.dts +++ b/arch/arm/boot/dts/s5pv210-goni.dts @@ -76,8 +76,8 @@ i2c_pmic: i2c-pmic { compatible = "i2c-gpio"; - gpios = <&gpj4 0 GPIO_ACTIVE_HIGH>, /* sda */ - <&gpj4 3 GPIO_ACTIVE_HIGH>; /* scl */ + sda-gpios = <&gpj4 0 GPIO_ACTIVE_HIGH>; + scl-gpios = <&gpj4 3 GPIO_ACTIVE_HIGH>; i2c-gpio,delay-us = <2>; /* ~100 kHz */ #address-cells = <1>; #size-cells = <0>; From patchwork Mon Sep 7 16:11:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761421 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D5EC113B1 for ; Mon, 7 Sep 2020 16:18:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2118208C7 for ; Mon, 7 Sep 2020 16:18:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495531; bh=FvdcTxTqJSV8i1AoGBW4JbEg+c4jrac22rp1N0zL13c=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=uhwzQv3uXpDnY88gCfxOQmWosPiHGu0YGWqZyZkKY5m052tz+1j8Z+YGm2wssLYnZ L2V8MtazzKH/E1xW7ZRuuBdRZVteXpUZ0E4oseJmO0j5TPcn/4WYTHLuubUqMYsOiP PFKrwKcUhg5dSD298H4DQjgcqnKo+bxRbQ8sEKIU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730452AbgIGQOF (ORCPT ); Mon, 7 Sep 2020 12:14:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:34050 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729916AbgIGQOC (ORCPT ); Mon, 7 Sep 2020 12:14:02 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2F8E8206E6; Mon, 7 Sep 2020 16:13:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495241; bh=FvdcTxTqJSV8i1AoGBW4JbEg+c4jrac22rp1N0zL13c=; h=From:To:Subject:Date:In-Reply-To:References:From; b=eFtiJjR1HcgO5wpmayaA/t8LIQDw5BSDdkGyRkZ6rWmwjvpQLkKMgv3ckFmNdnrDL 26hXfMqVjAZK6OPeE1FfK/kDTr8e4wVc4/qX/RLhgEwzLbtB16tMNxIaloiABJ7rBk uILe9GoqQRs2v727Sk2DGAN2bO9iXuEHo8qBxdok= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [RFT 24/25] ARM: dts: s5pv210: align SPI GPIO node name with dtschema in Aries Date: Mon, 7 Sep 2020 18:11:40 +0200 Message-Id: <20200907161141.31034-25-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The device tree schema expects SPI controller to be named "spi", otherwise dtbs_check complain with a warning like: spi-gpio-0: $nodename:0: 'spi-gpio-0' does not match '^spi(@.*|-[0-9a-f])*$' Signed-off-by: Krzysztof Kozlowski Tested-by: Jonathan Bakker --- arch/arm/boot/dts/s5pv210-aries.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi index 86c3b26fd21e..bd4450dbdcb6 100644 --- a/arch/arm/boot/dts/s5pv210-aries.dtsi +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi @@ -545,7 +545,7 @@ value = <0x5200>; }; - spi_lcd: spi-gpio-0 { + spi_lcd: spi-2 { compatible = "spi-gpio"; #address-cells = <1>; #size-cells = <0>; From patchwork Mon Sep 7 16:11:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11761419 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C6A0159D for ; Mon, 7 Sep 2020 16:18:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE7A8208C7 for ; Mon, 7 Sep 2020 16:18:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495520; bh=bwtOi8QElP0mGjZhVUaaYJrre3PcACxIN1rrV3SxlNw=; h=From:To:Subject:Date:In-Reply-To:References:List-ID:From; b=i2/c/z8FYgj4ht0i+P9FOsz0LKKAN/pVn5hD0sDEUWskFCwjstcwxaG7Rs0EiO9Mt gSRDNEsDwCZyb0Zez9jVv0jZXIcwHuRBAMtfpY7PvB2nz99bu3/ekxk/KS/R1Lm0Tg 2rL9SnjkIZDA2Qmwh8UnX46WEkdu20sZ7JmAPFnc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730455AbgIGQOI (ORCPT ); Mon, 7 Sep 2020 12:14:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:34096 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730453AbgIGQOG (ORCPT ); Mon, 7 Sep 2020 12:14:06 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2D1AB207DE; Mon, 7 Sep 2020 16:14:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599495245; bh=bwtOi8QElP0mGjZhVUaaYJrre3PcACxIN1rrV3SxlNw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=UYSZxr7VgfQX85+efnx0NAZinxygKy1kqfcI7NL163KkguKnH6Q6dd6fGPoc7+E0Z wxtyeFS25ChjYbXllL/KHWggeCnRQvDmF7P85PVn9/oUtIecD3rE+pknvEsLHJsstj R5STZXc7cq6FhMu0OvpuG97q4DvqJIDNW8EpzziY= From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Bakker , =?utf-8?q?Pawe=C5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: [RFT 25/25] ARM: dts: s5pv210: align DMA channels with dtschema Date: Mon, 7 Sep 2020 18:11:41 +0200 Message-Id: <20200907161141.31034-26-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200907161141.31034-1-krzk@kernel.org> References: <20200907161141.31034-1-krzk@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org dtschema expects DMA channels in specific order (tx, rx and tx-sec). The order actually should not matter because dma-names is used however let's make it aligned with dtschema to suppress warnings like: i2s@eee30000: dma-names: ['rx', 'tx', 'tx-sec'] is not valid under any of the given schemas Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s5pv210.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi index 96e667ba1c3f..72fb9d9f7ba3 100644 --- a/arch/arm/boot/dts/s5pv210.dtsi +++ b/arch/arm/boot/dts/s5pv210.dtsi @@ -240,8 +240,8 @@ reg = <0xeee30000 0x1000>; interrupt-parent = <&vic2>; interrupts = <16>; - dma-names = "rx", "tx", "tx-sec"; - dmas = <&pdma1 9>, <&pdma1 10>, <&pdma1 11>; + dma-names = "tx", "rx", "tx-sec"; + dmas = <&pdma1 10>, <&pdma1 9>, <&pdma1 11>; clock-names = "iis", "i2s_opclk0", "i2s_opclk1"; @@ -260,8 +260,8 @@ reg = <0xe2100000 0x1000>; interrupt-parent = <&vic2>; interrupts = <17>; - dma-names = "rx", "tx"; - dmas = <&pdma1 12>, <&pdma1 13>; + dma-names = "tx", "rx"; + dmas = <&pdma1 13>, <&pdma1 12>; clock-names = "iis", "i2s_opclk0"; clocks = <&clocks CLK_I2S1>, <&clocks SCLK_AUDIO1>; pinctrl-names = "default"; @@ -275,8 +275,8 @@ reg = <0xe2a00000 0x1000>; interrupt-parent = <&vic2>; interrupts = <18>; - dma-names = "rx", "tx"; - dmas = <&pdma1 14>, <&pdma1 15>; + dma-names = "tx", "rx"; + dmas = <&pdma1 15>, <&pdma1 14>; clock-names = "iis", "i2s_opclk0"; clocks = <&clocks CLK_I2S2>, <&clocks SCLK_AUDIO2>; pinctrl-names = "default";