From patchwork Sun Sep 13 23:03:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Drew Fustini X-Patchwork-Id: 11772531 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6FEDD1709 for ; Sun, 13 Sep 2020 23:06:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38D7B20731 for ; Sun, 13 Sep 2020 23:06:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LwBtTv1Q"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=beagleboard-org.20150623.gappssmtp.com header.i=@beagleboard-org.20150623.gappssmtp.com header.b="xGYPnpkO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38D7B20731 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=beagleboard.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=jJShwXQFXlZI4G+1E8ATklZSmjF5za3enlA4soFCGjg=; b=LwBtTv1QlIe3rnakWfvkXY05cR Q8olBreCY+T+cCb4X7VA1uc6ODCQkr/PoOjxxMSCsKL4gccd6FXTvp2tD25lMjxbD1mWQ6c4QEA7f v65yIauX1SpQ6d8zD1KeAIfm1FvmuLwDy+vIOu4ANEblsZ+tPCq4Wb3TzcLTVgGDhiQW076f8OpHl x7sNl2k+E4nBLi5pZWNOqLTHnyYl2pEGBtl7flx0Aehc1N894dlXH+/F+3OJEWL/l1FosUbDC1PRp ahDHu8pl0zkXKs6TZMQTSgIMaP8nJNGiu63AMvvmLXy6noHekNbE2UpBnsW0YTvvKViqrrx6mqwrO 8uWUpVpw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHb2W-0004TW-W6; Sun, 13 Sep 2020 23:04:09 +0000 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHb2U-0004T7-GP for linux-arm-kernel@lists.infradead.org; Sun, 13 Sep 2020 23:04:07 +0000 Received: by mail-ej1-x644.google.com with SMTP id q13so20547234ejo.9 for ; Sun, 13 Sep 2020 16:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9SldZtCk2q4nsXGS7xAt+YvKP+JMD0RBd/7nndQ7OzQ=; b=xGYPnpkOvjV2guhiQLfbAkzC/7YNuCzGUhPdX8zeH04ezPUD9aZl3fN1vWZJUU9+3H un9+d62uLxDQklFkXGKGBVt+aBq558OFOSEeL1mewIn/2ltoz8wrbRMNiq7Oz1VVGCkN l2NcUeZT64lVwLnJdoPdGrdfaxHSeQWIdKA3jn/Meo5aMBxpwLW3di+WhePRRbYj/zlg i+ivxcDQY9xCoZFM3maEt58qGAk4nFjRolpgCGRMOKkcsQrIazsISN15bJN/hWzH/4Kt 9ZF+eDCI5fSFdKKwJGyPMne985PfgZi7D2R7hcsabYIrCf2PiUAZNlEvc4DlhX8HFBxr rawg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9SldZtCk2q4nsXGS7xAt+YvKP+JMD0RBd/7nndQ7OzQ=; b=Z6DRrd8YqZORiyQy6Ib8XQKKhE1WoYrEuVXCtjx+DJFt8H635qRo3CxS9MzdAMgOvg A6NcZohLQX45p2vFc+OYbAR9fJ+XD/5AecOWJkd4gmPfdu2L+FwQYVk1bVJ1qTyC4rGv Nvig3cCk0aG7caVGcWsHqfGwZzoGWWDhf/Gh+u5salM2MOuSqiqmZzTqzE6NBx/nWgkL QEykJYsZaYI6/b4XEYthq4JlVRn4pjAUfIAewUA501kkkClqDsHsZwiCDfNdmmMFo2Hv 5jRqJS5R1/K4JPmXaH/uIJ1HaHs6JeiMXdkHY/p1qZcFcbVaLxwUssnabGOXaxz+Pr0D o7Fg== X-Gm-Message-State: AOAM533mlzCrb42/iU/7UBYR7/I/KK+N9NooBTLp1Pv9lwx0KsFUqqzk S6+6xkwOUMZiUKDM37p+lBek45GrJyQ3Tohc1jo= X-Google-Smtp-Source: ABdhPJymLIzw6wH0ol290j3Ilni2SshdpfYbKIN/B8glAUUXu/TzNoFjW+VT/pdj29EtJ9S1cUY8jw== X-Received: by 2002:a17:906:a207:: with SMTP id r7mr12092932ejy.32.1600038244812; Sun, 13 Sep 2020 16:04:04 -0700 (PDT) Received: from localhost.localdomain ([2604:a880:400:d0::26:8001]) by smtp.gmail.com with ESMTPSA id jo26sm6280761ejb.120.2020.09.13.16.04.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2020 16:04:03 -0700 (PDT) From: Drew Fustini To: linux-arm-kernel@lists.infradead.org, Tony Lindgren , Rob Herring , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Linus Walleij , Haojian Zhuang , devicetree@vger.kernel.org, bcousson@baylibre.com, Jason Kridner , Robert Nelson , Trent Piepho Subject: [PATCH v2] pinctrl: single: fix debug output when #pinctrl-cells = 2 Date: Mon, 14 Sep 2020 01:03:07 +0200 Message-Id: <20200913230306.2061645-1-drew@beagleboard.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200913_190406_572427_04002C36 X-CRM114-Status: GOOD ( 15.31 ) X-Spam-Score: 0.7 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:644 listed in] [list.dnswl.org] X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Drew Fustini Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The debug output in pcs_parse_one_pinctrl_entry() needs to be updated to print the correct pinctrl register value when #pinctrl-cells is 2. Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2") Reported-by: Trent Piepho Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/ Signed-off-by: Drew Fustini Acked-by: Tony Lindgren --- v2 change: this is a fix to my prior email where I referred to #pinctrl-cells = 3 which is incorrect. pinctrl_spec.args_count is 3 but #pinctrl-cells = 2 https://lore.kernel.org/linux-omap/20200913224746.2048603-1-drew@beagleboard.org/ drivers/pinctrl/pinctrl-single.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index 5cbf0e55087c..f3cd7e296712 100644 --- a/drivers/pinctrl/pinctrl-single.c +++ b/drivers/pinctrl/pinctrl-single.c @@ -1033,7 +1033,7 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs, } dev_dbg(pcs->dev, "%pOFn index: 0x%x value: 0x%x\n", - pinctrl_spec.np, offset, pinctrl_spec.args[1]); + pinctrl_spec.np, offset, vals[found].val); pin = pcs_get_pin_by_offset(pcs, offset); if (pin < 0) {