From patchwork Fri Oct 26 00:45:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10656839 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7EAB9109C for ; Fri, 26 Oct 2018 00:45:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 74B422C24D for ; Fri, 26 Oct 2018 00:45:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 690C22C6C8; Fri, 26 Oct 2018 00:45:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 16FB72C652 for ; Fri, 26 Oct 2018 00:45:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726193AbeJZJUS (ORCPT ); Fri, 26 Oct 2018 05:20:18 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:41279 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726180AbeJZJUR (ORCPT ); Fri, 26 Oct 2018 05:20:17 -0400 Received: by mail-qt1-f193.google.com with SMTP id l41-v6so12182004qtl.8 for ; Thu, 25 Oct 2018 17:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=k98qfZFTnS8YJsoHEehtGRqClwouswNGYRpoM+jy0g0=; b=WfCe3OEfI5h5TiyKZsUsPEW2ZKcSFLs7dwNQWaIFKq66ADuDggB/mQcSdWhrtg+mUd nXLELbHh2LuH2DsgCXMmPv1OfsjauU70IQWSz0OnSTxjisc4ZmosHus0Nvnbt+ktMMUl pDzz/9wgNySKhry6SU46DAvPxZQMH7YF+PvOjZIuFDlbavhM79P8chxr9ZMUX5GbnFRq 4yHKooNi8IqMfMxz1I8mhHt9cYA5zo58fyVfiaSlzJJ4t3/m2BDlTp4EdNWQTw3Bv/Ci ABN8Vwi+jOKAdAZo7DqWNd2piS5ntdYePWUWi9mCDYdqThPpPUrn3pujlv67tGTWoEh3 vd6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=k98qfZFTnS8YJsoHEehtGRqClwouswNGYRpoM+jy0g0=; b=qlv22K6tKw95PR/j2JgRfeqMnVmQAdafcD//H5flL/5Q2IhQX6sSGvU26EibPGp0Uu LIcd+rbJfrC8k6lJcyH9xKFqmdDiaf/Yn+564hXIN8q9+0/ST1XCllSvUwsFLbmV0bdJ EWBQaPiDL4eMtQ0pqZRyxXLjM2cXMpy25fsZl8O8OGQCvflM7EyD1N8ypwE58XiIJgBh os7ZZlg8uGPJNmQqMFQU1F5w3WG/AjbLhO0g2XEhsqXHMUYtTfcfnhVrR7Nx/HPxF/QB Iz8hl8oAlrSu/olr8e9nwawS6uP4852wOwBm93it0B3c8HpApCCE5UCPQ1ogavaSRSQ7 1gPA== X-Gm-Message-State: AGRZ1gJ6CtUgYrErN4kfIVU8LeWV157n1Qk/oRRCs1a7LovPskGVsnRp wTx0GGWQCUj3p9Nhmj8080ZeuA== X-Google-Smtp-Source: AJdET5dDxewdUwp9hl2WPeGetOqfFX7Y/rpJzmAex0gSFrFxaLYFikbhqjN5vznas7V45/6Zw8tcPQ== X-Received: by 2002:ac8:1b58:: with SMTP id p24-v6mr1364608qtk.56.1540514727014; Thu, 25 Oct 2018 17:45:27 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id y3-v6sm2371735qti.27.2018.10.25.17.45.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Oct 2018 17:45:26 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH 1/6] staging:iio:ad2s90: Make read_raw return spi_read's error code Date: Thu, 25 Oct 2018 21:45:07 -0300 Message-Id: <20181026004512.31012-2-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181026004512.31012-1-matheus.bernardino@usp.br> References: <20181026004512.31012-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Previously, when spi_read returned an error code inside ad2s90_read_raw, the code was ignored and IIO_VAL_INT was returned. This patch makes the function return the error code returned by spi_read when it fails. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index 59586947a936..11fac9f90148 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -35,12 +35,15 @@ static int ad2s90_read_raw(struct iio_dev *indio_dev, struct ad2s90_state *st = iio_priv(indio_dev); mutex_lock(&st->lock); + ret = spi_read(st->sdev, st->rx, 2); - if (ret) - goto error_ret; + if (ret < 0) { + mutex_unlock(&st->lock); + return ret; + } + *val = (((u16)(st->rx[0])) << 4) | ((st->rx[1] & 0xF0) >> 4); -error_ret: mutex_unlock(&st->lock); return IIO_VAL_INT; From patchwork Fri Oct 26 00:45:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10656841 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4C77514E2 for ; Fri, 26 Oct 2018 00:45:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3DCAB2C24D for ; Fri, 26 Oct 2018 00:45:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 31DDF2C6C8; Fri, 26 Oct 2018 00:45:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D42A32C24D for ; Fri, 26 Oct 2018 00:45:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726111AbeJZJUU (ORCPT ); Fri, 26 Oct 2018 05:20:20 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:37314 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725849AbeJZJUU (ORCPT ); Fri, 26 Oct 2018 05:20:20 -0400 Received: by mail-qt1-f193.google.com with SMTP id d14-v6so12209723qto.4 for ; Thu, 25 Oct 2018 17:45:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NGr8UhZ9CwRomF1EVbg7fLmktxQjU3RFkveOlg5US54=; b=rOKyx10RBKfSqOFtomhH6h1F9pCvFTdlBHfhpdYPitYnjM4w60pTYS/+VVgnO8GPh6 8lpYdCvbst88qyJ+GA0Jo6R/J3zlsy8i6cu/bmUJa1ajX/J/vx4IWlAS/FANAlcrIlqb Ok/fzUl8pNPLLHPj+XmhxzpO44mvJRSxspzN/ZzErOOw7XnS7OqukMveU5xxbyXl1aBI i6DiyO5ILy8uqyx8X7t9+bDP332/wI0uUzXllGxKQ4H9mDHzNLqMC+nudw/F3YY2R5ll HfP5f7dEGRrzdmG9J8itw9tb6Tpoz45Fk/mAy/OMfNVY2Rj9Furwd97Tpj2zquNldt8b TH+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NGr8UhZ9CwRomF1EVbg7fLmktxQjU3RFkveOlg5US54=; b=T1dfVzsVzB2DZohWUlmFveHBWFBoI4BXBC61IU5ImBe5NPPRA8G5zs7Du4NKUIxzCP ZEIBGqZ3H/HCLC9L8+wmdsu13vyPgnP1v/Y0OhSTAznrKJbA7IQdhN3Jppd/UADoI3az Zj7ARe3ShCdrY1HZ5+b84ByKWKmrL9nCdkzILxRz5Rcpq5PNHYFKHHXAEpTIJoTLO87G 6MMGkXU2RNTwF7c8A/3bn0zTvRIeDBX/nkmgfkF24FDQHtTOPp47bO16O1R0Iro1IJ/D 8PmTeoIRtIqSHOxifwFyNWXNtt91uRXVe2My5TaVSNTgJq0Tf6iggZqF8Ga9T1ptVbFK stQQ== X-Gm-Message-State: AGRZ1gKSwnD9udmxQJdIEfqcfiPQ/iEk5cnyZ89EdA/dYQviexsW6SoG wlq07uylFHzlq9y+oBd2bsa47w== X-Google-Smtp-Source: AJdET5dr5t3m8XMFDiKyAjILMJM7tAbXfincs/RfvmTFPw4kt2EiwgecmvjJwTGxnjfMRI3FEZKL8Q== X-Received: by 2002:aed:3b4b:: with SMTP id q11-v6mr1333973qte.229.1540514729837; Thu, 25 Oct 2018 17:45:29 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id y3-v6sm2371735qti.27.2018.10.25.17.45.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Oct 2018 17:45:29 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH 2/6] staging:iio:ad2s90: Make probe handle spi_setup failure Date: Thu, 25 Oct 2018 21:45:08 -0300 Message-Id: <20181026004512.31012-3-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181026004512.31012-1-matheus.bernardino@usp.br> References: <20181026004512.31012-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Previously, ad2s90_probe ignored the return code from spi_setup, not handling its possible failure. This patch makes ad2s90_probe check if the code is an error code and, if so, do the following: - Call dev_err with an appropriate error message. - Return the spi_setup's error code, aborting the execution of the rest of the function. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index 11fac9f90148..d6a42e3f1bd8 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -88,7 +88,12 @@ static int ad2s90_probe(struct spi_device *spi) /* need 600ns between CS and the first falling edge of SCLK */ spi->max_speed_hz = 830000; spi->mode = SPI_MODE_3; - spi_setup(spi); + ret = spi_setup(spi); + + if (ret < 0) { + dev_err(&spi->dev, "spi_setup failed!\n"); + return ret; + } return 0; } From patchwork Fri Oct 26 00:45:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10656849 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1A81714E2 for ; Fri, 26 Oct 2018 00:45:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 111642C24D for ; Fri, 26 Oct 2018 00:45:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 057422C652; Fri, 26 Oct 2018 00:45:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A825C2C6C8 for ; Fri, 26 Oct 2018 00:45:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726592AbeJZJUY (ORCPT ); Fri, 26 Oct 2018 05:20:24 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:37323 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726367AbeJZJUX (ORCPT ); Fri, 26 Oct 2018 05:20:23 -0400 Received: by mail-qt1-f195.google.com with SMTP id d14-v6so12209829qto.4 for ; Thu, 25 Oct 2018 17:45:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=J5RxTErJXoIN4DFbUXbMSG5XxKyOAlaWHaLsxy5wXNA=; b=IfrNsM4AxhSnWDdkSFRcz+w1o9OyzWXIeRS2LPgnU7cZLE9hG5iC0jvLMFjgMBGhn8 0TbvVqWOYBEDT2nlu79IZr00SAKUIWO5JetEbgEDG4Si/oWDsZQa7+iLrNEtZ6zFpYac b7AntHRcyWJ3PVU0nGXAj8UwPUljobOHT81AOj95nI9WE52hlHVkmTWL/mVdq9gypnk/ bEtiIGGy2aOd7Dg+heGWJx8Fv/7zGefZatjN1VZ973bxIHVE1LsqipFHBHJiTdxV57gF iYE6097l/3sBWivydTAST5U69a5Lck4id7trI14crXdMUV/rjvPvQf3XMVEr1428f4/8 TR1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=J5RxTErJXoIN4DFbUXbMSG5XxKyOAlaWHaLsxy5wXNA=; b=r3urbbliq91IAohXzSIChWlaplSNZmvMINI3NOHYy+ZR+mGfBLaYFc/hLsZs2piQTE 9DpBUz0SfYNfmxskv7Kwig35bwX2l2tE+bdK0j2byf4HZ8NkLwsbQDdeKFYVtjE7KImw ixCSTLfmplV/cZ0pnAx2BdYzA9KOSpNj4oaqAZQpp0i4pUxAhYNcV/TX3/NchQfua+c8 1fv6bsLm1+Nud87KOdWOEz/yVQiIa/RBv+CZnVKVUTBiGb92dW2yvT7NA/zWSNig1f/J s+HGTaE/gQZcy50IgRyPqEowTK/RKPEmpURbdvIhvv+SfGKE1lKT8jUKJW26CU1zxc8I HgiQ== X-Gm-Message-State: AGRZ1gIY+Q+Q9AH0e6FaZTHLs7Ra1Vi6wadMAPnCcqDPoaZQApSnb297 MHusE2zdVFcqbuN3QUUxeoPqiQ== X-Google-Smtp-Source: AJdET5eYrL3B/6dDzP8IGUjwaVecsh3FNyp3rV8oNHMSnHyIglObGdVoGIhMr03WixV2ngY3+yxZIg== X-Received: by 2002:ac8:4506:: with SMTP id q6-v6mr1422639qtn.68.1540514732803; Thu, 25 Oct 2018 17:45:32 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id y3-v6sm2371735qti.27.2018.10.25.17.45.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Oct 2018 17:45:32 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH 3/6] staging:iio:ad2s90: Remove always overwritten assignment Date: Thu, 25 Oct 2018 21:45:09 -0300 Message-Id: <20181026004512.31012-4-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181026004512.31012-1-matheus.bernardino@usp.br> References: <20181026004512.31012-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch removes an initial assignment to the variable ret at probe, that was always overwritten. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index d6a42e3f1bd8..c20d37dc065a 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -64,7 +64,7 @@ static int ad2s90_probe(struct spi_device *spi) { struct iio_dev *indio_dev; struct ad2s90_state *st; - int ret = 0; + int ret; indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st)); if (!indio_dev) From patchwork Fri Oct 26 00:45:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10656847 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0759A109C for ; Fri, 26 Oct 2018 00:45:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F01E02C24D for ; Fri, 26 Oct 2018 00:45:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E33052C6C8; Fri, 26 Oct 2018 00:45:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6E5442C24D for ; Fri, 26 Oct 2018 00:45:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727020AbeJZJU1 (ORCPT ); Fri, 26 Oct 2018 05:20:27 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:33685 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726556AbeJZJU0 (ORCPT ); Fri, 26 Oct 2018 05:20:26 -0400 Received: by mail-qk1-f194.google.com with SMTP id o89so6958942qko.0 for ; Thu, 25 Oct 2018 17:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Z2LHH9F5OJ0rvYdq5SDRuLDudXHduK0q/J3//KKhqZw=; b=ARIBD8TyH/vpvD17XO4fYyhxRcRMRUvKgZ4q1+hMMFlBmr61E4PU6cFWl4PtpMc6q8 9EU9JxHvK8ih9rwuQehPzA6ybyj7s+qp8MuwLs5Up4CokYEYmTEjPoSuUGh/4/cnwRdH YFkR0t+gLuemnErWZYo88pG604blVLtCZazqjmo+6So8ScvAhi29csFxtoCSsO7n+7XM nvtj4HEK3OZ8uYR7xAvznNXolK/6KAUvRZNrl/IYoj8dN5bns1170bVdBZb2pjcRmelp LyChpy8ajnNf8tBK77ITL+14kL5435LaRizJsbQ4K7OZysRWzmAexJcj1tnSd49VQCsT IlkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Z2LHH9F5OJ0rvYdq5SDRuLDudXHduK0q/J3//KKhqZw=; b=YYfppXUnGT4TeUGxp+07h8PV5SWqCBV+4QfG0Zci4cyXscCU4IVAnGnQzCAlzHNf8N AN1V6CpdgKimpatOqqfSsy0eUW/is1PagY4OZmdoW+aKgqxzh2GJ83QvZqcGWuoEEY8e HwnjFy6pfVwTp4zgjqKOxc0lhlF1YJ7wE3TEaOI/Fdt0bZC5dC3BeWb8DqMVx7u0z5JK suMs4ttfBAnX3jjM4MJDG6+UdtePeuGlzLEpD5voD6GJLqB1JaDHido+z+bjNFAlWFMY Vl7wy3aVFA/b1m4HbMazJEtgkpd6ERsmsL40OSuy88nE5fjchgS4TMqUOjI54Q2xkCni Z6uQ== X-Gm-Message-State: AGRZ1gLQ/+z5GI0xoIupG9M+OMAC22JQSJouz/3STZoApr65V5I62Obf L3KvAUZ8ypvdlH3sfCCsMYXQ1g== X-Google-Smtp-Source: AJdET5cyOAOdtWKoBifkV5+tKIEVZG0aqfjFItFDEFk4bPtY2o/Muy9NaJuascOIMXxZNHldf1jHlQ== X-Received: by 2002:a37:8d06:: with SMTP id p6-v6mr1273181qkd.4.1540514735667; Thu, 25 Oct 2018 17:45:35 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id y3-v6sm2371735qti.27.2018.10.25.17.45.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Oct 2018 17:45:35 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH 4/6] staging:iio:ad2s90: Move device registration to the end of probe Date: Thu, 25 Oct 2018 21:45:10 -0300 Message-Id: <20181026004512.31012-5-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181026004512.31012-1-matheus.bernardino@usp.br> References: <20181026004512.31012-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Previously, devm_iio_device_register was being called before the spi_setup call and the spi_device's max_speed_hz and mode assignments. This could lead to a race condition since the driver was still being set up after it was already made ready to use. To fix it, this patch moves the device registration to the end of ad2s90_probe. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index c20d37dc065a..b4a6a89c11b0 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -81,10 +81,6 @@ static int ad2s90_probe(struct spi_device *spi) indio_dev->num_channels = 1; indio_dev->name = spi_get_device_id(spi)->name; - ret = devm_iio_device_register(indio_dev->dev.parent, indio_dev); - if (ret) - return ret; - /* need 600ns between CS and the first falling edge of SCLK */ spi->max_speed_hz = 830000; spi->mode = SPI_MODE_3; @@ -95,7 +91,7 @@ static int ad2s90_probe(struct spi_device *spi) return ret; } - return 0; + return devm_iio_device_register(indio_dev->dev.parent, indio_dev); } static const struct spi_device_id ad2s90_id[] = { From patchwork Fri Oct 26 00:45:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10656845 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6DFD3109C for ; Fri, 26 Oct 2018 00:45:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 639E62C24D for ; Fri, 26 Oct 2018 00:45:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 48FEF2C6C8; Fri, 26 Oct 2018 00:45:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DFE5C2C652 for ; Fri, 26 Oct 2018 00:45:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727538AbeJZJUl (ORCPT ); Fri, 26 Oct 2018 05:20:41 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:44088 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726949AbeJZJU3 (ORCPT ); Fri, 26 Oct 2018 05:20:29 -0400 Received: by mail-qk1-f193.google.com with SMTP id n12so5738801qkh.11 for ; Thu, 25 Oct 2018 17:45:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=OkoLtsw0vdIrwS1FAqUPeM6GE5wcSzJ0J1yLPn9Rh1s=; b=NJHxq1VDcv6kW1pv7J+KC0jD41NfsfLO1FeLeG6sO8W1AgjQmjWxM5M/x6hwEPXoLV x2teyKt/sYevIS3tfXD3lDpLW6hsBUL6bxcHuMU8A5N+Nd9Z1oVUlgJSGmlimUT1SThA 57UnaMIzmqWcXLrz5pMIArzU9XNGIOuRmFfd8KXvXX6p7bdbe9g/46YL///PWE8E9bhf tPKd8u25G+tiFFcwXYECzjj3Knfci6CL35WP89XIsOHDd9esiGqZi6nHtZvI+0GinCkU K52XwjvGuFwR5xFmOsH8uoHcrup3UKQQexiLb+xxDNLCDNc8d5Ch1iF+6LnIvunyHJPo 2QHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=OkoLtsw0vdIrwS1FAqUPeM6GE5wcSzJ0J1yLPn9Rh1s=; b=Wjn81z6XjfjTYmPtHTQ9f1xbVTrSW0/6ETkaPxCx7yxrpFDQaqhGR+49VJb3Wd6s+K Y2DKVAZpxjsq3K9ChZdOHn9DLePwK8N1vGFZ1qDdzPD7mkWYkwXzGsgNTgL41GzjdPsT Pgr2091H0JX08C/1GzjhX6U0LFl8XkUs+eSKdml0NdWHOVrt6LxHtPuKHXDEqtLnyeOg ksfw+LtzojWeyodSpOL5AEzjk35pqF9jD6xpIjMAtKZ06JT5+Df8oGptFmjHdLPAbEid mdK8YV6urinszTHugcRZya1+x9tZ3EAF2uBUhCjTZOamYKhDROrX97PLa0P8Ureb84UQ bWbw== X-Gm-Message-State: AGRZ1gK1JKAbUTA9j3A5aoAyTQZKek/xsKcuYij9EmSlc0XmsiQ3+WS1 tVmwgkSqPhvZ+0l/Bgfy5sWZDw== X-Google-Smtp-Source: AJdET5cTgvZ+VSjXdxwvfJtN9KrDi/k0S0yyYC2abKckwD9h4K2UIZVzUX9Gby1Nt1fnYtBIWWSKLA== X-Received: by 2002:a37:1909:: with SMTP id k9mr1287173qkh.61.1540514738709; Thu, 25 Oct 2018 17:45:38 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id y3-v6sm2371735qti.27.2018.10.25.17.45.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Oct 2018 17:45:38 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com, Victor Colombo Subject: [PATCH 5/6] staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and read_raw Date: Thu, 25 Oct 2018 21:45:11 -0300 Message-Id: <20181026004512.31012-6-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181026004512.31012-1-matheus.bernardino@usp.br> References: <20181026004512.31012-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Victor Colombo This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and implements the relative read behavior at ad2s90_read_raw. Signed-off-by: Victor Colombo --- drivers/staging/iio/resolver/ad2s90.c | 32 ++++++++++++++++++--------- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index b4a6a89c11b0..52b656875ed1 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -34,19 +34,31 @@ static int ad2s90_read_raw(struct iio_dev *indio_dev, int ret; struct ad2s90_state *st = iio_priv(indio_dev); - mutex_lock(&st->lock); + switch (m) { + case IIO_CHAN_INFO_SCALE: + /* 2 * Pi / (2^12 - 1) ~= 0.001534355 */ + *val = 0; + *val2 = 1534355; + return IIO_VAL_INT_PLUS_NANO; + case IIO_CHAN_INFO_RAW: + mutex_lock(&st->lock); + + ret = spi_read(st->sdev, st->rx, 2); + if (ret < 0) { + mutex_unlock(&st->lock); + return ret; + } + + *val = (((u16)(st->rx[0])) << 4) | ((st->rx[1] & 0xF0) >> 4); - ret = spi_read(st->sdev, st->rx, 2); - if (ret < 0) { mutex_unlock(&st->lock); - return ret; - } - *val = (((u16)(st->rx[0])) << 4) | ((st->rx[1] & 0xF0) >> 4); - - mutex_unlock(&st->lock); + return IIO_VAL_INT; + default: + break; + } - return IIO_VAL_INT; + return -EINVAL; } static const struct iio_info ad2s90_info = { @@ -57,7 +69,7 @@ static const struct iio_chan_spec ad2s90_chan = { .type = IIO_ANGL, .indexed = 1, .channel = 0, - .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE), }; static int ad2s90_probe(struct spi_device *spi) From patchwork Fri Oct 26 00:45:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10656843 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7799614E2 for ; Fri, 26 Oct 2018 00:45:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6A7A22C24D for ; Fri, 26 Oct 2018 00:45:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5C2842C6C3; Fri, 26 Oct 2018 00:45:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 025B02C24D for ; Fri, 26 Oct 2018 00:45:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727543AbeJZJUc (ORCPT ); Fri, 26 Oct 2018 05:20:32 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:40516 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727453AbeJZJUc (ORCPT ); Fri, 26 Oct 2018 05:20:32 -0400 Received: by mail-qt1-f196.google.com with SMTP id z9-v6so12185937qto.7 for ; Thu, 25 Oct 2018 17:45:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NU6uEhiDTDfMKDT6vIKylD1JcOmwJKYVJFXwnpeU4xs=; b=ZdVgjW8o5j0hFmycZse60LAYwk8ZLgVMTfFc/PlA8x3OYy9kyQRpq8HWJbsiY+9TzA H5/mEniByRs99eSMaHt7o8ISGkpv6ucZtejmliUQgB5uUc/g1n+OsbI9cFN7S2KySPVg Ff3J75XU6zXHQzSZdPj9qTCTsk4C8EzDUstNEsTMqYknQV3ES1bTACfcRQIaUCOnIwR0 u3jwsYXFQ4hFa2KKQzzQ3ex8ITB+pBOuh5Yhnmhfl3kTIqvmRy+huxwDF8+YiAVtukdW 0oQ4PdYwbkQrgZYTuEvE1PzCK1kkdwN8c8ClZZTFIVd5pY4zHmN+CjCRz7izB3EyDHbV azfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NU6uEhiDTDfMKDT6vIKylD1JcOmwJKYVJFXwnpeU4xs=; b=CEEopc9HWrxc1r0EdGjEXPZE/9lOjrvuTeHynTUyk+Me7cItR9zslLhG6esTbttGJH C2unMsPqgsGbXCU4tbFmBWvwwwyGCFZ2D3OlnN/xAw7DpMBWYfNjy5KssYqpj8J0KOsm DZbrjCyQqoFjK6OQtBnW5v2AXyULvBYby0Dp6jl/ZgT9yPqEufEHloP5EePU7OBzDwWx oeRas7z6X8diu0zx6b/lsKZBXnSzSJlyOl5KregLJzmd5D87uLCHe4/o69O3+efPp/KS koVqX6YcFXNBuyQgmNIqc6pEjf4pWo4D/SJyTm/g8jYaoM/ALxhrXSSsDj3dyRO3GfQR IB5A== X-Gm-Message-State: AGRZ1gJAPagLiBxYX19fZoxsDFQr5DiQvasQyqq+/oPn6hz8BUDmKCOA UQx70ugApJxqbiT8aCLAP8/aeQ== X-Google-Smtp-Source: AJdET5f6Mgqdy+oiFVJ9tbTYEHDf1YxO93I/lCYm3xwuA+nY9xSIuT5bMCFVn/FmVxK54U9rBhNwGA== X-Received: by 2002:a0c:9d01:: with SMTP id m1mr1412459qvf.192.1540514741602; Thu, 25 Oct 2018 17:45:41 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id y3-v6sm2371735qti.27.2018.10.25.17.45.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Oct 2018 17:45:41 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH 6/6] staging:iio:ad2s90: Check channel type at read_raw Date: Thu, 25 Oct 2018 21:45:12 -0300 Message-Id: <20181026004512.31012-7-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181026004512.31012-1-matheus.bernardino@usp.br> References: <20181026004512.31012-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds a channel type check at the beginning of the ad2s90_read_raw function. Since ad2s90 has only one channel, it just checks if the given channel is the expected one and if not, return -EINVAL. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index 52b656875ed1..24002042a5c5 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -34,6 +34,9 @@ static int ad2s90_read_raw(struct iio_dev *indio_dev, int ret; struct ad2s90_state *st = iio_priv(indio_dev); + if (chan->type != IIO_ANGL) + return -EINVAL; + switch (m) { case IIO_CHAN_INFO_SCALE: /* 2 * Pi / (2^12 - 1) ~= 0.001534355 */