From patchwork Mon Sep 28 13:12:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 11803805 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 489CD139A for ; Mon, 28 Sep 2020 13:13:28 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 287D52074A for ; Mon, 28 Sep 2020 13:13:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 287D52074A Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kMsxX-0004Do-Tq; Mon, 28 Sep 2020 13:12:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kMsxW-0004DB-Qg for xen-devel@lists.xenproject.org; Mon, 28 Sep 2020 13:12:50 +0000 X-Inumbo-ID: 33c67fd4-73db-49e3-9666-bab5991a82f1 Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 33c67fd4-73db-49e3-9666-bab5991a82f1; Mon, 28 Sep 2020 13:12:45 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1kMsxQ-0007vv-JG; Mon, 28 Sep 2020 14:12:44 +0100 From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 1/5] daemonlib: Provide a "noop" command Date: Mon, 28 Sep 2020 14:12:37 +0100 Message-Id: <20200928131241.30278-2-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200928131241.30278-1-iwj@xenproject.org> References: <20200928131241.30278-1-iwj@xenproject.org> MIME-Version: 1.0 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Ian Jackson We are going to want clients to speak before waiting for the server banner. A noop command is useful for that. Putting this here makes it apply to both ownerdaemon and queuedaemon. Signed-off-by: Ian Jackson --- tcl/daemonlib.tcl | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tcl/daemonlib.tcl b/tcl/daemonlib.tcl index 1e86d5f4..747deab1 100644 --- a/tcl/daemonlib.tcl +++ b/tcl/daemonlib.tcl @@ -124,6 +124,10 @@ proc puts-chan {chan m} { puts $chan $m } +proc cmd/noop {chan desc} { + puts-chan $chan "OK noop" +} + #---------- data ---------- proc puts-chan-data {chan m data} { From patchwork Mon Sep 28 13:12:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 11803807 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8D8E7139A for ; Mon, 28 Sep 2020 13:13:44 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CC4B2074A for ; Mon, 28 Sep 2020 13:13:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CC4B2074A Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kMsxd-0004Eh-5y; Mon, 28 Sep 2020 13:12:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kMsxb-0004DB-Qt for xen-devel@lists.xenproject.org; Mon, 28 Sep 2020 13:12:55 +0000 X-Inumbo-ID: 71dbab40-fd75-45a1-9145-7c6ffc6a0c87 Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 71dbab40-fd75-45a1-9145-7c6ffc6a0c87; Mon, 28 Sep 2020 13:12:46 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1kMsxQ-0007vv-QS; Mon, 28 Sep 2020 14:12:44 +0100 From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 2/5] TCP fix: Do not wait for queuedaemon to speak Date: Mon, 28 Sep 2020 14:12:38 +0100 Message-Id: <20200928131241.30278-3-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200928131241.30278-1-iwj@xenproject.org> References: <20200928131241.30278-1-iwj@xenproject.org> MIME-Version: 1.0 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Ian Jackson This depends on the preceding daemonlib patch and an ms-queuedaemon restart. Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm index 61a99bc3..80e70070 100644 --- a/Osstest/Executive.pm +++ b/Osstest/Executive.pm @@ -643,7 +643,16 @@ sub tcpconnect_queuedaemon () { my $qserv= tcpconnect($c{QueueDaemonHost}, $c{QueueDaemonPort}); $qserv->autoflush(1); + # TCP connections can get into a weird state where the client + # thinks the connection is open but the server has no record + # of it. To avoid this, have the client speak without waiting + # for the server. + # + # See A TCP "stuck" connection mystery" + # https://www.evanjones.ca/tcp-stuck-connection-mystery.html + print $qserv "noop\n"; $_= <$qserv>; defined && m/^OK ms-queuedaemon\s/ or die "$_?"; + $_= <$qserv>; defined && m/^OK noop\s/ or die "$_?"; return $qserv; } From patchwork Mon Sep 28 13:12:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 11803815 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7EC22139A for ; Mon, 28 Sep 2020 13:14:04 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C80A2074A for ; Mon, 28 Sep 2020 13:14:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C80A2074A Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kMsxi-0004Gi-E8; Mon, 28 Sep 2020 13:13:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kMsxg-0004DB-R5 for xen-devel@lists.xenproject.org; Mon, 28 Sep 2020 13:13:00 +0000 X-Inumbo-ID: 625c183d-a0c0-400b-aced-525f919c6902 Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 625c183d-a0c0-400b-aced-525f919c6902; Mon, 28 Sep 2020 13:12:46 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1kMsxR-0007vv-PR; Mon, 28 Sep 2020 14:12:46 +0100 From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 3/5] TCP fix: Do not wait for ownerdaemon to speak Date: Mon, 28 Sep 2020 14:12:39 +0100 Message-Id: <20200928131241.30278-4-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200928131241.30278-1-iwj@xenproject.org> References: <20200928131241.30278-1-iwj@xenproject.org> MIME-Version: 1.0 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Ian Jackson Signed-off-by: Ian Jackson --- tcl/JobDB-Executive.tcl | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/tcl/JobDB-Executive.tcl b/tcl/JobDB-Executive.tcl index 29c82821..4fe85696 100644 --- a/tcl/JobDB-Executive.tcl +++ b/tcl/JobDB-Executive.tcl @@ -414,7 +414,20 @@ proc become-task {comment} { set ownerqueue [socket $c(OwnerDaemonHost) $c(OwnerDaemonPort)] fconfigure $ownerqueue -buffering line -translation lf + + # TCP connections can get into a weird state where the client + # thinks the connection is open but the server has no record + # of it. To avoid this, have the client speak without waiting + # for the server. We tolerate "unknown command" errors so + # that it is not necessary to restart the ownerdaemon since + # that is very disruptive. + # + # See A TCP "stuck" connection mystery" + # https://www.evanjones.ca/tcp-stuck-connection-mystery.html + puts $ownerqueue noop must-gets $ownerqueue {^OK ms-ownerdaemon\M} + must-gets $ownerqueue {^OK noop|^ERROR unknown command} + puts $ownerqueue create-task must-gets $ownerqueue {^OK created-task (\d+) (\w+ [\[\]:.0-9a-f]+)$} \ taskid refinfo From patchwork Mon Sep 28 13:12:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 11803811 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 55D6F618 for ; Mon, 28 Sep 2020 13:13:53 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 344DB2074A for ; Mon, 28 Sep 2020 13:13:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 344DB2074A Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kMsxn-0004Ij-NM; Mon, 28 Sep 2020 13:13:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kMsxl-0004DB-RR for xen-devel@lists.xenproject.org; Mon, 28 Sep 2020 13:13:05 +0000 X-Inumbo-ID: 57a42dc6-7aaf-4056-a2c0-c92c55ed05c7 Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 57a42dc6-7aaf-4056-a2c0-c92c55ed05c7; Mon, 28 Sep 2020 13:12:47 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1kMsxS-0007vv-Ax; Mon, 28 Sep 2020 14:12:46 +0100 From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson , Jan Beulich Subject: [OSSTEST PATCH 4/5] TftiDiVersion: Update to latest installer for stretch Date: Mon, 28 Sep 2020 14:12:40 +0100 Message-Id: <20200928131241.30278-5-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200928131241.30278-1-iwj@xenproject.org> References: <20200928131241.30278-1-iwj@xenproject.org> MIME-Version: 1.0 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The stretch (Debian oldstable) kernel has been updated, causing our Xen 4.10 tests (which are still using stretch) to break. This update seems to fix it. Reported-by: Jan Beulich Signed-off-by: Ian Jackson --- production-config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/production-config b/production-config index 6055bd18..0c135bcb 100644 --- a/production-config +++ b/production-config @@ -90,7 +90,7 @@ TftpNetbootGroup osstest # Update with ./mg-debian-installer-update(-all) TftpDiVersion_wheezy 2016-06-08 TftpDiVersion_jessie 2018-06-26 -TftpDiVersion_stretch 2020-02-10 +TftpDiVersion_stretch 2020-09-24 TftpDiVersion_buster 2020-05-19 DebianSnapshotBackports_jessie http://snapshot.debian.org/archive/debian/20190206T211314Z/ From patchwork Mon Sep 28 13:12:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 11803823 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 842C9139A for ; Mon, 28 Sep 2020 13:14:22 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 636902074A for ; Mon, 28 Sep 2020 13:14:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 636902074A Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kMsxs-0004KS-0M; Mon, 28 Sep 2020 13:13:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kMsxq-0004DB-RY for xen-devel@lists.xenproject.org; Mon, 28 Sep 2020 13:13:10 +0000 X-Inumbo-ID: 5e450bfe-2943-43d5-ad51-83a23db6441a Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5e450bfe-2943-43d5-ad51-83a23db6441a; Mon, 28 Sep 2020 13:12:47 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1kMsxS-0007vv-Im; Mon, 28 Sep 2020 14:12:46 +0100 From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 5/5] Update TftpDiVersion_buster Date: Mon, 28 Sep 2020 14:12:41 +0100 Message-Id: <20200928131241.30278-6-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200928131241.30278-1-iwj@xenproject.org> References: <20200928131241.30278-1-iwj@xenproject.org> MIME-Version: 1.0 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Ian Jackson Signed-off-by: Ian Jackson --- production-config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/production-config b/production-config index 0c135bcb..6f85a4df 100644 --- a/production-config +++ b/production-config @@ -91,7 +91,7 @@ TftpNetbootGroup osstest TftpDiVersion_wheezy 2016-06-08 TftpDiVersion_jessie 2018-06-26 TftpDiVersion_stretch 2020-09-24 -TftpDiVersion_buster 2020-05-19 +TftpDiVersion_buster 2020-09-28 DebianSnapshotBackports_jessie http://snapshot.debian.org/archive/debian/20190206T211314Z/