From patchwork Mon Oct 19 15:57:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11844657 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F1F0914B2 for ; Mon, 19 Oct 2020 16:00:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A42F1222B9 for ; Mon, 19 Oct 2020 16:00:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0DsTqLN/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A42F1222B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BACF96B0062; Mon, 19 Oct 2020 12:00:12 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id B34706B0068; Mon, 19 Oct 2020 12:00:12 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D8046B006E; Mon, 19 Oct 2020 12:00:12 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) by kanga.kvack.org (Postfix) with ESMTP id 660866B0062 for ; Mon, 19 Oct 2020 12:00:12 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id EF4511EE6 for ; Mon, 19 Oct 2020 16:00:11 +0000 (UTC) X-FDA: 77389136622.30.offer44_3015c9627238 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 9174C180B44A0 for ; Mon, 19 Oct 2020 16:00:01 +0000 (UTC) X-Spam-Summary: 1,0,0,be5f03e0eea3d40e,d41d8cd98f00b204,krzk@kernel.org,,RULES_HIT:41:355:379:541:800:960:973:988:989:1260:1311:1314:1345:1437:1515:1534:1539:1711:1714:1730:1747:1777:1792:2393:2559:2562:2904:3138:3139:3140:3141:3142:3350:3865:3866:3867:3870:3871:3872:4321:5007:6261:6653:7903:9010:10004:11026:11473:11658:11914:12043:12048:12296:12297:12438:12517:12519:12555:12895:12986:13069:13161:13221:13229:13311:13357:13894:14096:14181:14384:14394:14721:21080:21451:21627:30054:30064,0,RBL:198.145.29.99:@kernel.org:.lbl8.mailshell.net-62.14.0.100 64.201.201.201;04yri4xog33hemrtbm7qrri3hs91dopay3966dc6ond5ngcyanuoz5fp6ww8cok.conxk5e1xs8jhjf8jhnr9rucqk8t4jcq8ftr7qinarh1njjuqgowxga411c3cdo.y-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:47,LUA_SUMMARY:none X-HE-Tag: offer44_3015c9627238 X-Filterd-Recvd-Size: 2342 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Mon, 19 Oct 2020 16:00:01 +0000 (UTC) Received: from localhost.localdomain (unknown [194.230.155.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0564922283; Mon, 19 Oct 2020 15:59:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603123200; bh=74gScxROzXVRQQgGZLhzzit9KPSYZrzEyqfBjkTFQ1s=; h=From:To:Cc:Subject:Date:From; b=0DsTqLN/LzHqTFqRVlwIRJMEizvXtH/vexrm0vxIAozaHcthOty9ebaedleZ9Rngr zQMidbyYzkDOkhBas77QzvBsVk2fZpwQuZVjIj5hkUbJO4e8Fp6zmMJZAO49T8ISyo b9PHWyZv7K7wuWADg2ehBThajuRqzdT0qJZvSnN8= From: Krzysztof Kozlowski To: Vinod Koul , Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kbuild-all@lists.01.org, Andrew Morton , Linux Memory Management List , Geert Uytterhoeven , Arnd Bergmann , Krzysztof Kozlowski , kernel test robot Subject: [PATCH 1/2] dmaengine: ppc4xx: make ppc440spe_adma_chan_list static Date: Mon, 19 Oct 2020 17:57:55 +0200 Message-Id: <20201019155756.21445-1-krzk@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The ppc440spe_adma_chan_list file-scope variable is not used outside of the unit so it can be made static. Reported-by: kernel test robot Signed-off-by: Krzysztof Kozlowski --- drivers/dma/ppc4xx/adma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/ppc4xx/adma.c b/drivers/dma/ppc4xx/adma.c index 71cdaaa8134c..fea598550582 100644 --- a/drivers/dma/ppc4xx/adma.c +++ b/drivers/dma/ppc4xx/adma.c @@ -69,7 +69,7 @@ struct ppc_dma_chan_ref { }; /* The list of channels exported by ppc440spe ADMA */ -struct list_head +static struct list_head ppc440spe_adma_chan_list = LIST_HEAD_INIT(ppc440spe_adma_chan_list); /* This flag is set when want to refetch the xor chain in the interrupt From patchwork Mon Oct 19 15:57:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11844655 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D4E4214B7 for ; Mon, 19 Oct 2020 16:00:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7E8FE222B9 for ; Mon, 19 Oct 2020 16:00:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Nm1l8fbp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E8FE222B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6CAD06B005C; Mon, 19 Oct 2020 12:00:07 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 652A76B0062; Mon, 19 Oct 2020 12:00:07 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CC996B0068; Mon, 19 Oct 2020 12:00:07 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id 187086B005C for ; Mon, 19 Oct 2020 12:00:07 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3B34C362B for ; Mon, 19 Oct 2020 16:00:06 +0000 (UTC) X-FDA: 77389136412.19.fall74_3c0512e27238 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id B30D21AD1B7 for ; Mon, 19 Oct 2020 16:00:05 +0000 (UTC) X-Spam-Summary: 1,0,0,4b1fad25a9e72abb,d41d8cd98f00b204,krzk@kernel.org,,RULES_HIT:41:152:355:379:541:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:3138:3139:3140:3141:3142:3351:3865:3870:3871:4321:5007:6261:6653:10004:10400:11026:11473:11658:11914:12043:12048:12296:12297:12438:12517:12519:12555:12895:12986:13069:13161:13229:13311:13357:13894:14096:14097:14181:14394:14659:14721:21080:21451:21627:30054:30080,0,RBL:198.145.29.99:@kernel.org:.lbl8.mailshell.net-62.2.0.100 64.100.201.201;04yg3dfgcppnuxiorhngdofq5a9ohypkasszqa4xzwrhiwwxkxo7q35n46ckpdr.grd5x991646k1yopyx4cbiioaai8f847beha4btqmwxfb3kfa6o9ggiiswtaitc.r-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:26,LUA_SUMMARY:none X-HE-Tag: fall74_3c0512e27238 X-Filterd-Recvd-Size: 2790 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Mon, 19 Oct 2020 16:00:04 +0000 (UTC) Received: from localhost.localdomain (unknown [194.230.155.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F6BD222C2; Mon, 19 Oct 2020 16:00:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603123203; bh=YbT4xVqbiqIk3+wEZ89dSG3aONU5hUzF61bG7fyN8VU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Nm1l8fbpvyqmiSmCl9ZvOV5SwxGHflWu7G5+/5W72WOm9qmKGhaZUxK7e4ev/KHe0 JleqRGEmmqbNcrxu5CzksWlfhlx5200TJ6qwvMhYgaL3e7t6hSfkWIN3OgNUd72H8T lY45gPgfPIj2+9gdcboVCqb0c/7XAz3kMGx4WNw0= From: Krzysztof Kozlowski To: Vinod Koul , Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kbuild-all@lists.01.org, Andrew Morton , Linux Memory Management List , Geert Uytterhoeven , Arnd Bergmann , Krzysztof Kozlowski Subject: [PATCH 2/2] dmaengine: ppc4xx: remove xor_hw_desc assignment without reading Date: Mon, 19 Oct 2020 17:57:56 +0200 Message-Id: <20201019155756.21445-2-krzk@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201019155756.21445-1-krzk@kernel.org> References: <20201019155756.21445-1-krzk@kernel.org> MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The xor_hw_desc local variable is assigned but never read: drivers/dma/ppc4xx/adma.c: In function ‘ppc440spe_desc_set_src_mult’: drivers/dma/ppc4xx/adma.c:562:17: warning: variable ‘xor_hw_desc’ set but not used [-Wunused-but-set-variable] Signed-off-by: Krzysztof Kozlowski --- drivers/dma/ppc4xx/adma.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/dma/ppc4xx/adma.c b/drivers/dma/ppc4xx/adma.c index fea598550582..df7704053d91 100644 --- a/drivers/dma/ppc4xx/adma.c +++ b/drivers/dma/ppc4xx/adma.c @@ -559,7 +559,6 @@ static void ppc440spe_desc_set_src_mult(struct ppc440spe_adma_desc_slot *desc, int sg_index, unsigned char mult_value) { struct dma_cdb *dma_hw_desc; - struct xor_cb *xor_hw_desc; u32 *psgu; switch (chan->device->id) { @@ -590,7 +589,6 @@ static void ppc440spe_desc_set_src_mult(struct ppc440spe_adma_desc_slot *desc, *psgu |= cpu_to_le32(mult_value << mult_index); break; case PPC440SPE_XOR_ID: - xor_hw_desc = desc->hw_desc; break; default: BUG();