From patchwork Mon Oct 26 07:30:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chunyan Zhang X-Patchwork-Id: 11855831 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 214B86A2 for ; Mon, 26 Oct 2020 07:30:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 012B622370 for ; Mon, 26 Oct 2020 07:30:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z4gcyMzX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1769588AbgJZHaa (ORCPT ); Mon, 26 Oct 2020 03:30:30 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:37158 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1769514AbgJZHaa (ORCPT ); Mon, 26 Oct 2020 03:30:30 -0400 Received: by mail-pl1-f194.google.com with SMTP id b12so1978360plr.4; Mon, 26 Oct 2020 00:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=drWl2FNvQSHLDmYecs0jaTk4+hw1areIUXV4tqKgkWw=; b=Z4gcyMzXjnLOt+sgpyzKq6mPQ29+xJudWEvAno4HNCBCBw+SPn0dXRljBH2cYsGNRO XW6jWYqNidjbX8kun3Mjse/54/dA8xjVaD8EYYOcWDlNpEyoh1TT622/B1vgBJwBd0ep kRGJNRUp/ILuOUBgKi9Z/wrrJj5IhVCe9fSpWA7+hGbGsgiImjBlgvoFFqsiM4di5cy4 p2rPI9/8DfM/iOh4ypiSvyWdfrDmG9vfsy9vLOgYI25kN5hrjHpFzpyPRXmwhboN3gRv NUotVcGa+3AysmAb19I+XPEZfisoVyGX4B0MPrW61WHR1A2pp9R6BinoiCyG8dOm+38M ZLuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=drWl2FNvQSHLDmYecs0jaTk4+hw1areIUXV4tqKgkWw=; b=S7JtzNHqdsnNOisskQoZ7vCR2PDdfgYhMVio8yg+4RJCDR1QV3MdTELirB06hIHfna B0O8YYbevgCM07lp4z4zGWgUKqY1RbS6H8uP/Qx0FZA9X7TZuvmpucTfFCO4V9tujYb4 8qhNzFcRzniT9kCpA7kiWBSEpaFgp9tMfE+7jnUTqx1S8RK6CL1q8A459wftDiFboXNs ZFkvU1KWq6Y0fwOTu10CbY2Gw2r5m3iFaf20+k6kxhbYW5wArYNCg3z56do6Z/TusDF3 QFCKDQDSvUOmp2SmYnbdx4DrManJwCUGTSRf7yOi598X5qtB2ntd3QHHrFyMwdLz9td6 0XYA== X-Gm-Message-State: AOAM533e137vkOa7obBDS59iGPxRPw2aPuSpwYXsky9hAiF3npgCqrWr PvLcYavjz6rIWS5v6/+398o= X-Google-Smtp-Source: ABdhPJycPXffI2we4zUbrjmJLMGHDuxMFsMwOa9CVNv1NAXp1WMnH2i7ZTSibTHqAs4vxz7Y/bBRwA== X-Received: by 2002:a17:902:654a:b029:d5:e98f:2436 with SMTP id d10-20020a170902654ab02900d5e98f2436mr8602087pln.21.1603697429382; Mon, 26 Oct 2020 00:30:29 -0700 (PDT) Received: from ubt.spreadtrum.com ([117.18.48.82]) by smtp.gmail.com with ESMTPSA id t10sm11384930pjr.37.2020.10.26.00.30.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 00:30:28 -0700 (PDT) From: Chunyan Zhang To: Ohad Ben-Cohen , Bjorn Andersson , Baolin Wang Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Orson Zhai , Chunyan Zhang , Chunyan Zhang Subject: [PATCH 1/2] hwspinlock: sprd: fixed warning of unused variable 'sprd_hwspinlock_of_match' Date: Mon, 26 Oct 2020 15:30:08 +0800 Message-Id: <20201026073009.24164-1-zhang.lyra@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org From: Chunyan Zhang The macro function of_match_ptr() is NULL if CONFIG_OF is not set, in this case Clang compiler would complain the of_device_id variable is unused. Reported-by: kernel test robot Fixes: d8c8bbbb1aba ("hwspinlock: sprd: Add hardware spinlock driver") Signed-off-by: Chunyan Zhang --- drivers/hwspinlock/sprd_hwspinlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwspinlock/sprd_hwspinlock.c b/drivers/hwspinlock/sprd_hwspinlock.c index 36dc8038bbb4..e7b55217293c 100644 --- a/drivers/hwspinlock/sprd_hwspinlock.c +++ b/drivers/hwspinlock/sprd_hwspinlock.c @@ -148,7 +148,7 @@ static struct platform_driver sprd_hwspinlock_driver = { .probe = sprd_hwspinlock_probe, .driver = { .name = "sprd_hwspinlock", - .of_match_table = of_match_ptr(sprd_hwspinlock_of_match), + .of_match_table = sprd_hwspinlock_of_match, }, }; From patchwork Mon Oct 26 07:30:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chunyan Zhang X-Patchwork-Id: 11855833 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CD9C46A2 for ; Mon, 26 Oct 2020 07:30:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B001322370 for ; Mon, 26 Oct 2020 07:30:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GSkhR7sR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1769619AbgJZHae (ORCPT ); Mon, 26 Oct 2020 03:30:34 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:37163 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1769590AbgJZHad (ORCPT ); Mon, 26 Oct 2020 03:30:33 -0400 Received: by mail-pl1-f195.google.com with SMTP id b12so1978415plr.4; Mon, 26 Oct 2020 00:30:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5vgATSqJDubiiUAoouS4SwnpLi0yKdwIQc1C/2b6Fss=; b=GSkhR7sR2r16FOr/A4qN9u2l/f44ZuVtGSZqUbWFeLDwqZfE0VoDBW3lGtyAJQjlrJ UZjNXh4WJt2NqufYpwrdrdecEZcOCLZ94jvYS9SC2jnNXt4wozh+32Lx6Nr7nlGlVbEq ukd9ep7Cvi2wb6xQvoCqe2+NoA9Hll4h8rye8vP1BNTiXKLrRKloLaIKK09id88gDt2l qEw5NZTCJ2pq5u228WJdYglTJqMgf3lEvRXRe7txdkdmZa9qac7Wn2VcXOragL1sSbSM GolPvTlfpl4WdvueXvBJR0p3A5AOQlP4PW30tGeRGKJgaEDcjj0MMhD0NLB6uWgwkQPu 3FAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5vgATSqJDubiiUAoouS4SwnpLi0yKdwIQc1C/2b6Fss=; b=nsrWuZcCGCasd4hBqKx58Nc28twG52kERVrenLX4aDxLkdlHmareAHkZcXhZu1VxgA ixmv0qY6PICHZxjwtcOn1hNsvwycrv9mxOYbQ7XFp1KpeypKWDpvwaflQ4RquRQMhPc2 bmmQGFQN98BJHu3ygG/djsVkVLQCKKwCX6O76AHq8kzRtSQRPnFL0OJO9ZfEUO3fWhh0 mF4ZGZtwiYDVozKwFLdyKuSUUdu/YrP/4hWUPx/KtJe/boK5f9ouxD9AYPtF3MXGe2JM SkavWO/OTeHJfcHYiFe6ROsSK4uDVS3ViayO7Dmnohd7OL1AgKHpiXXzAJLz8fPv3moj 3Scg== X-Gm-Message-State: AOAM533VAaR1HS+cj2SUDsZXMaacXRej+XIxXgqVSwpbz5pqCnRGYy7n EeFWqr/i5xEQyiraBSQglac= X-Google-Smtp-Source: ABdhPJwNvVMyI5v0koxjqQtJsefBJmycdMdETquI2b1T/Vzl8Q/K80KZ8axKvls0D/9g3hToeUgUDQ== X-Received: by 2002:a17:90b:942:: with SMTP id dw2mr18994461pjb.159.1603697433114; Mon, 26 Oct 2020 00:30:33 -0700 (PDT) Received: from ubt.spreadtrum.com ([117.18.48.82]) by smtp.gmail.com with ESMTPSA id t10sm11384930pjr.37.2020.10.26.00.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 00:30:32 -0700 (PDT) From: Chunyan Zhang To: Ohad Ben-Cohen , Bjorn Andersson , Baolin Wang Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Orson Zhai , Chunyan Zhang , Chunyan Zhang Subject: [PATCH 2/2] hwspinlock: sprd: use module_platform_driver() instead postcore initcall Date: Mon, 26 Oct 2020 15:30:09 +0800 Message-Id: <20201026073009.24164-2-zhang.lyra@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201026073009.24164-1-zhang.lyra@gmail.com> References: <20201026073009.24164-1-zhang.lyra@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org From: Chunyan Zhang The hardware spinlock devices are defined in the DT, there's no need for iinit calls order, remove boilerplate code by using module_platform_driver. Signed-off-by: Chunyan Zhang --- drivers/hwspinlock/sprd_hwspinlock.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/hwspinlock/sprd_hwspinlock.c b/drivers/hwspinlock/sprd_hwspinlock.c index e7b55217293c..179231cec5a6 100644 --- a/drivers/hwspinlock/sprd_hwspinlock.c +++ b/drivers/hwspinlock/sprd_hwspinlock.c @@ -151,18 +151,7 @@ static struct platform_driver sprd_hwspinlock_driver = { .of_match_table = sprd_hwspinlock_of_match, }, }; - -static int __init sprd_hwspinlock_init(void) -{ - return platform_driver_register(&sprd_hwspinlock_driver); -} -postcore_initcall(sprd_hwspinlock_init); - -static void __exit sprd_hwspinlock_exit(void) -{ - platform_driver_unregister(&sprd_hwspinlock_driver); -} -module_exit(sprd_hwspinlock_exit); +module_platform_driver(sprd_hwspinlock_driver); MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("Hardware spinlock driver for Spreadtrum");