From patchwork Wed Oct 28 00:22:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrew Lunn X-Patchwork-Id: 11864187 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F771C4363A for ; Thu, 29 Oct 2020 00:13:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D87C20780 for ; Thu, 29 Oct 2020 00:13:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390771AbgJ2ANb (ORCPT ); Wed, 28 Oct 2020 20:13:31 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50752 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390799AbgJ2ANa (ORCPT ); Wed, 28 Oct 2020 20:13:30 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kXZEs-003tgs-Pi; Wed, 28 Oct 2020 01:22:54 +0100 From: Andrew Lunn To: Jakub Kicinski Cc: netdev , Thomas Petazzoni , Ralf Baechle , Andrew Lunn Subject: [PATCH net-next 1/2] net: marvell: mvneta: Fix trigraph warning with W=1 Date: Wed, 28 Oct 2020 01:22:34 +0100 Message-Id: <20201028002235.928999-2-andrew@lunn.ch> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201028002235.928999-1-andrew@lunn.ch> References: <20201028002235.928999-1-andrew@lunn.ch> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org drivers/net/ethernet/marvell/mvneta.c: In function ‘mvneta_tx_tso’: drivers/net/ethernet/marvell/mvneta.c:2651:39: warning: trigraph ??! ignored, use -trigraphs to enable [-Wtrigraphs] 2651 | pr_info("*** Is this even possible???!?!?\n"); Simply the questioning exclamation to a plain question to avoid the warning. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/marvell/mvneta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 54b0bf574c05..55f4c49c1278 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -2648,7 +2648,7 @@ static int mvneta_tx_tso(struct sk_buff *skb, struct net_device *dev, return 0; if (skb_headlen(skb) < (skb_transport_offset(skb) + tcp_hdrlen(skb))) { - pr_info("*** Is this even possible???!?!?\n"); + pr_info("*** Is this even possible????\n"); return 0; } From patchwork Wed Oct 28 00:38:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrew Lunn X-Patchwork-Id: 11864191 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 807E9C388F7 for ; Thu, 29 Oct 2020 00:13:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3682620780 for ; Thu, 29 Oct 2020 00:13:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390782AbgJ2ANV (ORCPT ); Wed, 28 Oct 2020 20:13:21 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50734 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726118AbgJ2ANR (ORCPT ); Wed, 28 Oct 2020 20:13:17 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kXZUR-003toc-6a; Wed, 28 Oct 2020 01:38:59 +0100 From: Andrew Lunn To: Jakub Kicinski Cc: netdev , Gerrit Renker , Jon Maloy , Ying Xue , Andrew Lunn Subject: [PATCH net-next 2/2] net: tipc: Add __printf() markup to fix -Wsuggest-attribute=format Date: Wed, 28 Oct 2020 01:38:49 +0100 Message-Id: <20201028003849.929490-3-andrew@lunn.ch> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201028003849.929490-1-andrew@lunn.ch> References: <20201028003849.929490-1-andrew@lunn.ch> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org net/tipc/netlink_compat.c: In function ‘tipc_tlv_sprintf’: net/tipc/netlink_compat.c:137:2: warning: function ‘tipc_tlv_sprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] 137 | n = vscnprintf(buf, rem, fmt, args); Signed-off-by: Andrew Lunn --- net/tipc/netlink_compat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c index 1c7aa51cc2a3..17a90a2fe753 100644 --- a/net/tipc/netlink_compat.c +++ b/net/tipc/netlink_compat.c @@ -118,7 +118,8 @@ static void tipc_tlv_init(struct sk_buff *skb, u16 type) skb_put(skb, sizeof(struct tlv_desc)); } -static int tipc_tlv_sprintf(struct sk_buff *skb, const char *fmt, ...) +static __printf(2, 3) int tipc_tlv_sprintf(struct sk_buff *skb, + const char *fmt, ...) { int n; u16 len;