From patchwork Fri Oct 30 03:46:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chunyan Zhang X-Patchwork-Id: 11868409 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2D6C86A2 for ; Fri, 30 Oct 2020 03:47:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04ECE2076B for ; Fri, 30 Oct 2020 03:47:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TVy3cd1d" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726405AbgJ3Dr6 (ORCPT ); Thu, 29 Oct 2020 23:47:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725780AbgJ3Dr5 (ORCPT ); Thu, 29 Oct 2020 23:47:57 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B6A8C0613CF; Thu, 29 Oct 2020 20:47:57 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id g12so4064632pgm.8; Thu, 29 Oct 2020 20:47:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pu6SkmJfdZiNGR7CU5WnbayuT7AOpBefhlB5Tkwk5xc=; b=TVy3cd1dgGNGl6yfNDkfIAHZ0NL8beVKGrgTAWi7hkv+0jlO7A0jXHWF+jnAkRXzKF jcd0ISyPrGAXx/3PvlFXugFL8C6sdJJGU1x/nn8w+XWH+vrfxC6SHt7pP7fV5aSiqjeN 4ERlJ6UsYaKMIYCsIyIHoGMrhkuohO6RaVaK9NXnkkMidvtg2+vyOqtckHauUq7T91uf dxN1U2UUY/qdNP/oL/zODs9iqrMeSC1sxagsdD8ulsbjuzBxT9cT/kNo6QXEQrFAfJ0V bSOTqpxW+txj50sbw3B3/DTl/aQg3/AjuV49NnZOKWi8rehes2XS6w3mmVeKdEjxoNYn cUpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pu6SkmJfdZiNGR7CU5WnbayuT7AOpBefhlB5Tkwk5xc=; b=gXdUcWB2OtKLeNvi3lSgkc26TuraWwF/rTj8CXrvSCMJR9NWmYOgpRGb6KAPhz3Fnr WX5IPBSYE3NDInXnEB5VxDvwI2vq66BIIHOiLfxtVV/YoP0WOT/A5DCmTdhElL8kRx7c fUBTp7C3Jl57L+ir/sHPKUF3K9JnE/5Ulx57rClW5WRg+aZGL+RzyEfbGh04PcUNzGOq qcE/xR/wACeSV2NrZXDEoFcbs5hVw9ylCCIt2CW5fG1FXYjgSE/qhYdVJPYl37ZlzwcO jX0ImpEknwPml8pwbWu+SJYhFKwCRpSRm2mVJznDA6EkqR8ehpuaUmEA3JvcsOA3IY1S zxCA== X-Gm-Message-State: AOAM532TrhB5n2yxeWqtUaonevBZ+e4wij4CkG3YNa3LasWGuu/fcMhd vIDIT/eH81v583dzicF5YXvNEIQzGBU= X-Google-Smtp-Source: ABdhPJzZlgmgsMwButX+90yazphawW+h01P1aUNi5yLvFtzFTC8QeUD0pwRKTF+dxqEX+ceEwqvnfA== X-Received: by 2002:a63:6c6:: with SMTP id 189mr448872pgg.133.1604029677223; Thu, 29 Oct 2020 20:47:57 -0700 (PDT) Received: from ubt.spreadtrum.com ([117.18.48.82]) by smtp.gmail.com with ESMTPSA id f21sm4323093pfn.173.2020.10.29.20.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 20:47:56 -0700 (PDT) From: Chunyan Zhang To: Ohad Ben-Cohen , Bjorn Andersson , Baolin Wang Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Orson Zhai , Chunyan Zhang , Chunyan Zhang Subject: [PATCH v2 1/2] hwspinlock: sprd: fixed warning of unused variable 'sprd_hwspinlock_of_match' Date: Fri, 30 Oct 2020 11:46:53 +0800 Message-Id: <20201030034654.15775-2-zhang.lyra@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201030034654.15775-1-zhang.lyra@gmail.com> References: <20201030034654.15775-1-zhang.lyra@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org From: Chunyan Zhang The macro function of_match_ptr() is NULL if CONFIG_OF is not set, then Clang compiler would complain the of_device_id variable is unused. But using of_match_ptr() is space saving, for this case, the unused structure 'sprd_hwspinlock_of_match' would be not built into symbol table if CONFIG_OF is not set, probably depends on the compiler though. So adding __maybe_unsed seems a good approach to fix this warning. Reported-by: kernel test robot Fixes: d8c8bbbb1aba ("hwspinlock: sprd: Add hardware spinlock driver") Signed-off-by: Chunyan Zhang --- drivers/hwspinlock/sprd_hwspinlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwspinlock/sprd_hwspinlock.c b/drivers/hwspinlock/sprd_hwspinlock.c index 36dc8038bbb4..4c63e2546064 100644 --- a/drivers/hwspinlock/sprd_hwspinlock.c +++ b/drivers/hwspinlock/sprd_hwspinlock.c @@ -138,7 +138,7 @@ static int sprd_hwspinlock_probe(struct platform_device *pdev) SPRD_HWLOCKS_NUM); } -static const struct of_device_id sprd_hwspinlock_of_match[] = { +static const __maybe_unused struct of_device_id sprd_hwspinlock_of_match[] = { { .compatible = "sprd,hwspinlock-r3p0", }, { /* sentinel */ } }; From patchwork Fri Oct 30 03:46:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chunyan Zhang X-Patchwork-Id: 11868411 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D517F1130 for ; Fri, 30 Oct 2020 03:48:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC1532076B for ; Fri, 30 Oct 2020 03:48:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bcgbACuH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726447AbgJ3DsD (ORCPT ); Thu, 29 Oct 2020 23:48:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726441AbgJ3DsB (ORCPT ); Thu, 29 Oct 2020 23:48:01 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45184C0613D2; Thu, 29 Oct 2020 20:48:01 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id h6so4074338pgk.4; Thu, 29 Oct 2020 20:48:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SvAQt88Nti2V+feV/QlVUCDtPsB4Ur7fsvT8VcZnsT0=; b=bcgbACuH72su7pDDnfab31Hni99eoTCPaTi90I2VTVWR1RGEbQqptxdTftXx5FUDfs U9pKvoUgNK3grRCXO2pbnMUZcP1UG649PYFGLITLBYhBTE6B2oBpKOi+rhtpqhcLiPuo 4L19Lt+/8PU39o3+zD9a4FF743rqXOks6q1im1EmYqzfNpQz3LNWiiH7EFyRxqcETplc pIDmGakROAheZqXMAct2GbFbAhhQ4OoZ0BFaHPOtX0KNMDezl+7dz9/YIm+6viUCL2RR S+qdXgs9OQMiKQE6B+HvfTAUxeTZz4hc+hmcS9jwPYf9sMzFIOTgv1PE3bw71C93eg8/ sL1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SvAQt88Nti2V+feV/QlVUCDtPsB4Ur7fsvT8VcZnsT0=; b=AyLLSfN9KAuRA/LsJ76MqFqtLSDAfJoqzcqeKiyqIEMFfnQz1Zrlf07gSJc5lwZEIo zFgKVxn/l6PzXoX/UbHngYiS/bAuFlwVvHQST6jxQ3/bwGzgLx0HyxDJMNqygEKkijDQ G866PagDdIkbeRljgFMlx0sTOcAO3NZ0ix9NxZb2bYqgxohwJtmGaYletMNTtsdqzzPC s8dF9pDuUzo1cTYGT5VH2O8wUB9RV0v0LOAheSv8zNzKYvR0Lm0ukukN/fqePuVHJa9V xWlDZsbxoM92C84hikNorv2/zUAHf7S0QpkPjWPCoCY0CaX0wsoJ75Q7ttrGgorDPxwF MoQw== X-Gm-Message-State: AOAM533JaMrRaIpxla/k7hmLTweqvwzOfM3l1GA8JT1kttkUBrssIc4T Inbqoi0lgx1wQhU0gTOBDb9Ccsi0a7Y= X-Google-Smtp-Source: ABdhPJxLlYFVN2eGtAleVeq8Ajpzy6ZK6HxlYw6KE4x5CIbgNRTAmTYe9X2ufB9Pu6n7jP7MbsqMcw== X-Received: by 2002:a63:685:: with SMTP id 127mr460771pgg.158.1604029680941; Thu, 29 Oct 2020 20:48:00 -0700 (PDT) Received: from ubt.spreadtrum.com ([117.18.48.82]) by smtp.gmail.com with ESMTPSA id f21sm4323093pfn.173.2020.10.29.20.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 20:48:00 -0700 (PDT) From: Chunyan Zhang To: Ohad Ben-Cohen , Bjorn Andersson , Baolin Wang Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Orson Zhai , Chunyan Zhang , Chunyan Zhang Subject: [PATCH v2 2/2] hwspinlock: sprd: use module_platform_driver() instead postcore initcall Date: Fri, 30 Oct 2020 11:46:54 +0800 Message-Id: <20201030034654.15775-3-zhang.lyra@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201030034654.15775-1-zhang.lyra@gmail.com> References: <20201030034654.15775-1-zhang.lyra@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org From: Chunyan Zhang The hardware spinlock devices are defined in the DT, there's no need for init calls order, remove boilerplate code by using module_platform_driver. Signed-off-by: Chunyan Zhang --- drivers/hwspinlock/sprd_hwspinlock.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/hwspinlock/sprd_hwspinlock.c b/drivers/hwspinlock/sprd_hwspinlock.c index 4c63e2546064..19d1924044e5 100644 --- a/drivers/hwspinlock/sprd_hwspinlock.c +++ b/drivers/hwspinlock/sprd_hwspinlock.c @@ -151,18 +151,7 @@ static struct platform_driver sprd_hwspinlock_driver = { .of_match_table = of_match_ptr(sprd_hwspinlock_of_match), }, }; - -static int __init sprd_hwspinlock_init(void) -{ - return platform_driver_register(&sprd_hwspinlock_driver); -} -postcore_initcall(sprd_hwspinlock_init); - -static void __exit sprd_hwspinlock_exit(void) -{ - platform_driver_unregister(&sprd_hwspinlock_driver); -} -module_exit(sprd_hwspinlock_exit); +module_platform_driver(sprd_hwspinlock_driver); MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("Hardware spinlock driver for Spreadtrum");