From patchwork Wed Nov 4 09:05:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11879987 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FFF6C2D0A3 for ; Wed, 4 Nov 2020 09:07:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 807702242B for ; Wed, 4 Nov 2020 09:07:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GAbGqZjq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="i1auLP28" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 807702242B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Gtfx5Zg3aKs6k+6j4TfFbtBwuzX4mt1uTdD9qG2jzDo=; b=GAbGqZjqaT4eX6lnVjDDt67i9 sFcvF0kZ8XHCQZAFmVDUdQjGs9WgIGxxvUpM1q3HIkmTgbvtNc/0zFDol4tCu+Po2ojuzYxQROne3 NKIleGNr4jvSzmZisW2NTGcaVFv6xcHHJ1p5H4OmqPqEPIgkkt/pJmRGxTH3OnmSzYxnCwLKU8xtN BzYe3nW827lAWPAE/pBwjcjyiVDxmuzvCzmgz/tiith9phbaN2aBJ7oG+YUb8KIQThJyxiExE4VoB KG4ixCbQ+hwpMs53625O5hlF+QvDHq/g5gZzbz5L9j6OujhGJGPPRKrVsUX35vY4DPDMPcps5BHWc feJOaCN+g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaEkZ-0003k4-8E; Wed, 04 Nov 2020 09:06:39 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaEkL-0003fK-Hs for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 09:06:27 +0000 Received: by mail-wm1-x342.google.com with SMTP id 13so1627097wmf.0 for ; Wed, 04 Nov 2020 01:06:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=D0aje7znnyCcuhdDe70XckIGCUNEYtXa5x7TCAbIvC0=; b=i1auLP28ZX6Tx2Qq8HzP8vgzDZtmIvoGS7mqjS9UiN11JzcSzmGfV6/P/Hy5qEB/wa c2fRKcRdOkKBdDLbrfyBUD0gc5ONavKPWObTXJczemN9TbWFZkperGQ8Qr8CYsp2guLb UASYdrAsLMLA5CApazgLRBvBMQuznz8QKFq4SM4MyrPWtDi/h2Hilig6JgeWCvbPXnU2 NwcBv7DTKEeAH/yHjM/xD/VM4h3bfhwL90j8v4tvZkPJxOzuVgc3mUYnSA+Fbj5wz1Kc TbQcoS5UKMmbHEUGQD8qSZXrCXQd971A5NywK5poBzU5ER8FQMmAs3W/LQ2DPcnsSdky 1K8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=D0aje7znnyCcuhdDe70XckIGCUNEYtXa5x7TCAbIvC0=; b=bAZJp30EJ4UqhnrpITvJJB7gvI5iItxh/nev7nFBCX0l5WgqiOYVtFwNAsHT7bYjY2 KWFkwOGlFG1VS30E3Atb45/kx8dSX9yJGPqpyIzn9mYnLD2xuuFdQcDLjePgXwMySqOp nejYkay9VopQ17Q1uRUdF7Jih45VJf/3Nua/YqHpkZbTwfTLxXACJ8PvTGSUWKRvGt6I QTQhd4NqJx8H2lQZSKnJtrVBNTO5mTg6orK5CtrxR7xv8RdpwZMaUXxfIefo8Ly0y1t0 CMMlpzv2pkc53dErKURyhmWLPqcAEnTKkuLKC0xIlz2Set1h4crU1B7N+s3WoQX8QQOv eGUg== X-Gm-Message-State: AOAM533qMP8b2qddWSFGkXvYcjhicToRi5NXVYp2OypykfwOX53Uglb7 XyM2hMJ+G/Ki9rWmh3IIcyALcQ== X-Google-Smtp-Source: ABdhPJyo3VvPetZlt2jTbqUfxgx2y301ZcEN0ty1/357xm3X60va5Wyl1ikPvzMi4j80HQz1wfalJA== X-Received: by 2002:a1c:20c6:: with SMTP id g189mr3590255wmg.6.1604480784359; Wed, 04 Nov 2020 01:06:24 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id e25sm1607823wrc.76.2020.11.04.01.06.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 01:06:23 -0800 (PST) From: Lee Jones To: davem@davemloft.net, kuba@kernel.org Subject: [PATCH 01/12] net: usb: lan78xx: Remove lots of set but unused 'ret' variables Date: Wed, 4 Nov 2020 09:05:59 +0000 Message-Id: <20201104090610.1446616-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104090610.1446616-1-lee.jones@linaro.org> References: <20201104090610.1446616-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_040625_640591_9D2FB805 X-CRM114-Status: GOOD ( 20.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Woojung Huh , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Microchip Linux Driver Support , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/net/usb/lan78xx.c: In function ‘lan78xx_read_raw_otp’: drivers/net/usb/lan78xx.c:825:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_write_raw_otp’: drivers/net/usb/lan78xx.c:879:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_deferred_multicast_write’: drivers/net/usb/lan78xx.c:1041:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_update_flowcontrol’: drivers/net/usb/lan78xx.c:1127:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_init_mac_address’: drivers/net/usb/lan78xx.c:1666:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_link_status_change’: drivers/net/usb/lan78xx.c:1841:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_irq_bus_sync_unlock’: drivers/net/usb/lan78xx.c:1920:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan8835_fixup’: drivers/net/usb/lan78xx.c:1994:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_rx_max_frame_length’: drivers/net/usb/lan78xx.c:2192:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_change_mtu’: drivers/net/usb/lan78xx.c:2270:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_mac_addr’: drivers/net/usb/lan78xx.c:2299:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_features’: drivers/net/usb/lan78xx.c:2333:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_suspend’: drivers/net/usb/lan78xx.c:3807:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Woojung Huh Cc: Microchip Linux Driver Support Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org Cc: linux-usb@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Andrew Lunn --- drivers/net/usb/lan78xx.c | 212 ++++++++++++++++++-------------------- 1 file changed, 100 insertions(+), 112 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 65b315bc60abd..5517d0555ef22 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -822,20 +822,19 @@ static int lan78xx_read_raw_otp(struct lan78xx_net *dev, u32 offset, u32 length, u8 *data) { int i; - int ret; u32 buf; unsigned long timeout; - ret = lan78xx_read_reg(dev, OTP_PWR_DN, &buf); + lan78xx_read_reg(dev, OTP_PWR_DN, &buf); if (buf & OTP_PWR_DN_PWRDN_N_) { /* clear it and wait to be cleared */ - ret = lan78xx_write_reg(dev, OTP_PWR_DN, 0); + lan78xx_write_reg(dev, OTP_PWR_DN, 0); timeout = jiffies + HZ; do { usleep_range(1, 10); - ret = lan78xx_read_reg(dev, OTP_PWR_DN, &buf); + lan78xx_read_reg(dev, OTP_PWR_DN, &buf); if (time_after(jiffies, timeout)) { netdev_warn(dev->net, "timeout on OTP_PWR_DN"); @@ -845,18 +844,18 @@ static int lan78xx_read_raw_otp(struct lan78xx_net *dev, u32 offset, } for (i = 0; i < length; i++) { - ret = lan78xx_write_reg(dev, OTP_ADDR1, - ((offset + i) >> 8) & OTP_ADDR1_15_11); - ret = lan78xx_write_reg(dev, OTP_ADDR2, - ((offset + i) & OTP_ADDR2_10_3)); + lan78xx_write_reg(dev, OTP_ADDR1, + ((offset + i) >> 8) & OTP_ADDR1_15_11); + lan78xx_write_reg(dev, OTP_ADDR2, + ((offset + i) & OTP_ADDR2_10_3)); - ret = lan78xx_write_reg(dev, OTP_FUNC_CMD, OTP_FUNC_CMD_READ_); - ret = lan78xx_write_reg(dev, OTP_CMD_GO, OTP_CMD_GO_GO_); + lan78xx_write_reg(dev, OTP_FUNC_CMD, OTP_FUNC_CMD_READ_); + lan78xx_write_reg(dev, OTP_CMD_GO, OTP_CMD_GO_GO_); timeout = jiffies + HZ; do { udelay(1); - ret = lan78xx_read_reg(dev, OTP_STATUS, &buf); + lan78xx_read_reg(dev, OTP_STATUS, &buf); if (time_after(jiffies, timeout)) { netdev_warn(dev->net, "timeout on OTP_STATUS"); @@ -864,7 +863,7 @@ static int lan78xx_read_raw_otp(struct lan78xx_net *dev, u32 offset, } } while (buf & OTP_STATUS_BUSY_); - ret = lan78xx_read_reg(dev, OTP_RD_DATA, &buf); + lan78xx_read_reg(dev, OTP_RD_DATA, &buf); data[i] = (u8)(buf & 0xFF); } @@ -876,20 +875,19 @@ static int lan78xx_write_raw_otp(struct lan78xx_net *dev, u32 offset, u32 length, u8 *data) { int i; - int ret; u32 buf; unsigned long timeout; - ret = lan78xx_read_reg(dev, OTP_PWR_DN, &buf); + lan78xx_read_reg(dev, OTP_PWR_DN, &buf); if (buf & OTP_PWR_DN_PWRDN_N_) { /* clear it and wait to be cleared */ - ret = lan78xx_write_reg(dev, OTP_PWR_DN, 0); + lan78xx_write_reg(dev, OTP_PWR_DN, 0); timeout = jiffies + HZ; do { udelay(1); - ret = lan78xx_read_reg(dev, OTP_PWR_DN, &buf); + lan78xx_read_reg(dev, OTP_PWR_DN, &buf); if (time_after(jiffies, timeout)) { netdev_warn(dev->net, "timeout on OTP_PWR_DN completion"); @@ -899,21 +897,21 @@ static int lan78xx_write_raw_otp(struct lan78xx_net *dev, u32 offset, } /* set to BYTE program mode */ - ret = lan78xx_write_reg(dev, OTP_PRGM_MODE, OTP_PRGM_MODE_BYTE_); + lan78xx_write_reg(dev, OTP_PRGM_MODE, OTP_PRGM_MODE_BYTE_); for (i = 0; i < length; i++) { - ret = lan78xx_write_reg(dev, OTP_ADDR1, - ((offset + i) >> 8) & OTP_ADDR1_15_11); - ret = lan78xx_write_reg(dev, OTP_ADDR2, - ((offset + i) & OTP_ADDR2_10_3)); - ret = lan78xx_write_reg(dev, OTP_PRGM_DATA, data[i]); - ret = lan78xx_write_reg(dev, OTP_TST_CMD, OTP_TST_CMD_PRGVRFY_); - ret = lan78xx_write_reg(dev, OTP_CMD_GO, OTP_CMD_GO_GO_); + lan78xx_write_reg(dev, OTP_ADDR1, + ((offset + i) >> 8) & OTP_ADDR1_15_11); + lan78xx_write_reg(dev, OTP_ADDR2, + ((offset + i) & OTP_ADDR2_10_3)); + lan78xx_write_reg(dev, OTP_PRGM_DATA, data[i]); + lan78xx_write_reg(dev, OTP_TST_CMD, OTP_TST_CMD_PRGVRFY_); + lan78xx_write_reg(dev, OTP_CMD_GO, OTP_CMD_GO_GO_); timeout = jiffies + HZ; do { udelay(1); - ret = lan78xx_read_reg(dev, OTP_STATUS, &buf); + lan78xx_read_reg(dev, OTP_STATUS, &buf); if (time_after(jiffies, timeout)) { netdev_warn(dev->net, "Timeout on OTP_STATUS completion"); @@ -1038,7 +1036,6 @@ static void lan78xx_deferred_multicast_write(struct work_struct *param) container_of(param, struct lan78xx_priv, set_multicast); struct lan78xx_net *dev = pdata->dev; int i; - int ret; netif_dbg(dev, drv, dev->net, "deferred multicast write 0x%08x\n", pdata->rfe_ctl); @@ -1047,14 +1044,14 @@ static void lan78xx_deferred_multicast_write(struct work_struct *param) DP_SEL_VHF_HASH_LEN, pdata->mchash_table); for (i = 1; i < NUM_OF_MAF; i++) { - ret = lan78xx_write_reg(dev, MAF_HI(i), 0); - ret = lan78xx_write_reg(dev, MAF_LO(i), - pdata->pfilter_table[i][1]); - ret = lan78xx_write_reg(dev, MAF_HI(i), - pdata->pfilter_table[i][0]); + lan78xx_write_reg(dev, MAF_HI(i), 0); + lan78xx_write_reg(dev, MAF_LO(i), + pdata->pfilter_table[i][1]); + lan78xx_write_reg(dev, MAF_HI(i), + pdata->pfilter_table[i][0]); } - ret = lan78xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl); + lan78xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl); } static void lan78xx_set_multicast(struct net_device *netdev) @@ -1124,7 +1121,6 @@ static int lan78xx_update_flowcontrol(struct lan78xx_net *dev, u8 duplex, u16 lcladv, u16 rmtadv) { u32 flow = 0, fct_flow = 0; - int ret; u8 cap; if (dev->fc_autoneg) @@ -1147,10 +1143,10 @@ static int lan78xx_update_flowcontrol(struct lan78xx_net *dev, u8 duplex, (cap & FLOW_CTRL_RX ? "enabled" : "disabled"), (cap & FLOW_CTRL_TX ? "enabled" : "disabled")); - ret = lan78xx_write_reg(dev, FCT_FLOW, fct_flow); + lan78xx_write_reg(dev, FCT_FLOW, fct_flow); /* threshold value should be set before enabling flow */ - ret = lan78xx_write_reg(dev, FLOW, flow); + lan78xx_write_reg(dev, FLOW, flow); return 0; } @@ -1663,11 +1659,10 @@ static const struct ethtool_ops lan78xx_ethtool_ops = { static void lan78xx_init_mac_address(struct lan78xx_net *dev) { u32 addr_lo, addr_hi; - int ret; u8 addr[6]; - ret = lan78xx_read_reg(dev, RX_ADDRL, &addr_lo); - ret = lan78xx_read_reg(dev, RX_ADDRH, &addr_hi); + lan78xx_read_reg(dev, RX_ADDRL, &addr_lo); + lan78xx_read_reg(dev, RX_ADDRH, &addr_hi); addr[0] = addr_lo & 0xFF; addr[1] = (addr_lo >> 8) & 0xFF; @@ -1700,12 +1695,12 @@ static void lan78xx_init_mac_address(struct lan78xx_net *dev) (addr[2] << 16) | (addr[3] << 24); addr_hi = addr[4] | (addr[5] << 8); - ret = lan78xx_write_reg(dev, RX_ADDRL, addr_lo); - ret = lan78xx_write_reg(dev, RX_ADDRH, addr_hi); + lan78xx_write_reg(dev, RX_ADDRL, addr_lo); + lan78xx_write_reg(dev, RX_ADDRH, addr_hi); } - ret = lan78xx_write_reg(dev, MAF_LO(0), addr_lo); - ret = lan78xx_write_reg(dev, MAF_HI(0), addr_hi | MAF_HI_VALID_); + lan78xx_write_reg(dev, MAF_LO(0), addr_lo); + lan78xx_write_reg(dev, MAF_HI(0), addr_hi | MAF_HI_VALID_); ether_addr_copy(dev->net->dev_addr, addr); } @@ -1838,7 +1833,7 @@ static void lan78xx_remove_mdio(struct lan78xx_net *dev) static void lan78xx_link_status_change(struct net_device *net) { struct phy_device *phydev = net->phydev; - int ret, temp; + int temp; /* At forced 100 F/H mode, chip may fail to set mode correctly * when cable is switched between long(~50+m) and short one. @@ -1849,7 +1844,7 @@ static void lan78xx_link_status_change(struct net_device *net) /* disable phy interrupt */ temp = phy_read(phydev, LAN88XX_INT_MASK); temp &= ~LAN88XX_INT_MASK_MDINTPIN_EN_; - ret = phy_write(phydev, LAN88XX_INT_MASK, temp); + phy_write(phydev, LAN88XX_INT_MASK, temp); temp = phy_read(phydev, MII_BMCR); temp &= ~(BMCR_SPEED100 | BMCR_SPEED1000); @@ -1863,7 +1858,7 @@ static void lan78xx_link_status_change(struct net_device *net) /* enable phy interrupt back */ temp = phy_read(phydev, LAN88XX_INT_MASK); temp |= LAN88XX_INT_MASK_MDINTPIN_EN_; - ret = phy_write(phydev, LAN88XX_INT_MASK, temp); + phy_write(phydev, LAN88XX_INT_MASK, temp); } } @@ -1917,14 +1912,13 @@ static void lan78xx_irq_bus_sync_unlock(struct irq_data *irqd) struct lan78xx_net *dev = container_of(data, struct lan78xx_net, domain_data); u32 buf; - int ret; /* call register access here because irq_bus_lock & irq_bus_sync_unlock * are only two callbacks executed in non-atomic contex. */ - ret = lan78xx_read_reg(dev, INT_EP_CTL, &buf); + lan78xx_read_reg(dev, INT_EP_CTL, &buf); if (buf != data->irqenable) - ret = lan78xx_write_reg(dev, INT_EP_CTL, data->irqenable); + lan78xx_write_reg(dev, INT_EP_CTL, data->irqenable); mutex_unlock(&data->irq_lock); } @@ -1991,7 +1985,6 @@ static void lan78xx_remove_irq_domain(struct lan78xx_net *dev) static int lan8835_fixup(struct phy_device *phydev) { int buf; - int ret; struct lan78xx_net *dev = netdev_priv(phydev->attached_dev); /* LED2/PME_N/IRQ_N/RGMII_ID pin to IRQ_N mode */ @@ -2001,11 +1994,11 @@ static int lan8835_fixup(struct phy_device *phydev) phy_write_mmd(phydev, MDIO_MMD_PCS, 0x8010, buf); /* RGMII MAC TXC Delay Enable */ - ret = lan78xx_write_reg(dev, MAC_RGMII_ID, - MAC_RGMII_ID_TXC_DELAY_EN_); + lan78xx_write_reg(dev, MAC_RGMII_ID, + MAC_RGMII_ID_TXC_DELAY_EN_); /* RGMII TX DLL Tune Adjust */ - ret = lan78xx_write_reg(dev, RGMII_TX_BYP_DLL, 0x3D00); + lan78xx_write_reg(dev, RGMII_TX_BYP_DLL, 0x3D00); dev->interface = PHY_INTERFACE_MODE_RGMII_TXID; @@ -2189,28 +2182,27 @@ static int lan78xx_phy_init(struct lan78xx_net *dev) static int lan78xx_set_rx_max_frame_length(struct lan78xx_net *dev, int size) { - int ret = 0; u32 buf; bool rxenabled; - ret = lan78xx_read_reg(dev, MAC_RX, &buf); + lan78xx_read_reg(dev, MAC_RX, &buf); rxenabled = ((buf & MAC_RX_RXEN_) != 0); if (rxenabled) { buf &= ~MAC_RX_RXEN_; - ret = lan78xx_write_reg(dev, MAC_RX, buf); + lan78xx_write_reg(dev, MAC_RX, buf); } /* add 4 to size for FCS */ buf &= ~MAC_RX_MAX_SIZE_MASK_; buf |= (((size + 4) << MAC_RX_MAX_SIZE_SHIFT_) & MAC_RX_MAX_SIZE_MASK_); - ret = lan78xx_write_reg(dev, MAC_RX, buf); + lan78xx_write_reg(dev, MAC_RX, buf); if (rxenabled) { buf |= MAC_RX_RXEN_; - ret = lan78xx_write_reg(dev, MAC_RX, buf); + lan78xx_write_reg(dev, MAC_RX, buf); } return 0; @@ -2267,13 +2259,12 @@ static int lan78xx_change_mtu(struct net_device *netdev, int new_mtu) int ll_mtu = new_mtu + netdev->hard_header_len; int old_hard_mtu = dev->hard_mtu; int old_rx_urb_size = dev->rx_urb_size; - int ret; /* no second zero-length packet read wanted after mtu-sized packets */ if ((ll_mtu % dev->maxpacket) == 0) return -EDOM; - ret = lan78xx_set_rx_max_frame_length(dev, new_mtu + VLAN_ETH_HLEN); + lan78xx_set_rx_max_frame_length(dev, new_mtu + VLAN_ETH_HLEN); netdev->mtu = new_mtu; @@ -2296,7 +2287,6 @@ static int lan78xx_set_mac_addr(struct net_device *netdev, void *p) struct lan78xx_net *dev = netdev_priv(netdev); struct sockaddr *addr = p; u32 addr_lo, addr_hi; - int ret; if (netif_running(netdev)) return -EBUSY; @@ -2313,12 +2303,12 @@ static int lan78xx_set_mac_addr(struct net_device *netdev, void *p) addr_hi = netdev->dev_addr[4] | netdev->dev_addr[5] << 8; - ret = lan78xx_write_reg(dev, RX_ADDRL, addr_lo); - ret = lan78xx_write_reg(dev, RX_ADDRH, addr_hi); + lan78xx_write_reg(dev, RX_ADDRL, addr_lo); + lan78xx_write_reg(dev, RX_ADDRH, addr_hi); /* Added to support MAC address changes */ - ret = lan78xx_write_reg(dev, MAF_LO(0), addr_lo); - ret = lan78xx_write_reg(dev, MAF_HI(0), addr_hi | MAF_HI_VALID_); + lan78xx_write_reg(dev, MAF_LO(0), addr_lo); + lan78xx_write_reg(dev, MAF_HI(0), addr_hi | MAF_HI_VALID_); return 0; } @@ -2330,7 +2320,6 @@ static int lan78xx_set_features(struct net_device *netdev, struct lan78xx_net *dev = netdev_priv(netdev); struct lan78xx_priv *pdata = (struct lan78xx_priv *)(dev->data[0]); unsigned long flags; - int ret; spin_lock_irqsave(&pdata->rfe_ctl_lock, flags); @@ -2354,7 +2343,7 @@ static int lan78xx_set_features(struct net_device *netdev, spin_unlock_irqrestore(&pdata->rfe_ctl_lock, flags); - ret = lan78xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl); + lan78xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl); return 0; } @@ -3804,7 +3793,6 @@ static u16 lan78xx_wakeframe_crc16(const u8 *buf, int len) static int lan78xx_set_suspend(struct lan78xx_net *dev, u32 wol) { u32 buf; - int ret; int mask_index; u16 crc; u32 temp_wucsr; @@ -3813,26 +3801,26 @@ static int lan78xx_set_suspend(struct lan78xx_net *dev, u32 wol) const u8 ipv6_multicast[3] = { 0x33, 0x33 }; const u8 arp_type[2] = { 0x08, 0x06 }; - ret = lan78xx_read_reg(dev, MAC_TX, &buf); + lan78xx_read_reg(dev, MAC_TX, &buf); buf &= ~MAC_TX_TXEN_; - ret = lan78xx_write_reg(dev, MAC_TX, buf); - ret = lan78xx_read_reg(dev, MAC_RX, &buf); + lan78xx_write_reg(dev, MAC_TX, buf); + lan78xx_read_reg(dev, MAC_RX, &buf); buf &= ~MAC_RX_RXEN_; - ret = lan78xx_write_reg(dev, MAC_RX, buf); + lan78xx_write_reg(dev, MAC_RX, buf); - ret = lan78xx_write_reg(dev, WUCSR, 0); - ret = lan78xx_write_reg(dev, WUCSR2, 0); - ret = lan78xx_write_reg(dev, WK_SRC, 0xFFF1FF1FUL); + lan78xx_write_reg(dev, WUCSR, 0); + lan78xx_write_reg(dev, WUCSR2, 0); + lan78xx_write_reg(dev, WK_SRC, 0xFFF1FF1FUL); temp_wucsr = 0; temp_pmt_ctl = 0; - ret = lan78xx_read_reg(dev, PMT_CTL, &temp_pmt_ctl); + lan78xx_read_reg(dev, PMT_CTL, &temp_pmt_ctl); temp_pmt_ctl &= ~PMT_CTL_RES_CLR_WKP_EN_; temp_pmt_ctl |= PMT_CTL_RES_CLR_WKP_STS_; for (mask_index = 0; mask_index < NUM_OF_WUF_CFG; mask_index++) - ret = lan78xx_write_reg(dev, WUF_CFG(mask_index), 0); + lan78xx_write_reg(dev, WUF_CFG(mask_index), 0); mask_index = 0; if (wol & WAKE_PHY) { @@ -3861,30 +3849,30 @@ static int lan78xx_set_suspend(struct lan78xx_net *dev, u32 wol) /* set WUF_CFG & WUF_MASK for IPv4 Multicast */ crc = lan78xx_wakeframe_crc16(ipv4_multicast, 3); - ret = lan78xx_write_reg(dev, WUF_CFG(mask_index), - WUF_CFGX_EN_ | - WUF_CFGX_TYPE_MCAST_ | - (0 << WUF_CFGX_OFFSET_SHIFT_) | - (crc & WUF_CFGX_CRC16_MASK_)); - - ret = lan78xx_write_reg(dev, WUF_MASK0(mask_index), 7); - ret = lan78xx_write_reg(dev, WUF_MASK1(mask_index), 0); - ret = lan78xx_write_reg(dev, WUF_MASK2(mask_index), 0); - ret = lan78xx_write_reg(dev, WUF_MASK3(mask_index), 0); + lan78xx_write_reg(dev, WUF_CFG(mask_index), + WUF_CFGX_EN_ | + WUF_CFGX_TYPE_MCAST_ | + (0 << WUF_CFGX_OFFSET_SHIFT_) | + (crc & WUF_CFGX_CRC16_MASK_)); + + lan78xx_write_reg(dev, WUF_MASK0(mask_index), 7); + lan78xx_write_reg(dev, WUF_MASK1(mask_index), 0); + lan78xx_write_reg(dev, WUF_MASK2(mask_index), 0); + lan78xx_write_reg(dev, WUF_MASK3(mask_index), 0); mask_index++; /* for IPv6 Multicast */ crc = lan78xx_wakeframe_crc16(ipv6_multicast, 2); - ret = lan78xx_write_reg(dev, WUF_CFG(mask_index), - WUF_CFGX_EN_ | - WUF_CFGX_TYPE_MCAST_ | - (0 << WUF_CFGX_OFFSET_SHIFT_) | - (crc & WUF_CFGX_CRC16_MASK_)); - - ret = lan78xx_write_reg(dev, WUF_MASK0(mask_index), 3); - ret = lan78xx_write_reg(dev, WUF_MASK1(mask_index), 0); - ret = lan78xx_write_reg(dev, WUF_MASK2(mask_index), 0); - ret = lan78xx_write_reg(dev, WUF_MASK3(mask_index), 0); + lan78xx_write_reg(dev, WUF_CFG(mask_index), + WUF_CFGX_EN_ | + WUF_CFGX_TYPE_MCAST_ | + (0 << WUF_CFGX_OFFSET_SHIFT_) | + (crc & WUF_CFGX_CRC16_MASK_)); + + lan78xx_write_reg(dev, WUF_MASK0(mask_index), 3); + lan78xx_write_reg(dev, WUF_MASK1(mask_index), 0); + lan78xx_write_reg(dev, WUF_MASK2(mask_index), 0); + lan78xx_write_reg(dev, WUF_MASK3(mask_index), 0); mask_index++; temp_pmt_ctl |= PMT_CTL_WOL_EN_; @@ -3905,16 +3893,16 @@ static int lan78xx_set_suspend(struct lan78xx_net *dev, u32 wol) * for packettype (offset 12,13) = ARP (0x0806) */ crc = lan78xx_wakeframe_crc16(arp_type, 2); - ret = lan78xx_write_reg(dev, WUF_CFG(mask_index), - WUF_CFGX_EN_ | - WUF_CFGX_TYPE_ALL_ | - (0 << WUF_CFGX_OFFSET_SHIFT_) | - (crc & WUF_CFGX_CRC16_MASK_)); - - ret = lan78xx_write_reg(dev, WUF_MASK0(mask_index), 0x3000); - ret = lan78xx_write_reg(dev, WUF_MASK1(mask_index), 0); - ret = lan78xx_write_reg(dev, WUF_MASK2(mask_index), 0); - ret = lan78xx_write_reg(dev, WUF_MASK3(mask_index), 0); + lan78xx_write_reg(dev, WUF_CFG(mask_index), + WUF_CFGX_EN_ | + WUF_CFGX_TYPE_ALL_ | + (0 << WUF_CFGX_OFFSET_SHIFT_) | + (crc & WUF_CFGX_CRC16_MASK_)); + + lan78xx_write_reg(dev, WUF_MASK0(mask_index), 0x3000); + lan78xx_write_reg(dev, WUF_MASK1(mask_index), 0); + lan78xx_write_reg(dev, WUF_MASK2(mask_index), 0); + lan78xx_write_reg(dev, WUF_MASK3(mask_index), 0); mask_index++; temp_pmt_ctl |= PMT_CTL_WOL_EN_; @@ -3922,7 +3910,7 @@ static int lan78xx_set_suspend(struct lan78xx_net *dev, u32 wol) temp_pmt_ctl |= PMT_CTL_SUS_MODE_0_; } - ret = lan78xx_write_reg(dev, WUCSR, temp_wucsr); + lan78xx_write_reg(dev, WUCSR, temp_wucsr); /* when multiple WOL bits are set */ if (hweight_long((unsigned long)wol) > 1) { @@ -3930,16 +3918,16 @@ static int lan78xx_set_suspend(struct lan78xx_net *dev, u32 wol) temp_pmt_ctl &= ~PMT_CTL_SUS_MODE_MASK_; temp_pmt_ctl |= PMT_CTL_SUS_MODE_0_; } - ret = lan78xx_write_reg(dev, PMT_CTL, temp_pmt_ctl); + lan78xx_write_reg(dev, PMT_CTL, temp_pmt_ctl); /* clear WUPS */ - ret = lan78xx_read_reg(dev, PMT_CTL, &buf); + lan78xx_read_reg(dev, PMT_CTL, &buf); buf |= PMT_CTL_WUPS_MASK_; - ret = lan78xx_write_reg(dev, PMT_CTL, buf); + lan78xx_write_reg(dev, PMT_CTL, buf); - ret = lan78xx_read_reg(dev, MAC_RX, &buf); + lan78xx_read_reg(dev, MAC_RX, &buf); buf |= MAC_RX_RXEN_; - ret = lan78xx_write_reg(dev, MAC_RX, buf); + lan78xx_write_reg(dev, MAC_RX, buf); return 0; } From patchwork Wed Nov 4 09:06:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11880009 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ECD1C4741F for ; Wed, 4 Nov 2020 09:08:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F27AB2242A for ; Wed, 4 Nov 2020 09:08:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WuLG7YvT"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="brnfN0ua" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F27AB2242A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qSpY0gQs7YkuD2CBYX/X5vbZcL1djT1farGQaJKx5cc=; b=WuLG7YvTkTLTTN87k5m8zZ8Ia 9KSEbOYcViBo5RbIpmXWFpkZxI4hHu7WqEf+TMYc7Bz1c116VMwIi+D1F2sW+YkCYkGrCpXlEMBEk NFJfQGfXGw38W99D6vvZYJqNXC1emNnGkbIOZ5/u95k5k6ZjQQ0Q11Sa6roNcUM8C6P9TlyVMvj+T Vr48UZhmYXfGynOdXr7eYguSEUe3DyGERkWiNsbFN/9nVtjy4GiBLn959LjRQQED4M+lGhbwY6G78 fcjauPTqtHNKbevzxAIQnKUJ7U8AOGUzoEXpd7MYGYWXoHMw88r5Z/5OORCBRO5wE8AIEPtg7i76P zU3SQVxMQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaEke-0003li-7a; Wed, 04 Nov 2020 09:06:44 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaEkM-0003fj-N0 for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 09:06:27 +0000 Received: by mail-wr1-x444.google.com with SMTP id p1so2026005wrf.12 for ; Wed, 04 Nov 2020 01:06:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c5eEvJlIJ9dRxH14TAwIWUTdkS+IjrVsnIh7Q0ggT08=; b=brnfN0ua+I8Gz0uH1YV2F5yGMa1nzKtE/fciwy9jk3b9rq5I0aNfgD4mZJzX8y7I1E v3JDs7pEobe4Yi8iYBQ40zxZ8nXthK8OcVOLr67uk0SAcc/ubdXmUKHvE0/AK1rMDu01 yrRiiolMV4YiWRm8HrWgQJ0JQAFJoqCM0yyfQZqUrnR9NiJ8SwrEv5+7kDefd5+Gi3cq gaPUm3pKb2M6ijdOnMD5xlQYyoNvOCtnC5vEOz1OroBw8vK3P6Lcw338vkw3+ONJXbDj vbiyjSwa39RI1uguEompiCmYj46eiYl+u75lYB12uxNu8llPEM5POY4oMBpriKxwoZcs 6iwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c5eEvJlIJ9dRxH14TAwIWUTdkS+IjrVsnIh7Q0ggT08=; b=VBwLYweThi+Tcs+lnB8eArx1guQxHYHX3WGXUhM0Xo2UjfwrFPdftXXZt82cMXPfZF JoSDmbr6fODF1iLoAYd0G8JuU/QAUqfF1k9VXFUSsNMUd6/J2ulZaVoVOhXfMNSb3Kjl FyIJppHHaAaLjPJuHfhdqQ0KCDrpUTh7yyFbtAFvLc3Ndv6W+XwCodnCFbechlW7DnfZ cLVT6FK9897H5fxRMgbopzzlGJSNpZx879o70QU0TrSIWYHw+BaUk24z26m20iVPjcP2 ulOLQOqw/DV6m2O9ssxBQ3tXcGmcLxxrSCAHuGbIryWyJQWwL4bpVtYdGnRWdhr0IAZ2 8PlQ== X-Gm-Message-State: AOAM533aHfRDGhhIWUsHW7PVxtZGBQJ3FCKMhpPZ41yF2OfR+DM+AkaM jlYX+PbrCGUqvC4SqNgXpyCWlWR5DryBHnO8 X-Google-Smtp-Source: ABdhPJym7Q/2k10PIfoqJtwM+8PymTLRCc0LKxW4WlS6/PkC+bMauBuh5tweYNKAWOXSj133iHyE3w== X-Received: by 2002:a05:6000:1252:: with SMTP id j18mr29760015wrx.18.1604480785876; Wed, 04 Nov 2020 01:06:25 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id e25sm1607823wrc.76.2020.11.04.01.06.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 01:06:24 -0800 (PST) From: Lee Jones To: davem@davemloft.net, kuba@kernel.org Subject: [PATCH 02/12] net: ethernet: smsc: smc911x: Mark 'status' as __maybe_unused Date: Wed, 4 Nov 2020 09:06:00 +0000 Message-Id: <20201104090610.1446616-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104090610.1446616-1-lee.jones@linaro.org> References: <20201104090610.1446616-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_040626_857906_8EC05B53 X-CRM114-Status: GOOD ( 16.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dustin McIntire , Lee Jones , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org 'status' is used to interact with a hardware register. It might not be safe to remove it entirely. Mark it as __maybe_unused instead. Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/smsc/smc911x.c: In function ‘smc911x_phy_configure’: drivers/net/ethernet/smsc/smc911x.c:882:6: warning: variable ‘status’ set but not used [-Wunused-but-set-variable] drivers/net/ethernet/smsc/smc911x.c: In function ‘smc911x_phy_interrupt’: drivers/net/ethernet/smsc/smc911x.c:976:6: warning: variable ‘status’ set but not used [-Wunused-but-set-variable] drivers/net/ethernet/smsc/smc911x.c: In function ‘smc911x_timeout’: drivers/net/ethernet/smsc/smc911x.c:1251:6: warning: variable ‘status’ set but not used [-Wunused-but-set-variable] Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Dustin McIntire Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/ethernet/smsc/smc911x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/smsc/smc911x.c b/drivers/net/ethernet/smsc/smc911x.c index 01069dfaf75c9..552953c376fe3 100644 --- a/drivers/net/ethernet/smsc/smc911x.c +++ b/drivers/net/ethernet/smsc/smc911x.c @@ -879,7 +879,7 @@ static void smc911x_phy_configure(struct work_struct *work) int phyaddr = lp->mii.phy_id; int my_phy_caps; /* My PHY capabilities */ int my_ad_caps; /* My Advertised capabilities */ - int status; + int __maybe_unused status; unsigned long flags; DBG(SMC_DEBUG_FUNC, dev, "--> %s()\n", __func__); @@ -973,7 +973,7 @@ static void smc911x_phy_interrupt(struct net_device *dev) { struct smc911x_local *lp = netdev_priv(dev); int phyaddr = lp->mii.phy_id; - int status; + int __maybe_unused status; DBG(SMC_DEBUG_FUNC, dev, "--> %s\n", __func__); @@ -1248,7 +1248,7 @@ static void smc911x_poll_controller(struct net_device *dev) static void smc911x_timeout(struct net_device *dev, unsigned int txqueue) { struct smc911x_local *lp = netdev_priv(dev); - int status, mask; + int __maybe_unused status, mask; unsigned long flags; DBG(SMC_DEBUG_FUNC, dev, "--> %s\n", __func__); From patchwork Wed Nov 4 09:06:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11879985 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5604C388F7 for ; Wed, 4 Nov 2020 09:07:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38557223FD for ; Wed, 4 Nov 2020 09:07:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nyJfFFka"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S41ZIgdX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38557223FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=od+Y1zpCvxf8m8FOu/iwbeRm2uQEudK3kZ2m6vgcsNU=; b=nyJfFFka0amj1jiTtsOTFkiNm XSXaKPwREmPA/2iYtFH4cg6fHQFQz6WyoheIeZUcN4y9ZukoMxHgzhe1EFKjf4oTIPTz2/4vnKlVv aqny3/F9KuQlYlHxmPFbglqaRd70IGHUhFjXzHF3Ng5Bv3tFzCmlEpCxsD9dFoLvcbftH1pn3FTt+ if3FsrsIoMPTXBIBqa0JkYxXGgBlodvy2bxMbhTiUo0IR/ToBucDb413Fp6ZAMy+sfqBDxDqlgvfg lI8+I4YIIa1QpKKBJNVIB/sr89JVUIQc2Lko4SoZkr2Lny/LDgfDjpjfSXm5FYgE+3LzD/KGKDhXp TclqV29VQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaEkj-0003mf-EC; Wed, 04 Nov 2020 09:06:53 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaEkO-0003gE-Nj for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 09:06:29 +0000 Received: by mail-wm1-x343.google.com with SMTP id c9so1597793wml.5 for ; Wed, 04 Nov 2020 01:06:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ai/IJbUl7BkHWFCRULoIxTKsMqh/iQX3oMXysG8BbAc=; b=S41ZIgdXvVqTIgwwHbRXU3qfzFvgTAbmi4OWfczFRVPCiGiRdj4qPlG5SOwJ5uywTz C7T7OcVUBRLLxIeNO1QBd6/dgafcDX/GrnfmzizRtYXClJsrxrkGYkWkzE5HV8vFkaYm Vm61EVcb9Sio3FhWr9lOwxMrnovggHCVkOkzb0eA792KgMHqH3xEnNBPRY8O+66QW3Yc pKOreTHSGLVhX8ZVb+05G5abH0ecdZVfsgebI7kNT8hHny5gz9YRmE/z8vMpM6ao4ZYf 160pps1JJ56uHvikDyXT7rqZwNprsktEAGhRk+gUGwr6bikQFEa3BQtdX6sM0bryOOoO uMFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ai/IJbUl7BkHWFCRULoIxTKsMqh/iQX3oMXysG8BbAc=; b=bnztqsyHc7sUunuKw6IY9DoCyA6Rv8NkxkfrjOuKdTyhFBLzk2+IUqFGFoC2eqPMQu 5UibK6jfCpVymvRXrXn8OkGHRKxJzUR/5z5MJzwxZ1PjYZXeynhRXNdLrtyYTTcGKvhu 2a+FEzMnaDAJXTElSBB/P2WLW4F88m15FrZzdfhsRyprxpBPTuXzD7s5o+FLBCxywKVZ wsROWCdo21XqwRfbhajvI+3TWjhfpW1FgPlxVshuUl+yfpIiwulPIJoKNqwgc7q2n7zE qQUC5vS4ezqC6EkfJ7nF9vy/4+fqHtbTjbE6b7PYHyVIGHb662x0QsPKms7KMMZmC0xF RymQ== X-Gm-Message-State: AOAM531o6njVC0P61w/bhftLhQ8hKkMP7SiZJ7+JjK0sHk1G+/JDev6H aCNBPcbNivSfUDvn3tslLmU8cRVamxy8XMEw X-Google-Smtp-Source: ABdhPJwm087ycZiPgwd2s+xPskQ6ypamydQcf3m85VIQR8L0POFSczG6jP7uSl1Gv+7c/M6zdHG47g== X-Received: by 2002:a1c:6643:: with SMTP id a64mr3528227wmc.142.1604480787291; Wed, 04 Nov 2020 01:06:27 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id e25sm1607823wrc.76.2020.11.04.01.06.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 01:06:26 -0800 (PST) From: Lee Jones To: davem@davemloft.net, kuba@kernel.org Subject: [PATCH 03/12] net: ethernet: xilinx: xilinx_emaclite: Document 'txqueue' even if it is unused Date: Wed, 4 Nov 2020 09:06:01 +0000 Message-Id: <20201104090610.1446616-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104090610.1446616-1-lee.jones@linaro.org> References: <20201104090610.1446616-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_040628_831808_8E6FF95E X-CRM114-Status: GOOD ( 14.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , netdev@vger.kernel.org, Martin Habets , linux-kernel@vger.kernel.org, Michal Simek , John Williams , Shannon Nelson , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/xilinx/xilinx_emaclite.c:525: warning: Function parameter or member 'txqueue' not described in 'xemaclite_tx_timeout' Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Michal Simek Cc: Shannon Nelson Cc: Martin Habets Cc: "Michael S. Tsirkin" Cc: John Williams Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 0c26f5bcc523a..2c98e4cc07a5b 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -518,6 +518,7 @@ static int xemaclite_set_mac_address(struct net_device *dev, void *address) /** * xemaclite_tx_timeout - Callback for Tx Timeout * @dev: Pointer to the network device + * @txqueue: Unused * * This function is called when Tx time out occurs for Emaclite device. */ From patchwork Wed Nov 4 09:06:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11880007 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27C16C2D0A3 for ; Wed, 4 Nov 2020 09:08:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F4272242A for ; Wed, 4 Nov 2020 09:08:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qL24yqyC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="O+gghJDv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F4272242A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zKN0aqPB31TywS23hZ9kashqHD8mta7FEfUNcK0ffoo=; b=qL24yqyCrb0Ik1DuVilIrdDgq 2ITmxBN3u5rFg+Ln01RcvVwv4b+uX/7on625cTM9HAqR2Vfi3hmEIb89CnhXiBrc0Pp4qtQGaYu7g 1TIjImE7o6Ro318leLp3+WAEbIjsP+KLAGG/tdQnRaf3IAFuveimKHN/C0bwD2UY9+ShIX9M4hOKU +Xyvuuz++9bYEdttB2ZKshb06cAbSlZfVdBFksUQudMfZEO5c0SUA8QqLgUmC+Xw5q1qG92kGMyQQ q6yFjWLHsQKzzuEGz5Er1ldsM2l9UjE6exBTCjq+yarF5OTvKtBGj7FzbxUx0vUzUuIkJAbzCYIak Wz5tdP3ig==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaEkr-0003oI-0Y; Wed, 04 Nov 2020 09:06:57 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaEkQ-0003gj-Ct for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 09:06:33 +0000 Received: by mail-wr1-x443.google.com with SMTP id y12so21180088wrp.6 for ; Wed, 04 Nov 2020 01:06:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PvDQ8jiSdggfocg7QevhSStHyCThX2E8vELTACyHnVM=; b=O+gghJDvfp86xHKWNgfCUbwJBZer6plfg8irRb7mhXGvdo7nvbxcHUd63h6bvqOdkS tSUboDCoCYlt9DCY7qiK941vY9cWWcrT5dhUFhaoj+IwczKKPvBRX+IcCuLvSThGRsjC D58ezTytuMvEmOQY2bTv2oJzSy7M8A1Ra31v/4WhDJ/gdw2Ed9Acb+z0jHdgaSO/RfzF aUbBPxkvtygM9zIr6Vg1dDhySOxbbryxrnmEFSg9EURVG1o51j2usPgmkNmwHgmn7/fp pBtT9CLc2nU/2WTyzWyLqGfkFnDvqMLpQf/WYFc17TlKpg2vLmamvONRa7oY8mjJW1dG wp2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PvDQ8jiSdggfocg7QevhSStHyCThX2E8vELTACyHnVM=; b=psiPieLKn0Bbf77SZjZ8JZH0CVbzt2TWw2Wq/+Q388lxRXOnTHvG9r49VnGSUYLVpM 7J3Ffs0H9egpjv1GRACuLjpF2eDq7MDcG1JiX3HoSjEuaxINCm2FXnYLSxfS0EZEiDXo uNfhbhHGqCXvjiKKG88mOQvPTR8hrrK93uCwO6lt+dkdCYrp8wqLFHAHp3rfmuiMtgLJ b+DBPK/OgmbqKQtdt+28qnqfsK9HoMAv+GV8JppxHX4uujds7+jjqF5TIJqdr+dVgIzX Vm89NOF+ke+an49GyGJZ22zwqrmr2rr5RKFMwf5DNJdCCQspTWTNn9Lgd1zUa1cHdylf 6OAQ== X-Gm-Message-State: AOAM5337FKBi4snDbqw1eE89tcpLdcnT6QNmpXxz3e/iKfWmS/m4jgTa OUpfPcAqfJVLW6fHxJwMTkAEFg== X-Google-Smtp-Source: ABdhPJxJr4EKzyziM/kfu7bfvSRJog/0BPh5wKW3PHtRCRM2FSGZw1LpbirvmDeO5VkFIi4ChKf8FQ== X-Received: by 2002:a5d:490a:: with SMTP id x10mr30228709wrq.289.1604480789629; Wed, 04 Nov 2020 01:06:29 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id e25sm1607823wrc.76.2020.11.04.01.06.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 01:06:29 -0800 (PST) From: Lee Jones To: davem@davemloft.net, kuba@kernel.org Subject: [PATCH 05/12] net: xen-netback: xenbus: Demote nonconformant kernel-doc headers Date: Wed, 4 Nov 2020 09:06:03 +0000 Message-Id: <20201104090610.1446616-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104090610.1446616-1-lee.jones@linaro.org> References: <20201104090610.1446616-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_040632_345042_3CD3AF15 X-CRM114-Status: GOOD ( 17.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , Jesper Dangaard Brouer , Daniel Borkmann , Paul Durrant , netdev@vger.kernel.org, Rusty Russell , John Fastabend , Alexei Starovoitov , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, bpf@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/net/xen-netback/xenbus.c:419: warning: Function parameter or member 'dev' not described in 'frontend_changed' drivers/net/xen-netback/xenbus.c:419: warning: Function parameter or member 'frontend_state' not described in 'frontend_changed' drivers/net/xen-netback/xenbus.c:1001: warning: Function parameter or member 'dev' not described in 'netback_probe' drivers/net/xen-netback/xenbus.c:1001: warning: Function parameter or member 'id' not described in 'netback_probe' Cc: Wei Liu Cc: Paul Durrant Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Jesper Dangaard Brouer Cc: John Fastabend Cc: Rusty Russell Cc: xen-devel@lists.xenproject.org Cc: netdev@vger.kernel.org Cc: bpf@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Wei Liu Reviewed-by: Andrew Lunn --- drivers/net/xen-netback/xenbus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index f1c1624cec8f5..de1b5471d929b 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -411,7 +411,7 @@ static void read_xenbus_frontend_xdp(struct backend_info *be, vif->xdp_headroom = headroom; } -/** +/* * Callback received when the frontend's state changes. */ static void frontend_changed(struct xenbus_device *dev, @@ -992,7 +992,7 @@ static int netback_remove(struct xenbus_device *dev) return 0; } -/** +/* * Entry point to this code when a new device is created. Allocate the basic * structures and switch to InitWait. */ From patchwork Wed Nov 4 09:06:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11880011 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60B2DC388F7 for ; Wed, 4 Nov 2020 09:09:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD35C2242B for ; Wed, 4 Nov 2020 09:09:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DAKD+kOK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N/4knhJ7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD35C2242B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rwqskpkH0AaBjKCiqcS9JExQIaB2k2pPKyeIR3/WZ64=; b=DAKD+kOKBUBgy46fj0PRKnpmS 1nR6Ysgc33SjTkmyrgwQyYPixHpPJhovFO8mmuDQWq0GSCE00rWvOd4jPB4CIRJhwkuaar3CihGhq GBSXgBIh6b+SYjr2Iqd3UB3nHanAeB1L5H6wQbXBi/h6Efy2xf1GRKrhUnAen5wfCXlA/grzloafg aJgZL7NfDgXmYq00qP7K8AfqZJ1XQOzfpKn7qNnKB/yRob2dZESzm85NCec5nSbmFNAFWwn2conUG rr7YF6nArY+KV74iJk4FrbM28u+ozdto8lxQWQpqS+9jwOwWwdXuQJxKxkNFS3cC/sDUSdJG6WzEg dUqDHzz4Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaEl2-0003s1-FJ; Wed, 04 Nov 2020 09:07:08 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaEkR-0003gl-Hx for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 09:06:34 +0000 Received: by mail-wr1-x444.google.com with SMTP id c17so1814974wrc.11 for ; Wed, 04 Nov 2020 01:06:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=szFDNNaKEVDZSNkDXGPen7gT5j56LfEHgacJ/wxEkwY=; b=N/4knhJ7uTG/9yLA1FSuCU1flqXLayCobZP7LJXfq0bxqg/f2LQPv0S3+gwUmPrlvH ZcTQ8cmH725ndJazq3KjmCYX/gRdGKIjWOqFDqJ6Ca3yHBeMCHLvqP7MbavdbqsWv3p7 tp/mtcK62uAtazyujW3FsYwtTv4ejBYtpMZufYjm5/EBuvnxhGiyARiEFh4oHYBpof1m FLMvr9ZE4WvZuj6VUoTmr+5MZIXNoqFQDTh/Kl6S82TH08rzQYQ/zWqOYCHsy8sFvrDU fZFsELF54BVdt4TghACs9PCg0x+aj2lcb0j+QMwz5ImUWToz4/E/k+BHprYQ7ZeD/4CF aBsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=szFDNNaKEVDZSNkDXGPen7gT5j56LfEHgacJ/wxEkwY=; b=E5xq70mSIf60gJp/K0FoIYqmef1Nme4lS4ftBPiNgvGruCFhK8ys4ZqsXF8HjJ9GKi FfuVP+3EjtoLLZkRp5+7s+NQmZuTTnkHoD4jxJnYvKfp/j/7mw+b+LnBM6CTajDK6BD8 rATzb1GxI2yX6IyJ9EotFEU37A8H8oWOX0sp1L1mX1T0/coT+Ti0DIBAW+HrrXNZlGMY 1Ym9wwfBn6gIWAZ63iGiWbTkotBrf1MSnNZkqIa/xmSYmkt+pY9AqqIUC0O7GgSHpG2B ptR0t9rRCsP4iHJqSOfr8UGP342OjypYJ++QIyvBQ9QUleEJzVLZ/3kHNR4z0M8vatOx gS8g== X-Gm-Message-State: AOAM532DniqBNNbQ2rmYn9ejZolYVsKxtyoVd2810BTzqqmU2Nlah3WV xI5QvwglbpmvETvoKmjSCCBnsQ== X-Google-Smtp-Source: ABdhPJzIJXs0rqnpGfYOPLHG8ZWucjsENoRrdaQl4vWak5XVOqN2jes5DesM6dPTbX7FugMpqk+Mjg== X-Received: by 2002:adf:80c8:: with SMTP id 66mr31727752wrl.415.1604480790781; Wed, 04 Nov 2020 01:06:30 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id e25sm1607823wrc.76.2020.11.04.01.06.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 01:06:30 -0800 (PST) From: Lee Jones To: davem@davemloft.net, kuba@kernel.org Subject: [PATCH 06/12] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header Date: Wed, 4 Nov 2020 09:06:04 +0000 Message-Id: <20201104090610.1446616-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104090610.1446616-1-lee.jones@linaro.org> References: <20201104090610.1446616-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_040632_480508_3A6833E8 X-CRM114-Status: GOOD ( 15.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ivan Khoronzhuk , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'ndev' not described in 'am65_cpsw_timer_set' drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'est_new' not described in 'am65_cpsw_timer_set' Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Ivan Khoronzhuk Cc: "Gustavo A. R. Silva" Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Andrew Lunn --- drivers/net/ethernet/ti/am65-cpsw-qos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/am65-cpsw-qos.c b/drivers/net/ethernet/ti/am65-cpsw-qos.c index 3bdd4dbcd2ff1..ebcc6386cc34a 100644 --- a/drivers/net/ethernet/ti/am65-cpsw-qos.c +++ b/drivers/net/ethernet/ti/am65-cpsw-qos.c @@ -356,7 +356,7 @@ static void am65_cpsw_est_set_sched_list(struct net_device *ndev, writel(~all_fetch_allow & AM65_CPSW_FETCH_ALLOW_MSK, ram_addr); } -/** +/* * Enable ESTf periodic output, set cycle start time and interval. */ static int am65_cpsw_timer_set(struct net_device *ndev, From patchwork Wed Nov 4 09:06:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11879989 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E420C2D0A3 for ; Wed, 4 Nov 2020 09:07:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C7D922404 for ; Wed, 4 Nov 2020 09:07:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Xjyq6Lmd"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n+ihKnyT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C7D922404 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QQV07u2VXtlZ0h/GPG0HQ8qMeBTdNJq0gq/jpw8ZcxI=; b=Xjyq6LmdA8tEBweHweIldyvrr cPFlONGjfOOXpOA/USfdqek5k9KJ9DkvVjSlcmz0MEjRnwmkE8AwALkawFfXgzS9u4dxoZVlYAjmb +QGlDCZQQrWb0s9Dra+3tzBpLDDmOCux9XKAomrYFaQhmfQwJzRvghc7dt9kJSOBogJ+gY4oHSHtk BOUFLUFccyzTbY3JERc+v/P0avb66ZIW0gCtR2k3HLqxhWDi5yjF2uesvC/QKrbM2QpE1PoQTsUAI yjFhVU2et9SR3pdpKNyqC9UlQ+m8KNDEe5FW842QuIxTASV1BUfbU864+/8SlkXBmX+e4aeCjqvxd 9Kwf2Vqww==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaEl5-0003t7-NE; Wed, 04 Nov 2020 09:07:11 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaEkT-0003hb-CJ for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 09:06:35 +0000 Received: by mail-wr1-x442.google.com with SMTP id g12so21153089wrp.10 for ; Wed, 04 Nov 2020 01:06:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=D8A2ZwumcFkzT7gBopGPWFQhxOdjyth3zeXHUUMb4LU=; b=n+ihKnyTjnEwQT2qqQcogdXtMTIe5atB10Jq6pn1twwR0/kYkC2Kr6+xyss8eCXcz9 2HbpeX+vhczhVLIu+hKhJn0TyfMwtIP8L8DdtH+PcdFgj/Kug/u+q3VC0O4YIf5PC78/ xs7LRni4ory5Un9NLgygd0y/y8RaoA8Mzkqc/VfDEjIHMyDuLH/Tq/h2//H7DYxavy3A 51IvYGt8mchAFiVNSubG2g0HJ1nnlc7kaqU/00TNNRpTd6u4B5LRIFGTRPvugtogSvg3 e93uRN+MLdHYsDvmoa7xlBIrgIbkI/MkDxrHb3rzBzyppvQMCXL3yhEGT/KU4SYrJv6E ua2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=D8A2ZwumcFkzT7gBopGPWFQhxOdjyth3zeXHUUMb4LU=; b=h/2E53JkvN2QBnZY01qS6U6J7O4L6mL6HOaWoZAi2iwDGFjB3uJsMHWO6epWGjnjEn zdUNCaWgdYM7/p0wBjfhESBrX/bdu19HGCX352bTjdFNjRqEhQdzijDBuWO56MRJ9QEl RqsPWdNMVx8ig4fsvyJvpdEpJv1iY8nIlep/hYzJZGGvJDsPdRw4h0qyzHi7Wuo+5xLh dmvPsxcSw2Y6g1T/MkJwvjk5jubT20aSnucLsIUZgvS4KNe5McuCvKQcnTL75Q3CMCDP ej3EvFSjGD7Fd+IH5tkMm9neXdFE/UcZSTQ1jcsfFpzQamo4GSXOG+wi1iBZAadVSCyk SA5g== X-Gm-Message-State: AOAM531aPkPGshHgw/Dgh7s37A2jd2udYohfSWTLeP6jiNioETSYd1Aa W4NzjRMpSs/S8BPYKpPWMoePRA== X-Google-Smtp-Source: ABdhPJxtrIz8nX0D31ibhE0UZs9oinr7sODGkhZPjlhMnN3sK39bw2U99heofu4Rp69Oab82cUkc+A== X-Received: by 2002:adf:f80a:: with SMTP id s10mr31220660wrp.275.1604480792277; Wed, 04 Nov 2020 01:06:32 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id e25sm1607823wrc.76.2020.11.04.01.06.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 01:06:31 -0800 (PST) From: Lee Jones To: davem@davemloft.net, kuba@kernel.org Subject: [PATCH 07/12] net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter Date: Wed, 4 Nov 2020 09:06:05 +0000 Message-Id: <20201104090610.1446616-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104090610.1446616-1-lee.jones@linaro.org> References: <20201104090610.1446616-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_040634_292664_A6CD4001 X-CRM114-Status: GOOD ( 14.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Grygorii Strashko , netdev@vger.kernel.org, Kurt Kanzenbach , linux-kernel@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/ti/am65-cpts.c:736: warning: Function parameter or member 'en' not described in 'am65_cpts_rx_enable' drivers/net/ethernet/ti/am65-cpts.c:736: warning: Excess function parameter 'skb' description in 'am65_cpts_rx_enable' Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Grygorii Strashko Cc: Kurt Kanzenbach Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/am65-cpts.c b/drivers/net/ethernet/ti/am65-cpts.c index 75056c14b161b..bb2b8e4919feb 100644 --- a/drivers/net/ethernet/ti/am65-cpts.c +++ b/drivers/net/ethernet/ti/am65-cpts.c @@ -727,7 +727,7 @@ static long am65_cpts_ts_work(struct ptp_clock_info *ptp) /** * am65_cpts_rx_enable - enable rx timestamping * @cpts: cpts handle - * @skb: packet + * @en: enable * * This functions enables rx packets timestamping. The CPTS can timestamp all * rx packets. From patchwork Wed Nov 4 09:06:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11880005 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C66EC2D0A3 for ; Wed, 4 Nov 2020 09:09:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95C0D2242A for ; Wed, 4 Nov 2020 09:09:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fTKrbnPw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Vy0ifnFN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95C0D2242A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=W28GO54DCwvEPGivHeKgoIExQr+EOzaSU4YW9H7An0k=; b=fTKrbnPwr8zMKJtvYsm/tedav Hl6McRNQVGBEVY+tJEM/Zs0w07yfrBnPWqwYopKHx1kHPkEzdltGUnyylK1e25cPkaZFH/xboDn4I DPCNR5a2nccGYrxJ1gEf/auDMKuOpkEPcQXgSJXhba+ToEZ0CUFTwSV/NT/teqZv/dk+9cVLxWR0B +tDYpicmRN31+P0C/Y1xMXPPoBE+H0MughRXlT/v8Z9OfRsGdUseBNtU7ab1mSpt6lO+3xdDcI3il AE2FeUlN5AgnTNzWMbWdf6Dy2SKkfU2mpEdmHbI13VG7zsVZVe3jXkk9Ze6lzATp/5FPmZ2dOZpnt 3U8+eQ4MA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaElD-0003uO-IG; Wed, 04 Nov 2020 09:07:19 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaEkU-0003hw-W5 for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 09:06:36 +0000 Received: by mail-wm1-x344.google.com with SMTP id 23so1415722wmg.1 for ; Wed, 04 Nov 2020 01:06:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kRmJDRZK6hYnZwsJWtSyII6GRFG28FGG7WVn2jtoat0=; b=Vy0ifnFNZsdam2EYQqrtqEkqnpo+nDE+vtZ1Exog/zDTxcDNqjIjGsjIU1pi4kN3El WJb+mUgrcdzGRp3ibB8ikQUE/nHlWxpqRKWFVzAojniHotRo1+HOdbKPDVdxQrzIx6sR o5bH/KMSqaIrUmQaZkvfPrv1gFxI//c+XLeUSm9xVA3kwk7Z26qKNIX1zX0RkPnJ08Uu 3N/AsWZ+Jl5bU+SZ4vt/SsxAgf4VmWQbEcGIUXSUX2VSwqItVn590AY7hkgF110FhA9z j+QBoryGrshn3GGWS2c27qqPt497aXTtIabvKKAeyhw/gsk+3P4aFPmg5/JE0C/2HE/p rbiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kRmJDRZK6hYnZwsJWtSyII6GRFG28FGG7WVn2jtoat0=; b=p7UFEjRjOrcg5KqVNMcoQU22F/45ENpe8QINDTTnhUXpOXvg2J+axe3rPCGRXqPbf1 RifXR71wqrAKoIT+t6M3lxukKcLxd7GKaVy3pc8N+HRQh0etdI8cqJfI9LOJ6m2+Heg0 WrY9ohDwKsIgrdv6VrpwB+IWGdgZ913qlrwawCdhmDj1TK+VJ4QGhrDQ4GXVQUTW25U/ pcf4CxITAeihuQFiaA1wU6SOSrCywN2cyCMQlJhV0eSENkTb8G7ZWN4K++Wg/Y+iKjts Y5sUeimDYQpwsgptlmTj2W6FVmr1kQ5gRqwDsjcrN8ZASjMR7KeCkLvgDMr1lgHW6A0x s5+Q== X-Gm-Message-State: AOAM532R04zR0w5ANz9BL1O8EPEcy7a5lZFbM3USEwWf4jl2aZrhPXQG 16kp6RZ7NShzFZTJwWVlFZIdCw== X-Google-Smtp-Source: ABdhPJwqi0yB/+B9/s0ULCABSavH/6P6SV0tchgnVRlqqMJnN0CKjV/Hb1Yj3pHPlBIYEvJ5zSVeQA== X-Received: by 2002:a1c:1dc1:: with SMTP id d184mr3360241wmd.169.1604480793874; Wed, 04 Nov 2020 01:06:33 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id e25sm1607823wrc.76.2020.11.04.01.06.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 01:06:33 -0800 (PST) From: Lee Jones To: davem@davemloft.net, kuba@kernel.org Subject: [PATCH 08/12] net: xen-netfront: Demote non-kernel-doc headers to standard comment blocks Date: Wed, 4 Nov 2020 09:06:06 +0000 Message-Id: <20201104090610.1446616-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104090610.1446616-1-lee.jones@linaro.org> References: <20201104090610.1446616-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_040635_289778_7094C344 X-CRM114-Status: GOOD ( 17.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Song Liu , Stefano Stabellini , Jesper Dangaard Brouer , Daniel Borkmann , netdev@vger.kernel.org, bpf@vger.kernel.org, John Fastabend , linux-kernel@vger.kernel.org, Alexei Starovoitov , Andrii Nakryiko , xen-devel@lists.xenproject.org, KP Singh , Yonghong Song , Boris Ostrovsky , Lee Jones , Martin KaFai Lau , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/net/xen-netfront.c: In function ‘store_rxbuf’: drivers/net/xen-netfront.c:2416:16: warning: variable ‘target’ set but not used [-Wunused-but-set-variable] drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'dev' not described in 'netfront_probe' drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'id' not described in 'netfront_probe' drivers/net/xen-netfront.c:1669: warning: Function parameter or member 'dev' not described in 'netfront_resume' drivers/net/xen-netfront.c:2313: warning: Function parameter or member 'dev' not described in 'netback_changed' drivers/net/xen-netfront.c:2313: warning: Function parameter or member 'backend_state' not described in 'netback_changed' Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Jesper Dangaard Brouer Cc: John Fastabend Cc: Martin KaFai Lau Cc: Song Liu Cc: Yonghong Song Cc: Andrii Nakryiko Cc: KP Singh Cc: xen-devel@lists.xenproject.org Cc: netdev@vger.kernel.org Cc: bpf@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Juergen Gross --- drivers/net/xen-netfront.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 920cac4385bf7..93740ef4cf1b4 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -1582,7 +1582,7 @@ static struct net_device *xennet_create_dev(struct xenbus_device *dev) return ERR_PTR(err); } -/** +/* * Entry point to this code when a new device is created. Allocate the basic * structures and the ring buffers for communication with the backend, and * inform the backend of the appropriate details for those. @@ -1659,7 +1659,7 @@ static void xennet_disconnect_backend(struct netfront_info *info) } } -/** +/* * We are reconnecting to the backend, due to a suspend/resume, or a backend * driver restart. We tear down our netif structure and recreate it, but * leave the device-layer structures intact so that this is transparent to the @@ -2305,7 +2305,7 @@ static int xennet_connect(struct net_device *dev) return 0; } -/** +/* * Callback received when the backend's state changes. */ static void netback_changed(struct xenbus_device *dev, From patchwork Wed Nov 4 09:06:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11880003 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D13AC4741F for ; Wed, 4 Nov 2020 09:09:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF6B92242C for ; Wed, 4 Nov 2020 09:09:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="a0bJNVED"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="q3O/SXd4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF6B92242C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Zr4WntSxNyXfrpl5OMIaIvE6bLcHErebPJvOkf9eCNA=; b=a0bJNVED7dGldJZJzjxb06fn3 c8L2mTmrMeTz/Klt8P6S98b8Xxpy9mL+VPspGdz/jgJNAroNw2FbbuTQ4vC3vPTDhv6z+82Co7w9V grH4fyVrvpZoMjD2aKMsUeA6gOHN1wukYpIPQZi8z79cOUUyyhmmC8xas1URh11Iipy6/ap4ck7N3 I5ihzmBJFfdKLsQJn2Q1JhR6C6DJZbdduLLQgpbR1GLWnBxfnz547QEUMsD2j7ELgDhodXOTCwFSR +lxBYDZJ+T/3W2mFgZ6ZcHGojt4bub88beynjQHzuilwK6PAZpT/JLVmu9Ht/8xv8xpKBJlb9UwOF kUCIUjtlw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaEmB-0004Ko-46; Wed, 04 Nov 2020 09:08:19 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaEkW-0003il-0J for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 09:06:53 +0000 Received: by mail-wm1-x344.google.com with SMTP id p22so1611314wmg.3 for ; Wed, 04 Nov 2020 01:06:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/B2umlHEGwiWmUzcbuvTIa6aaDkptaAOjJxXB95ER8o=; b=q3O/SXd4LV8Ycy1SNvZO/331iDTMCBCi8rZ58FfA5rgOfwOMV3xdfcQ3fXzVezQH0G +kWKkHrxzkgm88APVQPS3NRojiXIMSF6xaiJ/b1UvLhT2GvLse1x6a7/Zl0XGL2K1cfG S1FVBL26Ka6AoRQ//rNLtIaWg/HUa0NJLSAHQUJ18bmofOY7Q6RIlslTHkHYnGKPZh0S TCWisaLpOSszO/NlsTXsYORH9y+dPxCSPAPlAYpIoQVZe6HD8xvTGj4b8UGE78ZaDHFP cMpv0UoPO7nSdYIzAwSNmWBTV6mG0RtmxCCSH3/neHoVNHpEu8DwyiHz0j6+zhIWG36V /M+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/B2umlHEGwiWmUzcbuvTIa6aaDkptaAOjJxXB95ER8o=; b=L5NuR5Ah/Bh4/zB3hvj1NIJpx6RC/Oe9CijeOYlyIrT/5D9lKJ+0Vs4mLVREBzIz1E UtsTHkdVIXyTqa5zZASqA5A17rvUmt1PnJkXWR7HgLJDPKcSWkFR5cLdha7cRGGQHDpX q+XPXp6a+yDqSxm3qBtiC/d+LRZk8pKQitJI7pIKc3z2whl+PDMFNrjtkchXr5wOR3c/ EOQg2wPYu6GInRM3fnn2rLNelDBKSGu/V91gLVV/LSkD85Wbek4/8rkSJ1KVZ0qJdmg7 1cUM5AoF64zTL3QTiVEhY85d49jx2Xr02EKWbxXYe+CqboUhqIrpJQon3Vu5tr3znHh7 OGSg== X-Gm-Message-State: AOAM531wsolvvmVTMqmwb4lPM9L4BEVTYlbwO5Cdo5qqmiLcN+oGlSiZ 1JL4/NF6cPjI0Xq07YJ1BSx1uw== X-Google-Smtp-Source: ABdhPJzo+OegKdhy8F4t60EOE90G4mmOxUJrXbpS2bCT6Vg8Nm6O2AnmaKTkL6KQlAZoEbrT3oNfRg== X-Received: by 2002:a1c:df89:: with SMTP id w131mr3289237wmg.164.1604480795182; Wed, 04 Nov 2020 01:06:35 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id e25sm1607823wrc.76.2020.11.04.01.06.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 01:06:34 -0800 (PST) From: Lee Jones To: davem@davemloft.net, kuba@kernel.org Subject: [PATCH 09/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours Date: Wed, 4 Nov 2020 09:06:07 +0000 Message-Id: <20201104090610.1446616-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104090610.1446616-1-lee.jones@linaro.org> References: <20201104090610.1446616-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_040636_185971_12F2FB90 X-CRM114-Status: GOOD ( 15.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Falcon , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Santiago Leon , John Allen , netdev@vger.kernel.org, Lijun Pan , Benjamin Herrenschmidt , Dany Madden , Paul Mackerras , Sukadev Bhattiprolu , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): from drivers/net/ethernet/ibm/ibmvnic.c:35: inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'skb' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_len' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_data' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_field' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_data' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'len' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_len' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'scrq_arr' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'txbuff' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'num_entries' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'adapter' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'rwi' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'reset_state' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'adapter' not described in 'do_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'rwi' not described in 'do_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'reset_state' not described in 'do_reset' Cc: Dany Madden Cc: Lijun Pan Cc: Sukadev Bhattiprolu Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Santiago Leon Cc: Thomas Falcon Cc: John Allen Cc: netdev@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones Reviewed-by: Andrew Lunn Reviewed-by: Dany Madden --- drivers/net/ethernet/ibm/ibmvnic.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 1dc3cfdb38abc..b30e1f5784bad 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -1357,10 +1357,10 @@ static int ibmvnic_close(struct net_device *netdev) /** * build_hdr_data - creates L2/L3/L4 header data buffer - * @hdr_field - bitfield determining needed headers - * @skb - socket buffer - * @hdr_len - array of header lengths - * @tot_len - total length of data + * @hdr_field: bitfield determining needed headers + * @skb: socket buffer + * @hdr_len: array of header lengths + * @tot_len: total length of data * * Reads hdr_field to determine which headers are needed by firmware. * Builds a buffer containing these headers. Saves individual header @@ -1417,11 +1417,11 @@ static int build_hdr_data(u8 hdr_field, struct sk_buff *skb, /** * create_hdr_descs - create header and header extension descriptors - * @hdr_field - bitfield determining needed headers - * @data - buffer containing header data - * @len - length of data buffer - * @hdr_len - array of individual header lengths - * @scrq_arr - descriptor array + * @hdr_field: bitfield determining needed headers + * @data: buffer containing header data + * @len: length of data buffer + * @hdr_len: array of individual header lengths + * @scrq_arr: descriptor array * * Creates header and, if needed, header extension descriptors and * places them in a descriptor array, scrq_arr @@ -1469,10 +1469,10 @@ static int create_hdr_descs(u8 hdr_field, u8 *hdr_data, int len, int *hdr_len, /** * build_hdr_descs_arr - build a header descriptor array - * @skb - socket buffer - * @num_entries - number of descriptors to be sent - * @subcrq - first TX descriptor - * @hdr_field - bit field determining which headers will be sent + * @skb: socket buffer + * @num_entries: number of descriptors to be sent + * @subcrq: first TX descriptor + * @hdr_field: bit field determining which headers will be sent * * This function will build a TX descriptor array with applicable * L2/L3/L4 packet header descriptors to be sent by send_subcrq_indirect. @@ -1835,7 +1835,7 @@ static int ibmvnic_set_mac(struct net_device *netdev, void *p) return rc; } -/** +/* * do_reset returns zero if we are able to keep processing reset events, or * non-zero if we hit a fatal error and must halt. */ From patchwork Wed Nov 4 09:06:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11879991 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95C01C2D0A3 for ; Wed, 4 Nov 2020 09:08:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 127B32242B for ; Wed, 4 Nov 2020 09:08:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="apizxY+9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aFbXdi65" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 127B32242B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/ThTWMBydtEWj7X8oJF8aUKmd2owTbnxS8ExDl739t0=; b=apizxY+9ZYC3InR+l08HlO8UN zyzfWWYmWgMUZTAtFTC8JjNGU7gfosY4PspDym2YmVGeQCMPqBxA75MExqqda1gkConR2PoUlf1nw Ybhln2bxiMpbdiPa0A6u/t1E9WfdDXeL1GC/u06kyhVYQxSG6OqmwYVIDPaxxqOCOol4adtrbSkor xjzSY2MNjmVbA1boga9I5h0C5j3pN3I20cPDXTaIb0MyVazXqxhE2KKg971rCphyJCA12LS97gx9A o8WHf83HidbW8qlWiCx04oqlzlBIi2Kjqf/evP/uopWmuLkAMeq9ZqfvAxh7sd0SU1JLzNsGh0Lcu KcNZSJdMQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaElM-0003xs-G6; Wed, 04 Nov 2020 09:07:28 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaEkX-0003jF-C3 for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 09:06:38 +0000 Received: by mail-wm1-x341.google.com with SMTP id p19so1423514wmg.0 for ; Wed, 04 Nov 2020 01:06:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DTJOzm0gZUliIM1CJNEOWqPKlNYApXefDQfPPtC85HY=; b=aFbXdi65yd82soGVwLmvy7Zkj7puzP3tlWDEpJLWKc6c3ovAsCy4j2MSROqTyeZJ44 K3tFlhh2YKybamQbocQs3KrJ1LfviUXKeMTiECQGyLQ2qHlSjksyYKaAoueAPNnV1IJC dQ2OE3GNaBV80sNaITRjXJxUEN5P5qIctgwgz90nTKDpYdqCvOqQlB8brj+HVoUtTKPh 3FuLxpHRaeB7RsZwRtQV4LjCJNOGE5i7hPdqP5zg0aihpaepjdSj3RrJVrP8VpZce9o7 c3qfZFbIGc0TuGqp/ukXo/pVH1VXuLEBY4pO2x+y2NNDZPyDXAJ+DqazP8r2s/pWe6tk 5qXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DTJOzm0gZUliIM1CJNEOWqPKlNYApXefDQfPPtC85HY=; b=lIzgpZXwdj6QwBciiJf6GgEbl6Y4ZklaUjEgyzrZwkU3kswTM24TR7rf8Cn8lO6NE7 eNzzQ1SO1rV+MpE/IonVkR0l2N5MNwrDVQ7CxjC9ftiJaTT5Ek4TXofin5rXO63XaaaE 2ZF0hZ3MPGSV0YV7LXJ236jsHBxArq9XQqzeGI+y8H8pgwCDRiuQSu7/88OUc0RJfvtm 2/HNz8PE+emJ3ZRqyTmbyZ1kxzpG5yYdqAv7N6TKawHl8UL4Gntn82y9qY4uVrvZLUxo EZYHjLDCm35f31oecOnnnyNepynFVxnj8W/inHRnN3KNtbRfYTDgaR9MdYL1NgOmlZO+ aWDA== X-Gm-Message-State: AOAM532NQX9WRG1uD2FdDCIb4byzoHeTQDI5eRXalUJPeec37Hx/x75E z0iZDmw5c5v6NBnc7ZZ6OHLhBGYiEyYj4cB+ X-Google-Smtp-Source: ABdhPJxBaA6Bp7PvuVjNkKD5jYF3dYv7+JL6snqExRkG7etBcqIuE/SBL8AemuDBsSRPuujgMPj9kw== X-Received: by 2002:a1c:1b85:: with SMTP id b127mr3591594wmb.163.1604480796423; Wed, 04 Nov 2020 01:06:36 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id e25sm1607823wrc.76.2020.11.04.01.06.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 01:06:35 -0800 (PST) From: Lee Jones To: davem@davemloft.net, kuba@kernel.org Subject: [PATCH 10/12] net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours Date: Wed, 4 Nov 2020 09:06:08 +0000 Message-Id: <20201104090610.1446616-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104090610.1446616-1-lee.jones@linaro.org> References: <20201104090610.1446616-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_040637_833631_3957CF87 X-CRM114-Status: GOOD ( 17.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Geoff Levand , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Jens Osterkamp , netdev@vger.kernel.org, Paul Mackerras , Benjamin Herrenschmidt , Utz Bacher , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter or member 'irq' not described in 'gelic_card_interrupt' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter or member 'ptr' not described in 'gelic_card_interrupt' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1407: warning: Function parameter or member 'txqueue' not described in 'gelic_net_tx_timeout' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1439: warning: Function parameter or member 'napi' not described in 'gelic_ether_setup_netdev_ops' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1639: warning: Function parameter or member 'dev' not described in 'ps3_gelic_driver_probe' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1795: warning: Function parameter or member 'dev' not described in 'ps3_gelic_driver_remove' Cc: Geoff Levand Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Utz Bacher Cc: Jens Osterkamp Cc: netdev@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones Reviewed-by: Andrew Lunn --- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c b/drivers/net/ethernet/toshiba/ps3_gelic_net.c index d9a5722f561b5..f886e23f8ed0a 100644 --- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c +++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c @@ -1100,7 +1100,7 @@ static int gelic_net_poll(struct napi_struct *napi, int budget) return packets_done; } -/** +/* * gelic_card_interrupt - event handler for gelic_net */ static irqreturn_t gelic_card_interrupt(int irq, void *ptr) @@ -1400,6 +1400,7 @@ static void gelic_net_tx_timeout_task(struct work_struct *work) /** * gelic_net_tx_timeout - called when the tx timeout watchdog kicks in. * @netdev: interface device structure + * @txqueue: unused * * called, if tx hangs. Schedules a task that resets the interface */ @@ -1431,6 +1432,7 @@ static const struct net_device_ops gelic_netdevice_ops = { /** * gelic_ether_setup_netdev_ops - initialization of net_device operations * @netdev: net_device structure + * @napi: napi structure * * fills out function pointers in the net_device structure */ @@ -1632,7 +1634,7 @@ static void gelic_card_get_vlan_info(struct gelic_card *card) dev_info(ctodev(card), "internal vlan %s\n", card->vlan_required? "enabled" : "disabled"); } -/** +/* * ps3_gelic_driver_probe - add a device to the control of this driver */ static int ps3_gelic_driver_probe(struct ps3_system_bus_device *dev) @@ -1787,10 +1789,9 @@ static int ps3_gelic_driver_probe(struct ps3_system_bus_device *dev) return result; } -/** +/* * ps3_gelic_driver_remove - remove a device from the control of this driver */ - static int ps3_gelic_driver_remove(struct ps3_system_bus_device *dev) { struct gelic_card *card = ps3_system_bus_get_drvdata(dev); From patchwork Wed Nov 4 09:06:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11880023 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88930C388F7 for ; Wed, 4 Nov 2020 09:10:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CAE52242A for ; Wed, 4 Nov 2020 09:10:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FtspIO07"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YiTypI8h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CAE52242A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EUzb7Fid8DNT9TgCxDNufwSTeC1h+e/6Xry152RzBv0=; b=FtspIO07isT2m0VeO205yCkw4 setHVzDoIaz83kkPT3M9z7MUobuFHAaY6UUkxg8C6HKuo5pbJ1TxSSr5R85gzW1yFW0dXZZdcBJ44 AdAX8Sfnauzj9bOK99ANg7+P8xDT2gqxaWyr4Vwf55s9ZUZ1yc9vk0FfoJNsj0/BR+5djWulF82tS xn/TD586UHGBhwdsS2EX+ibEjpO5Yu4T0Eg7Kl5PllqSftw0wqM46EtrJ9+UJnxv54UQK3ngZqqYx 71Yh/kmbA84iuYbsYB5ZjZim8k1P/58pcUXG3oFw5P0xS46Jv1ewNlsKaylUVozFdNCcXDyRBjDPj BZYHgICwQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaEmI-0004QE-M5; Wed, 04 Nov 2020 09:08:26 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaEkY-0003k7-L6 for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 09:06:53 +0000 Received: by mail-wm1-x342.google.com with SMTP id p22so1611429wmg.3 for ; Wed, 04 Nov 2020 01:06:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=x/23In7GphBjuvLzsFPzeVbxW1AkJoC7VMLuq9ClVEg=; b=YiTypI8hZJMKh9sJmaRi+HggGPKXrCVi8Zu3qoOl9kAypEC44nS3VpgKl3xbzREdyZ wfzHIsbs5c8WghTROvmLFtBQldqLIdaPixDKKmGXQMzCzH3DsnplE0PdACjD41pSynpL JN9oaLaiescMESIiZ1sdG85mnee6jGVqVVZLF9oLC58tvmS7C06vyoFuCz0bKihAZ/fd xJeS3uq+I2VvPb0B+y62Rx3H/GtEBiO4eFy9wrt5dba5KTYI3UJB/LPeckZECimjm40/ +xmzeoOWt2rR2d2Srid3vuCeAcQ2aWMnk8j4FibtOnSxwAzpV0unN7ZPF9FcnjZmJdOt /YRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=x/23In7GphBjuvLzsFPzeVbxW1AkJoC7VMLuq9ClVEg=; b=nQ2XTGzvf/rWe6OOlUkR/KrTbyTMMIk2QTduEeknjyTyfm3KxtdOZIf75FqX1a69XN xePo/mRTfcDWrd9/qvT5fHvHLNymNf0u+DT0kgZz663lnoxFJyW3UZ7bOFoJjdDtr5y+ nI+1XEMjO1dbl7/XxreX/2wTJbjWJCCJwBgUMaiHVc6bgtKXa9pJxTFWFMjw6alGoY8W OvO/S7xLjn4+O5SvEXOWgFyFGFN1kR1e+RiQccZsltu/9sDbaJmtlHaJEZ8CEtTvIMlR qxuGllLab6f3rV1/GwYpxbOY+dYK/r4NCvYw1irAhM5bq8TvYELAFcXdPsMLrJu4G1Go GtnA== X-Gm-Message-State: AOAM533K4boQmk6WEDcwrFSBAT6sH9+pULX6zJNiu6c4We5YsuvIvS7A Dmcu1yKMr8lVA0vUiizxmuYwcg== X-Google-Smtp-Source: ABdhPJwlkdu+Vqx5xsQ3QhGy+QHBeYuiPfQ8/LYaV54nnmwGfoK2ltW77cXk6AUAu/xw/u3S5vS+7Q== X-Received: by 2002:a1c:1b8f:: with SMTP id b137mr3312243wmb.61.1604480797705; Wed, 04 Nov 2020 01:06:37 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id e25sm1607823wrc.76.2020.11.04.01.06.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 01:06:36 -0800 (PST) From: Lee Jones To: davem@davemloft.net, kuba@kernel.org Subject: [PATCH 11/12] net: ethernet: toshiba: spider_net: Document a whole bunch of function parameters Date: Wed, 4 Nov 2020 09:06:09 +0000 Message-Id: <20201104090610.1446616-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104090610.1446616-1-lee.jones@linaro.org> References: <20201104090610.1446616-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_040639_050548_8932BDF0 X-CRM114-Status: GOOD ( 20.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Osterkamp , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Utz Bacher , Lee Jones , linux-arm-kernel@lists.infradead.org, Ishizaki Kou Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/toshiba/spider_net.c:263: warning: Function parameter or member 'hwdescr' not described in 'spider_net_get_descr_status' drivers/net/ethernet/toshiba/spider_net.c:263: warning: Excess function parameter 'descr' description in 'spider_net_get_descr_status' drivers/net/ethernet/toshiba/spider_net.c:554: warning: Function parameter or member 'netdev' not described in 'spider_net_get_multicast_hash' drivers/net/ethernet/toshiba/spider_net.c:902: warning: Function parameter or member 't' not described in 'spider_net_cleanup_tx_ring' drivers/net/ethernet/toshiba/spider_net.c:902: warning: Excess function parameter 'card' description in 'spider_net_cleanup_tx_ring' drivers/net/ethernet/toshiba/spider_net.c:1074: warning: Function parameter or member 'card' not described in 'spider_net_resync_head_ptr' drivers/net/ethernet/toshiba/spider_net.c:1234: warning: Function parameter or member 'napi' not described in 'spider_net_poll' drivers/net/ethernet/toshiba/spider_net.c:1234: warning: Excess function parameter 'netdev' description in 'spider_net_poll' drivers/net/ethernet/toshiba/spider_net.c:1278: warning: Function parameter or member 'p' not described in 'spider_net_set_mac' drivers/net/ethernet/toshiba/spider_net.c:1278: warning: Excess function parameter 'ptr' description in 'spider_net_set_mac' drivers/net/ethernet/toshiba/spider_net.c:1350: warning: Function parameter or member 'error_reg1' not described in 'spider_net_handle_error_irq' drivers/net/ethernet/toshiba/spider_net.c:1350: warning: Function parameter or member 'error_reg2' not described in 'spider_net_handle_error_irq' drivers/net/ethernet/toshiba/spider_net.c:1968: warning: Function parameter or member 't' not described in 'spider_net_link_phy' drivers/net/ethernet/toshiba/spider_net.c:1968: warning: Excess function parameter 'data' description in 'spider_net_link_phy' drivers/net/ethernet/toshiba/spider_net.c:2149: warning: Function parameter or member 'work' not described in 'spider_net_tx_timeout_task' drivers/net/ethernet/toshiba/spider_net.c:2149: warning: Excess function parameter 'data' description in 'spider_net_tx_timeout_task' drivers/net/ethernet/toshiba/spider_net.c:2182: warning: Function parameter or member 'txqueue' not described in 'spider_net_tx_timeout' Cc: Ishizaki Kou Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Utz Bacher Cc: Jens Osterkamp Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Andrew Lunn --- drivers/net/ethernet/toshiba/spider_net.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/toshiba/spider_net.c b/drivers/net/ethernet/toshiba/spider_net.c index 5f5b33e6653b2..d5a75ef7e3ca9 100644 --- a/drivers/net/ethernet/toshiba/spider_net.c +++ b/drivers/net/ethernet/toshiba/spider_net.c @@ -254,7 +254,7 @@ spider_net_set_promisc(struct spider_net_card *card) /** * spider_net_get_descr_status -- returns the status of a descriptor - * @descr: descriptor to look at + * @hwdescr: descriptor to look at * * returns the status as in the dmac_cmd_status field of the descriptor */ @@ -542,6 +542,7 @@ spider_net_alloc_rx_skbs(struct spider_net_card *card) /** * spider_net_get_multicast_hash - generates hash for multicast filter table + * @netdev: interface device structure * @addr: multicast address * * returns the hash value. @@ -890,7 +891,7 @@ spider_net_xmit(struct sk_buff *skb, struct net_device *netdev) /** * spider_net_cleanup_tx_ring - cleans up the TX ring - * @card: card structure + * @t: timer context used to obtain the pointer to net card data structure * * spider_net_cleanup_tx_ring is called by either the tx_timer * or from the NAPI polling routine. @@ -1063,6 +1064,7 @@ static void show_rx_chain(struct spider_net_card *card) /** * spider_net_resync_head_ptr - Advance head ptr past empty descrs + * @card: card structure * * If the driver fails to keep up and empty the queue, then the * hardware wil run out of room to put incoming packets. This @@ -1220,7 +1222,7 @@ spider_net_decode_one_descr(struct spider_net_card *card) /** * spider_net_poll - NAPI poll function called by the stack to return packets - * @netdev: interface device structure + * @napi: napi device structure * @budget: number of packets we can pass to the stack at most * * returns 0 if no more packets available to the driver/stack. Returns 1, @@ -1268,7 +1270,7 @@ static int spider_net_poll(struct napi_struct *napi, int budget) /** * spider_net_set_mac - sets the MAC of an interface * @netdev: interface device structure - * @ptr: pointer to new MAC address + * @p: pointer to new MAC address * * Returns 0 on success, <0 on failure. Currently, we don't support this * and will always return EOPNOTSUPP. @@ -1340,6 +1342,8 @@ spider_net_link_reset(struct net_device *netdev) * spider_net_handle_error_irq - handles errors raised by an interrupt * @card: card structure * @status_reg: interrupt status register 0 (GHIINT0STS) + * @error_reg1: interrupt status register 1 (GHIINT1STS) + * @error_reg2: interrupt status register 2 (GHIINT2STS) * * spider_net_handle_error_irq treats or ignores all error conditions * found when an interrupt is presented @@ -1961,8 +1965,7 @@ spider_net_open(struct net_device *netdev) /** * spider_net_link_phy - * @data: used for pointer to card structure - * + * @t: timer context used to obtain the pointer to net card data structure */ static void spider_net_link_phy(struct timer_list *t) { @@ -2140,7 +2143,7 @@ spider_net_stop(struct net_device *netdev) /** * spider_net_tx_timeout_task - task scheduled by the watchdog timeout * function (to be called not under interrupt status) - * @data: data, is interface device structure + * @work: work context used to obtain the pointer to net card data structure * * called as task when tx hangs, resets interface (if interface is up) */ @@ -2174,6 +2177,7 @@ spider_net_tx_timeout_task(struct work_struct *work) /** * spider_net_tx_timeout - called when the tx timeout watchdog kicks in. * @netdev: interface device structure + * @txqueue: unused * * called, if tx hangs. Schedules a task that resets the interface */ From patchwork Wed Nov 4 09:06:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11880021 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C1E8C388F7 for ; Wed, 4 Nov 2020 09:10:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 106272242A for ; Wed, 4 Nov 2020 09:10:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kp3Y36H4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vwJYvf5t" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 106272242A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VE8ucNtkQLBoFTeZHbfTBTbB60/+8nqWdRf2xaF0qMY=; b=kp3Y36H4cqvXAITVOTUAelTqs k8WihRZhRMIf2wZCv8V7++6n7P8ygQ5AVupK3EbZFt89+mxHPe85VIaDd/BxWr4EJWAmLcwnLZkPk nOw0SOMP6BkY42StYedGCH4UJelwHqHuMomuNegnDa82HwyhEio8BkYX/pUu/U/DvQCd7/WMjeFI7 MEpxtr1Twzobh01rs9tnow70Ow7CCStyaHowSQyoQIN8TephZHyFYzPIEUosVf/RlGqAz/jSILpsS sE7y2vga/7nATJvQM9nqCZZBTrTZc8TMmtQ+SdpSsFiTx2e8X6/e19jpz2l3PdrvDH4d5HJciThiO B53q0NMpQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaElp-00049q-7A; Wed, 04 Nov 2020 09:07:57 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaEka-0003km-0r for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 09:06:41 +0000 Received: by mail-wr1-x443.google.com with SMTP id n18so21172125wrs.5 for ; Wed, 04 Nov 2020 01:06:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hCoWNpiCY5I/CQYGLXURefOzHbVXVRlIXhsHqYI/w30=; b=vwJYvf5tSu7houONcmY2RH0gAqaH3s1DrvDwNkF4scpQukej3gO26Urf1rHRcXlx7G B2whz/j1yA3d9bp292+5xEZLWicfY9GfbwHm4C6yccYuE9OZmNKeLxI5PBb//bQitl+E v6nlckH1Km93jQw2G02u45i90OEKa58QkQJKwuVrgtTcvR2aoDTlVT2T+iFhz7AEFzBt 4/GD1b8f73SRPihSSmP/Qu1gKvWTXZV54+o+y+7Dlakhv8SCIvaIOrhA7JHtfRDLugEK W+adwHbrSM4M/7sWpJ5Qu1vE6cyyvCWOjhiqzAcVRe3JrHoLI/3pZfXIMko92etRfCXg uymA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hCoWNpiCY5I/CQYGLXURefOzHbVXVRlIXhsHqYI/w30=; b=eM5BqfBgqJ4iVkthn9wzjHqxqKGxEMaC+4EHmP1hpd83YI7mIXXby/Q5k1aMhWrYZS EHrlt+xsZBxjy+cS2VcYnQViKSIYVM1r6h5xZvUwvjY8T6vw9eWI8mG8ookfxABUsDqO uhwbT2WjY/1xRWcnjb0sSEofsR1KDIb9ZQ786w5XSvyh0G17ju5px5idUKUh+8k1EW27 V9VLffwdIyYakC8hBUAm6KfUmMaOUQIREED8eAYH67ZLBa/7haQp0ct9M3OvRFlo6Eht wvONQOgiiWuM92/SnAjQUQCK4YxE3PZnFaRqlButVmk2KW0TeNJGr2H+S32ymwrCUKPl f9OQ== X-Gm-Message-State: AOAM5338VfQnAsV1Mz6kdZ+dHGFpmO2mcuidvTE/AvY8tVDlqHeoDWE9 LXZV6ilERqD9IdBvB4UMw88+/Q== X-Google-Smtp-Source: ABdhPJyouHiD9Dbeluv3U+pp3NeWi36AECmXpnyN2oBwE+mQUrCkcIzIM6ScwsKBWyolVfD7r82PcQ== X-Received: by 2002:adf:a195:: with SMTP id u21mr24545841wru.132.1604480799084; Wed, 04 Nov 2020 01:06:39 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id e25sm1607823wrc.76.2020.11.04.01.06.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 01:06:38 -0800 (PST) From: Lee Jones To: davem@davemloft.net, kuba@kernel.org Subject: [PATCH 12/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc issues Date: Wed, 4 Nov 2020 09:06:10 +0000 Message-Id: <20201104090610.1446616-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104090610.1446616-1-lee.jones@linaro.org> References: <20201104090610.1446616-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_040640_305569_27D191BB X-CRM114-Status: GOOD ( 14.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Falcon , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Santiago Leon , John Allen , netdev@vger.kernel.org, Paul Mackerras , Benjamin Herrenschmidt , Dany Madden , Lijun Pan , Sukadev Bhattiprolu , Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): from drivers/net/ethernet/ibm/ibmvnic.c:35: inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_data' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Excess function parameter 'tot_len' description in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_data' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Excess function parameter 'data' description in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'txbuff' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Excess function parameter 'skb' description in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Excess function parameter 'subcrq' description in 'build_hdr_descs_arr' Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Dany Madden Cc: Lijun Pan Cc: Sukadev Bhattiprolu Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Santiago Leon Cc: Thomas Falcon Cc: John Allen Cc: linuxppc-dev@lists.ozlabs.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Dany Madden --- drivers/net/ethernet/ibm/ibmvnic.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index b30e1f5784bad..08dab7a94b7ea 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -1360,7 +1360,7 @@ static int ibmvnic_close(struct net_device *netdev) * @hdr_field: bitfield determining needed headers * @skb: socket buffer * @hdr_len: array of header lengths - * @tot_len: total length of data + * @hdr_data: buffer to write the header to * * Reads hdr_field to determine which headers are needed by firmware. * Builds a buffer containing these headers. Saves individual header @@ -1418,7 +1418,7 @@ static int build_hdr_data(u8 hdr_field, struct sk_buff *skb, /** * create_hdr_descs - create header and header extension descriptors * @hdr_field: bitfield determining needed headers - * @data: buffer containing header data + * @hdr_data: buffer containing header data * @len: length of data buffer * @hdr_len: array of individual header lengths * @scrq_arr: descriptor array @@ -1469,9 +1469,8 @@ static int create_hdr_descs(u8 hdr_field, u8 *hdr_data, int len, int *hdr_len, /** * build_hdr_descs_arr - build a header descriptor array - * @skb: socket buffer + * @txbuff: tx buffer * @num_entries: number of descriptors to be sent - * @subcrq: first TX descriptor * @hdr_field: bit field determining which headers will be sent * * This function will build a TX descriptor array with applicable