From patchwork Wed Nov 4 16:24:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11881473 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 06183921 for ; Wed, 4 Nov 2020 16:26:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4D81206D9 for ; Wed, 4 Nov 2020 16:26:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qa0UA7Le" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731163AbgKDQ0d (ORCPT ); Wed, 4 Nov 2020 11:26:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730853AbgKDQYp (ORCPT ); Wed, 4 Nov 2020 11:24:45 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2556C061A4C for ; Wed, 4 Nov 2020 08:24:43 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id h22so2906251wmb.0 for ; Wed, 04 Nov 2020 08:24:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EFFGDIM6YxbyjqNmdxEzSxYZvjxZnEKm0jHptMdsaWs=; b=qa0UA7LeVIfHKJbOBgEUrNGqnwsyUh3ZXyRI95cNiijvXFriiQeSjlAdRqKgdhgTuZ VKidCqYL5gYT4LhaZYEGl75vPOUP3ykUejSwnh7Q7qOhFtnh5pupGR06AgPqK5N75rU9 BNa8rQl+KYQGjxl7EBdV0d8Ug9REGtfMe2UsZO0AVf0eU+39CurvcnluYbRgPC+PW+2A KoHhtLC+14wLmSmurMNK1I8H6xWDJwLnePRnH8PuVMG3UFYFXU1gr/qTzx1stZAQd2Mi Kti6TrrXz9j11RrG+B5NX57cICiAHrNjVl0TkF1/2u2MR/ttWpvnukOLR1KrqsDaO4vW eFRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EFFGDIM6YxbyjqNmdxEzSxYZvjxZnEKm0jHptMdsaWs=; b=WBomPLf9xLxqepSAK0Lr567gCuoveXWXbBBIgk388dINnruKBNu5AnGAOL+P3K4rKw 98/sPzZWjbWxc053yWcmkg13DsS7iwd96HqhIM4Wblb82EYtTuGZ6FO3bo/xIv3fSeOW ajOu8cnHhk1Kx/knltQd0kKuS0ZKqADwl9l1WRKpydMwV0G5dRO/ix1r4nVCzcfXMqCb 0BhdqM7OnRqJSMCvs26vkGXBvuzzzZ9mDSIXXRJs6/zzgmwobOBwk1endJfA5L31Rv4k jCfKqGhUEuVnW+W1l+BKcpuZXoijRrvfQ+z2ZyKd23iBzrE85DhHEhICmim2sfrvguUd 1Bng== X-Gm-Message-State: AOAM530cr+aYGCnyJChXG4uSwkg/OnOoGyQmWU+zF3+m4L+oCOFtMKf2 rdrRbG7mCoJtMMIm49nDirghCg== X-Google-Smtp-Source: ABdhPJxhvdIjV+YfPIEcOUvtay4LNDugBEPgNMSeioIVBMDoFKZL6foblf8yKGtLSCX5g+4BdGYFyw== X-Received: by 2002:a1c:84:: with SMTP id 126mr3535343wma.160.1604507082436; Wed, 04 Nov 2020 08:24:42 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id o129sm3008564wmb.25.2020.11.04.08.24.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:24:41 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Vincent Huang , Hans de Goede , Andrew Duggan , Christopher Heiny , linux-input@vger.kernel.org Subject: [PATCH 01/20] input: rmi4: rmi_bus: Fix misnaming of '__rmi_register_function_handler's 'owner' param Date: Wed, 4 Nov 2020 16:24:08 +0000 Message-Id: <20201104162427.2984742-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104162427.2984742-1-lee.jones@linaro.org> References: <20201104162427.2984742-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/rmi4/rmi_bus.c:299: warning: Function parameter or member 'owner' not described in '__rmi_register_function_handler' drivers/input/rmi4/rmi_bus.c:299: warning: Excess function parameter 'module' description in '__rmi_register_function_handler' Cc: Dmitry Torokhov Cc: Vincent Huang Cc: Hans de Goede Cc: Andrew Duggan Cc: Christopher Heiny Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/rmi4/rmi_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c index 47d1b97ed6cf3..24f31a5c0e04a 100644 --- a/drivers/input/rmi4/rmi_bus.c +++ b/drivers/input/rmi4/rmi_bus.c @@ -286,7 +286,7 @@ void rmi_unregister_function(struct rmi_function *fn) /** * rmi_register_function_handler - register a handler for an RMI function * @handler: RMI handler that should be registered. - * @module: pointer to module that implements the handler + * @owner: pointer to module that implements the handler * @mod_name: name of the module implementing the handler * * This function performs additional setup of RMI function handler and From patchwork Wed Nov 4 16:24:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11881431 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 85FFA921 for ; Wed, 4 Nov 2020 16:24:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E7092074B for ; Wed, 4 Nov 2020 16:24:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="c1d35Ul8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728841AbgKDQYq (ORCPT ); Wed, 4 Nov 2020 11:24:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730073AbgKDQYp (ORCPT ); Wed, 4 Nov 2020 11:24:45 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCD32C0613D3 for ; Wed, 4 Nov 2020 08:24:44 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id b8so22721709wrn.0 for ; Wed, 04 Nov 2020 08:24:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1B8aLNHl/Qs+uB28RwcWAHlScyGLFiAyQDDIMzV5Nlg=; b=c1d35Ul8+71Bsc2DO6reZqBHMH4M8JxQ+N5pONSycUxjIPLN0lw7SAFiEiTqAlkEUu MOHik11fAqXjr5Qq9nn47fxGrY5l3S9V1VjMZwqE/L1mmMVdhDTNaZLO9v4hPsT1j3Ke hnYWQGrBevOry2pXwUXYwbdvvuJ0GV/bTVhtMhg20igunh+oDwZ0lSLfFdz1A67rrJAK 6EczHiCMtpyERopQ6MMUcIfjHxL140BhIEOPxpaEuWwNW1Op0+bbYuOP5rc4pKGQkF3P qywrvVkh4W7VSjiJuHzezKOsMNMnPjezCFhZ0nO7dGrxLC1B1C9Yw5Xi+97Zmj8/y9wn NAUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1B8aLNHl/Qs+uB28RwcWAHlScyGLFiAyQDDIMzV5Nlg=; b=Ctwn6u6GYdZ0Xkt0SxzSyUgTCbf1jaKfItNQUsx7rh+i83Dkui6W2RqLWTCGgv630W s3uxyQ3tl8q+84D1L2h/09RwrmpafWK5FCYQnjRQZHpSs2Z4tNrL+oGkvmA7PvKST6yk 8yNECAf5GURAcTApgGw8JwuXyOLehns7Oj/Lwwdw96I/Z1lQ/rds79sCYcfCyUgBQki1 BOwQxRFD+ZLPR3F5MLZiVuEuvvOPDfitlutUsYIAqE/2sK9Ud0ynZ/CbQZRjsbSZ/M9s Wx5gJOdGxJWZYeXl0iIbVBK2j9iSsSzsk5vd0kfEZry7tRGv7ukErwzI63n+c1JtXU54 x5zw== X-Gm-Message-State: AOAM53037fsCy/HqUoTv/uJTpJXVmZys8byiIiWcO3opADT9uulpPa2d 9QEwsyaDjPImS80mSB+RByy0Mg== X-Google-Smtp-Source: ABdhPJzxrf60+RtCEC8+1PLcKvMvlLrMVnZ5U32Trjo0ZaEEFl90KL/39QKNcN5BzPL/q5W9sTqCbA== X-Received: by 2002:adf:df91:: with SMTP id z17mr31957489wrl.379.1604507083609; Wed, 04 Nov 2020 08:24:43 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id o129sm3008564wmb.25.2020.11.04.08.24.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:24:42 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Henrik Rydberg , Dudley Du , Daniel Kurtz , Benson Leung , linux-input@vger.kernel.org Subject: [PATCH 02/20] input: mouse: cyapa: Fix misnaming of 'cyapa_i2c_write's 'reg' param Date: Wed, 4 Nov 2020 16:24:09 +0000 Message-Id: <20201104162427.2984742-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104162427.2984742-1-lee.jones@linaro.org> References: <20201104162427.2984742-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/mouse/cyapa.c:130: warning: Function parameter or member 'reg' not described in 'cyapa_i2c_write' drivers/input/mouse/cyapa.c:130: warning: Excess function parameter 'ret' description in 'cyapa_i2c_write' Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: Dudley Du Cc: Daniel Kurtz Cc: Benson Leung Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Benson Leung --- drivers/input/mouse/cyapa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c index c675f156948b5..dacf7c0e43f98 100644 --- a/drivers/input/mouse/cyapa.c +++ b/drivers/input/mouse/cyapa.c @@ -119,7 +119,7 @@ static ssize_t cyapa_i2c_read(struct cyapa *cyapa, u8 reg, size_t len, /** * cyapa_i2c_write - Execute i2c block data write operation * @cyapa: Handle to this driver - * @ret: Offset of the data to written in the register map + * @reg: Offset of the data to written in the register map * @len: number of bytes to write * @values: Data to be written * From patchwork Wed Nov 4 16:24:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11881471 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6280714B4 for ; Wed, 4 Nov 2020 16:26:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C980206DB for ; Wed, 4 Nov 2020 16:26:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dVxYiVWa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730871AbgKDQYs (ORCPT ); Wed, 4 Nov 2020 11:24:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730862AbgKDQYq (ORCPT ); Wed, 4 Nov 2020 11:24:46 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43DD1C0613D3 for ; Wed, 4 Nov 2020 08:24:46 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id c17so3339125wrc.11 for ; Wed, 04 Nov 2020 08:24:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/pehohWmuys5loht7+WPpBg1h/OEijt9BJT+2ot7pfE=; b=dVxYiVWaB+e22PzDGjiCKLziltetH04dfjkI+LnDpCbnMDbROwELo9sbj6ZmUz7I4L X4bkKlWYlir2FkUNvuvrelWNtkT80hFmcvtwjO2e0fmYFwsZZDyHxjLxgA47LR+CU0Ln 7GH+BbJ5K8r4m6dbmAT/hn6wKTCy5YA49tU7VvMNCayhNufnEp+1DNvZaAElf7AdJokj wbus3avuX0tzWICtlHvx/hqwOiXYreKlPghHbyrkoTWPnbONJ5XN4LED9zbglKVcz0hd xNJzEGTwBT1n0i43ax7hPLy9oCq0pY706p+uDeSATC4s1Kg+UgDAVH/DnJ49HhbY09dn BjLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/pehohWmuys5loht7+WPpBg1h/OEijt9BJT+2ot7pfE=; b=qKcuMok5mPFavKQ/+grNuvwuydOfvZnFY8PyNU/w6D4oqe2C2T7h/3I+3jAp7QMvF7 w/sGuBoylh/Cz2cYAT3UGhKTnxA/uD5oTOvamIeIWUS1Y6inDX1RU/26D56r4xmZgr6K XcZz8H0XbPz3NWax0e2ac5fGnSBqjpTYcaZc0DsZLAaSpbi/xLocNx0OaFES9csNs45j 6FVZ7dPRbiHx0QREUMmORl88F0GH+f7maeICBWTT0wiIg4gOmAxK1ObEs3tmbau/mDRD D2fvtrRun2Vuebw0RYSjEsz4oacScC96xNrJAkD7pBRgE9VWDYZ+f3p9dz2WyjOUTU8A k0uQ== X-Gm-Message-State: AOAM531O5KBZiZ9c+6iAqfzUZ0ymzutR0+O3/2E0PR5BOKZsnO8nL89n f/a28qqrhW7nx2i04RJzqSiyXg== X-Google-Smtp-Source: ABdhPJynzGjvNfjtDsR1OdF+T/RCHr9NwfmXJKx5i8AjRSc0LoIT5yzEJwy09a3I4ZDlVEwovymnrg== X-Received: by 2002:adf:e610:: with SMTP id p16mr27404083wrm.302.1604507085026; Wed, 04 Nov 2020 08:24:45 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id o129sm3008564wmb.25.2020.11.04.08.24.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:24:44 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Henrik Rydberg , "Gustavo A. R. Silva" , Dudley Du , linux-input@vger.kernel.org Subject: [PATCH 03/20] input: mouse: cyapa_gen5: Fix obvious abuse of kernel-doc format Date: Wed, 4 Nov 2020 16:24:10 +0000 Message-Id: <20201104162427.2984742-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104162427.2984742-1-lee.jones@linaro.org> References: <20201104162427.2984742-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/mouse/cyapa_gen5.c:392: warning: Function parameter or member 'cyapa' not described in 'cyapa_i2c_pip_write' drivers/input/mouse/cyapa_gen5.c:392: warning: Function parameter or member 'buf' not described in 'cyapa_i2c_pip_write' drivers/input/mouse/cyapa_gen5.c:392: warning: Function parameter or member 'size' not described in 'cyapa_i2c_pip_write' drivers/input/mouse/cyapa_gen5.c:444: warning: Function parameter or member 'cyapa' not described in 'cyapa_empty_pip_output_data' drivers/input/mouse/cyapa_gen5.c:444: warning: Function parameter or member 'buf' not described in 'cyapa_empty_pip_output_data' drivers/input/mouse/cyapa_gen5.c:444: warning: Function parameter or member 'len' not described in 'cyapa_empty_pip_output_data' drivers/input/mouse/cyapa_gen5.c:444: warning: Function parameter or member 'func' not described in 'cyapa_empty_pip_output_data' Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: "Gustavo A. R. Silva" Cc: Dudley Du Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/mouse/cyapa_gen5.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/mouse/cyapa_gen5.c b/drivers/input/mouse/cyapa_gen5.c index bb3a63d1268d1..5c37af994b5b5 100644 --- a/drivers/input/mouse/cyapa_gen5.c +++ b/drivers/input/mouse/cyapa_gen5.c @@ -385,7 +385,7 @@ ssize_t cyapa_i2c_pip_read(struct cyapa *cyapa, u8 *buf, size_t size) return size; } -/** +/* * Return a negative errno code else zero on success. */ ssize_t cyapa_i2c_pip_write(struct cyapa *cyapa, u8 *buf, size_t size) @@ -435,7 +435,7 @@ static enum cyapa_pm_stage cyapa_get_pip_pm_state(struct cyapa *cyapa) return pm_stage; } -/** +/* * This function is aimed to dump all not read data in Gen5 trackpad * before send any command, otherwise, the interrupt line will be blocked. */ From patchwork Wed Nov 4 16:24:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11881433 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 77659921 for ; Wed, 4 Nov 2020 16:24:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DB112074B for ; Wed, 4 Nov 2020 16:24:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ygYYu735" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730878AbgKDQYt (ORCPT ); Wed, 4 Nov 2020 11:24:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730870AbgKDQYs (ORCPT ); Wed, 4 Nov 2020 11:24:48 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A8BAC0613D4 for ; Wed, 4 Nov 2020 08:24:48 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id v5so2951729wmh.1 for ; Wed, 04 Nov 2020 08:24:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LB9LqGfpy+30nABDjym4HdQWYW62bGrOr/5f5NXpmtI=; b=ygYYu735nXc5z/svx7/UBJe5GdmHVtu7p/5pU1OPA/+sz6DB1GdD4fHVZqKjjZ9ALo xQm0xlwMTbs2Rz1qZRX4Tv7FEACq2QRINXmcCIKv0neUELMOJ0UMAGvbeXBgn5gS1dXu oqhTcBQoB64cp9kYILgj/CarWEIq9BIZnYex/MPaxDfaeGG7snx6Gvfc9qmf3M/sir+l DO/+lfQxwCBD8f8W1MBfwxWmN6TRc6ibbTWBOf31jq5tpPhGw6yidxQCxb9LsDV1+K0T 9llR5KHq1Wb8d7VG53DLwlo1zd+Cllmja8LXho054Uyukc5x297XpeQ6WTIZrXzn5A6e 2bhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LB9LqGfpy+30nABDjym4HdQWYW62bGrOr/5f5NXpmtI=; b=BW3f4oFpnhkxnD2Z81FLW1DP3DeZfI+Ev7o8ytkyIW79IAFnHyB01CENtvO6Zk8Wo3 oInX1EJbNM5mS1vjlDooooeYjyhtadyrpPP9V5/lrCo26kgMqwYgQdpdsLyopC3RE7uF 9bI2DLHjhf9z3qxhgzXHpJ9V5yF41NZ4Z05O55R2bb7O0shm5Y9IYA5y4QnNH0UXkOw9 dWi1n79eU498WTMrym6hpi7vjkbcCzgelua4Itgu16QSFY4rMlghaITXB2+PctRWlk8C tpnms2/O2+TbSJCz+7tTvvRuTUT9vYYdP0ht5eioB/7fFFYwsND4W7OKPpOae7JEUFq0 Mb8A== X-Gm-Message-State: AOAM5303YWZWut1Pv8EA4hzj91ujt3J8dnDCA1cbthEb5K2R0minOFJb rCFr4lLZ42wOdLE6iqnoYLYMlQ== X-Google-Smtp-Source: ABdhPJzw4O4khcPkEHvyp46qCx1iQxm2OTchT8Dp0VbG1IUwRFlpvz1kpFK3RPfxkVVS1nvphGFsQQ== X-Received: by 2002:a7b:c1ce:: with SMTP id a14mr5623109wmj.126.1604507086891; Wed, 04 Nov 2020 08:24:46 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id o129sm3008564wmb.25.2020.11.04.08.24.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:24:45 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Sundar Iyer , linux-input@vger.kernel.org Subject: [PATCH 04/20] input: misc: ab8500-ponkey: Fix incorrect name in 'ab8500_ponkey' doc header Date: Wed, 4 Nov 2020 16:24:11 +0000 Message-Id: <20201104162427.2984742-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104162427.2984742-1-lee.jones@linaro.org> References: <20201104162427.2984742-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/misc/ab8500-ponkey.c:32: warning: Function parameter or member 'idev' not described in 'ab8500_ponkey' Cc: Dmitry Torokhov Cc: Sundar Iyer Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/misc/ab8500-ponkey.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/misc/ab8500-ponkey.c b/drivers/input/misc/ab8500-ponkey.c index ea3b8292acdd5..a9b9013680d62 100644 --- a/drivers/input/misc/ab8500-ponkey.c +++ b/drivers/input/misc/ab8500-ponkey.c @@ -19,7 +19,7 @@ /** * struct ab8500_ponkey - ab8500 ponkey information - * @input_dev: pointer to input device + * @idev: pointer to input device * @ab8500: ab8500 parent * @irq_dbf: irq number for falling transition * @irq_dbr: irq number for rising transition From patchwork Wed Nov 4 16:24:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11881435 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7F39C14B4 for ; Wed, 4 Nov 2020 16:24:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 59E742074B for ; Wed, 4 Nov 2020 16:24:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ihd4cjor" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730898AbgKDQYv (ORCPT ); Wed, 4 Nov 2020 11:24:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730886AbgKDQYu (ORCPT ); Wed, 4 Nov 2020 11:24:50 -0500 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87E75C0613D4 for ; Wed, 4 Nov 2020 08:24:49 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id c9so2932375wml.5 for ; Wed, 04 Nov 2020 08:24:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9NHmedOCRIc2xnnGH01/ejWH5JuRMMipEGdnpJjxqx0=; b=ihd4cjor+G6rX1ggGASF3+GjYf0ln8/wEy6pGL3SzwMX98KaSj0EcyR7Y/WGIfYp3M pUXD2dcjMEKpJjTL01KRKr99ewg4xK2se+OWdpfjcJ5PSe5fuGbw2exkIwmXaSV6kHNY yqYExKB+gb0ewMroVbBS2PXG8MBBORwKRNhVIAyNYdJeG9REXbflyKQC2cYt2I8zK+OK ojfUkUN9Bn8gyxPfgZg4FJo36TjcrGVu67tKHfiE1KvqCuwWLLRcVre0wGyIiDU5CJIs w9lAnUddYUvAtb5Ur8D8e3n4BFYwb1OIjRX3obRAPXRL6lJ0UjnTSyDBS0YK6QNbsgCJ rYXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9NHmedOCRIc2xnnGH01/ejWH5JuRMMipEGdnpJjxqx0=; b=PqFAPfqSFVU0r/79ItCBVI1FJyBlw6xPVWcrjAAyVb/bBEFCTny0Yt2+A6gaUO/P+K JPVfFiPJEvcTsEXUJo2ZAfJIufAU5c0pvw5gFAMwKJfcoYcfdEUxEgyj/RgUJlDmU83a L5vgcbrDoErmuQHm6HZzf5kG53lI+C2d5RLLPTgFcVsPphpvIxTDJ6ZcrL84GhXq0QAo WqDIYqDgQQg8xciiDmxZghbbONcMp98Pgj3aORWkbj0p+A4u140lJqpG8oH0kFQJPbil hepLW0xf3L3mSD20emSQsRX3KGDEBAdexQxFjcvP2khdYuFEQTx7BRyLQyTTbxAR+PIu OHHg== X-Gm-Message-State: AOAM530uIDnGVPG07voe3wcVLfyDHaUCyyiWbLXIH6JD4w/Sk1XSevQT 1X50lpOqqcx5qyvX5cSDnZ2VVg== X-Google-Smtp-Source: ABdhPJzN5pQ/mhwlh+PDZoLgd0UVb2djL7JMH20PolKMy8rlUhESY4VSUAiZsRqeTBcInCSLAH7P3g== X-Received: by 2002:a1c:8087:: with SMTP id b129mr5455110wmd.10.1604507088195; Wed, 04 Nov 2020 08:24:48 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id o129sm3008564wmb.25.2020.11.04.08.24.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:24:47 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , linux-input@vger.kernel.org Subject: [PATCH 05/20] input: rmi4: rmi_f01: Struct headers are expected to start with 'struct ' Date: Wed, 4 Nov 2020 16:24:12 +0000 Message-Id: <20201104162427.2984742-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104162427.2984742-1-lee.jones@linaro.org> References: <20201104162427.2984742-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/rmi4/rmi_f01.c:106: warning: Cannot understand * @ctrl0 - see the bit definitions above. Cc: Dmitry Torokhov Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/rmi4/rmi_f01.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/rmi4/rmi_f01.c b/drivers/input/rmi4/rmi_f01.c index e623c956376e3..23618fcb1f322 100644 --- a/drivers/input/rmi4/rmi_f01.c +++ b/drivers/input/rmi4/rmi_f01.c @@ -103,6 +103,7 @@ struct f01_basic_properties { #define RMI_F01_CTRL0_CONFIGURED_BIT BIT(7) /** + * struct f01_device_control * @ctrl0 - see the bit definitions above. * @doze_interval - controls the interval between checks for finger presence * when the touch sensor is in doze mode, in units of 10ms. From patchwork Wed Nov 4 16:24:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11881437 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 98A8D14B4 for ; Wed, 4 Nov 2020 16:24:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7783A2072E for ; Wed, 4 Nov 2020 16:24:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h3mrDnBn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730819AbgKDQYy (ORCPT ); Wed, 4 Nov 2020 11:24:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730906AbgKDQYw (ORCPT ); Wed, 4 Nov 2020 11:24:52 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87DC7C0613D4 for ; Wed, 4 Nov 2020 08:24:50 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id e2so2901171wme.1 for ; Wed, 04 Nov 2020 08:24:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PA3FVb+J4SclMKAlYY0ZMYvDath2dI2KOPbq273rzfU=; b=h3mrDnBnxtdzKtq6qaH4Yz1GlgnTi+jA7inH14IUqkWjyA20QAPGpBiFc5cf9nym+c UKA2KLCEXqYJ+/I+mXu1z10VqS9jsWRdHfYMrB+XlRjv/TZ/maeIkMV3qMQiFzmqU6ow 8XZlmBPWezi1G23RYmGrnMtlKHgFerW9GLD34mvRWQwUXNQ5UobzGUUzmsnLGp8itYZY h0iL1qsbz4OLNS4fmSrER/WH5x0DLsEG+6diVr4hIvo/+D26b67sBDojSRbCfd1o4p9q S5mjIwswjmXCigpggCkdguU0N+WfNIydyl12UiqtKt6MrbwKUTUP9BqQqOoMabm17Ffa ZrEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PA3FVb+J4SclMKAlYY0ZMYvDath2dI2KOPbq273rzfU=; b=FJxykrIUUDcZ7XAgaAR5IopXQizgv3sRS5SmjFl++CEVQJmIjXIdvaV8E/SuFdM/+k HolOu4aXyNGJ3LjHrzaEdmEXz38WoXBIdUDwRNe8MkEW9AxvPv4vaGFataBpsH20bdyA Q5e/nwWSluE7uJj3AAiZ2m2DaKcmMPgXtxTdung3aCYd81gRZKWRH0Kl3lor6gE5fH6/ UxVNdmLIjXzYu75p/FQhVPalymTPnhjDGGlTKCu3erNWtuPAtEXIOviwQKLf7UbhE3Wq vAo4mK4c3oJoleYOajclzIdBIKonL5NacgIUMrvP5kCrak3wVUnnzJHL3PG8eSwa1GC+ /EfA== X-Gm-Message-State: AOAM530xbCTlrRXLWnEIQbyS7+c55kSCvlP2ql4f9q0rTfM0HiO6SXAA 51y1IEgzzEWCw28+iyBG49MiMw== X-Google-Smtp-Source: ABdhPJzGkwC0/0zybFgME2vUtjZnUQpYba8BVXb2AQnp+5IpCvk1PI+MgzlLVHgipc70m2+Cb7ZTHw== X-Received: by 2002:a1c:b387:: with SMTP id c129mr5384063wmf.58.1604507089249; Wed, 04 Nov 2020 08:24:49 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id o129sm3008564wmb.25.2020.11.04.08.24.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:24:48 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , dusonlin@emc.com.tw, KT Liao , linux-input@vger.kernel.org Subject: [PATCH 06/20] include: input: elan-i2c-ids: Mark 'elan_acpi_id' as __maybe_unused Date: Wed, 4 Nov 2020 16:24:13 +0000 Message-Id: <20201104162427.2984742-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104162427.2984742-1-lee.jones@linaro.org> References: <20201104162427.2984742-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Some drivers which include 'elan-i2c-ids.h' make use of 'elan_acpi_id', but not all do. Tell the compiler that this is expected behaviour. Fixes the following W=1 kernel build warning(s): include/linux/input/elan-i2c-ids.h:26:36: warning: ‘elan_acpi_id’ defined but not used [-Wunused-const-variable=] Cc: Dmitry Torokhov Cc: dusonlin@emc.com.tw Cc: KT Liao Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- include/linux/input/elan-i2c-ids.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/input/elan-i2c-ids.h b/include/linux/input/elan-i2c-ids.h index 520858d126808..b6976d99b6b75 100644 --- a/include/linux/input/elan-i2c-ids.h +++ b/include/linux/input/elan-i2c-ids.h @@ -23,7 +23,7 @@ #include -static const struct acpi_device_id elan_acpi_id[] = { +static const struct acpi_device_id __maybe_unused elan_acpi_id[] = { { "ELAN0000", 0 }, { "ELAN0100", 0 }, { "ELAN0600", 0 }, From patchwork Wed Nov 4 16:24:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11881441 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0285514C0 for ; Wed, 4 Nov 2020 16:24:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CACEB20786 for ; Wed, 4 Nov 2020 16:24:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lso1mucy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730934AbgKDQY5 (ORCPT ); Wed, 4 Nov 2020 11:24:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730913AbgKDQYx (ORCPT ); Wed, 4 Nov 2020 11:24:53 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBE49C061A4A for ; Wed, 4 Nov 2020 08:24:51 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id w1so22743917wrm.4 for ; Wed, 04 Nov 2020 08:24:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=X0gqY/+HUV0Wr5kDu/23vRzM4J8U3NtwS4/rj4N8QsA=; b=lso1mucyGqycLajbhrAkYzP7u5i7QVTrGcp1cPVbYO8d332GYeWLGyef9lRw3CPlwJ XpltyVJrrtTJe5qv9u1OiDK05mV6Ioc4rMg5TUp2GmRygBvnJGz55bLjvplQmF/mK5+G IgRg/OOD2+2tyyG4kECcOx4kYqGnv6AcC72C4i+LiGI1REKovh4sFGJ9hSg0i3ksaP7F C9cLQTVIGrKN0CIBTRxcBZbqx7k6D8fM3S/BKMCWMhGMNbNioj/it64ZDvwYZnLwi35J BcgCRdZlccOzvtRBxQ3rL9nbGzaeIZidlEbRU0tXgHxNVN3knnhnZlaM0qwEy747HMfn gqPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=X0gqY/+HUV0Wr5kDu/23vRzM4J8U3NtwS4/rj4N8QsA=; b=Hb2sL3wGefz0OdYSn7cQS1+xI/Yvu9gTEIZ1H/3XnZQEwMno1Er64nyjGtb6ljsgLa p/lIn49Pb9Oe1oGGq8KzV+Okzlbiuc39YJV6ntS1YQ7GCyGBQ/HBeSFTrsXvU6kLGOwR jxP8Gtc+ca15enxXMTLhWO6e1OMeclxJ+9uYno07oTB5a6GyV4QixbLjCoQNaSvSd1yu Xoeh7e/0Yo9wqpMhsn6qyTZsDd0LsqPhdpAniAfCG64J6WYdfK8cjMH2gsHHcCR2spxJ OFpFdzmlfVllRROQsuaUsXvgPouFX3EiE4iqQrIh/66pVkjPbb/7HIr6466qohcHQ9c7 dhnw== X-Gm-Message-State: AOAM531fIYSAaFGs/dKPBptTzOjNQENX+7Og3oIe1B3qCgt/BR/iGY5B q7sY8cl15ICf/EInhnYYT7orvQ== X-Google-Smtp-Source: ABdhPJyIVkNKg158DR7Ruz3lyqCJ3UvU4gBJZ3sbH1KLrh50PA/PjxkN9udRu3pprTPXFw/OvrVM0A== X-Received: by 2002:a5d:66c9:: with SMTP id k9mr36083715wrw.158.1604507090615; Wed, 04 Nov 2020 08:24:50 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id o129sm3008564wmb.25.2020.11.04.08.24.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:24:49 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Benson Leung , Enric Balletbo i Serra , Guenter Roeck , linux-input@vger.kernel.org Subject: [PATCH 07/20] input: keyboard: cros_ec_keyb: Struct headers should start with 'struct ' Date: Wed, 4 Nov 2020 16:24:14 +0000 Message-Id: <20201104162427.2984742-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104162427.2984742-1-lee.jones@linaro.org> References: <20201104162427.2984742-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/keyboard/cros_ec_keyb.c:72: warning: cannot understand function prototype: 'struct cros_ec_bs_map ' Cc: Dmitry Torokhov Cc: Benson Leung Cc: Enric Balletbo i Serra Cc: Guenter Roeck Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Benson Leung --- drivers/input/keyboard/cros_ec_keyb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c index 15d17c7170816..fce0c839e1430 100644 --- a/drivers/input/keyboard/cros_ec_keyb.c +++ b/drivers/input/keyboard/cros_ec_keyb.c @@ -58,10 +58,9 @@ struct cros_ec_keyb { struct notifier_block notifier; }; - /** - * cros_ec_bs_map - Struct mapping Linux keycodes to EC button/switch bitmap - * #defines + * struct cros_ec_bs_map - Struct mapping Linux keycodes to EC button/switch + * bitmap #defines * * @ev_type: The type of the input event to generate (e.g., EV_KEY). * @code: A linux keycode From patchwork Wed Nov 4 16:24:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11881439 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 809E5921 for ; Wed, 4 Nov 2020 16:24:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B9FB206DB for ; Wed, 4 Nov 2020 16:24:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JGNHio/t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730888AbgKDQY5 (ORCPT ); Wed, 4 Nov 2020 11:24:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730919AbgKDQYx (ORCPT ); Wed, 4 Nov 2020 11:24:53 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F1F4C0613D4 for ; Wed, 4 Nov 2020 08:24:53 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id 23so2210182wmg.1 for ; Wed, 04 Nov 2020 08:24:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yOqqwbhs3ZFnypFgr81+FVo0+Ncb1joEEk3R1wcSBm8=; b=JGNHio/tzPkDy+/FyTCMGY/ssW2w/GQpFbLgWgw4NR8QApR1GggM30uCUKOV4eEZXp rILOPGM3qh9JetWxdtLK60SbE0JWyGkvi10rYTktKNMoePcY0aIYt3kQ0LeljkOSSx+A Exq53HV2ZKL2svrB4L98uT1ajW521U/Cv6TY8RHYdNwDUaTgcqh8VYJcVs5xfYHlFTzK cp3dqY6G4b8jU/EO7WWkOM9NzEbqKl6qlk+IDD2AqQWLrppkhC16HsoLDaNtq8CEYrqa XYXnZkvH0mMM+Nrn+WhFcZZ6HenlRsCM386vJmeGLUYhf75VgEEHlFrL1hJ7m5KsP9Wi Pb9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yOqqwbhs3ZFnypFgr81+FVo0+Ncb1joEEk3R1wcSBm8=; b=M01kJNTynE23d6u46b1eqSfr5xxQRufW019vWASorRwCFmcto+IopAFUOujkZVEA5z OAxQc19uO1q/offwv2S1a2pThusd4cYtOuxR0g01/A6bSbKNUOB0E1+G0yBm+QJwM0OD QUMlNO/tAR0aIgf6/Q6y0L1eVdBGs4d2kUZGUQtn1FDPQU8eX1q5HKTj6ZI+sdodSgyk qsiHm1AD4MAz/esY72mosMKSkiqkb6x12n/oLuMMCtgC0KvLdtjJiOQ7N4Aj9mHYChAg 7nz5xSc+k8jK9ExuCswuD0nyQ7wnshBGsUuhJXmHi/ueOs/AGVXJTrhw6617h8sEEE+f L6cg== X-Gm-Message-State: AOAM531LqDHgsvVlNlaLhu1Ca5OEfYzL69AiEv+iH4gc36TOa8qdXXCL vyrXirCMS/4Xpq4tSsKybY1KcQ== X-Google-Smtp-Source: ABdhPJxjdksOfjG9itW3gMfgTXD935vSw7Mn9Npcixc/CseYuLHAQnNW+iYB0LibrjKy5joIoxc4WQ== X-Received: by 2002:a1c:3d44:: with SMTP id k65mr5155183wma.147.1604507091818; Wed, 04 Nov 2020 08:24:51 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id o129sm3008564wmb.25.2020.11.04.08.24.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:24:51 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Henrik Rydberg , Andrew Duggan , linux-input@vger.kernel.org Subject: [PATCH 08/20] input: rmi4: rmi_f11: Struct headers are expected to start with 'struct ' Date: Wed, 4 Nov 2020 16:24:15 +0000 Message-Id: <20201104162427.2984742-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104162427.2984742-1-lee.jones@linaro.org> References: <20201104162427.2984742-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/rmi4/rmi_f11.c:66: warning: Cannot understand * @rezero - writing this to the F11 command register will cause the sensor to drivers/input/rmi4/rmi_f11.c:311: warning: cannot understand function prototype: 'struct f11_2d_sensor_queries ' Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: Andrew Duggan Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/rmi4/rmi_f11.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c index ffa39ab153f2a..38baf39ce0916 100644 --- a/drivers/input/rmi4/rmi_f11.c +++ b/drivers/input/rmi4/rmi_f11.c @@ -62,7 +62,7 @@ /* maximum ABS_MT_POSITION displacement (in mm) */ #define DMAX 10 -/** +/* * @rezero - writing this to the F11 command register will cause the sensor to * calibrate to the current capacitive state. */ @@ -178,7 +178,8 @@ #define F11_UNIFORM_CLICKPAD 0x02 /** - * Query registers 1 through 4 are always present. + * struct f11_2d_sensor_queries - Query registers 1 through 4 are always + * present. * * @nr_fingers - describes the maximum number of fingers the 2-D sensor * supports. From patchwork Wed Nov 4 16:24:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11881467 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 51AB514B4 for ; Wed, 4 Nov 2020 16:26:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D4C7206A5 for ; Wed, 4 Nov 2020 16:26:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="i/SMHsMT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730900AbgKDQ0F (ORCPT ); Wed, 4 Nov 2020 11:26:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730928AbgKDQY4 (ORCPT ); Wed, 4 Nov 2020 11:24:56 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77D73C0613D4 for ; Wed, 4 Nov 2020 08:24:54 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id g12so22667301wrp.10 for ; Wed, 04 Nov 2020 08:24:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JM2T5gVY6mQCYq3pa3CtVVdmUuOhZqTmm7j89dYLWQU=; b=i/SMHsMT00YS2lCynxMmugbtsc2/7yy4xnA5bc0ana2gO2cCL2SEp/JMla/n126zZh NPYH+jLh1YN4Df7mt2FAvaVYe/s8DxEH/mgQkK7E5j8pI/BNv9nCagofcEoikxhSYI0p YvxYFpnOfvtlbnHs7mK7pwZrCRaBdb2n9YLw2dnLGay6Ue4hHFG9/u+QGNEG1KQUmu3D 2Zj5Mg/DCXSLILCkeHP45dbLiZou4OR+z/6QP9ZfoF5AhABxuTFVSWs7gCU1TgcevrDr KjzhgM4jNrN/wCGCTgWun7Wd+xpKH0kGa3RhPPk+UjfPccndKb1dom1VZk3WoRnu+fgM Zpbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JM2T5gVY6mQCYq3pa3CtVVdmUuOhZqTmm7j89dYLWQU=; b=hzVg/uGJz+yuzTBnNCbGtG34UulazzIy4Nj5qRduhjLWUoFfHAQvw7Cpcmd3Sjcit1 UO48EaTeMKTSc3JnWJkH/lG6OaLQu5+ofv/HeymN66HZJNap1EUhdaKqYGZDaKFACnGz rAOCqbezcJprGS3tfRHf73I/dvnst1ZmxyAbRbROh1hBOU834r9goFjJrqNl3x5H56Mi Eu1CXnRJu8DpUPW7DBgYmj8whMkPc4Gk5LcV7UI50ZpyOBzYVKQFk6NVd26S5tDVyqEb MFJW8Waz2qRTVqYnO70HsndAM8Kw+qyUC7QnF5yNYRzo6SvNMR/tO7ft8AtjvRRuhL74 EZAw== X-Gm-Message-State: AOAM533ubay4M42CSqjc2RUVank+X9ArRHDynAwPaiDO+WVnyrvAcs6w NVwCAv43+8FV+12VKzq8ee1/Cw== X-Google-Smtp-Source: ABdhPJzdjlS/LhhU7HXjUaKMzpL+Law5xU6ARfYwU1WOJ3TBZddsJ93/Gm+k8L5S/PJ71zU7Xo2rGA== X-Received: by 2002:a05:6000:3:: with SMTP id h3mr31862922wrx.215.1604507093262; Wed, 04 Nov 2020 08:24:53 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id o129sm3008564wmb.25.2020.11.04.08.24.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:24:52 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Eugen Hristev , Dmitry Torokhov , linux-input@vger.kernel.org Subject: [PATCH 09/20] input: touchscreen: resistive-adc-touch: Struct headers should start with 'struct ' Date: Wed, 4 Nov 2020 16:24:16 +0000 Message-Id: <20201104162427.2984742-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104162427.2984742-1-lee.jones@linaro.org> References: <20201104162427.2984742-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/resistive-adc-touch.c:34: warning: cannot understand function prototype: 'struct grts_state ' Cc: Eugen Hristev Cc: Dmitry Torokhov Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/touchscreen/resistive-adc-touch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/resistive-adc-touch.c b/drivers/input/touchscreen/resistive-adc-touch.c index cfc8bb4553f78..e50af30183f4e 100644 --- a/drivers/input/touchscreen/resistive-adc-touch.c +++ b/drivers/input/touchscreen/resistive-adc-touch.c @@ -23,7 +23,7 @@ #define GRTS_MAX_POS_MASK GENMASK(11, 0) /** - * grts_state - generic resistive touch screen information struct + * struct grts_state - generic resistive touch screen information struct * @pressure_min: number representing the minimum for the pressure * @pressure: are we getting pressure info or not * @iio_chans: list of channels acquired From patchwork Wed Nov 4 16:24:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11881469 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A516F921 for ; Wed, 4 Nov 2020 16:26:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8105C2072E for ; Wed, 4 Nov 2020 16:26:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Zo4HwqwM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730922AbgKDQ0F (ORCPT ); Wed, 4 Nov 2020 11:26:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730933AbgKDQY4 (ORCPT ); Wed, 4 Nov 2020 11:24:56 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA951C061A4A for ; Wed, 4 Nov 2020 08:24:55 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id c17so3339713wrc.11 for ; Wed, 04 Nov 2020 08:24:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hwyOazzO/GQzyuqblzZOtq9SwXpd1xEL9uFxk2jvFF4=; b=Zo4HwqwMwEFUkSUixNvB41J5S0n/ImVso05y2fPLD//YtKZoVyJZRsOIzRR15+ueRx f+08bnoAreTE/Zhg0kiSmLb9NGmSpPepV3WbxvG25tFxr8hZY+2DXSiR/7G1CbDxKFCH 5Rh3XQPBQwgHFwpUMdOCKhh8KLCZ6GJmjmlJ+CEOorScoa38PZNA9lMcnrnW35kBIpwY gcwdgojBD4Wr0Dn9cK4xJIBEY7xsPsBvA4A0CwgtBn5Ar7grsTDoz1y/ut5c0yhecUMu seB5bdhJBBHk53BYEVQf0k3NfMQfu/Y3onv5oGbMVcXYkFJqpVThXv50LoLr1hgJfNc6 xZjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hwyOazzO/GQzyuqblzZOtq9SwXpd1xEL9uFxk2jvFF4=; b=lW0x2fuf5kAglMzX9QGjH5FLoguUMjG8NVQ35Yaz+mQ7pPvxRR7kr9eMdS9h/tEfPz pJESoijOi69MzPg09hsmdFW22G8/gEk4ff5GVtGpuCx5iiuqLECBxfgExb/vNXngFJdh qqJN871sab7xq9iku8jJ/UOmvihwEjbTBu0aa+rxvnJwEYm8V1hoDUSbu6pwC+qgHwnJ Oe1o8m4wc/tsWgXPELhgiAivOAlwQ6ADtpH3qGFJuabeEHdFZ0qMQrB/MVzPYnSMMxnl EHt/zm879tUNuVeKy2C/5ITxOX2aZFb3TUhY5P399dxWNXhaIYwFzAhx+T6SVcRz4YFa jLNw== X-Gm-Message-State: AOAM532UwuVbJbi+vI8WCnlCq7xMlfWLcpDOpWkJVgiLw8p6EtuP3I0b bkWyfGRybe9VG/z7ajkWyGCLEPRKDY+jkOab X-Google-Smtp-Source: ABdhPJwfuLiHj0uKdmCYgiPrFNhlKN1rGUHif2OjsyPaTaeOm2RMx7PaLn6wchUSsYtqNqeNBPpnrQ== X-Received: by 2002:adf:80eb:: with SMTP id 98mr7667239wrl.101.1604507094427; Wed, 04 Nov 2020 08:24:54 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id o129sm3008564wmb.25.2020.11.04.08.24.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:24:53 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Henrik Rydberg , Peter Osterlund , Stefan Gmeiner , "C. Scott Ananian" , Bruce Kalk , this to Subject: [PATCH 10/20] input: mouse: synaptics: Place braces around empty if() body Date: Wed, 4 Nov 2020 16:24:17 +0000 Message-Id: <20201104162427.2984742-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104162427.2984742-1-lee.jones@linaro.org> References: <20201104162427.2984742-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’: drivers/input/mouse/synaptics.c:1110:6: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: Peter Osterlund Cc: Stefan Gmeiner Cc: "C. Scott Ananian" Cc: Bruce Kalk Cc: this to Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/mouse/synaptics.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 82577095e175e..07835939d83b9 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -1106,8 +1106,9 @@ static void synaptics_process_packet(struct psmouse *psmouse) num_fingers = hw.w + 2; break; case 2: - if (SYN_MODEL_PEN(info->model_id)) + if (SYN_MODEL_PEN(info->model_id)) { ; /* Nothing, treat a pen as a single finger */ + } break; case 4 ... 15: if (SYN_CAP_PALMDETECT(info->capabilities)) From patchwork Wed Nov 4 16:24:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11881453 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 986CF14C0 for ; Wed, 4 Nov 2020 16:25:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71FCB206D4 for ; Wed, 4 Nov 2020 16:25:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eySFgeGH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730999AbgKDQZF (ORCPT ); Wed, 4 Nov 2020 11:25:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730947AbgKDQY7 (ORCPT ); Wed, 4 Nov 2020 11:24:59 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA6C2C061A4D for ; Wed, 4 Nov 2020 08:24:56 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id h22so2906994wmb.0 for ; Wed, 04 Nov 2020 08:24:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4Wus8zLlMTZdwx+8H6IUw2g9q/prHivgi0ht3FgmUO4=; b=eySFgeGHZ6y6orDLmCBdDXmmCFlZs55lHR+lsoCgHO5GOXgEu4xC5h28XqTJvuflrD C6NqtqXsTiDhMy8DJClV9SD55fRrZM+bGRf9scc7aB+4M6IqRcD9z5IA66xTZAajcOE7 24Pv2MmJpAPBRLyJzTRmFPbNynSys3FuzIo8lEW1Nit10Xw8C+HjMEugcizw1kYrGtRL 4PmUKI/m3vd4A9EJPuQuRL9O5I3nkdMk1NVRrL9ive49EarztXf4lBd3exmTEv3ceYpx bGGlflI4nLRxohw+l/6Hm4vNftnI2QqycMLJBO74l9cCFQi4RSywFfgpVSOD75MOX80J o5PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4Wus8zLlMTZdwx+8H6IUw2g9q/prHivgi0ht3FgmUO4=; b=VlQ6vIjl6v0cHDybHE9I/v7bWpGuCmnVOKhpZBw/Cvu/ZeEeoPUVSO5g74pGaUD+ou gRG5iqdid15TOU4tyNAbUpHXTbdcSiI4wgKX2sIbwOjsLT29qqoCInWuBzYDOvFA6MSu X9SghXEegwLHXNydZBzatsDcjAtfjnZR0pxM7JqjKejoo3Ei8RrkXv/B1MsTYGMaxDE1 zKbiJgNI/LIB4Ov9vhwrpohiBL3nzcp8iAMsJPK2IvhyUhxx9AHTjiDhMuHeEk9E9Idc xLpUzFTr4Vtc3XSKHO9cB4mOLsIT5X/iPVfTouICAz4X0AtbeibvgQ5cU0sZW1kHP23C 7vvA== X-Gm-Message-State: AOAM5328015bQB7hzeTpdpsOpnf6v7SRP0JT/DPkyT11pDWJQB90TWWr k1X444VBAggmfepZ7gmnN8+WEQ== X-Google-Smtp-Source: ABdhPJzh49GwcsjyMJuXN6DtlEk8btIl7d2MbHgGlXgbi94tJRPrtmwu9voNb68zeSPDwq26W85MPA== X-Received: by 2002:a1c:9a83:: with SMTP id c125mr5338586wme.116.1604507095671; Wed, 04 Nov 2020 08:24:55 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id o129sm3008564wmb.25.2020.11.04.08.24.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:24:54 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , "Gustavo A. R. Silva" , David Jander , Phil Blundell , linux-input@vger.kernel.org Subject: [PATCH 11/20] input: keyboard: gpio_keys: Fix misnamed function parameter 'dev' Date: Wed, 4 Nov 2020 16:24:18 +0000 Message-Id: <20201104162427.2984742-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104162427.2984742-1-lee.jones@linaro.org> References: <20201104162427.2984742-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/keyboard/gpio_keys.c:119: warning: Function parameter or member 'dev' not described in 'get_bm_events_by_type' drivers/input/keyboard/gpio_keys.c:119: warning: Excess function parameter 'input' description in 'get_bm_events_by_type' Cc: Dmitry Torokhov Cc: "Gustavo A. R. Silva" Cc: David Jander Cc: Phil Blundell Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/keyboard/gpio_keys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c index f2d4e4daa818f..a079504e98e82 100644 --- a/drivers/input/keyboard/gpio_keys.c +++ b/drivers/input/keyboard/gpio_keys.c @@ -108,7 +108,7 @@ static int get_n_events_by_type(int type) /** * get_bm_events_by_type() - returns bitmap of supported events per @type - * @input: input device from which bitmap is retrieved + * @dev: input device from which bitmap is retrieved * @type: type of button (%EV_KEY, %EV_SW) * * Return value of this function can be used to allocate bitmap From patchwork Wed Nov 4 16:24:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11881457 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5E10D921 for ; Wed, 4 Nov 2020 16:25:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CFAE206DB for ; Wed, 4 Nov 2020 16:25:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TgpHBxyd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730983AbgKDQZz (ORCPT ); Wed, 4 Nov 2020 11:25:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730973AbgKDQZD (ORCPT ); Wed, 4 Nov 2020 11:25:03 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E3DDC0401C1 for ; Wed, 4 Nov 2020 08:24:58 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id k18so2872360wmj.5 for ; Wed, 04 Nov 2020 08:24:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wqV2KeQMP/jFy3p+xfQ20dH54ZYHRrmQaU4ia2enM0c=; b=TgpHBxydiK0xY7RBNvsdU9Yu+j5Ha0R/S+kR6gjh3E260ncOOfUtbuIQQj/zGA/fIs a6c9rBGWZAi3x1dKcHK9Tbg9ZrTA45/6eE/PfJTwxNRM8jWIzBvUqt0MEs9SgWke2w9Z Qf9ncIivi1Kn9I5VipWCLMyXFcYVBEmFNq/m1qiYpLu4MR3PjuBdObyOWZdNk8BE88mY Eq5HaISwXddNkG3Gyx/OT+xYWjqivnvpJY0n5uCVIKRRYlE8ylLREiW4uNUHxnZTnhr+ mY0A+J/5780uburyheUsfTypAVqbyDVV9KOABCawsljanzyVoPJF7h/wyXMQE2w4CccC rkQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wqV2KeQMP/jFy3p+xfQ20dH54ZYHRrmQaU4ia2enM0c=; b=Q2xdp2GbqfCkXtmPuZS1rNPXLq2BVNMBY0wnmQkLiHPIz0IK1XkxrUQzHMqUYjBZeJ 9mscnCpTjVI6/1OOYJZFVrJzLevqfL3kGL8AjxTiZLgAbclXnmtu+9NUEXJyzqJW3h0E v/xlD2KkHe/b9immAbg4iofNswNwfJx3/0D2NfkgKxi0n1jEyhRSwAVgtHYoXtO6UzMR MXyY/IyFree64ae9GBUqD4WRfvNGVlR5BdNH9iIGUkMbRfMjTi52+qd1PWFNx12okbaw 5GbBEVCEStsZZf735qEHL/dbm0cqHcJdRKuP96nxsYjbx2vIhILbnCV9mQs634WKsKw3 EPDg== X-Gm-Message-State: AOAM530pq6wVGrV/AnQ7ZCroeHZYMfF6/mUkv8v+HU6ERkhO/gse1e+i hxOuVl4+kgipu8J6VDPG53R0ug== X-Google-Smtp-Source: ABdhPJw8fPHgbe9/qhRL11vvZZ1bNdDlY920DUkgfl4LgerotHnx/SYgDgtZu2uk1jR8JBUCEWkwjw== X-Received: by 2002:a1c:9cc1:: with SMTP id f184mr5351092wme.5.1604507096858; Wed, 04 Nov 2020 08:24:56 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id o129sm3008564wmb.25.2020.11.04.08.24.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:24:56 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Henrik Rydberg , Arjan Opmeer , linux-input@vger.kernel.org Subject: [PATCH 12/20] input: mouse: elantech: Demote obvious abuse of kernel-doc header Date: Wed, 4 Nov 2020 16:24:19 +0000 Message-Id: <20201104162427.2984742-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104162427.2984742-1-lee.jones@linaro.org> References: <20201104162427.2984742-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/mouse/elantech.c:1837: warning: Function parameter or member 'psmouse' not described in 'elantech_setup_smbus' drivers/input/mouse/elantech.c:1837: warning: Function parameter or member 'info' not described in 'elantech_setup_smbus' drivers/input/mouse/elantech.c:1837: warning: Function parameter or member 'leave_breadcrumbs' not described in 'elantech_setup_smbus' Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: Arjan Opmeer Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/mouse/elantech.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c index 90f8765f9efc8..47cd0e7f79bd1 100644 --- a/drivers/input/mouse/elantech.c +++ b/drivers/input/mouse/elantech.c @@ -1827,7 +1827,7 @@ static int elantech_create_smbus(struct psmouse *psmouse, leave_breadcrumbs); } -/** +/* * elantech_setup_smbus - called once the PS/2 devices are enumerated * and decides to instantiate a SMBus InterTouch device. */ From patchwork Wed Nov 4 16:24:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11881465 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 505C114C0 for ; Wed, 4 Nov 2020 16:26:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D371206DB for ; Wed, 4 Nov 2020 16:26:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wfZOJTrn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731128AbgKDQZ7 (ORCPT ); Wed, 4 Nov 2020 11:25:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730976AbgKDQZD (ORCPT ); Wed, 4 Nov 2020 11:25:03 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A8E8C0401C3 for ; Wed, 4 Nov 2020 08:24:59 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id n15so22750933wrq.2 for ; Wed, 04 Nov 2020 08:24:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=msuLefrZcEgx331/KYpWGgm3TBHNpr52u7dLtV0zqps=; b=wfZOJTrnJLcGlYWEG9B+GhDqsHkblvuFsfWhIGXyFjshWYHWR4vtXpsCVcTSbmVkAt oxZ4bOxM0fIV8AbbwoIkF1EnPmnlgGZYsQS5pID2zK7Tabthi6BONKDAbjiuNUy2eYal NMr6y+NvM+aeRXDTHIfFQRC2JqjikLBItk8Fr9UBD/3PloBYg7qMTloSAkweE+wDx3ak dcl9jOKsDuFTjE5uvUBCL4HfzV+K/V0Sy1c/Peh9K060HUY3KJ85bnTI5sjEpa4sCvoq ovgD+NsiBwUCq3HGH7W4sKf7tsfAsOrvdrWeyN4eKNB2Ff8X7EwtQ2hjfnJuslsGgnEr 7aDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=msuLefrZcEgx331/KYpWGgm3TBHNpr52u7dLtV0zqps=; b=DIm5rcSiaWIwUkAITOFz3BSsBqnU7UIIS5Bc9ALmIsfY73xdGvYkXFozEo5CKR/S9j Eqzb5Zviyw6vlcq0IZA+qU17Zwh7gboNXxJwJI0tbUelG4XcmaphicI6QB7HKb0ipc8q aChShjFwFzIScfCTIkWKnutvLufYQ8VuSzRvlu7mzeoxrjeT6SaZPh+jG7qcXpp01yY0 uEBFUzs36ao4PmazI2ZQ6ic1Ppj23GbER2nvBKPXSmeV7MzLIFbaofHBvbsUQBmLyDVl NWEhUiHmIwSN4muWG0yHbhNbeVaM1CBWWoLy0fpE4kFwzA6o6u9H9DOTi8Gl3dvnmhXq VTBQ== X-Gm-Message-State: AOAM532dH8avseCL4HJMwqgxzbfPkPE2UTlC9ff+xfL5HWuj0YDFNlOS GOQP5UHeBS9vb85zrRDKZOYyOPpnGZPcRrs6 X-Google-Smtp-Source: ABdhPJyHBpgiYezebevIEOeTys2mcAT0d8aCDxyMKil5oGa56dkB4VMa0DUUUu9MiJzU6eU3OB8/Cw== X-Received: by 2002:a5d:6ca8:: with SMTP id a8mr18741943wra.319.1604507098189; Wed, 04 Nov 2020 08:24:58 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id o129sm3008564wmb.25.2020.11.04.08.24.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:24:57 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , linux-input@vger.kernel.org Subject: [PATCH 13/20] input: rmi4: rmi_f54: Provide some missing 'REPORT_TYPE' enums Date: Wed, 4 Nov 2020 16:24:20 +0000 Message-Id: <20201104162427.2984742-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104162427.2984742-1-lee.jones@linaro.org> References: <20201104162427.2984742-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/rmi4/rmi_f54.c:77: warning: Enum value 'F54_REPORT_NONE' not described in enum 'rmi_f54_report_type' drivers/input/rmi4/rmi_f54.c:77: warning: Enum value 'F54_MAX_REPORT_TYPE' not described in enum 'rmi_f54_report_type' Cc: Dmitry Torokhov Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/rmi4/rmi_f54.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c index 6b23e679606ee..93b328c796c64 100644 --- a/drivers/input/rmi4/rmi_f54.c +++ b/drivers/input/rmi4/rmi_f54.c @@ -42,6 +42,8 @@ /** * enum rmi_f54_report_type - RMI4 F54 report types * + * @F54_REPORT_NONE: No Image Report. + * * @F54_8BIT_IMAGE: Normalized 8-Bit Image Report. The capacitance variance * from baseline for each pixel. * @@ -64,6 +66,10 @@ * Report. Set Low reference to its minimum value and high * references to its maximum value, then report the raw * capacitance for each pixel. + * + * @F54_MAX_REPORT_TYPE: + * Maximum number of Report Types. Used for sanity + * checking. */ enum rmi_f54_report_type { F54_REPORT_NONE = 0, From patchwork Wed Nov 4 16:24:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11881463 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B05FA921 for ; Wed, 4 Nov 2020 16:25:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A071206DB for ; Wed, 4 Nov 2020 16:25:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="naJ5FeJa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730978AbgKDQZ6 (ORCPT ); Wed, 4 Nov 2020 11:25:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730980AbgKDQZD (ORCPT ); Wed, 4 Nov 2020 11:25:03 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A488BC0401C4 for ; Wed, 4 Nov 2020 08:25:00 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id k10so21376011wrw.13 for ; Wed, 04 Nov 2020 08:25:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zwivgBdOs0zmcrd9rmzAZ3rcWWFWu9L80hhGgYgWXJ4=; b=naJ5FeJamZo4YFDvgyLGDdleJMHz+mOfR7xKKotIM//fvW4EGFDfXiNL/W1SBwtArU h82/fTZWWy+mhOqv1Ge/tf5IVIGnVx9RGmcLimmjoghPo7/HSX8py00JJ8yy+6rJs3kX l4w+bxtTF9Z0KsOXRZGk75ekO/OgGSwH5u4jFW3FGxuLBFV7a8QKnHS3mDDIF9PbcwOV 1JnxBeG3/3kUFpFnFskEbN65TmXUErcPAYKYunK9qQ1tnNjQwJcTzjXhSCW5FvuJgSDd OBBKFgs21L/EOUYJVQQtvaycqaOBN7mwPvVKdHzzoF5bLnkspt9WdSQvReKB28zDG93i WYfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zwivgBdOs0zmcrd9rmzAZ3rcWWFWu9L80hhGgYgWXJ4=; b=qe9ZxjlHkQvUlazJCCkqNx26039XlD3gFZV0svm45e3OE5dRyRzmwhYAdwMpp6Kztm XQmyd6KU3y8eO5yVdKHAbwrYMFKHOaS06KbzeNiSps7hTcl3kEp93gZGOdq4vGqK5edc tipzandWXqjvbqDPNUIhK99yCaLSePLBVfyYvIH1FYR74E+lD8gMH7kuLyPVs702SUEx Ea+jJvWicM3iImenmXusSka13RkzGIGbBbK2usC9agUHtJ7UREPu/wfBFHa4yupBBu0L x6DZb4CYfFI8Uy5WmE1vx1+b121KwSSkRpoEAHDcausLjYyHZzG/mRIbFjd6hMznd9FK /J1w== X-Gm-Message-State: AOAM530HPzjJt3/ExSfXeW04O33TYos/jUMNQjqqUSU2KNKuMef1R/Z8 Lu8AjaFyEocfffbC3/EygFjllQ== X-Google-Smtp-Source: ABdhPJwcC4S76QfH0IR6FW9cTE9tEsUkIsqeLxigoDJLm+uDBrv2Bzx7usaQ58fUHHC/fN/KKE8vYQ== X-Received: by 2002:a5d:5105:: with SMTP id s5mr2312563wrt.255.1604507099368; Wed, 04 Nov 2020 08:24:59 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id o129sm3008564wmb.25.2020.11.04.08.24.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:24:58 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Christopher Heiny , Andrew Duggan , linux-input@vger.kernel.org Subject: [PATCH 14/20] input: rmi4: rmi_i2c: Provide some missing descriptions for struct members Date: Wed, 4 Nov 2020 16:24:21 +0000 Message-Id: <20201104162427.2984742-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104162427.2984742-1-lee.jones@linaro.org> References: <20201104162427.2984742-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/rmi4/rmi_i2c.c:39: warning: Function parameter or member 'client' not described in 'rmi_i2c_xport' drivers/input/rmi4/rmi_i2c.c:39: warning: Function parameter or member 'supplies' not described in 'rmi_i2c_xport' drivers/input/rmi4/rmi_i2c.c:39: warning: Function parameter or member 'startup_delay' not described in 'rmi_i2c_xport' Cc: Dmitry Torokhov Cc: Christopher Heiny Cc: Andrew Duggan Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/rmi4/rmi_i2c.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/input/rmi4/rmi_i2c.c b/drivers/input/rmi4/rmi_i2c.c index a95c2c9bcab4c..50305fcfbef59 100644 --- a/drivers/input/rmi4/rmi_i2c.c +++ b/drivers/input/rmi4/rmi_i2c.c @@ -17,12 +17,16 @@ * struct rmi_i2c_xport - stores information for i2c communication * * @xport: The transport interface structure + * @client: The I2C client device structure * * @page_mutex: Locks current page to avoid changing pages in unexpected ways. * @page: Keeps track of the current virtual page * * @tx_buf: Buffer used for transmitting data to the sensor over i2c. * @tx_buf_size: Size of the buffer + * + * @supplies: Array of voltage regulators + * @startup_delay: Milliseconds to pause after powering up the regulators */ struct rmi_i2c_xport { struct rmi_transport_dev xport; From patchwork Wed Nov 4 16:24:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11881459 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8CFA714B4 for ; Wed, 4 Nov 2020 16:25:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BD4920786 for ; Wed, 4 Nov 2020 16:25:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lzCQLdZX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731124AbgKDQZz (ORCPT ); Wed, 4 Nov 2020 11:25:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730978AbgKDQZD (ORCPT ); Wed, 4 Nov 2020 11:25:03 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED05AC0401C6 for ; Wed, 4 Nov 2020 08:25:01 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id n15so22751073wrq.2 for ; Wed, 04 Nov 2020 08:25:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4GHOp4DltKz3i6bOt37UpUN4Df5qKRn7hwYhsGdTpAY=; b=lzCQLdZX72DPbrzpyO70KLlIhpN4uMbYtfbPZcWzETXAAxP1k6A+EH/fGbjr6jNaYC W9lEPRVXwQOTPZrb0nE9HVkdFt1oDyK2++3HF5hJI7qturNXgt823AurtYoLxyy643sA GLCQhg2Swsp6oLa9HY/H6NmgSFq3I61kHfEeVA53mm+f/3Sl7CZ3OtoKpVbJ9/omVpwL M38A7P+sEH2utR6YOdQ8chuHvsXFIkiHHcGPBrZr/BwD8QHNDb4MCA/Vgo/N/EG4u/Jn TIc3/v0bUHx93B5tcWh5TFBCHAJvg0jbeFLCTH2YbbPSiAfHI1Dv+twed+mbPtEm2ESQ nmdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4GHOp4DltKz3i6bOt37UpUN4Df5qKRn7hwYhsGdTpAY=; b=mD79Drq4/++g+Whpuu5q4BW3g6CtU+MlLYbMXETNaF+CQ10Mbsl1y1e/YJhrMCYsKi v1VrWLI9CpzuT4idQ7nwbtfmWxDxCvTmV4S5HI0+5YPuVTQ3jK+RbPhS1jCwA/82gPSx 2rX7epuP1WzJGHO6qWsqYbXNJ0lQfNTTbZrO8sMsB+mI9RlDHHaXuhfLLDSAQ8OZeycj bhy6BAhY9IpVBTtEtBkvGm3ybtrm2h1ct7rZMfE39gQEcbRwlngeCtHCQ3ReSEPlLPOB tReA3A0VXqKrARtpkK+pLr/G43An00Ob3Y7xeIpFDdMdg9aMAs6QmeOYB9GwF7RTQb4H 88Ew== X-Gm-Message-State: AOAM531NmFAD8sTVVXxJLg14/RJ/8G0egZSfQ6EYMeNH+QJ4kTIbx+1J JhoMf35SfpPLJjFBJBoysoLqgw== X-Google-Smtp-Source: ABdhPJxOo2g7lqHbzhI52bbzLERw4aq9EWSwSk1khVNfKk+K0uk2Mo7gSR3oOqhT5Z1sxUWzM7+5NA== X-Received: by 2002:adf:bd86:: with SMTP id l6mr34047834wrh.205.1604507100645; Wed, 04 Nov 2020 08:25:00 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id o129sm3008564wmb.25.2020.11.04.08.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:25:00 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Ferruh Yigit , Dmitry Torokhov , "at www.cypress.com" , linux-input@vger.kernel.org Subject: [PATCH 15/20] input: touchscreen: cyttsp4_core: Move 'cyttsp4_tch_abs_string' to the only file that references it Date: Wed, 4 Nov 2020 16:24:22 +0000 Message-Id: <20201104162427.2984742-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104162427.2984742-1-lee.jones@linaro.org> References: <20201104162427.2984742-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/input/touchscreen/cyttsp_i2c_common.c:24: drivers/input/touchscreen/cyttsp4_core.h:236:27: warning: ‘cyttsp4_tch_abs_string’ defined but not used [-Wunused-const-variable=] 236 | static const char const cyttsp4_tch_abs_string[] = { | ^~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/input/touchscreen/cyttsp4_i2c.c:17: drivers/input/touchscreen/cyttsp4_core.h:236:27: warning: ‘cyttsp4_tch_abs_string’ defined but not used [-Wunused-const-variable=] 236 | static const char * const cyttsp4_tch_abs_string[] = { | ^~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/input/touchscreen/cyttsp4_spi.c:17: drivers/input/touchscreen/cyttsp4_core.h:236:27: warning: ‘cyttsp4_tch_abs_string’ defined but not used [-Wunused-const-variable=] 236 | static const char * const cyttsp4_tch_abs_string[] = { | ^~~~~~~~~~~~~~~~~~~~~~ Cc: Ferruh Yigit Cc: Dmitry Torokhov Cc: "at www.cypress.com" Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/touchscreen/cyttsp4_core.c | 14 ++++++++++++++ drivers/input/touchscreen/cyttsp4_core.h | 14 -------------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/input/touchscreen/cyttsp4_core.c b/drivers/input/touchscreen/cyttsp4_core.c index 02a73d9a4defe..dccbcb942fe59 100644 --- a/drivers/input/touchscreen/cyttsp4_core.c +++ b/drivers/input/touchscreen/cyttsp4_core.c @@ -30,6 +30,20 @@ #define CY_CORE_STARTUP_RETRY_COUNT 3 +static const char * const cyttsp4_tch_abs_string[] = { + [CY_TCH_X] = "X", + [CY_TCH_Y] = "Y", + [CY_TCH_P] = "P", + [CY_TCH_T] = "T", + [CY_TCH_E] = "E", + [CY_TCH_O] = "O", + [CY_TCH_W] = "W", + [CY_TCH_MAJ] = "MAJ", + [CY_TCH_MIN] = "MIN", + [CY_TCH_OR] = "OR", + [CY_TCH_NUM_ABS] = "INVALID" +}; + static const u8 ldr_exit[] = { 0xFF, 0x01, 0x3B, 0x00, 0x00, 0x4F, 0x6D, 0x17 }; diff --git a/drivers/input/touchscreen/cyttsp4_core.h b/drivers/input/touchscreen/cyttsp4_core.h index f3e4443594404..6262f6e450751 100644 --- a/drivers/input/touchscreen/cyttsp4_core.h +++ b/drivers/input/touchscreen/cyttsp4_core.h @@ -233,20 +233,6 @@ enum cyttsp4_tch_abs { /* for ordering within the extracted touch data array */ CY_TCH_NUM_ABS }; -static const char * const cyttsp4_tch_abs_string[] = { - [CY_TCH_X] = "X", - [CY_TCH_Y] = "Y", - [CY_TCH_P] = "P", - [CY_TCH_T] = "T", - [CY_TCH_E] = "E", - [CY_TCH_O] = "O", - [CY_TCH_W] = "W", - [CY_TCH_MAJ] = "MAJ", - [CY_TCH_MIN] = "MIN", - [CY_TCH_OR] = "OR", - [CY_TCH_NUM_ABS] = "INVALID" -}; - struct cyttsp4_touch { int abs[CY_TCH_NUM_ABS]; }; From patchwork Wed Nov 4 16:24:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11881461 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CA3C91752 for ; Wed, 4 Nov 2020 16:25:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1E282072E for ; Wed, 4 Nov 2020 16:25:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Wr1VrvM2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731131AbgKDQZz (ORCPT ); Wed, 4 Nov 2020 11:25:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730983AbgKDQZD (ORCPT ); Wed, 4 Nov 2020 11:25:03 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C961C061A4A for ; Wed, 4 Nov 2020 08:25:03 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id w1so22744624wrm.4 for ; Wed, 04 Nov 2020 08:25:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=upETjiEPBAeYXJaDapQnz8RTaIUvobSDgtGDF4HQ8C4=; b=Wr1VrvM29yIcMiycLDDk50Vjw0jKq/vpiQh5ADfzp3wkEnC6Y7VqHn5MvUQQWlcoCM xxBaZpIlakYPU2h5u6qS7bReTt7UJVeMCBP9fMs3f1Q5zkpMw2gCxsIqqmNz9MzBBvwT MinQcwv7J/3tybf+gufIF+/77sfs6L5YtbrTw8TviyVXy7/zXk8B+dmCcs9IXyzLtU4P br8bofp41oUg+oGnQNlbdLQaVpu1aidRsUmHOcXcHp30ag7/6XLaeMK/VCCkVp2eBHnn N5+A4cMELZCbpNPEmtVgPBNOyMLyGExtwyumqlgjOMphImk6RN+4Q19NCtKvGbF1qCJc QNTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=upETjiEPBAeYXJaDapQnz8RTaIUvobSDgtGDF4HQ8C4=; b=lXxeqwrL6JTV5RYu/7EyAsBuwtYXl7U76QexdlrO6dPsDZYsUmMsp3uHRRoPcotzz5 D+zoUlZV2lspkTCq22t2aNJbZhQrLu+LwbwB+rdzNX+sQJwHZexrFImzkXdcHQUjKSsQ MPC0lRdJme7WtmK3l64LeiVOsxf+wyrbq+9e1MTHQCXCzXioi62jHHNWm9UhEyEyTPFM hz3ebxnjg7VeojPXoj+pk2sZgkgTftCOqjiBf6GX8N0fcYoLY7LpqzGQKEV+e25ofBHD vHfn92wuHE/jCSOveNMDj9C74GoUYbv2/TBxzhFOfpOhD0jlycBoWdPWmEDfOh7EdZjM TvmA== X-Gm-Message-State: AOAM533/vanSUPUTH78GY/vEWCCgxPC4s14vHPBLObKVeGWSo04hI+op 6K3k8ArvxhzcbLtwF8GVhNG2yQ== X-Google-Smtp-Source: ABdhPJzMUHJTxNM97Uu4GmPbwhCG+T4iv6uaRjx8TRLWALfVEZSpGRW/Yi9M8aDD+SY+aRUPVpI08g== X-Received: by 2002:adf:f841:: with SMTP id d1mr33437900wrq.297.1604507101738; Wed, 04 Nov 2020 08:25:01 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id o129sm3008564wmb.25.2020.11.04.08.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:25:01 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Dan Murphy , linux-input@vger.kernel.org Subject: [PATCH 16/20] input: misc: drv260x: Fix kernel-doc formatting and remove one abuse Date: Wed, 4 Nov 2020 16:24:23 +0000 Message-Id: <20201104162427.2984742-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104162427.2984742-1-lee.jones@linaro.org> References: <20201104162427.2984742-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'input_dev' not described in 'drv260x_data' drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'client' not described in 'drv260x_data' drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'regmap' not described in 'drv260x_data' drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'work' not described in 'drv260x_data' drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'enable_gpio' not described in 'drv260x_data' drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'regulator' not described in 'drv260x_data' drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'magnitude' not described in 'drv260x_data' drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'mode' not described in 'drv260x_data' drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'library' not described in 'drv260x_data' drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'rated_voltage' not described in 'drv260x_data' drivers/input/misc/drv260x.c:194: warning: Function parameter or member 'overdrive_voltage' not described in 'drv260x_data' drivers/input/misc/drv260x.c:244: warning: Function parameter or member 'voltage' not described in 'drv260x_calculate_voltage' Cc: Dmitry Torokhov Cc: Dan Murphy Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/misc/drv260x.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c index 79d7fa710a714..fabe106d499d4 100644 --- a/drivers/input/misc/drv260x.c +++ b/drivers/input/misc/drv260x.c @@ -167,17 +167,17 @@ /** * struct drv260x_data - - * @input_dev - Pointer to the input device - * @client - Pointer to the I2C client - * @regmap - Register map of the device - * @work - Work item used to off load the enable/disable of the vibration - * @enable_gpio - Pointer to the gpio used for enable/disabling - * @regulator - Pointer to the regulator for the IC - * @magnitude - Magnitude of the vibration event - * @mode - The operating mode of the IC (LRA_NO_CAL, ERM or LRA) - * @library - The vibration library to be used - * @rated_voltage - The rated_voltage of the actuator - * @overdriver_voltage - The over drive voltage of the actuator + * @input_dev: Pointer to the input device + * @client: Pointer to the I2C client + * @regmap: Register map of the device + * @work: Work item used to off load the enable/disable of the vibration + * @enable_gpio: Pointer to the gpio used for enable/disabling + * @regulator: Pointer to the regulator for the IC + * @magnitude: Magnitude of the vibration event + * @mode: The operating mode of the IC (LRA_NO_CAL, ERM or LRA) + * @library: The vibration library to be used + * @rated_voltage: The rated_voltage of the actuator + * @overdriver_voltage: The over drive voltage of the actuator **/ struct drv260x_data { struct input_dev *input_dev; @@ -234,12 +234,12 @@ static const struct reg_default drv260x_reg_defs[] = { #define DRV260X_DEF_RATED_VOLT 0x90 #define DRV260X_DEF_OD_CLAMP_VOLT 0x90 -/** +/* * Rated and Overdriver Voltages: * Calculated using the formula r = v * 255 / 5.6 * where r is what will be written to the register * and v is the rated or overdriver voltage of the actuator - **/ + */ static int drv260x_calculate_voltage(unsigned int voltage) { return (voltage * 255 / 5600); From patchwork Wed Nov 4 16:24:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11881455 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 76689921 for ; Wed, 4 Nov 2020 16:25:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 505C7206D4 for ; Wed, 4 Nov 2020 16:25:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="r3DtYquA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731089AbgKDQZo (ORCPT ); Wed, 4 Nov 2020 11:25:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730987AbgKDQZE (ORCPT ); Wed, 4 Nov 2020 11:25:04 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F556C061A4D for ; Wed, 4 Nov 2020 08:25:04 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id e2so2901848wme.1 for ; Wed, 04 Nov 2020 08:25:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gEEnx9N3Q6ff4TorTnZ32g1gwXsaI47EH/IMR+WZidg=; b=r3DtYquA9eQDmSD8EW1+bhREgzlV6LvrBBEaMbs2ZbGnZsxd0B7Ny0INQFWdj3D7Na +4/kMzSys6PKK6/3Q+brrOCiFFXgVcRSS0g9J2h0BRu2LesSSz1RTSA6+EwH+1kOdqOL NGVUxj8cRbOkhi5UKo572NgzFqy3prqW+s9PkrrTH+dcoZ/YvXouI43w3qeH7oyL2qPy yP22JD5q8Qa07DTRK/ia+yqxjglgJ/SbUkZqBEszmFT99IykGP8hrbG7yRBlqGoxQKNf MWz0D5Y3JJhf0fKqQvLr/bEdd3+B8Vx/B0sVnb0oBhHFDwDhBpdsdsIPV5Gv03+lAu19 J8bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gEEnx9N3Q6ff4TorTnZ32g1gwXsaI47EH/IMR+WZidg=; b=eKRbEvadLFvvZa7oKytk+Ph84rPBIhKzFKySVQReuitUD/QOFbyTlFiffNDEYQdSAs mV8bX/r9PH8oSHxFfG0HdqxgF/wCC1YbdHmjo91pzlTJga9shtkN+xbhV/YNAM+OF37h tzH47ycK7ulRqfwJy0OBI5PGTwOdQUuA4bkiG+rVHBee9mqOmrUxLLMnK8Oi8MW4+enC r2PQbOJ3ksMFPne/4CQ6RO3zs1FshKdAoXhl5j6/HBgEss/CFt6mXlzXaofjP1pZw6+w Ztd8SG9YgYUQrvQ3Ta2E4Qvk015zD8x74J17sx8yIr6SB5Ba43Sz4UAOwj9+LehM+BTG 42Ww== X-Gm-Message-State: AOAM532Tn6VHpX9gNbYqih8bo05v9cs3wjElE9cVZ/rJWWEvCso/yH7+ 0ATikHiuXoixCewqOGwHTtnnQA== X-Google-Smtp-Source: ABdhPJxGqzrZnMIGaRg5z6soxSJjVletd47ti4DjCQzkqa4Lt8eafXod2NPLJ+2rqaagHZWPvAoFRw== X-Received: by 2002:a1c:2d5:: with SMTP id 204mr5624113wmc.181.1604507102814; Wed, 04 Nov 2020 08:25:02 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id o129sm3008564wmb.25.2020.11.04.08.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:25:02 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Dan Murphy , linux-input@vger.kernel.org Subject: [PATCH 17/20] input: misc: drv2665: Fix formatting expected by kernel-doc Date: Wed, 4 Nov 2020 16:24:24 +0000 Message-Id: <20201104162427.2984742-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104162427.2984742-1-lee.jones@linaro.org> References: <20201104162427.2984742-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/misc/drv2665.c:59: warning: Function parameter or member 'input_dev' not described in 'drv2665_data' drivers/input/misc/drv2665.c:59: warning: Function parameter or member 'client' not described in 'drv2665_data' drivers/input/misc/drv2665.c:59: warning: Function parameter or member 'regmap' not described in 'drv2665_data' drivers/input/misc/drv2665.c:59: warning: Function parameter or member 'work' not described in 'drv2665_data' drivers/input/misc/drv2665.c:59: warning: Function parameter or member 'regulator' not described in 'drv2665_data' Cc: Dmitry Torokhov Cc: Dan Murphy Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/misc/drv2665.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/input/misc/drv2665.c b/drivers/input/misc/drv2665.c index 918ad9c3fa812..0e65ab180f499 100644 --- a/drivers/input/misc/drv2665.c +++ b/drivers/input/misc/drv2665.c @@ -44,11 +44,11 @@ /** * struct drv2665_data - - * @input_dev - Pointer to the input device - * @client - Pointer to the I2C client - * @regmap - Register map of the device - * @work - Work item used to off load the enable/disable of the vibration - * @regulator - Pointer to the regulator for the IC + * @input_dev: Pointer to the input device + * @client: Pointer to the I2C client + * @regmap: Register map of the device + * @work: Work item used to off load the enable/disable of the vibration + * @regulator: Pointer to the regulator for the IC */ struct drv2665_data { struct input_dev *input_dev; From patchwork Wed Nov 4 16:24:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11881451 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0EF0314B4 for ; Wed, 4 Nov 2020 16:25:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E132B206DB for ; Wed, 4 Nov 2020 16:25:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n7NvpaRz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730918AbgKDQZc (ORCPT ); Wed, 4 Nov 2020 11:25:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731001AbgKDQZG (ORCPT ); Wed, 4 Nov 2020 11:25:06 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88126C0613D3 for ; Wed, 4 Nov 2020 08:25:05 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id b8so22723023wrn.0 for ; Wed, 04 Nov 2020 08:25:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HLzGMSztWgz07v35Jtjii54NsFsWwuKNfNPhB7AbpDE=; b=n7NvpaRz/v65F5A+1qpFB3soNR/82EQVavWkMbv96kAU4YMRJbHd7l3KsRnNOodaPZ PemLn7Ogcq8PM1/Cr8PBTg5wleTXiAy+X/wEABMnNLO1EnonfgTbrCDp1uA9h8tDB+A1 oKIKOB8lXxRPgeUtHqOicYWZHvQrn4DfyOPk9iRiEsz1obM2VLKogw0LiVmh9tKMn0Vm viL0HhslU49iVhExW1VzATOOLkR4TvgAykDcbPXyV6NKK9e87yF1sPNwEsvOwYMVy3S7 hBW6/vMbuq7WlQhnD46vMUc24C2aOFVnoIVe5BPNiIQ0+fmfn82uFyY2ocqau7nFmDAG kpJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HLzGMSztWgz07v35Jtjii54NsFsWwuKNfNPhB7AbpDE=; b=oVmF8FaRB978GtVe+3n6XxEV5+XiQlS2KLFOHH0LlRPfcbOAJ8gf5yqgwG06RPObIj z1YALtAXWOnty0NKs4nL6FzJrKJ2qkuRWx4IstFpc+L3RRntRASD7rChRy+zi+kYNR9K szTEY6aLq55C2X/uu2zNNqTllBcA50wL2p6WUkK542j1IqfrG6xCfEiyjBBtBs0W7pHY zq5i/F3rVwmrIhTcLi5P3P0ZGeXO6sfjGttvOplvpgMjUMGGx5d++1cDBMo/cHT7i9rS mlx0jWu5xE9/kTHTy9AbxV2+IAT5E1j8t10PsWcTYsEYuoxQM2SWmRrmEFNeILavwjap Y6Mg== X-Gm-Message-State: AOAM530xhlj7qbTy3Bw2l6cxHNpAKTkLa/apawxt2QIaUwUTH0p91MXZ HYontyUhK4UVQWW+5T++kIiAbkmSWJo152k1 X-Google-Smtp-Source: ABdhPJzLYp68/eaXS5ETCQ873RexEl3JnFhUYZxhzam7N4Xf6ESKsOWLHSsfiMqVIIm42mZ0zk2Ozw== X-Received: by 2002:adf:ce91:: with SMTP id r17mr34508537wrn.326.1604507104315; Wed, 04 Nov 2020 08:25:04 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id o129sm3008564wmb.25.2020.11.04.08.25.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:25:03 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Dan Murphy , linux-input@vger.kernel.org Subject: [PATCH 18/20] input: misc: drv2667: Fix formatting and add missing member docs Date: Wed, 4 Nov 2020 16:24:25 +0000 Message-Id: <20201104162427.2984742-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104162427.2984742-1-lee.jones@linaro.org> References: <20201104162427.2984742-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'input_dev' not described in 'drv2667_data' drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'client' not described in 'drv2667_data' drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'regmap' not described in 'drv2667_data' drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'work' not described in 'drv2667_data' drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'regulator' not described in 'drv2667_data' drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'page' not described in 'drv2667_data' drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'magnitude' not described in 'drv2667_data' drivers/input/misc/drv2667.c:109: warning: Function parameter or member 'frequency' not described in 'drv2667_data' Cc: Dmitry Torokhov Cc: Dan Murphy Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/misc/drv2667.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/input/misc/drv2667.c b/drivers/input/misc/drv2667.c index bb9d5784df17d..dc19eb6a8713f 100644 --- a/drivers/input/misc/drv2667.c +++ b/drivers/input/misc/drv2667.c @@ -90,12 +90,14 @@ /** * struct drv2667_data - - * @input_dev - Pointer to the input device - * @client - Pointer to the I2C client - * @regmap - Register map of the device - * @work - Work item used to off load the enable/disable of the vibration - * @regulator - Pointer to the regulator for the IC - * @magnitude - Magnitude of the vibration event + * @input_dev: Pointer to the input device + * @client: Pointer to the I2C client + * @regmap: Register map of the device + * @work: Work item used to off load the enable/disable of the vibration + * @regulator: Pointer to the regulator for the IC + * @page: Page number + * @magnitude: Magnitude of the vibration event + * @frequency: Frequency of the vibration event **/ struct drv2667_data { struct input_dev *input_dev; From patchwork Wed Nov 4 16:24:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11881445 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6AF341752 for ; Wed, 4 Nov 2020 16:25:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45C962074B for ; Wed, 4 Nov 2020 16:25:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LTaYEiE1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731005AbgKDQZY (ORCPT ); Wed, 4 Nov 2020 11:25:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731021AbgKDQZI (ORCPT ); Wed, 4 Nov 2020 11:25:08 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0023C0613D4 for ; Wed, 4 Nov 2020 08:25:06 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id e2so2902003wme.1 for ; Wed, 04 Nov 2020 08:25:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pzzgIIrLdF8ykN8u3cmmBIEsZtdCUyU67RK6IptSh0I=; b=LTaYEiE1iRu0RgzvlDDLlI7NXWBMFl8leMa2AJcx94kVBdqeKoOZg73o3NgB6i5xKE QW8+vYVvu65g10XKy2s+CLasqSTL7FsBQ/fAugv1JCZyaRrhl1eJyvnv9T5EFQDkq+Q8 hqevmPcln8KUaoj0D98n72cGJK81JEs2P1A3rvNSVqrYHK1dLkfMDdz5whaE9u0qjLq3 KcSrG8Wdw2PpFkLcHPsi6HNsV4pWZ5kM5d4aOBE7vhYRv50uEbVsPUSNYYukoIxZt8YL Bf6dqx+6FKzq7vqgr4n1c7GHu2re9sGE47pmCrHgPcm8NLr5Xl+MoAb0kcGmPL+dS1uo PArw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pzzgIIrLdF8ykN8u3cmmBIEsZtdCUyU67RK6IptSh0I=; b=sI94ErsRYokBkAVK/UDiUm7H2VPf+LGdou43IqQwwQHZWAIwWWHUi95EbyWVwdAWfI oTUcFZBXOVsJ5QqKgwyn1uNQfMu20h9c32NUO+gJfxyO0Rz/3lebA6g/xSAfTcjkSiEt Cr64jG0QxOT7c5SEYo5HNt8XJO3PzL6lGVqdMawScVs8TIICRmtitdLbr35e2+0w5Djy AYJb3bz68Y08Wci5AP7sL1uiC7zRzK6i587wD1UI9vK/otKx+6ny5UX8z+NaNiMSzse9 3u0N9Y5kqwLkKpxp0DdPXjmFmlMR/bwOIzgT/so5+SxFTxgH79l9zfGSNRxxVeWE9DUH pKDg== X-Gm-Message-State: AOAM532LToidOSMCtne8CGCUOwR+xnEzbeKURpbOohTAs0Wr8Cg9VjdJ wP1SwQG8xBi7/ZDaWnoMS68gVQ== X-Google-Smtp-Source: ABdhPJxKrOSvHcePAUxBziapSUMd6iVGO2PGQTlj2QxxJ8/xho0A9F6lpZwcx365YE5E8QDiS0LVJg== X-Received: by 2002:a1c:84:: with SMTP id 126mr3537081wma.160.1604507105380; Wed, 04 Nov 2020 08:25:05 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id o129sm3008564wmb.25.2020.11.04.08.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:25:04 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Kumar G , Sundar Iyer , linux-input@vger.kernel.org Subject: [PATCH 19/20] input: keyboard: nomadik-ske-keypad: Provide some missing struct member docs Date: Wed, 4 Nov 2020 16:24:26 +0000 Message-Id: <20201104162427.2984742-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104162427.2984742-1-lee.jones@linaro.org> References: <20201104162427.2984742-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/keyboard/nomadik-ske-keypad.c:71: warning: Function parameter or member 'pclk' not described in 'ske_keypad' drivers/input/keyboard/nomadik-ske-keypad.c:71: warning: Function parameter or member 'ske_keypad_lock' not described in 'ske_keypad' Cc: Dmitry Torokhov Cc: Kumar G Cc: Sundar Iyer Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/keyboard/nomadik-ske-keypad.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/input/keyboard/nomadik-ske-keypad.c b/drivers/input/keyboard/nomadik-ske-keypad.c index 608446e14614d..0d55a95347f16 100644 --- a/drivers/input/keyboard/nomadik-ske-keypad.c +++ b/drivers/input/keyboard/nomadik-ske-keypad.c @@ -58,6 +58,8 @@ * @board: keypad platform device * @keymap: matrix scan code table for keycodes * @clk: clock structure pointer + * @pclk: clock structure pointer + * @ske_keypad_lock: spinlock protecting the keypad read/writes */ struct ske_keypad { int irq; From patchwork Wed Nov 4 16:24:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11881447 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 142A014B4 for ; Wed, 4 Nov 2020 16:25:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2F2E206A5 for ; Wed, 4 Nov 2020 16:25:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gQK/xp85" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731018AbgKDQZY (ORCPT ); Wed, 4 Nov 2020 11:25:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731016AbgKDQZI (ORCPT ); Wed, 4 Nov 2020 11:25:08 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF7F5C061A4A for ; Wed, 4 Nov 2020 08:25:07 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id p19so2221301wmg.0 for ; Wed, 04 Nov 2020 08:25:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TUgG9h/tqc78+buLe1wAWz/4+Vyvpx2KQ686RNHflno=; b=gQK/xp857nk6m1GRx6GUgrGDA+ULtaOWWxe8LqhpsySyUVzL5isfOvta12JVHGrOJi gzBr4aR2aznK/K+av2uj6BCAZCJNtzWBsQqjFjtp6dh0FLh1MhVneHsELlJiU7Ih9dUk FKTIqlsTU/SYXYkqDlpwcuf3ZqNxQhPwOwmnyu180LS7IiFEz/iG+niRZdPqyM9XFa9y xRGeC2Vzg26JaeztJ6SM5pIj6YPKOxEoyad7HJFWZZlp8ZD5wrR1u8GSb2/bXLIRBguK gWWDG+1zfCdjrgaQyjm1rPrJxyPGuIO+GSPa4vDVX3sbVw8pQEOuOxkm/1ByPEO3n090 YUOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TUgG9h/tqc78+buLe1wAWz/4+Vyvpx2KQ686RNHflno=; b=ZuCy/4u3OSHi/RDnzd5U7eNLZChEameA4LiLc17i29rHhm8d3xvga6MWW9Iuny0U8w +GFgFO+5ccFnCAWgnU/UvwZX5Q5x0t1SDBC9DZcJHHIC2kWgMYMe1YoAak2D2A8MiHm4 R6u1gV4smldshdTli+GZcQ2Rvyg0VVKxMhhJ4WNySuHQJm3QK8RbDJcp25o7WtvvVrCY 0c6AGUCi9nNhTramZdgGhBaStu7pb8gkdc23ABW8obUKJ2a2lCOyaf1PIeat7w+L5Hoz TZFPISL9Y604lFt2Mb+N9iTjNO8zzNX5v5avNp/M7A0flHIhhaa8JZWlNyPYmVWBc/ll rDPQ== X-Gm-Message-State: AOAM531ENXxVXKTZUkhDzPb/gaY9cRB0+jqrMF8OyFhLl2q7Iop1/w3Z pHM6Nn+oY46+6YrsV8I1O8GhIA== X-Google-Smtp-Source: ABdhPJxVaASBytTSgq8ExCJqrw3ThXNu25G6bOifGtb0/Nz2b6YDRxmAq3xZ/yDVcMCCuomPSAvHhg== X-Received: by 2002:a1c:9c51:: with SMTP id f78mr5726303wme.189.1604507106433; Wed, 04 Nov 2020 08:25:06 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id o129sm3008564wmb.25.2020.11.04.08.25.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 08:25:05 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Trilok Soni , linux-input@vger.kernel.org Subject: [PATCH 20/20] input: keyboard: pmic8xxx-keypad: Fix kernel-doc formatting Date: Wed, 4 Nov 2020 16:24:27 +0000 Message-Id: <20201104162427.2984742-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104162427.2984742-1-lee.jones@linaro.org> References: <20201104162427.2984742-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'num_rows' not described in 'pmic8xxx_kp' drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'num_cols' not described in 'pmic8xxx_kp' drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'input' not described in 'pmic8xxx_kp' drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'regmap' not described in 'pmic8xxx_kp' drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'key_sense_irq' not described in 'pmic8xxx_kp' drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'key_stuck_irq' not described in 'pmic8xxx_kp' drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'keycodes' not described in 'pmic8xxx_kp' drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'dev' not described in 'pmic8xxx_kp' drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'keystate' not described in 'pmic8xxx_kp' drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'stuckstate' not described in 'pmic8xxx_kp' drivers/input/keyboard/pmic8xxx-keypad.c:106: warning: Function parameter or member 'ctrl_reg' not described in 'pmic8xxx_kp' Cc: Dmitry Torokhov Cc: Trilok Soni Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/keyboard/pmic8xxx-keypad.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/input/keyboard/pmic8xxx-keypad.c b/drivers/input/keyboard/pmic8xxx-keypad.c index 91d5811d6f0e1..36bee6f5a8af0 100644 --- a/drivers/input/keyboard/pmic8xxx-keypad.c +++ b/drivers/input/keyboard/pmic8xxx-keypad.c @@ -76,17 +76,17 @@ /** * struct pmic8xxx_kp - internal keypad data structure - * @num_cols - number of columns of keypad - * @num_rows - number of row of keypad - * @input - input device pointer for keypad - * @regmap - regmap handle - * @key_sense_irq - key press/release irq number - * @key_stuck_irq - key stuck notification irq number - * @keycodes - array to hold the key codes - * @dev - parent device pointer - * @keystate - present key press/release state - * @stuckstate - present state when key stuck irq - * @ctrl_reg - control register value + * @num_cols: number of columns of keypad + * @num_rows: number of row of keypad + * @input: input device pointer for keypad + * @regmap: regmap handle + * @key_sense_irq: key press/release irq number + * @key_stuck_irq: key stuck notification irq number + * @keycodes: array to hold the key codes + * @dev: parent device pointer + * @keystate: present key press/release state + * @stuckstate: present state when key stuck irq + * @ctrl_reg: control register value */ struct pmic8xxx_kp { unsigned int num_rows;