From patchwork Fri Nov 2 18:10:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 10665973 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 685CB13B5 for ; Fri, 2 Nov 2018 18:10:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 50E532C135 for ; Fri, 2 Nov 2018 18:10:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4578E2C515; Fri, 2 Nov 2018 18:10:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DA3B12C53E for ; Fri, 2 Nov 2018 18:10:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=3YePW5Y3dzq5Zwrjj8zNvi3GliRODfoVP+wPjB5943M=; b=I5WLC4hpTbjlMP p0r3mwPJvAcj55/sREQbeNNkgh2V8tL635L4gtRVQBfqGEcaBV5+m/EWRDFbwh64a5hL8ZM1kBePT HRyM0xMIQSIJMZT510IGGPrt25259/ZHF2azWylxEyecLWggHilhWttWNX0yDHkWJC+ITpFXbfs1V IKomEj2vHU2Ujf93GijLnyjFoqNyy5wsjRMjsZM0238wUOIP9M+MVculi0jl244m15X5S4UfQzc8v esfiIb9aMLKB3FGAXpfMw35O+lpgI4ASxvdV9xZq8o23iUrqevHq0bL/7RmGskr/FRnjQo1+y0c7C FazC8dfHZOqbD/Ib6G2Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gIdtk-0006yG-7R; Fri, 02 Nov 2018 18:10:20 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gIdth-0005vF-3K for ath10k@lists.infradead.org; Fri, 02 Nov 2018 18:10:18 +0000 Received: by mail-pf1-x442.google.com with SMTP id j13-v6so1362612pff.11 for ; Fri, 02 Nov 2018 11:10:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Lat4TpCI71/3cxlaRQGsbFWbxSR9AgcpXz1+oAxrm0Y=; b=JlUg71d78M20dRhF3abONh16OyZZ6hGn10nWoVIYrTs+kloTHIlkB0hYXV8ABn8HUf +jxdSSL58CyFJwoxJNDmfezndYtMYuQAoS17Bi/8F+n7Z9ssA7Mgoq+VRO4OsowfNzBe oBh/WxW9lZxW8cx5gr9YNiUnao6X5xZCjb/mA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Lat4TpCI71/3cxlaRQGsbFWbxSR9AgcpXz1+oAxrm0Y=; b=GCSUgZVWdYnujDHujnJHQ39nHI0MfydW7hEsg9SfE71IkvIdATzls3E3jDo75QzsqI cS9uviK0+QuHytRhfP/IdMJmIHVNPfHIkR1gw8LVcteYwAF3+D46O3fpXfxp/7eH34jI nVwIlCx+OyU3Q+Fed1oUAeVsuXI30DTSJa8TfvxdFT5ysFrFCZqBFGJK46pj7Lpob7n6 rD+IcsmEEDLvUXiQyFDD1Lylsnvz7R4CTsshwrvREmu9ymxz4EHi5/85oXQ1+KEFWXEM 6ulaYix0JvRRP7+VjR1pZLnW7fZMX6e4JrxGXX6a9S47mjcgRB84pRvsxICzlqJJI75M Fh/g== X-Gm-Message-State: AGRZ1gKaJBfpqIl59VkhDDv1m1q+phYl0QCB1KRnH1TXA+OV+YGz8U2b T+Q8YlRGqcOUiOHixbcc2MEW8pu2ABU= X-Google-Smtp-Source: AJdET5ear+DAfnKHu+mWQJNUvZpDYVCwlDRtBn9YycyQ46lvtEQp7LcrAAuB20DtGnLzCei0Bm7/KA== X-Received: by 2002:a63:4e41:: with SMTP id o1mr12084835pgl.282.1541182205540; Fri, 02 Nov 2018 11:10:05 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:1:299d:6b87:5478:d28a]) by smtp.gmail.com with ESMTPSA id y184sm2416357pgd.71.2018.11.02.11.10.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Nov 2018 11:10:03 -0700 (PDT) From: Brian Norris To: ath10k@lists.infradead.org Subject: [PATCH] ath10k: ath10k_snoc_{read,write}32() should be static Date: Fri, 2 Nov 2018 11:10:00 -0700 Message-Id: <20181102181000.96834-1-briannorris@chromium.org> X-Mailer: git-send-email 2.19.1.930.g4563a0d9d0-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181102_111017_140420_BE8A020C X-CRM114-Status: UNSURE ( 9.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Brian Norris , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP They're provided as callbacks in ath10k_hif_ops and should be accessed that way, if needed outside of snoc.c, and anyway, they're currently unused outside snoc.c. Signed-off-by: Brian Norris --- drivers/net/wireless/ath/ath10k/snoc.c | 4 ++-- drivers/net/wireless/ath/ath10k/snoc.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index ffdebf9a5ac6..5b37a0c68be6 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.c +++ b/drivers/net/wireless/ath/ath10k/snoc.c @@ -474,14 +474,14 @@ static struct service_to_pipe target_service_to_ce_map_wlan[] = { }, }; -void ath10k_snoc_write32(struct ath10k *ar, u32 offset, u32 value) +static void ath10k_snoc_write32(struct ath10k *ar, u32 offset, u32 value) { struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar); iowrite32(value, ar_snoc->mem + offset); } -u32 ath10k_snoc_read32(struct ath10k *ar, u32 offset) +static u32 ath10k_snoc_read32(struct ath10k *ar, u32 offset) { struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar); u32 val; diff --git a/drivers/net/wireless/ath/ath10k/snoc.h b/drivers/net/wireless/ath/ath10k/snoc.h index e1d2d6675556..de077bc8bc74 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.h +++ b/drivers/net/wireless/ath/ath10k/snoc.h @@ -91,8 +91,6 @@ static inline struct ath10k_snoc *ath10k_snoc_priv(struct ath10k *ar) return (struct ath10k_snoc *)ar->drv_priv; } -void ath10k_snoc_write32(struct ath10k *ar, u32 offset, u32 value); -u32 ath10k_snoc_read32(struct ath10k *ar, u32 offset); int ath10k_snoc_fw_indication(struct ath10k *ar, u64 type); #endif /* _SNOC_H_ */