From patchwork Thu Nov 5 21:47:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11885315 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 76F18921 for ; Thu, 5 Nov 2020 21:47:36 +0000 (UTC) Received: by mail.kernel.org (Postfix) id 7122020756; Thu, 5 Nov 2020 21:47:36 +0000 (UTC) Delivered-To: soc@kernel.org Received: from localhost.localdomain (adsl-84-226-167-205.adslplus.ch [84.226.167.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 157D920728; Thu, 5 Nov 2020 21:47:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604612856; bh=Bh7VT9rBifHunoUtTj+bD6flceXhqeAe3vYTTwNZyyY=; h=From:List-Id:To:Cc:Subject:Date:From; b=SEja8IxC2FpvOxc+cNzPw+iQmW1rLt38nznh8xQ3IiNlr2t2L0YRpv0CIAPFzOPvg a4WPFiQ1rNayowRz38pmNFLbrfBaPv5fASeY2V3SWi9RHsONy7uZ9FKxHJO9VCtUkA 4b+BY2WBjT/O8tSiAMJeFaiGssPllRTU9+swPmaA= From: Krzysztof Kozlowski List-Id: To: arm@kernel.org, soc@kernel.org, Arnd Bergmann , Olof Johansson Cc: Krzysztof Kozlowski , Marek Szyprowski Subject: [PATCH fix for v5.10] ARM: dts: exynos: revert "add input clock to CMU in Exynos4412 Odroid" Date: Thu, 5 Nov 2020 22:47:02 +0100 Message-Id: <20201105214702.2738-1-krzk@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 This reverts commit eaf2d2f6895d676dda6c95a652b58594f2887720. The commit eaf2d2f6895d ("ARM: dts: exynos: add input clock to CMU in Exynos4412 Odroid") breaks probing of usb3503 USB hub on Odroid U3. It changes the order of clock drivers probe: the clkout (Exynos PMU) driver is probed before the main clk-exynos4 driver. The clkout driver on Exynos4412 depends on clk-exynos4 but it does not support deferred probe, therefore this dependency and changed probe order causes probe failure. The usb3503 USB hub on Odroid U3 on the other hand requires clkout clock. This can be seen in logs: [ 5.007442] usb3503 0-0008: unable to request refclk (-517) Reported-by: Marek Szyprowski Signed-off-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20200921174818.15525-1-krzk@kernel.org --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi index ab291cec650a..2983e91bc7dd 100644 --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi @@ -122,7 +122,6 @@ &camera { }; &clock { - clocks = <&clock CLK_XUSBXTI>; assigned-clocks = <&clock CLK_FOUT_EPLL>; assigned-clock-rates = <45158401>; };