From patchwork Sun Nov 8 16:25:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 11889703 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7976114C0 for ; Sun, 8 Nov 2020 16:25:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 501EC208B6 for ; Sun, 8 Nov 2020 16:25:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hkqc6KqA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727929AbgKHQZy (ORCPT ); Sun, 8 Nov 2020 11:25:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726388AbgKHQZx (ORCPT ); Sun, 8 Nov 2020 11:25:53 -0500 Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DD64C0613CF; Sun, 8 Nov 2020 08:25:53 -0800 (PST) Received: by mail-oi1-x241.google.com with SMTP id j7so7388018oie.12; Sun, 08 Nov 2020 08:25:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=y7H39mVcek5Gfl56DHtreNxTggw3nG3wMjBDYefwKcM=; b=Hkqc6KqANTQA9J7hn0qNGLRUAlI789x2UIJoG5SaxN+GcRD9H4JuunadDC/f25iian UKfA3zzoidXobrURZ95TdiBLmAObXjFkE5urNHNz1C+R5ZvlPFu9pJidxArPWoBWR2yG g/wXN475xGRXQTp+I+iZIGaagirPaRbHUkxhCJkPnhkvSMw70gsQA1Z+k71AYwRlF0f8 HxTP5Tn+s+vwzYPgPuiKqLm9d3RNBX9OKWYnOvzDNgOr/R/qmKW5pLfijEMjUJPazela vtBfE7TTJpp7HsKGRGmP8l2OOPTesgwKNzlQ9hEsXxiWtpg+fPBQ7s+xJA2DUTX89hfG I/pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=y7H39mVcek5Gfl56DHtreNxTggw3nG3wMjBDYefwKcM=; b=C2jXRgiJqY+QatZksEZFbqWx0HScagKBhc3a6t4cNm/simvANtmUUQ4KIg9rzJofC0 SjE0MiKjnBZ1r0YTOLOyILvWQdzpPgb8ab56OxdftKdVbXvXxXOVw60K2fQ81YBYunjV /MuteQr0uoSqM24VwVT5HHkCkY1wuXk56eexcCHOg9IuRqDvjEv9jNtlr1iOjAsYb3hv OVuoUInUx6J3dcryL7VW7TBX+gofnpTLCO5OU8etf89KMoMo37SiBoe9MQmA7BKxhZjt oLndphgM4LGXh5WgVQ6UB0lD3ZvS2tWKZIHWP+5NwH3D8NYAMAwEbJuovyP00LtA8Wj0 I2TA== X-Gm-Message-State: AOAM5315DbzovSnYx0glOvsNLkQs6MxZ98FFxSD7K1GPhm+nhWNKxC2u fGQVM7ayb+x+UHFXQs1WHM8= X-Google-Smtp-Source: ABdhPJxnrrMiXp39hxTKAWz6CjXselwNzDcNG3ayrWRQORvL9ZhRgigY1R9QPVpjInU+cePYhVEkDw== X-Received: by 2002:aca:ed06:: with SMTP id l6mr6629612oih.2.1604852752994; Sun, 08 Nov 2020 08:25:52 -0800 (PST) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id w18sm1875348otl.38.2020.11.08.08.25.52 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 08 Nov 2020 08:25:52 -0800 (PST) Sender: Guenter Roeck From: Guenter Roeck To: Wim Van Sebroeck Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck Subject: [PATCH 1/2] watchdog: armada_37xx: Add missing dependency on HAS_IOMEM Date: Sun, 8 Nov 2020 08:25:49 -0800 Message-Id: <20201108162550.27660-1-linux@roeck-us.net> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org The following kbuild warning is seen on a system without HAS_IOMEM. WARNING: unmet direct dependencies detected for MFD_SYSCON Depends on [n]: HAS_IOMEM [=n] Selected by [y]: - ARMADA_37XX_WATCHDOG [=y] && WATCHDOG [=y] && (ARCH_MVEBU || COMPILE_TEST This results in a subsequent compile error. drivers/watchdog/armada_37xx_wdt.o: in function `armada_37xx_wdt_probe': armada_37xx_wdt.c:(.text+0xdc): undefined reference to `devm_ioremap' Add the missing dependency. Reported-by: Necip Fazil Yildiran Fixes: 54e3d9b518c8 ("watchdog: Add support for Armada 37xx CPU watchdog") Signed-off-by: Guenter Roeck --- drivers/watchdog/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index fd7968635e6d..b3e8bdaa2a11 100644 --- a/drivers/watchdog/Kconfig +++ b/drivers/watchdog/Kconfig @@ -386,6 +386,7 @@ config ARM_SBSA_WATCHDOG config ARMADA_37XX_WATCHDOG tristate "Armada 37xx watchdog" depends on ARCH_MVEBU || COMPILE_TEST + depends on HAS_IOMEM select MFD_SYSCON select WATCHDOG_CORE help From patchwork Sun Nov 8 16:25:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 11889705 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A7E0C1130 for ; Sun, 8 Nov 2020 16:25:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8AB80221E9 for ; Sun, 8 Nov 2020 16:25:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GOe94XS3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728608AbgKHQZ4 (ORCPT ); Sun, 8 Nov 2020 11:25:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726388AbgKHQZz (ORCPT ); Sun, 8 Nov 2020 11:25:55 -0500 Received: from mail-ot1-x344.google.com (mail-ot1-x344.google.com [IPv6:2607:f8b0:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63093C0613CF; Sun, 8 Nov 2020 08:25:55 -0800 (PST) Received: by mail-ot1-x344.google.com with SMTP id g19so6251151otp.13; Sun, 08 Nov 2020 08:25:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=JwSH2aVoTO9OLiW27hN/IDvEgg/U4tZOFYArTi8XkLg=; b=GOe94XS3oWbAYmrseJkNCISMhHNI7+KTRl33h5D+p/wTFJlVDspXHDlHSIBxj2E2Vs ciy6j1iYFq56FoedCiq9XOo5XrtAjXMV/9dblprFgYgX9rPi8r7xigVdTefTiYANqIGa n21eEzyBaIcsjFyeV89SVNEpwWnmHW1VHPPlGLDdKm4IyXmS9F+M80JGAYZ4HU88U3rF k3Cr4Zw15Qxf//troD/4mneo5gEWtXeZ/oyVfDfftcuIeyV3fDAW3G2Vxxzio/lugMVB bsA+NPgb2ouNeYoK1rWv45tdWKFQShMxFR155l92UezGBUdu4YyrU6+54pZW/YG1P28T o5HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=JwSH2aVoTO9OLiW27hN/IDvEgg/U4tZOFYArTi8XkLg=; b=OlfY3kZ9j+oBVNTswPSrgxquz1i3PMe6hCODFoYP3Wz8ncLKIYoxnr0V67Rtp3Pf3r 2wDAze9ZB38cSLeecYOmBgZnpqyV7NBsbUQGrrK6nIb7ytWfws7z9b2h85DMzGiCZLKQ dflpmZ7bqsO8KhC/PqQJEoRhlc5El/QoDXs6ZTlS8BUwobkd2EzMa2JXJR19DaEfBW7p OsqbqZNFjg2voAp3/4SJiP+ysxZLa0PU23SwYZMSQJRRLEaetjS9cIxfCqrVSIeMvaof b60xU2YxdNEEoFRPg8DxecgV2lWyAT5L2RU7iM9DLeNCcWaWSWEvekzoK6zQBzGdj3H+ ojEg== X-Gm-Message-State: AOAM533xAFj0JOSqibj61OvHeq2FZz7ETViEzbXGqJYQXJCwMTPPhVnc aRJlMndYkkslmzMQCcCNehA5l09zePI= X-Google-Smtp-Source: ABdhPJwr9uptoZNFCxRRTMGXGBP/uxWgWh7mBsx0t5xc3FrNG5IZQLYZLE3mhAX7oFAivQ1pILp4Aw== X-Received: by 2002:a9d:5543:: with SMTP id h3mr7515017oti.241.1604852754733; Sun, 08 Nov 2020 08:25:54 -0800 (PST) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id y35sm1878191otb.5.2020.11.08.08.25.54 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 08 Nov 2020 08:25:54 -0800 (PST) Sender: Guenter Roeck From: Guenter Roeck To: Wim Van Sebroeck Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck Subject: [PATCH 2/2] watchdog: sirfsoc: Add missing dependency on HAS_IOMEM Date: Sun, 8 Nov 2020 08:25:50 -0800 Message-Id: <20201108162550.27660-2-linux@roeck-us.net> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201108162550.27660-1-linux@roeck-us.net> References: <20201108162550.27660-1-linux@roeck-us.net> Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org If HAS_IOMEM is not defined and SIRFSOC_WATCHDOG is enabled, the build fails with the following error. drivers/watchdog/sirfsoc_wdt.o: in function `sirfsoc_wdt_probe': sirfsoc_wdt.c:(.text+0x112): undefined reference to `devm_platform_ioremap_resource' Reported-by: Necip Fazil Yildiran Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible") Signed-off-by: Guenter Roeck --- drivers/watchdog/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index b3e8bdaa2a11..f8e9be65036a 100644 --- a/drivers/watchdog/Kconfig +++ b/drivers/watchdog/Kconfig @@ -790,6 +790,7 @@ config MOXART_WDT config SIRFSOC_WATCHDOG tristate "SiRFSOC watchdog" + depends on HAS_IOMEM depends on ARCH_SIRF || COMPILE_TEST select WATCHDOG_CORE default y