From patchwork Sat Nov 3 22:49:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10666783 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 68F4317D4 for ; Sat, 3 Nov 2018 22:50:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5CCBC29AC7 for ; Sat, 3 Nov 2018 22:50:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 50B9A29AD3; Sat, 3 Nov 2018 22:50:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 65EC629ACD for ; Sat, 3 Nov 2018 22:50:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728599AbeKDICt (ORCPT ); Sun, 4 Nov 2018 03:02:49 -0500 Received: from mail-qk1-f194.google.com ([209.85.222.194]:45752 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727047AbeKDICt (ORCPT ); Sun, 4 Nov 2018 03:02:49 -0500 Received: by mail-qk1-f194.google.com with SMTP id d135so8909991qkc.12 for ; Sat, 03 Nov 2018 15:50:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9WTEEyu2PskGPSxUGKrtAjHaKSrp/L3vMKzLiu3cbGg=; b=r5r9RgfVxE21mp07NnNDnSYmc6exBER3fT82vmtGer3obqxsAA1Pm94nglHJIq1MTw D46w5ApH2CDU3qCxWI59fOQlx6o3zCD1dGNYYABvJAkmd6jqhcDKg6HV7zYL79FtRjku Z8hYvcgpBi8k5pgOc4rr+ypvrLXmcvLCPnvX5BhaJbgpMeZurei5OxmY/oiur6wU9GhO cOPcsM32d+/lbcFWlVV0137YVxI6RbHnFOIHrCyPnT637BI1mI6nkAJidTCQzy19elCa M2TWwPksokgvHpDirk8UylaOmkGVXIqa5IaPaGqLoiuRDQ2rbWnMyfdwCBoRVKKLvLHC +mSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9WTEEyu2PskGPSxUGKrtAjHaKSrp/L3vMKzLiu3cbGg=; b=QwdYmZZcb1WsmAJsIrxKMCSk5sUwT9BfNbt9KFBRvIvm9E0gOOK1FZVXxzdzcHy05T pjPXSBUK9d4ijD6nLXBQBFhQhjXDG5PMbNBryyda0q2+9imJS9nea2MFXuUlYM5TMy+9 ff9/i3zca7LxdK/oolq4l/Mma1fDMFZR6RlLKQHHgw/l85sQxOdFh3lVRDBSDFjN5zns TPMzjYT6OxCQcHgqX+5A/G6/2DHyLIEoJkjazezmhXEvL/c/+2jL1R0v2C6vZbzmY0IS xs7sN2VmNcyHmtGftf9AVmZPJCnwXzR0+vP66Ifr/0Ssj9v+b1HQPtIhQu2eofSxxNnj uvyQ== X-Gm-Message-State: AGRZ1gKNT383aJVRGJcjz+7kyb4EbeSpRC76MSAl3wlEmtBiI5pJC3kd 3HIpICsS4COV37F67ENx+ZdT9g== X-Google-Smtp-Source: AJdET5clEuKXvSPDzKcVrQLCl7ErwcEaA6KpYThvCN+Im97tnxYe3mwSgdb9nxWFJV5HjQGo0Mmwkw== X-Received: by 2002:a37:a3c6:: with SMTP id m189mr15557224qke.173.1541285408393; Sat, 03 Nov 2018 15:50:08 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id 35-v6sm27550924qtu.69.2018.11.03.15.50.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Nov 2018 15:50:07 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH v3 1/6] staging:iio:ad2s90: Make read_raw return spi_read's error code Date: Sat, 3 Nov 2018 19:49:43 -0300 Message-Id: <20181103224948.31014-2-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181103224948.31014-1-matheus.bernardino@usp.br> References: <20181103224948.31014-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Previously, when spi_read returned an error code inside ad2s90_read_raw, the code was ignored and IIO_VAL_INT was returned. This patch makes the function return the error code returned by spi_read when it fails. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index 59586947a936..ba55de29ef36 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -36,11 +36,12 @@ static int ad2s90_read_raw(struct iio_dev *indio_dev, mutex_lock(&st->lock); ret = spi_read(st->sdev, st->rx, 2); - if (ret) - goto error_ret; + if (ret < 0) { + mutex_unlock(&st->lock); + return ret; + } *val = (((u16)(st->rx[0])) << 4) | ((st->rx[1] & 0xF0) >> 4); -error_ret: mutex_unlock(&st->lock); return IIO_VAL_INT; From patchwork Sat Nov 3 22:49:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10666793 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8D62014E2 for ; Sat, 3 Nov 2018 22:50:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 80E7E29AC7 for ; Sat, 3 Nov 2018 22:50:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 750B029AD3; Sat, 3 Nov 2018 22:50:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2235229AC7 for ; Sat, 3 Nov 2018 22:50:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726990AbeKDIDT (ORCPT ); Sun, 4 Nov 2018 03:03:19 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:37551 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728688AbeKDICw (ORCPT ); Sun, 4 Nov 2018 03:02:52 -0500 Received: by mail-qk1-f195.google.com with SMTP id 131so8985058qkd.4 for ; Sat, 03 Nov 2018 15:50:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zqk6KK1zavttyyKgEeKSNj6LjESJAqexffEcPC1/Ftw=; b=DOo6IijD1Mam6q+MOjJFKxVaOjeTMd1kXZLk3CJx+nPysyZnEtTZufGjd5e2U5oVM1 5p3bkAemFRdG8qX1mqzYrKCA9Wcu3RZybxMmDH+T4jOiLFJFtqc0Cn1DBI28jzMNCH+N qfBYDYCX9gGfDWMcx3hgCbulG0n+r6uuwjXhZDfq9BLFYSHfhTf0XyeGHa5vizmSIJ6F KAL2Z3Yo/Z6cF6YMSDKjmkXOeqe2KoD3dKX7mOrqX1A1SkSFe/Bg2V6X3VaZVHZ9zAHv GFXLnZcGLPsrk/ECE4dTW9iGxfhEKCMRp3bFJZJYEX6k1XXGna+Ss9/lfYa5iBvw6pCZ yshw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zqk6KK1zavttyyKgEeKSNj6LjESJAqexffEcPC1/Ftw=; b=U7UT1+hJabhdzWKhcXG/pviQo7AT7DlSJJjp0MFpecB6YLpcO9y45nyUXxAQcnbdvQ wuCUGlSCKfnsc9vOK0hEHB2WevfOFWyirddx+NCIr5drzo6J54GjuziZFJhtWW5d4X/B fS0g06tnCOgIbu2cwMkK+6UytOcIVGYukfY2PBZVmZqZN1JtM3BVuefcsyQmQjv6JuYm rcQt5B6fxkh87DgBoAXOqMqFyFfk7CF7hztSOH8dGhCUZM46qTm2WZJd3nScxT2/9Qxq yMtkD+1t4ukAbrYfZOa0++uWniEu1nhtmKX1khUW57hs/JY9dpOzHbaSktCF5vH0Lzz7 xQ4g== X-Gm-Message-State: AGRZ1gJQE5vsrUGIvuW6p+UIbO1ZEG6SjWDK1ix1U56ihkeHrwgiWtvB yGjz6fimeDzUZbrWfSIoLcFEQw== X-Google-Smtp-Source: AJdET5eRWlg54bZ5piysXhrLHCQPip8VGYd98n4hFrBcQGn80uhA+VXcPUjmTOnqPw7b64zmkwN37A== X-Received: by 2002:a37:a4cf:: with SMTP id n198mr9978343qke.101.1541285411678; Sat, 03 Nov 2018 15:50:11 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id 35-v6sm27550924qtu.69.2018.11.03.15.50.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Nov 2018 15:50:11 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH v3 2/6] staging:iio:ad2s90: Make probe handle spi_setup failure Date: Sat, 3 Nov 2018 19:49:44 -0300 Message-Id: <20181103224948.31014-3-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181103224948.31014-1-matheus.bernardino@usp.br> References: <20181103224948.31014-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Previously, ad2s90_probe ignored the return code from spi_setup, not handling its possible failure. This patch makes ad2s90_probe check if the code is an error code and, if so, do the following: - Call dev_err with an appropriate error message. - Return the spi_setup's error code. Note: The 'return ret' statement could be out of the 'if' block, but this whole block will be moved up in the function in the patch: 'staging:iio:ad2s90: Move device registration to the end of probe'. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index ba55de29ef36..4908c8a95fad 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -86,7 +86,12 @@ static int ad2s90_probe(struct spi_device *spi) /* need 600ns between CS and the first falling edge of SCLK */ spi->max_speed_hz = 830000; spi->mode = SPI_MODE_3; - spi_setup(spi); + ret = spi_setup(spi); + + if (ret < 0) { + dev_err(&spi->dev, "spi_setup failed!\n"); + return ret; + } return 0; } From patchwork Sat Nov 3 22:49:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10666791 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6AE2C14E2 for ; Sat, 3 Nov 2018 22:50:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5F39B29AC7 for ; Sat, 3 Nov 2018 22:50:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5386129AD3; Sat, 3 Nov 2018 22:50:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0095729AC7 for ; Sat, 3 Nov 2018 22:50:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728752AbeKDIC4 (ORCPT ); Sun, 4 Nov 2018 03:02:56 -0500 Received: from mail-qk1-f196.google.com ([209.85.222.196]:45770 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728593AbeKDIC4 (ORCPT ); Sun, 4 Nov 2018 03:02:56 -0500 Received: by mail-qk1-f196.google.com with SMTP id d135so8910253qkc.12 for ; Sat, 03 Nov 2018 15:50:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xuC9nGCa0Xu3GdJ9qRkKK25LaCKIesQs7VLCImXBAKU=; b=uHDjOW0HuP8aULg69i2rds4IIrM6qqjylGKMidH6a0hCIzjWk/yq21MFNbeTWcs/KM od+fZPThANrhSwAscMQAb2sTx3PeJjSl5JUXD8GEWJN6V6xZvRcomYPRQoEKpTA+KxrY jlwIY6vQCJO1Nmhw13/E0vMavTxq7Dm2Smdv7r4Ir9tyCBcBAusW8wwolRLpPHd+/RHw 1FUiCCGHJrKBjIwdqqFDQ5BfY+sAvU0x8kSF+c8v8Fs2zPuHWSFdR07ZEh3kEZBoIlMk nhhRyUe6lBKqgHa5tXGxl2kT1+KI2DQKt2gaklY2ZMw/EAUQKaUFmdfHqbB5c4RfzBi8 5KOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xuC9nGCa0Xu3GdJ9qRkKK25LaCKIesQs7VLCImXBAKU=; b=dwPBFMiiM8CwWStI1tcCX8Og4IvJVu0ga5FYArBRynihOojvSrJyQWXRyXBMt2Py9S zCGeGLLJ/6A1tSLeizCYn1Top6Ik0dZAvLUFjq9vWlS5TOl2MQpkHMvUJVDRMMtd6xu4 9MP353wA5UEgAxuvSI6MeQg15V1Gi6VXXi0PNYzHWCAS0e5cfOL2nEVVjDZg+dtoFfic rOM86Z1h3gp1pmyq/MzuxFkMbYemi08pwu7M6X6n6KRmZxCKEwYNThGIGkEGvD8/cvKD U5+eOM6FaIZRuk7bZZfUAUS0jufdH7suj1eflSPM0vopS5DiF1JPrYbrxVSj4HfbCinm YdRQ== X-Gm-Message-State: AGRZ1gJre+ml0Dx6tTCIQiIESjseXWaL7Q0W2Jv2BLAau/ThxhX2tUcX MvEY69kQ6OjcrrTy6gjRQWz9qQ== X-Google-Smtp-Source: AJdET5dyOHMyRB0HIwZuyrebJvu1+lpHLskk6VXSt0X68IeYhYP6Ks8Kh6m2OhI5x49rtF6ioXGJZg== X-Received: by 2002:a37:14ca:: with SMTP id 71mr14806570qku.295.1541285415382; Sat, 03 Nov 2018 15:50:15 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id 35-v6sm27550924qtu.69.2018.11.03.15.50.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Nov 2018 15:50:14 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH v3 3/6] staging:iio:ad2s90: Remove always overwritten assignment Date: Sat, 3 Nov 2018 19:49:45 -0300 Message-Id: <20181103224948.31014-4-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181103224948.31014-1-matheus.bernardino@usp.br> References: <20181103224948.31014-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch removes an initial assignment to the variable ret at probe, that was always overwritten. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index 4908c8a95fad..54ad85bd9dc6 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -62,7 +62,7 @@ static int ad2s90_probe(struct spi_device *spi) { struct iio_dev *indio_dev; struct ad2s90_state *st; - int ret = 0; + int ret; indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st)); if (!indio_dev) From patchwork Sat Nov 3 22:49:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10666785 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8CE6514E2 for ; Sat, 3 Nov 2018 22:50:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7E7C829AC7 for ; Sat, 3 Nov 2018 22:50:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7260229AD3; Sat, 3 Nov 2018 22:50:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D63F29AC7 for ; Sat, 3 Nov 2018 22:50:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728743AbeKDIDA (ORCPT ); Sun, 4 Nov 2018 03:03:00 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:43787 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728779AbeKDIC7 (ORCPT ); Sun, 4 Nov 2018 03:02:59 -0500 Received: by mail-qk1-f195.google.com with SMTP id r71so8936392qkr.10 for ; Sat, 03 Nov 2018 15:50:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GD4vVE0HPom8l9DS59ZCy1DA4DKNmflT3aSJsaYUcgA=; b=GUubobDbcf/zDkYhIxxdggdX5hJks+0xN50pfmTtNVPHJ/FsxiA37fzyP7ZUQFQXKZ XzKqgVBBVFS6abh6HRkRZYMjN7nr+U6nWU7NcwP/lkaojZlhWmiQ4P33MfOqGCjMVTZA 70ZnLGQg90J7uWn5E9GM4/A7KLkwxnnrDTvKOXckH3UqGO3uQKdw4Q6U/tHi1Y7efaTh jr78V2ovjPRAN4ecvL1Vfs0UwZZHkZuM7m1OwxPiXu1k9VdT07nIWAImtGDVUvVI1n9G BeAyPXxh+gzhcFDkiyj6lpI29neTAcVbx+aeKVWA8IPl+ugesdmkbUPHjJ7FmtH4VAcf +wkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GD4vVE0HPom8l9DS59ZCy1DA4DKNmflT3aSJsaYUcgA=; b=JU9jATc4oP2EABbBtBSrUPn1FWs5419zGyhM2BpiAkbg4wtvxCZjqReS4Pbg5/gEHP HrzznovLbdBkoWSAyK9R+1MlobataOuQEVS7InrXuhuysHJ+2BGoSqVPOXNCcKx311ZR hJxr4UflZhElyR/Kgq8Tb6goTukFxroH5vvm5dXkQMbeBFFIHBNNEMqk1Ycg4JQU0+Qf R+CJ8UhM0+45y8Sy+ryJlFxfd0uuTzBDQn2IZy6M/Hxili3eRRnKeKI77Rr5HKQoPkVr rBxF07duyKP65io9S1tdfrXcom9SW4wyvu0RUhSyvzToRFme0APquoMsbBfYrpO45YTc nGig== X-Gm-Message-State: AGRZ1gI76C70K+ASWlqhbobVzpCAJuU+80UNly2SVyElKRa75FVmQTJS W0B5iG9PGuTr/ksfE2rrBmzr3Q== X-Google-Smtp-Source: AJdET5emOQoEEYsu17VDqPH9pxzz2d8As5AujJn8zwW1Qxm3/MB7tl+pB1q14J/EA6PzkIgkSqhjkw== X-Received: by 2002:ac8:6104:: with SMTP id a4-v6mr10478328qtm.350.1541285418902; Sat, 03 Nov 2018 15:50:18 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id 35-v6sm27550924qtu.69.2018.11.03.15.50.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Nov 2018 15:50:18 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH v3 4/6] staging:iio:ad2s90: Move device registration to the end of probe Date: Sat, 3 Nov 2018 19:49:46 -0300 Message-Id: <20181103224948.31014-5-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181103224948.31014-1-matheus.bernardino@usp.br> References: <20181103224948.31014-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Previously, devm_iio_device_register was being called before the spi_setup call and the spi_device's max_speed_hz and mode assignments. This could lead to a race condition since the driver was still being set up after it was already made ready to use. To fix it, this patch moves the device registration to the end of ad2s90_probe. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index 54ad85bd9dc6..8f79cccf4814 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -79,10 +79,6 @@ static int ad2s90_probe(struct spi_device *spi) indio_dev->num_channels = 1; indio_dev->name = spi_get_device_id(spi)->name; - ret = devm_iio_device_register(indio_dev->dev.parent, indio_dev); - if (ret) - return ret; - /* need 600ns between CS and the first falling edge of SCLK */ spi->max_speed_hz = 830000; spi->mode = SPI_MODE_3; @@ -93,7 +89,7 @@ static int ad2s90_probe(struct spi_device *spi) return ret; } - return 0; + return devm_iio_device_register(indio_dev->dev.parent, indio_dev); } static const struct spi_device_id ad2s90_id[] = { From patchwork Sat Nov 3 22:49:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10666789 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A7B4414E2 for ; Sat, 3 Nov 2018 22:50:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9ACCE29AC7 for ; Sat, 3 Nov 2018 22:50:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8F19229AD3; Sat, 3 Nov 2018 22:50:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1E09529AC7 for ; Sat, 3 Nov 2018 22:50:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728801AbeKDIDE (ORCPT ); Sun, 4 Nov 2018 03:03:04 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:40102 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726954AbeKDIDD (ORCPT ); Sun, 4 Nov 2018 03:03:03 -0500 Received: by mail-qk1-f195.google.com with SMTP id y16so7757780qki.7 for ; Sat, 03 Nov 2018 15:50:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=m0AamTcm1g4t7bycgutx/ePAEZettKzmbxK6n56vTuo=; b=xVuXDa7SIAlQvPnjjEqBbluD0g7qOhssMDDXcJ4NVxL2IP8nNndDK2RVatjx+MHffm DlwmktP1oEZ34TqmR4dToUiSvQDRsEWbyzGlHQN+Lzk5D+uSqPUmRmsSgdQg2eQkTX6c birMcUVjD7EQhoLj78nxCfaOqc+Lux+1UufnYgWUA4TSHN5XAfasQpip/KAhJSXXenYU VM5AizT+3+4hZdbEIJqMogjC1LwOnElI+LfrL76QFtzrLlyEG+6GqQr2kStvAecxHZCk 9f+mmsA/XiarkEEY9Lk4nSBZifQfA8H/A5xc7p9b6TmU6TAL20MohUxAn5VWceKqYdRz lfoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=m0AamTcm1g4t7bycgutx/ePAEZettKzmbxK6n56vTuo=; b=lG8kUJ5GXgi6DFX2upnt+9HemsAJ4S30n78syaLXY3ycEbWA8QyPislH1wL8X3cDyK RdOgXtdaEmm00PAHBtFDjWYLw+WtQ8PWy8EEQWGONHGlQjp/1oAdG032WErOQjsdj3Ov NCcaVYWUXK7zBhmbG+6C4OkYhZK8gspg7VBwhKItQd2gOWfzhKjN3UXAB/Z9nGbT8JxH N7q5OTvZCUS26CvYVUBwz/W4Dxp1ADV/+igPfiGAOjedzyu++9434fcZAPVbIoEYjphs kM71c+n3k0BT1fPCoS2DBZN+ib3sHEjKUicHvaqG5PLbp05tMmv1VYE+dz7rcjS6exqa G+ng== X-Gm-Message-State: AGRZ1gIdNtsg2ho0pf2Lo3/yNs+4bQHZDTbU4s3Q1gPRDYZEYs8FeYJV sW03HcjqoipEwxvtpJOYO65Dwg== X-Google-Smtp-Source: AJdET5f4V7R90r/Ps/jr9qC25oKb7stN+/NkcZzVB9gvH4MhDmnduu4wzuC2Tj96PFcIJ/Y3JsOxlw== X-Received: by 2002:ad4:5307:: with SMTP id y7mr16298887qvr.9.1541285422387; Sat, 03 Nov 2018 15:50:22 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id 35-v6sm27550924qtu.69.2018.11.03.15.50.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Nov 2018 15:50:21 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com, Victor Colombo Subject: [PATCH v3 5/6] staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and read_raw Date: Sat, 3 Nov 2018 19:49:47 -0300 Message-Id: <20181103224948.31014-6-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181103224948.31014-1-matheus.bernardino@usp.br> References: <20181103224948.31014-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and implements the relative read behavior at ad2s90_read_raw. Signed-off-by: Victor Colombo Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 30 +++++++++++++++++++-------- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index 8f79cccf4814..9c168b7410d0 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -34,17 +34,29 @@ static int ad2s90_read_raw(struct iio_dev *indio_dev, int ret; struct ad2s90_state *st = iio_priv(indio_dev); - mutex_lock(&st->lock); - ret = spi_read(st->sdev, st->rx, 2); - if (ret < 0) { + switch (m) { + case IIO_CHAN_INFO_SCALE: + /* 2 * Pi / 2^12 */ + *val = 6283; /* mV */ + *val2 = 12; + return IIO_VAL_FRACTIONAL_LOG2; + case IIO_CHAN_INFO_RAW: + mutex_lock(&st->lock); + ret = spi_read(st->sdev, st->rx, 2); + if (ret < 0) { + mutex_unlock(&st->lock); + return ret; + } + *val = (((u16)(st->rx[0])) << 4) | ((st->rx[1] & 0xF0) >> 4); + mutex_unlock(&st->lock); - return ret; - } - *val = (((u16)(st->rx[0])) << 4) | ((st->rx[1] & 0xF0) >> 4); - mutex_unlock(&st->lock); + return IIO_VAL_INT; + default: + break; + } - return IIO_VAL_INT; + return -EINVAL; } static const struct iio_info ad2s90_info = { @@ -55,7 +67,7 @@ static const struct iio_chan_spec ad2s90_chan = { .type = IIO_ANGL, .indexed = 1, .channel = 0, - .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE), }; static int ad2s90_probe(struct spi_device *spi) From patchwork Sat Nov 3 22:49:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10666787 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CF14217D4 for ; Sat, 3 Nov 2018 22:50:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C311729AC7 for ; Sat, 3 Nov 2018 22:50:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B6EA729AD3; Sat, 3 Nov 2018 22:50:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 559B629AC7 for ; Sat, 3 Nov 2018 22:50:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728835AbeKDIDH (ORCPT ); Sun, 4 Nov 2018 03:03:07 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:44245 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727087AbeKDIDG (ORCPT ); Sun, 4 Nov 2018 03:03:06 -0500 Received: by mail-qk1-f195.google.com with SMTP id n12so8923299qkh.11 for ; Sat, 03 Nov 2018 15:50:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=uRaFpWiqq0590LAIWCKDCZV7Qjo+FL/9V7eRidlfT3s=; b=1CtKVcdxkcaI283xQLfB0FmveXFcTjA/J4RM6cOTw0TWTWyYJxs1hfN4KODCcC4rs4 PdacCMMokO7XCZmntj9zaKaRwMHeTKdUb75OZ+DR6cLWhnvxiK85DN2A1b31MEVefbgu X3MhEvXnjvs0IODEaQ8wOx2wPIe50dn+iJY3G7+T49qRBFrcJYJjiQQOG7CM7zrq8jMC 20DpfgzBZhpwwx/Pxdv4D4CNz3FcYgZ0D5jLK6qEq4cDs7+4eQnNg84gUI067LCdP2CL OfZsA447baszPcwSqb2UbHrxngRNGF+sXEjoTcONlbi6TKC4DJvyOWuXWEPYWPwmRXf9 ZmVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=uRaFpWiqq0590LAIWCKDCZV7Qjo+FL/9V7eRidlfT3s=; b=UimJ/2b4McOuF9feu3ChlnKAD5QhRhnan1ZjY3nhvIRyXHUQIR3pEZC0nGq6YKeC2M SMlbXd7TmB50YIQs0If54TKDu1v7pUXGH/usz4rl6DW8jA76fR6vqtqYJHav3ed5AW38 cuZjSSUs5ok056Krr8tqA1vukKMZN2TvSQhmesEy/H3xHwXa8NKCf/OHZC3BrvBCUdgW 9wLY+cs0HWJQEDw4jqlj282UmY5HJQrWaCyEElc404cNOSX9rirZyJUPaH85ElBqvAzO hwfpnVxNwPoNaDFbNfvfBKfyHCbhSn8ukfa5m0jpZPfGRkdk1dr07dvzxhtn1O1momJC gg4w== X-Gm-Message-State: AGRZ1gLF7Ay7Gxc53N7slgFszsEghofjDXb4HRyCLO1tRD9YuzruIOOe jSHNG/Qw6pdybVdCgpSMz1FLIg== X-Google-Smtp-Source: AJdET5eBeXKxiHKO8ookz4GGM6+/EUtIbCMcPq4mgVcRBDAoKdwpzrgYl/IHkNdR6ZkZ8j1mPy1+6g== X-Received: by 2002:a0c:d107:: with SMTP id a7mr16112704qvh.104.1541285425687; Sat, 03 Nov 2018 15:50:25 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id 35-v6sm27550924qtu.69.2018.11.03.15.50.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Nov 2018 15:50:25 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH v3 6/6] staging:iio:ad2s90: Check channel type at read_raw Date: Sat, 3 Nov 2018 19:49:48 -0300 Message-Id: <20181103224948.31014-7-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181103224948.31014-1-matheus.bernardino@usp.br> References: <20181103224948.31014-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds a channel type check at the beginning of the ad2s90_read_raw function. Since ad2s90 has only one channel, it just checks if the given channel is the expected one and if not, return -EINVAL. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index 9c168b7410d0..3e257ac46f7a 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -34,6 +34,9 @@ static int ad2s90_read_raw(struct iio_dev *indio_dev, int ret; struct ad2s90_state *st = iio_priv(indio_dev); + if (chan->type != IIO_ANGL) + return -EINVAL; + switch (m) { case IIO_CHAN_INFO_SCALE: /* 2 * Pi / 2^12 */