From patchwork Thu Nov 12 11:01:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11899713 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8062F139F for ; Thu, 12 Nov 2020 11:07:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 585FB22201 for ; Thu, 12 Nov 2020 11:07:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="E+asLefU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728060AbgKLLGl (ORCPT ); Thu, 12 Nov 2020 06:06:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727928AbgKLLCK (ORCPT ); Thu, 12 Nov 2020 06:02:10 -0500 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79288C0617A6 for ; Thu, 12 Nov 2020 03:02:10 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id 10so4884154wml.2 for ; Thu, 12 Nov 2020 03:02:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iidsrVG04+5OGr655Fc8AmVNociMTMEvIzPILgRtw34=; b=E+asLefU30g7IYG4PNqJ8WU7ULw0KGKd3Nvvtu5XudTRmWOs6n4eTJWI2sC8OUzJp/ r7IaUlq23l7mKA5kbznzkvEYjNaiPAZ80v1JEmtiRXDHAQqErWeWqenoe3i2cwzG75XZ QsODJG8B7hlzonxu6fSrDoPbNuZvcgO+xAYXzlNdaLiBsQKK+od82u3WYx7AqKLzDumg b+Ptb+TJL0kBvKqaSU3ieFtlaDx706S2pKe1+VQrsLEBsC16svAj+BHtd4gtTXzfPAm6 lhrE0pCir21AHHe5x9kpw0PcLgGNTNH2CCXr9iSd5l5c6mCbEUqHqA9hVLQGQgzEfmuB fWkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iidsrVG04+5OGr655Fc8AmVNociMTMEvIzPILgRtw34=; b=hma5mRGeaGLOYwsdiGdbI4CK8g9A6xD303XDCcKyoE79189eWNUiUaUp9VRJQYnDRy q9xBbl5Fgnh4SpBQnbmciM8qtKBnQgjnZ4VtZXPhzIfixAGF4G2FpbK3v6vTyqQs1Ul8 bZCLzCdy4mB0HrgAsqxiOLd8ZTCmQCoJLs7ipTr8Bji3wqs9goraSfS68a5Aq73SYeoo 1RYQKrVlWdenv7TghREFAOWpA5rK7M25UHo+/LTlJNcyuqd1fho2JinbEMdAGWrSCvQd fWlXqSZH49PI43KbkpmfMvujiPuLIDqmFSqecCE5+cyo+71WwqhJlFRTCoUHCTYMRRHA U60Q== X-Gm-Message-State: AOAM5300SuY8MPY4+oLD0I7Ed+t36BPslEyBd+1mSrrUgLQkMj38dqvJ 81Heq7OOJ9qyqO6L3FzOyz2RHA== X-Google-Smtp-Source: ABdhPJyFdXj837v2Sh4ImKatYRrWp+MMXle8DcPiD4par8LADB9Lp4CuXqbHSw8Jw3EHCeetVMvO0w== X-Received: by 2002:a1c:1f05:: with SMTP id f5mr8763569wmf.98.1605178929098; Thu, 12 Nov 2020 03:02:09 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x81sm6515329wmg.5.2020.11.12.03.02.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 03:02:08 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , =?utf-8?q?=C5=81ukasz_Patron?= , Cameron Gutman , Marko Friedemann , Oliver Schwartz , Steven Toth , Franz Lehner , Ivan Hawkes , Dominic Cerquetti , Adam Buchbinder , Jan Kratochvil , Christoph Fritz , linux-input@vger.kernel.org Subject: [PATCH 01/15] input: joystick: xpad: Demote non-conformant kernel-doc header Date: Thu, 12 Nov 2020 11:01:50 +0000 Message-Id: <20201112110204.2083435-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201112110204.2083435-1-lee.jones@linaro.org> References: <20201112110204.2083435-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/joystick/xpad.c:1361: warning: Function parameter or member 'xpad' not described in 'xpad_send_led_command' drivers/input/joystick/xpad.c:1361: warning: Function parameter or member 'command' not described in 'xpad_send_led_command' Cc: Dmitry Torokhov Cc: "Łukasz Patron" Cc: Cameron Gutman Cc: Marko Friedemann Cc: Oliver Schwartz Cc: Steven Toth Cc: Franz Lehner Cc: Ivan Hawkes Cc: Dominic Cerquetti Cc: Adam Buchbinder Cc: Jan Kratochvil Cc: Christoph Fritz Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/joystick/xpad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index c77cdb3b62b5b..2cd4296c2d082 100644 --- a/drivers/input/joystick/xpad.c +++ b/drivers/input/joystick/xpad.c @@ -1337,7 +1337,7 @@ struct xpad_led { struct usb_xpad *xpad; }; -/** +/* * set the LEDs on Xbox360 / Wireless Controllers * @param command * 0: off From patchwork Thu Nov 12 11:01:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11899685 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A652F1391 for ; Thu, 12 Nov 2020 11:02:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79D872223C for ; Thu, 12 Nov 2020 11:02:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oVniKyKU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728041AbgKLLCP (ORCPT ); Thu, 12 Nov 2020 06:02:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727969AbgKLLCO (ORCPT ); Thu, 12 Nov 2020 06:02:14 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2FDAC061A04 for ; Thu, 12 Nov 2020 03:02:11 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id c17so5484621wrc.11 for ; Thu, 12 Nov 2020 03:02:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nMKE4IlOr6evhy/Ie8gXbBmQpqdbJ7dvrI7Z+uES9YU=; b=oVniKyKUgho7jnPFtk0I6A3ULuPQSFCnRTuKY4hKAiDWM7bzWwqQlEqO39PpFQArz7 7Kqy9ACSUzCdM08TmqUwgI5w+JT0w7sgLA8EGVf1Tmqgg03brLsa6UKebtFQTTzOu6+V X0ViJv6AQyvIim12RFf3D25MXR3vfJseB3sqLXF+fdKRmzMtR6VUkq+dkIRonoT25SLI MYhBAUJkOfqdrw0KEeY4997CdiVGlLVoSn+6d/AOSU9Krlhm6c4eqxJtgjFepJz3Y64A iIU9Asz2/ElC2Un237l1Z9IlsQxOKXdiSi1DXskNYPJ8XSNt++pTPN5TYw1XqeklloiP 6DpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nMKE4IlOr6evhy/Ie8gXbBmQpqdbJ7dvrI7Z+uES9YU=; b=HOmNKKqOYEcAl7KvAtTJ57oQqk/LaEE+/3jVm2Q47O3p5ySCz8rllv05f5UqUxJsj0 qXZ2RcfWC8hHyY8vy0hQHjA1ddcFSxa5Bn3/AiQ3+LyUjq56FAwgdLuq3sdAQdjQ3i8K OReZlHX+Fkr5oLZYNYCo7BR9HBdGyMztCVvmqNF6Aj9Pt07VTtNkwnneNCRqG7kfbW6k HWKZAuizrtkPU/GDqvoslM7LhE+Hd+HeYKk5r1tM3aeIRdUIOde61s8wKATLvPl8VT4M AQJj3BDUz+EuUiMV3BPZaTktZHjLRPZKFXieGVEOOgm7KhHBMQfPz6+eqM6jfh15Le5q teBQ== X-Gm-Message-State: AOAM532makLNFNQ0GCWPGGkx20de5thIT6t05um27kqWQ/fFUuK6m8r9 99ZJdhRgKxFr4ykDI5cPgS4BMA== X-Google-Smtp-Source: ABdhPJxF7qJ/C1URUnUKpfIrnKc9ev2GZap1FEfEiAR06eLwFKpSNee+i1z21hmzKDMgd//sCFww5w== X-Received: by 2002:a05:6000:364:: with SMTP id f4mr7221199wrf.290.1605178930645; Thu, 12 Nov 2020 03:02:10 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x81sm6515329wmg.5.2020.11.12.03.02.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 03:02:10 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Joonyoung Shim , Donghwa Lee , linux-input@vger.kernel.org Subject: [PATCH 02/15] input: keyboard: samsung-keypad: Remove set but unused variable 'var' Date: Thu, 12 Nov 2020 11:01:51 +0000 Message-Id: <20201112110204.2083435-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201112110204.2083435-1-lee.jones@linaro.org> References: <20201112110204.2083435-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/keyboard/samsung-keypad.c: In function ‘samsung_keypad_irq’: drivers/input/keyboard/samsung-keypad.c:149:15: warning: variable ‘val’ set but not used [-Wunused-but-set-variable] Cc: Dmitry Torokhov Cc: Joonyoung Shim Cc: Donghwa Lee Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/keyboard/samsung-keypad.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/input/keyboard/samsung-keypad.c b/drivers/input/keyboard/samsung-keypad.c index 70c1d086bdd2a..1ed939d9798cf 100644 --- a/drivers/input/keyboard/samsung-keypad.c +++ b/drivers/input/keyboard/samsung-keypad.c @@ -146,13 +146,12 @@ static irqreturn_t samsung_keypad_irq(int irq, void *dev_id) { struct samsung_keypad *keypad = dev_id; unsigned int row_state[SAMSUNG_MAX_COLS]; - unsigned int val; bool key_down; pm_runtime_get_sync(&keypad->pdev->dev); do { - val = readl(keypad->base + SAMSUNG_KEYIFSTSCLR); + readl(keypad->base + SAMSUNG_KEYIFSTSCLR); /* Clear interrupt. */ writel(~0x0, keypad->base + SAMSUNG_KEYIFSTSCLR); From patchwork Thu Nov 12 11:01:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11899683 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4C302139F for ; Thu, 12 Nov 2020 11:02:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 213612053B for ; Thu, 12 Nov 2020 11:02:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Lc1AYuZ+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728035AbgKLLCP (ORCPT ); Thu, 12 Nov 2020 06:02:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727903AbgKLLCN (ORCPT ); Thu, 12 Nov 2020 06:02:13 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43F34C061A47 for ; Thu, 12 Nov 2020 03:02:13 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id s8so5503285wrw.10 for ; Thu, 12 Nov 2020 03:02:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=knWXj4Bg/0Bo5izs2YIZY2Umz4PY59EXUTTl8Cf1P4k=; b=Lc1AYuZ+Lt5588xyeZsCG++rT/I7ubH93uSjAHwJnPjdMQnzpRLxajJM9Xr2AaGqzA C37QdDmT4ivjUZfUqD8/MjbALgf6jVX+pBW1g3WaSoQRRi0ppqakLKAyo7aquZEWTL7j qncBK+yduN/EnLr9iWXnxKX9vy/3ywYlnp507pI3/QQwjyYaoJVKSkTJtvgYhsyG/G0W 0PAUMPfyeMhGXla5NHn9GHMAKKi4XhKOIWIU03Dgag94jCSeVXciOKDpdz4EXkT7LEZ2 QvXH09NxbKb+QnX6u1GBLFGs+8u9Iz11523salzrvZvIgay9khf16XSQCe6KjKSxRoab 1P9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=knWXj4Bg/0Bo5izs2YIZY2Umz4PY59EXUTTl8Cf1P4k=; b=tFuYgdHpYL980f9XExPtJ1DzbOmUZI7mVFqkdfeiHseE9ng9VLHECrsiqFKtH3pQ6q Wj9wdKTixbZpSddmIkCHWn6Se2dxeBrpeCIByk2lJ1IMsJvWLOKSuK4pLjjChZzVLD2z hqEuZ90qFqnR2QTm+81YljFYw8zLzJnFMFNI0DZquQlnBz41HMfNGTp/NL3qIXlkqDhP ukm6NpeJTISzvdvWpgpCy/LIOS/1vd56QeUw4J4M/Z8i5VQORjegA8nqB4L5j6mLPSdy lrVb4vfDfZkUQB86UETmU6YvlMvJmmnuKbVCUHJvjSSgry6YDd4DYNXwJYYQnEu7CKrM obBw== X-Gm-Message-State: AOAM5326JtA3CrbFcCCnv3XBSZiuEtJoDN6QylVUrU6K141H+GgoXoZZ aAwN/hwF0qlBhOYyE+rhi1QhAw== X-Google-Smtp-Source: ABdhPJyqyjes+BCgN06bC6HN+6GqsK+QWE28xLMVhslNDqpJesu8OVJHftKabKrCdKMpivjUocb94A== X-Received: by 2002:a5d:5405:: with SMTP id g5mr3726618wrv.350.1605178932058; Thu, 12 Nov 2020 03:02:12 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x81sm6515329wmg.5.2020.11.12.03.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 03:02:11 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , De Schrijver , Felipe Balbi , linux-input@vger.kernel.org Subject: [PATCH 03/15] input: misc: mc13783-pwrbutton: File headers are not good candidates for kernel-doc Date: Thu, 12 Nov 2020 11:01:52 +0000 Message-Id: <20201112110204.2083435-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201112110204.2083435-1-lee.jones@linaro.org> References: <20201112110204.2083435-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/misc/mc13783-pwrbutton.c:32: warning: cannot understand function prototype: 'struct mc13783_pwrb ' Cc: Dmitry Torokhov Cc: De Schrijver Cc: Felipe Balbi Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/misc/mc13783-pwrbutton.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/misc/mc13783-pwrbutton.c b/drivers/input/misc/mc13783-pwrbutton.c index afdf8ef25ee86..0636eee4bb6ce 100644 --- a/drivers/input/misc/mc13783-pwrbutton.c +++ b/drivers/input/misc/mc13783-pwrbutton.c @@ -1,4 +1,4 @@ -/** +/* * Copyright (C) 2011 Philippe Rétornaz * * Based on twl4030-pwrbutton driver by: From patchwork Thu Nov 12 11:01:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11899699 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 33FD61391 for ; Thu, 12 Nov 2020 11:05:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05BAC2223C for ; Thu, 12 Nov 2020 11:05:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FvWUQgKM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728054AbgKLLCR (ORCPT ); Thu, 12 Nov 2020 06:02:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728031AbgKLLCP (ORCPT ); Thu, 12 Nov 2020 06:02:15 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC10DC0613D1 for ; Thu, 12 Nov 2020 03:02:14 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id h2so4912511wmm.0 for ; Thu, 12 Nov 2020 03:02:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CMYg6E1kdXm+yD+hzGnKjz5iwy/O1uttWSB8VdrwJX0=; b=FvWUQgKMGClbxDUBdDyFjYlNDA1equD1xQMofMZntHFfIbfP4hqtgwFLYvsptlVHFp Aa1NGY3qFY0Jl10yCtnWfMq+ZoBMV4QLooxXfoCOy7mnrXWc7Urytan4kp5KKKwb9Usu LQCmz5T/bOg/MxxcYK5bq/HlGRONtHdo8DdjAsIf/gWDsqyENToN6DlsU+BL9Ol4Y5xO zTz9QsOGi30CLJ7jVaoddpKsC1cxoevAlUDfazrWUQs+TKJ+JJH56sepfrWKDi31VXiI qE5yzjYN3ApWdzebtlLXQ96ZKNunUjbulNfTxUr4TA0fAT6M3Ar/VFNlIBuOfXBC0PrH pIsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CMYg6E1kdXm+yD+hzGnKjz5iwy/O1uttWSB8VdrwJX0=; b=r6TGMPO6/dfm8pUPLD+DevITOawpa0NvoX547LpeIh91T904e7ZfFb+NqtYPuz/m6X BQpRJwis0m9nOQGd4QCVIgaZhW1x2029b/uM39BUGpEXJeeCnhcHQaVwlOppXu/eAqnq qVUb4LK/XXPOhLVfnpUInA7QXqC31MhC6SgHTbZv2Us4KJbGozxHuIA3w4mT6XX5P4gU jZnNYkbOmO3j+7mdNQ9iHR1rbh97f00fKSQM6aa3LKpjgiWuMDS/8G3WRIzEmp1j9B/v kRtY4lzbNi7oUwJ+P/9eb9a1aEW8sUoTLaIdPaGNVvg7YX1MoA/xK2T/KWL7HnPNtt2w BopQ== X-Gm-Message-State: AOAM533FmT2XI2DgKETfE96CZ0XBgaRRpXt0oFtR18sm4avOA69PPybj p7tqAdazxTNvLbU8OWuqAFLrGDiTD8ygaZFd X-Google-Smtp-Source: ABdhPJwBy4vJJPHYddsslHAtikZiVZvUMKoIPiPFJReFQlJnDyFpYrjp1YGMR4WyhQAI+S+Zth578w== X-Received: by 2002:a1c:df04:: with SMTP id w4mr8918637wmg.3.1605178933396; Thu, 12 Nov 2020 03:02:13 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x81sm6515329wmg.5.2020.11.12.03.02.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 03:02:12 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Bastien Nocera , Dmitry Torokhov , Henrik Rydberg , "K. Merker" , authored by , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 04/15] input: touchscreen: goodix: Provide some missing function parameter descriptions Date: Thu, 12 Nov 2020 11:01:53 +0000 Message-Id: <20201112110204.2083435-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201112110204.2083435-1-lee.jones@linaro.org> References: <20201112110204.2083435-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/goodix.c:569: warning: Function parameter or member 'len' not described in 'goodix_check_cfg' drivers/input/touchscreen/goodix.c:587: warning: Function parameter or member 'len' not described in 'goodix_send_cfg' drivers/input/touchscreen/goodix.c:1165: warning: Function parameter or member 'cfg' not described in 'goodix_config_cb' drivers/input/touchscreen/goodix.c:1165: warning: Function parameter or member 'ctx' not described in 'goodix_config_cb' drivers/input/touchscreen/goodix.c:1165: warning: Excess function parameter 'ts' description in 'goodix_config_cb' Cc: Bastien Nocera Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: "K. Merker" Cc: authored by Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/touchscreen/goodix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c index 02c75ea385e08..80a82a66a0f3b 100644 --- a/drivers/input/touchscreen/goodix.c +++ b/drivers/input/touchscreen/goodix.c @@ -564,6 +564,7 @@ static void goodix_calc_cfg_checksum_16(struct goodix_ts_data *ts) * * @ts: goodix_ts_data pointer * @cfg: firmware config data + * @len: config data length */ static int goodix_check_cfg(struct goodix_ts_data *ts, const u8 *cfg, int len) { @@ -582,6 +583,7 @@ static int goodix_check_cfg(struct goodix_ts_data *ts, const u8 *cfg, int len) * * @ts: goodix_ts_data pointer * @cfg: config firmware to write to device + * @len: config data length */ static int goodix_send_cfg(struct goodix_ts_data *ts, const u8 *cfg, int len) { @@ -1156,6 +1158,7 @@ static int goodix_configure_dev(struct goodix_ts_data *ts) /** * goodix_config_cb - Callback to finish device init * + * @cfg: firmware config * @ts: our goodix_ts_data pointer * * request_firmware_wait callback that finishes From patchwork Thu Nov 12 11:01:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11899709 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 256CA1391 for ; Thu, 12 Nov 2020 11:06:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC6162220B for ; Thu, 12 Nov 2020 11:06:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SObc/VTe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727611AbgKLLF0 (ORCPT ); Thu, 12 Nov 2020 06:05:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728042AbgKLLCQ (ORCPT ); Thu, 12 Nov 2020 06:02:16 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0BEDC0617A6 for ; Thu, 12 Nov 2020 03:02:15 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id 23so5918586wmg.1 for ; Thu, 12 Nov 2020 03:02:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kWLlC6ktlLXwXUeWXx8bHoPHYfcR3KsyU0jvMMlPcPs=; b=SObc/VTeOY+p3UM45yQu+wx/n3vgLtnbs9/szCWi/Uvo6w0HOls+v+TDcCpiyOdtjC P3KGg0WoiPwPeYRB0YFAgeyLc0PHY9HMa4GQKPdksXYiNyoBz/ky+mK+k4bw3yjZixIu pYo5hFOvjY2WbyYn0McFr1GmUahWvP/q4wVCEtfYVpe+rbnZB6hperaWhadArmTxgwyp n0vDXHjgwqjaPxVewspdN+8qb7FEvKMwxUMUhwMbricwRpPHRawwjoSHoyi/tX+wcOKT L2omsdN7pcDaFR/6bivTcwDg+VgOBMSqtLus+U42ROhy2NIWfZtIT73pidnvJMktxlOd YUCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kWLlC6ktlLXwXUeWXx8bHoPHYfcR3KsyU0jvMMlPcPs=; b=IKMGeQJYG1KtRtMAXkZopY2HAV1TKiMEhmj2Q+Z4tusv4dE/v54E4xaLq1CxWY/1rg XtY8JeoVpXDPSF5AqqBuW8PG0mM1sEqF3SSTk4dupxl7bDl+d8XDpMHX3eHj0tb/zUzX 2JTUhY/TzJLX8klrmP0dwHifWs2Ff38CE7pfNbENurpz3wf2h9xZVHB7F+5WJ6lUU6ps mYY5Bj4G0rsOTjpLHg4Yj5gDL/QLrWqSfiG214J1+pAiKfsEWnIQdXdW26A8LzZP2e6W 0GL6JjVlyypWg06hZXy911k72nWGkzuwk8z3k3AErQdt1sztW2+odd+cK4TKzotzHqsX aJew== X-Gm-Message-State: AOAM532u3XjwmkFPR8A4dzrY2uFAT1uQo3NS+ox5QIHvq//K2/mk1si+ Evx+GGXlQsGn2IKEggd+j75bRQ== X-Google-Smtp-Source: ABdhPJyDMS/KEjghxHHrXH5jorlSclEwYy5ef65oQXyCr7uZP+ZLYdL0R90cHziJKqAjJY5MN+NP/Q== X-Received: by 2002:a1c:2c2:: with SMTP id 185mr9137231wmc.103.1605178934689; Thu, 12 Nov 2020 03:02:14 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x81sm6515329wmg.5.2020.11.12.03.02.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 03:02:14 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Haibo Chen , linux-input@vger.kernel.org Subject: [PATCH 05/15] input: touchscreen: imx6ul_tsc: Remove set but unused variable 'value' Date: Thu, 12 Nov 2020 11:01:54 +0000 Message-Id: <20201112110204.2083435-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201112110204.2083435-1-lee.jones@linaro.org> References: <20201112110204.2083435-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/imx6ul_tsc.c: In function ‘adc_irq_fn’: drivers/input/touchscreen/imx6ul_tsc.c:307:6: warning: variable ‘value’ set but not used [-Wunused-but-set-variable] Cc: Dmitry Torokhov Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: Haibo Chen Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Haibo Chen --- drivers/input/touchscreen/imx6ul_tsc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index cd369f9ac5e60..e1852f7d4d31e 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -304,11 +304,10 @@ static irqreturn_t adc_irq_fn(int irq, void *dev_id) { struct imx6ul_tsc *tsc = dev_id; u32 coco; - u32 value; coco = readl(tsc->adc_regs + REG_ADC_HS); if (coco & 0x01) { - value = readl(tsc->adc_regs + REG_ADC_R0); + readl(tsc->adc_regs + REG_ADC_R0); complete(&tsc->completion); } From patchwork Thu Nov 12 11:01:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11899705 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D77ED16C1 for ; Thu, 12 Nov 2020 11:05:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE3CE2222A for ; Thu, 12 Nov 2020 11:05:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xnYi8HWP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727865AbgKLLFP (ORCPT ); Thu, 12 Nov 2020 06:05:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728050AbgKLLCR (ORCPT ); Thu, 12 Nov 2020 06:02:17 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E176C0613D1 for ; Thu, 12 Nov 2020 03:02:17 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id a3so5083468wmb.5 for ; Thu, 12 Nov 2020 03:02:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VOfJDj7y+29ZeViL6kV6ywYnxqJxhhS/scmeQ+AwyUU=; b=xnYi8HWPfJhINUl5GughYizx5EulzqcrsMAEAjGJ+xbjtyqE85Yq3lTb/b9WroJOez fIe6z4/au00Bj0AM1zlZXZI9NgPYdk5/+asccsKCvKWT5OnQoKN7HZIwWI2qhXHEYK0M +jvneVxEeh6ociRKLCYbBp7vUDYwpJzFG+pYYR8wOd90y8LAO9eCorbLocrL8HraXRzE pIUHRJGpWvTaD2Leq3GUEX9Az/o3beW+/sVSk46BU8z2D+zKRGZSMZURCUZRvlTfy20n VyJeGGyDzB0kl92q0YiLuMLJ64+4dnAtMd0DdmXP+OU53Ls2YYcRUIjy8GQNmKSJIp2a aJpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VOfJDj7y+29ZeViL6kV6ywYnxqJxhhS/scmeQ+AwyUU=; b=bs4z8XSCwBQ1bozBL8zVvwrQZLspTZMkJrgWp7+tHbbNOL+2WCqS18TWKipID8L05j WknAK0se7pyEbovyXueX21+33YkJEcYB4/SRg9YDbDGCDNDQEVNwvnw+7BnL0lYESGnN EY+ZsQl8FGjK763xN5NVi7BnAUCfGs5fr3rB58e5kvHKaXN0gW1Q/c8tAbhkusqPCehe sXVodUK0ZzFqPaZscaquCGrejWuF0FOENfHFjk1JcYkC5Kyo+aDG7Qyf7wzrxfYaz8Bv iYIAAr6QssV5bwvEcQGiUzoidDJGu00zedOIR6GgpZgvK2mux0Cfp9yvPekPX0CDrOo4 OOyQ== X-Gm-Message-State: AOAM532Hsy9gvjHSvFDffq70EQ4Ilne8DfH7LpdlABWRoW4y3YG+FjdY 9TUoNCjhh77S1QoBtdp6AZq/GQ== X-Google-Smtp-Source: ABdhPJxzQzMyykieVm/6jAmybrxw45zJcIIEK+Qk4odsvnT5XcN6YERSI2FNYga4SW+sJ01ZR86vYQ== X-Received: by 2002:a1c:1c1:: with SMTP id 184mr9229111wmb.16.1605178935753; Thu, 12 Nov 2020 03:02:15 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x81sm6515329wmg.5.2020.11.12.03.02.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 03:02:15 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Sangwon Jee , Dmitry Torokhov , Henrik Rydberg , linux-input@vger.kernel.org Subject: [PATCH 06/15] input: touchscreen: melfas_mip4: Remove a bunch of unused variables Date: Thu, 12 Nov 2020 11:01:55 +0000 Message-Id: <20201112110204.2083435-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201112110204.2083435-1-lee.jones@linaro.org> References: <20201112110204.2083435-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/melfas_mip4.c: In function ‘mip4_report_touch’: drivers/input/touchscreen/melfas_mip4.c:474:5: warning: variable ‘size’ set but not used [-Wunused-but-set-variable] drivers/input/touchscreen/melfas_mip4.c:472:5: warning: variable ‘pressure_stage’ set but not used [-Wunused-but-set-variable] drivers/input/touchscreen/melfas_mip4.c:469:7: warning: variable ‘palm’ set but not used [-Wunused-but-set-variable] drivers/input/touchscreen/melfas_mip4.c:468:7: warning: variable ‘hover’ set but not used [-Wunused-but-set-variable] Cc: Sangwon Jee Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/touchscreen/melfas_mip4.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c index f67efdd040b24..9c98759098c7a 100644 --- a/drivers/input/touchscreen/melfas_mip4.c +++ b/drivers/input/touchscreen/melfas_mip4.c @@ -465,13 +465,9 @@ static void mip4_report_keys(struct mip4_ts *ts, u8 *packet) static void mip4_report_touch(struct mip4_ts *ts, u8 *packet) { int id; - bool hover; - bool palm; bool state; u16 x, y; - u8 pressure_stage = 0; u8 pressure; - u8 size; u8 touch_major; u8 touch_minor; @@ -480,14 +476,11 @@ static void mip4_report_touch(struct mip4_ts *ts, u8 *packet) case 1: /* Touch only */ state = packet[0] & BIT(7); - hover = packet[0] & BIT(5); - palm = packet[0] & BIT(4); id = (packet[0] & 0x0F) - 1; x = ((packet[1] & 0x0F) << 8) | packet[2]; y = (((packet[1] >> 4) & 0x0F) << 8) | packet[3]; pressure = packet[4]; - size = packet[5]; if (ts->event_format == 0) { touch_major = packet[5]; touch_minor = packet[5]; @@ -501,14 +494,10 @@ static void mip4_report_touch(struct mip4_ts *ts, u8 *packet) default: /* Touch + Force(Pressure) */ id = (packet[0] & 0x0F) - 1; - hover = packet[1] & BIT(2); - palm = packet[1] & BIT(1); state = packet[1] & BIT(0); x = ((packet[2] & 0x0F) << 8) | packet[3]; y = (((packet[2] >> 4) & 0x0F) << 8) | packet[4]; - size = packet[6]; - pressure_stage = (packet[7] & 0xF0) >> 4; pressure = ((packet[7] & 0x0F) << 8) | packet[8]; touch_major = packet[9]; From patchwork Thu Nov 12 11:01:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11899703 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4591B1391 for ; Thu, 12 Nov 2020 11:05:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B9B22222A for ; Thu, 12 Nov 2020 11:05:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S88QmjUn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727991AbgKLLFP (ORCPT ); Thu, 12 Nov 2020 06:05:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727984AbgKLLCS (ORCPT ); Thu, 12 Nov 2020 06:02:18 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 885C7C0613D4 for ; Thu, 12 Nov 2020 03:02:18 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id a3so5083537wmb.5 for ; Thu, 12 Nov 2020 03:02:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ptuCzI/J/pK9IazFF47wcnYE5/wwDz9k/tG2ZC99w5I=; b=S88QmjUnNDZeCsyETNSmZySh+Xaxhs4CRH6sB6GJSY1DSznnz7bt9ghkTHRhAh0TLn BkM+vR6W06OtSum8nppStkpiiqRaeR9TCpjhvs+j9txHemmPUgV4FYSzwg860LqJ6Cr/ sF4meh0dFzqZesoi600iC+FHeaHQ5dglk9beVgL6ToV4rtSS2/e7r0j6S6gDLMqgrKRO fU6hP9QLV0Hb0s3MNfV7NkpveH+QABSfEPg4hsYlfTOTAU4eLe20s3u5E1GMISFtBT8m AjRkC4bwbsgThL1CjoTe3s5sphwQhjpV/w+VOooMmtcX/caV9R39763GY2NMVP97t2GN U/cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ptuCzI/J/pK9IazFF47wcnYE5/wwDz9k/tG2ZC99w5I=; b=GQ4Or1DQ9r/hT3t3bveJH5U29WQ/R2y/KpsIkPz73hBtPVmwLdX4LZEWxl8gkFsGZc ngJZlcBuCTASiLttmJXtGuXJHbSAbt7te14Y4s15tec7w0fACzr7n9RSpvOMnAGEsSLU OaktoUnTXyMXIcce/PkAThjR+lPnARNHKa+CJW/1YtXepxdnj1gpcV/NktSf8Laoga5A IW8Uey3xTW59JuG6PkhdYah6iLAWj1dul2DcbMXffCrXv+JlhDg5OtEz2ptBPi6/DFg6 mpAbbcdUd1DHAJBkFcduelk/wConFZz5VSvheDR+l46PeevbtcTk+xccx2w1T6KO43G3 HbVg== X-Gm-Message-State: AOAM530UPs9aASQtY1qkc8IS/6Qu60tZS7pBbh9rKJ0uRq7thh8mXCnb DKQeLsqVqCvOp1HP2bter86RbQ== X-Google-Smtp-Source: ABdhPJxTRgilLM/FjlLiQ1ZsOBcH2s9gUfdLNN/bU2pb/97TwO9nWNbbW1J8uTtBkUr128N53mduCA== X-Received: by 2002:a7b:ce84:: with SMTP id q4mr2954963wmj.26.1605178937333; Thu, 12 Nov 2020 03:02:17 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x81sm6515329wmg.5.2020.11.12.03.02.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 03:02:16 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Henrik Rydberg , James Hilliard , Daniel Ritz , linux-input@vger.kernel.org Subject: [PATCH 07/15] input: touchscreen: usbtouchscreen: Remove unused variable 'ret' Date: Thu, 12 Nov 2020 11:01:56 +0000 Message-Id: <20201112110204.2083435-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201112110204.2083435-1-lee.jones@linaro.org> References: <20201112110204.2083435-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/usbtouchscreen.c: In function ‘nexio_read_data’: drivers/input/touchscreen/usbtouchscreen.c:1052:50: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: James Hilliard Cc: Daniel Ritz Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/touchscreen/usbtouchscreen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c index 397cb1d3f481b..c3b7130cd9033 100644 --- a/drivers/input/touchscreen/usbtouchscreen.c +++ b/drivers/input/touchscreen/usbtouchscreen.c @@ -1049,7 +1049,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt) unsigned int data_len = be16_to_cpu(packet->data_len); unsigned int x_len = be16_to_cpu(packet->x_len); unsigned int y_len = be16_to_cpu(packet->y_len); - int x, y, begin_x, begin_y, end_x, end_y, w, h, ret; + int x, y, begin_x, begin_y, end_x, end_y, w, h; /* got touch data? */ if ((pkt[0] & 0xe0) != 0xe0) @@ -1061,7 +1061,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt) x_len -= 0x80; /* send ACK */ - ret = usb_submit_urb(priv->ack, GFP_ATOMIC); + usb_submit_urb(priv->ack, GFP_ATOMIC); if (!usbtouch->type->max_xc) { usbtouch->type->max_xc = 2 * x_len; From patchwork Thu Nov 12 11:01:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11899707 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7B13D139F for ; Thu, 12 Nov 2020 11:05:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52E152222A for ; Thu, 12 Nov 2020 11:05:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TQdfJpcQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727739AbgKLLFO (ORCPT ); Thu, 12 Nov 2020 06:05:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727934AbgKLLCU (ORCPT ); Thu, 12 Nov 2020 06:02:20 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B99CC0613D1 for ; Thu, 12 Nov 2020 03:02:20 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id a65so5115128wme.1 for ; Thu, 12 Nov 2020 03:02:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4itWujiotoYQisXSQ7fjROwshRjEA26YsYFt2SDX4IY=; b=TQdfJpcQKSbZ8SfiZ3c4WrInJ4vysLX2BTlR6ITcAftbm9emW2wWJZyumBo26ThtBu u0PgKCubGc/pqCWfeoq4v4Jdb2fTvLOA2gaAZsDIq56g1weE+9k7iFXv37Cu1vLVqAG8 cZHmTZUnLk39zs8xMq1gM1hOoJGZUlOGZLkFbJxtNbUw8xuJ4bKMkNVqQzVIixFdx4x8 vt8sWr2UXPzQVijeTL//XnZqu2zsbZk6uOJXKhgsPntQWPhsDJIqdlNBP791RqhpAqAO z87YHk8+XdIqWoRoaHoKIxbVjmQ0VTDCCQJrpiHjbXdtLJfOR05ThvAsjYNWHcsQUnVV kPgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4itWujiotoYQisXSQ7fjROwshRjEA26YsYFt2SDX4IY=; b=ZJ+e/tIMgQokFF1zoLo4Z9Rydkg/MXpht/BRnkwf0DZy8PS0f1Nx0cMAZrIm9zgCeO DMs4AI+xMmgzjbn3QKi5jA18rPMXmWGfLCacyIOAeXA9J15K9HbExgNP2nCZgkVCiXJt bBWsCmMFX5D+YACQFqDJ6+luaXBkPnTRgkN3UGYFV+P+3SRMtNUYbAnckI0Vu0cxTXxh 01IE0MDgvjPPsgPlKB5oPc1tICtUGeIJTTrBgzt2M0EpscERF+GbJ/TuccOdnHAlsYob YtiQlgUVhJunqBYgXQAx5vEH7DQE9MGkmXfocYweUfexW8eRtatNgPe4xhtV5ZhpsYJ5 s4ZA== X-Gm-Message-State: AOAM530nR/S38s3aAT5j2H4FEBirK3VeX4DC9e7vsAymMoj7n2aPm++3 808/ZwOjAu78MbjCdVFgk5SG8g== X-Google-Smtp-Source: ABdhPJxbX43EeFV7frl73sbQcSTXcq5whw8kL0kNaJb6Dysa8x99FtnS8yGivRJfQt3K9q+WsEVTcg== X-Received: by 2002:a1c:e1c6:: with SMTP id y189mr8772221wmg.94.1605178938847; Thu, 12 Nov 2020 03:02:18 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x81sm6515329wmg.5.2020.11.12.03.02.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 03:02:18 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Henrik Rydberg , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 08/15] input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp' Date: Thu, 12 Nov 2020 11:01:57 +0000 Message-Id: <20201112110204.2083435-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201112110204.2083435-1-lee.jones@linaro.org> References: <20201112110204.2083435-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/surface3_spi.c: In function ‘surface3_spi_process_touch’: drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable ‘timestamp’ set but not used [-Wunused-but-set-variable] Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/touchscreen/surface3_spi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/input/touchscreen/surface3_spi.c b/drivers/input/touchscreen/surface3_spi.c index ce4828b1415a8..72dc4c562a4e1 100644 --- a/drivers/input/touchscreen/surface3_spi.c +++ b/drivers/input/touchscreen/surface3_spi.c @@ -94,9 +94,7 @@ static void surface3_spi_report_touch(struct surface3_ts_data *ts_data, static void surface3_spi_process_touch(struct surface3_ts_data *ts_data, u8 *data) { - u16 timestamp; unsigned int i; - timestamp = get_unaligned_le16(&data[15]); for (i = 0; i < 13; i++) { struct surface3_ts_data_finger *finger; From patchwork Thu Nov 12 11:01:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11899701 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 76DCE16C1 for ; Thu, 12 Nov 2020 11:05:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A8D02223C for ; Thu, 12 Nov 2020 11:05:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FgtdmpwR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727803AbgKLLFO (ORCPT ); Thu, 12 Nov 2020 06:05:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727909AbgKLLCV (ORCPT ); Thu, 12 Nov 2020 06:02:21 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13962C0617A7 for ; Thu, 12 Nov 2020 03:02:21 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id b6so5535230wrt.4 for ; Thu, 12 Nov 2020 03:02:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iYWVqLY7S/76cWfEGdUmj7rrU+UasLzWnb4c5U8gOxE=; b=FgtdmpwRrYsOn8FUB6Hpe4ElccdLfhBVC2lRp8Urqj16+B+T7tXk0ftLggcVea+k/9 kVtlIgJ6EmASjM5YMA9fShkGvjbb02+DqpQzJI9cKIsHwyhJ+OzMZg9A6GQmMwaw/s5l 6Y/n8AlPUlcwj8qkQXt3v2yIGNzRyfaDvTFTvJHCh5/EUjyaVRt16voCY1nEEVrLtHnu fs09xCf/l9CPRADbvxCSJv0Oc06iM88odOaY9rvrDzGMP3NV6BFkf2Rr23JswoIttinf ynccuJ7ur86ricWzBi2VmX9vehCGi7N8QVIxGHzJzOn6o2MtA9ZMQb9qwl4lAgCljwyL MDxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iYWVqLY7S/76cWfEGdUmj7rrU+UasLzWnb4c5U8gOxE=; b=uDWjIt/eas69KusQx8g7Qpr/gm6aN9zIHoc8Ta12GV4rNTUI0Y8/5xCUxNw0745sBh je6TBfQJAV1V0ffbyaUP5MGyLexqSLCutrzzh4oQmDgfUB2jAyyQ3ZSlbLazgOaF6sy4 O4izmza2hwdbLCb/20WxOVi2QDEFnoRGBr+PqrQBkxvBhBol+EoWTdeQKACaAf+LxWBW 8s7k19R3bGgNTl96V/fYET4VnI/14fn+6CrKXsQwHsuiXBifNl00O08eL0/e+FjXKrij 0AH5wEjskvWXQzOuA28ZH+pNkuc7n9NanlwN+LGQjR5K8ybEBZGXeHol3bicpoQsxm9X eUcQ== X-Gm-Message-State: AOAM530i2pjNh1i4L/fMeHFQZsY2CB06WcuSbwN/p1Mgvm149lr1yE/s +gFjyQw5oqOg00usTo41pJWeyA== X-Google-Smtp-Source: ABdhPJzsfgHXHWLswyYB1RNmQMzrGY50nkRCRdx70M8c5gZjLUnS+JHYkd6dWaToI58kESLJp+ye3g== X-Received: by 2002:adf:8063:: with SMTP id 90mr21087244wrk.148.1605178939843; Thu, 12 Nov 2020 03:02:19 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x81sm6515329wmg.5.2020.11.12.03.02.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 03:02:19 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Mark Brown , patches@opensource.cirrus.com, linux-input@vger.kernel.org Subject: [PATCH 09/15] input: misc: wm831x-on: Source file headers are not good candidates for kernel-doc Date: Thu, 12 Nov 2020 11:01:58 +0000 Message-Id: <20201112110204.2083435-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201112110204.2083435-1-lee.jones@linaro.org> References: <20201112110204.2083435-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/misc/wm831x-on.c:30: warning: cannot understand function prototype: 'struct wm831x_on ' Cc: Dmitry Torokhov Cc: Mark Brown Cc: patches@opensource.cirrus.com Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Richard Fitzgerald --- drivers/input/misc/wm831x-on.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/misc/wm831x-on.c b/drivers/input/misc/wm831x-on.c index 1b44de265a0ad..a42fe041b73c6 100644 --- a/drivers/input/misc/wm831x-on.c +++ b/drivers/input/misc/wm831x-on.c @@ -1,4 +1,4 @@ -/** +/* * wm831x-on.c - WM831X ON pin driver * * Copyright (C) 2009 Wolfson Microelectronics plc From patchwork Thu Nov 12 11:01:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11899697 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C753A1391 for ; Thu, 12 Nov 2020 11:04:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E31A2223C for ; Thu, 12 Nov 2020 11:04:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VhQygiOo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726969AbgKLLEe (ORCPT ); Thu, 12 Nov 2020 06:04:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727942AbgKLLCW (ORCPT ); Thu, 12 Nov 2020 06:02:22 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78CA6C0613D4 for ; Thu, 12 Nov 2020 03:02:22 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id c17so5485225wrc.11 for ; Thu, 12 Nov 2020 03:02:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZQVGs5MUcX5FGl2B0GSyWePcq4JNp/6FjWRufhPjYcY=; b=VhQygiOoSK+sK6f7HkMc+o9zkzRaUN+FSCWD/crO0V8nHR27+xLSjUbKSc7ltAkPPF rKj75y4G0aMj+ioqRWIGJh3F+bT/AD+09bJhZbAB96sZxXR/Crg81ZwIGo5zsGerQWBA eIYAOm5DgjWp+COQ6NBzaN/KucO3rUnUxAeENnEm8gy98aPkLD3Xo/C88T8/t4IBcAIM lgRvlS/F4PFpNaNjjEumIbmGtiJucF4sKa1D44J24lhAAz3vzUYyeGRQYe1haqmg+Gxv EY8KDPXq2mAuPrplhkjUh9QrE5J8/mpjUTn/IlBeZ0kPqKXZg6HRI2kTL2tU+veHFUME hrRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZQVGs5MUcX5FGl2B0GSyWePcq4JNp/6FjWRufhPjYcY=; b=lsgs634L2XC56hSNXMoBotcncBVIFcKq7yvKPs8IxsB8DPYnf6cG8XgC88KZAmchHl RqWLKrgdV2SxysHPUiPGeEQKEcL1rf/BnIN6dnnxFl3vVOqPu5UFdtCvqqVEYIBXN03F kcU/mXL3if/lxJVHyHrmo5nfE0RYp/DpdFximFupS3HpW5XvNiBZ5mwNNqtTlI0jpyPl 49dA/4DZZNfh8Qzs3gMWNudpwQ03u/HdNQV4eYQunSe+cXhMMdhDUvamzuTM2rtfnmbb TP9oskpGzJI/CCfVY053y4fqpWuqbffRWoOPj8iWXoypsY+v56A9DXmiilaMG+yfRvYL 9Crw== X-Gm-Message-State: AOAM5313A5Usx8yDG0Unh1KK38RFy3ex5lXCPi646QBk4fpFKr0Q91fj PohpYeYw0QvnNNp7inr46TsC/g== X-Google-Smtp-Source: ABdhPJwYLGSBuyC85zWYlngJC+Pi/QkUTlnPMLHlWOimyhWy+xhqiTpOPwSU0SIRVvfPM06uTF+WLQ== X-Received: by 2002:adf:e544:: with SMTP id z4mr1114555wrm.83.1605178941187; Thu, 12 Nov 2020 03:02:21 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x81sm6515329wmg.5.2020.11.12.03.02.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 03:02:20 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Henrik Rydberg , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 10/15] input: touchscreen: surface3_spi: Fix naming issue with 'surface3_spi_get_gpio_config's header Date: Thu, 12 Nov 2020 11:01:59 +0000 Message-Id: <20201112110204.2083435-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201112110204.2083435-1-lee.jones@linaro.org> References: <20201112110204.2083435-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/surface3_spi.c: In function ‘surface3_spi_process_touch’: drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable ‘timestamp’ set but not used [-Wunused-but-set-variable] drivers/input/touchscreen/surface3_spi.c:225: warning: Function parameter or member 'data' not described in 'surface3_spi_get_gpio_config' drivers/input/touchscreen/surface3_spi.c:225: warning: Excess function parameter 'ts' description in 'surface3_spi_get_gpio_config' Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: Lee Jones Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/touchscreen/surface3_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/surface3_spi.c b/drivers/input/touchscreen/surface3_spi.c index 72dc4c562a4e1..1da23e5585a0d 100644 --- a/drivers/input/touchscreen/surface3_spi.c +++ b/drivers/input/touchscreen/surface3_spi.c @@ -217,7 +217,7 @@ static void surface3_spi_power(struct surface3_ts_data *data, bool on) /** * surface3_spi_get_gpio_config - Get GPIO config from ACPI/DT * - * @ts: surface3_spi_ts_data pointer + * @data: surface3_spi_ts_data pointer */ static int surface3_spi_get_gpio_config(struct surface3_ts_data *data) { From patchwork Thu Nov 12 11:02:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11899687 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A68B8139F for ; Thu, 12 Nov 2020 11:02:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BF902220B for ; Thu, 12 Nov 2020 11:02:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="q4pAEypD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728028AbgKLLCh (ORCPT ); Thu, 12 Nov 2020 06:02:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728062AbgKLLCZ (ORCPT ); Thu, 12 Nov 2020 06:02:25 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A81A7C061A48 for ; Thu, 12 Nov 2020 03:02:23 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id b6so5535402wrt.4 for ; Thu, 12 Nov 2020 03:02:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B4d/QfbKjqnYQ7wHVGb7VTqafE/Ge7L0vq+yNpxoIB0=; b=q4pAEypDvyqScJDo4EP3Ds6T8AOki+4u3TU68A2urR4ULcQnOQ9poaOly1fH3HclCa i9nwZApvPhjMqB5otxS0ZjymKU4Rh3r2wy4hPm8qz7sGmlNQ/O8iXxMibaD08cZeQJqp nIUtfE2c/pIKtXQnGVPyyhpE/W0Q25akkjBYstWIlvES21aKWw6ZY9to7dBIH96NM83z 4+PgnlYi7aaTCw4be5RCCNuow6ATTdQf2klpNWlIXUtuIhgFlsq1Zz6/sH4mG9dE3Pic xDN+wW/hmzvgAhK8X00FADmwfwI4aO3oHEgby9kRXHOA42xsOrF2rhKGmwsVW7czABJX mmtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B4d/QfbKjqnYQ7wHVGb7VTqafE/Ge7L0vq+yNpxoIB0=; b=izdDMXGOlu6iiAijXMoWiOKlTN9y/QxC7zsYqcdIp8Gzqha10g+KzMNM0+TfLgreVg vVHixCjaioGsJ4rZsuMwJZDhOCiPzSzdXz4drlH9t0zklTS7doct5/cQ27ES1r3kh6cP bmndQSweQoP/gik6uamm5JPDV5b2/2XE85s5E/WzEGXVXd/sLQyAgAcH6nZKw3F3ReFz 7i/yz3rtzKNWBw7C/RdTORSIbBe3m0xwt77aQ4Ri/iqd4L6bn7vxDmAPqZtMMWhW6vb5 10ia4ZKOPjMAVh/Kn9UrHi9LAyruOLfgv8HpAvtyYsCdfFOd7ji66CGZgPZlQz3RqoL7 X25Q== X-Gm-Message-State: AOAM533aLl1O5bt6/jVf3WkOeKg5OUUhNJlBNIrcro6qqxiNCZDbeZu2 0eDXON6kVepK1PPF1ldK3K9f/w== X-Google-Smtp-Source: ABdhPJw755llj/vCgve1wFyJNTYAnMx9OD/zSXfnvYyxLSi6nN6Icd0ygnM2mKKeUJgJ8mnLb25LUg== X-Received: by 2002:adf:e351:: with SMTP id n17mr35767174wrj.308.1605178942386; Thu, 12 Nov 2020 03:02:22 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x81sm6515329wmg.5.2020.11.12.03.02.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 03:02:21 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Liam Girdwood , Ian Molton , Andrew Zabolotny , Russell King , patches@opensource.cirrus.com, linux-input@vger.kernel.org Subject: [PATCH 11/15] input: touchscreen: wm97xx-core: Provide missing description for 'status' Date: Thu, 12 Nov 2020 11:02:00 +0000 Message-Id: <20201112110204.2083435-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201112110204.2083435-1-lee.jones@linaro.org> References: <20201112110204.2083435-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/wm97xx-core.c:204: warning: Function parameter or member 'status' not described in 'wm97xx_set_gpio' Cc: Dmitry Torokhov Cc: Liam Girdwood Cc: Ian Molton Cc: Andrew Zabolotny Cc: Russell King Cc: patches@opensource.cirrus.com Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Richard Fitzgerald --- drivers/input/touchscreen/wm97xx-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/wm97xx-core.c b/drivers/input/touchscreen/wm97xx-core.c index 0a174bd829152..45ce89467c167 100644 --- a/drivers/input/touchscreen/wm97xx-core.c +++ b/drivers/input/touchscreen/wm97xx-core.c @@ -194,7 +194,7 @@ EXPORT_SYMBOL_GPL(wm97xx_get_gpio); * wm97xx_set_gpio - Set the status of a codec GPIO. * @wm: wm97xx device. * @gpio: gpio - * + * @status: status * * Set the status of a codec GPIO pin */ From patchwork Thu Nov 12 11:02:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11899695 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C7DE1139F for ; Thu, 12 Nov 2020 11:04:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0D1F2223C for ; Thu, 12 Nov 2020 11:04:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="c7s4GoHs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726061AbgKLLEe (ORCPT ); Thu, 12 Nov 2020 06:04:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728060AbgKLLCZ (ORCPT ); Thu, 12 Nov 2020 06:02:25 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2163C061A4A for ; Thu, 12 Nov 2020 03:02:24 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id 23so5514036wrc.8 for ; Thu, 12 Nov 2020 03:02:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WvY9te180OdLZG/3R+1QDjkO+/n4VFTObKYg6zpyjpg=; b=c7s4GoHslhO/5aCEeC2U2ciigs2PdRNSMMwlCmib4jNWifhZmO1CFfJbD4xOudP/kE 5Ws5YrVtmAruR8/ODKtauM1baSmvH8vir2NhiFzQj/Z70TRSUCxHnIec1am/9lFysr6Y i0/DgPPjfaXRkL6sBt2jPZkMJxNONSVlzsgiQ006DQ8KNthJqrmiPSDK7mu4KPRf6UB/ 7jScF55NzDiGUdWzutACSRrnlQNm7v80Dwgj6nctNY2LwUERaSqF41L0FXoFMwDCzT3D 8jgIDRNxDggKa35OsNoDn2eQdIM3dQ4whwXqZBTt9Ibi6GzP+tqJfR77bBuRvUFr6oui 2l3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WvY9te180OdLZG/3R+1QDjkO+/n4VFTObKYg6zpyjpg=; b=VVOJGKZAedDdI2EPxODzhsZxIINa1zfLe/sjlj6BsGtE2legMbu1nqnohEg3r3Iy5U oOOwqJ95b3VPUBqKJORyLj0w749eleT5GJVgklfddIXSZ5yysJa0JrE/0TQLO4OE0sVK AxO2I5B/UOyED2kyxleGrfOOEJdk5kmZhln1OBaBM3PoLgj+ZnpbJhGxMapOXnkLUaTK yuIw/QM0sKeiSO/lV+DokEcrKw5KmLl6Xo0cs0k+B9B8KKmagaf0Icu/x6S9W/S3f1VY coK7uWgI3pSTZzwzUUwzmZYJ24AfyZvFw0SekWd5z6gpnLonn2BNASdhx2q6Vk4pPjxm YoDg== X-Gm-Message-State: AOAM532ec1CQX3D2VLO9/v6caAAlTLjWBtBnjl9AODqlRpae9USYjhPx JNildjLiwMtGj9dtpbnerGOHGQ== X-Google-Smtp-Source: ABdhPJypb4Z4PS8wkRi6qUquNvkk/2vA3NoJBB2bf6GPSLoYbfV/3+LRiUE184gwcRldEGTcpv3jRg== X-Received: by 2002:a5d:5686:: with SMTP id f6mr8330558wrv.329.1605178943669; Thu, 12 Nov 2020 03:02:23 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x81sm6515329wmg.5.2020.11.12.03.02.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 03:02:23 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Henrik Rydberg , Peter Osterlund , Stefan Gmeiner , "C. Scott Ananian" , Bruce Kalk , this to Subject: [PATCH 12/15] input: mouse: synaptics: Demote non-conformant kernel-doc header Date: Thu, 12 Nov 2020 11:02:01 +0000 Message-Id: <20201112110204.2083435-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201112110204.2083435-1-lee.jones@linaro.org> References: <20201112110204.2083435-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/mouse/synaptics.c:1781: warning: Function parameter or member 'psmouse' not described in 'synaptics_setup_intertouch' drivers/input/mouse/synaptics.c:1781: warning: Function parameter or member 'info' not described in 'synaptics_setup_intertouch' drivers/input/mouse/synaptics.c:1781: warning: Function parameter or member 'leave_breadcrumbs' not described in 'synaptics_setup_intertouch' Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: Peter Osterlund Cc: Stefan Gmeiner Cc: "C. Scott Ananian" Cc: Bruce Kalk Cc: this to Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/mouse/synaptics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 07835939d83b9..403d0ce0e8bd2 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -1771,7 +1771,7 @@ static int synaptics_create_intertouch(struct psmouse *psmouse, leave_breadcrumbs); } -/** +/* * synaptics_setup_intertouch - called once the PS/2 devices are enumerated * and decides to instantiate a SMBus InterTouch device. */ From patchwork Thu Nov 12 11:02:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11899693 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 67E001391 for ; Thu, 12 Nov 2020 11:03:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E71622241 for ; Thu, 12 Nov 2020 11:03:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DWfYoEQO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728091AbgKLLC7 (ORCPT ); Thu, 12 Nov 2020 06:02:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728069AbgKLLCa (ORCPT ); Thu, 12 Nov 2020 06:02:30 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1017CC061A4C for ; Thu, 12 Nov 2020 03:02:26 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id 33so5526825wrl.7 for ; Thu, 12 Nov 2020 03:02:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=q13pa3CA8d60JdSrIfIwRLUNzuOKQhVdzs81KgY0XSs=; b=DWfYoEQOFtYfEfTrbiPpgx57N/JlSCJ4huAeQqgq82lHGI1NufzVJnXkKJqaq11vhZ VeVA+N/eSqojHUStJDRxrwCigWwv7eCMz96KSzsB3kuV3Eb2EIpzmBlQPTjxc9AL/lHK s+wc8M/Gny52NsLM7ku0PMgtRiQI2PNxzKG296xutecMHWAPLJOmX4/tMlx+TyuAw7pw HZKZzPeBkIh9zahDlOl/ds1QHXCL+w5s12NU8J2bm5SIhbUrpuIoE/SVdyQ/gvM+JogP SsJVUNIUB1fcFJC3p0azo28xfLbEAbskV8+BqaVJhFx/2Yd1n5m4qVAfn2hWJ4nbaiRx 97rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=q13pa3CA8d60JdSrIfIwRLUNzuOKQhVdzs81KgY0XSs=; b=M5bunCqrKM8haN6lBuP1HJj6ADkByMRkCwid3sJzSU8Byc3e4JJoS4yP76b160aOm0 yeKfjukNAW2eYauull5AiYl0gVcFEuRLpL9tfkGk/kZkzm8e49P1n8uVIug246LlW+Rk 5+J3V20mn9TEnuEnPsYzj999UDh/FqJ9DwKAn8e07BjRmrymugClVWLeDQoAZQsmqgVJ R4+AJZSTTO0dN/v+ZrZpseaZ+3zO9iyuqmz+h78x+jvE+Lgov5uf1jlJFB2OGL3aho9z CdiRhHZkUcXGoLxOVnhfRDSnb/lerNNniZ+TBMOxEHSdwtJ+ZDLlikXa0v0IAIM/mk9e 4vfg== X-Gm-Message-State: AOAM531hvLavIvp8akrcd37h/dlcW0Mh6u5aaqQW1V8SXHPAbVKpJNCy z2Mfs5FQ9XEtlfO8eOjpL42BMw== X-Google-Smtp-Source: ABdhPJyAuKsKG1ycPinw+5lG50HywDicLjWaFxJdXUPWgC4SSmqOhYseu9rK8+5tlKw8O7CXlS8EVg== X-Received: by 2002:adf:f24a:: with SMTP id b10mr19242197wrp.352.1605178944840; Thu, 12 Nov 2020 03:02:24 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x81sm6515329wmg.5.2020.11.12.03.02.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 03:02:24 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Bastien Nocera , Dmitry Torokhov , Henrik Rydberg , "K. Merker" , authored by , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 13/15] input: touchscreen: goodix: Fix misspelling of 'ctx' Date: Thu, 12 Nov 2020 11:02:02 +0000 Message-Id: <20201112110204.2083435-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201112110204.2083435-1-lee.jones@linaro.org> References: <20201112110204.2083435-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/goodix.c:1168: warning: Function parameter or member 'ctx' not described in 'goodix_config_cb' drivers/input/touchscreen/goodix.c:1168: warning: Excess function parameter 'ts' description in 'goodix_config_cb' Cc: Bastien Nocera Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: "K. Merker" Cc: authored by Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/touchscreen/goodix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c index 80a82a66a0f3b..c1b728e47827f 100644 --- a/drivers/input/touchscreen/goodix.c +++ b/drivers/input/touchscreen/goodix.c @@ -1159,7 +1159,7 @@ static int goodix_configure_dev(struct goodix_ts_data *ts) * goodix_config_cb - Callback to finish device init * * @cfg: firmware config - * @ts: our goodix_ts_data pointer + * @ctx: our goodix_ts_data pointer * * request_firmware_wait callback that finishes * initialization of the device. From patchwork Thu Nov 12 11:02:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11899689 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 808721391 for ; Thu, 12 Nov 2020 11:02:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5798B2222A for ; Thu, 12 Nov 2020 11:02:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FztJ+8sX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728089AbgKLLCm (ORCPT ); Thu, 12 Nov 2020 06:02:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728070AbgKLLCa (ORCPT ); Thu, 12 Nov 2020 06:02:30 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C9F0C061A4E for ; Thu, 12 Nov 2020 03:02:27 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id a3so5083994wmb.5 for ; Thu, 12 Nov 2020 03:02:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lDq1ucxwNVdiyOuGDpG3UuS4AQsRLKqvrJ8cBQ65tp8=; b=FztJ+8sXVteaVXQlm1MysT50leos1FgWA71xWpI6b3mwdJ/d/0+JXHOTe8qhRiYbwI EU+0NpeyNV3G3gR8P4TPI48MF+tY+7BYbiJSA2wHhPosXHVoYlZH7OIL9usqmtqgkjGT 0zEbOY0mQ1sM3RR+AuS/PBKBrI9okpRyT6BRUYl5O86GEmsFlHD8WFtDWUJ4Ph3Be7DA mnSaqE91cvIPS/6egGhg++TjpAaxQwfZaRU1GJGe58FesqMy6zdOrwyRWBTkglbWn13i C/Hrp2aUvP+O4mlHL4x2gx6sCS2HO2LazlfJc+cXrGtjovpeRgOxeZ2DwgaGj9Wv+gpT IdNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lDq1ucxwNVdiyOuGDpG3UuS4AQsRLKqvrJ8cBQ65tp8=; b=a2iqh3ceGQiuCzNr/MlznLZ/GCBfhYp877SkckTnEJC/hK+Sp/ngmMbF2L5O+X5OKj giuQ9V0Wp7R3VX7syOLxlLFJMXvsm25zBLkgmbV60F3LJcFtzqKYEknYBgiFH2c2Yk38 VKs+W8ZkkfffE/Tpcngm/89smmPAsz50zdNcTPKeUyPPToM8qqXOXAJnJDwroxN9ATLH y0XX1yoLLc5qUthRb+vD8inGWosf2Kvw6u4Tww0gBMyNIdIK/AWDQ2S9dO3UrsIjAuAu P+o27CI1Xeb45bWRzqZ41uO62LEE7zT12j2OdmK+MWMxjHJz58Qwk8LssoCaXc9rYA0M SXHw== X-Gm-Message-State: AOAM532kSKA6xw5rgyY5mZViyUoQNCTdmcKZbYjMEjoq+mlgBk9CMNvG L+weadr2iTQrJB88K2WAffPaqg== X-Google-Smtp-Source: ABdhPJz0T5vXUqEh/5sdw7ELKie10+1/9KTs/+Ako8UhqhB5cLmE0Rqj3oGMOPZqH9MDG/eNhqyVSg== X-Received: by 2002:a1c:87:: with SMTP id 129mr9252628wma.34.1605178946051; Thu, 12 Nov 2020 03:02:26 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x81sm6515329wmg.5.2020.11.12.03.02.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 03:02:25 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Henrik Rydberg , "Gustavo A. R. Silva" , linux-input@vger.kernel.org Subject: [PATCH 14/15] input: keyboard: applespi: Provide missing struct 'message' descriptions Date: Thu, 12 Nov 2020 11:02:03 +0000 Message-Id: <20201112110204.2083435-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201112110204.2083435-1-lee.jones@linaro.org> References: <20201112110204.2083435-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'keyboard' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'touchpad' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'tp_info' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'tp_info_command' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'init_mt_command' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'capsl_command' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'bl_command' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'data' not described in 'message' Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: "Gustavo A. R. Silva" Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/keyboard/applespi.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/input/keyboard/applespi.c b/drivers/input/keyboard/applespi.c index 14362ebab9a9d..8053a3d2ff635 100644 --- a/drivers/input/keyboard/applespi.c +++ b/drivers/input/keyboard/applespi.c @@ -286,6 +286,15 @@ struct command_protocol_bl { * structure (after re-assembly in case of being split over * multiple spi-packets), minus the trailing crc. The total size * of the message struct is therefore @length + 10. + * + * @keyboard: Keyboard message + * @touchpad: Touchpad message + * @tp_info: Touchpad info (response) + * @tp_info_command: Touchpad info (CRC) + * @init_mt_command: Initialise Multitouch + * @capsl_command: Toggle caps-lock LED + * @bl_command: Keyboard brightness + * @data: Buffer data */ struct message { __le16 type; From patchwork Thu Nov 12 11:02:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11899691 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 551111391 for ; Thu, 12 Nov 2020 11:02:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E9092224B for ; Thu, 12 Nov 2020 11:02:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rU/IcTCB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728097AbgKLLCn (ORCPT ); Thu, 12 Nov 2020 06:02:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728076AbgKLLCb (ORCPT ); Thu, 12 Nov 2020 06:02:31 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DD83C061A51 for ; Thu, 12 Nov 2020 03:02:28 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id r17so5564933wrw.1 for ; Thu, 12 Nov 2020 03:02:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8MisLbkhVndMxAYlMMQCECnSCP8aKALlPxLYJrYPFes=; b=rU/IcTCBOxXpCF1frEkmqXpRoww8BjSck635mcTOuRRaR78RPkefsPcpxTaHf+nN+F UTE+hSY3XHGgiM0GjDai4t5IvRCseHH0zgBAl9Ot25jtjDa8iOEmwSd9yiNlPoj84y5b ZqU71TIbWFEmTcinsyFwIYsUaRgJKhET4hRiXqTAWiXqiJIXyDuPwR3XzMHLGeGKXrKx EI2bBamtj/0ppOHe6dllilPq5CY7hRD7AGrKVvZwJ+DVTgjpzZj8bRZhUPmpSQjTi2IQ Dm+XpK9I+5KmmtTURMXCA2Tp5bmL4jDkRulk6wHTTfXshpmoG7wYxsExQcJ0Y/eu3TAW bYlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8MisLbkhVndMxAYlMMQCECnSCP8aKALlPxLYJrYPFes=; b=GPypziXVOKcMtY8gNOaMysXZFkvGTEZL/vI0oRz75sCgbbHDWUDg7EIjiy8hiH7dYD 8Fqet2fftc6yIclGdCZkMsr6/jyLkLkj83Yy5IJ8UVuQ7cJRsdPv1thz+rkA+K8EXXbf HkeRVbmabo/NoPs0bHfn9NRpMKwC+sTsCJKcDj2LcRcdTvCnDkkUnjVMvo67+/o47GFP sDxULfypF5ixs3J9VgLFpsjH96afVnWK6o8pwaOcJPFKyrhJIqtTXv1fqpYpRiFmpvlS voDFGOmfaduHYnEI9jRvDimriGO013B018egDAdAqlIZgDX56el14Xu0miRNczaj75yQ FJwg== X-Gm-Message-State: AOAM5307v4UiEt5qq+ljQ1l8sPUd1UOinoKUlhKGO1prxr07B3wyyfGa D8OV6r7fcMBzRGfBEXA4/qlOng== X-Google-Smtp-Source: ABdhPJzr/VdtNa9Zb16JJ7e23so/+DGmq9whZymA6z78Hcm8qBaRiICDoKfj+yOLKMot9J7amF2uJQ== X-Received: by 2002:adf:b78b:: with SMTP id s11mr27388775wre.42.1605178947411; Thu, 12 Nov 2020 03:02:27 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x81sm6515329wmg.5.2020.11.12.03.02.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 03:02:26 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics , "VMware, Inc." , Dmitry Torokhov , Thomas Hellstrom , linux-input@vger.kernel.org Subject: [PATCH 15/15] input: mouse: vmmouse: Demote obvious abuse of kernel-doc header Date: Thu, 12 Nov 2020 11:02:04 +0000 Message-Id: <20201112110204.2083435-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201112110204.2083435-1-lee.jones@linaro.org> References: <20201112110204.2083435-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/mouse/vmmouse.c:99: warning: Function parameter or member 'cmd' not described in 'VMMOUSE_CMD' drivers/input/mouse/vmmouse.c:99: warning: Function parameter or member 'in1' not described in 'VMMOUSE_CMD' drivers/input/mouse/vmmouse.c:99: warning: Function parameter or member 'out1' not described in 'VMMOUSE_CMD' drivers/input/mouse/vmmouse.c:99: warning: Function parameter or member 'out2' not described in 'VMMOUSE_CMD' drivers/input/mouse/vmmouse.c:99: warning: Function parameter or member 'out3' not described in 'VMMOUSE_CMD' drivers/input/mouse/vmmouse.c:99: warning: Function parameter or member 'out4' not described in 'VMMOUSE_CMD' Cc: VMware Graphics Cc: "VMware, Inc." Cc: Dmitry Torokhov Cc: Thomas Hellstrom Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/mouse/vmmouse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mouse/vmmouse.c b/drivers/input/mouse/vmmouse.c index 148245c69be75..42443ffba7c4d 100644 --- a/drivers/input/mouse/vmmouse.c +++ b/drivers/input/mouse/vmmouse.c @@ -76,7 +76,7 @@ struct vmmouse_data { char dev_name[128]; }; -/** +/* * Hypervisor-specific bi-directional communication channel * implementing the vmmouse protocol. Should never execute on * bare metal hardware.