From patchwork Tue Jul 31 19:26:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Maxime_Roussin-B=C3=A9langer?= X-Patchwork-Id: 10551227 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 06E79139A for ; Tue, 31 Jul 2018 19:33:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EB1D72B49A for ; Tue, 31 Jul 2018 19:33:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DF5E42B49D; Tue, 31 Jul 2018 19:33:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8B5312B49A for ; Tue, 31 Jul 2018 19:33:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730113AbeGaVPL (ORCPT ); Tue, 31 Jul 2018 17:15:11 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:42538 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732093AbeGaVPL (ORCPT ); Tue, 31 Jul 2018 17:15:11 -0400 Received: by mail-qt0-f196.google.com with SMTP id z8-v6so17258186qto.9 for ; Tue, 31 Jul 2018 12:33:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=MXZbbKFcCgmQKWLcUhl+jfMqNwjVkR5QxuhtDyHMdwQ=; b=HX6wSfXkgq4SgSkytRSFA0uWDZ/XCyIycdkvIt21CMucsd9bwt8/7njb0aF6kQzBGI Llt227TWJCCxENMO1XX8VKcFQWQo6tsGszAsuyMnoC48cO48kRkO7HQIWT07oaEqDrm/ TDy4uSR9en2qoyfOqDJLRz9ohC95TINCdz4VHVTZJr8zOExOga7+wrG9lHN+j9VhaxAM GXGxQSD+C9pXF3vawpFHXuS7wtW/GekUOMKc93HEnov4BhyGAW5D1ISf0Zqe7dYizCtY gMhF6yp8/SDdKJx0Xx6pMIjBjR8YUn/EZtIMFIUjrSka0KNd+unH59ust75Me20jH3EJ uJfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=MXZbbKFcCgmQKWLcUhl+jfMqNwjVkR5QxuhtDyHMdwQ=; b=HQl665VQTR8yEBr/z4PFRwvozDbOUlWyLGIWwg7SuKNFV4D+64FMeUq6sVODfGaN2O dy/Mrxb6+pE9CMKeGX+laBI0Bkc5i8hCoiuMHukt3XptGxk/e1bV5eSrPwB/Un1+0EW/ GCPsFUwIuXBqTVvZ2UiG6HU7buTqI+s8z2UOIOd2CXLeRApg+OzgbcxiCJutIZdxOrKh cpOhrq/MhtbVNkBZ2GRUsIJgru0EnuRP3jM3ZF7IDKtE1sEk7SvqsTAnjiUXbGeGozcX a0yibP1xOYV6akJ6+1/kRmZR12ADbIRddvHLaSvZv8Fj5Gqpk0X7gjifyHvaIr2jVste MZDw== X-Gm-Message-State: AOUpUlGts8zSsPson8aaQd4j92d+QP6mhgIIXVdwK8p6ognwksoGsrD9 D82wi1iN4FBbsauGX0hS5H8= X-Google-Smtp-Source: AAOMgpcHJjPrOktpCP9WK02k3WSc37rYGRf/1+AVDYQN4OHKD7t/6pwG6YgFsUD8Bc2fcpthD/rPpg== X-Received: by 2002:a0c:afb8:: with SMTP id s53-v6mr20434091qvc.164.1533065602874; Tue, 31 Jul 2018 12:33:22 -0700 (PDT) Received: from mbedesk.Sonatest.net (ipagstaticip-d73c7528-4de5-0861-800b-03d8b15e3869.sdsl.bell.ca. [174.94.156.236]) by smtp.gmail.com with ESMTPSA id u21-v6sm9991128qka.88.2018.07.31.12.33.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Jul 2018 12:33:22 -0700 (PDT) From: =?utf-8?q?Maxime_Roussin-B=C3=A9langer?= To: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler Cc: linux-iio@vger.kernel.org, =?utf-8?q?Maxime_Roussin-B=C3=A9langer?= Subject: [PATCH] iio: light: si1133: fix uninitialized resp variable Date: Tue, 31 Jul 2018 15:26:51 -0400 Message-Id: <20180731192651.29128-1-maxime.roussinbelanger@gmail.com> X-Mailer: git-send-email 2.18.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Read response register to detect any error. Reported-by: Dan Carpenter --- drivers/iio/light/si1133.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index d3fbeb3bc463..9b8862af0127 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -409,6 +409,9 @@ static int si1133_command(struct si1133_data *data, u8 cmd) err = -ETIMEDOUT; goto out; } + err = regmap_read(data->regmap, SI1133_REG_RESPONSE0, &resp); + if (err) + goto out; } else { err = regmap_read_poll_timeout(data->regmap, SI1133_REG_RESPONSE0, resp,