From patchwork Mon Nov 16 06:15:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Narani X-Patchwork-Id: 11907393 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2044C63697 for ; Mon, 16 Nov 2020 06:16:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8276A2222E for ; Mon, 16 Nov 2020 06:16:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PfUgFIER"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="kkeM12mt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8276A2222E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EaLThjtbucQBJwcLvt7Gh+gVhJIx0FhIBh5oRfLIIfs=; b=PfUgFIEROwuXEQsw82qR1ut3w ac49vzY5shf+LLIU1UQQxKxiTsW4tK03OYtk2/Fb8FEkVLZx/FxB/EenS76+7aWsyhflYoKehoUH9 jKOg3snRc5GLoA4kaudT3i4bqZhMvZaMBJkjqiBMF3coPElBhxjgT8wKbZ60fuGSmM2Em8Jri4DX/ wNShGo9YLdbninrG+bkfQHVsWVD8NKwBwA81xAWjB+gNXbrE+2pW7Hy11F0WahMyJ2cN42gx+tW9Y 7ow9IAr5aGnDD0W9CTJzp0IZURzBA9hFuQz0J8bpavI2gMVVlpt07bPLWXFAvq1N33piwEplEEifC LFi5iagZQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1keXnr-0008NF-VE; Mon, 16 Nov 2020 06:15:51 +0000 Received: from mail-eopbgr760072.outbound.protection.outlook.com ([40.107.76.72] helo=NAM02-CY1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1keXno-0008Ly-OT for linux-arm-kernel@lists.infradead.org; Mon, 16 Nov 2020 06:15:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ALvZvbKzqXuD8EYokRIYJhqZJX1Fpif+SJQtTJVtBVYv98RutPwhZFbNjJcmU+qxy6KCagPfocpbW95R8ddh+ysq6qBpT96zW8Bl5NBJ2q6zKViNgSzPOL70fML48dgKt3ght2hfcsMLXGy54vd/RQ3er3+vZRRRMXRINh2F0Il7zlgWBESHfbboWfu8E3jpJPs6XwcqLyn/cfz+Jh6kFl7Q9puPO2chpfUvyX5QllcfoBJTX/H3Ndz0kSy0fSDChjaAA/AEbrS+gX4tuzF7VC9C3hXrycxWikzitqTYBkGuBp7HL5sLy5yQAEvR0LDX1RSqj8JDlJ6rbUwGmgnCrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2x00KdmMIsg/dPwgAFp/Xd5Lq1B+3I3mFeW1BxVaVQQ=; b=mthyz1B5yom2Y3dUshhlYBVvpaUVkmYnHJrK1CK+Wh5UGNs4B6APFSgXyzOZh4KzhRYeAXrVX4oTnu40YZGfc5TgIgxsQjQXwXr7jfn3YAwtybLW9OkKQZY3/o5e0SQICL0BXQH86k/y3qYrmm3eV1ArBWspHDSdUOFXJGwvlMgZqe78bmE2BUPHKopwOH/WAF9oQ2EQgmT6lu0QSXuoi54Evm4Kjv+12ncwoGIF3X6uc1uovGsDeiNGBTcedoSRxRNWZ4wkySehiVCs8N1QveSNeumN8PZZrv1EiZp2/1HmQIxVmoUFhtN0DaZmrcjxMO0gDo8NuIrxqt6xWe6jtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=intel.com smtp.mailfrom=xilinx.com; dmarc=bestguesspass action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2x00KdmMIsg/dPwgAFp/Xd5Lq1B+3I3mFeW1BxVaVQQ=; b=kkeM12mtKGama1MXWB/gOkB7mGiNePlGMSUaIGVF39kiX8Ao9KWHuw/J5YJgrtfsV9aRxHu20Anz6Nri3tFUD7vPEBFNNhg20OvnPeS8mnHYUF2yMKhMgs8DqnCxe/4FvflgHitjaSifZW3fsqJoJc5NKRPVWAPyxeTs8udUXgo= Received: from CY1PR07CA0016.namprd07.prod.outlook.com (2a01:111:e400:c60a::26) by BL0PR02MB5492.namprd02.prod.outlook.com (2603:10b6:208:8c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.28; Mon, 16 Nov 2020 06:15:45 +0000 Received: from CY1NAM02FT052.eop-nam02.prod.protection.outlook.com (2a01:111:e400:c60a:cafe::14) by CY1PR07CA0016.outlook.office365.com (2a01:111:e400:c60a::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25 via Frontend Transport; Mon, 16 Nov 2020 06:15:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by CY1NAM02FT052.mail.protection.outlook.com (10.152.74.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3564.22 via Frontend Transport; Mon, 16 Nov 2020 06:15:44 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Sun, 15 Nov 2020 22:15:43 -0800 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.1913.5 via Frontend Transport; Sun, 15 Nov 2020 22:15:43 -0800 Received: from [172.23.64.106] (port=44807 helo=xhdvnc125.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1keXni-0007IV-Ln; Sun, 15 Nov 2020 22:15:42 -0800 Received: by xhdvnc125.xilinx.com (Postfix, from userid 16987) id B4E7A12109C; Mon, 16 Nov 2020 11:45:28 +0530 (IST) From: Manish Narani To: , , Subject: [PATCH 1/2] mmc: sdhci-of-arasan: Use Mask writes for Tap delays Date: Mon, 16 Nov 2020 11:45:26 +0530 Message-ID: <1605507327-106818-2-git-send-email-manish.narani@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1605507327-106818-1-git-send-email-manish.narani@xilinx.com> References: <1605507327-106818-1-git-send-email-manish.narani@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 425d1b62-13ed-41fd-53f8-08d889f70d62 X-MS-TrafficTypeDiagnostic: BL0PR02MB5492: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3rz7KE22aI12qEtH8keC+oKcF8AlVOHYazdxs0bpK3qomRz0K5W9yXwQ5SJMKiMxGTs/6ylDYVT7cIZJWvOZFNPKfH/gFy+TR1iaDMJUfbebd4r0glFuMv1eZ6Sp8Iu11q5sv/K+2KzvVwQnbdK6LZcHRvZ863pM8ytD2a4oF86wM59igNHTUhb98EEv8vJ8xAj1YD736bQigbaP0gA/y5cZpEaCSkOsba9NVxOgBugL9E1KyyhADDAIIQs2dOdFIC+frT3c+miqbUbexMuuEKtAGx3cSlDm9YEbLSgA5Cx7NPlDtYfzBz1/lvOXKW3IQ1/uG3oA8nHbVudo1rXlN17AYpVsb8zVH3RuZ9lRI/DiQmIOmKFgGVB6cX96m0hX6E4Ic/9mc7W6EaeIJQgDqH9Z7Ajig4UgW6qLR8VbJzg= X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch02.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(39850400004)(396003)(376002)(346002)(136003)(46966005)(8676002)(2906002)(336012)(8936002)(107886003)(4326008)(6266002)(26005)(186003)(2616005)(426003)(44832011)(36756003)(47076004)(82740400003)(356005)(7636003)(5660300002)(70586007)(70206006)(36906005)(82310400003)(316002)(42186006)(54906003)(110136005)(478600001)(102446001); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2020 06:15:44.6780 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 425d1b62-13ed-41fd-53f8-08d889f70d62 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: CY1NAM02FT052.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB5492 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201116_011548_822608_D6743B6C X-CRM114-Status: UNSURE ( 9.40 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sai Krishna Potthuri , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Manish Narani , git@xilinx.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Mask the ITAP and OTAP delay bits before updating with the new tap value for Versal platform. Fixes: 1a470721c8f5 ("sdhci: arasan: Add support for Versal Tap Delays") Signed-off-by: Sai Krishna Potthuri Signed-off-by: Manish Narani Acked-by: Michal Simek --- drivers/mmc/host/sdhci-of-arasan.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index 100621e55427..3ec5ecad637c 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -30,7 +30,10 @@ #define SDHCI_ARASAN_VENDOR_REGISTER 0x78 #define SDHCI_ARASAN_ITAPDLY_REGISTER 0xF0F8 +#define SDHCI_ARASAN_ITAPDLY_SEL_MASK 0xFF + #define SDHCI_ARASAN_OTAPDLY_REGISTER 0xF0FC +#define SDHCI_ARASAN_OTAPDLY_SEL_MASK 0x3F #define SDHCI_ARASAN_CQE_BASE_ADDR 0x200 #define VENDOR_ENHANCED_STROBE BIT(0) @@ -755,6 +758,7 @@ static int sdhci_versal_sdcardclk_set_phase(struct clk_hw *hw, int degrees) regval = sdhci_readl(host, SDHCI_ARASAN_OTAPDLY_REGISTER); regval |= SDHCI_OTAPDLY_ENABLE; sdhci_writel(host, regval, SDHCI_ARASAN_OTAPDLY_REGISTER); + regval &= ~SDHCI_ARASAN_OTAPDLY_SEL_MASK; regval |= tap_delay; sdhci_writel(host, regval, SDHCI_ARASAN_OTAPDLY_REGISTER); } @@ -822,6 +826,7 @@ static int sdhci_versal_sampleclk_set_phase(struct clk_hw *hw, int degrees) sdhci_writel(host, regval, SDHCI_ARASAN_ITAPDLY_REGISTER); regval |= SDHCI_ITAPDLY_ENABLE; sdhci_writel(host, regval, SDHCI_ARASAN_ITAPDLY_REGISTER); + regval &= ~SDHCI_ARASAN_ITAPDLY_SEL_MASK; regval |= tap_delay; sdhci_writel(host, regval, SDHCI_ARASAN_ITAPDLY_REGISTER); regval &= ~SDHCI_ITAPDLY_CHGWIN; From patchwork Mon Nov 16 06:15:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Narani X-Patchwork-Id: 11907397 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75630C55ABD for ; Mon, 16 Nov 2020 06:16:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1663A2222E for ; Mon, 16 Nov 2020 06:16:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="udoxUz2S"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="RmCvgP1c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1663A2222E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=et1AW9xuyv1G5S0bCtuMT2scbb8SBdJoXPgtSM2lX+w=; b=udoxUz2SZZfC9c0NIrYUZ2Z6r wHZZ1m6cXzjCbiUXJYynn4Ub6+jLYz0/fdOWG+ioDo40xyNIAfWL5Q8ht7GYRXWzuxrv0IumG6u0J Y1kXFz5RZVNezGew7vBZki6cY2Iy7HuXRPQCPF7jY7VquzGG2DyPcl2Y1ecGyyH5lKPv+SSVBetpV nACpA2Xhf+/jx7jY9wqM936KQaxP/ajg5eYpPI4/xQoorKEuWIyBrFYXmI33GUKBiNSYi6CxV6osX G5ZDxiOiiMyq+rMLWdFcrtqPTXr8behe800IdXjJ2xNeDmEacVGi87XyZk7Ly1NdVKx6Orc/DZAmC vQP3Mu/lw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1keXoB-0008Rx-BA; Mon, 16 Nov 2020 06:16:11 +0000 Received: from mail-bn8nam12on2077.outbound.protection.outlook.com ([40.107.237.77] helo=NAM12-BN8-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1keXo2-0008PZ-LS for linux-arm-kernel@lists.infradead.org; Mon, 16 Nov 2020 06:16:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kde9huFVAd2cfO6AFMRi4PY3cOLO/f+EHk0q11yFAxdQnr2fth5/w3jKx/rpwpm/uevuiRYcjrpRO9f+mAfG9pjDJ0fW9vHoEfUPtVzoR8oRj5QNeFyQHODvUZ5/bLgiWZwIb89fMpCo5rhzyd7/Ckc2RqPEZa1a+04wpcuWrCEd+ImwppnN1Sti7+v/FEaSpiJEk9J83kwC4YJkj7ypcVrklj1P6sDX6VxqPBdi0FStUItGshBd96dgDsABxfqDTIS7JpQ4ZrF470vaeuwUoVR5kyEYI0Ko/z/6dOTWbXpuZ190OXFor0E/gHC6F10TR1fNPmXERgowl4pX4XuYZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/rqxRj7fk9vRZ7vZxg7lmIfJVMJucO5hfkvBtxlvhzA=; b=OxqgbcGzzrhG3u4G+ywwuJZLdywLnDEQ09ppKjhLEzsDepASui34JjxGhitG7970gOT45HI9zhNreLl8krb5YmVxbA+6VF3ITutEvhPCqySxLR1DFpQCnYjYmYoLtWErjAvmwezQydk5PQe3YIogsfgJT2Cb3veqIuWJMrxKsmJRQXQfoMKr1gYMEqD7nOLlLGa4NH9pCQ/3co6giodtbXUE9rL1kyKDClrtvMy376Q4RRBLUG+ChoWivvCV5PAhpFp44sRKzQT0FmMTTVOe1GiDtmix7sBuingY6hnn1U+0aNooN7p+2MwzygllSmkgKLo6bIH++V+q1UCbS7umiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=intel.com smtp.mailfrom=xilinx.com; dmarc=bestguesspass action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/rqxRj7fk9vRZ7vZxg7lmIfJVMJucO5hfkvBtxlvhzA=; b=RmCvgP1cgcT74Kia2Stbl7UEIK2mE9vwX3AMNBL4zfERZmtppPhPEeX3dE1V66kj0b/PcuboxSFdDBfgUZR7QaRVOjneUBQvtfoMXH/lIcq79lEbY9viphM8lFQTP/T2UtsoB7pk0D79Z4oZA3+yCmcAVD873T4jbd3QOVGVXYk= Received: from CY4PR16CA0047.namprd16.prod.outlook.com (2603:10b6:910:60::34) by CY4PR02MB2872.namprd02.prod.outlook.com (2603:10b6:903:127::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Mon, 16 Nov 2020 06:16:00 +0000 Received: from CY1NAM02FT062.eop-nam02.prod.protection.outlook.com (2603:10b6:910:60:cafe::f4) by CY4PR16CA0047.outlook.office365.com (2603:10b6:910:60::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.28 via Frontend Transport; Mon, 16 Nov 2020 06:16:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by CY1NAM02FT062.mail.protection.outlook.com (10.152.75.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3564.22 via Frontend Transport; Mon, 16 Nov 2020 06:15:59 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Sun, 15 Nov 2020 22:15:56 -0800 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.1913.5 via Frontend Transport; Sun, 15 Nov 2020 22:15:56 -0800 Received: from [172.23.64.106] (port=44810 helo=xhdvnc125.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1keXnv-0007Ji-RZ; Sun, 15 Nov 2020 22:15:56 -0800 Received: by xhdvnc125.xilinx.com (Postfix, from userid 16987) id C221E121216; Mon, 16 Nov 2020 11:45:28 +0530 (IST) From: Manish Narani To: , , Subject: [PATCH 2/2] mmc: sdhci-of-arasan: Issue DLL reset explicitly Date: Mon, 16 Nov 2020 11:45:27 +0530 Message-ID: <1605507327-106818-3-git-send-email-manish.narani@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1605507327-106818-1-git-send-email-manish.narani@xilinx.com> References: <1605507327-106818-1-git-send-email-manish.narani@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ddb60ea0-d9c3-4abc-9480-08d889f716dd X-MS-TrafficTypeDiagnostic: CY4PR02MB2872: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +VlW3FG/abpn2z2/3Jv5kP8B0uUB35YY+Er/R1HtrToQNRBOmGvGQ7NHCMJL/703NKQPAjVutojEzzahgpOTJLLfbRuaaI06eDGt/eIliaa2iNsppjEIjd09N6FZj3Jw8XHyUX8Gk2lgsjXzHzX91EEwkCx0y+IBW5C1aeTIR4mDtITqiApCzwVKWU8S156AfiDYjg3CcE2ZSiquGB+DVOsqmCJ32uf1Ppma1Aoy7bj+4b7J6dNw6bHnzdc3lM9aqCKqLakO/hn3SlXqZcpDJtQQoGx43V544B5GBrLvdNKkGRNbKt9bwwHn75NXMeB5eB6OVnwsc1ICsVFDg6d0fCWXyQikmq4yA9/1Oe9t2KNlR/KkIXDdVNUQn3spcslStjdE8MwbBHCKfaX35Xg3wglDtELTfb5upl6xPtpxSdc= X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch02.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(39850400004)(346002)(376002)(136003)(396003)(46966005)(336012)(356005)(186003)(7636003)(82740400003)(47076004)(6266002)(107886003)(36756003)(26005)(2616005)(426003)(478600001)(4326008)(44832011)(8936002)(42186006)(36906005)(110136005)(54906003)(316002)(2906002)(70206006)(83380400001)(8676002)(5660300002)(82310400003)(70586007)(102446001); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2020 06:15:59.5378 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ddb60ea0-d9c3-4abc-9480-08d889f716dd X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: CY1NAM02FT062.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR02MB2872 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201116_011602_754696_34C2E364 X-CRM114-Status: GOOD ( 10.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sai Krishna Potthuri , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Manish Narani , git@xilinx.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In the current implementation DLL reset will be issued for each ITAP and OTAP setting inside ATF, this is creating issues in some scenarios and this sequence is not inline with the TRM. To fix the issue, DLL reset should be removed from the ATF and host driver will request it explicitly. This patch update host driver to explicitly request for DLL reset before ITAP (assert DLL) and after OTAP (release DLL) settings. Fixes: a5c8b2ae2e51 ("mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup") Signed-off-by: Sai Krishna Potthuri Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index 3ec5ecad637c..e066d8f51954 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -635,6 +635,9 @@ static int sdhci_zynqmp_sdcardclk_set_phase(struct clk_hw *hw, int degrees) if (ret) pr_err("Error setting Output Tap Delay\n"); + eemi_ops->ioctl(node_id, IOCTL_SD_DLL_RESET, + PM_DLL_RESET_RELEASE, 0, NULL); + return ret; } @@ -794,6 +797,9 @@ static int sdhci_versal_sampleclk_set_phase(struct clk_hw *hw, int degrees) if (host->version < SDHCI_SPEC_300) return 0; + eemi_ops->ioctl(node_id, IOCTL_SD_DLL_RESET, + PM_DLL_RESET_ASSERT, 0, NULL); + switch (host->timing) { case MMC_TIMING_MMC_HS: case MMC_TIMING_SD_HS: