From patchwork Mon Nov 16 08:25:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tzung-Bi Shih X-Patchwork-Id: 11907685 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DDE22697 for ; Mon, 16 Nov 2020 08:26:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6B2C20702 for ; Mon, 16 Nov 2020 08:26:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="JsL/W1lT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726302AbgKPI0K (ORCPT ); Mon, 16 Nov 2020 03:26:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726281AbgKPI0J (ORCPT ); Mon, 16 Nov 2020 03:26:09 -0500 Received: from mail-qv1-xf49.google.com (mail-qv1-xf49.google.com [IPv6:2607:f8b0:4864:20::f49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70EE0C0613CF for ; Mon, 16 Nov 2020 00:26:09 -0800 (PST) Received: by mail-qv1-xf49.google.com with SMTP id u19so10275039qvx.4 for ; Mon, 16 Nov 2020 00:26:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=FGK3po+1mabmofbsrOAmqgZTB285sISrAEMhHIPEXVY=; b=JsL/W1lTuj6I5ZApSjpS7ca/5BQyo4GmrFUADec+nmp2dPG5WZqt3B+a7DbQaVymYU x6f2oycz6c8JtN9wbjU7JRHN5+lvqWJAIiT97Q5+7aQVf/Io/EUh2rKdP/QJ9N8XWQaS 9gaGS9xBbiCluwBzhShkSc2E5FHOUW+cSc+46uw7R4MS5y94nQImZ2Ihb7HlwdcfFjgY L+SsuYC5oaTo4rUy5ZOGTDLTXH0rLMswsJHlMJrrSUkuvqVhGc+2xz75zROYAw52tcuA pz5sB6lq3VnDeAxlylx+pHesOCHROgprfGpQ9q7kY023QojLs4IjQ6879cCAY8Vn3Z3x C0zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=FGK3po+1mabmofbsrOAmqgZTB285sISrAEMhHIPEXVY=; b=E1m/QWkH1OTZXbBKQkSn6lezIP4jQbynyzlbgS5hQppy3DPSWtpVTRZSdmcC/weUHt Tw5VZqrfkmSooywOJTFs8oNTLKi59BFl8Il95q3enCh+uAQ4ncEN4z0Ql5/5xmGEy3BD ZDMJJF1AENQN/DsAGw+iNcXA3EMHcWGjAMhksq3KA9mCkfS101EogncZVUv6ENMEjw0P aAzM3AEV8lMgufkp4JSpLpOrxydxjPT6qr0syXAzJZUjT3E/MVYfWlUm27y3YsZGIqC3 qrBYEDzwGhDT8zcqA5YYRFkQBCSFR4ASmqJZI7uy5Hl6nL11aGvoYg4sszKKZov3R3Ph +jug== X-Gm-Message-State: AOAM533lUAjB/l/sEI8kMYASCcwYhx+PiFnRa8KsZqQ5yxMo/3iXvT32 8nN5NAlhB2pq3jA5EHPTAgSHO4J1nClS X-Google-Smtp-Source: ABdhPJzDrTnHczzHtkZNBK/N7SQ6we1yTn8KBhiJm4PEqnZsFVM7m+93BhG3MptVNJqxfLnG0DfgmB+BOgq7 Sender: "tzungbi via sendgmr" X-Received: from tzungbi-z840.tpe.corp.google.com ([2401:fa00:1:b:725a:fff:fe41:c6a5]) (user=tzungbi job=sendgmr) by 2002:ad4:54cd:: with SMTP id j13mr13656224qvx.8.1605515168633; Mon, 16 Nov 2020 00:26:08 -0800 (PST) Date: Mon, 16 Nov 2020 16:25:36 +0800 In-Reply-To: <20201116082537.3287009-1-tzungbi@google.com> Message-Id: <20201116082537.3287009-2-tzungbi@google.com> Mime-Version: 1.0 References: <20201116082537.3287009-1-tzungbi@google.com> X-Mailer: git-send-email 2.29.2.299.gdc1121823c-goog Subject: [PATCH v2 1/2] remoteproc/mediatek: fix sparse errors on sram power on and off From: Tzung-Bi Shih To: ohad@wizery.com, bjorn.andersson@linaro.org Cc: linux-remoteproc@vger.kernel.org, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, groeck@chromium.org, drinkcat@chromium.org, pihsun@chromium.org, tzungbi@google.com, kernel test robot Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org Fixes the following sparse errors on sram power on and off: On drivers/remoteproc/mtk_scp.c:306:17: warning: incorrect type in argument 2 (different address spaces) expected void volatile [noderef] __iomem *addr got void *addr On drivers/remoteproc/mtk_scp.c:307:9: warning: incorrect type in argument 2 (different address spaces) expected void volatile [noderef] __iomem *addr got void *addr On drivers/remoteproc/mtk_scp.c:314:9: warning: incorrect type in argument 2 (different address spaces) expected void volatile [noderef] __iomem *addr got void *addr On drivers/remoteproc/mtk_scp.c:316:17: warning: incorrect type in argument 2 (different address spaces) expected void volatile [noderef] __iomem *addr got void *addr Reported-by: kernel test robot Signed-off-by: Tzung-Bi Shih Reviewed-by: Nicolas Boichat Reviewed-by: Mathieu Poirier --- drivers/remoteproc/mtk_scp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c index 577cbd5d421e..8ed89ea1eb78 100644 --- a/drivers/remoteproc/mtk_scp.c +++ b/drivers/remoteproc/mtk_scp.c @@ -298,7 +298,7 @@ static int mt8183_scp_before_load(struct mtk_scp *scp) return 0; } -static void mt8192_power_on_sram(void *addr) +static void mt8192_power_on_sram(void __iomem *addr) { int i; @@ -307,7 +307,7 @@ static void mt8192_power_on_sram(void *addr) writel(0, addr); } -static void mt8192_power_off_sram(void *addr) +static void mt8192_power_off_sram(void __iomem *addr) { int i; From patchwork Mon Nov 16 08:25:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tzung-Bi Shih X-Patchwork-Id: 11907687 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 295521746 for ; Mon, 16 Nov 2020 08:26:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00ECA20702 for ; Mon, 16 Nov 2020 08:26:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QOBEhTLv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726281AbgKPI0O (ORCPT ); Mon, 16 Nov 2020 03:26:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726176AbgKPI0O (ORCPT ); Mon, 16 Nov 2020 03:26:14 -0500 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22BABC0613CF for ; Mon, 16 Nov 2020 00:26:13 -0800 (PST) Received: by mail-yb1-xb4a.google.com with SMTP id c137so3249781ybf.21 for ; Mon, 16 Nov 2020 00:26:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=iRKdGUeQKewf5nuXxBX2agP7HYNBW301CirwCFhx4pU=; b=QOBEhTLv6QVv/QjZqTP+H+yyG/6mzw35iNQXRNy1YtY/1cays5xvfiDfdKHvbTTDS+ 2YSyEvQ1HADSKiodkgTxOjX1QQDG/L/gJ5iA9Hz6adaEPpASQUu9DvqifQpNAgE0nU5T PFlgzbIQ6XbOXWAe2kerZkJUBEkmpnLyQ/IFB7WXMy76lv+rK/fasC7cEZd6DmdebDpv S9uV5tIvfjS1zglfg1qhhPaqBfBcIyqFWgO309RdbxgEAR6aj4e4GoSvWVjA7JrnV0Un l8bNzLcVj+e56k+Eq1KzcueJlH62U0gTkqNjKyzsuqyyr4g2L8Ist6sX40HSJZh9IgFE 7Tmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=iRKdGUeQKewf5nuXxBX2agP7HYNBW301CirwCFhx4pU=; b=qzC7xVglstcPuRJL5GU+/WIc+T68jLk/ROAYNyCEnWQAHqjnNM9p1ZNvE6Xbi0nVn7 JUJY4KDUCh3sTld0Qg58cnczFobwwV27zsvwUcMNzgAjbfaKMELbK5RfJlEQEaHHyfg/ F7vEyKRBzPdcciA1/4vWECtZhBdS4lLE3BqYNUk859pnGc0QHIr5NsEwdDHBEZnWvc2Y 90RfX5u7rbsXrWTwp6OpOfAGSoVV+EVmMhxWT/eTjDRgDZ8VfcNgHeEvTSIXOPzHewSm v7XIsMi0NFDdMjKqRKoJMboY9e+3P5zMC+gXO80eCsX/ALYcnirCJs4BsCguBy0lvEYZ Ue2g== X-Gm-Message-State: AOAM531Nc8G2rtAD6dedzgWrdNYxxwFhgrr310/0CCHTA4v8CYDGL9p5 VOMtzBQivtTyhlSfzjNsBHas9ZPQFa/c X-Google-Smtp-Source: ABdhPJw0N0XKpM+KTbbElpvFZIMiwftJ2h8EAOI91tZQq6qWMiAPMPFuFLr/2HlvN0EDQXvVSWUOTPNvIvX4 Sender: "tzungbi via sendgmr" X-Received: from tzungbi-z840.tpe.corp.google.com ([2401:fa00:1:b:725a:fff:fe41:c6a5]) (user=tzungbi job=sendgmr) by 2002:a25:da0f:: with SMTP id n15mr13910518ybf.481.1605515172335; Mon, 16 Nov 2020 00:26:12 -0800 (PST) Date: Mon, 16 Nov 2020 16:25:37 +0800 In-Reply-To: <20201116082537.3287009-1-tzungbi@google.com> Message-Id: <20201116082537.3287009-3-tzungbi@google.com> Mime-Version: 1.0 References: <20201116082537.3287009-1-tzungbi@google.com> X-Mailer: git-send-email 2.29.2.299.gdc1121823c-goog Subject: [PATCH v2 2/2] remoteproc/mediatek: fix sparse errors on dma_alloc and dma_free From: Tzung-Bi Shih To: ohad@wizery.com, bjorn.andersson@linaro.org Cc: linux-remoteproc@vger.kernel.org, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, groeck@chromium.org, drinkcat@chromium.org, pihsun@chromium.org, tzungbi@google.com, kernel test robot Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org Fixes the following sparse errors on dma_alloc_coherent() and dma_free_coherent(). On drivers/remoteproc/mtk_scp.c:559:23: warning: incorrect type in assignment (different address spaces) expected void [noderef] __iomem *cpu_addr got void * On drivers/remoteproc/mtk_scp.c:572:56: warning: incorrect type in argument 3 (different address spaces) expected void *cpu_addr got void [noderef] __iomem *cpu_addr The cpu_addr is not a __iomem address. Removes the marker. Reported-by: kernel test robot Signed-off-by: Tzung-Bi Shih Reviewed-by: Nicolas Boichat Reviewed-by: Mathieu Poirier --- drivers/remoteproc/mtk_common.h | 2 +- drivers/remoteproc/mtk_scp.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/mtk_common.h b/drivers/remoteproc/mtk_common.h index 47b4561443a9..b3397d327786 100644 --- a/drivers/remoteproc/mtk_common.h +++ b/drivers/remoteproc/mtk_common.h @@ -99,7 +99,7 @@ struct mtk_scp { bool ipi_id_ack[SCP_IPI_MAX]; wait_queue_head_t ack_wq; - void __iomem *cpu_addr; + void *cpu_addr; dma_addr_t dma_addr; size_t dram_size; diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c index 8ed89ea1eb78..a1e23b5f19b9 100644 --- a/drivers/remoteproc/mtk_scp.c +++ b/drivers/remoteproc/mtk_scp.c @@ -413,7 +413,7 @@ static void *scp_da_to_va(struct rproc *rproc, u64 da, size_t len) } else if (scp->dram_size) { offset = da - scp->dma_addr; if (offset >= 0 && (offset + len) < scp->dram_size) - return (void __force *)scp->cpu_addr + offset; + return scp->cpu_addr + offset; } return NULL;