From patchwork Mon Nov 16 08:32:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Narani X-Patchwork-Id: 11907723 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA33AC55ABD for ; Mon, 16 Nov 2020 08:34:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54285207BC for ; Mon, 16 Nov 2020 08:34:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fm0PccH9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="K4Bjixvs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54285207BC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6VvWwfjVZdoICt5QjLidw1tK8t1mQ+H+OHkJeW1IaCE=; b=fm0PccH9NkF6T7ASMdyd2zcIT W319tjHf0egTun2kndF5hyT4kfbeiM2+abmLnw9D5FWpVYz4fmPWXxCu+ata+cbYL2LBEAbw7ovx4 FTvLKEOu+qacg/zwHTguQOI4zRDP0uzNVlqz46oNvxyAH5JButMgkJmBmWAjTazx0VPMP95EhEnFG 9Vkc3kGaAHiJ40gQ9mSyqmpHl5q4uZ9B/NpXa5dIiTQs8bRn23NUKH1E4KnXDS4mRV058yPv3ochk Gm4BG46Bj+vKEoUd2tm0B0QnC6WLnL8X/L0xq6/5VzQfmlFJve0V866/aayPWaufJMX90f8F4gGlu nQ+cqIuYA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1keZxB-0000Hh-JQ; Mon, 16 Nov 2020 08:33:37 +0000 Received: from mail-co1nam11on2084.outbound.protection.outlook.com ([40.107.220.84] helo=NAM11-CO1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1keZx9-0000Fz-97 for linux-arm-kernel@lists.infradead.org; Mon, 16 Nov 2020 08:33:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lg0rmsr5gUiBko2uKpzL8g5ur1AppMsF2d/76uwBzFrGCoZ+hDg9iOsIPMMcHFcZiEpDjO186uBwFGruUiKGgKxZbO1wplWCYNgXebbg7JAZczXqQ7XjFfCh4Z45wfVht2pYBBLHu9NcsHEncKv+ykkVS2+bODUsKHxz+7sm1NA8h+cHqVIefUd9Lz2sdIoEUzBCi4Ju1mdUHcnsqcXj/Rd4O0hJSAyik+4/BM1RAStyQRpMK43XAFaJ0VjpeLXWzJUY99SR5CweWC41txs6o9pdkKPsVQPcxW35tw6hG9iH43SUjYiEr1AS3H83uxkEtLQ6d7Lkog8KAs4REPDlfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nDlnLgqE+mpMh1k2o/if8A3nKkv8KASdChtlgJNAs/g=; b=k2vQ/Xzzmz9eRxOJ2kDXZqtyYfAMqCTYa380X6RXOLfT/IOheHkFT7pflXDJNcW13Jiv9fwfz+l8HiGhWe/32T527B+SZaR/goiuNO+gmI7IUQJvj7w4Zr1ctobPVgKcIfinlShVF5ctE1oIQYKlzf2OLm33BWEohCk83MPZZniLHUcbiA5oTfmZJekjU9OZmRSsefqMXIuvqDEA3ObMZCKd9AQruu7GB4PofwzFytjgSX4y2ZDwjxS9sD/s24qbWpZgbxcu34/OAYm2xM7UBnb2b93UMm9YnUWofzX29o4h4bwBC0GmmJxMXzASpmSMgiNm3mWgi03ob2DhMunI8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=intel.com smtp.mailfrom=xilinx.com; dmarc=bestguesspass action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nDlnLgqE+mpMh1k2o/if8A3nKkv8KASdChtlgJNAs/g=; b=K4Bjixvstuk3kPWO9TRwHhj8QDmXFluN5HlPbvyRm2xAKdsJ+M1H0EH4yVVRJMX6H0u6UxFlBq4BWyhBbGfRTMCkRRmEarHjgg9vb9aw1oE4H9sQSfju0qGn6b2OpkHgqVWcUnuLehv6cc/m/slYwbzxC5olSuW3k0VLjSVE4CA= Received: from BL0PR02CA0100.namprd02.prod.outlook.com (2603:10b6:208:51::41) by DM5PR02MB3324.namprd02.prod.outlook.com (2603:10b6:4:66::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.19; Mon, 16 Nov 2020 08:33:27 +0000 Received: from BL2NAM02FT020.eop-nam02.prod.protection.outlook.com (2603:10b6:208:51:cafe::c3) by BL0PR02CA0100.outlook.office365.com (2603:10b6:208:51::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.28 via Frontend Transport; Mon, 16 Nov 2020 08:33:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by BL2NAM02FT020.mail.protection.outlook.com (10.152.77.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3564.22 via Frontend Transport; Mon, 16 Nov 2020 08:33:27 +0000 Received: from xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Mon, 16 Nov 2020 00:33:02 -0800 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server id 15.1.1913.5 via Frontend Transport; Mon, 16 Nov 2020 00:33:02 -0800 Received: from [172.23.64.106] (port=51138 helo=xhdvnc125.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1keZwb-0002UY-CR; Mon, 16 Nov 2020 00:33:01 -0800 Received: by xhdvnc125.xilinx.com (Postfix, from userid 16987) id 6B86A121067; Mon, 16 Nov 2020 14:02:47 +0530 (IST) From: Manish Narani To: , , Subject: [PATCH v2 1/3] mmc: sdhci-of-arasan: Allow configuring zero tap values Date: Mon, 16 Nov 2020 14:02:43 +0530 Message-ID: <1605515565-117562-2-git-send-email-manish.narani@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1605515565-117562-1-git-send-email-manish.narani@xilinx.com> References: <1605515565-117562-1-git-send-email-manish.narani@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 34249311-1c19-4c5d-b19a-08d88a0a4a33 X-MS-TrafficTypeDiagnostic: DM5PR02MB3324: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2p4H1H/XMNt0FH8bLgaASDGyGzkavBUB2CHcLUAvzz+rUbR/JDonMboFjwyNEcbmn5y1VYy9qmQFh9Uy4c7bX4tUK/aV6GQCOC+HMw6j8GD24fxnlrhr3zsE/ptdpLwbvDraiXUPH36/QXXt+JUNQc3t9KmvRefe2IYokoWbXsSvxv3Qv6FLq2Fqf9dPxm15eqmVdEZrveTABN0Bg54APcVUoaFdlqGl9+niEUnXZ1nrx4C7C0idSyBhxE6wicO/H9dspOJXwbJYRW1EF/8MZKivf+gImoTjw4GVzUcYn/CJCAUBIitp4QWLEGRi/YafSDSyVchczCO3lf7Ge9ZiNDrbBFidkAtARjtgXL8wv7kNex7oz5O7owArowQ9U6khvouFBy1ZiOZ6jnBFRp4dgpa7CfFvF9eSHy1vqKXDecU= X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch02.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(396003)(39850400004)(346002)(376002)(136003)(46966005)(2616005)(82740400003)(4326008)(6266002)(70586007)(107886003)(426003)(44832011)(47076004)(7636003)(478600001)(83380400001)(82310400003)(356005)(2906002)(5660300002)(36906005)(8936002)(70206006)(186003)(26005)(54906003)(8676002)(110136005)(42186006)(316002)(336012)(6666004)(36756003)(102446001); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2020 08:33:27.0673 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 34249311-1c19-4c5d-b19a-08d88a0a4a33 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BL2NAM02FT020.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR02MB3324 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201116_033335_346874_32DB3E5C X-CRM114-Status: GOOD ( 12.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sai Krishna Potthuri , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Manish Narani , git@xilinx.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Allow configuring the Output and Input tap values with zero to avoid failures in some cases (one of them is SD boot mode) where the output and input tap values may be already set to non-zero. Fixes: a5c8b2ae2e51 ("mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup") Signed-off-by: Sai Krishna Potthuri Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 40 ++++++------------------------ 1 file changed, 8 insertions(+), 32 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index 829ccef87426..100621e55427 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -600,14 +600,8 @@ static int sdhci_zynqmp_sdcardclk_set_phase(struct clk_hw *hw, int degrees) u8 tap_delay, tap_max = 0; int ret; - /* - * This is applicable for SDHCI_SPEC_300 and above - * ZynqMP does not set phase for <=25MHz clock. - * If degrees is zero, no need to do anything. - */ - if (host->version < SDHCI_SPEC_300 || - host->timing == MMC_TIMING_LEGACY || - host->timing == MMC_TIMING_UHS_SDR12 || !degrees) + /* This is applicable for SDHCI_SPEC_300 and above */ + if (host->version < SDHCI_SPEC_300) return 0; switch (host->timing) { @@ -668,14 +662,8 @@ static int sdhci_zynqmp_sampleclk_set_phase(struct clk_hw *hw, int degrees) u8 tap_delay, tap_max = 0; int ret; - /* - * This is applicable for SDHCI_SPEC_300 and above - * ZynqMP does not set phase for <=25MHz clock. - * If degrees is zero, no need to do anything. - */ - if (host->version < SDHCI_SPEC_300 || - host->timing == MMC_TIMING_LEGACY || - host->timing == MMC_TIMING_UHS_SDR12 || !degrees) + /* This is applicable for SDHCI_SPEC_300 and above */ + if (host->version < SDHCI_SPEC_300) return 0; switch (host->timing) { @@ -733,14 +721,8 @@ static int sdhci_versal_sdcardclk_set_phase(struct clk_hw *hw, int degrees) struct sdhci_host *host = sdhci_arasan->host; u8 tap_delay, tap_max = 0; - /* - * This is applicable for SDHCI_SPEC_300 and above - * Versal does not set phase for <=25MHz clock. - * If degrees is zero, no need to do anything. - */ - if (host->version < SDHCI_SPEC_300 || - host->timing == MMC_TIMING_LEGACY || - host->timing == MMC_TIMING_UHS_SDR12 || !degrees) + /* This is applicable for SDHCI_SPEC_300 and above */ + if (host->version < SDHCI_SPEC_300) return 0; switch (host->timing) { @@ -804,14 +786,8 @@ static int sdhci_versal_sampleclk_set_phase(struct clk_hw *hw, int degrees) struct sdhci_host *host = sdhci_arasan->host; u8 tap_delay, tap_max = 0; - /* - * This is applicable for SDHCI_SPEC_300 and above - * Versal does not set phase for <=25MHz clock. - * If degrees is zero, no need to do anything. - */ - if (host->version < SDHCI_SPEC_300 || - host->timing == MMC_TIMING_LEGACY || - host->timing == MMC_TIMING_UHS_SDR12 || !degrees) + /* This is applicable for SDHCI_SPEC_300 and above */ + if (host->version < SDHCI_SPEC_300) return 0; switch (host->timing) { From patchwork Mon Nov 16 08:32:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Narani X-Patchwork-Id: 11907729 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2C20C55ABD for ; Mon, 16 Nov 2020 08:34:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A2C621D93 for ; Mon, 16 Nov 2020 08:34:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="v1XrpgZd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="AMjTGiqc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A2C621D93 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=s9GKeziH4mohbFwE6/QVoIhgk21QDZxG4KV10MKEmQM=; b=v1XrpgZdHeJiUEknQ55bPGBNB c8MCAvWYBg8EMD8PR4bcJvfrW0R6uPtzIjtV+FQw00tYeFIKuF/sOKbJo0AwMyJqNZmuIMDkDtqbm BXAp1/lIECVJ2N22tTRs/jLHZ1mSljneTRI7xCkP0L+XMJehRBk6/85GrgmZxtky/aA4eSKf21+pj RokGxSCLGbozCgjHiBQi5+zp7/MRFNt1g3kXZ1gPECZe17d6yRK9HLW7Dy2HvxCiNCgdYWn58rx09 IFww3UN+b9nNKqqIpa6oirbImm+OEa4mhvue4XNj42930Mm78BxujWszXkZmiIbIgsT+T+p3zugB2 lwk9JqnDg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1keZxJ-0000K9-Uw; Mon, 16 Nov 2020 08:33:45 +0000 Received: from mail-eopbgr680051.outbound.protection.outlook.com ([40.107.68.51] helo=NAM04-BN3-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1keZx9-0000Fv-IN for linux-arm-kernel@lists.infradead.org; Mon, 16 Nov 2020 08:33:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Iid6mOdYG1Cs4dkJHupFLy1LWrpI1hozhx+/LK0XQzBoXxls2BkNkheZYGCrWtC7FBQKMcBgzgdVBC/giyBFvGD0/fwtX7NSMgboaNQNkhM2qQgFgRuX7obiYn0P9GmE/ltiutRVnrBT9H2f33qrv1+Z8r2fJqt6tNXHvtRZyN3Oz6dwWOyA0lu+4oRhi0HisGbGPQn7imbqRbs2HWyO6Td+Ht6UqsEQovSgeGN+LBiParGNYK9iXpaa8FDA97Bnynud4xF0KW/gXBYEdYHIK/XUg3lTEa9U3KYMnXvNUWOmyg+yGnR1BGKM1hqilP+XB+m8HsVT83yHuUs9oVPx1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dSTrBvusM1nmYanNfV/4Dk4JcEKizyWgTXqNQpmk0wo=; b=PcPz89sRVnyylJqhmunze/NoCzSvVNrA8m90KFGnhd5wCEpLq/vSddtZfMMU+59AXJgNIzZ+wb/YF1KgH9qzWCXvLRnD2E/ngD0u2i6WNe9lkjzVyGoiauPY9EzV+lC7hOELPTF0jPY7ZVj/922kweVRZyBeKns40hinwsZaWO68k3660OTqxwpUW5WIc3g08gNJbd9LlAbDdV6Ii24aWx3Fz+ruAifYfot1QeIERS7e7+1d6d+MLSGEGtqjiSN0USoKw6FlgQUxudVJ0IpFmYMNBG7XYW0/1nI7Zt/NqLUgka3yyAO/6FVL50/q2iNZH3oPjeKiUAcFBVfpWvlVkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=intel.com smtp.mailfrom=xilinx.com; dmarc=bestguesspass action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dSTrBvusM1nmYanNfV/4Dk4JcEKizyWgTXqNQpmk0wo=; b=AMjTGiqcQptCGGhmNMjOwrz+h2kY6Hp2uzDq1Z4h4toLXhEJleWd0C7/wb6lTZsJDN10EiXkjMhnz1pGqlU7zBqpVw+GDozHFWGKRhevV1aZEIp2iPW7JZWgGX4y2hQfe3l1Oittp+dLDc+HyqUt+z1EqiSDuvVDDV+NlDeGMnI= Received: from SN4PR0601CA0003.namprd06.prod.outlook.com (2603:10b6:803:2f::13) by DM5PR02MB3750.namprd02.prod.outlook.com (2603:10b6:4:af::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25; Mon, 16 Nov 2020 08:33:29 +0000 Received: from SN1NAM02FT026.eop-nam02.prod.protection.outlook.com (2603:10b6:803:2f:cafe::f) by SN4PR0601CA0003.outlook.office365.com (2603:10b6:803:2f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25 via Frontend Transport; Mon, 16 Nov 2020 08:33:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT026.mail.protection.outlook.com (10.152.72.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3564.22 via Frontend Transport; Mon, 16 Nov 2020 08:33:29 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Mon, 16 Nov 2020 00:33:15 -0800 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.1913.5 via Frontend Transport; Mon, 16 Nov 2020 00:33:15 -0800 Received: from [172.23.64.106] (port=51158 helo=xhdvnc125.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1keZwo-0002Vl-HV; Mon, 16 Nov 2020 00:33:14 -0800 Received: by xhdvnc125.xilinx.com (Postfix, from userid 16987) id 717751211D2; Mon, 16 Nov 2020 14:02:47 +0530 (IST) From: Manish Narani To: , , Subject: [PATCH v2 2/3] mmc: sdhci-of-arasan: Use Mask writes for Tap delays Date: Mon, 16 Nov 2020 14:02:44 +0530 Message-ID: <1605515565-117562-3-git-send-email-manish.narani@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1605515565-117562-1-git-send-email-manish.narani@xilinx.com> References: <1605515565-117562-1-git-send-email-manish.narani@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0ab22d09-7adf-469a-db9c-08d88a0a4ba0 X-MS-TrafficTypeDiagnostic: DM5PR02MB3750: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CptzD8NM62/G1NrV6wRshggV8b7e8Ozo4E2GElk4pmxldDfyU3AV6vWdAVWiLaeq4BI2ND6Dza23XvZmwHPkDEs19+05mXKyUE0OtEgswlhwVF0i51Tag46PWuzu4LJElT+UCQ7NyM5VWHvbqE4k3KTQA5ruIhMHUgCkY9+vnMCHyhHwdsCBMnYDxT2PAFAx/5QTF1eXqEn1MtyMeFhDd1e9n9CnKvaBA49DM+s9uGcss8l1aYvKF0sltrvnOA9LbGYi0i/1csBM6mUcrRsnp7enbBmsPBe7M0sFgNDxvQ35GLYtteQYHUSV1gArJhMtm5Qq2LCwzRcbx7Sw6CSx6LMyJE+YNgdpNHzJoZZSCX6ncg8upBTQA/QYbvxudzQqT5lxhnyqxz5Gp+We7iqk2WbZ6wKd1SOMUVb2Imz1YkM= X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch01.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(376002)(346002)(396003)(136003)(39850400004)(46966005)(2906002)(8676002)(6666004)(26005)(186003)(70206006)(110136005)(316002)(42186006)(70586007)(36906005)(54906003)(8936002)(36756003)(7636003)(82310400003)(5660300002)(44832011)(4326008)(478600001)(6266002)(107886003)(2616005)(336012)(47076004)(82740400003)(426003)(356005)(102446001); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2020 08:33:29.5214 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0ab22d09-7adf-469a-db9c-08d88a0a4ba0 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT026.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR02MB3750 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201116_033335_628311_E17A4F95 X-CRM114-Status: GOOD ( 10.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sai Krishna Potthuri , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Manish Narani , git@xilinx.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Mask the ITAP and OTAP delay bits before updating with the new tap value for Versal platform. Fixes: 1a470721c8f5 ("sdhci: arasan: Add support for Versal Tap Delays") Signed-off-by: Sai Krishna Potthuri Signed-off-by: Manish Narani Acked-by: Michal Simek --- drivers/mmc/host/sdhci-of-arasan.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index 100621e55427..3ec5ecad637c 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -30,7 +30,10 @@ #define SDHCI_ARASAN_VENDOR_REGISTER 0x78 #define SDHCI_ARASAN_ITAPDLY_REGISTER 0xF0F8 +#define SDHCI_ARASAN_ITAPDLY_SEL_MASK 0xFF + #define SDHCI_ARASAN_OTAPDLY_REGISTER 0xF0FC +#define SDHCI_ARASAN_OTAPDLY_SEL_MASK 0x3F #define SDHCI_ARASAN_CQE_BASE_ADDR 0x200 #define VENDOR_ENHANCED_STROBE BIT(0) @@ -755,6 +758,7 @@ static int sdhci_versal_sdcardclk_set_phase(struct clk_hw *hw, int degrees) regval = sdhci_readl(host, SDHCI_ARASAN_OTAPDLY_REGISTER); regval |= SDHCI_OTAPDLY_ENABLE; sdhci_writel(host, regval, SDHCI_ARASAN_OTAPDLY_REGISTER); + regval &= ~SDHCI_ARASAN_OTAPDLY_SEL_MASK; regval |= tap_delay; sdhci_writel(host, regval, SDHCI_ARASAN_OTAPDLY_REGISTER); } @@ -822,6 +826,7 @@ static int sdhci_versal_sampleclk_set_phase(struct clk_hw *hw, int degrees) sdhci_writel(host, regval, SDHCI_ARASAN_ITAPDLY_REGISTER); regval |= SDHCI_ITAPDLY_ENABLE; sdhci_writel(host, regval, SDHCI_ARASAN_ITAPDLY_REGISTER); + regval &= ~SDHCI_ARASAN_ITAPDLY_SEL_MASK; regval |= tap_delay; sdhci_writel(host, regval, SDHCI_ARASAN_ITAPDLY_REGISTER); regval &= ~SDHCI_ITAPDLY_CHGWIN; From patchwork Mon Nov 16 08:32:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Narani X-Patchwork-Id: 11907725 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D9D2C55ABD for ; Mon, 16 Nov 2020 08:34:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 127C0207BC for ; Mon, 16 Nov 2020 08:34:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="taa2zJwv"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="abUK6fmb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 127C0207BC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=48CHGmyMLenQlNu2zC95azTV8dHfVqPGuZCjV9QwKfg=; b=taa2zJwv7Zhk5hc5KET2H9l5Q VUXIRK+hfXCbnWTq6p6ZyCAaFJ4sb6ep8Vvom0JCh6VkDi53uFcum+qJYfUI7jP9zXTISq8iMd9nB 6HRiAkhhBZeF3n5unUIo1K68Kuc0zpKzmlrRvwtdxCNSfZO3CAEIymgvLA9saqlEGlBDj/bZK5+6w xFp1BIAwNiy5JAN4mIi+4u3gge+ZmwOTRXOcALnOXhVfVRz5pxrMZ4qOBNhYT08uaHKD9FwBEw5Kf i3ODamJPDNyYvPYvtUy3R+77AaOK1bAgAslS3MNYdiOnpa1BD4oQ4iQJis/Sfm4cQOUNIY53cKE1y HsTNbrgBw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1keZxY-0000PU-L7; Mon, 16 Nov 2020 08:34:00 +0000 Received: from mail-bn7nam10on2054.outbound.protection.outlook.com ([40.107.92.54] helo=NAM10-BN7-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1keZxU-0000NM-IX for linux-arm-kernel@lists.infradead.org; Mon, 16 Nov 2020 08:33:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X8pCrG0cCvlIfnqCCKh54KDxZ1g3D6q3vQJLWqFrhM/0A7InssSuoH5EJegg/a41WuljpmWuh93CvqaderQGMG3MS8vGdjg8hyKxmdmrRp+AVzqh281wOc7Mya//AJr48MOjK/OTDBsl+1CSlj7Q3cg+S7VUmeXNkU+UX5oHn02e6Y33SOAnzxJ/VN7igrdDzr70YAOqsjyvSfVUtuRFgwGoabxDxFI29ym+7yxNWtDTlgWU/IJWbnABccGAYywKbdRI2VNakKDMZUa+hD5CuEfQKkWx706noBJ3bsVqvhWTUNWONsjxI6mRXRSqDertJixYYDzbr+bQdGo1agbedA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F3PC6HKJlnagsA+B4h6NfIPrw/IhvEB6/AcFQIbXXtQ=; b=f5qvUQ3Nq+LzhpKDi2Z9/9Rm4aLy4IwPggLmi+vrlok5S/1PkIcaMfGeMlfxMo4zBKu3zLHm//hUpc6XjmEwsQ19skxLCT6sqbKbckNc7vgn61TrVGKkluCMK2J2Wvc1U6d0EyZdWJd2MiZm0AcZtdg4xB9DpMYkYbAtUKPfcb4PpWD3qfqvF52zsUXk3N8lDUpduyO83pSVlWTIiB4rta78JOGOAZTfpR/t3tbfgSCYK9UCaJdAdsLDoYIQ/9VrtXDGlF/friIeQ5yRjbNKOadgHf5QqLrWnwwqpot+qbRaqMt/+ISX+XPba1Rp0Vj5QDnGiCxOFN+ctkgamZLJpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=intel.com smtp.mailfrom=xilinx.com; dmarc=bestguesspass action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F3PC6HKJlnagsA+B4h6NfIPrw/IhvEB6/AcFQIbXXtQ=; b=abUK6fmbxeMhCITknvB2Fm3jYoxlATM0hXNHnPognMCGk3g6oWIfOGtvPR5ZXcunL7Sv6FFV6iJLokp1OEEvywuWHm3qA7EgvdruPz5BRz3pOtiijEL1xJOpXrYKYsuNogcOdAeH2U6xuuLyef4cP35XY6pGaPuOZNEx5HDIyGc= Received: from BL1PR13CA0106.namprd13.prod.outlook.com (2603:10b6:208:2b9::21) by MW2PR02MB3833.namprd02.prod.outlook.com (2603:10b6:907:4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.24; Mon, 16 Nov 2020 08:33:52 +0000 Received: from BL2NAM02FT038.eop-nam02.prod.protection.outlook.com (2603:10b6:208:2b9:cafe::67) by BL1PR13CA0106.outlook.office365.com (2603:10b6:208:2b9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.21 via Frontend Transport; Mon, 16 Nov 2020 08:33:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by BL2NAM02FT038.mail.protection.outlook.com (10.152.77.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3564.22 via Frontend Transport; Mon, 16 Nov 2020 08:33:52 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Mon, 16 Nov 2020 00:33:28 -0800 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.1913.5 via Frontend Transport; Mon, 16 Nov 2020 00:33:28 -0800 Received: from [172.23.64.106] (port=51164 helo=xhdvnc125.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1keZx1-0002WJ-Ma; Mon, 16 Nov 2020 00:33:27 -0800 Received: by xhdvnc125.xilinx.com (Postfix, from userid 16987) id 773CB1211EF; Mon, 16 Nov 2020 14:02:47 +0530 (IST) From: Manish Narani To: , , Subject: [PATCH v2 3/3] mmc: sdhci-of-arasan: Issue DLL reset explicitly Date: Mon, 16 Nov 2020 14:02:45 +0530 Message-ID: <1605515565-117562-4-git-send-email-manish.narani@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1605515565-117562-1-git-send-email-manish.narani@xilinx.com> References: <1605515565-117562-1-git-send-email-manish.narani@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cbd1a5bc-8152-4575-8a36-08d88a0a5931 X-MS-TrafficTypeDiagnostic: MW2PR02MB3833: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0HWSx/HTmocBoXhbam/OzeRQBXETrEMZ7Jv9B4KCuCwKqABpIo/9pd4j3u93l4SBlC1XU9aAjY0ecAPV4+Gax+NuXxxGmc1AMS3ahTAuFegg9H2PpmD3jTLxRBzaNrNaG5Uk9L7pjyW2BhCLy/YW7I78Xg9d6rAIQ5LMZtgz1lAfgNW0CbaGFx7ysshvVl8QrHhSvJ35ETqpjldjzo7PPe+G36LHUztBCTsUPy17jmG5NBnxqkw/qCSpmC8CiUT647p6m5Mx3qLQYfAoKcAIoHv4WEsTqxdOkGh9xuIX/PJo/C4C232iOkrZ/+kkpWwaszuhfhsgYMHCP581kcL8edRdFnzgvvAO3FMB4qqbKi5tWnhK181c+Wlos9G+uXkP4u5+q4WvoOmTtEN7z9mX9WjPJSJT7I29ELGx5Eaxjrs= X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch02.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(39850400004)(396003)(376002)(346002)(136003)(46966005)(8676002)(110136005)(7636003)(8936002)(36756003)(83380400001)(316002)(26005)(4326008)(70586007)(82310400003)(82740400003)(54906003)(2906002)(47076004)(2616005)(44832011)(6266002)(107886003)(42186006)(186003)(336012)(356005)(478600001)(5660300002)(426003)(70206006)(36906005)(102446001); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2020 08:33:52.2180 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cbd1a5bc-8152-4575-8a36-08d88a0a5931 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BL2NAM02FT038.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR02MB3833 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201116_033356_662059_D38405DB X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sai Krishna Potthuri , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Manish Narani , git@xilinx.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In the current implementation DLL reset will be issued for each ITAP and OTAP setting inside ATF, this is creating issues in some scenarios and this sequence is not inline with the TRM. To fix the issue, DLL reset should be removed from the ATF and host driver will request it explicitly. This patch update host driver to explicitly request for DLL reset before ITAP (assert DLL) and after OTAP (release DLL) settings. Fixes: a5c8b2ae2e51 ("mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup") Signed-off-by: Sai Krishna Potthuri Signed-off-by: Manish Narani --- drivers/mmc/host/sdhci-of-arasan.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index 3ec5ecad637c..d25a4b50c2f3 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -635,6 +635,9 @@ static int sdhci_zynqmp_sdcardclk_set_phase(struct clk_hw *hw, int degrees) if (ret) pr_err("Error setting Output Tap Delay\n"); + /* Release DLL Reset */ + zynqmp_pm_sd_dll_reset(node_id, PM_DLL_RESET_RELEASE); + return ret; } @@ -669,6 +672,9 @@ static int sdhci_zynqmp_sampleclk_set_phase(struct clk_hw *hw, int degrees) if (host->version < SDHCI_SPEC_300) return 0; + /* Assert DLL Reset */ + zynqmp_pm_sd_dll_reset(node_id, PM_DLL_RESET_ASSERT); + switch (host->timing) { case MMC_TIMING_MMC_HS: case MMC_TIMING_SD_HS: