From patchwork Mon Nov 5 14:15:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?Q2zDqW1lbnQgUMOpcm9u?= X-Patchwork-Id: 10668335 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 73A131709 for ; Mon, 5 Nov 2018 14:15:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6344E28FD0 for ; Mon, 5 Nov 2018 14:15:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5701128FEA; Mon, 5 Nov 2018 14:15:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 08A3828FD0 for ; Mon, 5 Nov 2018 14:15:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=6MUtoJfAaCEzrlcCwupsqPtwEZ1QMwAq27EOKYj6eJI=; b=Eb+nXkhF1zSrXS 5IdEPm0nox3aS2/rJu9G/EUkJPWxwGLE+R13UPlyWaTPdbWStjcyF9SCXMLP+c4KiC4TwbbDVhJHC /+c4YCTLGI8pf3P/NEpYo/8gKM1ivAkXo/gCLaT33TF1Et/NWrNd3zLulgWuHArkVkkFhTkZJhUL1 saqwgXfJpF3oVFOXeIKGqbjAqanR4KWFLdn9tBnAtbY0WFTKsnhesNGG4bESpoczS8gYgsZlSYDtq q/whxzHq3BWGPuE9CrkXI8uiF4dnJ6dHX5A/q+PJHy+ly+rjwtJjkxUrUSbRi6TovmhQPs7xP3jVE n9RfGN+BsjJdozpoPLfQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gJffS-0000Ll-Jo; Mon, 05 Nov 2018 14:15:50 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gJffI-0000Kb-By for linux-arm-kernel@lists.infradead.org; Mon, 05 Nov 2018 14:15:48 +0000 Received: by mail-wr1-x441.google.com with SMTP id k15-v6so6728119wre.12 for ; Mon, 05 Nov 2018 06:15:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pKoF4gPx9B0hHhbAB2Ch8ktDsv0ythRuT+2AvvIEQMI=; b=Wk/9rq74GD3KQbHd6whopkrWhMnzN0W2Bmr5tOsey/ZtmG9ID2KL79rTrXAWtrJvEz dAhl10zay2Rc3Bj1XRKPns0o5rNMAxwGD/B36VED/QJt5zSQGMcyAWcewIaLPg5UTGJY TCHi/dKYNpLyOe4a0S5V35KZQdnMoxaSCJU90E5znY7cYxPQbxCHcdU5xPIi6MrlBzPf uYrI7J7zlH89MBWrEkz6vVqO3ri3S/EJ8w46XmpBThirQLbwM/krisyOtmB4w6p0e1js VR29nq5/G8b6fFZ6USJjMfLgEnAtcBga7LAM3yXmkGX79heqS3/QDuF3FhxgQpuwvOFw EqPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pKoF4gPx9B0hHhbAB2Ch8ktDsv0ythRuT+2AvvIEQMI=; b=hT9pzit7Me7RnlsvZax5YH+wBgqw2fqbYhRvRZXku+cQqIvFaVNMkGGGA36qC4N20W ef2QUWcCgPjqwNt9zv+YJgi4utwWRhDgtpVUhnOj0JyKTMiF89UfbFLNjFY2m7KaKHP7 6t0asjrZhlE11CELLSUIGdHFJOEqK1Z2hrHDHvC4Z4iG13IVttkRCUG1kwyIlS4Epivg AVyEN+0y5Q/4nzGxna7deP3OV/rY2sg8zqhgzsY+l8NrGK6YiqgIhWy3yuclq1Rw/ir6 trL7SYqVUlNNmqHPftV5KNC6+9xBaVePIVJu0P5hGPgGn9/tnBAN6niwClcZNgPneFi1 Di6g== X-Gm-Message-State: AGRZ1gI7xvLqkkHvhb/CKk+2HfqS1ckVq51ifgKXIZm1jKBPMK52+m5B J8jK8D6U5J4I3nvOmYXmVqg= X-Google-Smtp-Source: AJdET5dnKpMYvinEdgPnYEhcava063LWXTrt7G7cc/M4x7b/biyLdKl7VZrT4Y5I6J9W9RypAU05xQ== X-Received: by 2002:adf:ca03:: with SMTP id o3-v6mr19257898wrh.148.1541427328197; Mon, 05 Nov 2018 06:15:28 -0800 (PST) Received: from localhost.localdomain (static-css-cqn-141161.business.bouyguestelecom.com. [176.149.141.161]) by smtp.gmail.com with ESMTPSA id v2-v6sm13585081wru.20.2018.11.05.06.15.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Nov 2018 06:15:27 -0800 (PST) From: =?utf-8?b?Q2zDqW1lbnQgUMOpcm9u?= To: NXP Linux Team , Daniel Lezcano Subject: [PATCH] clocksource: imx-gpt: remove unnecessary irq protection Date: Mon, 5 Nov 2018 15:15:11 +0100 Message-Id: <20181105141511.30657-1-peron.clem@gmail.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181105_061540_407266_0355225C X-CRM114-Status: GOOD ( 11.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, =?utf-8?b?Q2zDqW1lbnQgUMOpcm9u?= , linux-arm-kernel@lists.infradead.org, Fabio Estevam , Thomas Gleixner , Vladimir Zapolskiy Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP shutdown and oneshot are already protected against irq interruptions Signed-off-by: Clément Péron --- drivers/clocksource/timer-imx-gpt.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/drivers/clocksource/timer-imx-gpt.c b/drivers/clocksource/timer-imx-gpt.c index 165fbbb1c9a0..48e025e8dc82 100644 --- a/drivers/clocksource/timer-imx-gpt.c +++ b/drivers/clocksource/timer-imx-gpt.c @@ -198,15 +198,8 @@ static int v2_set_next_event(unsigned long evt, static int mxc_shutdown(struct clock_event_device *ced) { struct imx_timer *imxtm = to_imx_timer(ced); - unsigned long flags; u32 tcn; - /* - * The timer interrupt generation is disabled at least - * for enough time to call mxc_set_next_event() - */ - local_irq_save(flags); - /* Disable interrupt in GPT module */ imxtm->gpt->gpt_irq_disable(imxtm); @@ -221,21 +214,12 @@ static int mxc_shutdown(struct clock_event_device *ced) printk(KERN_INFO "%s: changing mode\n", __func__); #endif /* DEBUG */ - local_irq_restore(flags); - return 0; } static int mxc_set_oneshot(struct clock_event_device *ced) { struct imx_timer *imxtm = to_imx_timer(ced); - unsigned long flags; - - /* - * The timer interrupt generation is disabled at least - * for enough time to call mxc_set_next_event() - */ - local_irq_save(flags); /* Disable interrupt in GPT module */ imxtm->gpt->gpt_irq_disable(imxtm); @@ -260,7 +244,6 @@ static int mxc_set_oneshot(struct clock_event_device *ced) * mode switching */ imxtm->gpt->gpt_irq_enable(imxtm); - local_irq_restore(flags); return 0; }