From patchwork Tue Nov 24 07:36:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kai-Heng Feng X-Patchwork-Id: 11927331 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CF3FC2D0E4 for ; Tue, 24 Nov 2020 07:36:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DE7120872 for ; Tue, 24 Nov 2020 07:36:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726363AbgKXHgc (ORCPT ); Tue, 24 Nov 2020 02:36:32 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:44117 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726359AbgKXHgb (ORCPT ); Tue, 24 Nov 2020 02:36:31 -0500 Received: from 1.general.khfeng.uk.vpn ([10.172.196.174] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1khSsC-0005hv-8e; Tue, 24 Nov 2020 07:36:25 +0000 From: Kai-Heng Feng To: rafael.j.wysocki@intel.com Cc: andy.shevchenko@gmail.com, mika.westerberg@linux.intel.com, hdegoede@redhat.com, bhelgaas@google.com, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, Kai-Heng Feng , "Rafael J. Wysocki" , Len Brown , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] ACPI: PM: Re-enable ACPI GPE if it's already enabled Date: Tue, 24 Nov 2020 15:36:19 +0800 Message-Id: <20201124073619.771940-1-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Dell Precision 5550 fails to detect Thunderbolt device hotplug events, once the Thunderbolt device and its root port are runtime-suspended to D3cold. While putting the entire hierarchy to D3cold, the root port ACPI GPE is enabled via acpi_pci_propagate_wakeup() when suspending Thunderbolt bridges/switches. So when putting the root port to D3cold as last step, ACPI GPE is untouched as it's already enabled. However, platform may need PCI devices to be in D3hot or PME enabled prior enabling GPE to make it work. So re-enable ACPI GPE to address this. Signed-off-by: Kai-Heng Feng Tested-by: Kai-Heng Feng --- drivers/acpi/device_pm.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c index 94d91c67aeae..dc25d9d204ae 100644 --- a/drivers/acpi/device_pm.c +++ b/drivers/acpi/device_pm.c @@ -757,11 +757,10 @@ static int __acpi_device_wakeup_enable(struct acpi_device *adev, mutex_lock(&acpi_wakeup_lock); - if (wakeup->enable_count >= max_count) - goto out; - - if (wakeup->enable_count > 0) - goto inc; + if (wakeup->enable_count > 0) { + acpi_disable_gpe(wakeup->gpe_device, wakeup->gpe_number); + acpi_disable_wakeup_device_power(adev); + } error = acpi_enable_wakeup_device_power(adev, target_state); if (error) @@ -777,8 +776,8 @@ static int __acpi_device_wakeup_enable(struct acpi_device *adev, acpi_handle_debug(adev->handle, "GPE%2X enabled for wakeup\n", (unsigned int)wakeup->gpe_number); -inc: - wakeup->enable_count++; + if (wakeup->enable_count < max_count) + wakeup->enable_count++; out: mutex_unlock(&acpi_wakeup_lock);