From patchwork Thu Nov 26 13:36:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11933997 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6E22C63697 for ; Thu, 26 Nov 2020 13:36:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72C0321D46 for ; Thu, 26 Nov 2020 13:36:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="g6zRzVGz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390337AbgKZNgQ (ORCPT ); Thu, 26 Nov 2020 08:36:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390128AbgKZNgQ (ORCPT ); Thu, 26 Nov 2020 08:36:16 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89FB4C0613D4 for ; Thu, 26 Nov 2020 05:36:14 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id 23so2166696wrc.8 for ; Thu, 26 Nov 2020 05:36:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cUSIVImOhh6mnD33JdJKn9l+xD1dBbES1ADQWyw/cSQ=; b=g6zRzVGz9G1rkRBJxu5GSPNOBBUME2NZh6JpVJ0XbDF3pkN9YxfMue8xN524DY45wu Sp8DJn8yglGxMUVUM5GPZG5fg0igrw2+z38ejyPzdWeA6TxVMyH1JIGNbMgnw2MGMadV mepdLcyL/Cl1BRZNhQ8AhJAj88El5PDv3BRgRpdh4Pvrz3vVqJmiycHkmr61VYJGs8M1 3ySiuhIsQY8pQtlu3LQCrXxbvmjdS86FMsGMUahPRdEk2egdpZC1087da1lo459fWCoX qwwUH7ysRR4lYdn2qE7iY9fwvdhf3d0MC0BJ7vHqLvMXTlHcqbl+iltinxppF5bya/78 rVNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cUSIVImOhh6mnD33JdJKn9l+xD1dBbES1ADQWyw/cSQ=; b=uKX/qzso54tgvSmG8Nol0h4YyzWnddaIzg+80NILqFGRHeMQ+00l5ehCP+nePlq+uC 8u/EnsE+JMtwbOQOTMUmMJjU7DOlrWzv351p9N1euLmqaFAckta3fSeG4yOEewMPMDNV UPy+VhmKFw9Oh3c4iGDMv05iwrPn4uLlxD8avG7sfCVlVNpllgDZrENDjZIfNcgyqvZq c+y15nXzcGhF46miPqxXFc7BhveY6Uskb9/g8lEeUGasm7t1nhqLHbc9XUgvqmJ6z/Bi 8NRcHXDM649qImrLK82+wOoEN9ChtQw5LEuy7YVNwHfQbQTk4VrALPp1Kl2xtEBZtEsJ uL1A== X-Gm-Message-State: AOAM531C7OfafoPIquUDKsF7oYNWsdFlwJnr3/zMJWuWheEaVoYp0Wd8 osDvvhMjylvmm+8ulEE72y/JUg== X-Google-Smtp-Source: ABdhPJyM38k3nbNTIdMzbfDCjcuDIn2fZ5gNnfZoSC241xKOUSNHw7HTf/ihb3IWGPrAVzYSSQ9IGg== X-Received: by 2002:adf:dd09:: with SMTP id a9mr3919342wrm.128.1606397773337; Thu, 26 Nov 2020 05:36:13 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id l3sm9056280wrr.89.2020.11.26.05.36.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:36:12 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Henrik Rydberg , Peter Osterlund , Stefan Gmeiner , "C. Scott Ananian" , Bruce Kalk , this to Subject: [PATCH v2 1/4] input: mouse: synaptics: Replace NOOP with suitable commentary Date: Thu, 26 Nov 2020 13:36:04 +0000 Message-Id: <20201126133607.3212484-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133607.3212484-1-lee.jones@linaro.org> References: <20201126133607.3212484-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’: drivers/input/mouse/synaptics.c:1110:6: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: Peter Osterlund Cc: Stefan Gmeiner Cc: "C. Scott Ananian" Cc: Bruce Kalk Cc: this to Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/mouse/synaptics.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 8fb7b4385ded9..3cc8b76629fa2 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -1106,8 +1106,11 @@ static void synaptics_process_packet(struct psmouse *psmouse) num_fingers = hw.w + 2; break; case 2: - if (SYN_MODEL_PEN(info->model_id)) - ; /* Nothing, treat a pen as a single finger */ + /* + * Keep defaults + * + * SYN_MODEL_PEN: Treat pens as a single finger + */ break; case 4 ... 15: if (SYN_CAP_PALMDETECT(info->capabilities)) From patchwork Thu Nov 26 13:36:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11934003 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0FAAC64E7C for ; Thu, 26 Nov 2020 13:36:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8314B2087C for ; Thu, 26 Nov 2020 13:36:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Qba3Y44U" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390033AbgKZNgY (ORCPT ); Thu, 26 Nov 2020 08:36:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390480AbgKZNgX (ORCPT ); Thu, 26 Nov 2020 08:36:23 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A12FAC0617A7 for ; Thu, 26 Nov 2020 05:36:21 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id 10so2176162wml.2 for ; Thu, 26 Nov 2020 05:36:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VOfJDj7y+29ZeViL6kV6ywYnxqJxhhS/scmeQ+AwyUU=; b=Qba3Y44UBdpC8FW+jUziVINWIgRedMTLk1YdievSzjOk4FV2QY6K+mZoOGTp3AalIO yZJs0ZcGqkoTIxL3v4lUDuxliEjAGgEr6PV3a59wCDc3NNhjiqR6aOgGMqEodtf6N/93 LNtSNs7fK87N5IfB5Oz9oy9mWnQw/TduJM95YPiSfb+/mXlDAxx5czfYL9rKr0UKZquE tYxIco6SbhOf5EpKT/emq0KuHOZBrb1R7P8tBSiJh7n09ykqUkbVq/rJDmFd/1Hv8FT3 X3D8MsISYr3hWyKYbEfXOI/yr9gIpX/xOh1LQqTZitONUdozBmTExTm8eZrcomVaFPlw adBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VOfJDj7y+29ZeViL6kV6ywYnxqJxhhS/scmeQ+AwyUU=; b=eNuwJbaZhGW928JoZ3rcgPHUVHQU7CMgiKzLZ7P3Ywjgc6QS28LfLiYyPgAfQ21H60 /0Xa3kPeoJN0Sjk3Hyn6OBO3AsP12Zk6JOREVsb7rQTyxGeIW0DLeenr0Fo+bB80AaoX 9jrYs2LTfwEivGIgYB+CQ3l4Thp53jRel3JH8WyJT6amV5OlakvFWK4ekLzQlHmEPB/M UZY2zwdKd7aprQCEHjEvErHfj+QnUXO8Oy8YW++LSyrgW8mi560X/NaSxel79QwUyQS0 i/YYfjLTzc8mmmb/4F+Dz1LFuMywWo4AtelXaEsqD/443BD7nzau8vjU+jcGUe9ZN1GW H60Q== X-Gm-Message-State: AOAM532ePe9PXEYS1iKrWVj64/WIR3jG4GsBJUQgK87yvNdvjtp8ge1J HZiX0s8GUl+fvn0ILQEGv2wsbQ== X-Google-Smtp-Source: ABdhPJxwE9siZ4vhGtQgx5DvuECLtki3M1efXqBKTmVa3SLokn14BDGvexxUi8KQBLfqf4CQsC5FUQ== X-Received: by 2002:a1c:e0d4:: with SMTP id x203mr3590217wmg.68.1606397774983; Thu, 26 Nov 2020 05:36:14 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id l3sm9056280wrr.89.2020.11.26.05.36.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:36:14 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Sangwon Jee , Dmitry Torokhov , Henrik Rydberg , linux-input@vger.kernel.org Subject: [PATCH v2 2/4] input: touchscreen: melfas_mip4: Remove a bunch of unused variables Date: Thu, 26 Nov 2020 13:36:05 +0000 Message-Id: <20201126133607.3212484-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133607.3212484-1-lee.jones@linaro.org> References: <20201126133607.3212484-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/melfas_mip4.c: In function ‘mip4_report_touch’: drivers/input/touchscreen/melfas_mip4.c:474:5: warning: variable ‘size’ set but not used [-Wunused-but-set-variable] drivers/input/touchscreen/melfas_mip4.c:472:5: warning: variable ‘pressure_stage’ set but not used [-Wunused-but-set-variable] drivers/input/touchscreen/melfas_mip4.c:469:7: warning: variable ‘palm’ set but not used [-Wunused-but-set-variable] drivers/input/touchscreen/melfas_mip4.c:468:7: warning: variable ‘hover’ set but not used [-Wunused-but-set-variable] Cc: Sangwon Jee Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/touchscreen/melfas_mip4.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c index f67efdd040b24..9c98759098c7a 100644 --- a/drivers/input/touchscreen/melfas_mip4.c +++ b/drivers/input/touchscreen/melfas_mip4.c @@ -465,13 +465,9 @@ static void mip4_report_keys(struct mip4_ts *ts, u8 *packet) static void mip4_report_touch(struct mip4_ts *ts, u8 *packet) { int id; - bool hover; - bool palm; bool state; u16 x, y; - u8 pressure_stage = 0; u8 pressure; - u8 size; u8 touch_major; u8 touch_minor; @@ -480,14 +476,11 @@ static void mip4_report_touch(struct mip4_ts *ts, u8 *packet) case 1: /* Touch only */ state = packet[0] & BIT(7); - hover = packet[0] & BIT(5); - palm = packet[0] & BIT(4); id = (packet[0] & 0x0F) - 1; x = ((packet[1] & 0x0F) << 8) | packet[2]; y = (((packet[1] >> 4) & 0x0F) << 8) | packet[3]; pressure = packet[4]; - size = packet[5]; if (ts->event_format == 0) { touch_major = packet[5]; touch_minor = packet[5]; @@ -501,14 +494,10 @@ static void mip4_report_touch(struct mip4_ts *ts, u8 *packet) default: /* Touch + Force(Pressure) */ id = (packet[0] & 0x0F) - 1; - hover = packet[1] & BIT(2); - palm = packet[1] & BIT(1); state = packet[1] & BIT(0); x = ((packet[2] & 0x0F) << 8) | packet[3]; y = (((packet[2] >> 4) & 0x0F) << 8) | packet[4]; - size = packet[6]; - pressure_stage = (packet[7] & 0xF0) >> 4; pressure = ((packet[7] & 0x0F) << 8) | packet[8]; touch_major = packet[9]; From patchwork Thu Nov 26 13:36:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11934001 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DAE6C64E7A for ; Thu, 26 Nov 2020 13:36:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7EAB21D46 for ; Thu, 26 Nov 2020 13:36:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fsUJkN4/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390354AbgKZNgT (ORCPT ); Thu, 26 Nov 2020 08:36:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390327AbgKZNgS (ORCPT ); Thu, 26 Nov 2020 08:36:18 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72253C0617A7 for ; Thu, 26 Nov 2020 05:36:18 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id k14so2191805wrn.1 for ; Thu, 26 Nov 2020 05:36:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ptuCzI/J/pK9IazFF47wcnYE5/wwDz9k/tG2ZC99w5I=; b=fsUJkN4/93Fz7NiE9jRzBq6Hfq0UT50vEbBIcuvpg45I4KmD6OMv4XyGsj5CG1LHWR fpgYzwiplcjwn/5uYkPtEUG+uwYsQnK79MkHbhgK3nJJZr+uN3nueq/yigjtR/QMJrv2 k/y+vsocVqpob2Ytont14F9aBquqt4fo1DOPq70hvnmTT89r6pKYIW2F0aRqktGI4ZxK FTQdnQcz+pxlA/9IWWCY5DE0/Ugqt6IIj/1MjPZ7Pm3sklxAV10hSdnlpIsWxGUOlVK+ a4u3z+me4ADzl7cZQ0mVvPf02q2rS/tYNdAgvf4hCOaiF4BvHo/+tCQlw2ynBkeqmE+M Cv4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ptuCzI/J/pK9IazFF47wcnYE5/wwDz9k/tG2ZC99w5I=; b=YQfU5YKVOKlCGwfK0juuzk/dGXgPvUHMhvIBPhR57mXpctuGOsUIYRP/G0JSdsHN88 BZeg+V+ST+u4MMowfcQWjNykg426Q1QQCOL1q5X26xxxqtKb4uVjqS90Rodgd5IdUvMd HHmmKMXQ/nojQqH1WS3Bd3/9Xjpw0N32lxyML9l2PmYG9uYVxM6W2eByCDTN62Ur4+uc oZNSkSCN9p9HmoajaQlVLXTOKqLACJcsy9coUp7ZkAMnVw0hHIHtI5gGeCUNzdwkZVbX wvGdP3K7+hXdhYq6Pm8svUQTPKRizrhpJ1vmCkklC4h2XK1rElLUyUb6sch9ujBvaGMS fKxA== X-Gm-Message-State: AOAM532IlzKtqna5bLSmvuZh1buqfPnzHvg6Egm1SC7QCxB5Ny+1yO34 z6h9QXKYTQRFlbjxm0LZ+XsPzA== X-Google-Smtp-Source: ABdhPJxwcnxrJ60FYcuBBWacWLhwXpwENFfsols49hd2U3IbbEunR/QQzoUJFwWbsF4dSCR5Ykp83w== X-Received: by 2002:a5d:544e:: with SMTP id w14mr3906110wrv.227.1606397777236; Thu, 26 Nov 2020 05:36:17 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id l3sm9056280wrr.89.2020.11.26.05.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:36:16 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Henrik Rydberg , James Hilliard , Daniel Ritz , linux-input@vger.kernel.org Subject: [PATCH v2 3/4] input: touchscreen: usbtouchscreen: Remove unused variable 'ret' Date: Thu, 26 Nov 2020 13:36:06 +0000 Message-Id: <20201126133607.3212484-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133607.3212484-1-lee.jones@linaro.org> References: <20201126133607.3212484-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/usbtouchscreen.c: In function ‘nexio_read_data’: drivers/input/touchscreen/usbtouchscreen.c:1052:50: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: James Hilliard Cc: Daniel Ritz Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/touchscreen/usbtouchscreen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c index 397cb1d3f481b..c3b7130cd9033 100644 --- a/drivers/input/touchscreen/usbtouchscreen.c +++ b/drivers/input/touchscreen/usbtouchscreen.c @@ -1049,7 +1049,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt) unsigned int data_len = be16_to_cpu(packet->data_len); unsigned int x_len = be16_to_cpu(packet->x_len); unsigned int y_len = be16_to_cpu(packet->y_len); - int x, y, begin_x, begin_y, end_x, end_y, w, h, ret; + int x, y, begin_x, begin_y, end_x, end_y, w, h; /* got touch data? */ if ((pkt[0] & 0xe0) != 0xe0) @@ -1061,7 +1061,7 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt) x_len -= 0x80; /* send ACK */ - ret = usb_submit_urb(priv->ack, GFP_ATOMIC); + usb_submit_urb(priv->ack, GFP_ATOMIC); if (!usbtouch->type->max_xc) { usbtouch->type->max_xc = 2 * x_len; From patchwork Thu Nov 26 13:36:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11933999 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B695C64E75 for ; Thu, 26 Nov 2020 13:36:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E6852087C for ; Thu, 26 Nov 2020 13:36:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="X+JCQyhr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390467AbgKZNgU (ORCPT ); Thu, 26 Nov 2020 08:36:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390327AbgKZNgT (ORCPT ); Thu, 26 Nov 2020 08:36:19 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99011C0617A7 for ; Thu, 26 Nov 2020 05:36:19 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id x22so2163133wmc.5 for ; Thu, 26 Nov 2020 05:36:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YJZuOyPoke9O1aNcUMwMh4SJuqZZoxbP5+ZVqt4w+RI=; b=X+JCQyhrfwOusPtMMbMFFQqy9G3DnrN0Apfg0toduxUQh7QrAPEpyOcrVwrW4GIGOf WZO3vAn7iAx/44TweVYH0J+J8iBHKESeAod+9TIG5Ol3Xr3Oey1B6tY21C5nhyjzJqEc GSRuryP7dGIjAzaTCsuaWDaDHUV8Px1plwRMkMwh6yZeI/EiLZ+rB1qVgPfozWIfdQ01 WX5/+bkNu2JwnKYrQijfM/RKsGURD370CI+TpX3yb0nuCi5Z4HDdgFqeM8qRNbSc1W/I vSHpIUrn6C0LaCRUj3lhTFyTlm5r2Mby3uov+qbe4t8u3uK2krXnEC37R7SGeZ6L1UIP zoOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YJZuOyPoke9O1aNcUMwMh4SJuqZZoxbP5+ZVqt4w+RI=; b=KZbx6Xfb0QqSXYMutP0CXLOUO+TlvyqOq8JCUZzwCtBQgz0HFQok3cCauG2Su6oIf/ aQcMjlXGMeMezOw/Tt7/HtUohyepxN23XmmWQRRFCLhti1pMEcQtEzyJcDZOSHK6a0Hm Y78ZGB/eTI8sTDUfyjUuc+8D8ET/O6ntl9pxwp9BtBEAaQz+w0nWaLOuVDdUj8CkOkxu Re6EYBtaocn7SZpL7jPqk038nQPLWsYuCMZEY1kqe6pft1ZM2SksY+kzmHblrrTvYvNd voXai+2ap/WO0QFs7mljzuM3PH8zMRlNhiZiiyuzLy0B64hYf7Wi2OlHviJFcdvDgtcw 51jA== X-Gm-Message-State: AOAM532UxhQCF0gQyWc55IY58r3i+gnOfWX4BNuFZuIOH7TL4zFkbtTV l06JMmAwBZguUuYG/fmLT8Y92rnq69wDM5L+ X-Google-Smtp-Source: ABdhPJxLtvF9xQt6Eye8xlahrZrJol0bdVI8FzxBdv1mrVpSPY40QBjsFnhs3BvAKDV65oEIj6UgcA== X-Received: by 2002:a7b:c19a:: with SMTP id y26mr3511199wmi.88.1606397778263; Thu, 26 Nov 2020 05:36:18 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id l3sm9056280wrr.89.2020.11.26.05.36.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:36:17 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Henrik Rydberg , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH v2 4/4] input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp' Date: Thu, 26 Nov 2020 13:36:07 +0000 Message-Id: <20201126133607.3212484-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133607.3212484-1-lee.jones@linaro.org> References: <20201126133607.3212484-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/surface3_spi.c: In function ‘surface3_spi_process_touch’: drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable ‘timestamp’ set but not used [-Wunused-but-set-variable] Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/touchscreen/surface3_spi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/input/touchscreen/surface3_spi.c b/drivers/input/touchscreen/surface3_spi.c index 731454599fcee..1da23e5585a0d 100644 --- a/drivers/input/touchscreen/surface3_spi.c +++ b/drivers/input/touchscreen/surface3_spi.c @@ -94,9 +94,7 @@ static void surface3_spi_report_touch(struct surface3_ts_data *ts_data, static void surface3_spi_process_touch(struct surface3_ts_data *ts_data, u8 *data) { - u16 timestamp; unsigned int i; - timestamp = get_unaligned_le16(&data[15]); for (i = 0; i < 13; i++) { struct surface3_ts_data_finger *finger;