From patchwork Fri Nov 27 07:18:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Ujfalusi X-Patchwork-Id: 11935093 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AE05C2D0E4 for ; Fri, 27 Nov 2020 07:19:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5EB521D93 for ; Fri, 27 Nov 2020 07:19:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VSOxaThS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Dg4TgYQ+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5EB521D93 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PuG3Y3DCccEzpYrXBmPv4wuIRMpZCH812xGaQrkWqw0=; b=VSOxaThSIskt6tFVTBJujs22J r88Ojq698lS+tYa/4LyHSvThoWH3Nk+wVy610/yLSdHfqQ+V89lLyV4AzrAa7JpxiX0WYpxu0qHGR JjO3keJrdJnAsS9p8hvV+3yab/C7BYbmAUTBWa/Tlw74P90idq4ZkpS7HV+FS0xjUR5eX1CVzIxjC eHYPhe5g4dnm/eQfeKZT1RWSz4s22Kl3UcazXj1BrcrNDbL6bsEPeacUy6l9uX7Fz0lzL8mZnH6hI iIWpSaCNd9YR4InobbtdK5LIUmzpE+z+rWS7Tij4On0Wh12OGxKBTKb5+uLIVykaLCTMhXM6Vl508 p35tb29gg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiY0r-0001RB-1a; Fri, 27 Nov 2020 07:17:49 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiY0m-0001NN-0r for linux-arm-kernel@lists.infradead.org; Fri, 27 Nov 2020 07:17:45 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0AR7HcdA128347; Fri, 27 Nov 2020 01:17:38 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1606461458; bh=QCEaSAPyq4gNobl1XoJ4kq3NkpE9v4LSEb38RtVgIik=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=Dg4TgYQ+CSyn6JRe2Sgbfq2RwZYMSVbOPhB5py1tiotoGlbYMx0lz6doOhyrUPMbD ZYp0pzEl9xq5NP8rRRRCoe/S33/xAcyZkOlylYa+7XAJvPDgbyScv6KT6YiVIngvW4 FieivqcUXtz6pI9L5xns/kTKkXQPpyLoxDA5NKDY= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0AR7Hc1S105208 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Nov 2020 01:17:38 -0600 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Fri, 27 Nov 2020 01:17:38 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Fri, 27 Nov 2020 01:17:38 -0600 Received: from feketebors.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0AR7HZt6015823; Fri, 27 Nov 2020 01:17:35 -0600 From: Peter Ujfalusi To: , , Subject: [PATCH] dmaengine: ti: k3-udma-glue: Add new class for glue channels Date: Fri, 27 Nov 2020 09:18:31 +0200 Message-ID: <20201127071831.29986-1-peter.ujfalusi@ti.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201117105656.5236-20-peter.ujfalusi@ti.com> References: <20201117105656.5236-20-peter.ujfalusi@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201127_021744_304898_C8D63ADC X-CRM114-Status: GOOD ( 16.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: grygorii.strashko@ti.com, vigneshr@ti.com, linux-kernel@vger.kernel.org, t-kristo@ti.com, dmaengine@vger.kernel.org, dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The dev_release must be provided for a device and in case of the udma glue layer it is in essence an empty function as the struct containing the registered device is devm managed. Reported-by: Vignesh Raghavendra Signed-off-by: Peter Ujfalusi --- Hi, now that we actually have the silicon and the glue layer got into use it was descovered that we need to have a class with dev_release function for the devices we create for the physical channels used by the glue layer. Vinod: I would prefer to send v3 and squash this patch down to the parent. Regards, Peter drivers/dma/ti/k3-udma-glue.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma/ti/k3-udma-glue.c index 2d0b26a7bf78..790027a99c4c 100644 --- a/drivers/dma/ti/k3-udma-glue.c +++ b/drivers/dma/ti/k3-udma-glue.c @@ -85,6 +85,16 @@ struct k3_udma_glue_rx_channel { u32 flows_ready; }; +static void chan_dev_release(struct device *dev) +{ + /* The struct containing the device is devm managed */ +} + +static struct class k3_udma_glue_devclass = { + .name = "k3_udma_glue_chan", + .dev_release = chan_dev_release, +}; + #define K3_UDMAX_TDOWN_TIMEOUT_US 1000 static int of_k3_udma_glue_parse(struct device_node *udmax_np, @@ -286,6 +296,7 @@ struct k3_udma_glue_tx_channel *k3_udma_glue_request_tx_chn(struct device *dev, } tx_chn->udma_tchan_id = xudma_tchan_get_id(tx_chn->udma_tchanx); + tx_chn->common.chan_dev.class = &k3_udma_glue_devclass; tx_chn->common.chan_dev.parent = xudma_get_device(tx_chn->common.udmax); dev_set_name(&tx_chn->common.chan_dev, "tchan%d-0x%04x", tx_chn->udma_tchan_id, tx_chn->common.dst_thread); @@ -903,6 +914,7 @@ k3_udma_glue_request_rx_chn_priv(struct device *dev, const char *name, } rx_chn->udma_rchan_id = xudma_rchan_get_id(rx_chn->udma_rchanx); + rx_chn->common.chan_dev.class = &k3_udma_glue_devclass; rx_chn->common.chan_dev.parent = xudma_get_device(rx_chn->common.udmax); dev_set_name(&rx_chn->common.chan_dev, "rchan%d-0x%04x", rx_chn->udma_rchan_id, rx_chn->common.src_thread); @@ -1033,6 +1045,7 @@ k3_udma_glue_request_remote_rx_chn(struct device *dev, const char *name, goto err; } + rx_chn->common.chan_dev.class = &k3_udma_glue_devclass; rx_chn->common.chan_dev.parent = xudma_get_device(rx_chn->common.udmax); dev_set_name(&rx_chn->common.chan_dev, "rchan_remote-0x%04x", rx_chn->common.src_thread); @@ -1419,3 +1432,9 @@ void k3_udma_glue_rx_cppi5_to_dma_addr(struct k3_udma_glue_rx_channel *rx_chn, *addr &= (u64)GENMASK(K3_ADDRESS_ASEL_SHIFT - 1, 0); } EXPORT_SYMBOL_GPL(k3_udma_glue_rx_cppi5_to_dma_addr); + +static int __init k3_udma_glue_class_init(void) +{ + return class_register(&k3_udma_glue_devclass); +} +arch_initcall(k3_udma_glue_class_init);