From patchwork Tue Nov 6 16:59:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Bianconi X-Patchwork-Id: 10670849 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 447B513A4 for ; Tue, 6 Nov 2018 17:00:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 34D9A2A9C4 for ; Tue, 6 Nov 2018 17:00:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 293F92A9ED; Tue, 6 Nov 2018 17:00:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AE2202A9E3 for ; Tue, 6 Nov 2018 17:00:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389447AbeKGC0R (ORCPT ); Tue, 6 Nov 2018 21:26:17 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:43314 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389285AbeKGC0Q (ORCPT ); Tue, 6 Nov 2018 21:26:16 -0500 Received: by mail-wr1-f65.google.com with SMTP id y3-v6so14049369wrh.10 for ; Tue, 06 Nov 2018 09:00:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1Zr/yr36XtR7nj8WAI/rLWpJ8ZqzD69e2a6KztYJlfs=; b=X1uvfcivNMu3rKOH9dwL4wqDN1fkRP6YjakJ3EYdzc5+QBsXIZnvQ0zU4YO6S5pyTS NaTpsELhUdCKaAtA8hKgcZLGFUN8Ovks4Ob0Wwk9JlyZjFvNOyKBSdG28qFAk8Oh9Mys CuwFEU6uIbyZOzwv6pG9SfM8sYxBc5yiWdWOFb2NZ+Mn0YWSqcbhhnPtklj2ou/unDQN 98mPDSUZi66W9tiuWhEwxs0o+WH0zOcJwkIcK3dokLZfF06R2qa2M1a39byWzt+KqDDb 66S2tksdNhcFpkPY0cIfhJhWraE3NBNriIq3FaUdk+ZXxgQfCV5QnJM+9C/upOq++N8u Pn2A== X-Gm-Message-State: AGRZ1gK4VEQ1PfsLX4PFGniaNfhAB5E1K/IJw7FJh+gypvjpWiYojk/h Hc9LwDJ1k5+/dPetRp5RgyE5Tw== X-Google-Smtp-Source: AJdET5duay4ylNQIQm/9lVTHVaLIVdFSUltX893unQ56TdwPwcMwvQTeMa2Xn+In3t84zZ3GiC0cTA== X-Received: by 2002:adf:ff4e:: with SMTP id u14-v6mr24206875wrs.232.1541523607906; Tue, 06 Nov 2018 09:00:07 -0800 (PST) Received: from localhost.localdomain.com (nat-pool-mxp-t.redhat.com. [149.6.153.186]) by smtp.gmail.com with ESMTPSA id x142-v6sm649271wmd.20.2018.11.06.09.00.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Nov 2018 09:00:07 -0800 (PST) From: Lorenzo Bianconi To: nbd@nbd.name Cc: sgruszka@redhat.com, linux-wireless@vger.kernel.org Subject: [PATCH 1/4] mt76x2u: phy: add TX_SHAPING calibration Date: Tue, 6 Nov 2018 17:59:45 +0100 Message-Id: <1870868969df6afe13a424a69af2802f9bb9ab9f.1541522368.git.lorenzo.bianconi@redhat.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: References: Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add MCU_CAL_TX_SHAPING calibration in mt76x2u_phy_channel_calibrate routine since now mt76x2 and mt76x2u driver run the same firmware Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76x2/usb_phy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2/usb_phy.c b/drivers/net/wireless/mediatek/mt76/mt76x2/usb_phy.c index 8011c261c658..24e292e895b6 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x2/usb_phy.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x2/usb_phy.c @@ -35,6 +35,7 @@ void mt76x2u_phy_channel_calibrate(struct mt76x02_dev *dev) mt76x02_mcu_calibrate(dev, MCU_CAL_TXIQ, is_5ghz, false); mt76x02_mcu_calibrate(dev, MCU_CAL_RXIQC_FI, is_5ghz, false); mt76x02_mcu_calibrate(dev, MCU_CAL_TEMP_SENSOR, 0, false); + mt76x02_mcu_calibrate(dev, MCU_CAL_TX_SHAPING, 0, false); mt76x2u_mac_resume(dev); } From patchwork Tue Nov 6 16:59:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Bianconi X-Patchwork-Id: 10670851 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 15AA2109C for ; Tue, 6 Nov 2018 17:00:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 043762A9EE for ; Tue, 6 Nov 2018 17:00:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ED12729AF3; Tue, 6 Nov 2018 17:00:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C3D7D2A9E2 for ; Tue, 6 Nov 2018 17:00:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389472AbeKGC0T (ORCPT ); Tue, 6 Nov 2018 21:26:19 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:39888 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389285AbeKGC0S (ORCPT ); Tue, 6 Nov 2018 21:26:18 -0500 Received: by mail-wr1-f67.google.com with SMTP id r10-v6so14348737wrv.6 for ; Tue, 06 Nov 2018 09:00:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ApYZFf76b5XRsmIvDN9IPXMTLRw15PGsC2g0FCH5Zfg=; b=J87F8uJPBPGRXY4LjB2J4EH0mm3MWXSGUb8UknOJ7UMZh37csFb+XT/Pi5hRjNoLXY 3WnG9xBJosfHdhCaxhsHheBcxj7Ikkvh7w711X8YZIXlJAbDhGntl8rC/WnuA/gh7Q1P O/oq/6V0tEbAJUWDlEtxewjun3HKRtY37TIUJhZpo6QOnNGpXgmlNd8xKEpkuCXutSZC QoGEOL2lH5baVxQvci0glk95WM4M/0v6Hsqf3CMlcp4kRDPJ2m0Ovrh4EyDjPHf8iTCN 9Zo2lIsGkYn5xnrbBJdFF82JFuKAhUfibzRz7essg2AKTwB4Ke71LwnHRBs9fqgSfjDs Pvsg== X-Gm-Message-State: AGRZ1gL4l2gszpOi6Yag07b4IdZTx1p47nRyX+Wk30HDdd0weKSZ+fPc vtWUAJyz6Wh4UEK9i4Vimd9Osg== X-Google-Smtp-Source: AJdET5dCOy44sh/qlOCafTukmL1sdOf72rjNqvBXdy+L+uCUmx4uyzluv+V9LTCrA7IyN+iLpl/kuQ== X-Received: by 2002:adf:fe44:: with SMTP id m4-v6mr7152359wrs.309.1541523609731; Tue, 06 Nov 2018 09:00:09 -0800 (PST) Received: from localhost.localdomain.com (nat-pool-mxp-t.redhat.com. [149.6.153.186]) by smtp.gmail.com with ESMTPSA id x142-v6sm649271wmd.20.2018.11.06.09.00.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Nov 2018 09:00:09 -0800 (PST) From: Lorenzo Bianconi To: nbd@nbd.name Cc: sgruszka@redhat.com, linux-wireless@vger.kernel.org Subject: [PATCH 2/4] mt76x2u: phy: run phy_channel_calibrate after channel switch Date: Tue, 6 Nov 2018 17:59:46 +0100 Message-Id: X-Mailer: git-send-email 2.17.2 In-Reply-To: References: Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Perform channel calibration after each channel switch and not only after connection establishment since NetworkManager perform multiple frequency scanning if RSSI in lower a given threshold Signed-off-by: Lorenzo Bianconi --- .../wireless/mediatek/mt76/mt76x2/mt76x2u.h | 1 - .../wireless/mediatek/mt76/mt76x2/usb_main.c | 5 ----- .../wireless/mediatek/mt76/mt76x2/usb_phy.c | 18 +++++++++++++++--- 3 files changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2/mt76x2u.h b/drivers/net/wireless/mediatek/mt76/mt76x2/mt76x2u.h index 833974de5c80..0b0075411b34 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x2/mt76x2u.h +++ b/drivers/net/wireless/mediatek/mt76/mt76x2/mt76x2u.h @@ -43,7 +43,6 @@ int mt76x2u_mac_stop(struct mt76x02_dev *dev); int mt76x2u_phy_set_channel(struct mt76x02_dev *dev, struct cfg80211_chan_def *chandef); void mt76x2u_phy_calibrate(struct work_struct *work); -void mt76x2u_phy_channel_calibrate(struct mt76x02_dev *dev); void mt76x2u_mcu_complete_urb(struct urb *urb); int mt76x2u_mcu_init(struct mt76x02_dev *dev); diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2/usb_main.c b/drivers/net/wireless/mediatek/mt76/mt76x2/usb_main.c index c2e0a43082e5..cad99715997e 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x2/usb_main.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x2/usb_main.c @@ -91,11 +91,6 @@ mt76x2u_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif, mutex_lock(&dev->mt76.mutex); - if (changed & BSS_CHANGED_ASSOC) { - mt76x2u_phy_channel_calibrate(dev); - mt76x2_apply_gain_adj(dev); - } - if (changed & BSS_CHANGED_BSSID) { mt76_wr(dev, MT_MAC_BSSID_DW0, get_unaligned_le32(info->bssid)); diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2/usb_phy.c b/drivers/net/wireless/mediatek/mt76/mt76x2/usb_phy.c index 24e292e895b6..a64268e8db42 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x2/usb_phy.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x2/usb_phy.c @@ -18,15 +18,20 @@ #include "eeprom.h" #include "../mt76x02_phy.h" -void mt76x2u_phy_channel_calibrate(struct mt76x02_dev *dev) +static void +mt76x2u_phy_channel_calibrate(struct mt76x02_dev *dev, bool mac_stopped) { struct ieee80211_channel *chan = dev->mt76.chandef.chan; bool is_5ghz = chan->band == NL80211_BAND_5GHZ; + if (dev->cal.channel_cal_done) + return; + if (mt76x2_channel_silent(dev)) return; - mt76x2u_mac_stop(dev); + if (!mac_stopped) + mt76x2u_mac_stop(dev); if (is_5ghz) mt76x02_mcu_calibrate(dev, MCU_CAL_LC, 0, false); @@ -37,7 +42,11 @@ void mt76x2u_phy_channel_calibrate(struct mt76x02_dev *dev) mt76x02_mcu_calibrate(dev, MCU_CAL_TEMP_SENSOR, 0, false); mt76x02_mcu_calibrate(dev, MCU_CAL_TX_SHAPING, 0, false); - mt76x2u_mac_resume(dev); + if (!mac_stopped) + mt76x2u_mac_resume(dev); + mt76x2_apply_gain_adj(dev); + + dev->cal.channel_cal_done = true; } void mt76x2u_phy_calibrate(struct work_struct *work) @@ -45,6 +54,7 @@ void mt76x2u_phy_calibrate(struct work_struct *work) struct mt76x02_dev *dev; dev = container_of(work, struct mt76x02_dev, cal_work.work); + mt76x2u_phy_channel_calibrate(dev, false); mt76x2_phy_tssi_compensate(dev, false); mt76x2_phy_update_channel_gain(dev); @@ -165,7 +175,9 @@ int mt76x2u_phy_set_channel(struct mt76x02_dev *dev, if (scan) return 0; + mt76x2u_phy_channel_calibrate(dev, true); mt76x02_init_agc_gain(dev); + if (mt76x2_tssi_enabled(dev)) { /* init default values for temp compensation */ mt76_rmw_field(dev, MT_TX_ALC_CFG_1, MT_TX_ALC_CFG_1_TEMP_COMP, From patchwork Tue Nov 6 16:59:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Bianconi X-Patchwork-Id: 10670853 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7AF16109C for ; Tue, 6 Nov 2018 17:00:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6C96C2A9E7 for ; Tue, 6 Nov 2018 17:00:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6B0F92A9C1; Tue, 6 Nov 2018 17:00:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1325E2A9F7 for ; Tue, 6 Nov 2018 17:00:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389482AbeKGC0V (ORCPT ); Tue, 6 Nov 2018 21:26:21 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:46763 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389285AbeKGC0V (ORCPT ); Tue, 6 Nov 2018 21:26:21 -0500 Received: by mail-wr1-f67.google.com with SMTP id 74-v6so14335557wrb.13 for ; Tue, 06 Nov 2018 09:00:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gDQUstN8ielQYKv4iw7PRV0NeDRDMswtkC8vk+awLq8=; b=USiMU5h8/a5BST41h4y7l9v1x76wkRsObs+71Fen4+xLt3VCP10GDwMoFa8TjYILFJ v8o8iplnBVPMOSsdeHQDORHgDwrhpizq8a7TUTbdg3m4fEbBMXXiVv3fr3LmqpRI+oXS 3v/UG9K1zOOCiIrVVkICc7S+ZCcZvFgtO0boOwMuI449emLmQ+Y7PO4D030Km00n1FgC euyTBo+05fvJkKiMWLamNuCCw9d8Gh874QrOHMpEYc537HDM/VAqCZcBQOgKlP+SDrqC 6tLxXgENMfIJsMMxcMxf91ngpfBimVuL92SJlQEnCHhxCxo2CMRHaL/g41wrU4L3cUrP iWQQ== X-Gm-Message-State: AGRZ1gKDb6xexiZW5kadEf+Nbhy3HjHl7ETK+qe14X/Tiv3YNI/eF3I0 n4QzQgTtjN94yh9pLLYVCK3lyP430YQ= X-Google-Smtp-Source: AJdET5eXLdg6tRHB/zpzHGTv5RX/9JqPDmuossNJzRyTCCpFTWr7s/9xt8ufCXEQfov/PyCqLeXu1w== X-Received: by 2002:adf:e406:: with SMTP id g6-v6mr17422552wrm.277.1541523612231; Tue, 06 Nov 2018 09:00:12 -0800 (PST) Received: from localhost.localdomain.com (nat-pool-mxp-t.redhat.com. [149.6.153.186]) by smtp.gmail.com with ESMTPSA id x142-v6sm649271wmd.20.2018.11.06.09.00.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Nov 2018 09:00:11 -0800 (PST) From: Lorenzo Bianconi To: nbd@nbd.name Cc: sgruszka@redhat.com, linux-wireless@vger.kernel.org Subject: [PATCH 3/4] mt76x2u: main: use mt76x02_bss_info_changed utility routine Date: Tue, 6 Nov 2018 17:59:47 +0100 Message-Id: X-Mailer: git-send-email 2.17.2 In-Reply-To: References: Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Initialize bss_info_changed mac80211 callback to mt76x02_bss_info_changed utility routine and remove duplicated code. Use 8 as WCID index for sta interface Signed-off-by: Lorenzo Bianconi --- .../wireless/mediatek/mt76/mt76x2/usb_main.c | 23 +++---------------- 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2/usb_main.c b/drivers/net/wireless/mediatek/mt76/mt76x2/usb_main.c index cad99715997e..a9ecc92875ae 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x2/usb_main.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x2/usb_main.c @@ -50,11 +50,12 @@ static int mt76x2u_add_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif) { struct mt76x02_dev *dev = hw->priv; + unsigned int idx = 8; if (!ether_addr_equal(dev->mt76.macaddr, vif->addr)) mt76x02_mac_setaddr(dev, vif->addr); - mt76x02_vif_init(dev, vif, 0); + mt76x02_vif_init(dev, vif, idx); return 0; } @@ -83,24 +84,6 @@ mt76x2u_set_channel(struct mt76x02_dev *dev, return err; } -static void -mt76x2u_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif, - struct ieee80211_bss_conf *info, u32 changed) -{ - struct mt76x02_dev *dev = hw->priv; - - mutex_lock(&dev->mt76.mutex); - - if (changed & BSS_CHANGED_BSSID) { - mt76_wr(dev, MT_MAC_BSSID_DW0, - get_unaligned_le32(info->bssid)); - mt76_wr(dev, MT_MAC_BSSID_DW1, - get_unaligned_le16(info->bssid + 4)); - } - - mutex_unlock(&dev->mt76.mutex); -} - static int mt76x2u_config(struct ieee80211_hw *hw, u32 changed) { @@ -150,7 +133,7 @@ const struct ieee80211_ops mt76x2u_ops = { .ampdu_action = mt76x02_ampdu_action, .config = mt76x2u_config, .wake_tx_queue = mt76_wake_tx_queue, - .bss_info_changed = mt76x2u_bss_info_changed, + .bss_info_changed = mt76x02_bss_info_changed, .configure_filter = mt76x02_configure_filter, .conf_tx = mt76x02_conf_tx, .sw_scan_start = mt76x02_sw_scan, From patchwork Tue Nov 6 16:59:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Bianconi X-Patchwork-Id: 10670855 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4505E13A4 for ; Tue, 6 Nov 2018 17:00:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 33BFF2A9C8 for ; Tue, 6 Nov 2018 17:00:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 312B32A9FB; Tue, 6 Nov 2018 17:00:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CA2092A9E9 for ; Tue, 6 Nov 2018 17:00:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389495AbeKGC0Y (ORCPT ); Tue, 6 Nov 2018 21:26:24 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:38607 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389285AbeKGC0X (ORCPT ); Tue, 6 Nov 2018 21:26:23 -0500 Received: by mail-wm1-f66.google.com with SMTP id l2-v6so12862204wmh.3 for ; Tue, 06 Nov 2018 09:00:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=JynL7O12bknstPoP9n4LYotMSCHrMx0BQnxUnYeAqa0=; b=WYZgEhT+UXkQ3T53O8O94VXOixw/Z4ve8d3o5HeXsr+iSVsS36OrVnrafMbRQ7v6hv njn5Q0DbNjNOcHNW5WPsm5/3OhHMCXRzMF+58Nle8+2XnHuJyJTXulbp87GQsE8yuIyy qqnn/IfX62ylmbKugrZyLK9AtRLjyc4A5vWv9C/AifdmcP0H/fP0gZ39edNLL1G7Alxb TV8bYPYZ80WGMb2SewoXd3mlN/oING3V6J5bA6vj1itYueZhheIqCSLyx5FZ0Dg+KoL1 xrOLa6uAYHePgE30gnr5Wc8e0nk7AGFgPsMP/VeDGnz2xW4GsV+/0RE1rsUb4pwRCA2u GoIA== X-Gm-Message-State: AGRZ1gJ11Msj9hbZS3LrM2Y2Ycj7397P2ZIB06pO4EndnNizVkUnvX/0 Rrmy3RP98g1zR2/PPdUDPE1lZw== X-Google-Smtp-Source: AJdET5eDRi8s/ovZeHqpFzOXyTSdoJpZlgvZ8PA46Xl0yCHJbN/wIrCWvZYZsSjN7fZD8ZZIsddTzw== X-Received: by 2002:a1c:5788:: with SMTP id l130-v6mr2603946wmb.60.1541523614885; Tue, 06 Nov 2018 09:00:14 -0800 (PST) Received: from localhost.localdomain.com (nat-pool-mxp-t.redhat.com. [149.6.153.186]) by smtp.gmail.com with ESMTPSA id x142-v6sm649271wmd.20.2018.11.06.09.00.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Nov 2018 09:00:14 -0800 (PST) From: Lorenzo Bianconi To: nbd@nbd.name Cc: sgruszka@redhat.com, linux-wireless@vger.kernel.org Subject: [PATCH 4/4] mt76x2u: init: remove mt76x2u_init_beacon_offsets routine Date: Tue, 6 Nov 2018 17:59:48 +0100 Message-Id: <76835f131fa51259fcbf79df7b7073f808aa7cd2.1541522368.git.lorenzo.bianconi@redhat.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: References: Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Remove mt76x2u_init_beacon_offsets routine since the driver supports just STA mode Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76x2/usb_init.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2/usb_init.c b/drivers/net/wireless/mediatek/mt76/mt76x2/usb_init.c index 8b280a4ea792..de0fbdb02c4d 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x2/usb_init.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x2/usb_init.c @@ -156,14 +156,6 @@ struct mt76x02_dev *mt76x2u_alloc_device(struct device *pdev) return dev; } -static void mt76x2u_init_beacon_offsets(struct mt76x02_dev *dev) -{ - mt76_wr(dev, MT_BCN_OFFSET(0), 0x18100800); - mt76_wr(dev, MT_BCN_OFFSET(1), 0x38302820); - mt76_wr(dev, MT_BCN_OFFSET(2), 0x58504840); - mt76_wr(dev, MT_BCN_OFFSET(3), 0x78706860); -} - int mt76x2u_init_hardware(struct mt76x02_dev *dev) { int i, k, err; @@ -200,8 +192,6 @@ int mt76x2u_init_hardware(struct mt76x02_dev *dev) mt76x02_mac_setaddr(dev, dev->mt76.eeprom.data + MT_EE_MAC_ADDR); dev->mt76.rxfilter = mt76_rr(dev, MT_RX_FILTR_CFG); - mt76x2u_init_beacon_offsets(dev); - if (!mt76x02_wait_for_txrx_idle(&dev->mt76)) return -ETIMEDOUT;