From patchwork Thu Dec 3 20:18:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anna Schumaker X-Patchwork-Id: 11949537 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C52AC4361A for ; Thu, 3 Dec 2020 20:19:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E70421E92 for ; Thu, 3 Dec 2020 20:19:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727850AbgLCUT0 (ORCPT ); Thu, 3 Dec 2020 15:19:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727844AbgLCUTZ (ORCPT ); Thu, 3 Dec 2020 15:19:25 -0500 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F9FAC061A53 for ; Thu, 3 Dec 2020 12:18:45 -0800 (PST) Received: by mail-qk1-x743.google.com with SMTP id q22so3400827qkq.6 for ; Thu, 03 Dec 2020 12:18:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WtxAoLGt1uk0hZ2EXOqGreitEccXumouSJeNLPddMUs=; b=sbnbYPQR0LzpCq8NmhQGbrp7d9/D4KmAAS0ZEm7+wjgdbs2yNjVvmm5iHSZAqgb4br rAFudVHszPiC2dVFPTqRk9v45NrTosyGdtj33R6wWyE0yZWJd519iJN40Y+xsFHyt+xf 3UtFy3ENeKkV66/2aBqbPDKXabijWMf9imXSD0bDJp9A12mZ1PoCAnCEWM6YgidD2LZQ YXym6ixVvfD6XxYZvSqV2CqXuNsystYwMlJ5h23zUDzKMGTz+DpfGNjzTgcqc8nPE1/i PAFeNQVTR3QPW3WKXCUraeTl40C2cfVYiDffOrw+xdrjDP/wugD6LY5FbXL6Z+rY1/V3 PfDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=WtxAoLGt1uk0hZ2EXOqGreitEccXumouSJeNLPddMUs=; b=ZwTyihOho58LMYlypkiznMOgp8fi5nsJ8/KCZoV6KICYkF+Ptm1dnFuFgY1LXVy9y3 ZZkG8NUXtSCT5RMqlC1StrwHv3UQIRJQKHSX+o3g5QcPrKM8ooT8OP20NzZdlh+K7z9l qsOfNbzFAGLEKeAN3kIZeY4+YLRZ7ERWA3jK0/CfXhbMBwjleDxpA/fREQ+8n87RHLNx W6VukClP18/QrEYHkRMVUjD4pAol+UYCiMC6AHFwnB3wrNjw8BsLWGzxjvAnkx33fTFE +s+83prF25CrKmvo2dc4uq8l6sECtMj0kYI/GYU4gpYAwlJbIEUoW2bOy92GLri6mDFC sk5g== X-Gm-Message-State: AOAM532ueM/GotiHgDBN85OF9i/yzsq30m2cjz0f9BVerhxaB+n9TvYE iaLTDfAy9Ws7yOWTHUeT7nlCvW88sw4= X-Google-Smtp-Source: ABdhPJx8ucIfUFgSNFNw3bUWSQ+wBgowhS9hmRft/hASZKa13zlmj5jGeoYddwhjJzi2VC2MbhGWEA== X-Received: by 2002:a37:ac19:: with SMTP id e25mr4681087qkm.344.1607026724516; Thu, 03 Dec 2020 12:18:44 -0800 (PST) Received: from gouda.nowheycreamery.com (c-68-32-74-190.hsd1.mi.comcast.net. [68.32.74.190]) by smtp.gmail.com with ESMTPSA id q20sm2194530qtn.80.2020.12.03.12.18.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Dec 2020 12:18:43 -0800 (PST) Sender: Anna Schumaker From: schumaker.anna@gmail.com X-Google-Original-From: Anna.Schumaker@Netapp.com To: linux-nfs@vger.kernel.org Cc: Anna.Schumaker@Netapp.com Subject: [PATCH 1/3] NFS: Disable READ_PLUS by default Date: Thu, 3 Dec 2020 15:18:39 -0500 Message-Id: <20201203201841.103294-2-Anna.Schumaker@Netapp.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201203201841.103294-1-Anna.Schumaker@Netapp.com> References: <20201203201841.103294-1-Anna.Schumaker@Netapp.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Anna Schumaker We've been seeing failures with xfstests generic/091 and generic/263 when using READ_PLUS. I've made some progress on these issues, and the tests fail later on but still don't pass. Let's disable READ_PLUS by default until we can work out what is going on. Signed-off-by: Anna Schumaker --- fs/nfs/Kconfig | 9 +++++++++ fs/nfs/nfs4proc.c | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig index 88e1763e02f3..e2a488d403a6 100644 --- a/fs/nfs/Kconfig +++ b/fs/nfs/Kconfig @@ -205,3 +205,12 @@ config NFS_DISABLE_UDP_SUPPORT Choose Y here to disable the use of NFS over UDP. NFS over UDP on modern networks (1Gb+) can lead to data corruption caused by fragmentation during high loads. + +config NFS_V4_2_READ_PLUS + bool "NFS: Enable support for the NFSv4.2 READ_PLUS operation" + depends on NFS_V4_2 + default n + help + This is intended for developers only. The READ_PLUS operation has + been shown to have issues under specific conditions and should not + be used in production. diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 9e0ca9b2b210..e89468678ae1 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -5309,7 +5309,7 @@ static int nfs4_read_done(struct rpc_task *task, struct nfs_pgio_header *hdr) nfs4_read_done_cb(task, hdr); } -#ifdef CONFIG_NFS_V4_2 +#if defined CONFIG_NFS_V4_2 && defined CONFIG_NFS_V4_2_READ_PLUS static void nfs42_read_plus_support(struct nfs_server *server, struct rpc_message *msg) { if (server->caps & NFS_CAP_READ_PLUS) From patchwork Thu Dec 3 20:18:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anna Schumaker X-Patchwork-Id: 11949541 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7819C4167B for ; Thu, 3 Dec 2020 20:19:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64BB0221F4 for ; Thu, 3 Dec 2020 20:19:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727773AbgLCUTd (ORCPT ); Thu, 3 Dec 2020 15:19:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726915AbgLCUTc (ORCPT ); Thu, 3 Dec 2020 15:19:32 -0500 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 783C2C061A4F for ; Thu, 3 Dec 2020 12:18:46 -0800 (PST) Received: by mail-qk1-x743.google.com with SMTP id n132so3427354qke.1 for ; Thu, 03 Dec 2020 12:18:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VpbzW1tJjXNLaoKcxIkBvS9VSfhDnefWLuqJQFG1IaQ=; b=W+s96HL43gfE/BdEiVnEe7Y+Kh2Z2lHe0s0rOsGG/vc3xJ0AjnYNIL0orDRUh29om2 f4Xw2VBnnM3ZuD3wiJzfGcUibOhJFqZW0qq5ZZLQnRzLLKHlrHHofU82bVSYuynJeOd+ AsN1AJKKM7aPWncZU3Xx5bAzskJ04JZJYdwNmGFjp1Ns6kiKBVJyQsolSZYbBqgpEKgP j9U2v+YWCbxX/DjF+ZhAlIFdyDWH9AThA7KLG9pND+78ODe1T8LWqEV2otlSMvx4MRJY lsQdH7czMUeYMsb14mhgPbSBiMuyqj+xbnB7fMaVs34Utm4jN/LSBGWbFV1UzHD3UwKi 8n8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=VpbzW1tJjXNLaoKcxIkBvS9VSfhDnefWLuqJQFG1IaQ=; b=aB8tskonMc4YCNKAk1N9Fv0A3uOF59AIPW0byowZ7zEnQIdY/rDNpbbxkCTLxZj1gc at+wBdSZh1HZBAOOGnxKwqzwBOgX/LPvMd7Wj4aFmRvEEilVu2qsgIn0Ib/N0kEp/WnD 4ib26QbFhLKvVSi4G6xB+W6apJToha6E4A0tjU7KP3qSMc9hxAiszYqlvXfmiOJQ+OmL xU99BX7ByREy/DU2BftCjDjwWJ27Qoz8a93Vp1h+VUflj0sU/u+VA3WkGECVNXm70SqL jMoBCFazOOiXnIpd8E12e2UF0+cB2kEChTTBalBQufiTk2NzMMMb/4qDuVrm7cvAMUrB IDjA== X-Gm-Message-State: AOAM533cknPpVEtEXK3xGV2JLmKoZusiOwAMIYmeUC2s6I1zpdmqb3fd Zd/sgMZ1RTbteRbksDVg02LGOAZw/jc= X-Google-Smtp-Source: ABdhPJybVxmZLbXk9DY2ORHjwGbQFh0OjLwVqo//nRluu7kJv796m0vUnIq4zIJfy6zTywAFW6wGnw== X-Received: by 2002:a05:620a:94d:: with SMTP id w13mr4489799qkw.194.1607026725466; Thu, 03 Dec 2020 12:18:45 -0800 (PST) Received: from gouda.nowheycreamery.com (c-68-32-74-190.hsd1.mi.comcast.net. [68.32.74.190]) by smtp.gmail.com with ESMTPSA id q20sm2194530qtn.80.2020.12.03.12.18.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Dec 2020 12:18:44 -0800 (PST) Sender: Anna Schumaker From: schumaker.anna@gmail.com X-Google-Original-From: Anna.Schumaker@Netapp.com To: linux-nfs@vger.kernel.org Cc: Anna.Schumaker@Netapp.com Subject: [PATCH 2/3] NFS: Allocate a scratch page for READ_PLUS Date: Thu, 3 Dec 2020 15:18:40 -0500 Message-Id: <20201203201841.103294-3-Anna.Schumaker@Netapp.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201203201841.103294-1-Anna.Schumaker@Netapp.com> References: <20201203201841.103294-1-Anna.Schumaker@Netapp.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Anna Schumaker We might need this to better handle shifting around data in the reply buffer. Suggested-by: Trond Myklebust Signed-off-by: Anna Schumaker --- fs/nfs/nfs42xdr.c | 2 ++ fs/nfs/read.c | 13 +++++++++++-- include/linux/nfs_xdr.h | 1 + 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/fs/nfs/nfs42xdr.c b/fs/nfs/nfs42xdr.c index 8432bd6b95f0..ef095a5f86f7 100644 --- a/fs/nfs/nfs42xdr.c +++ b/fs/nfs/nfs42xdr.c @@ -1297,6 +1297,8 @@ static int nfs4_xdr_dec_read_plus(struct rpc_rqst *rqstp, struct compound_hdr hdr; int status; + xdr_set_scratch_buffer(xdr, page_address(res->scratch), PAGE_SIZE); + status = decode_compound_hdr(xdr, &hdr); if (status) goto out; diff --git a/fs/nfs/read.c b/fs/nfs/read.c index eb854f1f86e2..012deb5a136f 100644 --- a/fs/nfs/read.c +++ b/fs/nfs/read.c @@ -37,15 +37,24 @@ static struct kmem_cache *nfs_rdata_cachep; static struct nfs_pgio_header *nfs_readhdr_alloc(void) { - struct nfs_pgio_header *p = kmem_cache_zalloc(nfs_rdata_cachep, GFP_KERNEL); + struct nfs_pgio_header *p; + struct page *page; - if (p) + page = alloc_page(GFP_KERNEL); + if (!page) + return ERR_PTR(-ENOMEM); + + p = kmem_cache_zalloc(nfs_rdata_cachep, GFP_KERNEL); + if (p) { p->rw_mode = FMODE_READ; + p->res.scratch = page; + } return p; } static void nfs_readhdr_free(struct nfs_pgio_header *rhdr) { + __free_page(rhdr->res.scratch); kmem_cache_free(nfs_rdata_cachep, rhdr); } diff --git a/include/linux/nfs_xdr.h b/include/linux/nfs_xdr.h index d63cb862d58e..e0a1c97f11a9 100644 --- a/include/linux/nfs_xdr.h +++ b/include/linux/nfs_xdr.h @@ -659,6 +659,7 @@ struct nfs_pgio_res { struct nfs_fattr * fattr; __u64 count; __u32 op_status; + struct page * scratch; union { struct { unsigned int replen; /* used by read */ From patchwork Thu Dec 3 20:18:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anna Schumaker X-Patchwork-Id: 11949539 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8761EC433FE for ; Thu, 3 Dec 2020 20:19:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3DBB3221F2 for ; Thu, 3 Dec 2020 20:19:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727929AbgLCUT2 (ORCPT ); Thu, 3 Dec 2020 15:19:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727844AbgLCUT1 (ORCPT ); Thu, 3 Dec 2020 15:19:27 -0500 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C3BBC061A54 for ; Thu, 3 Dec 2020 12:18:47 -0800 (PST) Received: by mail-qk1-x743.google.com with SMTP id i199so3404328qke.5 for ; Thu, 03 Dec 2020 12:18:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=T1cjsePf2wHK5cj8ShKsUDNynGhFjKDY0ROw5ITEQmA=; b=oYJbu4CgJ6ipd3YL7eXCNZDu4KsiXVOd1sQOIOoZiE4LY9Ic/bRAIEGfhPUvnJYar4 Ut6SZbXH1cT1oOz3srvf5A+kUkKi45OfbT2fYQbLfNCPaxzKSayDEsUuGPVNH/F8e0WF yx0siKkcIofYX6G3CkDWhAzkqhBjZuxuh5/XgqyAS/WyvD7AswbVLvj+v2qcorAbH2Mk daQRbjKNo3VjDgFZFMwSeKJew2KV7uhZ4vJt+g0x0KNYrCMNhCHYpuTf0xBqQ8I8fEf/ YUvZD3FIUbDjAFb6phQ+eAN4yoWNaIRuZJcnm5A7wNneNrHlSNWTojY8NTecMEl78Dwh cC0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=T1cjsePf2wHK5cj8ShKsUDNynGhFjKDY0ROw5ITEQmA=; b=TbuiXzMJrcRWcZcUFMf5MbJSZXw649IPPTEKElu+fNc+o84w2jG0DH/qYC49gTZ1Xy Z0FgftanL2i2WrCwsPk5V2zcV7IpGVFRUnrPH6KqzBdUSBI8P87CEesK2zKOYz/s686+ R8ubl3DNlAT2BtJi2K5+7T47w/giGAiG999NUUAbBl/vl5ZzDRIJQLIzYSyufLZpH/QG 4b1Qmw3Q6Vq03C1QAupjII+0rlkrp7/wfhBr02jyGjV13cC7vzxxIJ4A5igXjtCHN8LU onS01z+r30mM4x6HHvdyYZJGx+DIPdV3wXxgSBw40C4mITrSpXYK1iDcc5Tyx2t0fbzU xNCA== X-Gm-Message-State: AOAM5322MPS1lC2KTtj4AIob9RttDeuL27VSY04KSrUt2am7AhJ7srFg u9bunThaxyAldP+ETpZwf99NPZW/qyA= X-Google-Smtp-Source: ABdhPJw+oY4qU2W72rTaS286od2Nc15yX1SJ3f+GpLtebM4JSScLE9uzll+eAR/327pLvBbXyzGULw== X-Received: by 2002:a37:a484:: with SMTP id n126mr4693353qke.277.1607026726395; Thu, 03 Dec 2020 12:18:46 -0800 (PST) Received: from gouda.nowheycreamery.com (c-68-32-74-190.hsd1.mi.comcast.net. [68.32.74.190]) by smtp.gmail.com with ESMTPSA id q20sm2194530qtn.80.2020.12.03.12.18.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Dec 2020 12:18:45 -0800 (PST) Sender: Anna Schumaker From: schumaker.anna@gmail.com X-Google-Original-From: Anna.Schumaker@Netapp.com To: linux-nfs@vger.kernel.org Cc: Anna.Schumaker@Netapp.com Subject: [PATCH 3/3] SUNRPC: Keep buf->len in sync with xdr->nwords when expanding holes Date: Thu, 3 Dec 2020 15:18:41 -0500 Message-Id: <20201203201841.103294-4-Anna.Schumaker@Netapp.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201203201841.103294-1-Anna.Schumaker@Netapp.com> References: <20201203201841.103294-1-Anna.Schumaker@Netapp.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Anna Schumaker Otherwise we could end up placing data a few bytes off from where we actually want to put it. Signed-off-by: Anna Schumaker --- net/sunrpc/xdr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c index 71e03b930b70..5b848fe65c81 100644 --- a/net/sunrpc/xdr.c +++ b/net/sunrpc/xdr.c @@ -1314,6 +1314,7 @@ uint64_t xdr_expand_hole(struct xdr_stream *xdr, uint64_t offset, uint64_t lengt unsigned int res = _shift_data_right_tail(buf, from + bytes - shift, shift); truncated = shift - res; xdr->nwords -= XDR_QUADLEN(truncated); + buf->len -= 4 * XDR_QUADLEN(truncated); bytes -= shift; } @@ -1325,7 +1326,7 @@ uint64_t xdr_expand_hole(struct xdr_stream *xdr, uint64_t offset, uint64_t lengt bytes); _zero_pages(buf->pages, buf->page_base + offset, length); - buf->len += length - (from - offset) - truncated; + buf->len += length - (from - offset); xdr_set_page(xdr, offset + length, PAGE_SIZE); return length; }