From patchwork Sat Dec 5 16:54:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yury Norov X-Patchwork-Id: 11953241 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08D38C4361A for ; Sat, 5 Dec 2020 16:55:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC37722EBF for ; Sat, 5 Dec 2020 16:55:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC37722EBF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=xE4ZXVsaDRCjDb7bWKw/EDd8IiMTk2e/BCJFBIleY5o=; b=gTTU+IDru2Jj0cHcxrjIOmHH9I 3cimOlwPNoq09izGHdqs5wMYiiMQhH4BYhsAuy4q3aRNO577ePB7ioY626oamrlDaX8SzPnurVhKq V1ssNBMZVmtaVdgyRNo+sbGRxVIr76TO5Z4xvkKUt1r4CcFnr03/okSUr/8b8eDUZTPsezJvKAHMm 0z7DRBvi4G+xeuVXTwqGfVhzuxdl4hPP9609ZmOcWUOKMgID0pB82qoymU3FUTq4n1cc+P+o2FKWc St/nn+6VKWiVDIWl3lL5Jv0Sb7hqjtAukItYxi6MUlVer8rfzCw7rZbnQWpSs85M0ync5UwlTFux3 q5D9r7dg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1klap5-0004u3-94; Sat, 05 Dec 2020 16:54:15 +0000 Received: from mail-qk1-x743.google.com ([2607:f8b0:4864:20::743]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1klap2-0004th-Te for linux-arm-kernel@lists.infradead.org; Sat, 05 Dec 2020 16:54:13 +0000 Received: by mail-qk1-x743.google.com with SMTP id q22so8602455qkq.6 for ; Sat, 05 Dec 2020 08:54:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=oIRoSEGJLf8joA0+34Z8WBxAWHJSo0r9QDagd8ox+Nc=; b=BVpGu4oj+2gagBMnBu5fD2tvH6kcIWlE4peCRgnJzfVLK+9RxA5P9FS6GqMqfuZv78 sWDNKqVJqPeWWQCauATjKT4q0ZlHM0PYVyO0JFXfDwk9hLCoB+QOG9XKncu2kGfEHaFf 848aUPFnkqR4zzUq7Rhm4Jk9SGJCGlrYnbHBXWe+065eWwWe7zjR5vzmzixGDP9GynHK 8TokbuFMkyGkCxsrKq927pwBGqPVTAa/5iKLCqO98kYHLfRdNh+S9t1RwZNcNwqKsyum dxfpTDWHYfyxTyHpkTnkNpMfP+WCBl3DDFrB4C8bRaZDPO2MLIIwnawu1ygxoOT85CsZ 2LiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=oIRoSEGJLf8joA0+34Z8WBxAWHJSo0r9QDagd8ox+Nc=; b=SJrIZRCzRtYWJ/Um4dMFuaKO4u+lMdBQsIGNvCfRpqBDdlZ624VeZ8fpeFoIIDvY0Y n38cgi6l6nUrJHKaDSLtaF5dgxBe9bMDulZ1JZNRUYdLk4IV+sfXFanB+/wpe3WwwCEL p4D2uG0JDHObBtcBbqsVME1KaVuoz4PjQlDEAdlCjbf0bjZB1DnOF/VVwnGriPIQDvq8 kIG6tpdlUFwNUmegAqi9oYdpQIyhBLIIy3IoAQzXQXboboKZqfxWNkNfcU0cQnwVVJgx islw8zHIsEH6obZHJ8vLnMhLqAnEHOGIsEMG+jsCxGmOuz7a6XPZGWVVH9WCTjCoWvQM 6LnA== X-Gm-Message-State: AOAM532lLHNxVwFHZ1IHtXvp1GtU6B/J8h6bvC8Sjo3Wh1gzQX9j8RYU H0pJXM1R6mFKP0UOQmHUeeQ= X-Google-Smtp-Source: ABdhPJziRERFUWIPA3cN72AJFivk2FJHGpMa80KMnN1GBZqAqPU3SLoRnHLbIkQ2NQ3W7XSTrN+r4A== X-Received: by 2002:a37:2d05:: with SMTP id t5mr1146929qkh.187.1607187249235; Sat, 05 Dec 2020 08:54:09 -0800 (PST) Received: from localhost ([12.221.2.200]) by smtp.gmail.com with ESMTPSA id c138sm9114777qke.95.2020.12.05.08.54.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Dec 2020 08:54:08 -0800 (PST) From: Yury Norov To: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: [PATCH] arm64: enable GENERIC_FIND_FIRST_BIT Date: Sat, 5 Dec 2020 08:54:06 -0800 Message-Id: <20201205165406.108990-1-yury.norov@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201205_115413_016322_F6F37180 X-CRM114-Status: GOOD ( 12.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yury Norov Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org ARM64 doesn't implement find_first_{zero}_bit in arch code and doesn't enable it in config. It leads to using find_next_bit() which is less efficient: 0000000000000000 : 0: aa0003e4 mov x4, x0 4: aa0103e0 mov x0, x1 8: b4000181 cbz x1, 38 c: f9400083 ldr x3, [x4] 10: d2800802 mov x2, #0x40 // #64 14: 91002084 add x4, x4, #0x8 18: b40000c3 cbz x3, 30 1c: 14000008 b 3c 20: f8408483 ldr x3, [x4], #8 24: 91010045 add x5, x2, #0x40 28: b50000c3 cbnz x3, 40 2c: aa0503e2 mov x2, x5 30: eb02001f cmp x0, x2 34: 54ffff68 b.hi 20 // b.pmore 38: d65f03c0 ret 3c: d2800002 mov x2, #0x0 // #0 40: dac00063 rbit x3, x3 44: dac01063 clz x3, x3 48: 8b020062 add x2, x3, x2 4c: eb02001f cmp x0, x2 50: 9a829000 csel x0, x0, x2, ls // ls = plast 54: d65f03c0 ret ... 0000000000000118 <_find_next_bit.constprop.1>: 118: eb02007f cmp x3, x2 11c: 540002e2 b.cs 178 <_find_next_bit.constprop.1+0x60> // b.hs, b.nlast 120: d346fc66 lsr x6, x3, #6 124: f8667805 ldr x5, [x0, x6, lsl #3] 128: b4000061 cbz x1, 134 <_find_next_bit.constprop.1+0x1c> 12c: f8667826 ldr x6, [x1, x6, lsl #3] 130: 8a0600a5 and x5, x5, x6 134: ca0400a6 eor x6, x5, x4 138: 92800005 mov x5, #0xffffffffffffffff // #-1 13c: 9ac320a5 lsl x5, x5, x3 140: 927ae463 and x3, x3, #0xffffffffffffffc0 144: ea0600a5 ands x5, x5, x6 148: 54000120 b.eq 16c <_find_next_bit.constprop.1+0x54> // b.none 14c: 1400000e b 184 <_find_next_bit.constprop.1+0x6c> 150: d346fc66 lsr x6, x3, #6 154: f8667805 ldr x5, [x0, x6, lsl #3] 158: b4000061 cbz x1, 164 <_find_next_bit.constprop.1+0x4c> 15c: f8667826 ldr x6, [x1, x6, lsl #3] 160: 8a0600a5 and x5, x5, x6 164: eb05009f cmp x4, x5 168: 540000c1 b.ne 180 <_find_next_bit.constprop.1+0x68> // b.any 16c: 91010063 add x3, x3, #0x40 170: eb03005f cmp x2, x3 174: 54fffee8 b.hi 150 <_find_next_bit.constprop.1+0x38> // b.pmore 178: aa0203e0 mov x0, x2 17c: d65f03c0 ret 180: ca050085 eor x5, x4, x5 184: dac000a5 rbit x5, x5 188: dac010a5 clz x5, x5 18c: 8b0300a3 add x3, x5, x3 190: eb03005f cmp x2, x3 194: 9a839042 csel x2, x2, x3, ls // ls = plast 198: aa0203e0 mov x0, x2 19c: d65f03c0 ret ... 0000000000000238 : 238: a9bf7bfd stp x29, x30, [sp, #-16]! 23c: aa0203e3 mov x3, x2 240: d2800004 mov x4, #0x0 // #0 244: aa0103e2 mov x2, x1 248: 910003fd mov x29, sp 24c: d2800001 mov x1, #0x0 // #0 250: 97ffffb2 bl 118 <_find_next_bit.constprop.1> 254: a8c17bfd ldp x29, x30, [sp], #16 258: d65f03c0 ret Enabling this functions would also benefit for_each_{set,clear}_bit(). Would it make sense to enable this config for all such architectures by default? Signed-off-by: Yury Norov Tested-by: Alexey Klimov --- arch/arm64/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 1515f6f153a0..2b90ef1f548e 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -106,6 +106,7 @@ config ARM64 select GENERIC_CPU_AUTOPROBE select GENERIC_CPU_VULNERABILITIES select GENERIC_EARLY_IOREMAP + select GENERIC_FIND_FIRST_BIT select GENERIC_IDLE_POLL_SETUP select GENERIC_IRQ_IPI select GENERIC_IRQ_MULTI_HANDLER