From patchwork Tue Dec 8 21:09:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bean Huo X-Patchwork-Id: 11959749 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F1B0C4167B for ; Tue, 8 Dec 2020 21:10:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03F31207AA for ; Tue, 8 Dec 2020 21:10:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729746AbgLHVKg (ORCPT ); Tue, 8 Dec 2020 16:10:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725766AbgLHVKd (ORCPT ); Tue, 8 Dec 2020 16:10:33 -0500 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 229A3C061793; Tue, 8 Dec 2020 13:09:53 -0800 (PST) Received: by mail-ej1-x641.google.com with SMTP id ce23so22887887ejb.8; Tue, 08 Dec 2020 13:09:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PpklWkjP2Yw3YF1XNWucRpoNoqCpa0K9B8TluzWP6kw=; b=vIJZ0cQSFNSacfHYzYf5aOaonEIdnV5EOQMb/rf8tH0qbF4UfKZBPl8akgutJ1E3om WwNu79rkQHYZgvJRh2tTHRB9HZb7B1wKFfhAKi9sWZDy8wCah4jN4XrLzFwH4QdM6ANY P/4b+Np+HI1eScDid+kEZogZ8hRt7VDjyI+I1l0HdRMzGxaXEEyjuFlYiEBsL4v4vcDm V9Ij261LIiZMf/BeelQs3R4pICzO2lase7xzYyK54Ax1sc6B04M4ohF1bZTVnioXaJ9Z ILHDkivPsA49owRLGAwia3q7pmORuIIfM2g1OIiHag8kwOMWcwEZ6Rk0CPVC3GB8kyBS dr4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PpklWkjP2Yw3YF1XNWucRpoNoqCpa0K9B8TluzWP6kw=; b=Ra01vr5YJyPZZv9Aob+r2X/6L9Q5N2kemKt2LCXx/yFkLathNgf19EKwlfKgW//zXi 24Kwcsj3RaYRhD7aIDCs90DnaXGA/rXA1zawMwcgAvoGJW+8CSXzqOtyf4w5aKTncWRN P+/7jYNmYscRzmHd8a0pJkO3zSO9Oo0DeWDQVfR032m8hZ6t7arlHj18/eVmisK5YkRU iah5R70emqzt7Elb4mg/b7FF9IQGXZPXVmRSF574c/DwwS3vvZIP0jKQ/c9uKAaVxXfF WeiNF/E0p/iGtKr5+GThMeLEqyVNeOSSbuuAEIiCsZ+XD7vE9DtBGD4qushIkp8a2ZTB AjoA== X-Gm-Message-State: AOAM5303DV5PqlRAkSYzdDYmeBufN9H3Mv7DQikR83IGUBsvPcJ0/ZrF gi001BsmdcLXI9iFOfHWeiQ= X-Google-Smtp-Source: ABdhPJzmYgytETHjFbjU1qsk8rP7ytzqAh3acRvtyl4TNYVc+gy7OtcNh5Kp1Ypg5yB+mMHNdciM9g== X-Received: by 2002:a17:906:3a55:: with SMTP id a21mr25104244ejf.516.1607461791875; Tue, 08 Dec 2020 13:09:51 -0800 (PST) Received: from localhost.localdomain (ip5f5bfce9.dynamic.kabel-deutschland.de. [95.91.252.233]) by smtp.gmail.com with ESMTPSA id n22sm17908edr.11.2020.12.08.13.09.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 13:09:51 -0800 (PST) From: Bean Huo To: alim.akhtar@samsung.com, avri.altman@wdc.com, asutoshd@codeaurora.org, jejb@linux.ibm.com, martin.petersen@oracle.com, stanley.chu@mediatek.com, beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com, cang@codeaurora.org Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/3] scsi: ufs: Add "wb_on" sysfs node to control WB on/off Date: Tue, 8 Dec 2020 22:09:39 +0100 Message-Id: <20201208210941.2177-2-huobean@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201208210941.2177-1-huobean@gmail.com> References: <20201208210941.2177-1-huobean@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org From: Bean Huo Currently UFS WriteBooster driver uses clock scaling up/down to set WB on/off, for the platform which doesn't support UFSHCD_CAP_CLK_SCALING, WB will be always on. Provide a sysfs attribute to enable/disable WB during runtime. Write 1/0 to "wb_on" sysfs node to enable/disable UFS WB. Reviewed-by: Avri Altman Reviewed-by: Stanley Chu Signed-off-by: Bean Huo --- drivers/scsi/ufs/ufs-sysfs.c | 41 ++++++++++++++++++++++++++++++++++++ drivers/scsi/ufs/ufshcd.c | 3 +-- drivers/scsi/ufs/ufshcd.h | 2 ++ 3 files changed, 44 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/ufs/ufs-sysfs.c b/drivers/scsi/ufs/ufs-sysfs.c index 08e72b7eef6a..2b4e9fe935cc 100644 --- a/drivers/scsi/ufs/ufs-sysfs.c +++ b/drivers/scsi/ufs/ufs-sysfs.c @@ -189,6 +189,45 @@ static ssize_t auto_hibern8_store(struct device *dev, return count; } +static ssize_t wb_on_show(struct device *dev, struct device_attribute *attr, + char *buf) +{ + struct ufs_hba *hba = dev_get_drvdata(dev); + + return scnprintf(buf, PAGE_SIZE, "%d\n", hba->wb_enabled); +} + +static ssize_t wb_on_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t count) +{ + struct ufs_hba *hba = dev_get_drvdata(dev); + unsigned int wb_enable; + ssize_t res; + + if (ufshcd_is_clkscaling_supported(hba)) { + /* + * If the platform supports UFSHCD_CAP_AUTO_BKOPS_SUSPEND, + * turn WB on/off will be done while clock scaling up/down. + */ + dev_warn(dev, "To control WB through wb_on is not allowed!\n"); + return -EOPNOTSUPP; + } + if (!ufshcd_is_wb_allowed(hba)) + return -EOPNOTSUPP; + + if (kstrtouint(buf, 0, &wb_enable)) + return -EINVAL; + + if (wb_enable != 0 && wb_enable != 1) + return -EINVAL; + + pm_runtime_get_sync(hba->dev); + res = ufshcd_wb_ctrl(hba, wb_enable); + pm_runtime_put_sync(hba->dev); + + return res < 0 ? res : count; +} + static DEVICE_ATTR_RW(rpm_lvl); static DEVICE_ATTR_RO(rpm_target_dev_state); static DEVICE_ATTR_RO(rpm_target_link_state); @@ -196,6 +235,7 @@ static DEVICE_ATTR_RW(spm_lvl); static DEVICE_ATTR_RO(spm_target_dev_state); static DEVICE_ATTR_RO(spm_target_link_state); static DEVICE_ATTR_RW(auto_hibern8); +static DEVICE_ATTR_RW(wb_on); static struct attribute *ufs_sysfs_ufshcd_attrs[] = { &dev_attr_rpm_lvl.attr, @@ -205,6 +245,7 @@ static struct attribute *ufs_sysfs_ufshcd_attrs[] = { &dev_attr_spm_target_dev_state.attr, &dev_attr_spm_target_link_state.attr, &dev_attr_auto_hibern8.attr, + &dev_attr_wb_on.attr, NULL }; diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 11a4aad09f3a..f9fefb6c7ddb 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -245,7 +245,6 @@ static inline int ufshcd_config_vreg_hpm(struct ufs_hba *hba, static int ufshcd_try_to_abort_task(struct ufs_hba *hba, int tag); static int ufshcd_wb_buf_flush_enable(struct ufs_hba *hba); static int ufshcd_wb_buf_flush_disable(struct ufs_hba *hba); -static int ufshcd_wb_ctrl(struct ufs_hba *hba, bool enable); static int ufshcd_wb_toggle_flush_during_h8(struct ufs_hba *hba, bool set); static inline void ufshcd_wb_toggle_flush(struct ufs_hba *hba, bool enable); static void ufshcd_hba_vreg_set_lpm(struct ufs_hba *hba); @@ -5303,7 +5302,7 @@ static void ufshcd_bkops_exception_event_handler(struct ufs_hba *hba) __func__, err); } -static int ufshcd_wb_ctrl(struct ufs_hba *hba, bool enable) +int ufshcd_wb_ctrl(struct ufs_hba *hba, bool enable) { int ret; u8 index; diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h index 7a7e056a33a9..ea19d6c77faf 100644 --- a/drivers/scsi/ufs/ufshcd.h +++ b/drivers/scsi/ufs/ufshcd.h @@ -1073,6 +1073,8 @@ int ufshcd_exec_raw_upiu_cmd(struct ufs_hba *hba, u8 *desc_buff, int *buff_len, enum query_opcode desc_op); +int ufshcd_wb_ctrl(struct ufs_hba *hba, bool enable); + /* Wrapper functions for safely calling variant operations */ static inline const char *ufshcd_get_var_name(struct ufs_hba *hba) { From patchwork Tue Dec 8 21:09:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bean Huo X-Patchwork-Id: 11959747 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13AD3C433FE for ; Tue, 8 Dec 2020 21:10:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E098B23B1A for ; Tue, 8 Dec 2020 21:10:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729733AbgLHVKg (ORCPT ); Tue, 8 Dec 2020 16:10:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728551AbgLHVKe (ORCPT ); Tue, 8 Dec 2020 16:10:34 -0500 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27490C061794; Tue, 8 Dec 2020 13:09:54 -0800 (PST) Received: by mail-ej1-x641.google.com with SMTP id ga15so26665183ejb.4; Tue, 08 Dec 2020 13:09:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=yxa79y+dWlbM9PnngE1WxJbURfn2atLQazPtCccKi84=; b=taeT/fjNy+0QXQqkqdjvSGD26ZejL2QQJihlf8T+oUzs6wCqd1MtnM7f72eQk5HJb8 E1TwPFcFnyysMSj1lWSF4GkyhVjNMlc3yTwLLvdizTGcUKDiCBiY84SSd4Ef1hEDlgKn LMiJdSiIJ+qci8JqqVUI19uVfDm9HO+aZBpnw/W1/jMJ2npYtbHT1WY29irl/CIF06aX kHzStvX55wGJbg6sUgYaUvL+uy37Zm5askIJpLoO6cX6JQ4gXcvBN+eFgcqAq7m3oyvZ iA5eagMpUtKyNYDw/hbk7U45d0+I0/IIEQ289hYKS5V3I2m6aP8KT48l0Z88wPxmebsT xEFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yxa79y+dWlbM9PnngE1WxJbURfn2atLQazPtCccKi84=; b=O21Qe2W5u4MMb96rCY4R/R1wUyr6QGmV5LX6/LsFfldc5eQ6r3h29hTmWZordmA6nx 6RMMacU2OeKb8oNe62yhI4/4eFNO+dfGZ61HBVt5ugX0JAJ8JmIuUZDR89t7cUZCnMGx WrFIHKHRYLxlUQWv9Oc72k5I4K1yKD572yRwhSDwhOa6dBEBPDVhYM86TAIzzcmNFUAI oF96JDK85ydpoB6Wx8OpipaPFzU7M2i9pfMigQ5PwDcP1J5yA8VUBX7xSFf+fAGrvCl1 EnSF5O+TRJyPw01lQ3fMO8eKqnZQFsLFbTVBaDH18RQS7vsOqGsXhpGa0oFBd+FutpwE CqIw== X-Gm-Message-State: AOAM531RnWMSp19dieY4K+jlpuVDm8vGZ76yy8co0Ge+8G07dlLKpfWp jW7CHdLUCRsXpVzMkBpFDaM= X-Google-Smtp-Source: ABdhPJwROkqzPhQM+uQq1OVxMOuajT6R9Gl2i78m1q4iDt2csUFF2BeD/PApEURBDeFaGqUXmrDoGw== X-Received: by 2002:a17:906:94c5:: with SMTP id d5mr24179757ejy.427.1607461792899; Tue, 08 Dec 2020 13:09:52 -0800 (PST) Received: from localhost.localdomain (ip5f5bfce9.dynamic.kabel-deutschland.de. [95.91.252.233]) by smtp.gmail.com with ESMTPSA id n22sm17908edr.11.2020.12.08.13.09.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 13:09:52 -0800 (PST) From: Bean Huo To: alim.akhtar@samsung.com, avri.altman@wdc.com, asutoshd@codeaurora.org, jejb@linux.ibm.com, martin.petersen@oracle.com, stanley.chu@mediatek.com, beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com, cang@codeaurora.org Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/3] scsi: ufs: Keep device active mode only fWriteBoosterBufferFlushDuringHibernate == 1 Date: Tue, 8 Dec 2020 22:09:40 +0100 Message-Id: <20201208210941.2177-3-huobean@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201208210941.2177-1-huobean@gmail.com> References: <20201208210941.2177-1-huobean@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org From: Bean Huo According to the JEDEC UFS 3.1 Spec, If fWriteBoosterBufferFlushDuringHibernate is set to one, the device flushes the WriteBooster Buffer data automatically whenever the link enters the hibernate (HIBERN8) state. While the flushing operation is in progress, the device should be kept in Active power mode. Currently, we set this flag during the UFSHCD probe stage, but we didn't deal with its programming failure. Even this failure is less likely to occur, but still it is possible. This patch is to add checkup of fWriteBoosterBufferFlushDuringHibernate setting, keep the device as "active power mode" only when this flag be successfully set to 1. Fixes: 51dd905bd2f6 ("scsi: ufs: Fix WriteBooster flush during runtime suspend") Signed-off-by: Bean Huo --- drivers/scsi/ufs/ufs.h | 2 ++ drivers/scsi/ufs/ufshcd.c | 20 +++++++++++++++----- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h index d593edb48767..311d5f7a024d 100644 --- a/drivers/scsi/ufs/ufs.h +++ b/drivers/scsi/ufs/ufs.h @@ -530,6 +530,8 @@ struct ufs_dev_info { bool f_power_on_wp_en; /* Keeps information if any of the LU is power on write protected */ bool is_lu_power_on_wp; + /* Indicates if flush WB buffer during hibern8 successfully enabled */ + bool is_hibern8_wb_flush; /* Maximum number of general LU supported by the UFS device */ u8 max_lu_supported; u8 wb_dedicated_lu; diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index f9fefb6c7ddb..f3ba46c48383 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -283,10 +283,16 @@ static inline void ufshcd_wb_config(struct ufs_hba *hba) dev_err(hba->dev, "%s: Enable WB failed: %d\n", __func__, ret); else dev_info(hba->dev, "%s: Write Booster Configured\n", __func__); + ret = ufshcd_wb_toggle_flush_during_h8(hba, true); - if (ret) + if (ret) { dev_err(hba->dev, "%s: En WB flush during H8: failed: %d\n", __func__, ret); + hba->dev_info.is_hibern8_wb_flush = false; + } else { + hba->dev_info.is_hibern8_wb_flush = true; + } + ufshcd_wb_toggle_flush(hba, true); } @@ -5444,6 +5450,7 @@ static bool ufshcd_wb_need_flush(struct ufs_hba *hba) if (!ufshcd_is_wb_allowed(hba)) return false; + /* * The ufs device needs the vcc to be ON to flush. * With user-space reduction enabled, it's enough to enable flush @@ -8535,6 +8542,7 @@ static int ufshcd_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op) enum ufs_pm_level pm_lvl; enum ufs_dev_pwr_mode req_dev_pwr_mode; enum uic_link_state req_link_state; + bool hibern8; hba->pm_op_in_progress = 1; if (!ufshcd_is_shutdown_pm(pm_op)) { @@ -8594,11 +8602,13 @@ static int ufshcd_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op) * Hibern8, keep device power mode as "active power mode" * and VCC supply. */ + hibern8 = req_link_state == UIC_LINK_HIBERN8_STATE || + (req_link_state == UIC_LINK_ACTIVE_STATE && + ufshcd_is_auto_hibern8_enabled(hba)); + hba->dev_info.b_rpm_dev_flush_capable = - hba->auto_bkops_enabled || - (((req_link_state == UIC_LINK_HIBERN8_STATE) || - ((req_link_state == UIC_LINK_ACTIVE_STATE) && - ufshcd_is_auto_hibern8_enabled(hba))) && + hba->auto_bkops_enabled || (hibern8 && + hba->dev_info.is_hibern8_wb_flush && ufshcd_wb_need_flush(hba)); } From patchwork Tue Dec 8 21:09:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bean Huo X-Patchwork-Id: 11959753 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE118C4167B for ; Tue, 8 Dec 2020 21:11:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A642023B1A for ; Tue, 8 Dec 2020 21:11:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729671AbgLHVKg (ORCPT ); Tue, 8 Dec 2020 16:10:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729308AbgLHVKf (ORCPT ); Tue, 8 Dec 2020 16:10:35 -0500 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 304E3C06179C; Tue, 8 Dec 2020 13:09:55 -0800 (PST) Received: by mail-ej1-x644.google.com with SMTP id lt17so26715047ejb.3; Tue, 08 Dec 2020 13:09:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pcUFeGN1uwzpyJXiBF01tsjkIE/O4GFCTJ/pyCmdmBU=; b=QIHsxzx6gd3fFLf1zUHC6i3YFsw4z7RdrhdaLFyeEJBDe4e+XqhkZnyMoHL7iVe17v RhBzzd4VpQyRi4uO7MdaUlCrW5djq6MvQx+BHf1BWXC3pyjtpSYIy6KzkuYLQgljszdO hp42xJ2m42tBXR05FVz++pQExVQOufK8o7Z6vn5DmDrwCqmx+LI6DVqPv32fZTN9f8MJ Vq8QssCLFTqttTQi0vQFtCP49gKd/W0zDDRYLRf39HiEKHAR4GpqDzRo3yEtKdyTYrt6 oY0UAN4nJvLp2MwJY8Ob55Nks31Sdxts/bhMtqmSvCX+ozN31L45BuJ/b0zQiORe/HDk BN7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pcUFeGN1uwzpyJXiBF01tsjkIE/O4GFCTJ/pyCmdmBU=; b=OPoM6q7ur8wuKrl1cDFdz+1TEqDrRP1Yy3wARly7SNiYD8A79aT+g7UPgaFF5/D3m9 PkPjJXa87w1HfGX4PJIvZnqlleWR+SbY/tCHtc0gg56/qrlCNh7A09sjk9QHgRFjYbzC U1jSV2439fMnDE43RltZcifYU/MNGGGF0HnHfFBRUI/uNAw0kK7jgg5M1KuRFgjwln1z NGcNIbr1C5xgCRzMlCVNvYb/OE3IV2zgzNV0vGlzTdwHz+06L5rAMzN65LuurQJUQ2VB VPy89ESVgHMod1WBA5SMXcl9d3J+olpdyUjM/dq9r3AfQocvmtuNmt0dw+7bqkLiUnHM kM4A== X-Gm-Message-State: AOAM530W304NZ2zsNgXqPUhIQdhwP1DvGdBNB4TiXxquFPNar1bEZi1k vuKzowp31StD/KgHh1w0eKM= X-Google-Smtp-Source: ABdhPJyjzP5NFJy3eu7Vc0AjmAczfmBkCADjF9lFg/pGiZEoLKxkC7/UjFEbyFl6SMPPHoMdUyxs4g== X-Received: by 2002:a17:906:d62:: with SMTP id s2mr5548458ejh.61.1607461793933; Tue, 08 Dec 2020 13:09:53 -0800 (PST) Received: from localhost.localdomain (ip5f5bfce9.dynamic.kabel-deutschland.de. [95.91.252.233]) by smtp.gmail.com with ESMTPSA id n22sm17908edr.11.2020.12.08.13.09.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 13:09:53 -0800 (PST) From: Bean Huo To: alim.akhtar@samsung.com, avri.altman@wdc.com, asutoshd@codeaurora.org, jejb@linux.ibm.com, martin.petersen@oracle.com, stanley.chu@mediatek.com, beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com, cang@codeaurora.org Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 3/3] scsi: ufs: Changes comment in the function ufshcd_wb_probe() Date: Tue, 8 Dec 2020 22:09:41 +0100 Message-Id: <20201208210941.2177-4-huobean@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201208210941.2177-1-huobean@gmail.com> References: <20201208210941.2177-1-huobean@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org From: Bean Huo USFHCD supports WriteBooster "LU dedicated buffer” mode and “shared buffer” mode both, so changes the comment in the function ufshcd_wb_probe(). Signed-off-by: Bean Huo Reviewed-by: Can Guo Reviewed-by: Stanley Chu --- drivers/scsi/ufs/ufshcd.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index f3ba46c48383..75ea74748bc6 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -7167,10 +7167,9 @@ static void ufshcd_wb_probe(struct ufs_hba *hba, u8 *desc_buf) goto wb_disabled; /* - * WB may be supported but not configured while provisioning. - * The spec says, in dedicated wb buffer mode, - * a max of 1 lun would have wb buffer configured. - * Now only shared buffer mode is supported. + * WB may be supported but not configured while provisioning. The spec + * says, in dedicated wb buffer mode, a max of 1 lun would have wb + * buffer configured. */ dev_info->b_wb_buffer_type = desc_buf[DEVICE_DESC_PARAM_WB_TYPE];