From patchwork Wed Dec 9 12:51:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Georgi Djakov X-Patchwork-Id: 11961267 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C9B8C433FE for ; Wed, 9 Dec 2020 12:51:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F3378238A0 for ; Wed, 9 Dec 2020 12:51:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3378238A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8AA706B00D0; Wed, 9 Dec 2020 07:51:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 85BDD6B00D1; Wed, 9 Dec 2020 07:51:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7244A6B00D3; Wed, 9 Dec 2020 07:51:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0143.hostedemail.com [216.40.44.143]) by kanga.kvack.org (Postfix) with ESMTP id 524206B00D0 for ; Wed, 9 Dec 2020 07:51:57 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 179DD1EF2 for ; Wed, 9 Dec 2020 12:51:57 +0000 (UTC) X-FDA: 77573731074.06.grass71_53094ec273ef Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id EFD0F1004691B for ; Wed, 9 Dec 2020 12:51:56 +0000 (UTC) X-HE-Tag: grass71_53094ec273ef X-Filterd-Recvd-Size: 7565 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Wed, 9 Dec 2020 12:51:56 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id k10so1380631wmi.3 for ; Wed, 09 Dec 2020 04:51:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=t3b+hYd92c2/h1jvJK/jdhfNTZJqrtzVMndWrwAcWaU=; b=LLV0B9jIT+l3TZUaw3h4ien5tjsB2Q8QWFj00m+fHTuXF7GLxlIPzH+YFxCi/8bHBz vd3VgMn0j7kxDTSUkM14sWNfVkCU548pXXl0LnxiXhhzglEJIK6XwDeW9mOtzubRgAMQ j5wV5HNMLLpzIZQZhNBjWJVr4HTHMw2g91U25nzlgYjVwNgWLAlNLCv5jQIjgFCRODdv JYtDLp954bJHL21T7ywrMr1GPlTNdDfp0RiLgxSRQBh6CW8oD2lAHSTwt8HMDVLk9XL9 FGINZ13YfRs5K5NG8PFIUepsdCWqYd0NlZb7DP29xFcr7n2sRqcBlbHSiA5Wp/flLg8c 28IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=t3b+hYd92c2/h1jvJK/jdhfNTZJqrtzVMndWrwAcWaU=; b=bXtLSZvaWWwKPWQzvegoVIHmI0KOFkdZncmPtgxCTKJSIzm6qOalvpAAdhNBUtjh3p XeWW1EFe5NhIFMEfq75t2Mtoxc6dMOuZTuyBPlqrUrP3BlIi4S0MvEAr5NVxd/WIM52p V1DPNpR36OlkrkJsuA91YsXYXmBH8b3qJHsMedMN8Nuw4WKFkcW7QlStn8mT8MnZR0oH iRttPzZgwhb5fSquyWpo7LogqSxLWAWxz6JazqwAkdeyZ8Q+6wsIGW7Vgoe/ojgJoPyN P9/9EFsQwCq3W7wyQ8+B8Dfola4/oVPA8yac8Y6vihzjbNoH4GIg4hxrLj5hCU+RzTWI pv1g== X-Gm-Message-State: AOAM531QbF34c5mrIJwOCfmft7rgfsBRW66CyFYUka4LtKskd8UidXAD Zo/5XBy6ldlKWLwlekh0s0rC5w== X-Google-Smtp-Source: ABdhPJzszTCHPo9N5/2hsfso3ic0KtpeDs7QEBxKMw3n132ewsgTiRxkQ5pZuvPdDVsxG2Fy29Gnwg== X-Received: by 2002:a1c:b608:: with SMTP id g8mr2661594wmf.110.1607518315269; Wed, 09 Dec 2020 04:51:55 -0800 (PST) Received: from localhost.localdomain ([212.45.67.2]) by smtp.googlemail.com with ESMTPSA id k7sm3780754wrn.63.2020.12.09.04.51.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Dec 2020 04:51:54 -0800 (PST) From: Georgi Djakov To: akpm@linux-foundation.org, linux-mm@kvack.org Cc: vbabka@suse.cz, corbet@lwn.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, lmark@codeaurora.org, georgi.djakov@linaro.org Subject: [PATCH v2] mm/page_owner: Record timestamp and pid Date: Wed, 9 Dec 2020 14:51:53 +0200 Message-Id: <20201209125153.10533-1-georgi.djakov@linaro.org> X-Mailer: git-send-email 2.29.0 MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Liam Mark Collect the time for each allocation recorded in page owner so that allocation "surges" can be measured. Record the pid for each allocation recorded in page owner so that the source of allocation "surges" can be better identified. The above is very useful when doing memory analysis. On a crash for example, we can get this information from kdump (or ramdump) and parse it to figure out memory allocation problems. Please note that on x86_64 this increases the size of struct page_owner from 16 bytes to 32. Signed-off-by: Liam Mark Signed-off-by: Georgi Djakov Acked-by: Vlastimil Babka --- v2: - Improve the commit message (Andrew and Vlastimil) - Update page_owner.rst with more recent object size information (Andrew) - Use pid_t for the pid (Andrew) - Print the info also in __dump_page_owner() (Vlastimil) v1: https://lore.kernel.org/r/20201112184106.733-1-georgi.djakov@linaro.org/ Documentation/vm/page_owner.rst | 12 ++++++------ mm/page_owner.c | 17 +++++++++++++---- 2 files changed, 19 insertions(+), 10 deletions(-) diff --git a/Documentation/vm/page_owner.rst b/Documentation/vm/page_owner.rst index 02deac76673f..cf7c0c361621 100644 --- a/Documentation/vm/page_owner.rst +++ b/Documentation/vm/page_owner.rst @@ -41,17 +41,17 @@ size change due to this facility. - Without page owner:: text data bss dec hex filename - 40662 1493 644 42799 a72f mm/page_alloc.o + 48392 2333 644 51369 c8a9 mm/page_alloc.o - With page owner:: text data bss dec hex filename - 40892 1493 644 43029 a815 mm/page_alloc.o - 1427 24 8 1459 5b3 mm/page_ext.o - 2722 50 0 2772 ad4 mm/page_owner.o + 48800 2445 644 51889 cab1 mm/page_alloc.o + 6574 108 29 6711 1a37 mm/page_owner.o + 1025 8 8 1041 411 mm/page_ext.o -Although, roughly, 4 KB code is added in total, page_alloc.o increase by -230 bytes and only half of it is in hotpath. Building the kernel with +Although, roughly, 8 KB code is added in total, page_alloc.o increase by +520 bytes and less than half of it is in hotpath. Building the kernel with page owner and turning it on if needed would be great option to debug kernel memory problem. diff --git a/mm/page_owner.c b/mm/page_owner.c index b735a8eafcdb..af464bb7fbe7 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -10,6 +10,7 @@ #include #include #include +#include #include "internal.h" @@ -25,6 +26,8 @@ struct page_owner { gfp_t gfp_mask; depot_stack_handle_t handle; depot_stack_handle_t free_handle; + u64 ts_nsec; + pid_t pid; }; static bool page_owner_enabled = false; @@ -172,6 +175,8 @@ static inline void __set_page_owner_handle(struct page *page, page_owner->order = order; page_owner->gfp_mask = gfp_mask; page_owner->last_migrate_reason = -1; + page_owner->pid = current->pid; + page_owner->ts_nsec = local_clock(); __set_bit(PAGE_EXT_OWNER, &page_ext->flags); __set_bit(PAGE_EXT_OWNER_ALLOCATED, &page_ext->flags); @@ -236,6 +241,8 @@ void __copy_page_owner(struct page *oldpage, struct page *newpage) new_page_owner->last_migrate_reason = old_page_owner->last_migrate_reason; new_page_owner->handle = old_page_owner->handle; + new_page_owner->pid = old_page_owner->pid; + new_page_owner->ts_nsec = old_page_owner->ts_nsec; /* * We don't clear the bit on the oldpage as it's going to be freed @@ -349,9 +356,10 @@ print_page_owner(char __user *buf, size_t count, unsigned long pfn, return -ENOMEM; ret = snprintf(kbuf, count, - "Page allocated via order %u, mask %#x(%pGg)\n", + "Page allocated via order %u, mask %#x(%pGg), pid %d, ts %llu ns\n", page_owner->order, page_owner->gfp_mask, - &page_owner->gfp_mask); + &page_owner->gfp_mask, page_owner->pid, + page_owner->ts_nsec); if (ret >= count) goto err; @@ -427,8 +435,9 @@ void __dump_page_owner(struct page *page) else pr_alert("page_owner tracks the page as freed\n"); - pr_alert("page last allocated via order %u, migratetype %s, gfp_mask %#x(%pGg)\n", - page_owner->order, migratetype_names[mt], gfp_mask, &gfp_mask); + pr_alert("page last allocated via order %u, migratetype %s, gfp_mask %#x(%pGg), pid %d, ts %llu\n", + page_owner->order, migratetype_names[mt], gfp_mask, &gfp_mask, + page_owner->pid, page_owner->ts_nsec); handle = READ_ONCE(page_owner->handle); if (!handle) {