From patchwork Tue Dec 15 05:34:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 11974033 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFB21C4361B for ; Tue, 15 Dec 2020 05:36:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A88D72229C for ; Tue, 15 Dec 2020 05:36:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A88D72229C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=bYJtBAM7XFqiviQC21Cc7ID1W7a9tlMVhfX7nzo7MPM=; b=wjdFBEssLWAQ9JNLumwQfRi9wl Hd8JYDWJ3ruEQ4EWet2W7R+kS550QNaYVN9uXflebjkHkdvJNjUtG5fLhZeGDYgCmdwfWnEz4VKr+ kr6tOaSuZNm3s9ljSx6UjQrcsoJ62Drc70MCXosDkIlIFtUn1F8+ya4pEWBADVFpejksuwB62eLf5 h1kK9mJgfX/bwnlxr1Y/UjYGjHXHLNOFDel+ZE64PV0dEPZf6HBN7bkDV+bftM7ghNU/1mFwoPyIJ yJ3cB6rszlkQf/EBCU1np6EcqVwixICOu5HAl3+QVC14HewZr8pOW4YrHZxsUlVIWrCSB+rHoYb5i SIsAQ8/w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp2yl-0005rt-S0; Tue, 15 Dec 2020 05:34:31 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp2yi-0005rE-1a for linux-arm-kernel@lists.infradead.org; Tue, 15 Dec 2020 05:34:29 +0000 Received: by mail-pl1-x644.google.com with SMTP id r4so10359102pls.11 for ; Mon, 14 Dec 2020 21:34:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wcFcGYpvBy6tnBdPjWwdyiQjWcBUe6C5DCH1A2Cba4E=; b=NBE0rtLi/ltbqXo56JM6EWTuLmeSbxa4lmf8EspxvTDjPj9NIzdDjd+2I9OJJRKdFU svttQRs/nH84xvWccKeKVAqpzF1G96MyoH6HQ7/Oj8md2llvsIMI+wYDMPPGcgL3QuAF wu9RtWN6ghHA2IBIostWyvOPTzmlF04OaAodzYhbwpDexfk/Hw6ve9z+UiXdUDm5Ope9 cDGP4kwpDWniu1GY9hf4QXVHTw81K68TgUr/rKuf1g4ThCsnipeS6AsIHhqCJhUjh6BA uv1lp591T8OIPxvlyGhRTMwZHG0zS/KREq5S/IQxXN78UsdU3YvNaOrEEL8XwAYzLwzJ Wj+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wcFcGYpvBy6tnBdPjWwdyiQjWcBUe6C5DCH1A2Cba4E=; b=lx7O2mZRIya4FEXOlcwV9GMfzovDatFUTBKDR2CtRZbK0DHP+KuF1fo2JnKypTeiNF xIKTq/TRE6njhUBGXY6Pt+b5lL841ItQCeeLmV2+AcOPoZEqYIMXrEvjZbULUxC7q6pZ 0R1nmJIqMUYv/L32r5u3clTl7WuQUDm5QXvjDXy7R8L+vv1bnO0wU8+papfLC0f+NA08 AWWx6SUZzAR2kkFAXaVJWitW1T3jVfAboiGi4ryMYpCgi3ijbCNmOsw3M3i/OoT4ho9K VyNCzjdsBRKpRRsBQNEXhtjuDPqRM91oJUeK03lTyeU1DDaqnLam1FjcSO0KftIGPx6m 5myw== X-Gm-Message-State: AOAM53057ysg8wPg06mOzRAO4favlQ/5i4mmkOSqU+JeU6MybxL3xKza sZsdFPX0ILrHINOnanRlnNeQkw== X-Google-Smtp-Source: ABdhPJx4r4T2MdTwUyAXuYYXxheqGSt/gbNyj9qbwtRertqW0XA/0EJb0C5m9Kg6dsXyVn7SiLAbwA== X-Received: by 2002:a17:902:b90b:b029:da:97e2:722d with SMTP id bf11-20020a170902b90bb02900da97e2722dmr16686967plb.3.1608010465421; Mon, 14 Dec 2020 21:34:25 -0800 (PST) Received: from localhost ([122.172.20.109]) by smtp.gmail.com with ESMTPSA id d6sm21177494pfo.199.2020.12.14.21.34.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Dec 2020 21:34:24 -0800 (PST) From: Viresh Kumar To: Ionela Voinescu , Catalin Marinas , Will Deacon Subject: [PATCH V3 1/3] arm64: topology: Avoid the have_policy check Date: Tue, 15 Dec 2020 11:04:14 +0530 Message-Id: <5ffc7b9ed03c6301ac2f710f609282959491b526.1608010334.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.25.0.rc1.19.g042ed3e048af MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201215_003428_395524_D92414EF X-CRM114-Status: GOOD ( 19.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Viresh Kumar , Vincent Guittot , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Every time I have stumbled upon this routine, I get confused with the way 'have_policy' is used and I have to dig in to understand why is it so. Here is an attempt to make it easier to understand, and hopefully it is an improvement. The 'have_policy' check was just an optimization to avoid writing to amu_fie_cpus in case we don't have to, but that optimization itself is creating more confusion than the real work. Lets just do that if all the CPUs support AMUs. It is much cleaner that way. Reviewed-by: Ionela Voinescu Signed-off-by: Viresh Kumar --- V3: - Added Reviewed by tag. arch/arm64/kernel/topology.c | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c index f6faa697e83e..ebadc73449f9 100644 --- a/arch/arm64/kernel/topology.c +++ b/arch/arm64/kernel/topology.c @@ -199,14 +199,14 @@ static int freq_inv_set_max_ratio(int cpu, u64 max_rate, u64 ref_rate) return 0; } -static inline bool +static inline void enable_policy_freq_counters(int cpu, cpumask_var_t valid_cpus) { struct cpufreq_policy *policy = cpufreq_cpu_get(cpu); if (!policy) { pr_debug("CPU%d: No cpufreq policy found.\n", cpu); - return false; + return; } if (cpumask_subset(policy->related_cpus, valid_cpus)) @@ -214,8 +214,6 @@ enable_policy_freq_counters(int cpu, cpumask_var_t valid_cpus) amu_fie_cpus); cpufreq_cpu_put(policy); - - return true; } static DEFINE_STATIC_KEY_FALSE(amu_fie_key); @@ -225,7 +223,6 @@ static int __init init_amu_fie(void) { bool invariance_status = topology_scale_freq_invariant(); cpumask_var_t valid_cpus; - bool have_policy = false; int ret = 0; int cpu; @@ -245,17 +242,12 @@ static int __init init_amu_fie(void) continue; cpumask_set_cpu(cpu, valid_cpus); - have_policy |= enable_policy_freq_counters(cpu, valid_cpus); + enable_policy_freq_counters(cpu, valid_cpus); } - /* - * If we are not restricted by cpufreq policies, we only enable - * the use of the AMU feature for FIE if all CPUs support AMU. - * Otherwise, enable_policy_freq_counters has already enabled - * policy cpus. - */ - if (!have_policy && cpumask_equal(valid_cpus, cpu_present_mask)) - cpumask_or(amu_fie_cpus, amu_fie_cpus, valid_cpus); + /* Overwrite amu_fie_cpus if all CPUs support AMU */ + if (cpumask_equal(valid_cpus, cpu_present_mask)) + cpumask_copy(amu_fie_cpus, cpu_present_mask); if (!cpumask_empty(amu_fie_cpus)) { pr_info("CPUs[%*pbl]: counters will be used for FIE.", From patchwork Tue Dec 15 05:34:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 11974035 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4CCDC19425 for ; Tue, 15 Dec 2020 05:36:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85FC32229C for ; Tue, 15 Dec 2020 05:36:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85FC32229C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=x3uXDVUmHuaRC4OPX1Mv8249WHzdsgiaKRjsA2OQack=; b=vcra/30lwgBOPn7iNA4GSPJGF kPFLYDyqiW+WnSB4mMmcNB6NQxyf5xXYcJxVzKPJfK1+cWyJHfRlANLSxRcnqwjP2hrUUB6o5sBDv ar39InZB9cnFCBm0vgPTNQJacN8GNIsmDDIdNubiHabzl/lblUkLAtbWjbu6apTN8Tsi5FDICiDo9 JTweIRaRv2KxDU0PfSKW8nD1Yaebuo2bfj6ArI6rbRlGbDNDpPtWvNNQDielnd66xL4+2QDjZtYOs 1Ur/sEsLbEQkl0mn8nVhNtByox6LJI/AmnpHqTwybfRfxT28ITCODDR2fXJfzVAiLks5cV+BCjX5q 6BEFReB7g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp2yq-0005sc-4p; Tue, 15 Dec 2020 05:34:36 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp2yk-0005rV-JL for linux-arm-kernel@lists.infradead.org; Tue, 15 Dec 2020 05:34:31 +0000 Received: by mail-pj1-x1043.google.com with SMTP id n3so1496112pjm.1 for ; Mon, 14 Dec 2020 21:34:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lgJQB0DZGeyzhCL0iUrGx8mWydeXs5tsx4bv2Z8klnQ=; b=MycjyOgezkR8Zbn91/11XWPtpVKZlNKSu0I3+WAXAIKiVYVnH+6n1Wcdz5BAXn6ovI GWYiThlTjt2dkewgfYxLm1gArJXGb+Il69Bx1brJZQVrJhisHmzo/EiYvDfgCmW6gHkT lc3ux9NZiDS91AInrbBzpNjj6DuiuCqCZgvOnn4xE90ZCZam/EckgdG5vqvbC79rdy+Y iYdTPRHF2w+Xd+yqZfHDmbzi1O0PmRlxvRJCjffM3df5S4rPyqklQzE25+Iy9nFlgDpT qHd7xfO8XKt09vGuYh4YeJE7lwnRkg7sq9PVl8nMXQe+af4vl0BR1lPOvCy0lrzrzHVN zW6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lgJQB0DZGeyzhCL0iUrGx8mWydeXs5tsx4bv2Z8klnQ=; b=ppNRVLLN1YaWAoLvlJaVWUlC+J7moabGvMdOoPWJO9M4FH07T6pCB843W9jCvLrWeH ad8CxIJaSYVBDpU7+KbEi9WBOKWJvBAw27SPBOxltn5bNrIS+g0TdFnwrjDp4vML3vjG XPZwtGyOpZdTVCDmgjmr1pwQvz0RW/IQ5nSn9+cZymT5nIVM2MYe4psvaEcO10J0GOjy mJwOceDF+xCtLOZ6tW3J0/mjcQ6S+rVCRaYYEgJrMciJdPXhBOmjAbPeqY3bVkovpe+e u3SkU/I91N+HbrCEAbSjEC1SR5Z5Rw/i8nZ/SfFiQ9lDEg551ecM/iICR1qbAxOL4KiF j8tA== X-Gm-Message-State: AOAM530FCiqcdVl+dtd1hDPKjgKknb1vgeEU8q7Ru+NIBQFbp6ljlLtN 64bw0o1LPoqtcTYPvAJKxHXVOA== X-Google-Smtp-Source: ABdhPJyn0xBCA0AwIHZzUhyyaq89Ym+SBCQknUnzclvYEEjNa/dnV3CD8q9Jf5M/SaBY26gjy7Ksig== X-Received: by 2002:a17:90b:1886:: with SMTP id mn6mr28569544pjb.31.1608010468750; Mon, 14 Dec 2020 21:34:28 -0800 (PST) Received: from localhost ([122.172.20.109]) by smtp.gmail.com with ESMTPSA id u12sm21037339pfn.88.2020.12.14.21.34.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Dec 2020 21:34:28 -0800 (PST) From: Viresh Kumar To: Ionela Voinescu , Catalin Marinas , Will Deacon Subject: [PATCH V3 2/3] arm64: topology: Reorder init_amu_fie() a bit Date: Tue, 15 Dec 2020 11:04:15 +0530 Message-Id: <87d517c24630494afd9ba5769c2e2b10ee1d3f5d.1608010334.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.25.0.rc1.19.g042ed3e048af In-Reply-To: <5ffc7b9ed03c6301ac2f710f609282959491b526.1608010334.git.viresh.kumar@linaro.org> References: <5ffc7b9ed03c6301ac2f710f609282959491b526.1608010334.git.viresh.kumar@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201215_003430_670114_D7B6C628 X-CRM114-Status: GOOD ( 18.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Viresh Kumar , Vincent Guittot , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This patch does a couple of optimizations in init_amu_fie(), like early exits from paths where we don't need to continue any further, avoid the enable/disable dance, moving the calls to topology_scale_freq_invariant() just when we need them, instead of at the top of the routine, and avoiding calling it for the third time. Signed-off-by: Viresh Kumar Reviewed-by: Ionela Voinescu --- V3: - Skipped the enable/disable dance. - No need to call topology_scale_freq_invariant() multiple times. arch/arm64/kernel/topology.c | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c index ebadc73449f9..57267d694495 100644 --- a/arch/arm64/kernel/topology.c +++ b/arch/arm64/kernel/topology.c @@ -221,8 +221,8 @@ static DEFINE_STATIC_KEY_FALSE(amu_fie_key); static int __init init_amu_fie(void) { - bool invariance_status = topology_scale_freq_invariant(); cpumask_var_t valid_cpus; + bool invariant; int ret = 0; int cpu; @@ -249,18 +249,19 @@ static int __init init_amu_fie(void) if (cpumask_equal(valid_cpus, cpu_present_mask)) cpumask_copy(amu_fie_cpus, cpu_present_mask); - if (!cpumask_empty(amu_fie_cpus)) { - pr_info("CPUs[%*pbl]: counters will be used for FIE.", - cpumask_pr_args(amu_fie_cpus)); - static_branch_enable(&amu_fie_key); - } + if (cpumask_empty(amu_fie_cpus)) + goto free_valid_mask; - /* - * If the system is not fully invariant after AMU init, disable - * partial use of counters for frequency invariance. - */ - if (!topology_scale_freq_invariant()) - static_branch_disable(&amu_fie_key); + invariant = topology_scale_freq_invariant(); + + /* We aren't fully invariant yet */ + if (!invariant && !cpumask_equal(amu_fie_cpus, cpu_present_mask)) + goto free_valid_mask; + + static_branch_enable(&amu_fie_key); + + pr_info("CPUs[%*pbl]: counters will be used for FIE.", + cpumask_pr_args(amu_fie_cpus)); /* * Task scheduler behavior depends on frequency invariance support, @@ -268,7 +269,7 @@ static int __init init_amu_fie(void) * a result of counter initialisation and use, retrigger the build of * scheduling domains to ensure the information is propagated properly. */ - if (invariance_status != topology_scale_freq_invariant()) + if (!invariant) rebuild_sched_domains_energy(); free_valid_mask: From patchwork Tue Dec 15 05:34:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 11974037 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10067C4361B for ; Tue, 15 Dec 2020 05:36:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCFFF2229C for ; Tue, 15 Dec 2020 05:36:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCFFF2229C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gj8DweAkdD3lglN5QmnOtUHAUyN3mQPqL9CPduAc+0k=; b=UdbssTLz9IWsDXymOgOfTgRXQ kLiM+OlHpl7toTUmt5Su/IDc+6yLuUHgb0TVC+GZu7nEwI0rAI/VIE/kDq0RqnKpPbUg5dQrTbj63 ujfJ0dHHRZzVZ9G8XEYLDK4VUZiXTmU2ynQpRjHBzItZGQANXBqxXGKupw/Ruf4OMcZTI0FYrdbBJ gbiWOkgz0yPRzD2O6NQij2D1yhnSDV6liOlGKhg1wVyKK6i2ab1/6UaO5TIlAD9VFQtTerlxjnfoC 61MPu2jAHZRyCrTx4LvDLqq55lONovv1BBltByZ5fvagw4DvcvFVCPuCVuo+Hrb4l1sM2zGD1Olpv 0CvH6ShSA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp2yt-0005sx-NM; Tue, 15 Dec 2020 05:34:40 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp2yo-0005s2-03 for linux-arm-kernel@lists.infradead.org; Tue, 15 Dec 2020 05:34:35 +0000 Received: by mail-pl1-x629.google.com with SMTP id v3so10349121plz.13 for ; Mon, 14 Dec 2020 21:34:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Inc8dinYQAlGT5BgcNFExipWp8kF8aKZc4Rc2pdmTFE=; b=F3W+30NrFnYS6OxRVpnS+92LFlMqyuIbh9uJUupi+IxFLS2veW9RdhalGL98lqI6ra 1X/KaQFt/n6vWSx+jA4aq3UDPQyAl4u1lbX2qQ5kdIjKqYFlbDilQ8yPbaiFkPtQCYO4 r0fwng4GMd0TIizdbGRB4y9UoC1noNoxbtnn3OkO9J+YuqZBXrsjtyZqo91mHaN6+HQ/ YVCp0YYpOTAPaLiy5Ypwa3EBhz9MwqqJPP+P5mNJX2VB2y2Tfzjj65MbYNSLcGS/4ByG Pd8V9R2Jzkuc56Jo3XaVOgZeeyH1i6uusBr5pQ3BKmAZchk8SPfI7o8o3t/pj8QaCwyh DP/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Inc8dinYQAlGT5BgcNFExipWp8kF8aKZc4Rc2pdmTFE=; b=dte5vtr9PmQvl9wlWKhItjYJBy4q+A90TaqCQAllGjrEVlKgs1ZwtB8Xwa+Z8Bfu4L uSacDPcvvxRNxmyA/3hcS4NxxHO80vv9VSUA74oI0oDXC5BAYmxFVWBFNWXZyHHNYmkw Snh+zRQhNq+AR1/M5hnwXoIaFmT1lDaA8xErx8QBwxLZoXBrHpOjIOBx3eSRyzcZz2gX t4Wnfq/knwAcE0yCs3hu2EhuGIz30kenIr7Z3cG3yHiK4WmRjXnnUpAym8XpJmkvpAtW zZYXw4poXDlOtXhEthBP8EAMB3tlyogD3jmqYDZU5JfAxRYKfgZsiyPVeYvC1Fs20DQO 5L0w== X-Gm-Message-State: AOAM531XfqB2UHZ+FbwhElkN3g5qRmXMXFN7QMvqNrnUuspZ5Mxa7M7t qrdj2Qbyi/Ec6RSyLgH7Wu9X2A== X-Google-Smtp-Source: ABdhPJwVjo6+JEYhHW0Dd+3SfomSsbXagYooBEySexBFGqYOe+ZXGwmoVAvstSesdzKx8PaRD0XAow== X-Received: by 2002:a17:90a:a394:: with SMTP id x20mr27698233pjp.24.1608010472084; Mon, 14 Dec 2020 21:34:32 -0800 (PST) Received: from localhost ([122.172.20.109]) by smtp.gmail.com with ESMTPSA id l141sm23656776pfd.124.2020.12.14.21.34.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Dec 2020 21:34:31 -0800 (PST) From: Viresh Kumar To: Ionela Voinescu , Catalin Marinas , Will Deacon Subject: [PATCH V3 3/3] arm64: topology: Make AMUs work with modular cpufreq drivers Date: Tue, 15 Dec 2020 11:04:16 +0530 Message-Id: <8f0fe23d1c9effed71d5660c939472d43726a61b.1608010334.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.25.0.rc1.19.g042ed3e048af In-Reply-To: <5ffc7b9ed03c6301ac2f710f609282959491b526.1608010334.git.viresh.kumar@linaro.org> References: <5ffc7b9ed03c6301ac2f710f609282959491b526.1608010334.git.viresh.kumar@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201215_003434_075912_992ECC4C X-CRM114-Status: GOOD ( 26.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Viresh Kumar , Vincent Guittot , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The AMU counters won't get used today if the cpufreq driver is built as a module as the amu core requires everything to be ready by late init. Fix that properly by registering for cpufreq policy notifier. Note that the amu core don't have any cpufreq dependency after the first time CPUFREQ_CREATE_POLICY notifier is called for all the CPUs. And so we don't need to do anything on the CPUFREQ_REMOVE_POLICY notifier. And for the same reason we check if the CPUs are already parsed in the beginning of amu_fie_setup() and skip if that is true. Alternatively we can shoot a work from there to unregister the notifier instead, but that seemed too much instead of this simple check. Signed-off-by: Viresh Kumar --- V3: - This is a new patch. Ionela, I don't have a way to test the AMU stuff, will it be possible for you to give it a try ? arch/arm64/kernel/topology.c | 88 +++++++++++++++++++----------------- 1 file changed, 46 insertions(+), 42 deletions(-) diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c index 57267d694495..0fc2b32ddb45 100644 --- a/arch/arm64/kernel/topology.c +++ b/arch/arm64/kernel/topology.c @@ -199,64 +199,33 @@ static int freq_inv_set_max_ratio(int cpu, u64 max_rate, u64 ref_rate) return 0; } -static inline void -enable_policy_freq_counters(int cpu, cpumask_var_t valid_cpus) -{ - struct cpufreq_policy *policy = cpufreq_cpu_get(cpu); - - if (!policy) { - pr_debug("CPU%d: No cpufreq policy found.\n", cpu); - return; - } - - if (cpumask_subset(policy->related_cpus, valid_cpus)) - cpumask_or(amu_fie_cpus, policy->related_cpus, - amu_fie_cpus); - - cpufreq_cpu_put(policy); -} - static DEFINE_STATIC_KEY_FALSE(amu_fie_key); #define amu_freq_invariant() static_branch_unlikely(&amu_fie_key) -static int __init init_amu_fie(void) +static void amu_fie_setup(const struct cpumask *cpus) { - cpumask_var_t valid_cpus; bool invariant; - int ret = 0; int cpu; - if (!zalloc_cpumask_var(&valid_cpus, GFP_KERNEL)) - return -ENOMEM; - - if (!zalloc_cpumask_var(&amu_fie_cpus, GFP_KERNEL)) { - ret = -ENOMEM; - goto free_valid_mask; - } + /* We are already set since the last insmod of cpufreq driver */ + if (unlikely(cpumask_subset(cpus, amu_fie_cpus))) + return; - for_each_present_cpu(cpu) { + for_each_cpu(cpu, cpus) { if (!freq_counters_valid(cpu) || freq_inv_set_max_ratio(cpu, cpufreq_get_hw_max_freq(cpu) * 1000, arch_timer_get_rate())) - continue; - - cpumask_set_cpu(cpu, valid_cpus); - enable_policy_freq_counters(cpu, valid_cpus); + return; } - /* Overwrite amu_fie_cpus if all CPUs support AMU */ - if (cpumask_equal(valid_cpus, cpu_present_mask)) - cpumask_copy(amu_fie_cpus, cpu_present_mask); - - if (cpumask_empty(amu_fie_cpus)) - goto free_valid_mask; + cpumask_or(amu_fie_cpus, amu_fie_cpus, cpus); invariant = topology_scale_freq_invariant(); /* We aren't fully invariant yet */ if (!invariant && !cpumask_equal(amu_fie_cpus, cpu_present_mask)) - goto free_valid_mask; + return; static_branch_enable(&amu_fie_key); @@ -271,13 +240,48 @@ static int __init init_amu_fie(void) */ if (!invariant) rebuild_sched_domains_energy(); +} + +static int init_amu_fie_callback(struct notifier_block *nb, unsigned long val, + void *data) +{ + struct cpufreq_policy *policy = data; + + if (val == CPUFREQ_CREATE_POLICY) + amu_fie_setup(policy->related_cpus); + + /* + * We don't need to handle CPUFREQ_REMOVE_POLICY event as the AMU + * counters don't have any dependency on cpufreq driver once we have + * initialized AMU support and enabled invariance. The AMU counters will + * keep on working just fine in the absence of the cpufreq driver, and + * for the CPUs for which there are no counters availalbe, the last set + * value of freq_scale will remain valid as that is the frequency those + * CPUs are running at. + */ + + return 0; +} + +static struct notifier_block init_amu_fie_notifier = { + .notifier_call = init_amu_fie_callback, +}; + +static int __init init_amu_fie(void) +{ + int ret; + + if (!zalloc_cpumask_var(&amu_fie_cpus, GFP_KERNEL)) + return -ENOMEM; -free_valid_mask: - free_cpumask_var(valid_cpus); + ret = cpufreq_register_notifier(&init_amu_fie_notifier, + CPUFREQ_POLICY_NOTIFIER); + if (ret) + free_cpumask_var(amu_fie_cpus); return ret; } -late_initcall_sync(init_amu_fie); +core_initcall(init_amu_fie); bool arch_freq_counters_available(const struct cpumask *cpus) {