From patchwork Thu Jan 14 15:23:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12019899 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63ED9C433E6 for ; Thu, 14 Jan 2021 15:24:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C49E23B28 for ; Thu, 14 Jan 2021 15:24:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726259AbhANPYQ (ORCPT ); Thu, 14 Jan 2021 10:24:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729200AbhANPYP (ORCPT ); Thu, 14 Jan 2021 10:24:15 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D22D9C0613C1 for ; Thu, 14 Jan 2021 07:23:34 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id v15so2507910wrx.4 for ; Thu, 14 Jan 2021 07:23:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cUSIVImOhh6mnD33JdJKn9l+xD1dBbES1ADQWyw/cSQ=; b=xMh/CZ1b26BOHhoxUuGWCrtKccuWrXwsla3Jb8f49NJCwCVpAmALeqJ50oxnz87jRf rkaYJnGrQR7ZclSxlw5FrsfP9lBQEO0PbwDU5Oxl35M3dnTUd7LDyhGEZ1XCzh/snZwC bl9LK/YQkBaLgfdSuTcbXpcFCrBnXrSw5tC1aAwEScghnNgAuNAIlWMKepDjUg4g3m0g xDyOxAPlYWgMIbAzedZzXwavu1HrtBa+dZHK0UxeofUssJyP/YKahXpSsoS8avdmyt7W r7I/NFtffiI0A+VqNDdaaauCk1HvVrpbnIAqtZ9xWpjVnZZGmmGlNEKX2A+3Lxi8kYeL webQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cUSIVImOhh6mnD33JdJKn9l+xD1dBbES1ADQWyw/cSQ=; b=eBgWkIy0d+VvsB2d84VFXJj/yZttVG6YY6F3Ijtl8i8fKcF+GUVf7y+6a9YwdFEcQW RWfWp7MBURVTTXKTWZA3pjUB8amj2AxRVknZP1jTHCifve9tJQBJZizPtHMUhSgRMOVE +21S6W10uEFuZ8kZoW5mYGCXtSXC0NQy9B2osKvLeDlfgYjWfO5g4VQeUAqZCNELHl74 l0TeL00HEt8XAnMSdk/1nfENw+R/pxbu7rUe5blnV0u8esSXFs0AWVDpN7QlSDBnym+h jj2QU8HZ9PsM/oXR8DrF5FTcvZxQXgErcDxKfCYpJWPgytuB8V6GyNIwGBklLVIQVMU8 8HOA== X-Gm-Message-State: AOAM530n18i08ufyiQXc+8iG36EG6I0UBypV1PiJYMNFs/+LnQGmwQpX qDS26k08iHQx92etndEpmXlFzQ== X-Google-Smtp-Source: ABdhPJz0ji0rfOQMV2IR5mKX8CEEVKtkzkGzxDncQYZmm/N8GG3eov3UlqqJX7AIk5l+x6tuJ6aQkg== X-Received: by 2002:a5d:58d3:: with SMTP id o19mr8708735wrf.250.1610637813543; Thu, 14 Jan 2021 07:23:33 -0800 (PST) Received: from dell.default ([91.110.221.178]) by smtp.gmail.com with ESMTPSA id e15sm10777713wrx.86.2021.01.14.07.23.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 07:23:32 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Henrik Rydberg , Peter Osterlund , Stefan Gmeiner , "C. Scott Ananian" , Bruce Kalk , this to Subject: [PATCH 1/5] input: mouse: synaptics: Replace NOOP with suitable commentary Date: Thu, 14 Jan 2021 15:23:19 +0000 Message-Id: <20210114152323.2382283-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210114152323.2382283-1-lee.jones@linaro.org> References: <20210114152323.2382283-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’: drivers/input/mouse/synaptics.c:1110:6: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: Peter Osterlund Cc: Stefan Gmeiner Cc: "C. Scott Ananian" Cc: Bruce Kalk Cc: this to Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/mouse/synaptics.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 8fb7b4385ded9..3cc8b76629fa2 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -1106,8 +1106,11 @@ static void synaptics_process_packet(struct psmouse *psmouse) num_fingers = hw.w + 2; break; case 2: - if (SYN_MODEL_PEN(info->model_id)) - ; /* Nothing, treat a pen as a single finger */ + /* + * Keep defaults + * + * SYN_MODEL_PEN: Treat pens as a single finger + */ break; case 4 ... 15: if (SYN_CAP_PALMDETECT(info->capabilities)) From patchwork Thu Jan 14 15:23:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12019903 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2CB3C433E0 for ; Thu, 14 Jan 2021 15:24:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACFE223A7E for ; Thu, 14 Jan 2021 15:24:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728441AbhANPYg (ORCPT ); Thu, 14 Jan 2021 10:24:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726269AbhANPYf (ORCPT ); Thu, 14 Jan 2021 10:24:35 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CF1FC0613D6 for ; Thu, 14 Jan 2021 07:23:36 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id y17so6158561wrr.10 for ; Thu, 14 Jan 2021 07:23:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=emmStX9qhOYOd+dblyHI68RIhRy+T5Rtfe1f4/LeDqU=; b=tx/SQRmaSa7vWznaqpwEIsGMlMwxLts4yZ5xZOOW2lVDXeap7iWwpatlHL0aBdMQya YwxqYpz7MjszELUgKs5R1s8nz5EKnpCRFeOZI2hbNgaUHUzJI8WLeT8ffMgzvo8adAJr Fd1F0uyyoHpqeO3Zasr0n4VYlzCC5CE/XSn/4vRJZ0NhdjlKQYyQFjyza/7aemVOojPE 6A8eymDVqsNeO7ciCAFI7HTH4Qqha0ciywS/Ox0fTqi4Qbr/CaOeQRDHDWwVxnO/eURw h5ZLUSz06kPsAXlw3rPdZIoBlIWpbZf7bqRcV4K9J40OGRjcvTYWtg6Q93qv9iGeTyXh wvqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=emmStX9qhOYOd+dblyHI68RIhRy+T5Rtfe1f4/LeDqU=; b=C2ArxaEANZb3i8aeBRubKBU+XsLZKnV/sruktU2o4LutnsyV+aY7eN8Q2mvZrgIXKO EIpYdZqxHVO26kY6LFXOrdBX9aDhpPV8bcNofk0Fokv2aG95oXd8NuGjYySmDQOlfhgn iu3ir/QTHERexBAxTNanAbfCvfu4vPmy2PoWBQBs/HappFv0cLz66q85VycVpfG7XwPE JKFrCOYY+o+wWdVFooSZKRjKtj2Zj7HQbzyAzfbjP0S/wN0WhmOKIWOWPPaqpzefaLpP WdKU33a/uYlGsIfG0kOesxb5K/fOCRJR7b+NM9aN887kfY0WlSUXQCA4qexthWUTAW1z j1LA== X-Gm-Message-State: AOAM530p5s58T66pkGYkXygxJnoiIKRs3DSdk9P/KoYd1tBcanGAktXv q03VgKItC3iaQOZKCXanj5wG4w== X-Google-Smtp-Source: ABdhPJygzGegSOhqoPC1wqYCq4XYpIX5A7Wq7t9xprCcdvYgsoV0FcfL9IL3RDbPH7iC4s6K4MT6VA== X-Received: by 2002:adf:8b15:: with SMTP id n21mr8321366wra.426.1610637815098; Thu, 14 Jan 2021 07:23:35 -0800 (PST) Received: from dell.default ([91.110.221.178]) by smtp.gmail.com with ESMTPSA id e15sm10777713wrx.86.2021.01.14.07.23.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 07:23:34 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Sangwon Jee , Dmitry Torokhov , Henrik Rydberg , linux-input@vger.kernel.org Subject: [PATCH 2/5] input: touchscreen: melfas_mip4: Mark a bunch of variables as __always_unused Date: Thu, 14 Jan 2021 15:23:20 +0000 Message-Id: <20210114152323.2382283-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210114152323.2382283-1-lee.jones@linaro.org> References: <20210114152323.2382283-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Dmitry requested to keep these around for the purposes of documentation. Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/melfas_mip4.c: In function ‘mip4_report_touch’: drivers/input/touchscreen/melfas_mip4.c:474:5: warning: variable ‘size’ set but not used [-Wunused-but-set-variable] drivers/input/touchscreen/melfas_mip4.c:472:5: warning: variable ‘pressure_stage’ set but not used [-Wunused-but-set-variable] drivers/input/touchscreen/melfas_mip4.c:469:7: warning: variable ‘palm’ set but not used [-Wunused-but-set-variable] drivers/input/touchscreen/melfas_mip4.c:468:7: warning: variable ‘hover’ set but not used [-Wunused-but-set-variable] Cc: Sangwon Jee Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/touchscreen/melfas_mip4.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c index c0050044a5a9e..225796a3f5460 100644 --- a/drivers/input/touchscreen/melfas_mip4.c +++ b/drivers/input/touchscreen/melfas_mip4.c @@ -465,13 +465,13 @@ static void mip4_report_keys(struct mip4_ts *ts, u8 *packet) static void mip4_report_touch(struct mip4_ts *ts, u8 *packet) { int id; - bool hover; - bool palm; + bool __always_unused hover; + bool __always_unused palm; bool state; u16 x, y; - u8 pressure_stage = 0; + u8 __always_unused pressure_stage = 0; u8 pressure; - u8 size; + u8 __always_unused size; u8 touch_major; u8 touch_minor; From patchwork Thu Jan 14 15:23:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12019905 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0266C433E6 for ; Thu, 14 Jan 2021 15:24:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C63CD23B44 for ; Thu, 14 Jan 2021 15:24:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726269AbhANPYg (ORCPT ); Thu, 14 Jan 2021 10:24:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728275AbhANPYf (ORCPT ); Thu, 14 Jan 2021 10:24:35 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 147B5C0613ED for ; Thu, 14 Jan 2021 07:23:38 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id a12so6158462wrv.8 for ; Thu, 14 Jan 2021 07:23:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2/gXgNDu1uyW35GFMajH90cFbEvxlmWXIJTYckxzqVk=; b=krtlsG+aLWRAIX9zV+NsYdLbI48e1rxdpWZNPphUG+hAJz96nZsRel763lARXW5V8z TX0t8kxqdYeuJC7UkKpw6mWnnxI+AFmCQIjRKT3s0VpTYlfLBpqT+1ufUY2RN9mpobIZ TiQfQuMBRP9ixaLxo6a6ohljtZNq95lk5ko8yI8+TwSyPN7LL5H/9Ppa2YmwDmA0AWDB rlFWie1u6F8XbK0IqXCFx2upanbDm9JC+GGh8nr66ylcpg2qBLoIKGMcSLPVph76w19Y MYiT6Vzm71CwHtvd5MdAZNYr2nGIPkt09IEdHs9ZpZAjxqgFk/EFxTzlQRIDtRXrzQ+h QdHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2/gXgNDu1uyW35GFMajH90cFbEvxlmWXIJTYckxzqVk=; b=l4auIOvJoU2IAMl2vyQPxA9TN/NG/s8OR0aT7fVKlbA2XjfwA9Oqi8CYz+OiD+uDer Z6Dvho+7QrFntIwPmehEiY70wYHEXrnFbVP3eyt+tceytESBS/UI8pxRUQ1rzDaWzDj6 mPwmYceiHRbFbE+pCA1QRT8HXQrRGs9acmGGpaaNWcApdc0c/fHe7sORkVasEbRnZBGT X4uZYkk0aMZOep2R515oc7VAx1hyY9GH2BB5V6bC2UDQk1Lp5X7JRwVEadk6MHUrKL85 5DVnJ94JddmIhVuSoLgMD9p85sDqYqmCTjXcDakMx57DySm27UfXEXU7buUUcI80zNxQ oAHA== X-Gm-Message-State: AOAM533RihUPJzdCu8WWOSRcx7cDQr26xmRmsBz7MHMnvuVupwfcyOjz gSDkgDxrbuSK1fHqvWVe0AaT0lPjIvuKt1PE X-Google-Smtp-Source: ABdhPJw+mdqQdSv/cG7KLNxvSCpUa7jSfXXjrft1iLVMvVdpmSN7RS5FfXzrLw2Q4OMUNOP/c2LklQ== X-Received: by 2002:a5d:4e89:: with SMTP id e9mr8367193wru.201.1610637816788; Thu, 14 Jan 2021 07:23:36 -0800 (PST) Received: from dell.default ([91.110.221.178]) by smtp.gmail.com with ESMTPSA id e15sm10777713wrx.86.2021.01.14.07.23.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 07:23:36 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Henrik Rydberg , James Hilliard , Daniel Ritz , linux-input@vger.kernel.org Subject: [PATCH 3/5] input: touchscreen: usbtouchscreen: Actually check return value of usb_submit_urb() Date: Thu, 14 Jan 2021 15:23:21 +0000 Message-Id: <20210114152323.2382283-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210114152323.2382283-1-lee.jones@linaro.org> References: <20210114152323.2382283-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/usbtouchscreen.c: In function ‘nexio_read_data’: drivers/input/touchscreen/usbtouchscreen.c:1052:50: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: James Hilliard Cc: Daniel Ritz Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/touchscreen/usbtouchscreen.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c index 397cb1d3f481b..44a5454d04533 100644 --- a/drivers/input/touchscreen/usbtouchscreen.c +++ b/drivers/input/touchscreen/usbtouchscreen.c @@ -1044,6 +1044,7 @@ static void nexio_exit(struct usbtouch_usb *usbtouch) static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt) { + struct device *dev = &usbtouch->interface->dev; struct nexio_touch_packet *packet = (void *) pkt; struct nexio_priv *priv = usbtouch->priv; unsigned int data_len = be16_to_cpu(packet->data_len); @@ -1062,6 +1063,8 @@ static int nexio_read_data(struct usbtouch_usb *usbtouch, unsigned char *pkt) /* send ACK */ ret = usb_submit_urb(priv->ack, GFP_ATOMIC); + if (ret) + dev_warn(dev, "Failed to submit USB Request Block\n"); if (!usbtouch->type->max_xc) { usbtouch->type->max_xc = 2 * x_len; From patchwork Thu Jan 14 15:23:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12019907 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE5F0C433E0 for ; Thu, 14 Jan 2021 15:24:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FD7523A7E for ; Thu, 14 Jan 2021 15:24:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729407AbhANPYz (ORCPT ); Thu, 14 Jan 2021 10:24:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728544AbhANPYy (ORCPT ); Thu, 14 Jan 2021 10:24:54 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3FF3C061795 for ; Thu, 14 Jan 2021 07:23:40 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id v184so820207wma.1 for ; Thu, 14 Jan 2021 07:23:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YJZuOyPoke9O1aNcUMwMh4SJuqZZoxbP5+ZVqt4w+RI=; b=r2JSG1IJnbN0WfX5sB5L2Cq/teMhRCtH4rBbnSLTPluaLtMGJxUn/XATcotrcaLRE5 utL3DvHa7fsz/+QlHoykplDmscM0XvWs860rgqW1CAGZzKuEyBjxBcw83hqZnMKvnw0Z YCxnS2KxO4crQJsEz4E0IzO1xCMvxSnGajqw6MauczaDwZ55uWYBILR4M9wdIFwkt410 U42gupjSDuysYDyYU326nDWgeuM8i0W/yEVv3Zq7MO99Dc5/lNwGsto//vFJH1pdLiAP JfwY8IOhwEVIFH7EHiedIeOxINfZfuJhYkPpbOtml1nsUFj6vGTLQ2YlsSoaFsidbJpU /Apw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YJZuOyPoke9O1aNcUMwMh4SJuqZZoxbP5+ZVqt4w+RI=; b=jap6W13Bitd/GMgV9fNpHcwCjw1Q/GIMOj2PPDPFlgcL3Lxl8/GGe/kiDWko4ppAm5 4IH56xTbz0kojXTsT8j+Q+agjSm7+G5ncKTcyEFvxrm3AcVJRmUlZq5fjJBd/THNOInD tnGdlNU4um4LwWmqFdXBjWLMglCdE0k/9HOLsWUebStalXCmN3i0hDrXcDBrP2Ri/ECN S+sdLsCzZi9GFRKv65ZlXALulspvuD9AgMvdScOgc0rF1j+1q0J1cjuKDGnLjNaLaX8d 6U02Pot+Nlh/Rp8Q86ex0KUZgQlgKlZMZTVfh2poClZGj0v8V473XfW8ZqsfP8Tf7Tb7 4k4w== X-Gm-Message-State: AOAM533hRFWdZvqDbRw8FHHYbqEwVqha1R1MaDcKcE9HX6hTnldNts7j QSeJJEUW0dfxswrKi39fh0chkQ== X-Google-Smtp-Source: ABdhPJx2UKyCEzuGYIeNsgJs70XmBN475KmSy2OCYzwa33HUGNcgxGsp2/MFTZQ8zEmxhuBBWXKEPA== X-Received: by 2002:a1c:b3c3:: with SMTP id c186mr4525364wmf.169.1610637819435; Thu, 14 Jan 2021 07:23:39 -0800 (PST) Received: from dell.default ([91.110.221.178]) by smtp.gmail.com with ESMTPSA id e15sm10777713wrx.86.2021.01.14.07.23.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 07:23:38 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Henrik Rydberg , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 4/5] input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp' Date: Thu, 14 Jan 2021 15:23:22 +0000 Message-Id: <20210114152323.2382283-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210114152323.2382283-1-lee.jones@linaro.org> References: <20210114152323.2382283-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/surface3_spi.c: In function ‘surface3_spi_process_touch’: drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable ‘timestamp’ set but not used [-Wunused-but-set-variable] Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Benjamin Tissoires --- drivers/input/touchscreen/surface3_spi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/input/touchscreen/surface3_spi.c b/drivers/input/touchscreen/surface3_spi.c index 731454599fcee..1da23e5585a0d 100644 --- a/drivers/input/touchscreen/surface3_spi.c +++ b/drivers/input/touchscreen/surface3_spi.c @@ -94,9 +94,7 @@ static void surface3_spi_report_touch(struct surface3_ts_data *ts_data, static void surface3_spi_process_touch(struct surface3_ts_data *ts_data, u8 *data) { - u16 timestamp; unsigned int i; - timestamp = get_unaligned_le16(&data[15]); for (i = 0; i < 13; i++) { struct surface3_ts_data_finger *finger; From patchwork Thu Jan 14 15:23:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12019909 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 580B1C433E6 for ; Thu, 14 Jan 2021 15:25:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25F4C23A9F for ; Thu, 14 Jan 2021 15:25:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727450AbhANPZE (ORCPT ); Thu, 14 Jan 2021 10:25:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729404AbhANPYz (ORCPT ); Thu, 14 Jan 2021 10:24:55 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8ADAC061796 for ; Thu, 14 Jan 2021 07:23:43 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id k10so4867120wmi.3 for ; Thu, 14 Jan 2021 07:23:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j/+bCy6NrhocYkhQjIFLsXRroyVux/dbH+svWNWdQyQ=; b=ERomriJ5NywBp23UX4u658HW/Nqh6AIqaycBNvleJNsA1Ud7a5YalC0I1tzz0fC5Od fwYjHvaaSrXnwaf11CdOVPvy3SjksfFQJ3jVKe2/I6WG1sAvkUbYXhP/GTCw+Jh2mFiT wZRDhrP8rYmcOyhpozbE7EvpOLJvZUyTmmJAMSD801UGfV2EEawB7QH703cVvVhRuhOC 4UsILN0LirRxIgkt/4BUIfyeCvSt697EHySQjjr42tE+XPF/K05dCHFSxLWKONRWvPj3 PfnUsZOpohgo9ShFwvhpOkB1abEhWH/tcVzRfNQ/XIvuZrXh6sfMD9a8isblKDYKo0jl BvkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j/+bCy6NrhocYkhQjIFLsXRroyVux/dbH+svWNWdQyQ=; b=AutgcMZrK0RFYSaqGFhXFMX08IbA+M2NXgNuV+cBjHuAtp1Taw5SRBZ7FL0Yq0N2yu QXJHXnd2onqG8np/CEOFyKyp2qtg0PyY2aNr8WL70fss2pfY3H/QdVzkBcxlPvCM2/Bo HVaUJXHxYpVHQvX4bS91v1PRQP8JVodIfMCPax7HOZcWkiSjwT05vveEkmu/0hx0vsS/ O1zfuf2TM/JOXwir/q8PMwUVeu/MR2D3c7Sdpl2Q2iJtyfsjsDFcqHR/ijXvFK9d5VVz pJ3EIKfRb260ZhjeHxdVH+oVqX3pM0o1E8PSTjfRuCe4MXlfBXhfQRl/PSvtlo74Bc5j KT5Q== X-Gm-Message-State: AOAM533M5a4WBTlgx7ISVBJwiowqsIwl0EwZqVKHpivXhy+sN6fObT0c D5XtjyqgmDo5QMsE3yLP9koQjw== X-Google-Smtp-Source: ABdhPJyB5UCo1HKIbdX59cHs1y1+H/YppQr8pHhUpqQnshgUA1zoSs1SW9jgNoHwXrjI1Ae5j6gnhw== X-Received: by 2002:a1c:acc9:: with SMTP id v192mr4340744wme.174.1610637822501; Thu, 14 Jan 2021 07:23:42 -0800 (PST) Received: from dell.default ([91.110.221.178]) by smtp.gmail.com with ESMTPSA id e15sm10777713wrx.86.2021.01.14.07.23.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 07:23:41 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue , Stefan Riedmueller , Luotao Fu , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH 5/5] input: touchscreen: stmpe-ts: Add description for 'prop' struct member Date: Thu, 14 Jan 2021 15:23:23 +0000 Message-Id: <20210114152323.2382283-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210114152323.2382283-1-lee.jones@linaro.org> References: <20210114152323.2382283-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/touchscreen/stmpe-ts.c:82: warning: Function parameter or member 'prop' not described in 'stmpe_touch' Cc: Dmitry Torokhov Cc: Maxime Coquelin Cc: Alexandre Torgue Cc: Stefan Riedmueller Cc: Luotao Fu Cc: linux-input@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Lee Jones --- drivers/input/touchscreen/stmpe-ts.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c index cd747725589b1..25c45c3a35615 100644 --- a/drivers/input/touchscreen/stmpe-ts.c +++ b/drivers/input/touchscreen/stmpe-ts.c @@ -52,6 +52,7 @@ * @idev: registered input device * @work: a work item used to scan the device * @dev: a pointer back to the MFD cell struct device* + * @prop: Touchscreen properties * @ave_ctrl: Sample average control * (0 -> 1 sample, 1 -> 2 samples, 2 -> 4 samples, 3 -> 8 samples) * @touch_det_delay: Touch detect interrupt delay