From patchwork Thu Jan 21 09:44:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12037335 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51804C433E6 for ; Thu, 21 Jan 2021 18:14:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B6FC23A57 for ; Thu, 21 Jan 2021 18:14:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389207AbhAUSOa (ORCPT ); Thu, 21 Jan 2021 13:14:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728780AbhAUJqF (ORCPT ); Thu, 21 Jan 2021 04:46:05 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 888A2C061757 for ; Thu, 21 Jan 2021 01:45:24 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id c128so936066wme.2 for ; Thu, 21 Jan 2021 01:45:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XqHnJ2PCqY0GDD9E/M7j7TZIcrnsj5geJs7YkKXUyyQ=; b=RTUKiq8Os5P5UyzCC/cUjVpVnM5DorMjaNn+QkLgBUSmF/z/Onh3iZAYn+of7tsD5T oZNB2XQtiosWQEzjBU4S7sraSsPlxge80pYuBywKY+agV/0tfHSLbKKwuwKMYQGcPYS9 7Fw7BcHG1/fzSbVYb6DHGfdUNNsoyN6ak+SC9yEn6m9a3mRp/yFY6hAx9cSjZRl59v+P RzMbbG/FHz/yfOm6cM0O/4TUSjiWpCSGZ1hLM2RU0Fj4TSxKlvzPmmfBiPXKm+WHTJPg Z9L1r5lJs82BSrmnaBxeIklNWH5VFelO+F4FJBSTtqmv1JiCGo8xDGwTEVxTpgxmCRag LGyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XqHnJ2PCqY0GDD9E/M7j7TZIcrnsj5geJs7YkKXUyyQ=; b=HkGAdPJRMpowMsD9WRw2Q1UOxSY2zdN2rMaasaTM/8scukwCvJrb/rhuQdvuRb5Dnr QuUdkTWO4cWpzHlZuIwHDhDqwQZZ5lgiNXlDtLFKCBbsBztl+f0aUE7a6WwztLyAmcwk 7RpKGjTrQLFnFCNvhMAOWAj1c+dNLD7UfeC7y8Hs/NO6W9k3KBM33fQHItV9yp62UIMX QrvnBtmxzzWaYMLquCrg3A48Y0Sp90b/TZvOr81LKaLReOGPkhLv19bxIz4lW4IBE1lr 8YElRIZmXSAvxrheOGi4xZK+KlAZMMWU6c+DlCiSSHLerOI6oxMlfWmwP7Liwbk2ygD/ ZM+Q== X-Gm-Message-State: AOAM531S0YNb+HBxAMZ8dJN0LbyuJ6XHEMPYa8lefIl5zEtU0e5qrbEU DavtlMOuKxBw62TWGH2jwcq2lw== X-Google-Smtp-Source: ABdhPJxZCaAzCae2wKCuVCpT+4ho7qtdoImSFpg9c2BEz0qXsuK08X7w5N74AR8JZOUHinI5F+y9ow== X-Received: by 2002:a7b:cb04:: with SMTP id u4mr7997443wmj.117.1611222323296; Thu, 21 Jan 2021 01:45:23 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:22 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Leon Romanovsky , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 01/30] RDMA/hw/mlx5/odp: Fix formatting and add missing descriptions in 'pagefault_data_segments()' Date: Thu, 21 Jan 2021 09:44:50 +0000 Message-Id: <20210121094519.2044049-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/mlx5/odp.c:1062: warning: Function parameter or member 'dev' not described in 'pagefault_data_segments' drivers/infiniband/hw/mlx5/odp.c:1062: warning: Function parameter or member 'pfault' not described in 'pagefault_data_segments' drivers/infiniband/hw/mlx5/odp.c:1062: warning: Function parameter or member 'wqe' not described in 'pagefault_data_segments' drivers/infiniband/hw/mlx5/odp.c:1062: warning: Function parameter or member 'wqe_end' not described in 'pagefault_data_segments' drivers/infiniband/hw/mlx5/odp.c:1062: warning: Function parameter or member 'bytes_mapped' not described in 'pagefault_data_segments' drivers/infiniband/hw/mlx5/odp.c:1062: warning: Function parameter or member 'total_wqe_bytes' not described in 'pagefault_data_segments' drivers/infiniband/hw/mlx5/odp.c:1062: warning: Function parameter or member 'receive_queue' not described in 'pagefault_data_segments' Cc: Leon Romanovsky Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/mlx5/odp.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/odp.c b/drivers/infiniband/hw/mlx5/odp.c index aa2413b50adc9..7b30be6aeb167 100644 --- a/drivers/infiniband/hw/mlx5/odp.c +++ b/drivers/infiniband/hw/mlx5/odp.c @@ -1040,16 +1040,18 @@ static int pagefault_single_data_segment(struct mlx5_ib_dev *dev, /** * Parse a series of data segments for page fault handling. * - * @pfault contains page fault information. - * @wqe points at the first data segment in the WQE. - * @wqe_end points after the end of the WQE. - * @bytes_mapped receives the number of bytes that the function was able to - * map. This allows the caller to decide intelligently whether - * enough memory was mapped to resolve the page fault - * successfully (e.g. enough for the next MTU, or the entire - * WQE). - * @total_wqe_bytes receives the total data size of this WQE in bytes (minus - * the committed bytes). + * @dev: Pointer to mlx5 IB device + * @pfault: contains page fault information. + * @wqe: points at the first data segment in the WQE. + * @wqe_end: points after the end of the WQE. + * @bytes_mapped: receives the number of bytes that the function was able to + * map. This allows the caller to decide intelligently whether + * enough memory was mapped to resolve the page fault + * successfully (e.g. enough for the next MTU, or the entire + * WQE). + * @total_wqe_bytes: receives the total data size of this WQE in bytes (minus + * the committed bytes). + * @receive_queue: receive WQE end of sg list * * Returns the number of pages loaded if positive, zero for an empty WQE, or a * negative error code. From patchwork Thu Jan 21 09:44:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12035365 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B86C0C433DB for ; Thu, 21 Jan 2021 09:46:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7597D23975 for ; Thu, 21 Jan 2021 09:46:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728790AbhAUJq3 (ORCPT ); Thu, 21 Jan 2021 04:46:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728759AbhAUJqG (ORCPT ); Thu, 21 Jan 2021 04:46:06 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5F11C0613D3 for ; Thu, 21 Jan 2021 01:45:25 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id v184so938709wma.1 for ; Thu, 21 Jan 2021 01:45:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wJ33o4tgodcPX4COD9SPtmLKlxciPGqpB+G6YKGSIJU=; b=qpboCo6Jn4F2KnFbGAFSpZ3Z+ZIt1BPReMS4x7K68RtMci3SjRk0oS6255uZFpOK2W aJpDGAD4eOiRN5oyF/O4L7D4sAew4VHKYjj6Mb0ZzmqbLkMtV4Sb0n7SwB8qUnMBXjwL An6/bpLCThSMN4TXuV84ciDR+7UAdSg4Gt+e+Lcdz0mAKv9r4ozbQnCvulyeGaakeCAS IfHhwsxGx7wyI/rbPKHLl7TT3G7kBh5av16hAHMNCMEaLjF59eYkXBT80CLnhgTPj+ML lKIBv5L5xDRa/KxrXn1fu3Km6ueUNZTeyxynnOxHO28l2HCsWP01X997cEHL80e0Vutn rKQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wJ33o4tgodcPX4COD9SPtmLKlxciPGqpB+G6YKGSIJU=; b=nSL+Pu34+mo1wVKzBqWa0hTtHQHzQhci58uhR4C3eO/CbSTjPtbjn9D+4TA3DzLRWl loPhfryXzhsxYZf4Nc8aOl0BkR19rmUEL4HgLegjkBFQYLnFSaCZWqn7eF9P5PpYav3m en+H4JMkYP7DvGvma/zhrWgKklJ1/jVWLm2GdAjSQ+/GEYh3ggApK+s4T1TKfVR1oMWJ ufRc1B9BHM2FBzRefYUDEdnF1ECQBX0npd3HLV7ssY1rVOs/6ZvBUq2STrcYKjd7VUDP fD6CGoNj6eTw3pt+nJtjv0AxcvUCkU1A2s4+08TaWgBc5jX3oy/b5k6LQX5Lp8bAB9Np fY7A== X-Gm-Message-State: AOAM531INdnrOZFofvrLYC+vl7btUK+9u7+lrs5JUIYccG9ZG9bwWNn0 6kG3VvDWrPdSX/XKUHXF4CeGbw== X-Google-Smtp-Source: ABdhPJzLatP3nSzaG3gu3Zq9S87pzShfBipjh2qaGsUDLMVOi1AGC6tbdhTzGv40b+h971zvRsW6Eg== X-Received: by 2002:a1c:6741:: with SMTP id b62mr8216797wmc.21.1611222324492; Thu, 21 Jan 2021 01:45:24 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:23 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Leon Romanovsky , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 02/30] RDMA/hw/mlx5/qp: Demote non-conformant kernel-doc header Date: Thu, 21 Jan 2021 09:44:51 +0000 Message-Id: <20210121094519.2044049-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/mlx5/qp.c:5384: warning: Function parameter or member 'qp' not described in 'mlx5_ib_qp_set_counter' drivers/infiniband/hw/mlx5/qp.c:5384: warning: Function parameter or member 'counter' not described in 'mlx5_ib_qp_set_counter' Cc: Leon Romanovsky Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/qp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index 0cb7cc642d87d..c916e48b2e529 100644 --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -5376,7 +5376,7 @@ void mlx5_ib_drain_rq(struct ib_qp *qp) handle_drain_completion(cq, &rdrain, dev); } -/** +/* * Bind a qp to a counter. If @counter is NULL then bind the qp to * the default counter */ From patchwork Thu Jan 21 09:44:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12035363 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99FAAC433E0 for ; Thu, 21 Jan 2021 09:46:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5487E235DD for ; Thu, 21 Jan 2021 09:46:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728582AbhAUJqT (ORCPT ); Thu, 21 Jan 2021 04:46:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728844AbhAUJqH (ORCPT ); Thu, 21 Jan 2021 04:46:07 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF409C0613ED for ; Thu, 21 Jan 2021 01:45:26 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id e15so939338wme.0 for ; Thu, 21 Jan 2021 01:45:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DuWnTnQlKM5d7eIpepIHxbb/jr5fMrflS56XVI5B5ZI=; b=LVvJvw4WJe3+7vXijwOXM85K/2lPGitkue2jDfxepKvoOG6dCHHTDbzHSXWlKspZJu Hl2kNIBKk05w2PaoGOamZkh5lkelwiryKXtR9bx5WvHO6KHr/pZBczENO2+XFkYsvho0 9OPBG6ai394ZE5c59fU8jXyRd80HHYkF8d3GpFCFbRuK89VI4qvJBMeLiSjVkVg8dA/F +uxND7F+FnmRyF69505R6IZutHG6wRACnILzSxy7EJKgGpWhl8kWHlx7fakTa74jnKEE alnse0sizD2R5pLU8EZEBi4nqYsuBYmelN6gg9XK65xNNrKbwRqwMtvIg5pr2FnJF0pK Swkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DuWnTnQlKM5d7eIpepIHxbb/jr5fMrflS56XVI5B5ZI=; b=SZBS2oUAPsH+a8L2liySlwK2u6a9/z6C4/N0311bZBwcBYuzPfoIdhehjg4hedlKqO Vv89A0GdlgEq3e8In4yfIBBiFaVSKTUoIAmP/VYbIFFKJ/oAmCA22LGJ4i2XIXSsilaW F0yS/Gt2VjBOQZURGE0XwZLLfMJb28Gc+xdqu+HOOifsKzLSvoKQBqhzW1/MjNY2nnEP 2mYrpVpyWVEtutjwTLHFsKy7KSZDKGi3xZ2ZY1PGHx+a8qqpN+boJUgUp7agYkyyMBqN Kdnhdt2McEXH2sYWpV24GfWEs02Un+LDBGsfKjM/nRuxpPrOO6yE5eTjC/ATXGvEtVi2 +W9A== X-Gm-Message-State: AOAM531qK7t28TWt0Kza4ZDQqZW4TIsm1OPm02d/k6Of2j+uY9puEKEH s76GP7XgQXSG8jPbvep2eI2Cxg== X-Google-Smtp-Source: ABdhPJzZbE02TDkxHr4pcuDCcMT0VK0JklH7GHF4SOka1EHWF5SyStuve8C+Q8twGRUoeDsfSZlExA== X-Received: by 2002:a1c:5608:: with SMTP id k8mr8035775wmb.91.1611222325701; Thu, 21 Jan 2021 01:45:25 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:25 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Gal Pressman , Yossi Leybovich , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 03/30] RDMA/hw/efa/efa_com: Stop using param description notation for non-params Date: Thu, 21 Jan 2021 09:44:52 +0000 Message-Id: <20210121094519.2044049-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/efa/efa_com.c:801: warning: Excess function parameter 'note' description in 'efa_com_admin_q_comp_intr_handler' Cc: Gal Pressman Cc: Yossi Leybovich Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Gal Pressman --- drivers/infiniband/hw/efa/efa_com.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/efa/efa_com.c b/drivers/infiniband/hw/efa/efa_com.c index 336bc2c57bb1d..f7242188a8434 100644 --- a/drivers/infiniband/hw/efa/efa_com.c +++ b/drivers/infiniband/hw/efa/efa_com.c @@ -795,7 +795,7 @@ int efa_com_admin_init(struct efa_com_dev *edev, * This method goes over the admin completion queue and wakes up * all the pending threads that wait on the commands wait event. * - * @note: Should be called after MSI-X interrupt. + * Note: Should be called after MSI-X interrupt. */ void efa_com_admin_q_comp_intr_handler(struct efa_com_dev *edev) { From patchwork Thu Jan 21 09:44:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12037333 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38E5AC43381 for ; Thu, 21 Jan 2021 18:14:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0DCF23A57 for ; Thu, 21 Jan 2021 18:14:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728255AbhAUSOh (ORCPT ); Thu, 21 Jan 2021 13:14:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728894AbhAUJq6 (ORCPT ); Thu, 21 Jan 2021 04:46:58 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B517C061794 for ; Thu, 21 Jan 2021 01:45:28 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id u14so930803wmq.4 for ; Thu, 21 Jan 2021 01:45:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lBLwu+617zQ07npA6RXz6Tf17IOtHddjN6cfc3yfTCI=; b=dfLuKNzZ3ku/O7QE9b2/0QO9aIwxpb3WHqXtAqE0V52WOktO4jw01QZw73WtJjBr5U 5mbmCFDOjUvG7AIVz4lCKaG7O38kTo78KyHCMLwM2hpML1vlVQoxQlfgxPRa2ZpNWiDx djcKyw139NyoRRzxu34PYyn18P55ak47Cnk5UiYhYqTXj1RfRTHlflsQUm44X4yxZG23 RK/qDniEwy98Fpwz8UOYSSP2NB0BH/u9Opdh9QvEXlDTxfo3alHKXGU7uUVKhBpqsQiJ oFNwGbIcHfiDH7byUXHl79PkoSsqNnyfLNAKCJPWrfEjYjuGpOFrIRFf5iKjh5QVVtic Rbsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lBLwu+617zQ07npA6RXz6Tf17IOtHddjN6cfc3yfTCI=; b=dEtyQwaeyyU+aiti3MUZ5JAOcSaIh+Yd/mzxLyXtM1Ty4d8NOgubNmE8Nf2cKDx0NB jSPjC1dCGB/+C2+OOY2gBPtL1IQjrlJqXLcDPoPDaDqBlBjDMmSwErL1EAtRzaPSO1gh SkoQ8hL1Hz7+y70bHuPJ+gT7E72jMfRCvaLpMRkN4cE0/uLcElg0PvLz1SQROWIdl2Lz tDIUYym9cDhbeVKD87P2Fi468sSgbRYDNQ96i2FhNbpnGkSwv9nnyfGRE8RB5FQgsAwi zEJCCTiz0kLIXYLlzFdW6oqgYX1QgvIsMHF6QIPEbFWXiku1quvqicA7v7ao7r7YJSul az/Q== X-Gm-Message-State: AOAM5332gVi5I1W3GYXR8BbJNDaAZBBYhlDqLTxOZ9L44LCbLjm7n6Ih hQaSGQziS7MTIHcT4yUqOKCgjg== X-Google-Smtp-Source: ABdhPJwO5trW2/kFg2672ZAmOG6H9jxxi6HftdC4+xImSiIHF4p72gEqrWXXpradGXLbGc8ASwjlwQ== X-Received: by 2002:a05:600c:2249:: with SMTP id a9mr8317598wmm.169.1611222326913; Thu, 21 Jan 2021 01:45:26 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:26 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Lijun Ou , Weihang Li , Doug Ledford , Jason Gunthorpe , Wei Hu , Nenglong Zhao , linux-rdma@vger.kernel.org Subject: [PATCH 04/30] RDMA/hw/hns/hns_roce_hw_v1: Fix doc-rot issue relating to 'rereset' Date: Thu, 21 Jan 2021 09:44:53 +0000 Message-Id: <20210121094519.2044049-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hns/hns_roce_hw_v1.c:1398: warning: Function parameter or member 'dereset' not described in 'hns_roce_v1_reset' drivers/infiniband/hw/hns/hns_roce_hw_v1.c:1398: warning: Excess function parameter 'enable' description in 'hns_roce_v1_reset' Cc: Lijun Ou Cc: "Wei Hu Cc: Weihang Li Cc: Doug Ledford Cc: Jason Gunthorpe Cc: Wei Hu Cc: Nenglong Zhao Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c index f68585ff8e8a5..23fe8e9f61da5 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c @@ -1391,7 +1391,7 @@ static void hns_roce_free_mr_free(struct hns_roce_dev *hr_dev) /** * hns_roce_v1_reset - reset RoCE * @hr_dev: RoCE device struct pointer - * @enable: true -- drop reset, false -- reset + * @dereset: true -- drop reset, false -- reset * return 0 - success , negative --fail */ static int hns_roce_v1_reset(struct hns_roce_dev *hr_dev, bool dereset) From patchwork Thu Jan 21 09:44:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12035371 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18A18C433DB for ; Thu, 21 Jan 2021 09:47:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFDFA235DD for ; Thu, 21 Jan 2021 09:47:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728910AbhAUJrC (ORCPT ); Thu, 21 Jan 2021 04:47:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728873AbhAUJqj (ORCPT ); Thu, 21 Jan 2021 04:46:39 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D05CC061795 for ; Thu, 21 Jan 2021 01:45:29 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id v184so938859wma.1 for ; Thu, 21 Jan 2021 01:45:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l90cpQ/e0T6TuHwbhU/4LDQoeOSySsNazUcP2W8fpcw=; b=L1EpP2OlDV281D8ChiGh+C9MURnk5TsQ2b0hrO8AIuw6a0RHnu43Wnv3e6Ka1XH6YU ycjd3SONVCJOuz4cE03wkdbqQRMRtf+GV3/rW6SNeK5AIN84J/F88FjfUkeJPQlRVjyu gHTkRbeeuceYrm+Zf/lXZA2AIdL0t+HpKXpLem2AfDc/WiPGXAw0Kppj2MXpULyjRSri GwxHEHdTs/j9C09/0OlycRKvczqMD31fL9m+DUSvPfobi3jr18BQilUQIky9RF9ufdsL WYwelapy5ylUtEymKJl7PV3I0S5I58bNZyOymZnZBav2OAnZEmUfk4fg0uZNO41Jaxea tdOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l90cpQ/e0T6TuHwbhU/4LDQoeOSySsNazUcP2W8fpcw=; b=rPhHn3XQ2NpgEz3n4UWX/RHIm98fYhxI7vYzEAT0O6F1XVlXIUt01Aqphlpg43Nkh7 WkjN43kXUv50y1+lvPWMPC2Ggi7htMRbzj1P4hEy+BQE6R9QrvOZ2OZCA3Wd3Fl1+GRM V6/a+wE7tKdF1kKAQxnBdGjUP540WnUk4u0ZTk6NokKXr1UktRoG5mHHrqLmSx25//r5 0ZxMkL1HF5HaLDj61visTX5ygB1q9KoI/QyWanDhT2kotePTRiQJC6k3lWkjfuJA3u7g 45TFoqBzAASZs0QbrxQRCn7sKWA4dFYcuy3ZdykbnE89lRaCN1kpPE3HUQBmFz5J903w 5bDA== X-Gm-Message-State: AOAM531+hnBDRQXZ5OWLwh7bNb/psk3O2CuWN2pW+7eIFcXeMaRoTC0A w0cnwmA1W18yIjV1ZihfH7AXRg== X-Google-Smtp-Source: ABdhPJxi6autxrB/UQLxpm5CwpzYbaV6KpUuwNif9ZzlofRVk0JZbRFYvUwAELNzokX8sqEzjzTAFw== X-Received: by 2002:a1c:9e02:: with SMTP id h2mr8144143wme.107.1611222328098; Thu, 21 Jan 2021 01:45:28 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:27 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Lijun Ou , Weihang Li , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 05/30] RDMA/hw/hns/hns_roce_mr: Add missing description for 'hr_dev' param Date: Thu, 21 Jan 2021 09:44:54 +0000 Message-Id: <20210121094519.2044049-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hns/hns_roce_mr.c:1003: warning: Function parameter or member 'hr_dev' not described in 'hns_roce_mtr_create' Cc: Lijun Ou Cc: "Wei Hu Cc: Weihang Li Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hns/hns_roce_mr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/hns/hns_roce_mr.c b/drivers/infiniband/hw/hns/hns_roce_mr.c index 1bcffd93ff3e3..1fbfa3a375453 100644 --- a/drivers/infiniband/hw/hns/hns_roce_mr.c +++ b/drivers/infiniband/hw/hns/hns_roce_mr.c @@ -990,6 +990,7 @@ static int mtr_init_buf_cfg(struct hns_roce_dev *hr_dev, /** * hns_roce_mtr_create - Create hns memory translate region. * + * @hr_dev: RoCE device struct pointer * @mtr: memory translate region * @buf_attr: buffer attribute for creating mtr * @ba_page_shift: page shift for multi-hop base address table From patchwork Thu Jan 21 09:44:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12035369 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 338DDC433DB for ; Thu, 21 Jan 2021 09:46:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFAD823975 for ; Thu, 21 Jan 2021 09:46:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728859AbhAUJqj (ORCPT ); Thu, 21 Jan 2021 04:46:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728866AbhAUJqd (ORCPT ); Thu, 21 Jan 2021 04:46:33 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87715C061799 for ; Thu, 21 Jan 2021 01:45:30 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id m4so1046647wrx.9 for ; Thu, 21 Jan 2021 01:45:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ulUZihKhMqKu/FrEiWqrt3ulvrhzcfuoTPlw0e6qsC0=; b=s2Jpzxqbxd53qzUNbh7UAVlZrjT6H0kWcYwxFsR4dCFFaDnTqYtpashSgSX5gR2JDP 38nju6rQs1j2eYSe9SOopw/xTiIwmUqQxwnNDVnPtTslhmG3/ISkq5jLXxMx9qUYpBsU wxREzxxNKT6OR0tMGsFojbYU6cNzafQ/4h1XquOj3DnZlyhaxbI2OTLXoPq/l7JuH/QR RNl+UFzRnQnbeaU4B2hLApOxSw2UPdf71nzaj4YK7WyeuKKF3CoFUdRdulqy5FwbFbmO E2odcOx0e9wpUBn0TSVxNq+QXuVxGOHRFfac/EvjPM+/vt3v+mpAFLO1eb6ev/Cm4M5g s4BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ulUZihKhMqKu/FrEiWqrt3ulvrhzcfuoTPlw0e6qsC0=; b=e/nJAC/s2sbyxBW1UW8gfCijMPXvYYbEP7CCo4LYcibJrBWpobRlOFOeRuHiE2CIgd bAB+zptDEGC93MrCMZUwosqBzvjyqGkyUpsfP5jAtpu1QJfUIXQL45LJX4wOpyw059Kz Y1UKR8jQ678CEEHCTw0MPqapIeFHe+iumLKqCv83RJTH9IBZytBue9sQ+/wHi3y7MwhK d2cTufdPtPDW2zuvruR2fYywCCxnWkeRbZkumwZXsS/FV89Q9Nk6sHZecxTFpMoFujs6 3E1qqTzQ12frZxFMfMHjYn+YYXb+yX0gKZIzCLg6n30R9MszpFiD5mVL1SiU81kf+lLe 4xyQ== X-Gm-Message-State: AOAM532NZiLToXeWXK9k3wXZ2CD9fi/NJDBo86y1zZqA9DVCfXcxBB8L WxxZKRuDXT9Mioo8HiCVK1+PVg== X-Google-Smtp-Source: ABdhPJyloRfA7yE9s0rM4TaoOVsvlwgbcPwr1rQdlqGPliv4/vSWBDY68K0cjoDWPAyHsb9j/ShwZw== X-Received: by 2002:a5d:4f82:: with SMTP id d2mr13325203wru.87.1611222329357; Thu, 21 Jan 2021 01:45:29 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:28 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , Intel , linux-rdma@vger.kernel.org Subject: [PATCH 06/30] RDMA/hw/qib/qib_driver: Fix misspelling in 'ppd's param description Date: Thu, 21 Jan 2021 09:44:55 +0000 Message-Id: <20210121094519.2044049-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/qib/qib_driver.c:165: warning: Function parameter or member 'ppd' not described in 'qib_wait_linkstate' drivers/infiniband/hw/qib/qib_driver.c:165: warning: Excess function parameter 'dd' description in 'qib_wait_linkstate' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: Intel Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/qib/qib_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/qib/qib_driver.c b/drivers/infiniband/hw/qib/qib_driver.c index 92eeea5679e2c..84fc4dcc5399f 100644 --- a/drivers/infiniband/hw/qib/qib_driver.c +++ b/drivers/infiniband/hw/qib/qib_driver.c @@ -151,7 +151,7 @@ int qib_count_units(int *npresentp, int *nupp) /** * qib_wait_linkstate - wait for an IB link state change to occur - * @dd: the qlogic_ib device + * @ppd: the qlogic_ib device * @state: the state to wait for * @msecs: the number of milliseconds to wait * From patchwork Thu Jan 21 09:44:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12035367 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65393C433E6 for ; Thu, 21 Jan 2021 09:46:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A1A8235DD for ; Thu, 21 Jan 2021 09:46:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728869AbhAUJqi (ORCPT ); Thu, 21 Jan 2021 04:46:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728859AbhAUJqd (ORCPT ); Thu, 21 Jan 2021 04:46:33 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A73ABC06179B for ; Thu, 21 Jan 2021 01:45:31 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id e15so939539wme.0 for ; Thu, 21 Jan 2021 01:45:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=r8pCMAUEP/8sjzyOaRZr85LSq4Lc0g21mTMMeuXpfhQ=; b=f5JSIX6TPhgmEnjLUD7rLdFt36UBUiJ8I1xpDjS6VfNIfRL/z/tIomK78Zkf0S/Vh3 HWUDJ/VY5L+jNeu30E/26qXvpsMVKkeYQ/CZejfOcBqwR+33GCDh3pAHDdi5E561B3cG k6jUALYY+4X4q2L0X55kMcxoNoAOS33Ltp6KUB3e2wt/eHMV29tVXGdCpFPHJVQJm/lS QFmnDCjiJBjDzFb9Jf2ZgMfhjBtM9RAeNFztBe2+KkzUKBrAmAipqmIsQ6XoH8PNoqL8 IQD3hjA+3bt6XTCXSS4hvHokhwndyqUvRa0c5cCK6oLI/bYXQTPPJmx39AQIeRThNv1o hfUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=r8pCMAUEP/8sjzyOaRZr85LSq4Lc0g21mTMMeuXpfhQ=; b=ICEHP/VIMmVurykOmzei7xe2q8lDczSJ3oxeami3E3o5yqDek8FOPa46hWzXePiFTA 6f/pPSfjLpTJoer4vGpBM31MXck1d1px7FeLyxanUtHFu3TQtfuzbYwjA9HW7GZtpiS5 1+1I8zF8Q6m+l/wdLxqDjJm9mMNrrgik1D70drphHW2gnq5QwPBSV3K0t+bsgPfGqBZK I6XIeT6Rh+Ji9GWcaXyYLZxoHVkRkkh1T2G325ee3QMEOpdQe6GdOQOXrWwivm1Tgrm5 R24nSVE+FzjVP1y5nzomlx5MQMc2Q6S59L568TK0hgKpUEHnQW6LEvf5Ff09VpV452ds ZHew== X-Gm-Message-State: AOAM5301V8RseFCA+Aao+ZllYsO+Q8IbtmGeX2tU1CkarBpRG1cP832e vt76b6AiO6/gv6tuUe2wvOrjLg== X-Google-Smtp-Source: ABdhPJzH6LLBqgEy08SoInzP9sd4tJ8ceZnoEnKBEuvsFHdCOcGw5Yex7rHPBdHgylszB+SlbJqxlQ== X-Received: by 2002:a1c:3c04:: with SMTP id j4mr8189605wma.177.1611222330475; Thu, 21 Jan 2021 01:45:30 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:29 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 07/30] RDMA/sw/rdmavt/vt: Fix formatting issue and update description for 'context' Date: Thu, 21 Jan 2021 09:44:56 +0000 Message-Id: <20210121094519.2044049-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/sw/rdmavt/vt.c:300: warning: Function parameter or member 'context' not described in 'rvt_dealloc_ucontext' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/sw/rdmavt/vt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/sw/rdmavt/vt.c b/drivers/infiniband/sw/rdmavt/vt.c index 49cec85a372a9..8fd0128a93360 100644 --- a/drivers/infiniband/sw/rdmavt/vt.c +++ b/drivers/infiniband/sw/rdmavt/vt.c @@ -294,7 +294,7 @@ static int rvt_alloc_ucontext(struct ib_ucontext *uctx, struct ib_udata *udata) /** * rvt_dealloc_ucontext - Free a user context - * @context - Free this + * @context: Unused */ static void rvt_dealloc_ucontext(struct ib_ucontext *context) { From patchwork Thu Jan 21 09:44:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12037321 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45989C433DB for ; Thu, 21 Jan 2021 18:11:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E030D23A22 for ; Thu, 21 Jan 2021 18:11:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733004AbhAUSKy (ORCPT ); Thu, 21 Jan 2021 13:10:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728360AbhAUJq6 (ORCPT ); Thu, 21 Jan 2021 04:46:58 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0012C06179C for ; Thu, 21 Jan 2021 01:45:32 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id m1so376950wrq.12 for ; Thu, 21 Jan 2021 01:45:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=V7Dz2i0KYPfhUGY0bW4v3Nhy8U/GbOrRWsydmH19RnY=; b=bHnr1u+duI3VWQLf6ohZQMMuc4rLFaL4D3Udr3/9VZK7Wg7PUZ1KmWp0hEbXlXvtCk 50ILR2oioMdQVrhb54fFsC6XMvuQsHUu7R2/Y0K420RpiHcqxb3NYHHCGqSmKxX1KB9k s8aC+2im1z27D8J2yp0k/qNoDSaigAW8Q9VYlHVr+C+a0BashY8c490bEBrDjVzpjpLF o3VviIaHRH5CFP2AjlaouNc42bcNgaHqeaopCT3ba1fxt33kzk9JZTYYlCDFFg7qvNTj kZg1kKuyxQ0vpR/Nofrmyq+KtfiL7AyJKOLlAKUMw297lMqaGdVU2UQCnIM0lAKoHPr9 HIEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=V7Dz2i0KYPfhUGY0bW4v3Nhy8U/GbOrRWsydmH19RnY=; b=fu1UsHjMcwse0OqTuHNdqDSYv9RNnx+x/O5957f1nm/5Te0OwMxla5P3bULntAsbS4 wMBFciuFzxPvqqMDMRS93JkVMALZ7No7iqCU1Inlp5+TnPbu/QkATcW09S/R46jY1SGs mVGHzMUpyv3pzlf9gVNx9Z6o293Pp2av5JMwaBRP3JYrS1clvNkvF+4hINdaKJUVREhd 2bOaRdQJvdM715ZXdQF/DV0bXQ/JTLMMYPmakdZiw4pbptmpa21qRmm68fx3TwlncaPC XYIyfL8iYrSlO9LpLPMZysgcrzWQ8tcJT5u7y1fETraPwYidZL4Nan3RdifkDR8m8kyR jnhw== X-Gm-Message-State: AOAM5334QjVfdvjIJd4B6QrO3Eix06Z+X0lK7n+xrt7kR5I8SmRAvdoz C6dyQpsnqnm6bcZpto02RUXTbQ== X-Google-Smtp-Source: ABdhPJxZBxAkgrWIZFohOrkk6WlUWMvrYdfizqnTD5tJzbCbVEFXrrl439o4R4oXxSa+y8k/grYMWg== X-Received: by 2002:a5d:650f:: with SMTP id x15mr13366848wru.332.1611222331635; Thu, 21 Jan 2021 01:45:31 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:31 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 08/30] RDMA/hw/qib/qib_eeprom: Fix misspelling of 'buff' in 'qib_eeprom_{read,write}()' Date: Thu, 21 Jan 2021 09:44:57 +0000 Message-Id: <20210121094519.2044049-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/qib/qib_eeprom.c:55: warning: Function parameter or member 'buff' not described in 'qib_eeprom_read' drivers/infiniband/hw/qib/qib_eeprom.c:55: warning: Excess function parameter 'buffer' description in 'qib_eeprom_read' drivers/infiniband/hw/qib/qib_eeprom.c:102: warning: Function parameter or member 'buff' not described in 'qib_eeprom_write' drivers/infiniband/hw/qib/qib_eeprom.c:102: warning: Excess function parameter 'buffer' description in 'qib_eeprom_write' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/qib/qib_eeprom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_eeprom.c b/drivers/infiniband/hw/qib/qib_eeprom.c index 5838b3bf34b99..bf660c001b6df 100644 --- a/drivers/infiniband/hw/qib/qib_eeprom.c +++ b/drivers/infiniband/hw/qib/qib_eeprom.c @@ -47,7 +47,7 @@ * qib_eeprom_read - receives bytes from the eeprom via I2C * @dd: the qlogic_ib device * @eeprom_offset: address to read from - * @buffer: where to store result + * @buff: where to store result * @len: number of bytes to receive */ int qib_eeprom_read(struct qib_devdata *dd, u8 eeprom_offset, @@ -94,7 +94,7 @@ static int eeprom_write_with_enable(struct qib_devdata *dd, u8 offset, * qib_eeprom_write - writes data to the eeprom via I2C * @dd: the qlogic_ib device * @eeprom_offset: where to place data - * @buffer: data to write + * @buff: data to write * @len: number of bytes to write */ int qib_eeprom_write(struct qib_devdata *dd, u8 eeprom_offset, From patchwork Thu Jan 21 09:44:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12035375 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEE72C433E0 for ; Thu, 21 Jan 2021 09:47:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FF87235DD for ; Thu, 21 Jan 2021 09:47:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728889AbhAUJrJ (ORCPT ); Thu, 21 Jan 2021 04:47:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728900AbhAUJq6 (ORCPT ); Thu, 21 Jan 2021 04:46:58 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17EB2C0617A0 for ; Thu, 21 Jan 2021 01:45:34 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id m187so865344wme.2 for ; Thu, 21 Jan 2021 01:45:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+H03APXDfdyL7LaFA/b0g0zCzrZS1ohEeqXf8bvJDzc=; b=gHfXC3dpfxVrG1AHvM5pWZgIn/rUAADDCIUSmEHMDfEsPyUGK+N/+uqhpMtMNwkLi7 3UXIcgVHSXd/IoQuekp10s4hm/O7L0/q8vh3SzksXOq+sQ6n0UtldsQgwjtoL+bfGVoe zm2jQNnnmC+XwQYvYiO1jsfPaaDIegC1eKzMmnFctK7pJN3Oj7QAUm8wECvwZ4dsseYf YdJlaJT3b3pss8AlG02O+VaBL4BZX6U6QHThsZgvINWbazBEoshNQ+P7GVDoo7wm5hOL B7G4UwUTsk1lb2syfCslJWPn47KuYJzHcA+/zHDc28F4tBB+9GLzAsXWhYJbH11mfmiG h8EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+H03APXDfdyL7LaFA/b0g0zCzrZS1ohEeqXf8bvJDzc=; b=sguGAhyyF+QW8za0zRfUipGD3rFaIUvjGS7BuOHGwTqRWf0R4Z8V3XqT2MBJj8UaKq E85V05/J5DOcIF/0jBMm+Et+oiY5vWP1E5A75D+zK/8rBXYT4VTgZ4Nlqk0YxgytVafV rfV2ErZODl9YDl3yahuURlwGsbhcDSbXiPxQbtkqCar4C4kN1fZ5d98OzlHBoPb166X4 /IkbUht2idT+Q6kM9NPK5oQ7mnkxCyVpXnUQBYgS2Vx56fsOi/3j7VF0pUosAJSLXz+B 7juLHzJzISb/DQeqMgBXnpRyCTmscbsl70Wi18QS8BmytMgKtUZdLruadyVH0FWUSScY vw4w== X-Gm-Message-State: AOAM532hegF00J0BEyRXE9L7mrkQAbnFd9bhOFw3qBc15z0cuvUGHRD6 qgeWIlVWHvPVz4g7EkQ8eCfXAEdKQJOblCWu X-Google-Smtp-Source: ABdhPJxqr9xHKchQbaXjh71PW8euM5LCZv2yrvaYhwC6CnOhV7vk3K4gwav0E881INC9hql6/FvDYw== X-Received: by 2002:a1c:de09:: with SMTP id v9mr8437204wmg.0.1611222332813; Thu, 21 Jan 2021 01:45:32 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:32 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 09/30] RDMA/hw/qib/qib_mad: Fix a few misspellings and supply missing descriptions Date: Thu, 21 Jan 2021 09:44:58 +0000 Message-Id: <20210121094519.2044049-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/qib/qib_mad.c:896: warning: Function parameter or member 'ppd' not described in 'rm_pkey' drivers/infiniband/hw/qib/qib_mad.c:896: warning: Excess function parameter 'dd' description in 'rm_pkey' drivers/infiniband/hw/qib/qib_mad.c:926: warning: Function parameter or member 'ppd' not described in 'add_pkey' drivers/infiniband/hw/qib/qib_mad.c:926: warning: Excess function parameter 'dd' description in 'add_pkey' drivers/infiniband/hw/qib/qib_mad.c:2365: warning: Function parameter or member 'in' not described in 'qib_process_mad' drivers/infiniband/hw/qib/qib_mad.c:2365: warning: Function parameter or member 'out' not described in 'qib_process_mad' drivers/infiniband/hw/qib/qib_mad.c:2365: warning: Function parameter or member 'out_mad_size' not described in 'qib_process_mad' drivers/infiniband/hw/qib/qib_mad.c:2365: warning: Function parameter or member 'out_mad_pkey_index' not described in 'qib_process_mad' drivers/infiniband/hw/qib/qib_mad.c:2365: warning: Excess function parameter 'in_mad' description in 'qib_process_mad' drivers/infiniband/hw/qib/qib_mad.c:2365: warning: Excess function parameter 'out_mad' description in 'qib_process_mad' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/qib/qib_mad.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_mad.c b/drivers/infiniband/hw/qib/qib_mad.c index f83e331977f82..44e2f813024a6 100644 --- a/drivers/infiniband/hw/qib/qib_mad.c +++ b/drivers/infiniband/hw/qib/qib_mad.c @@ -886,7 +886,7 @@ static int subn_set_portinfo(struct ib_smp *smp, struct ib_device *ibdev, /** * rm_pkey - decrecment the reference count for the given PKEY - * @dd: the qlogic_ib device + * @ppd: the qlogic_ib device * @key: the PKEY index * * Return true if this was the last reference and the hardware table entry @@ -916,7 +916,7 @@ static int rm_pkey(struct qib_pportdata *ppd, u16 key) /** * add_pkey - add the given PKEY to the hardware table - * @dd: the qlogic_ib device + * @ppd: the qlogic_ib device * @key: the PKEY * * Return an error code if unable to add the entry, zero if no change, @@ -2346,8 +2346,10 @@ static int process_cc(struct ib_device *ibdev, int mad_flags, * @port: the port number this packet came in on * @in_wc: the work completion entry for this packet * @in_grh: the global route header for this packet - * @in_mad: the incoming MAD - * @out_mad: any outgoing MAD reply + * @in: the incoming MAD + * @out: any outgoing MAD reply + * @out_mad_size: size of the outgoing MAD reply + * @out_mad_pkey_index: unused * * Returns IB_MAD_RESULT_SUCCESS if this is a MAD that we are not * interested in processing. From patchwork Thu Jan 21 09:44:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12037323 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72E75C433E9 for ; Thu, 21 Jan 2021 18:11:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1768F23A5A for ; Thu, 21 Jan 2021 18:11:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728360AbhAUSK7 (ORCPT ); Thu, 21 Jan 2021 13:10:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728901AbhAUJq6 (ORCPT ); Thu, 21 Jan 2021 04:46:58 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD50BC0617A1 for ; Thu, 21 Jan 2021 01:45:35 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id e15so939707wme.0 for ; Thu, 21 Jan 2021 01:45:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=L2I8dCKIs3PfH9t5ebM9UIW4X6/Lh18WEUkSq5oyF1c=; b=Nv2ll40o/1jNkvdCMnMHS8IeGvGLQxo5qX+lL0/yj3gapBl0p+YUjhj4taNi8NgJpz ApPYPjbxdNur+YfZYdmDtWaYIg3Vk5ZchnPrTz8+w5gPgQJ+mETHyZVCoLPOX8/rF/AQ +uNYfWEJnvfP9r7Saq9S5H/PixWwbStCT/7K+l6w71MIOMh1ywv1wS05Si4RopylAjZw YmiGSdozEKgnY9Rvb+JDyEDQZcIRGxo4y9MvP5FONJrpUzuMg7lWtD6c4RfcEihk20LE ZqCz9M3X66cUaHDS1XuQFZblb1DVOXSDKNR3mgFT1kLGPAU/h8W5qDJQ4Uqr626zDUGq JZaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L2I8dCKIs3PfH9t5ebM9UIW4X6/Lh18WEUkSq5oyF1c=; b=gX19+PX41otIlDG8Ukt7hqelT4AyjY8WazqlrRghbtMCo2bfSvlDHzpgzCjwIpgDxT jmGz7wHPuGLdfkJNOPWJQY3W329mizddlW1bGrNpFBD5VJycozO6urnxHC7MQlWMaYll +XI/d5D4D/Y6cu7jX3n4WkO46A7gjsb6tdIDTjxB7Ce9C7MqD4XUtcMGoTghQ74HfvqU CW4O9rF5KdPeC2cMv6rsW1TVzVPM6htxHi0TKf61V+JXHJw/IlzhjB+0t+SSV70MycDi IBl32jtjZ2ZdXx5KE+e55UdJZSsvZPSfeP5SRQa+QNZw/hzd2Vv82l56bdggbyMSRupJ AE9g== X-Gm-Message-State: AOAM532YeG4uj1YlPBJ2TBBxEQJJytbKRXCHqhDiEQxMVZjimxOHyHEh w0w0VoVEaKUqopyVZ5zNrk/jrg1C7h6kg5zX X-Google-Smtp-Source: ABdhPJwQF2LMwnM2UWIfClu/IM8MwWBJ8P9C/RaSSGEx6Tgbv96zNiFUr+W7lvYe6cZlixx4F2U1zg== X-Received: by 2002:a7b:c854:: with SMTP id c20mr7978977wml.127.1611222334495; Thu, 21 Jan 2021 01:45:34 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:33 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 10/30] RDMA/hw/qib/qib_intr: Fix a bunch of formatting issues Date: Thu, 21 Jan 2021 09:44:59 +0000 Message-Id: <20210121094519.2044049-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/qib/qib_intr.c:48: warning: Function parameter or member 'msg' not described in 'qib_format_hwmsg' drivers/infiniband/hw/qib/qib_intr.c:48: warning: Function parameter or member 'msgl' not described in 'qib_format_hwmsg' drivers/infiniband/hw/qib/qib_intr.c:48: warning: Function parameter or member 'hwmsg' not described in 'qib_format_hwmsg' drivers/infiniband/hw/qib/qib_intr.c:64: warning: Function parameter or member 'hwerrs' not described in 'qib_format_hwerrors' drivers/infiniband/hw/qib/qib_intr.c:64: warning: Function parameter or member 'hwerrmsgs' not described in 'qib_format_hwerrors' drivers/infiniband/hw/qib/qib_intr.c:64: warning: Function parameter or member 'nhwerrmsgs' not described in 'qib_format_hwerrors' drivers/infiniband/hw/qib/qib_intr.c:64: warning: Function parameter or member 'msg' not described in 'qib_format_hwerrors' drivers/infiniband/hw/qib/qib_intr.c:64: warning: Function parameter or member 'msgl' not described in 'qib_format_hwerrors' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/qib/qib_intr.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_intr.c b/drivers/infiniband/hw/qib/qib_intr.c index 65c3b964ad1bf..85c3187d796d9 100644 --- a/drivers/infiniband/hw/qib/qib_intr.c +++ b/drivers/infiniband/hw/qib/qib_intr.c @@ -40,9 +40,9 @@ /** * qib_format_hwmsg - format a single hwerror message - * @msg message buffer - * @msgl length of message buffer - * @hwmsg message to add to message buffer + * @msg: message buffer + * @msgl: length of message buffer + * @hwmsg: message to add to message buffer */ static void qib_format_hwmsg(char *msg, size_t msgl, const char *hwmsg) { @@ -53,11 +53,11 @@ static void qib_format_hwmsg(char *msg, size_t msgl, const char *hwmsg) /** * qib_format_hwerrors - format hardware error messages for display - * @hwerrs hardware errors bit vector - * @hwerrmsgs hardware error descriptions - * @nhwerrmsgs number of hwerrmsgs - * @msg message buffer - * @msgl message buffer length + * @hwerrs: hardware errors bit vector + * @hwerrmsgs: hardware error descriptions + * @nhwerrmsgs: number of hwerrmsgs + * @msg: message buffer + * @msgl: message buffer length */ void qib_format_hwerrors(u64 hwerrs, const struct qib_hwerror_msgs *hwerrmsgs, size_t nhwerrmsgs, char *msg, size_t msgl) From patchwork Thu Jan 21 09:45:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12037317 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98A74C43381 for ; Thu, 21 Jan 2021 18:08:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6459423A57 for ; Thu, 21 Jan 2021 18:08:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728933AbhAUSIr (ORCPT ); Thu, 21 Jan 2021 13:08:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728929AbhAUJrQ (ORCPT ); Thu, 21 Jan 2021 04:47:16 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EADF1C0617A4 for ; Thu, 21 Jan 2021 01:45:36 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id b5so1045015wrr.10 for ; Thu, 21 Jan 2021 01:45:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+U4mrC++Zc7DzOaX+UA+V8TmeVUrNgtzJDFj+ktzZpk=; b=PpcpLUCI8JAqZ90E8GXMAq61yVjGvXox3pYJ+xZEdJvD8c57FtkSfToVQV8ZjeBQZV G19ZMGVHpTdvsHPqu6bdBFZKnTRYm6qUT5u+vziJ+EiHEr3ZtrAnzJajzrlh9JFJxA3E 83tUcqhYNdMLkraUc8rTpU8VLToHUOufcfmK2ybgW1YKDU20QKZfuw8A8eZWBjEV/Toa x9pf4nqG1YBqxvxNkJpVghJnbAUcgCrz5h7hZYj5p/Z4ZPXb+soznPL7divA+S96jNL/ PswucHZaAgffXgpU7FSw9K0Swzo4ogms0x4z8vSSkJ7WAE7E1tUcAvgf4uk6aAr41OFw m+YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+U4mrC++Zc7DzOaX+UA+V8TmeVUrNgtzJDFj+ktzZpk=; b=f6mCIJQHhDic66eQ6CZVaIjMaEFtNuS3+E4TVeUkFUAvfrsf5LAKcLauxcWNVSe+bk G8pukmtw4Zr7DNIaAoX1IvJYW2v4SKeAskt4kFjSut2fo+ljlGz1+uQ+CL1yTC2mwT7a +yJXy2l7GlPubOt1j2y8yL0zZ+H5CRr7LecV3i/q9nws4GB7MQmaYTeB/zredcK25rHD pdpF9e2HgV0GWAErfDkx6BVQEcTW5SZmr48s0ahoU7P6caj8ioYysr0GAgCxiAfuKxGE xWl7a5jVtcsSdrtYszYc/S1+i1Ujdo6af5C8v4xZh0zU2hMcBtuZkV27ADk8atbxI5Yk D49A== X-Gm-Message-State: AOAM531/9sbHotJiT+ZefPdVWKOu6L5NYEMBd3vA7flXSshY3+BitcG5 GT58spO2S5O9DJlQ9ZR7lEmj6w== X-Google-Smtp-Source: ABdhPJz+fQlPuqpwnk3hk0kAqFuHWbYZZm4MdB7twAYGtL9sNJfY0qTHF9sHJOtEFZosaTs+gsLqWw== X-Received: by 2002:a5d:61ca:: with SMTP id q10mr13499186wrv.124.1611222335687; Thu, 21 Jan 2021 01:45:35 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:35 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 11/30] RDMA/hw/qib/qib_pcie: Demote obvious kernel-doc abuse Date: Thu, 21 Jan 2021 09:45:00 +0000 Message-Id: <20210121094519.2044049-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/qib/qib_pcie.c:190: warning: Function parameter or member 'dd' not described in 'qib_cache_msi_info' drivers/infiniband/hw/qib/qib_pcie.c:190: warning: Function parameter or member 'pos' not described in 'qib_cache_msi_info' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/qib/qib_pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/qib/qib_pcie.c b/drivers/infiniband/hw/qib/qib_pcie.c index 2e07b3749b880..cb2a02d671e2b 100644 --- a/drivers/infiniband/hw/qib/qib_pcie.c +++ b/drivers/infiniband/hw/qib/qib_pcie.c @@ -181,7 +181,7 @@ void qib_pcie_ddcleanup(struct qib_devdata *dd) pci_set_drvdata(dd->pcidev, NULL); } -/** +/* * We save the msi lo and hi values, so we can restore them after * chip reset (the kernel PCI infrastructure doesn't yet handle that * correctly. From patchwork Thu Jan 21 09:45:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12037363 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B117EC433E0 for ; Thu, 21 Jan 2021 18:46:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E87A230F9 for ; Thu, 21 Jan 2021 18:46:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728347AbhAUSOf (ORCPT ); Thu, 21 Jan 2021 13:14:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728882AbhAUJq6 (ORCPT ); Thu, 21 Jan 2021 04:46:58 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C71EC0617A5 for ; Thu, 21 Jan 2021 01:45:38 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id m187so865528wme.2 for ; Thu, 21 Jan 2021 01:45:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xZmdccX9MGdQfCu47xZuIw29j2db84mzV6TEw0Hxm3I=; b=RXfEMISkApvJA3X8uCs1LCUOrsUFhPeyVfGlOQ7pkh0y9c0OQtWMFY/1CVEcHPSqat 3GSqPm9O5g1z103zHmOT7fJFBQNPeOBaSXKuZD2NV3gFgHz8uCSltK3r57ymgacA/idU WiQf5hMPEdMHo+Xa4y0fodRgwRouN95oO7A5Tkbkul8dHYsH8nbLL6EKg9e4Bxlmlfq2 sn7thzyeTQg2xtSa8SP6cHPwtZPMwWd2T91gOQ6T9a8FUW1AHXufYUsJuD4g0B0/SNVk Z67DfPrDKMzZPyKTLOL9bwugDCOBCKu6zj0FL9mGx2rtRS9zKhrHhvots0tg13UKMNtD gWyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xZmdccX9MGdQfCu47xZuIw29j2db84mzV6TEw0Hxm3I=; b=qAPm2BSUTvGd6/Qd42ZtIUkW4PNwy7O2hacS7KkhenT9DHPZYj0BV65/8Mlztyz7/x wlecNCfipmuQES4CgGWcpGno2SOHjLlyWggtG2GKDF5iiP/Lf5qZ8hGNF6tQtv2SucdF l79qYOXSuwz77+toq5GKQZFmQV9I+AB6Z3QxyIW4SpI88vmNyfbZxt9gKtdCasiFnBEi XSPB5FwIYCMxHICJb6QzCdrdzs/r7JF2j/Itrak9w8KHTzBhfwHCK14ffUsWOG0KP6Mx +iK9PzUkbh8LgOPl+KP52W9z3Eqb2Q9Rfssul9sRDKhhtseEvPrTy8ZescWONmrS3JW+ wW8g== X-Gm-Message-State: AOAM533f7fhbWEddAov2J1iQAj0i6n4vgzoYDuqRaVHHj5AqG0ieF4e3 uIH0p40HcXRMEjGQZ9Ji238pDg== X-Google-Smtp-Source: ABdhPJyAV7xhFxtJvC8XZkrUWqxRc4o0L7r1xhjv7Hyp1oRpOtfmdbBFOgAUHJAmaBtH3a1xElKFkw== X-Received: by 2002:a7b:c5c7:: with SMTP id n7mr8085626wmk.140.1611222336896; Thu, 21 Jan 2021 01:45:36 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:36 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 12/30] RDMA/hw/qib/qib_qp: Fix some issues in worthy kernel-doc headers and demote another Date: Thu, 21 Jan 2021 09:45:01 +0000 Message-Id: <20210121094519.2044049-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/qib/qib_qp.c:214: warning: Function parameter or member 'rdi' not described in 'qib_free_all_qps' drivers/infiniband/hw/qib/qib_qp.c:387: warning: Function parameter or member 'qp' not described in 'qib_check_send_wqe' drivers/infiniband/hw/qib/qib_qp.c:387: warning: Function parameter or member 'wqe' not described in 'qib_check_send_wqe' drivers/infiniband/hw/qib/qib_qp.c:387: warning: Function parameter or member 'call_send' not described in 'qib_check_send_wqe' drivers/infiniband/hw/qib/qib_qp.c:425: warning: Function parameter or member 's' not described in 'qib_qp_iter_print' drivers/infiniband/hw/qib/qib_qp.c:425: warning: Function parameter or member 'iter' not described in 'qib_qp_iter_print' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/qib/qib_qp.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_qp.c b/drivers/infiniband/hw/qib/qib_qp.c index 8d0563ef5be17..ca39a029e4af8 100644 --- a/drivers/infiniband/hw/qib/qib_qp.c +++ b/drivers/infiniband/hw/qib/qib_qp.c @@ -207,7 +207,7 @@ int qib_alloc_qpn(struct rvt_dev_info *rdi, struct rvt_qpn_table *qpt, return ret; } -/** +/* * qib_free_all_qps - check for QPs still in use */ unsigned qib_free_all_qps(struct rvt_dev_info *rdi) @@ -376,9 +376,9 @@ void qib_flush_qp_waiters(struct rvt_qp *qp) /** * qib_check_send_wqe - validate wr/wqe - * @qp - The qp - * @wqe - The built wqe - * @call_send - Determine if the send should be posted or scheduled + * @qp: The qp + * @wqe: The built wqe + * @call_send: Determine if the send should be posted or scheduled * * Returns 0 on success, -EINVAL on failure */ @@ -418,8 +418,8 @@ static const char * const qp_type_str[] = { /** * qib_qp_iter_print - print information to seq_file - * @s - the seq_file - * @iter - the iterator + * @s: the seq_file + * @iter: the iterator */ void qib_qp_iter_print(struct seq_file *s, struct rvt_qp_iter *iter) { From patchwork Thu Jan 21 09:45:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12037361 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60702C433E9 for ; Thu, 21 Jan 2021 18:46:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D8F423A61 for ; Thu, 21 Jan 2021 18:46:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728379AbhAUSOk (ORCPT ); Thu, 21 Jan 2021 13:14:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728883AbhAUJq6 (ORCPT ); Thu, 21 Jan 2021 04:46:58 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BC5EC0617A7 for ; Thu, 21 Jan 2021 01:45:39 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id m2so868170wmm.1 for ; Thu, 21 Jan 2021 01:45:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gI++tdaotzFTWEtFjrYrQT/ATa/OhK5Kbs3X5CYZOEc=; b=wa7rs05ZwLBVT4NrU+//IeE7VH3Bh3P6pjXr71eZRYaojm7cni7eR6qIKC6+S7Sdn/ +nR2KQCzecZ+0l5Tl3kZau/YAQzQhV57imwyLBZgiLA1kVZ+WcuBGOi0JQSAuoMapdYc StW3HN8o6FzCblly+f76yNmoBGUtmPCBs4w2ekNGXwYQCwI+0bvaWNBy5aPpnjCn0O7i YQtmzvh/PVgOtNfVAmnMaRDDEQxct2EALmN2tAdpiCkrAJ/RqogsZZoSWKzA+iD4O+Jb 2LbYxcERfUalti9kbBk3AoJKbjSJYczMfjFrPCtx1Nge6Ufw6eBC5266soosPs/R00ur jyHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gI++tdaotzFTWEtFjrYrQT/ATa/OhK5Kbs3X5CYZOEc=; b=RWNRkSJqzuMAMxgQjBAne0vC12tQ1CpA7VG12sd3MUFh3Eb/9T0tycaLhKUoyv8NsN IrQGNTcmm7mAh+6Zc1zcnhIukW6zA49ZZo701khW2/kXU4S2KkJcwXFHtM3D6+mp13rY kmd1hGpxsL+6Y4kOegVX/Fik2hr8IQbQWwL3juS2hZaVZYINYticwuspBp7aS0qjIpRE xuQk41Qis+jinDAK/4ZEX2pwMiVJ5vHb34qFDJnB5OVc+/fZvdaWc8BGkEdqejzo6a0V 0eNfJZuSOWqNKouMIxf/+d3W6moHRtTrwo6XfeYdBB+phxukd4KMObLaIfFAcoKzzJtz QD/g== X-Gm-Message-State: AOAM530h1hM30j0plNbnHKDroX2Ta9tshzVc70OtxqOHUN51ZVkfMCZD 3pDA54pB6p3ndg2QrkJCl/akKVoqKqc/DY91 X-Google-Smtp-Source: ABdhPJzLcptrzIXNQrmi7mv457uOgJ6M3AFulTuDrWnc7HhdLM8ljD4lIdvVhdmnjj0x3SreZ5nBbw== X-Received: by 2002:a1c:b1d7:: with SMTP id a206mr8101992wmf.88.1611222338036; Thu, 21 Jan 2021 01:45:38 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:37 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 13/30] RDMA/sw/rdmavt/cq: Demote hardly complete kernel-doc header Date: Thu, 21 Jan 2021 09:45:02 +0000 Message-Id: <20210121094519.2044049-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/sw/rdmavt/cq.c:381: warning: Function parameter or member 'cqe' not described in 'rvt_resize_cq' drivers/infiniband/sw/rdmavt/cq.c:381: warning: Function parameter or member 'udata' not described in 'rvt_resize_cq' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/sw/rdmavt/cq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/sw/rdmavt/cq.c b/drivers/infiniband/sw/rdmavt/cq.c index 20cc0799ac4bc..5138afca067f6 100644 --- a/drivers/infiniband/sw/rdmavt/cq.c +++ b/drivers/infiniband/sw/rdmavt/cq.c @@ -371,7 +371,7 @@ int rvt_req_notify_cq(struct ib_cq *ibcq, enum ib_cq_notify_flags notify_flags) return ret; } -/** +/* * rvt_resize_cq - change the size of the CQ * @ibcq: the completion queue * From patchwork Thu Jan 21 09:45:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12035373 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A40D5C433E6 for ; Thu, 21 Jan 2021 09:47:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F12A235DD for ; Thu, 21 Jan 2021 09:47:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728873AbhAUJrE (ORCPT ); Thu, 21 Jan 2021 04:47:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728889AbhAUJq6 (ORCPT ); Thu, 21 Jan 2021 04:46:58 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC9B1C0617AA for ; Thu, 21 Jan 2021 01:45:40 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id v15so1060151wrx.4 for ; Thu, 21 Jan 2021 01:45:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l5TP7SOW2qS+epdcMI5v0wC0XhSdnGQZ2H2fkGXdgtw=; b=GHgcG5XwW3b1jiCm5xGS6W9EwgGh2Ytv30roeEV7x4YCdpXWj5wk2VYAFaBBtG30iG cEkBNIoUlCFw0OnJXTjq45+lkursH/CjoS2fGHGeYAfF8XqY6aDuAxZH9MD1VXPR7ycs XletK79gfIi2IZn4t6/4aEPNmzHAHlGvyyQm4BQCsFp4r+/d92YWdkBBIk+/XrM88bud /NV+jJDE1VNWDU27m3wyt96ZIsoNvK8MsOWrkLhkCaamaRtOhznSDJy0ox374zwt7Ydp XK0HlyUwbRq5ol8VjxQmj6gDqIhkwNDwj9mSiRrhfHgDas70bhu1j6l9L6kekyUvbdYi FxcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l5TP7SOW2qS+epdcMI5v0wC0XhSdnGQZ2H2fkGXdgtw=; b=C3yLERrESm149y1yvzsNnZ2tznDkaWBUmp1bZjNEuoGgAvmpIO0W26rxNNwmGko1Z/ lgH7o1rqNJxWBw8eyrqnQ0r3c4XkL0grOeoHxUpcUyvExaTJdi2JKlrBTDbNtxonY9Kj AHH5Tpy3sFt8HrKEdIqQ+lxkH2XTdQyQqzALP5UlCfvqgyDs3aC9hHxP/A2CFHKuMxry mEiOaHcLGzSzWMO0c8y1SUbO+dxPAfOPjUbYYEhUOL729AjSJcsr/WBLZnX9NMuFKTtB RwhlnvAb1dQtcGVkc43RKP+4D0rNYxi8BvhzO27cqMVryj7w2TcVxbVnIylxY2mo/cd5 11Hw== X-Gm-Message-State: AOAM5328xUiVRe2Brhxxnd2Mcck2UfXCLQjumjODzaCwraG88IsL51iK cvu0kHBxGyilm2cr8SXZKSlJcQ== X-Google-Smtp-Source: ABdhPJyw5JGcIev6YI1r4Oogk+Z/zXtt6cDAcLCzW8hq8pf6WIY4/7B0GzBugt0neuEHI5VHfZpryg== X-Received: by 2002:adf:f512:: with SMTP id q18mr1959752wro.55.1611222339429; Thu, 21 Jan 2021 01:45:39 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:38 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 14/30] RDMA/hw/qib/qib_rc: Fix some worthy kernel-docs demote hardly complete one Date: Thu, 21 Jan 2021 09:45:03 +0000 Message-Id: <20210121094519.2044049-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/qib/qib_rc.c:216: warning: Function parameter or member 'flags' not described in 'qib_make_rc_req' drivers/infiniband/hw/qib/qib_rc.c:1008: warning: Function parameter or member 'aeth' not described in 'do_rc_ack' drivers/infiniband/hw/qib/qib_rc.c:1008: warning: Function parameter or member 'val' not described in 'do_rc_ack' drivers/infiniband/hw/qib/qib_rc.c:1008: warning: Function parameter or member 'rcd' not described in 'do_rc_ack' drivers/infiniband/hw/qib/qib_rc.c:1274: warning: Function parameter or member 'rcd' not described in 'qib_rc_rcv_resp' drivers/infiniband/hw/qib/qib_rc.c:1497: warning: Function parameter or member 'rcd' not described in 'qib_rc_rcv_error' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/qib/qib_rc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/qib/qib_rc.c b/drivers/infiniband/hw/qib/qib_rc.c index 3915e5b4a9bc1..a1c20ffb44903 100644 --- a/drivers/infiniband/hw/qib/qib_rc.c +++ b/drivers/infiniband/hw/qib/qib_rc.c @@ -207,6 +207,7 @@ static int qib_make_rc_ack(struct qib_ibdev *dev, struct rvt_qp *qp, /** * qib_make_rc_req - construct a request packet (SEND, RDMA r/w, ATOMIC) * @qp: a pointer to the QP + * @flags: unused * * Assumes the s_lock is held. * @@ -992,7 +993,7 @@ static struct rvt_swqe *do_rc_completion(struct rvt_qp *qp, return wqe; } -/** +/* * do_rc_ack - process an incoming RC ACK * @qp: the QP the ACK came in on * @psn: the packet sequence number of the ACK @@ -1259,6 +1260,7 @@ static void rdma_seq_err(struct rvt_qp *qp, struct qib_ibport *ibp, u32 psn, * @psn: the packet sequence number for this packet * @hdrsize: the header length * @pmtu: the path MTU + * @rcd: the context pointer * * This is called from qib_rc_rcv() to process an incoming RC response * packet for the given QP. @@ -1480,6 +1482,7 @@ static void qib_rc_rcv_resp(struct qib_ibport *ibp, * @opcode: the opcode for this packet * @psn: the packet sequence number for this packet * @diff: the difference between the PSN and the expected PSN + * @rcd: the context pointer * * This is called from qib_rc_rcv() to process an unexpected * incoming RC packet for the given QP. From patchwork Thu Jan 21 09:45:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12037319 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86693C433E9 for ; Thu, 21 Jan 2021 18:10:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34B9C23A58 for ; Thu, 21 Jan 2021 18:10:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389711AbhAUSJD (ORCPT ); Thu, 21 Jan 2021 13:09:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728915AbhAUJrD (ORCPT ); Thu, 21 Jan 2021 04:47:03 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35B34C0617B1 for ; Thu, 21 Jan 2021 01:45:42 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id j18so863905wmi.3 for ; Thu, 21 Jan 2021 01:45:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Yuu62i1MBy9SgGgF6TOSTSpWnyQgtFShBFPCZ/OtBLI=; b=MSpN0+4ssxyWwH66+DWlGkTjuTZll+0WUdcSDzB6T243qvcOwnmsLaKL8Sml9maeuM X85N+7xCyj4+8PLYsLWyWHxXfo5IKyuOYIZ4PWqbsDXCR2Lkpu8EFjPNB25Nfpp+Zunb cEQ4gVGGfiBCAw8gKJg1hlHXTal3tsCjJmzEBy3tu30C0NkK6OHriMeKFo5V8McOiXpe K2YPBpyfbLj0MlKdsk8xg0yhkAT7e/o9RXa9ZV1ABwm414i2TqWrZPXpKTvH2NQb2jFa Z8wfIA/nAeJj2R4c0afxAfVnFZQkM4mea3bX1xA8AnGjRIGgOVGYgiGaGUVaXGBZvvLy Euxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Yuu62i1MBy9SgGgF6TOSTSpWnyQgtFShBFPCZ/OtBLI=; b=sde5P3fXxWXxSU9B7HZOsaDzXPOZlY/S1eEx0VK5NgRsKa4X+1IUqI4GrcqijmXcUn XK2vBKuKq6Zse/DM9ZGw944edouuMq8exFGmQqbn5ZvcARUzkbUWmiXBeX6z76gMFOqg /XWQtiu0OfJ4vgCOXqqXa3uOw8vbI8MqneENPOGCG2yWAlqJ3u4KFfR37tMy9kwXDc3j HNgvLXi6bm1j9BkEYZuozyjz+x305OjmNmVAKCYjWmRPeB9T6MIWZsabBbWLaD4KQWk7 13DUttd8KBwful+aBH4MorpR52yzH8wV1/e2o4trVHTbJmiAdriNlojk4Up7bEiisr9X +pIg== X-Gm-Message-State: AOAM533VAil73j6Qpix8yIOAPyQa0pgGJRmSFzME6TxLiZyys6orlNap muYruJO2T7twYEAt7CPF3kj1fQ== X-Google-Smtp-Source: ABdhPJy2+pEZbsc3edarPA/SdsrT2nL1kPb+R9JDLvOpCmbcIPB0Pg9BGHsVy3WFlkqQdaQRBs0BtQ== X-Received: by 2002:a7b:c306:: with SMTP id k6mr8096769wmj.52.1611222340975; Thu, 21 Jan 2021 01:45:40 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:40 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 15/30] RDMA/hw/hfi1/chip: Fix a bunch of kernel-doc formatting and spelling issues Date: Thu, 21 Jan 2021 09:45:04 +0000 Message-Id: <20210121094519.2044049-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hfi1/chip.c:1335: warning: Function parameter or member 'dd' not described in 'hfi1_addr_from_offset' drivers/infiniband/hw/hfi1/chip.c:1335: warning: Function parameter or member 'offset' not described in 'hfi1_addr_from_offset' drivers/infiniband/hw/hfi1/chip.c:1350: warning: Function parameter or member 'dd' not described in 'read_csr' drivers/infiniband/hw/hfi1/chip.c:1350: warning: Function parameter or member 'offset' not described in 'read_csr' drivers/infiniband/hw/hfi1/chip.c:1363: warning: Function parameter or member 'dd' not described in 'write_csr' drivers/infiniband/hw/hfi1/chip.c:1363: warning: Function parameter or member 'offset' not described in 'write_csr' drivers/infiniband/hw/hfi1/chip.c:1363: warning: Function parameter or member 'value' not described in 'write_csr' drivers/infiniband/hw/hfi1/chip.c:1385: warning: Function parameter or member 'dd' not described in 'get_csr_addr' drivers/infiniband/hw/hfi1/chip.c:1385: warning: Function parameter or member 'offset' not described in 'get_csr_addr' drivers/infiniband/hw/hfi1/chip.c:8442: warning: Function parameter or member 'rcd' not described in 'receive_interrupt_common' drivers/infiniband/hw/hfi1/chip.c:8491: warning: Function parameter or member 'napi' not described in 'hfi1_netdev_rx_napi' drivers/infiniband/hw/hfi1/chip.c:8491: warning: Function parameter or member 'budget' not described in 'hfi1_netdev_rx_napi' drivers/infiniband/hw/hfi1/chip.c:14221: warning: Function parameter or member 'dd' not described in 'init_qpmap_table' drivers/infiniband/hw/hfi1/chip.c:14221: warning: Function parameter or member 'first_ctxt' not described in 'init_qpmap_table' drivers/infiniband/hw/hfi1/chip.c:14221: warning: Function parameter or member 'last_ctxt' not described in 'init_qpmap_table' drivers/infiniband/hw/hfi1/chip.c:14399: warning: Function parameter or member 'dd' not described in 'init_qos' drivers/infiniband/hw/hfi1/chip.c:14399: warning: Function parameter or member 'rmt' not described in 'init_qos' drivers/infiniband/hw/hfi1/chip.c:15032: warning: Function parameter or member 'dd' not described in 'hfi1_init_dd' drivers/infiniband/hw/hfi1/chip.c:15032: warning: Excess function parameter 'dev' description in 'hfi1_init_dd' drivers/infiniband/hw/hfi1/chip.c:15032: warning: Excess function parameter 'ent' description in 'hfi1_init_dd' drivers/infiniband/hw/hfi1/chip.c:15395: warning: Function parameter or member 'ppd' not described in 'create_pbc' drivers/infiniband/hw/hfi1/chip.c:15395: warning: Function parameter or member 'srate_mbs' not described in 'create_pbc' drivers/infiniband/hw/hfi1/chip.c:15395: warning: Function parameter or member 'dw_len' not described in 'create_pbc' drivers/infiniband/hw/hfi1/chip.c:15395: warning: Excess function parameter 'srate' description in 'create_pbc' drivers/infiniband/hw/hfi1/chip.c:15395: warning: Excess function parameter 'dwlen' description in 'create_pbc' Cc: Mike Marciniszyn Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hfi1/chip.c | 46 +++++++++++++++---------------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/chip.c b/drivers/infiniband/hw/hfi1/chip.c index c87b94ea29397..993cbf37e0b9e 100644 --- a/drivers/infiniband/hw/hfi1/chip.c +++ b/drivers/infiniband/hw/hfi1/chip.c @@ -1323,8 +1323,8 @@ CNTR_ELEM(#name, \ /** * hfi_addr_from_offset - return addr for readq/writeq - * @dd - the dd device - * @offset - the offset of the CSR within bar0 + * @dd: the dd device + * @offset: the offset of the CSR within bar0 * * This routine selects the appropriate base address * based on the indicated offset. @@ -1340,8 +1340,8 @@ static inline void __iomem *hfi1_addr_from_offset( /** * read_csr - read CSR at the indicated offset - * @dd - the dd device - * @offset - the offset of the CSR within bar0 + * @dd: the dd device + * @offset: the offset of the CSR within bar0 * * Return: the value read or all FF's if there * is no mapping @@ -1355,9 +1355,9 @@ u64 read_csr(const struct hfi1_devdata *dd, u32 offset) /** * write_csr - write CSR at the indicated offset - * @dd - the dd device - * @offset - the offset of the CSR within bar0 - * @value - value to write + * @dd: the dd device + * @offset: the offset of the CSR within bar0 + * @value: value to write */ void write_csr(const struct hfi1_devdata *dd, u32 offset, u64 value) { @@ -1373,8 +1373,8 @@ void write_csr(const struct hfi1_devdata *dd, u32 offset, u64 value) /** * get_csr_addr - return te iomem address for offset - * @dd - the dd device - * @offset - the offset of the CSR within bar0 + * @dd: the dd device + * @offset: the offset of the CSR within bar0 * * Return: The iomem address to use in subsequent * writeq/readq operations. @@ -8433,7 +8433,7 @@ static inline int check_packet_present(struct hfi1_ctxtdata *rcd) return hfi1_rcd_head(rcd) != tail; } -/** +/* * Common code for receive contexts interrupt handlers. * Update traces, increment kernel IRQ counter and * setup ASPM when needed. @@ -8447,7 +8447,7 @@ static void receive_interrupt_common(struct hfi1_ctxtdata *rcd) aspm_ctx_disable(rcd); } -/** +/* * __hfi1_rcd_eoi_intr() - Make HW issue receive interrupt * when there are packets present in the queue. When calling * with interrupts enabled please use hfi1_rcd_eoi_intr. @@ -8484,8 +8484,8 @@ static void hfi1_rcd_eoi_intr(struct hfi1_ctxtdata *rcd) /** * hfi1_netdev_rx_napi - napi poll function to move eoi inline - * @napi - pointer to napi object - * @budget - netdev budget + * @napi: pointer to napi object + * @budget: netdev budget */ int hfi1_netdev_rx_napi(struct napi_struct *napi, int budget) { @@ -10142,7 +10142,7 @@ u32 lrh_max_header_bytes(struct hfi1_devdata *dd) /* * Set Send Length - * @ppd - per port data + * @ppd: per port data * * Set the MTU by limiting how many DWs may be sent. The SendLenCheck* * registers compare against LRH.PktLen, so use the max bytes included @@ -14200,9 +14200,9 @@ u8 hfi1_get_qp_map(struct hfi1_devdata *dd, u8 idx) /** * init_qpmap_table - * @dd - device data - * @first_ctxt - first context - * @last_ctxt - first context + * @dd: device data + * @first_ctxt: first context + * @last_ctxt: first context * * This return sets the qpn mapping table that * is indexed by qpn[8:1]. @@ -14383,8 +14383,8 @@ static int qos_rmt_entries(struct hfi1_devdata *dd, unsigned int *mp, /** * init_qos - init RX qos - * @dd - device data - * @rmt - RSM map table + * @dd: device data + * @rmt: RSM map table * * This routine initializes Rule 0 and the RSM map table to implement * quality of service (qos). @@ -15022,8 +15022,7 @@ static int check_int_registers(struct hfi1_devdata *dd) /** * hfi1_init_dd() - Initialize most of the dd structure. - * @dev: the pci_dev for hfi1_ib device - * @ent: pci_device_id struct for this dev + * @dd: the dd device * * This is global, and is called directly at init to set up the * chip-specific function pointers for later use. @@ -15378,10 +15377,11 @@ static u16 delay_cycles(struct hfi1_pportdata *ppd, u32 desired_egress_rate, /** * create_pbc - build a pbc for transmission + * @ppd: info of physical Hfi port * @flags: special case flags or-ed in built pbc - * @srate: static rate + * @srate_mbs: static rate * @vl: vl - * @dwlen: dword length (header words + data words + pbc words) + * @dw_len: dword length (header words + data words + pbc words) * * Create a PBC with the given flags, rate, VL, and length. * From patchwork Thu Jan 21 09:45:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12035377 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E8D6C433DB for ; Thu, 21 Jan 2021 09:48:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFB61235DD for ; Thu, 21 Jan 2021 09:47:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728969AbhAUJrf (ORCPT ); Thu, 21 Jan 2021 04:47:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728954AbhAUJr3 (ORCPT ); Thu, 21 Jan 2021 04:47:29 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2F9CC0617B9 for ; Thu, 21 Jan 2021 01:45:43 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id q7so1036127wre.13 for ; Thu, 21 Jan 2021 01:45:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p4lWsX1/HMWo9e2h+pWPHWU7/13R9cTAE/+8ZINfLr8=; b=ScRTv9wJ+i/WWqoj5qdXsAVNJgIefZzJ7qKjwF3BXsDzblOmxnzAyBC9JYi1rNS5jH CKZczGXBrR/G63fNlKwXytTljWa8Lqi8dLYjFF710lzxfm1S5GwiVWt5HRMaMpvi5SDJ SC1Nc0fdBor+jNndu1vuhXYY42tH8qbbaTSjw8K+ZWuWqD9D/BBnW7I1u5S/ykBwKUmZ sQie9KA1cXarCU35luoIzbQNiRdDFOswnSE0gQYKrNah6+i0tKpPgVDnPK64pWpsIBwp ZwUtuEoqx5+48c5EIPpff1msG781IGPZiFh2p15nyH5/AEmPtaZjw/B3ph339hVjXK4D mJSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p4lWsX1/HMWo9e2h+pWPHWU7/13R9cTAE/+8ZINfLr8=; b=Mons7vtLdK5gwx5JDpNlxTrj4Xi9ugEY4EWoVvPONrwCMptpNHJE/r9yGIV8PGeaCX pNw97Pg7XbN1yGcLadAX2gcgFRMCjPFmClYMKmFuHxbtLtopQ4vSF2ZedUUunJS1k2E8 LTw8KxiEFzCLpmFBIYWjKfePFQHAogK8BMaRiWnGCgIDYHB0Jw2gCr/LuB2Hhm4x6T7v mxFwbz0cBEVOzpPjqOjyvWOfo19WPBYLgX4kCECIpIE2OiDek+XhHmejC5xNzi1IcdXC c5Ppxx/hQtH+gUf99CvmnnSMQY9ztFCZ6uCH06dvX1o0kVjUtWU1dXUHbn8xyOaWpg6L Dudw== X-Gm-Message-State: AOAM5336btbBV6Gj+UvpxWTkwjbgruEyRsBkTrLG4kNBK7HYLQx+fCnf KQ0kyH2mx+WT8FV/FX21PFL71A== X-Google-Smtp-Source: ABdhPJyEfsOYnrJQ5QY9vXKSK3jdn1xNP/R9pYUB3pJz4ZQIRAiHBZc3WYoVE2GOJnaVWPnTJ+/5CA== X-Received: by 2002:adf:ee90:: with SMTP id b16mr13298698wro.221.1611222342589; Thu, 21 Jan 2021 01:45:42 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:41 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 16/30] RDMA/hw/qib/qib_twsi: Provide description for missing param 'last' Date: Thu, 21 Jan 2021 09:45:05 +0000 Message-Id: <20210121094519.2044049-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/qib/qib_twsi.c:175: warning: Function parameter or member 'last' not described in 'rd_byte' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/qib/qib_twsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/qib/qib_twsi.c b/drivers/infiniband/hw/qib/qib_twsi.c index f5698664419b4..97b8a2bf5c696 100644 --- a/drivers/infiniband/hw/qib/qib_twsi.c +++ b/drivers/infiniband/hw/qib/qib_twsi.c @@ -168,6 +168,7 @@ static void stop_cmd(struct qib_devdata *dd); /** * rd_byte - read a byte, sending STOP on last, else ACK * @dd: the qlogic_ib device + * @last: identifies the last read * * Returns byte shifted out of device */ From patchwork Thu Jan 21 09:45:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12037313 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FBF8C433DB for ; Thu, 21 Jan 2021 18:08:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B767F23A22 for ; Thu, 21 Jan 2021 18:08:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728936AbhAUSHW (ORCPT ); Thu, 21 Jan 2021 13:07:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728932AbhAUJrQ (ORCPT ); Thu, 21 Jan 2021 04:47:16 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5434C0617BC for ; Thu, 21 Jan 2021 01:45:45 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id 7so1076050wrz.0 for ; Thu, 21 Jan 2021 01:45:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bQj9Yz0LsqxFRbs970izNlVd0TnTgiu7VPZTWgmuulQ=; b=hm9y9/U251qJnd1mNpICdUnfsUijKIs0K8BN6Sxq6UmgDsd0Ncwa8J50V0M35XwoRc pQ3Kl7ovk4sfJxgy0/1xk/r4SS7x9npQ+aAtgfU4ySGCvjgrSrMpcWrRT7DUw7ykli1P mRF7+fxkl1S6FODlz2He88YQ8nodQAAR14XRMlcoyJAjZXeGphGEnXfDFiXvlaMaPrx9 Ntmk6/StXCD+3q3hJ96dXv/zpX3Dv1nGN9ulokXpLLf5GxXGaZYjYftCt8+jE+HgdFh8 KZXdjDd3x7vJsGhzyeg4+WwujH4vnHt/XU344ATGeobEekKSyTjE/GCPIGLgMifGA9KU bRew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bQj9Yz0LsqxFRbs970izNlVd0TnTgiu7VPZTWgmuulQ=; b=P5C9FBUKcEblEXPoXsExQfGrS8NaiZTmVLYzwDEB4Il82UZjAYBcfMBfOSwuoNUE/z iYX16N6y5l2wUJ0Z7qzOSTQE5VkRrrt4oOcbFS+CNmC37Ds3rU3rjede67/Tp5+hqQYr OAtcYB+K2fhQwLEJvAxo68I1Qp5Fd45JuwWTQs5vs7Q9NZZfnq1lg6hilbl8eu36T/DM +Pq/MZyWuF17vkDx4aV+QiL+L3abJ27em2v4iJkOZeRczML6OXWBr+cpU7QZSHryjz+j 6w9rnHxsX4GCO5aokJpfbmpmTpIoByMBt7GITYfKKoRA54/oB7ASUv8aFrtJwQsPz6Wq JwVw== X-Gm-Message-State: AOAM532Z7wx442c2JTiKIdbNNMZQ+T1fBNPv4fdCPa4zPwi4m2BhHukG uroksLE6PM8APx2lWF1Wr+AdoQ== X-Google-Smtp-Source: ABdhPJyFMznrk9mjmBUMiZvtOK9aG393nTPehjVw8PPdCM3jpKQ/UvucvDGqnqPYKjf5weOAXCOwJA== X-Received: by 2002:adf:efc5:: with SMTP id i5mr13033790wrp.377.1611222344559; Thu, 21 Jan 2021 01:45:44 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:43 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 17/30] RDMA/hw/qib/qib_tx: Provide description for 'qib_chg_pioavailkernel()'s 'rcd' param Date: Thu, 21 Jan 2021 09:45:06 +0000 Message-Id: <20210121094519.2044049-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/qib/qib_tx.c:383: warning: Function parameter or member 'rcd' not described in 'qib_chg_pioavailkernel' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/qib/qib_tx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/qib/qib_tx.c b/drivers/infiniband/hw/qib/qib_tx.c index 29785eb846469..6a8148851f21d 100644 --- a/drivers/infiniband/hw/qib/qib_tx.c +++ b/drivers/infiniband/hw/qib/qib_tx.c @@ -377,6 +377,7 @@ void qib_sendbuf_done(struct qib_devdata *dd, unsigned n) * @start: the starting send buffer number * @len: the number of send buffers * @avail: true if the buffers are available for kernel use, false otherwise + * @rcd: the context pointer */ void qib_chg_pioavailkernel(struct qib_devdata *dd, unsigned start, unsigned len, u32 avail, struct qib_ctxtdata *rcd) From patchwork Thu Jan 21 09:45:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12037315 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8711AC433E9 for ; Thu, 21 Jan 2021 18:08:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 383A123A69 for ; Thu, 21 Jan 2021 18:08:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731858AbhAUSIm (ORCPT ); Thu, 21 Jan 2021 13:08:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728933AbhAUJrQ (ORCPT ); Thu, 21 Jan 2021 04:47:16 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9BC0C0617BD for ; Thu, 21 Jan 2021 01:45:46 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id a9so1055445wrt.5 for ; Thu, 21 Jan 2021 01:45:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BeYhM/gH7brge1QkCSipQ9tBDSDjW9MlS8bPaE7B1A8=; b=s9i6jxDv4DkGnMgES+kvI+EHj5xw6cQL4eG5xYhN4oM1HkzqyoYJV0Ao0jFg8JOYEw aZnw1pTt3BZXyFRP0+K0nifWKcv58QfF4O1GuVXA4VZL4Qq7M+IwDwnIHHII3uNGXRO/ GfXnfPhRJbp1mzdCsNgM63dXcTBQToZIjd9vxbEx1YzHHLkX/BQOkg0+1QpnsKBaIOKP LpNZygecWRovslicC8zBYIVSOtYBFyBInuyEQG7h/DOTiQEL+tL6cDYPoZMY8ZD7l5gf Mm7zcCeK4pXqwsN2NSQEBqpOoP509zpHNux4USeBfMkbJr5WruIdeSDbopcUDPC5A8J/ BiaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BeYhM/gH7brge1QkCSipQ9tBDSDjW9MlS8bPaE7B1A8=; b=I+/nLYmEgcQrHPuo5VI1F+jDXRIBMQ0Wchd4r+6ctlOO5GIC7FzhZT96BUTRZXtCmC AiNOo2UpILyhMnp6z/E4cy9sbNQSAwz3+jaKsy2usdnAEAjH+ff7GJDdaOv8dptIthCl C320mhc/loE5+DUq5AO/0Bob8wZMTuiCwVWCcyNso+/aNdXY/m5+XDiy7uzJrdpqhVy7 RkeYsjrao6mI+S9AYIRGaPMw+s7fWa41z6NYCUXwmSUOTtmc1cK21BRF+fi+xroqJ5Od xaXlERgBPnFfZx3WPwWrxScHWaT0kATo7EnxNHj7kQiVBu9cAW3GhVJwkKOieXDLfcVR WdRg== X-Gm-Message-State: AOAM532o1/FJ3OECp5wbxHMe/KnAZ/RQ3SbtQocPTNy99AYPUYyT7zHO /CgUUgb06NJ4y3MW88seET4Zeg== X-Google-Smtp-Source: ABdhPJxQDZ4TDz20U4Hz/CUPoBCqpHFrj1gif6aIbNNCTV3hySivt6MTDBAN20GqXnEtYA3PqrHfYg== X-Received: by 2002:adf:f684:: with SMTP id v4mr13529216wrp.387.1611222345752; Thu, 21 Jan 2021 01:45:45 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:45 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 18/30] RDMA/hw/qib/qib_uc: Provide description for missing 'flags' param Date: Thu, 21 Jan 2021 09:45:07 +0000 Message-Id: <20210121094519.2044049-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/qib/qib_uc.c:49: warning: Function parameter or member 'flags' not described in 'qib_make_uc_req' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/qib/qib_uc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/qib/qib_uc.c b/drivers/infiniband/hw/qib/qib_uc.c index 554af4273a131..8e2bda77d8b9c 100644 --- a/drivers/infiniband/hw/qib/qib_uc.c +++ b/drivers/infiniband/hw/qib/qib_uc.c @@ -40,6 +40,7 @@ /** * qib_make_uc_req - construct a request packet (SEND, RDMA write) * @qp: a pointer to the QP + * @flags: unused * * Assumes the s_lock is held. * From patchwork Thu Jan 21 09:45:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12037311 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4481C4332E for ; Thu, 21 Jan 2021 18:07:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA30F23A5A for ; Thu, 21 Jan 2021 18:07:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389106AbhAUSHW (ORCPT ); Thu, 21 Jan 2021 13:07:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728936AbhAUJrT (ORCPT ); Thu, 21 Jan 2021 04:47:19 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16238C061381 for ; Thu, 21 Jan 2021 01:45:48 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id v184so939866wma.1 for ; Thu, 21 Jan 2021 01:45:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XmIU7Hx0pkyEcx/3o0WhDyQYZMQPyc4u6z7mHc/BEGk=; b=W2U5NYMURcYEfi5ItscagZ3XbR3KUn3NejODcNDGd9GGFAGN4o0zTppEo4rhafYLWe SuwBlJ5zK6okyN6LB/V9uNfTiOab6kqx/F/L9QfeFs+eK6+vvGjf5Jda5pjGBNSK82sG zFQZ0E/w2S4Rlxrj5fv39FuyF73iO9TMOQinfRlNUWHvkQzwk8HKSYhbQ56OZh2Ogp4J 86zRyke2tfC6+10MvbrkxzKE4GYQ+otnmNRHkK2GZmNG3BixJ/kO2Qi/s0Bhft+v8IDU Fpr73Od7A7Jme+kP+n7KyJR5FhMIRkaLPQpplv17ancvFLioyeASK8wc9JK2KJyozTbH eyqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XmIU7Hx0pkyEcx/3o0WhDyQYZMQPyc4u6z7mHc/BEGk=; b=COqtqo8uhy5P3Jx1Fsx+64pfpBP2D08fVpOr//axq5uOkFamIH3uS6V6AK8dTqkO1V TqsrIcRleT5UnVESlC0UlZVLcvkRHrE6CuGRrppdoeVQTOkZJ0Q/ARSGO+V+arxvNyaR StxSIFeClIxE6iPUI+mxlQ09SrbpNcRs/TQTe5/oH65CTy/XHmUEqT4zYHOANMJEuVTo EYVfj8sgLQ5ZHfKZ7HOl/qBV58+tau/5pIUDj9B77Uw5zEItaH/tena8leSLjrpaxJCn 0dCQcePp41ptOeJD3+BifHsagFIEdcnvThQmR2yTWHcCc0Lb3Knsqa6doXguJpKAPym5 qz0Q== X-Gm-Message-State: AOAM532vcehgy9moRef0rYBoRy136VoPjtaICdxYFiwWm8V+gJhr23lD eb6Z0MnJL+r5KWeiLGA5i3QCtg== X-Google-Smtp-Source: ABdhPJxz48wWMCXURTZGOMFkGBBixGQ0C0+9Ej4xgco1ek+rzYnYc+5272A+DPVgnMKnuIZf3tC7jw== X-Received: by 2002:a05:600c:2249:: with SMTP id a9mr8318923wmm.169.1611222346891; Thu, 21 Jan 2021 01:45:46 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:46 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 19/30] RDMA/hw/qib/qib_ud: Provide description for 'qib_make_ud_req's 'flags' param Date: Thu, 21 Jan 2021 09:45:08 +0000 Message-Id: <20210121094519.2044049-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/qib/qib_ud.c:231: warning: Function parameter or member 'flags' not described in 'qib_make_ud_req' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/qib/qib_ud.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/qib/qib_ud.c b/drivers/infiniband/hw/qib/qib_ud.c index 93ca21347959f..81eda94bd2799 100644 --- a/drivers/infiniband/hw/qib/qib_ud.c +++ b/drivers/infiniband/hw/qib/qib_ud.c @@ -222,6 +222,7 @@ static void qib_ud_loopback(struct rvt_qp *sqp, struct rvt_swqe *swqe) /** * qib_make_ud_req - construct a UD request packet * @qp: the QP + * @flags: flags to modify and pass back to caller * * Assumes the s_lock is held. * From patchwork Thu Jan 21 09:45:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12036153 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07150C433E0 for ; Thu, 21 Jan 2021 13:19:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD5B223A01 for ; Thu, 21 Jan 2021 13:19:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728942AbhAUK24 (ORCPT ); Thu, 21 Jan 2021 05:28:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728948AbhAUJr3 (ORCPT ); Thu, 21 Jan 2021 04:47:29 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5733DC061382 for ; Thu, 21 Jan 2021 01:45:49 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id l12so1069042wry.2 for ; Thu, 21 Jan 2021 01:45:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sN+lfIF9Ruac5w+3RJGLplih0Ni1e9QoQ7rC6Jmgsbs=; b=hMoksjVQLU5nEHu9W9aY8QUD6u3DDph2ZjVE8VQjUyMtfH/lCdBJB2JYHH/OkZgvp+ i2p2r37+btE9jabrt1F/n3hcnuTvJt2jCFNblRusd3sg7XhTiXEogYb0lkzT5bwv01d9 c1A7EoWZPrOtIDi0v5sEJBzhLQOKBMOloWxu6rv6RH6WIfmtZqLzHHx3ekxt04EVYgZK CZO2/Gvm6TUPWjQKXuL5CgWVedFQqaai1awC7Y3JjqFf3kQyk34sUumbRzGRg0QdzemP cMFpCFdT6VM/QBcfzWciTxkGeitEqrqVxrI9vKK4LyN3aU4Ef7p2t+cx1wQ9OgP9mlDw ihMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sN+lfIF9Ruac5w+3RJGLplih0Ni1e9QoQ7rC6Jmgsbs=; b=CCAylnaF5jNVm9Wq/PDWKnzO0uBh8K8eiDSqzmHq9Fe77t7mnTL9SnVfXmiHnYunew UrTOfd8IFpwfIPui/RzPaqslF3Ya67AUDXBnMt9Yn23bLAfwfk1oUHbNCWEhtGY8F7uT t98of/skgACihqxAug9rIyFDSK7rlCZDt+upec2xfjQiqArsG4xAvFTIfGofm12uT6Gj BftoyCyYxMi4oOSDG87Pwf4ZO+hkIIggh0bFvA8ypOtS3x1OJ1ouQI5H7uRq6zVAt0WF Dg1l57bUgucdEMlm62Wmz1aA6G0vR8UJQKdcj4NkqofeMlmf4VDPVpJmAQUr4Vt0072h i7Ng== X-Gm-Message-State: AOAM5333N7Ed/+z+4RlnGkCO7uNVhb2vok9dIVA90sH2xFC+aO5GwtrS cCc0qVNO7wAhBnxcKYKECaChew== X-Google-Smtp-Source: ABdhPJwBvadl37HLosjSDHe2pRSFbd8z9UuT5CPM5/vCOZPZTmF5U2ApYFZYsdLzgTJ1HHIMICFbhA== X-Received: by 2002:adf:e705:: with SMTP id c5mr12995825wrm.303.1611222348084; Thu, 21 Jan 2021 01:45:48 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:47 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 20/30] RDMA/sw/rdmavt/mad: Fix 'rvt_process_mad()'s documentation header Date: Thu, 21 Jan 2021 09:45:09 +0000 Message-Id: <20210121094519.2044049-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/sw/rdmavt/mad.c:75: warning: Function parameter or member 'in' not described in 'rvt_process_mad' drivers/infiniband/sw/rdmavt/mad.c:75: warning: Function parameter or member 'in_mad_size' not described in 'rvt_process_mad' drivers/infiniband/sw/rdmavt/mad.c:75: warning: Function parameter or member 'out' not described in 'rvt_process_mad' drivers/infiniband/sw/rdmavt/mad.c:75: warning: Function parameter or member 'out_mad_size' not described in 'rvt_process_mad' drivers/infiniband/sw/rdmavt/mad.c:75: warning: Function parameter or member 'out_mad_pkey_index' not described in 'rvt_process_mad' drivers/infiniband/sw/rdmavt/mad.c:75: warning: Excess function parameter 'in_mad' description in 'rvt_process_mad' drivers/infiniband/sw/rdmavt/mad.c:75: warning: Excess function parameter 'out_mad' description in 'rvt_process_mad' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/sw/rdmavt/mad.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/sw/rdmavt/mad.c b/drivers/infiniband/sw/rdmavt/mad.c index 108c71e3ac233..8cc4de9aa6644 100644 --- a/drivers/infiniband/sw/rdmavt/mad.c +++ b/drivers/infiniband/sw/rdmavt/mad.c @@ -56,8 +56,11 @@ * @port_num: the port number this packet came in on, 1 based from ib core * @in_wc: the work completion entry for this packet * @in_grh: the global route header for this packet - * @in_mad: the incoming MAD - * @out_mad: any outgoing MAD reply + * @in: the incoming MAD + * @out_mad_size: size of the incoming MAD reply + * @out: any outgoing MAD reply + * @out_mad_size: size of the outgoing MAD reply + * @out_mad_pkey_index: unused * * Note that the verbs framework has already done the MAD sanity checks, * and hop count/pointer updating for IB_MGMT_CLASS_SUBN_DIRECTED_ROUTE From patchwork Thu Jan 21 09:45:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12035507 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FE48C433DB for ; Thu, 21 Jan 2021 10:29:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E0D7204EF for ; Thu, 21 Jan 2021 10:29:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728803AbhAUK2q (ORCPT ); Thu, 21 Jan 2021 05:28:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728942AbhAUJrX (ORCPT ); Thu, 21 Jan 2021 04:47:23 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DC33C061385 for ; Thu, 21 Jan 2021 01:45:50 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id v15so1060596wrx.4 for ; Thu, 21 Jan 2021 01:45:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q4kMSsAHr6rPwePPe9GLokWhKQx3zqto7WVpZ/I6tzo=; b=fAM8b8n5WWLc5D9TMzPl5yev6ZUXT1KUpdBUyeatcBeABXWK/wVvW/XHTCmcN6T93+ hslAQP9sDCW7uRl1EuF4vOSZaR9uXksbbpTUVkOm7+oTk+3vlSAsRHHcIWLp89WghyL7 bKWoF+fLrnjoPAJYTfip5++bLkyurCIsDwpPug0WvmVQLUlJ+KnKozM+PYhcmGwOotCp 55H3vtwrqMvoV1O75xsOg7W45E5fLPq8uzFgOXD9pYGCwve/9eo35FASq7QaS5kJwkuj bztRTszYbo8Z2EYZtm16+KmIdWpai+T5QrhcsChqkfH52y4gNrjJlfBR+FbSbid9yTWF GWsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q4kMSsAHr6rPwePPe9GLokWhKQx3zqto7WVpZ/I6tzo=; b=NYh17iPslwX0TvbdNYDfkuU5vW4Y2AIuWq7kEzqGkYxFauGPZucJ6DrbsvSO30s8/H 2M1VQEZlEm22Vmng419nSKTJvyzB/oB3LDgVtzYKNRk2lP769+3xxjGoHjrloxGynv1z HlyrMfjQp0lZgYaWTKvg4LkaJHXTkcwomDSlgrzo5+q47D6bZkX4glqQCmHE8okPmUqs 2MgpiSzk5P2pNHBULrGYsvTqKJvchjp5sWJtVynz/ZkbF63FCGy2L/2Mh+t0tUBfudQA Qv/xMFaszt83KChGxAxsA1iiSw5j2VTUPW2aB1C6B6MN5Pm6kJ4wSqadzLvxmpdUsvVS bkPw== X-Gm-Message-State: AOAM533rzWvj9GttZ/aCJ1ynNDcQLz1UUUINjqEk+Y1lckGwxsQrQDN1 AAR4tyt5FD0dWF30e8cx+/7DSA== X-Google-Smtp-Source: ABdhPJzTTMwSDYFOzdJ/1Jrdc93C45YqhRaj0x+Mn3bYqzQ7mVNkSyBRiZwG3Y/p3e2Hq2Wnm+YPvA== X-Received: by 2002:a5d:6749:: with SMTP id l9mr13439374wrw.395.1611222349332; Thu, 21 Jan 2021 01:45:49 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:48 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 21/30] RDMA/hw/qib/qib_user_pages: Demote non-conformant documentation header Date: Thu, 21 Jan 2021 09:45:10 +0000 Message-Id: <20210121094519.2044049-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/qib/qib_user_pages.c:60: warning: Function parameter or member 'hwdev' not described in 'qib_map_page' drivers/infiniband/hw/qib/qib_user_pages.c:60: warning: Function parameter or member 'page' not described in 'qib_map_page' drivers/infiniband/hw/qib/qib_user_pages.c:60: warning: Function parameter or member 'daddr' not described in 'qib_map_page' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/qib/qib_user_pages.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/qib/qib_user_pages.c b/drivers/infiniband/hw/qib/qib_user_pages.c index 4c24e83f31752..5d6cf7427431b 100644 --- a/drivers/infiniband/hw/qib/qib_user_pages.c +++ b/drivers/infiniband/hw/qib/qib_user_pages.c @@ -43,7 +43,7 @@ static void __qib_release_user_pages(struct page **p, size_t num_pages, unpin_user_pages_dirty_lock(p, num_pages, dirty); } -/** +/* * qib_map_page - a safety wrapper around pci_map_page() * * A dma_addr of all 0's is interpreted by the chip as "disabled". From patchwork Thu Jan 21 09:45:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12035427 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8218CC433E0 for ; Thu, 21 Jan 2021 10:06:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42950239A1 for ; Thu, 21 Jan 2021 10:06:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728814AbhAUJru (ORCPT ); Thu, 21 Jan 2021 04:47:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728951AbhAUJr3 (ORCPT ); Thu, 21 Jan 2021 04:47:29 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4C81C061387 for ; Thu, 21 Jan 2021 01:45:51 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id a12so1051155wrv.8 for ; Thu, 21 Jan 2021 01:45:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mYxGBsvkYUdjpbxW8TKZG60qwkP74ogfKinwU5RJVJA=; b=EooXLJ4bOpjkR5CtIpeQZ2w6CNSMVbTuRRhXL64htl1YGJ2pycdRJiXyrsWpncl3j7 1lqqQPLJDOLGsfWV8sS6CzMuBamqOSSe+eYRZxLp5vocSwE+qCZJEP0tlIq5Dr0Gyu+X P9B1geDhwj4Kt685ercxvfWYQEdj1I7rc9kpleUh7eBIcoPcwICVvDTRvZMT10y9vcrx yabwINV1l91iZ0qPchPcQiEdaSK3R19fd2Psjabgm8LlVuyTHup9NYDkWOxfjl4dIMpJ BTvVJczl30cydx+craf8EnfkIseI2FWTXs51KLoN7a4M2RE14bNBj7WksaqxRvpvdT9l pq5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mYxGBsvkYUdjpbxW8TKZG60qwkP74ogfKinwU5RJVJA=; b=l3jFLOn5viHZB0ES3J4Wm//52WnLI9BUFmYQcCocYYhuvckUa6u4zpXMIM/l4U820d cf670ezsGxKPdeePzmbsZ3nWeGq5yiWATmdYj8JBbslzPMDAemZTtWSnBRwvy1DsF7b4 tCjXUGMCZuVEO56/FPcYzWRjJIro5UjsGk5jKDPZzO/Em+v1NQIKCejKgEmAPtEKUIsZ TijQOCFefTyvjc6X8knRifPanvEEnCIItw1Cmrn/7i2Jkq4yJsTSWeUcw3qGQm3hHREj o9NlzHfO9zA8KxIxTZKf1cdLS1rpZ5B0+vyfrJSNUO7uiIRHJiq+VbssgKwgxoRExZj3 f3JA== X-Gm-Message-State: AOAM531kJyhkH6Co/XWDZoiSntTXwx1zRGyf9afbBAsCP5PA9R19rxPY svA9juwoMVSUKOhTaP+g5qdw7g== X-Google-Smtp-Source: ABdhPJyo43uNNkEn2GWYNHsQer8mv01MlSt6TGU3/jQ6NIDMP2IdH2ZrYuTrOCRPHz8tGaN+VlSxtg== X-Received: by 2002:adf:a319:: with SMTP id c25mr13595220wrb.262.1611222350474; Thu, 21 Jan 2021 01:45:50 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:49 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 22/30] RDMA/sw/rdmavt/mcast: Demote incomplete kernel-doc header Date: Thu, 21 Jan 2021 09:45:11 +0000 Message-Id: <20210121094519.2044049-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/sw/rdmavt/mcast.c:195: warning: Function parameter or member 'rdi' not described in 'rvt_mcast_add' drivers/infiniband/sw/rdmavt/mcast.c:195: warning: Function parameter or member 'ibp' not described in 'rvt_mcast_add' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/sw/rdmavt/mcast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/sw/rdmavt/mcast.c b/drivers/infiniband/sw/rdmavt/mcast.c index 5233a63d99a65..951abac13dbb4 100644 --- a/drivers/infiniband/sw/rdmavt/mcast.c +++ b/drivers/infiniband/sw/rdmavt/mcast.c @@ -180,7 +180,7 @@ struct rvt_mcast *rvt_mcast_find(struct rvt_ibport *ibp, union ib_gid *mgid, } EXPORT_SYMBOL(rvt_mcast_find); -/** +/* * rvt_mcast_add - insert mcast GID into table and attach QP struct * @mcast: the mcast GID table * @mqp: the QP to attach From patchwork Thu Jan 21 09:45:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12035505 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0FEEC433DB for ; Thu, 21 Jan 2021 10:28:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8ECA2204EF for ; Thu, 21 Jan 2021 10:28:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728976AbhAUJrl (ORCPT ); Thu, 21 Jan 2021 04:47:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728952AbhAUJr3 (ORCPT ); Thu, 21 Jan 2021 04:47:29 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC19AC061388 for ; Thu, 21 Jan 2021 01:45:52 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id j18so864336wmi.3 for ; Thu, 21 Jan 2021 01:45:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vJDsuEDRVCvcahYEPrkVEeJePqFypDnKwf1mJL7+9Q4=; b=k+KPDF1sMPR9MbWSWGLgTX1n2t/pUJJtovIraWlWFZqiHEZGXR6Obr9cr+SUOGFlwI yf1DHrs8J5H1y6UvVrIe2ld8T3+1hBE2m7/3pIdiO8x8WQlLwIbgLIunMiGMnaQc9OWU YRyMxwhMmMmsEBHuM3LFLtHRXxPkZXuLKz5vC+obZaLg3S0PEo52stMPYADifh3/jooR vC5IT8S4bSTTHyob8QosD7oHsNEwKFtSG/oCA8AgQPn5LWqXBOlbiw0r6D92gWOY9hXg ISJMK+8LWR4VBd/Pa/3Y/mOgtLnQp3JgsHCb/GNeud+3s7yVxYb8VFnlFfGFG/Fx4Uze W13g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vJDsuEDRVCvcahYEPrkVEeJePqFypDnKwf1mJL7+9Q4=; b=Y7xNDJwO10eaG+We4s/r5XQwTBvvtZ45Ce3gpMTfr23KMnXlgpLyCl/5+m4n7H7wUF Hj2gthA5Z5mT+t/fUw2RYlEtEwd0c4nnYt3e+zvXDa7fc2XadXV+bcf6lST8FQAlit1S p/y/p7BlziMFX7UyD4na/+w2NkPviOyVxg8nnde487UL8D+KesvibYPX6Rv143NBkbbg EXLg9hR+jVpc6iNCPTBpEEImk/ZXpLOb/jOWj71S2+kVn5LpK8pO7RxrnIYX6Fg9p0sN y/Drs+SyXfWoZuSmVJcyxkWHOQJe46yt/OlYdQZXqPbWK7iWQs3cbct3TNi0vHDBzgjs 2dVg== X-Gm-Message-State: AOAM532UwdwQY8dAp8fyZxEhmd0Pv5J9Y3cKeOlrSCc9jyDKlB98fTWf /vU1lQaRcy63IyXniWW8rbpjpQ== X-Google-Smtp-Source: ABdhPJxs8JBbfjEoWD2z25WVRMknXxxD8R3+0bCNorKJSqYd63qAxbJP0AwnRloQ+9RveG8OpPFyxQ== X-Received: by 2002:a1c:5686:: with SMTP id k128mr6996635wmb.189.1611222351717; Thu, 21 Jan 2021 01:45:51 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:51 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 23/30] RDMA/hw/hfi1/exp_rcv: Fix some kernel-doc formatting issues Date: Thu, 21 Jan 2021 09:45:12 +0000 Message-Id: <20210121094519.2044049-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hfi1/exp_rcv.c:56: warning: Function parameter or member 'set' not described in 'hfi1_exp_tid_set_init' drivers/infiniband/hw/hfi1/exp_rcv.c:66: warning: Function parameter or member 'rcd' not described in 'hfi1_exp_tid_group_init' drivers/infiniband/hw/hfi1/exp_rcv.c:77: warning: Function parameter or member 'rcd' not described in 'hfi1_alloc_ctxt_rcv_groups' drivers/infiniband/hw/hfi1/exp_rcv.c:114: warning: Function parameter or member 'rcd' not described in 'hfi1_free_ctxt_rcv_groups' Cc: Mike Marciniszyn Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hfi1/exp_rcv.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/exp_rcv.c b/drivers/infiniband/hw/hfi1/exp_rcv.c index e9d5cc8b771a2..91f13140ddf21 100644 --- a/drivers/infiniband/hw/hfi1/exp_rcv.c +++ b/drivers/infiniband/hw/hfi1/exp_rcv.c @@ -50,7 +50,7 @@ /** * exp_tid_group_init - initialize exp_tid_set - * @set - the set + * @set: the set */ static void hfi1_exp_tid_set_init(struct exp_tid_set *set) { @@ -60,7 +60,7 @@ static void hfi1_exp_tid_set_init(struct exp_tid_set *set) /** * hfi1_exp_tid_group_init - initialize rcd expected receive - * @rcd - the rcd + * @rcd: the rcd */ void hfi1_exp_tid_group_init(struct hfi1_ctxtdata *rcd) { @@ -71,7 +71,7 @@ void hfi1_exp_tid_group_init(struct hfi1_ctxtdata *rcd) /** * alloc_ctxt_rcv_groups - initialize expected receive groups - * @rcd - the context to add the groupings to + * @rcd: the context to add the groupings to */ int hfi1_alloc_ctxt_rcv_groups(struct hfi1_ctxtdata *rcd) { @@ -101,7 +101,7 @@ int hfi1_alloc_ctxt_rcv_groups(struct hfi1_ctxtdata *rcd) /** * free_ctxt_rcv_groups - free expected receive groups - * @rcd - the context to free + * @rcd: the context to free * * The routine dismantles the expect receive linked * list and clears any tids associated with the receive From patchwork Thu Jan 21 09:45:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12035471 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51824C433E6 for ; Thu, 21 Jan 2021 10:19:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1822A221F8 for ; Thu, 21 Jan 2021 10:19:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728784AbhAUKTP (ORCPT ); Thu, 21 Jan 2021 05:19:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728954AbhAUJrl (ORCPT ); Thu, 21 Jan 2021 04:47:41 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57C95C06138A for ; Thu, 21 Jan 2021 01:45:54 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id v15so1060780wrx.4 for ; Thu, 21 Jan 2021 01:45:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1PUI6ltCF6UYEL6FQ111TDKZz1F/sP23xV8l8xivz1A=; b=zEgaTqVGy6l3GlqsBT2B6w3UmLi9VdmgcuZ1Aif/smB5SejrYguy/EhRvkFTpwVAg+ 9zw4fOC3y7NCBZfyf/3gl2bHJng3gUB/l2hbsar1curQKlCiBjdzUeorZ4o4iOYzSqb1 oV3d8USZ9iGC5E2xr7nDWT/Uatu6o9l4tdRg2KJ+xST77UcPtawNO75xyj/Q/zs2a52S hacMnIABZgNjU6vGl5mgo7F2wwg/asggYjvU2N/NIhttzzczKPFx0BPH+KtB11/8lGEx RArBi7wsW6GRIDrRoivmPA0HYDG6EGnGWMFflKq09KRZDSilHPS+Gnj2lNtsF7vRPSnf EjGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1PUI6ltCF6UYEL6FQ111TDKZz1F/sP23xV8l8xivz1A=; b=fof6CL4LVfxqWJVOAb+oePi4t4hLMGKnPde3G4ZxCW7mmtZw0C9VkMhhsJ6bcU54Fd ygOTE/hJKdEK6evy4Mt0Iqw0aML3f8tuLrAQT7mNZeIOOXi0jsL4AqWDzl2TbW/PcY9B ZDao/RKTB0g3/0nk4D+kBInPcja3sFnXIzX6wiByC7z2OKoh1722VZqf2mDWrfh/QOlo rAApiBk7D3XL6nemZBHxnALhrgdCU3f9NStPD+k/WNS91SrhCN5CLx2vOjzOGQL7g4rf UQamc1PE7gDrgN3DShfV4ZZ8sI45tVtDMl/HjlOyvKhhjSU2ksvVWB6AyLHWWzR7IaGu N6jg== X-Gm-Message-State: AOAM530rn3CgXwRdg7B0zGxy9UE58jw4Rdvr0nO4klNXTe95Hi/VjAar vC5brpN/KkH7sbhZ7AoNKuRXNA== X-Google-Smtp-Source: ABdhPJwbluN9S+sVEAB25VBXJCdu2Vzynmm1+2Tz3m+RMP9VEKts2YjjQAXfTYK4YVq7o4lWA2nNQg== X-Received: by 2002:a05:6000:1362:: with SMTP id q2mr10421159wrz.341.1611222353050; Thu, 21 Jan 2021 01:45:53 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:52 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 24/30] RDMA/hw/qib/qib_iba7220: Fix some kernel-doc issues Date: Thu, 21 Jan 2021 09:45:13 +0000 Message-Id: <20210121094519.2044049-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/qib/qib_iba7220.c:1726: warning: Function parameter or member 'ppd' not described in 'qib_setup_7220_setextled' drivers/infiniband/hw/qib/qib_iba7220.c:1726: warning: Excess function parameter 'dd' description in 'qib_setup_7220_setextled' drivers/infiniband/hw/qib/qib_iba7220.c:2154: warning: Function parameter or member 'type' not described in 'qib_7220_put_tid' drivers/infiniband/hw/qib/qib_iba7220.c:2154: warning: Excess function parameter 'tidtype' description in 'qib_7220_put_tid' drivers/infiniband/hw/qib/qib_iba7220.c:2192: warning: Function parameter or member 'rcd' not described in 'qib_7220_clear_tids' drivers/infiniband/hw/qib/qib_iba7220.c:2192: warning: Excess function parameter 'ctxt' description in 'qib_7220_clear_tids' drivers/infiniband/hw/qib/qib_iba7220.c:2248: warning: Function parameter or member 'kinfo' not described in 'qib_7220_get_base_info' drivers/infiniband/hw/qib/qib_iba7220.c:2248: warning: Excess function parameter 'kbase' description in 'qib_7220_get_base_info' drivers/infiniband/hw/qib/qib_iba7220.c:2903: warning: Function parameter or member 'ppd' not described in 'qib_portcntr_7220' drivers/infiniband/hw/qib/qib_iba7220.c:2903: warning: Function parameter or member 'reg' not described in 'qib_portcntr_7220' drivers/infiniband/hw/qib/qib_iba7220.c:2903: warning: Excess function parameter 'dd' description in 'qib_portcntr_7220' drivers/infiniband/hw/qib/qib_iba7220.c:2903: warning: Excess function parameter 'creg' description in 'qib_portcntr_7220' drivers/infiniband/hw/qib/qib_iba7220.c:3242: warning: Function parameter or member 't' not described in 'qib_get_7220_faststats' drivers/infiniband/hw/qib/qib_iba7220.c:4479: warning: Function parameter or member 'pdev' not described in 'qib_init_iba7220_funcs' drivers/infiniband/hw/qib/qib_iba7220.c:4479: warning: Excess function parameter 'dev' description in 'qib_init_iba7220_funcs' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/qib/qib_iba7220.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_iba7220.c b/drivers/infiniband/hw/qib/qib_iba7220.c index 0a6f26d4cb310..229dcd6ead95b 100644 --- a/drivers/infiniband/hw/qib/qib_iba7220.c +++ b/drivers/infiniband/hw/qib/qib_iba7220.c @@ -1701,7 +1701,7 @@ static void qib_7220_quiet_serdes(struct qib_pportdata *ppd) /** * qib_setup_7220_setextled - set the state of the two external LEDs - * @dd: the qlogic_ib device + * @ppd: the qlogic_ib device * @on: whether the link is up or not * * The exact combo of LEDs if on is true is determined by looking @@ -2146,7 +2146,7 @@ static int qib_setup_7220_reset(struct qib_devdata *dd) * qib_7220_put_tid - write a TID to the chip * @dd: the qlogic_ib device * @tidptr: pointer to the expected TID (in chip) to update - * @tidtype: 0 for eager, 1 for expected + * @type: 0 for eager, 1 for expected * @pa: physical address of in memory buffer; tidinvalid if freeing */ static void qib_7220_put_tid(struct qib_devdata *dd, u64 __iomem *tidptr, @@ -2180,7 +2180,7 @@ static void qib_7220_put_tid(struct qib_devdata *dd, u64 __iomem *tidptr, /** * qib_7220_clear_tids - clear all TID entries for a ctxt, expected and eager * @dd: the qlogic_ib device - * @ctxt: the ctxt + * @rcd: the ctxt * * clear all TID entries for a ctxt, expected and eager. * Used from qib_close(). On this chip, TIDs are only 32 bits, @@ -2238,7 +2238,7 @@ static void qib_7220_tidtemplate(struct qib_devdata *dd) /** * qib_init_7220_get_base_info - set chip-specific flags for user code * @rcd: the qlogic_ib ctxt - * @kbase: qib_base_info pointer + * @kinfo: qib_base_info pointer * * We set the PCIE flag because the lower bandwidth on PCIe vs * HyperTransport can affect some user packet algorithims. @@ -2896,8 +2896,8 @@ static void sendctrl_7220_mod(struct qib_pportdata *ppd, u32 op) /** * qib_portcntr_7220 - read a per-port counter - * @dd: the qlogic_ib device - * @creg: the counter to snapshot + * @ppd: the qlogic_ib device + * @reg: the counter to snapshot */ static u64 qib_portcntr_7220(struct qib_pportdata *ppd, u32 reg) { @@ -3232,7 +3232,7 @@ static u32 qib_read_7220portcntrs(struct qib_devdata *dd, loff_t pos, u32 port, /** * qib_get_7220_faststats - get word counters from chip before they overflow - * @opaque - contains a pointer to the qlogic_ib device qib_devdata + * @t: contains a pointer to the qlogic_ib device qib_devdata * * This needs more work; in particular, decision on whether we really * need traffic_wds done the way it is @@ -4468,7 +4468,7 @@ static int qib_7220_eeprom_wen(struct qib_devdata *dd, int wen) /** * qib_init_iba7220_funcs - set up the chip-specific function pointers - * @dev: the pci_dev for qlogic_ib device + * @pdev: the pci_dev for qlogic_ib device * @ent: pci_device_id struct for this dev * * This is global, and is called directly at init to set up the From patchwork Thu Jan 21 09:45:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12035455 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91CA3C433DB for ; Thu, 21 Jan 2021 10:16:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42DF6239EB for ; Thu, 21 Jan 2021 10:16:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729005AbhAUKQX (ORCPT ); Thu, 21 Jan 2021 05:16:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728981AbhAUJro (ORCPT ); Thu, 21 Jan 2021 04:47:44 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0198C06138C for ; Thu, 21 Jan 2021 01:45:55 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id 7so1076499wrz.0 for ; Thu, 21 Jan 2021 01:45:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=swQmxPcitFGtHbQmdYPSgooCu5Sjk8enE4kIJ6+5AJE=; b=fecRIgXILzNrwrTxxAbVmd1570PYEAZKeg7sglhJhHb5QjD6XJgsfq+ZgcbmBcIofk g18+JJnN9SCz1IrzXVR/FeMVV1+uBdI99IpVxaHsOLMq7YnCN6uRxrr7so8LtzwtF/HL X0HBGbJosOpkLB9JuZgk5Q7U5ZwzLJY+aw851i5hCP2v66AWYNOlZAEXkM993jG2e3J5 Wxj+ONHYutXHum7m/XMbUfSqYv1jpINDBMdnARGBFaWBf/7vFg69AjmLivAv8Wbd4Wex +bVWMukxS6h6rCXGXfBbTqx+KcLBSjvtMFTJ2ZqzsjJtUQ/qIkGj01j1RYfuaGKR7KGV ilrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=swQmxPcitFGtHbQmdYPSgooCu5Sjk8enE4kIJ6+5AJE=; b=AESLMAuLGHnLGhYqysGqTbHrNSFNFx3FH7Iy5/Ad8ouNzsDYFECb0fTtlLgXhJi+P9 75wXtP4VOQ1iUTEXUlphBSsoadcaTrSCAiPlGkOrYTg7XgY7q1Dc1ISk4z+WPmtrZuaV wepJ3/3gaqvPZyZQ4I11yQRIPRpPOkoLDnpd3r2QIkG5R5h2kZWXZADpa8VRtSv5RScF 2Dkpvl8ZK2iCUTRWfW54QoR51RX3tjDzZs8zRf9P1VaQkvyJf3CN1i71TsxEAE1Hve5i l4SyrZV49NCXeXwyWo4TtuntX9IwvY9zl24MNIfgBnG28Y3qY8dMSogzZ8TWxiJF41WU ptmw== X-Gm-Message-State: AOAM531nR/bl0DXkX8+/goKytBlm4SYVOTljhqEzmEjBpB2xd5UbAqw8 qa2PYzFw1KCxBpPjBTFSlWN0aA== X-Google-Smtp-Source: ABdhPJyKmEtpnLm87Yke89vIYkTU6/mngH04AoIWw1YPaoXGMMVeoDdAt2Q2NYROHYNejb0Ugj9Low== X-Received: by 2002:adf:f7d2:: with SMTP id a18mr13127288wrq.47.1611222354435; Thu, 21 Jan 2021 01:45:54 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:53 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 25/30] RDMA/hw/hfi1/file_ops: Fix' manage_rcvq()'s 'arg' param Date: Thu, 21 Jan 2021 09:45:14 +0000 Message-Id: <20210121094519.2044049-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hfi1/file_ops.c:1533: warning: Function parameter or member 'arg' not described in 'manage_rcvq' drivers/infiniband/hw/hfi1/file_ops.c:1533: warning: Excess function parameter 'start_stop' description in 'manage_rcvq' Cc: Mike Marciniszyn Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hfi1/file_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/hfi1/file_ops.c b/drivers/infiniband/hw/hfi1/file_ops.c index 329ee4f48d957..3b7bbc7b9d105 100644 --- a/drivers/infiniband/hw/hfi1/file_ops.c +++ b/drivers/infiniband/hw/hfi1/file_ops.c @@ -1522,7 +1522,7 @@ int hfi1_set_uevent_bits(struct hfi1_pportdata *ppd, const int evtbit) * manage_rcvq - manage a context's receive queue * @uctxt: the context * @subctxt: the sub-context - * @start_stop: action to carry out + * @arg: start/stop action to carry out * * start_stop == 0 disables receive on the context, for use in queue * overflow conditions. start_stop==1 re-enables, to be used to From patchwork Thu Jan 21 09:45:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12035451 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67CB5C433E0 for ; Thu, 21 Jan 2021 10:15:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0594A239EB for ; Thu, 21 Jan 2021 10:15:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728685AbhAUKP2 (ORCPT ); Thu, 21 Jan 2021 05:15:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728987AbhAUJro (ORCPT ); Thu, 21 Jan 2021 04:47:44 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9F3AC06138E for ; Thu, 21 Jan 2021 01:45:56 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id a9so1055907wrt.5 for ; Thu, 21 Jan 2021 01:45:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/z56S/t3xQgupRDRVcqi9lXvNCrBWFO94RXqxT4CMuQ=; b=qL6bk2OfCaDqiV1dsjLrmXbE3eDhjXTa/paqFHpv6GVUOlLVqfE82X803aM219wIE2 UhkS7Ki0YMa7u4BMypzQfBrefVZRSPbJ5sZrSRU2OtValeT3N+LUIJHe85EQfwS5joSC yppbjdBD7Ld5/lsq07E/vIw02sn2+SwyjXAeEqoG6TrYUZvTOuX6xfcYgyalU6CSw1gL Va5A0Gn8FstqbqsA/m0uN9xDFHkX6y1vpUnFK/flTLvyTz2/x6xinjhZAZY6J5rZTAQH OWZXIH1CHqZkaRHfgFIcnsanU6jvg5wRF3ab6kZ9U7BbI0cnGT2clnDDDdcYVNliEL0b Q9mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/z56S/t3xQgupRDRVcqi9lXvNCrBWFO94RXqxT4CMuQ=; b=uQV6wdnQ2b2hT3zpgzivirpN0hWCPKMBPF7SfcwNaUBl1Tu0dqA26as+sO5iUyl2nA Ot18P70Zj3BMhyLqcrR+SYi6ZIi5yVerZwuAxI6BWRCus09AzC21iXnW2kvY9hDes2VM lgWmepKsCsAJWk105JWVLLeO6AJ7cGPVgZtU2UicJKumMt7Yp/bxT23+1cnbS45nQ8jL 8V1hyVOefHAfUx3ye5vCenVH+cDbxrGhUCPqBvQoHdOn//9X5opv0XKFUiJf9dT94gVa 0eZLQpMu/bqrOy+ts8kIJ6hLbPaFYi2aVYd1Q8zzI5tqkqzP2KQJkCCIJgWHWOv/QR7M h+SQ== X-Gm-Message-State: AOAM530+0aiJMKN2UII4uiLzLHDJuYC0jqq0QJ1fftuodbLGjOZFG6sQ 5Exv9d/msCA/MQ6tFPyz1bPsXQ== X-Google-Smtp-Source: ABdhPJxP9fP515TxSu/dojg5poCx1LFivE8imReVdPIJ84j5E6L788alyhlX1DaQIBkEcY7GUB3FMg== X-Received: by 2002:adf:e54a:: with SMTP id z10mr13580456wrm.1.1611222355700; Thu, 21 Jan 2021 01:45:55 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:55 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 26/30] RDMA/sw/rdmavt/mr: Fix some issues related to formatting and missing descriptions Date: Thu, 21 Jan 2021 09:45:15 +0000 Message-Id: <20210121094519.2044049-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/sw/rdmavt/mr.c:380: warning: Function parameter or member 'virt_addr' not described in 'rvt_reg_user_mr' drivers/infiniband/sw/rdmavt/mr.c:449: warning: Function parameter or member 'qp' not described in 'rvt_dereg_clean_qp_cb' drivers/infiniband/sw/rdmavt/mr.c:449: warning: Function parameter or member 'v' not described in 'rvt_dereg_clean_qp_cb' drivers/infiniband/sw/rdmavt/mr.c:466: warning: Function parameter or member 'mr' not described in 'rvt_dereg_clean_qps' drivers/infiniband/sw/rdmavt/mr.c:484: warning: Function parameter or member 'mr' not described in 'rvt_check_refs' drivers/infiniband/sw/rdmavt/mr.c:484: warning: Function parameter or member 't' not described in 'rvt_check_refs' drivers/infiniband/sw/rdmavt/mr.c:513: warning: Function parameter or member 'mr' not described in 'rvt_mr_has_lkey' drivers/infiniband/sw/rdmavt/mr.c:513: warning: Function parameter or member 'lkey' not described in 'rvt_mr_has_lkey' drivers/infiniband/sw/rdmavt/mr.c:526: warning: Function parameter or member 'ss' not described in 'rvt_ss_has_lkey' drivers/infiniband/sw/rdmavt/mr.c:526: warning: Function parameter or member 'lkey' not described in 'rvt_ss_has_lkey' drivers/infiniband/sw/rdmavt/mr.c:551: warning: Function parameter or member 'udata' not described in 'rvt_dereg_mr' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/sw/rdmavt/mr.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/infiniband/sw/rdmavt/mr.c b/drivers/infiniband/sw/rdmavt/mr.c index 90fc234f489ac..601d18dda1f5a 100644 --- a/drivers/infiniband/sw/rdmavt/mr.c +++ b/drivers/infiniband/sw/rdmavt/mr.c @@ -369,6 +369,7 @@ struct ib_mr *rvt_get_dma_mr(struct ib_pd *pd, int acc) * @pd: protection domain for this memory region * @start: starting userspace address * @length: length of region to register + * @virt_addr: associated virtual address * @mr_access_flags: access flags for this memory region * @udata: unused by the driver * @@ -438,8 +439,8 @@ struct ib_mr *rvt_reg_user_mr(struct ib_pd *pd, u64 start, u64 length, /** * rvt_dereg_clean_qp_cb - callback from iterator - * @qp - the qp - * @v - the mregion (as u64) + * @qp: the qp + * @v: the mregion (as u64) * * This routine fields the callback for all QPs and * for QPs in the same PD as the MR will call the @@ -457,7 +458,7 @@ static void rvt_dereg_clean_qp_cb(struct rvt_qp *qp, u64 v) /** * rvt_dereg_clean_qps - find QPs for reference cleanup - * @mr - the MR that is being deregistered + * @mr: the MR that is being deregistered * * This routine iterates RC QPs looking for references * to the lkey noted in mr. @@ -471,8 +472,8 @@ static void rvt_dereg_clean_qps(struct rvt_mregion *mr) /** * rvt_check_refs - check references - * @mr - the megion - * @t - the caller identification + * @mr: the megion + * @t: the caller identification * * This routine checks MRs holding a reference during * when being de-registered. @@ -506,8 +507,8 @@ static int rvt_check_refs(struct rvt_mregion *mr, const char *t) /** * rvt_mr_has_lkey - is MR - * @mr - the mregion - * @lkey - the lkey + * @mr: the mregion + * @lkey: the lkey */ bool rvt_mr_has_lkey(struct rvt_mregion *mr, u32 lkey) { @@ -516,8 +517,8 @@ bool rvt_mr_has_lkey(struct rvt_mregion *mr, u32 lkey) /** * rvt_ss_has_lkey - is mr in sge tests - * @ss - the sge state - * @lkey + * @ss: the sge state + * @lkey: the lkey * * This code tests for an MR in the indicated * sge state. @@ -540,7 +541,7 @@ bool rvt_ss_has_lkey(struct rvt_sge_state *ss, u32 lkey) /** * rvt_dereg_mr - unregister and free a memory region * @ibmr: the memory region to free - * + * @udata: unused by the driver * * Note that this is called to free MRs created by rvt_get_dma_mr() * or rvt_reg_user_mr(). From patchwork Thu Jan 21 09:45:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12035379 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BE34C433E0 for ; Thu, 21 Jan 2021 09:48:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 50BBE235DD for ; Thu, 21 Jan 2021 09:48:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729004AbhAUJsC (ORCPT ); Thu, 21 Jan 2021 04:48:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728984AbhAUJro (ORCPT ); Thu, 21 Jan 2021 04:47:44 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40306C061343 for ; Thu, 21 Jan 2021 01:45:58 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id q7so1036851wre.13 for ; Thu, 21 Jan 2021 01:45:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PKRdxGowR6+2SlFAzbCdVtAOlJIiEEiKpCM9bIUXE5M=; b=mG8u4AFN7PsNYcEKs/l//NonrtelRjACSLJq4e+TVo0K8mzjkVu5BDL3atZvUalrFV 2sG+IGz5x+r+Xqu8ian32V+Y6BM7ycHh/lu0DqET8lOQJ88Q3jnfH6ChgNTZBVqDqtUd JoKCAI2ZcFX8Ursa6zYypoHh4ylvzcvDXON48ksyRQ0bNvExBc7sq3qE9O2r0L/mV80M 5pR8rT9eAavR/vJCQWterdSoGEV8XT//Y6lZLCzX/Tnsq7pTDb1LLqcByK9dtXMV5PcY RTvZ9Hme+VggC8Y4gEaOeK2HqA+4wfhy1gllrqRk0aQfwnTCGXZr5ABmVnsfi/34QXlS a3yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PKRdxGowR6+2SlFAzbCdVtAOlJIiEEiKpCM9bIUXE5M=; b=e4MFFcXFg9kdTK1U01AKQX1IkkpIL/pKm5MYeAAzyJoHj5hPIR+a8hvIiAPqfIDkAL ozK5ilj2czPOpcHI2/vxTFL+bmxoykBNyTZApq9Ei48JvgI58pJETL6xnhFFCUaS30Zh 4ESYaXG0qMtk/g94YdCNYYbzj+/R2U+DJidy/vneWIbAAc9XsJxzv41YEaGPk8TKyau8 sDVWq9+9Vbpn35l23z4dc33ykXVc6y8WquJkGMmmfJijqyVHlT8H8xCq2zx2IboZ7SZq VaNr0R2KabfdXzNi4VCPZNBpMzPjQktffkZXNU6O8R3CwrgxkHNBN9Y9eFHYWiamhgvl Ir1A== X-Gm-Message-State: AOAM531OOEJeuiXh0RV3ENrf2UnQYmPVDNqd9x6J1xW3JMEY22yglHRx wZwAiOmIAmOSQnknSRLRhdwxUA== X-Google-Smtp-Source: ABdhPJyF3Ip23qrhUl1lzN0DXoq+AJOOj0E2HrMQk0HU7TSvdcjKP+jsXxHDcGUQcTbhM4S9e66LOg== X-Received: by 2002:a5d:6888:: with SMTP id h8mr13530772wru.268.1611222356944; Thu, 21 Jan 2021 01:45:56 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:56 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 27/30] RDMA/hw/qib/qib_iba7322: Fix a bunch of copy/paste issues Date: Thu, 21 Jan 2021 09:45:16 +0000 Message-Id: <20210121094519.2044049-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/qib/qib_iba7322.c:2521: warning: Function parameter or member 'ppd' not described in 'qib_7322_mini_quiet_serdes' drivers/infiniband/hw/qib/qib_iba7322.c:2521: warning: Excess function parameter 'dd' description in 'qib_7322_mini_quiet_serdes' drivers/infiniband/hw/qib/qib_iba7322.c:3768: warning: Function parameter or member 'type' not described in 'qib_7322_put_tid' drivers/infiniband/hw/qib/qib_iba7322.c:3768: warning: Excess function parameter 'tidtype' description in 'qib_7322_put_tid' drivers/infiniband/hw/qib/qib_iba7322.c:3806: warning: Function parameter or member 'rcd' not described in 'qib_7322_clear_tids' drivers/infiniband/hw/qib/qib_iba7322.c:3806: warning: Excess function parameter 'ctxt' description in 'qib_7322_clear_tids' drivers/infiniband/hw/qib/qib_iba7322.c:3872: warning: Function parameter or member 'kinfo' not described in 'qib_7322_get_base_info' drivers/infiniband/hw/qib/qib_iba7322.c:3872: warning: Excess function parameter 'kbase' description in 'qib_7322_get_base_info' drivers/infiniband/hw/qib/qib_iba7322.c:4730: warning: Function parameter or member 'reg' not described in 'qib_portcntr_7322' drivers/infiniband/hw/qib/qib_iba7322.c:4730: warning: Excess function parameter 'creg' description in 'qib_portcntr_7322' drivers/infiniband/hw/qib/qib_iba7322.c:5109: warning: Function parameter or member 't' not described in 'qib_get_7322_faststats' drivers/infiniband/hw/qib/qib_iba7322.c:7189: warning: Function parameter or member 'pdev' not described in 'qib_init_iba7322_funcs' drivers/infiniband/hw/qib/qib_iba7322.c:7189: warning: Excess function parameter 'dev' description in 'qib_init_iba7322_funcs' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/qib/qib_iba7322.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_iba7322.c b/drivers/infiniband/hw/qib/qib_iba7322.c index 189a0ce6056a6..9fe6ea75b45e5 100644 --- a/drivers/infiniband/hw/qib/qib_iba7322.c +++ b/drivers/infiniband/hw/qib/qib_iba7322.c @@ -2514,7 +2514,7 @@ static int qib_7322_bringup_serdes(struct qib_pportdata *ppd) /** * qib_7322_quiet_serdes - set serdes to txidle - * @dd: the qlogic_ib device + * @ppd: the qlogic_ib device * Called when driver is being unloaded */ static void qib_7322_mini_quiet_serdes(struct qib_pportdata *ppd) @@ -3760,7 +3760,7 @@ static int qib_do_7322_reset(struct qib_devdata *dd) * qib_7322_put_tid - write a TID to the chip * @dd: the qlogic_ib device * @tidptr: pointer to the expected TID (in chip) to update - * @tidtype: 0 for eager, 1 for expected + * @type: 0 for eager, 1 for expected * @pa: physical address of in memory buffer; tidinvalid if freeing */ static void qib_7322_put_tid(struct qib_devdata *dd, u64 __iomem *tidptr, @@ -3796,7 +3796,7 @@ static void qib_7322_put_tid(struct qib_devdata *dd, u64 __iomem *tidptr, /** * qib_7322_clear_tids - clear all TID entries for a ctxt, expected and eager * @dd: the qlogic_ib device - * @ctxt: the ctxt + * @rcd: the ctxt * * clear all TID entries for a ctxt, expected and eager. * Used from qib_close(). @@ -3861,7 +3861,7 @@ static void qib_7322_tidtemplate(struct qib_devdata *dd) /** * qib_init_7322_get_base_info - set chip-specific flags for user code * @rcd: the qlogic_ib ctxt - * @kbase: qib_base_info pointer + * @kinfo: qib_base_info pointer * * We set the PCIE flag because the lower bandwidth on PCIe vs * HyperTransport can affect some user packet algorithims. @@ -4724,7 +4724,7 @@ static void sendctrl_7322_mod(struct qib_pportdata *ppd, u32 op) /** * qib_portcntr_7322 - read a per-port chip counter * @ppd: the qlogic_ib pport - * @creg: the counter to read (not a chip offset) + * @reg: the counter to read (not a chip offset) */ static u64 qib_portcntr_7322(struct qib_pportdata *ppd, u32 reg) { @@ -5096,7 +5096,7 @@ static u32 qib_read_7322portcntrs(struct qib_devdata *dd, loff_t pos, u32 port, /** * qib_get_7322_faststats - get word counters from chip before they overflow - * @opaque - contains a pointer to the qlogic_ib device qib_devdata + * @t: contains a pointer to the qlogic_ib device qib_devdata * * VESTIGIAL IBA7322 has no "small fast counters", so the only * real purpose of this function is to maintain the notion of @@ -7175,7 +7175,7 @@ static int qib_7322_tempsense_rd(struct qib_devdata *dd, int regnum) /** * qib_init_iba7322_funcs - set up the chip-specific function pointers - * @dev: the pci_dev for qlogic_ib device + * @pdev: the pci_dev for qlogic_ib device * @ent: pci_device_id struct for this dev * * Also allocates, inits, and returns the devdata struct for this From patchwork Thu Jan 21 09:45:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12035453 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80EFEC433E6 for ; Thu, 21 Jan 2021 10:15:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FA02239ED for ; Thu, 21 Jan 2021 10:15:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725275AbhAUKPW (ORCPT ); Thu, 21 Jan 2021 05:15:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728811AbhAUJru (ORCPT ); Thu, 21 Jan 2021 04:47:50 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60CF9C061345 for ; Thu, 21 Jan 2021 01:45:59 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id g10so1072280wrx.1 for ; Thu, 21 Jan 2021 01:45:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hHWi4XXx2vyVztgjTgAmprH4VRWvHZdCQBx5OVlNKfY=; b=lgfYOvgxTbmldjCfGQVsXLWqgsor7xJTmEgRIw5q8Ks1K+0y2v4FIO6SqDa8zyLRsD 8YID8tJA3CvEd/laqfupMqMPV8mKMaBv6DXL9iB6/R+X5sqrPK+BfwRmDsytoG7ulKVD X3GPNKgGxvfxRQL1o0OaAOIYeYy/kd0bAp++V56jgMjzJ6N24JxVKiCc68JqSIi1Hk/z RdMgpxskr2osXM9qKuCxUwBHxbTWF8c34L6P0zxlHH1rLKpK1hkQZBgvNPWaQWbY0GU1 YaaWrdeTHGep+huyI4O0zXrq0JiuCewdu1apJ5kLtRRYKxkssPD6UWxUOdWbDJGB+x4+ QJ3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hHWi4XXx2vyVztgjTgAmprH4VRWvHZdCQBx5OVlNKfY=; b=ire4qq+4M4EFFxnDLKOe4R/HMt9IiRXPah+Cc7UNcWR+uICQpKbusiwoWzrwHGl3U8 jlcTTjMc4Y671IGlugd8dwAP2abjPJrZeMWWkKK2ETPcaWXeDhdJjP05MCxFaECLJsO9 qZcMa125hohLHM25cPazkKq+fiUFXRlmaH16VnUQ9X65HjEdztZHKHC45z57SHJkxTul a4RCSB4woUSBmIkTkCm0TSsRLDeQdJnphG+gTSVJ+xG+9ZFngYF570Mhy/ICRam3ONEH ynD6m5IuLGxa3sqYdKL1DEbT/EpAbMSWQnvZBWTnoJyYfSFiFQ+i2s94kVgsmS2teXo9 k9bQ== X-Gm-Message-State: AOAM533j0GtXJPriXUVSb8IZR+WR+16ED9lXuN0WEgIJSXMEGHnuXKY2 Utg+2sxy30qylkDAwEnTFMT2sA== X-Google-Smtp-Source: ABdhPJz2zDgq7vJg6Rf0Bfqtm30Oq7JlUDjRPhnw8ZGHxiWVsIkHVD2umFKM+J6YRqF3Kv0ci2cdfg== X-Received: by 2002:adf:e7c1:: with SMTP id e1mr1969479wrn.23.1611222358180; Thu, 21 Jan 2021 01:45:58 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:57 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 28/30] RDMA/hw/qib/qib_verbs: Repair some formatting problems Date: Thu, 21 Jan 2021 09:45:17 +0000 Message-Id: <20210121094519.2044049-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/qib/qib_verbs.c:1077: warning: Function parameter or member 'ppd' not described in 'qib_get_counters' drivers/infiniband/hw/qib/qib_verbs.c:1077: warning: Excess function parameter 'dd' description in 'qib_get_counters' drivers/infiniband/hw/qib/qib_verbs.c:1686: warning: Function parameter or member 'qp' not described in '_qib_schedule_send' drivers/infiniband/hw/qib/qib_verbs.c:1703: warning: Function parameter or member 'qp' not described in 'qib_schedule_send' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/qib/qib_verbs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_verbs.c b/drivers/infiniband/hw/qib/qib_verbs.c index f6c01bad5a74f..8e0de265ad578 100644 --- a/drivers/infiniband/hw/qib/qib_verbs.c +++ b/drivers/infiniband/hw/qib/qib_verbs.c @@ -1067,7 +1067,7 @@ int qib_snapshot_counters(struct qib_pportdata *ppd, u64 *swords, /** * qib_get_counters - get various chip counters - * @dd: the qlogic_ib device + * @ppd: the qlogic_ib device * @cntrs: counters are placed here * * Return the counters needed by recv_pma_get_portcounters(). @@ -1675,7 +1675,7 @@ void qib_unregister_ib_device(struct qib_devdata *dd) /** * _qib_schedule_send - schedule progress - * @qp - the qp + * @qp: the qp * * This schedules progress w/o regard to the s_flags. * @@ -1694,7 +1694,7 @@ bool _qib_schedule_send(struct rvt_qp *qp) /** * qib_schedule_send - schedule progress - * @qp - the qp + * @qp: the qp * * This schedules qp progress. The s_lock * should be held. From patchwork Thu Jan 21 09:45:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12035425 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CDB9C433E0 for ; Thu, 21 Jan 2021 10:06:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C1D2238EE for ; Thu, 21 Jan 2021 10:06:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728984AbhAUJsI (ORCPT ); Thu, 21 Jan 2021 04:48:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728952AbhAUJrv (ORCPT ); Thu, 21 Jan 2021 04:47:51 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC174C061346 for ; Thu, 21 Jan 2021 01:46:00 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id a12so1051530wrv.8 for ; Thu, 21 Jan 2021 01:46:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rLv2flVn35uo9irrj5vj4AyXKUEKpIoSxfExpgzfyqk=; b=W/Cw7iSAfCegPPgWDVVFavdDoZgNTLSWzdLW5FgGDNh8rpuW9FQC2cDYzRkAhQr54V epHWNXbURwsDrFWKsuDruRHu9PVKrvWXBoOZJ2vezQkq8zouISncNxlIwsARDz8dFQpz wgE+TeAZMzlYbMGUgRBxOn8IHZkq+K2sdZcrF9wnXy1cQryjcfR5HodAV2IGAMaz7XUY mj7qAra0JQ1UsXLROHPI6G9OtL48SoRas3GYp48hZjllcWsvwesiD/n0IIfPFdfKdHvC keDQhVO+Ir/8HHUCNgC9ylEL5H2oOfEegvkzeTJxtcQv79DgosWg9nUrPWzBwiyquAH0 Q1Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rLv2flVn35uo9irrj5vj4AyXKUEKpIoSxfExpgzfyqk=; b=K9Q1qD6PY+/ZQ1Swtiov0fFe8RmeIDPvzuNt+jZrtJOmllHDBfqNnCwozxw019JfQ0 jdQqtQp+nPuyY1c1ThlQMamKXlBZ8n5YjWOskqFnX6nfke7UZZBvp/CBqNTaBfHNvSqa XPRnUeFXwHLrOeqFdLqyBhgBjD9GJ6H84AbZj6TxS4UkulhtcE4a8yutRrkmyNnhmukK 2xt9p5V7tW5i4Ie1eHK7m5L3av7ZaGNsq/kvgrDQKfET+HgGGU5bf3AfQNuOt4FXYF6Z Nn2SxNR8Mhp3ULu8qwZES42zQgFysQbGLfYlkAwkXfZ2ZZY5L5EEZDuHmzPsl7TKg3KP GxGA== X-Gm-Message-State: AOAM530a5wB3FeZstJlCeJICJMbQRHaqWzAZ/BTL8lFT0qGmRKUd04GL GJFq+Q8wOcSlud00pN6t3hYmog== X-Google-Smtp-Source: ABdhPJy2RelPiJq9pzkrT/MZnHW73VgbvuH/hiBDTlyXNz25cnCEXSa6atgMPguJqI6GtClf9uxDUQ== X-Received: by 2002:adf:f684:: with SMTP id v4mr13530258wrp.387.1611222359423; Thu, 21 Jan 2021 01:45:59 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:45:58 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 29/30] RDMA/hw/qib/qib_iba6120: Fix some repeated (copy/paste) kernel-doc issues Date: Thu, 21 Jan 2021 09:45:18 +0000 Message-Id: <20210121094519.2044049-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/qib/qib_iba6120.c:1229: warning: Function parameter or member 'ppd' not described in 'qib_6120_bringup_serdes' drivers/infiniband/hw/qib/qib_iba6120.c:1229: warning: Excess function parameter 'dd' description in 'qib_6120_bringup_serdes' drivers/infiniband/hw/qib/qib_iba6120.c:1436: warning: Function parameter or member 'ppd' not described in 'qib_6120_setup_setextled' drivers/infiniband/hw/qib/qib_iba6120.c:1436: warning: Excess function parameter 'dd' description in 'qib_6120_setup_setextled' drivers/infiniband/hw/qib/qib_iba6120.c:1836: warning: Function parameter or member 'type' not described in 'qib_6120_put_tid' drivers/infiniband/hw/qib/qib_iba6120.c:1836: warning: Excess function parameter 'tidtype' description in 'qib_6120_put_tid' drivers/infiniband/hw/qib/qib_iba6120.c:1903: warning: Function parameter or member 'type' not described in 'qib_6120_put_tid_2' drivers/infiniband/hw/qib/qib_iba6120.c:1903: warning: Excess function parameter 'tidtype' description in 'qib_6120_put_tid_2' drivers/infiniband/hw/qib/qib_iba6120.c:1944: warning: Function parameter or member 'rcd' not described in 'qib_6120_clear_tids' drivers/infiniband/hw/qib/qib_iba6120.c:1944: warning: Excess function parameter 'ctxt' description in 'qib_6120_clear_tids' drivers/infiniband/hw/qib/qib_iba6120.c:2018: warning: Function parameter or member 'kinfo' not described in 'qib_6120_get_base_info' drivers/infiniband/hw/qib/qib_iba6120.c:2018: warning: Excess function parameter 'kbase' description in 'qib_6120_get_base_info' drivers/infiniband/hw/qib/qib_iba6120.c:2277: warning: Function parameter or member 'ppd' not described in 'qib_portcntr_6120' drivers/infiniband/hw/qib/qib_iba6120.c:2277: warning: Function parameter or member 'reg' not described in 'qib_portcntr_6120' drivers/infiniband/hw/qib/qib_iba6120.c:2277: warning: Excess function parameter 'dd' description in 'qib_portcntr_6120' drivers/infiniband/hw/qib/qib_iba6120.c:2277: warning: Excess function parameter 'creg' description in 'qib_portcntr_6120' drivers/infiniband/hw/qib/qib_iba6120.c:2620: warning: Function parameter or member 't' not described in 'qib_get_6120_faststats' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/qib/qib_iba6120.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_iba6120.c b/drivers/infiniband/hw/qib/qib_iba6120.c index 44150be215bf2..b35e1174be22f 100644 --- a/drivers/infiniband/hw/qib/qib_iba6120.c +++ b/drivers/infiniband/hw/qib/qib_iba6120.c @@ -1223,7 +1223,7 @@ static void qib_set_ib_6120_lstate(struct qib_pportdata *ppd, u16 linkcmd, /** * qib_6120_bringup_serdes - bring up the serdes - * @dd: the qlogic_ib device + * @ppd: the qlogic_ib device */ static int qib_6120_bringup_serdes(struct qib_pportdata *ppd) { @@ -1412,7 +1412,7 @@ static void qib_6120_quiet_serdes(struct qib_pportdata *ppd) /** * qib_6120_setup_setextled - set the state of the two external LEDs - * @dd: the qlogic_ib device + * @ppd: the qlogic_ib device * @on: whether the link is up or not * * The exact combo of LEDs if on is true is determined by looking @@ -1823,7 +1823,7 @@ static int qib_6120_setup_reset(struct qib_devdata *dd) * qib_6120_put_tid - write a TID in chip * @dd: the qlogic_ib device * @tidptr: pointer to the expected TID (in chip) to update - * @tidtype: RCVHQ_RCV_TYPE_EAGER (1) for eager, RCVHQ_RCV_TYPE_EXPECTED (0) + * @type: RCVHQ_RCV_TYPE_EAGER (1) for eager, RCVHQ_RCV_TYPE_EXPECTED (0) * for expected * @pa: physical address of in memory buffer; tidinvalid if freeing * @@ -1890,7 +1890,7 @@ static void qib_6120_put_tid(struct qib_devdata *dd, u64 __iomem *tidptr, * qib_6120_put_tid_2 - write a TID in chip, Revision 2 or higher * @dd: the qlogic_ib device * @tidptr: pointer to the expected TID (in chip) to update - * @tidtype: RCVHQ_RCV_TYPE_EAGER (1) for eager, RCVHQ_RCV_TYPE_EXPECTED (0) + * @type: RCVHQ_RCV_TYPE_EAGER (1) for eager, RCVHQ_RCV_TYPE_EXPECTED (0) * for expected * @pa: physical address of in memory buffer; tidinvalid if freeing * @@ -1932,7 +1932,7 @@ static void qib_6120_put_tid_2(struct qib_devdata *dd, u64 __iomem *tidptr, /** * qib_6120_clear_tids - clear all TID entries for a context, expected and eager * @dd: the qlogic_ib device - * @ctxt: the context + * @rcd: the context * * clear all TID entries for a context, expected and eager. * Used from qib_close(). On this chip, TIDs are only 32 bits, @@ -2008,7 +2008,7 @@ int __attribute__((weak)) qib_unordered_wc(void) /** * qib_6120_get_base_info - set chip-specific flags for user code * @rcd: the qlogic_ib ctxt - * @kbase: qib_base_info pointer + * @kinfo: qib_base_info pointer * * We set the PCIE flag because the lower bandwidth on PCIe vs * HyperTransport can affect some user packet algorithms. @@ -2270,8 +2270,8 @@ static void sendctrl_6120_mod(struct qib_pportdata *ppd, u32 op) /** * qib_portcntr_6120 - read a per-port counter - * @dd: the qlogic_ib device - * @creg: the counter to snapshot + * @ppd: the qlogic_ib device + * @reg: the counter to snapshot */ static u64 qib_portcntr_6120(struct qib_pportdata *ppd, u32 reg) { @@ -2610,7 +2610,7 @@ static void qib_chk_6120_errormask(struct qib_devdata *dd) /** * qib_get_faststats - get word counters from chip before they overflow - * @opaque - contains a pointer to the qlogic_ib device qib_devdata + * @t: contains a pointer to the qlogic_ib device qib_devdata * * This needs more work; in particular, decision on whether we really * need traffic_wds done the way it is From patchwork Thu Jan 21 09:45:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12035429 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E58E4C433E0 for ; Thu, 21 Jan 2021 10:06:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98DB3239D3 for ; Thu, 21 Jan 2021 10:06:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726181AbhAUKF5 (ORCPT ); Thu, 21 Jan 2021 05:05:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728415AbhAUJrx (ORCPT ); Thu, 21 Jan 2021 04:47:53 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2CBCC061349 for ; Thu, 21 Jan 2021 01:46:01 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id a9so1056126wrt.5 for ; Thu, 21 Jan 2021 01:46:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XqksBZrA3odDFn/ITnacc/iTVMMrBkdLV36fQYYpBKs=; b=IUHmUEPz1ssVdtT4iImldKBIPFQSaTjNATWl7tdiuiuCD6yIIvpW1LcjWqf2zC+kP+ ONvIqMfLNnBxYsAjFxhqUZKTgOetpiOucBtGyycM6K+34CFTNmR2j8iHyiDqRazhlGBc qRh3c3qTtOWnDb00KWaUh/UZexq0lrQYMf1ezzoInYRh3sJOLgEhcH+uNVGNB9u0/363 q/3qmOMCHAwiHnsJUKhCLptQuhFk04j4h3uYAiguVyK4Q1f90DtcDDwc3OD/guHvROCn z3lbMc5Eq/0vCPRmQ3u98ZqEe8k0K11pYmvcz7IhGcZJDA7vIWZn7yDejUNqs68yMmY7 kgrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XqksBZrA3odDFn/ITnacc/iTVMMrBkdLV36fQYYpBKs=; b=jd5hmcYF4kNgwqiKEW3yYd3sZ7tdBlHctbrM0ak3CBuQlDH6CohqM8JBGHYnNUvFLy JI1zbqpQ0ewwqMrTAh5PsVblTDnfxHvA7vfP/adogGpd4tO482ZcYODJgtdzQr4TZXi/ Rkppa5OnoH7f93PwwWylyhn+a/dCtBiUZhZIsV9wM2ffGKI1W3B19/E3LqzFX6GYgzrQ 1wDmaxkh+AwvM9kuLdoDUnCQLWaewepuzxVgMln/1VIH8XnLIgEPS+xI/G5fZ9A7AyF1 MHtvjq4UUyQQljhlJWAXIJ1g1LVrO3Vuz9MV03Lon/8xx5QSKNYBXc/PyqS+pV48MANE dOaQ== X-Gm-Message-State: AOAM530l9rJRCMtQAGxgBJ316KFgqaSG5sZhgAirUMszXqzbFOIFgOTx 3dKWFq9ZkGeUVpDr/Ue/cTLa6Q== X-Google-Smtp-Source: ABdhPJzC+77t2FW0BclKKfKW3nlo0wzlW6UtCmvMAeUddP508BE1nW6k6f4Ou+MV0qRyLsxZmlPopQ== X-Received: by 2002:a5d:4bc2:: with SMTP id l2mr13557020wrt.204.1611222360687; Thu, 21 Jan 2021 01:46:00 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id a17sm8185648wrs.20.2021.01.21.01.45.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jan 2021 01:46:00 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 30/30] RDMA/sw/rdmavt/qp: Fix a bunch of kernel-doc misdemeanours Date: Thu, 21 Jan 2021 09:45:19 +0000 Message-Id: <20210121094519.2044049-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210121094519.2044049-1-lee.jones@linaro.org> References: <20210121094519.2044049-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/sw/rdmavt/qp.c:165: warning: Function parameter or member 'rdi' not described in 'rvt_wss_init' drivers/infiniband/sw/rdmavt/qp.c:329: warning: Function parameter or member 'rdi' not described in 'init_qpn_table' drivers/infiniband/sw/rdmavt/qp.c:534: warning: Function parameter or member 'type' not described in 'alloc_qpn' drivers/infiniband/sw/rdmavt/qp.c:664: warning: Function parameter or member 'wqe' not described in 'rvt_swqe_has_lkey' drivers/infiniband/sw/rdmavt/qp.c:664: warning: Function parameter or member 'lkey' not described in 'rvt_swqe_has_lkey' drivers/infiniband/sw/rdmavt/qp.c:682: warning: Function parameter or member 'qp' not described in 'rvt_qp_sends_has_lkey' drivers/infiniband/sw/rdmavt/qp.c:682: warning: Function parameter or member 'lkey' not described in 'rvt_qp_sends_has_lkey' drivers/infiniband/sw/rdmavt/qp.c:706: warning: Function parameter or member 'qp' not described in 'rvt_qp_acks_has_lkey' drivers/infiniband/sw/rdmavt/qp.c:706: warning: Function parameter or member 'lkey' not described in 'rvt_qp_acks_has_lkey' drivers/infiniband/sw/rdmavt/qp.c:866: warning: Function parameter or member 'rdi' not described in 'rvt_init_qp' drivers/infiniband/sw/rdmavt/qp.c:920: warning: Function parameter or member 'rdi' not described in '_rvt_reset_qp' drivers/infiniband/sw/rdmavt/qp.c:1736: warning: Function parameter or member 'udata' not described in 'rvt_destroy_qp' drivers/infiniband/sw/rdmavt/qp.c:1924: warning: Function parameter or member 'qp' not described in 'rvt_qp_valid_operation' drivers/infiniband/sw/rdmavt/qp.c:1924: warning: Function parameter or member 'post_parms' not described in 'rvt_qp_valid_operation' drivers/infiniband/sw/rdmavt/qp.c:1924: warning: Function parameter or member 'wr' not described in 'rvt_qp_valid_operation' drivers/infiniband/sw/rdmavt/qp.c:2020: warning: Function parameter or member 'call_send' not described in 'rvt_post_one_wr' drivers/infiniband/sw/rdmavt/qp.c:2621: warning: Function parameter or member 'qp' not described in 'rvt_stop_rnr_timer' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/sw/rdmavt/qp.c | 34 ++++++++++++++++++------------- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/drivers/infiniband/sw/rdmavt/qp.c b/drivers/infiniband/sw/rdmavt/qp.c index 22fa9bde54199..76d6bbfbec50c 100644 --- a/drivers/infiniband/sw/rdmavt/qp.c +++ b/drivers/infiniband/sw/rdmavt/qp.c @@ -156,7 +156,7 @@ void rvt_wss_exit(struct rvt_dev_info *rdi) rdi->wss = NULL; } -/** +/* * rvt_wss_init - Init wss data structures * * Return: 0 on success @@ -323,6 +323,7 @@ static void get_map_page(struct rvt_qpn_table *qpt, /** * init_qpn_table - initialize the QP number table for a device + * @rdi: rvt dev struct * @qpt: the QPN table */ static int init_qpn_table(struct rvt_dev_info *rdi, struct rvt_qpn_table *qpt) @@ -524,6 +525,7 @@ static inline unsigned mk_qpn(struct rvt_qpn_table *qpt, * IB_QPT_SMI/IB_QPT_GSI * @rdi: rvt device info structure * @qpt: queue pair number table pointer + * @type: the QP type * @port_num: IB port number, 1 based, comes from core * @exclude_prefix: prefix of special queue pair number being allocated * @@ -655,8 +657,8 @@ static void rvt_clear_mr_refs(struct rvt_qp *qp, int clr_sends) /** * rvt_swqe_has_lkey - return true if lkey is used by swqe - * @wqe - the send wqe - * @lkey - the lkey + * @wqe: the send wqe + * @lkey: the lkey * * Test the swqe for using lkey */ @@ -675,8 +677,8 @@ static bool rvt_swqe_has_lkey(struct rvt_swqe *wqe, u32 lkey) /** * rvt_qp_sends_has_lkey - return true is qp sends use lkey - * @qp - the rvt_qp - * @lkey - the lkey + * @qp: the rvt_qp + * @lkey: the lkey */ static bool rvt_qp_sends_has_lkey(struct rvt_qp *qp, u32 lkey) { @@ -699,8 +701,8 @@ static bool rvt_qp_sends_has_lkey(struct rvt_qp *qp, u32 lkey) /** * rvt_qp_acks_has_lkey - return true if acks have lkey - * @qp - the qp - * @lkey - the lkey + * @qp: the qp + * @lkey: the lkey */ static bool rvt_qp_acks_has_lkey(struct rvt_qp *qp, u32 lkey) { @@ -716,10 +718,10 @@ static bool rvt_qp_acks_has_lkey(struct rvt_qp *qp, u32 lkey) return false; } -/* +/** * rvt_qp_mr_clean - clean up remote ops for lkey - * @qp - the qp - * @lkey - the lkey that is being de-registered + * @qp: the qp + * @lkey: the lkey that is being de-registered * * This routine checks if the lkey is being used by * the qp. @@ -853,6 +855,7 @@ int rvt_alloc_rq(struct rvt_rq *rq, u32 size, int node, /** * rvt_init_qp - initialize the QP state to the reset state + * @rdi: rvt dev struct * @qp: the QP to init or reinit * @type: the QP type * @@ -907,6 +910,7 @@ static void rvt_init_qp(struct rvt_dev_info *rdi, struct rvt_qp *qp, /** * _rvt_reset_qp - initialize the QP state to the reset state + * @rdi: rvt dev struct * @qp: the QP to reset * @type: the QP type * @@ -1726,6 +1730,7 @@ int rvt_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, /** * rvt_destroy_qp - destroy a queue pair * @ibqp: the queue pair to destroy + * @udata: unused by the driver * * Note that this can be called while the QP is actively sending or * receiving! @@ -1901,9 +1906,9 @@ int rvt_post_recv(struct ib_qp *ibqp, const struct ib_recv_wr *wr, /** * rvt_qp_valid_operation - validate post send wr request - * @qp - the qp - * @post-parms - the post send table for the driver - * @wr - the work request + * @qp: the qp + * @post_parms_ the post send table for the driver + * @wr: the work request * * The routine validates the operation based on the * validation table an returns the length of the operation @@ -2013,6 +2018,7 @@ static inline int rvt_qp_is_avail( * rvt_post_one_wr - post one RC, UC, or UD send work request * @qp: the QP to post on * @wr: the work request to send + * @call_send: kick the send engine into gear */ static int rvt_post_one_wr(struct rvt_qp *qp, const struct ib_send_wr *wr, @@ -2612,7 +2618,7 @@ EXPORT_SYMBOL(rvt_stop_rc_timers); /** * rvt_stop_rnr_timer - stop an rnr timer - * @qp - the QP + * @qp: the QP * * stop an rnr timer and return if the timer * had been pending.