From patchwork Tue Nov 13 18:58:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Almeida?= X-Patchwork-Id: 10681385 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CB18714E2 for ; Tue, 13 Nov 2018 19:00:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C01292B3D9 for ; Tue, 13 Nov 2018 19:00:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B40632B3A6; Tue, 13 Nov 2018 19:00:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 678262B3D4 for ; Tue, 13 Nov 2018 19:00:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9YA9JaXMGZDf++CvgzRZpw1Cym3rDN7BeslgecXuZL4=; b=MFfhi+Vu+8Wa0m OO24I2ro7+2Q8BTvXFlbE7LqGKUFeor1SOLX9HNakEzAH7PbkXy5CPIoseSPkkb9wf7GiWrXmsHdb QAoh+3FDlKk/I/8jjoFurf1KS/20lq1AATGmcc/sQwOw3D+uqlEDcBpfZiBdicEwX6H4C03Zi5TY2 aFyrcdm41HvpP0hGYFeX4czrMxB7ELZ0ekNCKTNGEzogYryoNGgbRB0Y77cT9tIiPpGAqwKTEdF3S JKDnh7IN6l0/LVK0iTR6gyTIUO5jai6K5USPCnEFDHYSlrwMHYN6d3QmR2i24iwhPNcmUsT/ZTSs9 rs7r8S8ikFxwndr7m8ww==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gMdv7-0002d2-NF; Tue, 13 Nov 2018 19:00:17 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gMduy-0002JP-Sl; Tue, 13 Nov 2018 19:00:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=D0sSY/Kd4OAn9GI2rwMKOLIww1c61650+gdBM4JQTMg=; b=onkeDDii6YPw0i4Dc4yNzYVE6v Pak9fH/m5uHuTAYkmJgq1BDFkZw4YHqNyK9vkmKPwEIKLEHy7LhJiE8JtOGJw5vLw520biYPH0+ci U4LZ3rDMMvsAIe16k2qZNaorNFSTY2EglclD0JkonC9qiKUh5bO+tx9crW/NzQMK08xMLjILpXg/B lKvcXjwsj3klWn0zmSRLCkvXm5EZji47jCWL+w7gpgpvoavxgaXEkoy1nMEs8zGFzWoP5krfSWrf6 gYzKEr4xD6c5DnkEcrjGdhIuoJG0UczezIi5p5t83HRpnyBP2fru8+cZenbFATvDPJbkF7cfbSO1H Z+om7uiQ==; Received: from mx1.riseup.net ([198.252.153.129]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gMduv-0008N0-HZ; Tue, 13 Nov 2018 19:00:06 +0000 Received: from cotinga.riseup.net (cotinga-pn.riseup.net [10.0.1.164]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id 257C71A0BB9; Tue, 13 Nov 2018 10:59:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1542135581; bh=/ZZvFgko24gfKCd+wj2Tlp7WU1bp4WyLTWwqwvbS/So=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bBiRZj+sDej53Lp4eiqnXbIrV4PxJOFRgPEDjVLJ6Lk3nqoIyBB6GZ2QkS315obar VZP4xc4Tj49ihhGTfSLJXjIzIX7vTYXzBQNspcsQWajRyD4QxEipAfHBAwYdCx+Ty7 02eEDLe1R9/ua07xhtunZiJWe0xeVz+8A8pkLGLU= X-Riseup-User-ID: 6D90F957788DF2154F633180000E58E4B6561499F17BC012A758C4FA1356CAEC Received: from [127.0.0.1] (localhost [127.0.0.1]) by cotinga.riseup.net with ESMTPSA id C4ACF1031CB; Tue, 13 Nov 2018 10:59:38 -0800 (PST) From: andrealmeid@riseup.net To: eric@anholt.net, linux-rpi-kernel@lists.infradead.org, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, lkcamp@lists.libreplanetbr.org, devel@driverdev.osuosl.org, stefan.wahren@i2se.com Subject: [PATCH v3 1/2] staging: vchi: change type 'int32_t' to 's32' Date: Tue, 13 Nov 2018 16:58:34 -0200 Message-Id: <20181113185835.14429-2-andrealmeid@riseup.net> In-Reply-To: <20181113185835.14429-1-andrealmeid@riseup.net> References: <20181113185835.14429-1-andrealmeid@riseup.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181113_140005_695772_56C78DAD X-CRM114-Status: GOOD ( 12.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Andr=C3=A9_Almeida?= Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: André Almeida As one can see in a typedef at linux/types.h:103, s32 and int32_t are both a 32 bits signed integer. s32 is preferred because it is defined by the kernel maintainers and it prevents portability issues. Changed to meet checkpatch criteria. Signed-off-by: André Almeida --- drivers/staging/vc04_services/interface/vchi/vchi_mh.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchi/vchi_mh.h b/drivers/staging/vc04_services/interface/vchi/vchi_mh.h index 198bd076b666..40c760d493a1 100644 --- a/drivers/staging/vc04_services/interface/vchi/vchi_mh.h +++ b/drivers/staging/vc04_services/interface/vchi/vchi_mh.h @@ -36,7 +36,7 @@ #include -typedef int32_t VCHI_MEM_HANDLE_T; +typedef s32 VCHI_MEM_HANDLE_T; #define VCHI_MEM_HANDLE_INVALID 0 #endif From patchwork Tue Nov 13 18:58:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Almeida?= X-Patchwork-Id: 10681387 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1205D13BF for ; Tue, 13 Nov 2018 19:00:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 00AE92B3C5 for ; Tue, 13 Nov 2018 19:00:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E54FC2B3A6; Tue, 13 Nov 2018 19:00:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4AE282B3C5 for ; Tue, 13 Nov 2018 19:00:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hBg11Zrjh3vIl8K+T1yEuYFZul1IEIpo5sf2bwkFZyo=; b=UupgCHg2RQwmUQ hdY+L1XurwCSuNG+UFBatTU3S/TrRuZvoCfkAf0mftt/jQAPaWogFv6LT0StdgnKSkOkjzu0uaSkw tAdK1bSAZ0rDMzkge4+dev8/F6XukXg/r1pBzT44ZRwrPs/A0c8mMIgZAP0zX+fCki5zCB/pvj1xb fI6k+CzCXV5/GrIjaF8e3SoLPWl/UGuZRmhBvZ3Fa86Zj0P90LkGnRW2nFQb7xDuEGBEElIYatJCU ed20/dNUnmIcW4Ny4/aGI16HJeVeLD+GVwHtvbULfG3c2z+XQpJymFSz+NKrJnyTM3GgiBTMFVRbF lgMnXY4Tl/drEDVxowvA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gMdvL-0002wt-Iv; Tue, 13 Nov 2018 19:00:31 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gMdv4-0002XW-1T; Tue, 13 Nov 2018 19:00:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xB7NNYTjFJ8u3QhnYyyGqQswOHnaHhsL2GCZQtpJR1M=; b=m4KrfI3lDy901mGv6MSa/pKBx0 dILn9yLhMRkGOcU73VpolhylB8CoJCpHqNKuVcc1Mc94KloNMw43dKa/yMFdT81E9Wqf318PPzr0a 2ml7ZsMCsBsCTBYJTEDoWqcDlHsm4GWwxqpW83IBY5l3eK/VIaCgnHcCYXxcShA3aD+4WDeG+lxFF YOmp1Nab1NMv/XxEXCOQca0zJjzaix4a2rXj1ria2N4YzJoh1xzH1vGzLJ/Kud9lRPguWx4d0UDZf q1faBsSxT/B3lOZQPJWP9aJPbTAmLWROMNSKbgSK8ErdYA3FeDLscEmzfrmXUEjfOkpxRuh4YGErv TqxlNvHA==; Received: from mx1.riseup.net ([198.252.153.129]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gMduv-0008N5-HZ; Tue, 13 Nov 2018 19:00:12 +0000 Received: from cotinga.riseup.net (cotinga-pn.riseup.net [10.0.1.164]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id D74921A0BA9; Tue, 13 Nov 2018 10:59:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1542135587; bh=+r9qqIk8w7jOSo7svZLiJHn5yPy/VtQ6HE5kMUfA6zY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BLUT7AaFECSbsRi3+HOeZrFZQRXsYeXWFDqFhgGTCzNCfGVXqz3Us2ePTVBreqb1J cbE66N+iAsk4d8VdtBu0IQZ3jSKg8Phjj0n/xI5nY75T1swFgcc6Xlq3hE99ZGKHxl 7yXyIG6uOFEh3Ur0BL2QdZclTOEDEavw6ZaaVgvk= X-Riseup-User-ID: C1AC8885EC7F87684D762F5986AF24A9D2E126B33BBAD4D6CD038409E431CBBF Received: from [127.0.0.1] (localhost [127.0.0.1]) by cotinga.riseup.net with ESMTPSA id 842721031CB; Tue, 13 Nov 2018 10:59:44 -0800 (PST) From: andrealmeid@riseup.net To: eric@anholt.net, linux-rpi-kernel@lists.infradead.org, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, lkcamp@lists.libreplanetbr.org, devel@driverdev.osuosl.org, stefan.wahren@i2se.com Subject: [PATCH v3 2/2] stagin: vchi: Add SPDX-License-Identifier Date: Tue, 13 Nov 2018 16:58:35 -0200 Message-Id: <20181113185835.14429-3-andrealmeid@riseup.net> In-Reply-To: <20181113185835.14429-1-andrealmeid@riseup.net> References: <20181113185835.14429-1-andrealmeid@riseup.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181113_140005_798659_ED333C31 X-CRM114-Status: GOOD ( 16.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Andr=C3=A9_Almeida?= Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: André Almeida Using multiple license representation as shown here [1]. [1] https://spdx.org/sites/cpstandard/files/pages/files/using_spdx_license_list_short_identifiers.pdf Signed-off-by: André Almeida Acked-by: Stefan Wahren --- Thanks for the feedback Stefan. I've tried to make the code similar to your example. Let me know if it's still wrong. --- .../vc04_services/interface/vchi/vchi_mh.h | 30 +------------------ 1 file changed, 1 insertion(+), 29 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchi/vchi_mh.h b/drivers/staging/vc04_services/interface/vchi/vchi_mh.h index 40c760d493a1..bbf227e4f21a 100644 --- a/drivers/staging/vc04_services/interface/vchi/vchi_mh.h +++ b/drivers/staging/vc04_services/interface/vchi/vchi_mh.h @@ -1,34 +1,6 @@ +/* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0) */ /** * Copyright (c) 2010-2012 Broadcom. All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * 1. Redistributions of source code must retain the above copyright - * notice, this list of conditions, and the following disclaimer, - * without modification. - * 2. Redistributions in binary form must reproduce the above copyright - * notice, this list of conditions and the following disclaimer in the - * documentation and/or other materials provided with the distribution. - * 3. The names of the above-listed copyright holders may not be used - * to endorse or promote products derived from this software without - * specific prior written permission. - * - * ALTERNATIVELY, this software may be distributed under the terms of the - * GNU General Public License ("GPL") version 2, as published by the Free - * Software Foundation. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS - * IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, - * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR - * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR - * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, - * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, - * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR - * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF - * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING - * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS - * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ #ifndef VCHI_MH_H_