From patchwork Wed Feb 10 18:49:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 12081629 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29733C433E0 for ; Wed, 10 Feb 2021 18:50:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6BFE64E2E for ; Wed, 10 Feb 2021 18:50:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6BFE64E2E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=PQjjk9RYQ/fz11tO1S43cT3Mol7sHAl7oWrRTkiMqEI=; b=oUpqG5MwCdMEnSgt301Wjlea5K 7F5reF3ml86j9jcPOCuCzVI7RDwVPSKY5DJfN63LoCDxDNAXE+vI3pyGPwpBhswPz4XDEGjCnyUPl gRyiJ1M1qokiEWZSy84QdpeMKN1D/P7fJdld9kNJrWmGYlVUiXdvqLiqtc55h+LqfubkA/9zf+hwj eSf4b/ygd2k2mCi8egCuP29XH71QT6xq3/X8c1AOUXLo6pTFA4UU6VY8IpHBbsataXAGR0BD9s+G+ FK5eKy5AH/PaVxQsnETbzZjHu7rsHIkwI9l8sJ6b4+Gq5WNmQr8QLinzr2vSGV5jnAngGWpMWoSBa MujRSIwA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9uYg-0000Vw-Ey; Wed, 10 Feb 2021 18:49:50 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9uYd-0000VN-Hv for linux-arm-kernel@lists.infradead.org; Wed, 10 Feb 2021 18:49:48 +0000 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1l9uYU-0007ag-NO; Wed, 10 Feb 2021 18:49:38 +0000 From: Colin King To: Michael Turquette , Stephen Boyd , Michal Simek , Michael Tretter , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH][next] soc: xilinx: vcu: remove deadcode on null divider check Date: Wed, 10 Feb 2021 18:49:38 +0000 Message-Id: <20210210184938.146124-1-colin.king@canonical.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210210_134947_681132_5AC61243 X-CRM114-Status: UNSURE ( 9.78 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Colin Ian King The pointer 'divider' has previously been null checked followed by a return, hence the subsequent null check is redundant deadcode that can be removed. Clean up the code and remove it. Fixes: 9c789deea206 ("soc: xilinx: vcu: implement clock provider for output clocks") Signed-off-by: Colin Ian King --- drivers/clk/xilinx/xlnx_vcu.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/clk/xilinx/xlnx_vcu.c b/drivers/clk/xilinx/xlnx_vcu.c index d66b1315114e..607936d7a413 100644 --- a/drivers/clk/xilinx/xlnx_vcu.c +++ b/drivers/clk/xilinx/xlnx_vcu.c @@ -512,9 +512,6 @@ static void xvcu_clk_hw_unregister_leaf(struct clk_hw *hw) mux = clk_hw_get_parent(divider); clk_hw_unregister_mux(mux); - if (!divider) - return; - clk_hw_unregister_divider(divider); }