From patchwork Mon Feb 22 18:15:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikulas Patocka X-Patchwork-Id: 12099265 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DD8BC433E0 for ; Mon, 22 Feb 2021 18:18:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 577C064F00 for ; Mon, 22 Feb 2021 18:18:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232107AbhBVSSB (ORCPT ); Mon, 22 Feb 2021 13:18:01 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:28629 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232115AbhBVSRK (ORCPT ); Mon, 22 Feb 2021 13:17:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614017743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=WaZ2kh4UnOsLrC34DpoJEUcu/sl/BIRVLnI4aWYpm3I=; b=HjqITfOs0z40Q4lykUBi1oHgHv9LpUVmJXqTRtL0zHwqbay+Jlnqj5yGmG7Nl2gGegr7lt IE0Ddxngl2OdIWCgbRuWElgNrNMIR8RXOf1jxjko12uOBkd7mg2bbwUDFiazuoeU+nmmuf M3FSFb0pmVmmy8PDMKm0eY1JbqYNUVs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-464-ePKjqakSMKWWusfWSD5WEQ-1; Mon, 22 Feb 2021 13:15:39 -0500 X-MC-Unique: ePKjqakSMKWWusfWSD5WEQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EA63A195D560; Mon, 22 Feb 2021 18:15:37 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (file01.intranet.prod.int.rdu2.redhat.com [10.11.5.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 350A45D6D5; Mon, 22 Feb 2021 18:15:33 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (localhost [127.0.0.1]) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4) with ESMTP id 11MIFW0P006167; Mon, 22 Feb 2021 13:15:32 -0500 Received: from localhost (mpatocka@localhost) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4/Submit) with ESMTP id 11MIFW2J006163; Mon, 22 Feb 2021 13:15:32 -0500 X-Authentication-Warning: file01.intranet.prod.int.rdu2.redhat.com: mpatocka owned process doing -bs Date: Mon, 22 Feb 2021 13:15:32 -0500 (EST) From: Mikulas Patocka X-X-Sender: mpatocka@file01.intranet.prod.int.rdu2.redhat.com To: Jens Axboe , Marian Csontos cc: linux-block@vger.kernel.org, dm-devel@redhat.com Subject: [PATCH] blk-settings: make sure that max_sectors is aligned on "logical_block_size" boundary. (fwd) Message-ID: User-Agent: Alpine 2.02 (LRH 1266 2009-07-14) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org ---------- Forwarded message ---------- Date: Thu, 19 Nov 2020 15:36:51 -0500 (EST) From: Mikulas Patocka To: David Teigland , Jens Axboe Cc: heinzm@redhat.com, Zdenek Kabelac , Marian Csontos , linux-block@vger.kernel.org, dm-devel@redhat.com Subject: [PATCH] blk-settings: make sure that max_sectors is aligned on "logical_block_size" boundary. We get these I/O errors when we run md-raid1 on the top of dm-integrity on the top of ramdisk: device-mapper: integrity: Bio not aligned on 8 sectors: 0xff00, 0xff device-mapper: integrity: Bio not aligned on 8 sectors: 0xff00, 0xff device-mapper: integrity: Bio not aligned on 8 sectors: 0xffff, 0x1 device-mapper: integrity: Bio not aligned on 8 sectors: 0xffff, 0x1 device-mapper: integrity: Bio not aligned on 8 sectors: 0x8048, 0xff device-mapper: integrity: Bio not aligned on 8 sectors: 0x8147, 0xff device-mapper: integrity: Bio not aligned on 8 sectors: 0x8246, 0xff device-mapper: integrity: Bio not aligned on 8 sectors: 0x8345, 0xbb The ramdisk device has logical_block_size 512 and max_sectors 255. The dm-integrity device uses logical_block_size 4096 and it doesn't affect the "max_sectors" value - thus, it inherits 255 from the ramdisk. So, we have a device with max_sectors not aligned on logical_block_size. The md-raid device sees that the underlying leg has max_sectors 255 and it will split the bios on 255-sector boundary, making the bios unaligned on logical_block_size. In order to fix the bug, we round down max_sectors to logical_block_size. Signed-off-by: Mikulas Patocka Cc: stable@vger.kernel.org --- block/blk-settings.c | 10 ++++++++++ 1 file changed, 10 insertions(+) Index: linux-2.6/block/blk-settings.c =================================================================== --- linux-2.6.orig/block/blk-settings.c 2020-10-29 12:20:46.000000000 +0100 +++ linux-2.6/block/blk-settings.c 2020-11-19 21:20:18.000000000 +0100 @@ -591,6 +591,16 @@ int blk_stack_limits(struct queue_limits ret = -1; } + t->max_sectors = round_down(t->max_sectors, t->logical_block_size / 512); + if (t->max_sectors < PAGE_SIZE / 512) + t->max_sectors = PAGE_SIZE / 512; + t->max_hw_sectors = round_down(t->max_hw_sectors, t->logical_block_size / 512); + if (t->max_sectors < PAGE_SIZE / 512) + t->max_hw_sectors = PAGE_SIZE / 512; + t->max_dev_sectors = round_down(t->max_dev_sectors, t->logical_block_size / 512); + if (t->max_sectors < PAGE_SIZE / 512) + t->max_dev_sectors = PAGE_SIZE / 512; + /* Discard alignment and granularity */ if (b->discard_granularity) { alignment = queue_limit_discard_alignment(b, start);