From patchwork Tue Feb 23 18:14:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring (Arm)" X-Patchwork-Id: 12100673 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D335C433DB for ; Tue, 23 Feb 2021 18:15:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07B9364E85 for ; Tue, 23 Feb 2021 18:15:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233845AbhBWSPL (ORCPT ); Tue, 23 Feb 2021 13:15:11 -0500 Received: from mail-ot1-f53.google.com ([209.85.210.53]:38144 "EHLO mail-ot1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233821AbhBWSPJ (ORCPT ); Tue, 23 Feb 2021 13:15:09 -0500 Received: by mail-ot1-f53.google.com with SMTP id s3so13350196otg.5; Tue, 23 Feb 2021 10:14:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OkVXldj0RZQt+gCAlu5wKTAhvB5CUtWme7iv2atmKcw=; b=Rn6D8KQhUUlNuANppqqQAPi/FivIxz+nIys39x/4Ey3kEc86AHj1XELD1fLMiz0Kp8 4lXfZJrCsEJhK93zQXt4iWtdJOTD/YYm9gTQWYTD3fzvvY2Nax6HX+/DWCqKMsV8TUcX VSli6OxkXWkAQJrIPozbBrIk/sDWitffoUJ1LgeDWh0gX0OJB5AGqmmYVFISYlLpUTmi eAVVDHTkADtTglBFZU0sUW/+okPbY4oibnrIcGQc05k2Jn7VQ5KxfijPvphRvo5K09hy 5t7wlg4kgxdYItb76FMeS58FLTun46p/Smfldd9e+DSsCki8z2KO61jOrW+4icI94yp+ MB4w== X-Gm-Message-State: AOAM533on1EU/6RS0E0qZh2V2vuu+iS9n7r5sjxbhJRJHQr1Q5hGOyDy sSp1WVwKvpryhEX7umVA99FfEYkOjQ== X-Google-Smtp-Source: ABdhPJzUmK4LFbBi9Q8/Dz0MYS7UWFpnG4hTPpZ0IEVSjh4oDM7W/FVvf4xZN/r+UxvRt2l2fZxRLg== X-Received: by 2002:a9d:1c86:: with SMTP id l6mr10109319ota.319.1614104068420; Tue, 23 Feb 2021 10:14:28 -0800 (PST) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id b2sm3578113oov.3.2021.02.23.10.14.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Feb 2021 10:14:27 -0800 (PST) From: Rob Herring To: Masahiro Yamada , Michal Marek , linux-kbuild@vger.kernel.org Cc: Linus Torvalds , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org Subject: [PATCH 1/3] kbuild: Make old-atomics and missing-syscalls phony targets Date: Tue, 23 Feb 2021 12:14:23 -0600 Message-Id: <20210223181425.4010665-2-robh@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210223181425.4010665-1-robh@kernel.org> References: <20210223181425.4010665-1-robh@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org The old-atomics and missing-syscalls targets are not files, so they should be marked as PHONY. Cc: Masahiro Yamada Cc: Michal Marek Signed-off-by: Rob Herring --- Kbuild | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Kbuild b/Kbuild index fa441b98c9f6..032157c3ffd2 100644 --- a/Kbuild +++ b/Kbuild @@ -44,6 +44,7 @@ always-y += missing-syscalls quiet_cmd_syscalls = CALL $< cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags) $(missing_syscalls_flags) +PHONY += missing-syscalls missing-syscalls: scripts/checksyscalls.sh $(offsets-file) FORCE $(call cmd,syscalls) @@ -55,5 +56,6 @@ always-y += old-atomics quiet_cmd_atomics = CALL $< cmd_atomics = $(CONFIG_SHELL) $< +PHONY += old-atomics old-atomics: scripts/atomic/check-atomics.sh FORCE $(call cmd,atomics) From patchwork Tue Feb 23 18:14:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring (Arm)" X-Patchwork-Id: 12100677 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70A01C433E6 for ; Tue, 23 Feb 2021 18:15:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 356F164E4D for ; Tue, 23 Feb 2021 18:15:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233852AbhBWSPO (ORCPT ); Tue, 23 Feb 2021 13:15:14 -0500 Received: from mail-oi1-f172.google.com ([209.85.167.172]:43803 "EHLO mail-oi1-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233843AbhBWSPL (ORCPT ); Tue, 23 Feb 2021 13:15:11 -0500 Received: by mail-oi1-f172.google.com with SMTP id d20so18542609oiw.10; Tue, 23 Feb 2021 10:14:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Qt8JapFR4fQx7DIa/yS5vjOVQrDG88jy3WbeHeUDOX8=; b=XBZaQC9Rr1sbx1UeA5jxBNMLQa/mcg1rF89G5QcIAXr30nfRs3AL1elgIE0eaeMwEs xuqcTwLc5yBtlx2pFT9fV+XF+BEVlzK6wlEWMUgCUC3adRaYMCvM1ujjPcInVzmem+ug J+mhkhBs/EdFfxYDSE2i+KbUpG6NIivxzpF3vwBfInyqg9QQ3H4pmOExch80LS/Aer74 /OOKqicoN46l4n9xEMpeGFM1TJO1xpa3F/vg6/+BSg+yc7xb5X5p/aCo+7tueFB51FF2 Hdr/kpcF1NW9I6n9HMpTIt0cJfXXWWIYuYfqLsI/3+uUxQznAgq25riFjrppg0VqASLK c/Tg== X-Gm-Message-State: AOAM532+kS6RogMCKN6jfEcC9RrCHCBP9K4/dvjSs/Z0SwrFVUBy4omZ 6O5KCww8cYLYxbmgP3/UZA== X-Google-Smtp-Source: ABdhPJyIh57oR1GBWIC49B1ke/YV4wUnFAwqNsVX+/pcTDN2Gqss6L27Fkupxc66/vxn7AylZPI8YQ== X-Received: by 2002:aca:b655:: with SMTP id g82mr2307oif.91.1614104070167; Tue, 23 Feb 2021 10:14:30 -0800 (PST) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id b2sm3578113oov.3.2021.02.23.10.14.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Feb 2021 10:14:29 -0800 (PST) From: Rob Herring To: Masahiro Yamada , Michal Marek , linux-kbuild@vger.kernel.org Cc: Linus Torvalds , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org Subject: [PATCH 2/3] x86: Drop generated syscall headers from 'targets' Date: Tue, 23 Feb 2021 12:14:24 -0600 Message-Id: <20210223181425.4010665-3-robh@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210223181425.4010665-1-robh@kernel.org> References: <20210223181425.4010665-1-robh@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org Including the generated syscall headers in 'targets' is wrong because they are not built in $(obj)/ and the Makefile does its own path prefix and build rules. Cc: Andy Lutomirski Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: x86@kernel.org Cc: "H. Peter Anvin" Cc: Masahiro Yamada Cc: Michal Marek Signed-off-by: Rob Herring --- arch/x86/entry/syscalls/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/entry/syscalls/Makefile b/arch/x86/entry/syscalls/Makefile index 6fb9b57ed5ba..b0dcb7e41554 100644 --- a/arch/x86/entry/syscalls/Makefile +++ b/arch/x86/entry/syscalls/Makefile @@ -62,8 +62,6 @@ syshdr-$(CONFIG_X86_64) += unistd_32_ia32.h unistd_64_x32.h syshdr-$(CONFIG_X86_64) += syscalls_64.h syshdr-$(CONFIG_XEN) += xen-hypercalls.h -targets += $(uapisyshdr-y) $(syshdr-y) - PHONY += all all: $(addprefix $(uapi)/,$(uapisyshdr-y)) all: $(addprefix $(out)/,$(syshdr-y)) From patchwork Tue Feb 23 18:14:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring (Arm)" X-Patchwork-Id: 12100675 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 890CAC433E9 for ; Tue, 23 Feb 2021 18:15:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5741A64EC1 for ; Tue, 23 Feb 2021 18:15:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233858AbhBWSPS (ORCPT ); Tue, 23 Feb 2021 13:15:18 -0500 Received: from mail-ot1-f54.google.com ([209.85.210.54]:44686 "EHLO mail-ot1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233108AbhBWSPM (ORCPT ); Tue, 23 Feb 2021 13:15:12 -0500 Received: by mail-ot1-f54.google.com with SMTP id f33so3259294otf.11; Tue, 23 Feb 2021 10:14:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lTYr+diXJVTiSAjQ+/0IAIEJBjYcnrKX6LHvfOe/yD4=; b=ScJ/HPfwsfn2uIKmPS+KY7U2ytuUmXJT2WkHXDOp0JgDVCmY1lTKfiD/tVc8CG4rOw TpxIgF5GBopenWhBsz1mMHDCW02JFhTb1QKYzNLukKrzZGygv3PKSVYIp7uhrE2qjsOX bPrbOcrB99nIiNXxvidItzxwMBIrfd6OmEn41cC9E1pD232iCuYmGL8D1EpaVGvJR8t0 zUu3dfMZnbJIf2uDb3a9RTTMu3NUCSeZvWtSk98+Qw+QEVO/f5J4jHj7n6ATG4N9UaAB UNX3d79/Te0FuTb+QigCWJfsNC4UD+U2wV0SuDq7If6YcLRz57tbQqus5JPravrG5k/y I05A== X-Gm-Message-State: AOAM530Q3Y++Z1pr/Ctt+hBW3RPb4vXBomvHy0NIjb9RWtPnIoMELX/d iHo1rLqh2sqdEBMC+0R/kA== X-Google-Smtp-Source: ABdhPJzgi9RSM9ezqnICcQq+CUwXTtCdUXFaCJNhtfUlypjSQzbMrjUF/XIl3lXvz/eWOlPmhquFYA== X-Received: by 2002:a9d:3b0:: with SMTP id f45mr21299500otf.62.1614104071627; Tue, 23 Feb 2021 10:14:31 -0800 (PST) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id b2sm3578113oov.3.2021.02.23.10.14.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Feb 2021 10:14:30 -0800 (PST) From: Rob Herring To: Masahiro Yamada , Michal Marek , linux-kbuild@vger.kernel.org Cc: Linus Torvalds , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org Subject: [PATCH 3/3] kbuild: Add a build check for missing gitignore entries Date: Tue, 23 Feb 2021 12:14:25 -0600 Message-Id: <20210223181425.4010665-4-robh@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210223181425.4010665-1-robh@kernel.org> References: <20210223181425.4010665-1-robh@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org Any non-phony targets need to be in gitignore. The normal way to check this is doing an in-tree build and running git-status which is easy to miss. Git provides an easy way to check whether a file is ignored with git-check-ignore. Let's add a build time check using it. If the build is not in a git tree, the check will silently fail. This also has the side effect of a sanity check for 'always-y', 'extra-y' and 'targets' entries which are not correctly marked as PHONY or have the wrong path. Cc: Masahiro Yamada Cc: Michal Marek Cc: linux-kbuild@vger.kernel.org Signed-off-by: Rob Herring --- scripts/Makefile.lib | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index b00855b247e0..84ac8b74bbe9 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -103,6 +103,10 @@ real-obj-m := $(addprefix $(obj)/,$(real-obj-m)) multi-used-m := $(addprefix $(obj)/,$(multi-used-m)) subdir-ym := $(addprefix $(obj)/,$(subdir-ym)) +$(foreach f, $(filter-out $(patsubst %,$(obj)/%,$(PHONY)),$(extra-y) $(always-y) $(targets)), \ + $(if $(shell git -C $(srctree) check-ignore -q $(f) 2> /dev/null || echo $(f)), \ + $(warning $(f) is missing gitignore entry))) + # Finds the multi-part object the current object will be linked into. # If the object belongs to two or more multi-part objects, list them all. modname-multi = $(sort $(foreach m,$(multi-used),\