From patchwork Wed Feb 24 07:56:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= X-Patchwork-Id: 12101465 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14764C433DB for ; Wed, 24 Feb 2021 07:58:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2B0F64DF5 for ; Wed, 24 Feb 2021 07:58:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233625AbhBXH55 (ORCPT ); Wed, 24 Feb 2021 02:57:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232164AbhBXH5Z (ORCPT ); Wed, 24 Feb 2021 02:57:25 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57F64C06178A; Tue, 23 Feb 2021 23:56:45 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id r3so904964wro.9; Tue, 23 Feb 2021 23:56:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=+YN7Bc5pB2WEQ1yJoqO0rNS97fCF9BNOChHdZpj7P+c=; b=W2qCYlG6qxiSFTw6eXLvAyxB3shzU8qiD36vJ2zVdvPRzcgDq16TEcazS09xpp5VR1 q6Mk43zlSiJwFy3unwjW322SMBAZbjYT7J+O+Cq/tgPBHim4Bb3C8uDAL7xMfGyz+u0T vWxPumVmtT6dg7nwjz0b4xp3waBlrmFRM+o6N5dHvsynJZClMswVEs1lmqWo4/X6Quoi JlHNU3MsHGg+2AVZA9a7w+N12YVJ/E/olZcEuU1s1csGxxL5TVsn/QUokFO+E8YcpQmh +Sr5KHkzIZUVqW4YN3Epbndd/x2NEHi0712MB+hsDdf1+ZAe71LUqOv1XH2VuRIHZBMA 2suA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+YN7Bc5pB2WEQ1yJoqO0rNS97fCF9BNOChHdZpj7P+c=; b=QrHjz1QhauR7C0zt+tc77kqJs69KnGWTNwAifYaI057Vx5mXh2be9j9lJBeFkfeoCk wx8p9tSM3YsAY71QvBkDd2UoTpZ/AnbKICKuCmYzSc1WXlrTq87kOQYp1x03UJTT+WJC sF6yDO92WP/+iC6oiYVr4ftz0+mOTKcoXxmb6hbW6LC/A03T4GtWektFLrdYKStIIOpr fR0eT1vopHLenFsvtYMO99JY6wpsQl1dtVHyFVBwmmblaXehbtKd7S8Y/F4+LlWLYq3T Nc0JcSjqjUFojHuD+Epag0JU22IMq6dZMETJnWA0zNBDFAhtFdVP0YobMlesjuHPOg13 Pcmw== X-Gm-Message-State: AOAM533dbKWfUJhGqRWIOFFvywwQcOWJ2MuNoNDd2Y7qv8x6opYGATMD ajRDj72TK017M8jrU7YxHK0= X-Google-Smtp-Source: ABdhPJyHvaxP0k4Imi07xm3ejDISkZyQxpndcRvFhBl9o+pxRbnM7JqT5x4WdsayxITrniTNxGkZKg== X-Received: by 2002:a05:6000:188b:: with SMTP id a11mr29814959wri.151.1614153404063; Tue, 23 Feb 2021 23:56:44 -0800 (PST) Received: from skynet.lan (170.red-88-1-105.dynamicip.rima-tde.net. [88.1.105.170]) by smtp.gmail.com with ESMTPSA id u7sm1954033wrt.67.2021.02.23.23.56.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Feb 2021 23:56:43 -0800 (PST) From: =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= To: Thomas Gleixner , Marc Zyngier , Rob Herring , Florian Fainelli , =?utf-8?q?Fern=C3=A1ndez_Rojas?= , Jonas Gorski , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org Subject: [PATCH v2 1/2] dt-bindings: interrupt-controller: document BCM6345 external interrupt controller Date: Wed, 24 Feb 2021 08:56:39 +0100 Message-Id: <20210224075640.20465-2-noltari@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210224075640.20465-1-noltari@gmail.com> References: <20210223204340.312-1-noltari@gmail.com> <20210224075640.20465-1-noltari@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Document the binding for the BCM6345 external interrupt controller. Signed-off-by: Álvaro Fernández Rojas Signed-off-by: Jonas Gorski Reviewed-by: Florian Fainelli --- v3: pass dt_binding_check. v2: fix title typo. .../brcm,bcm6345-ext-intc.yaml | 78 +++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml new file mode 100644 index 000000000000..a691510e78b7 --- /dev/null +++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm6345-ext-intc.yaml @@ -0,0 +1,78 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/interrupt-controller/brcm,bcm6345-ext-intc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom BCM6345 external interrupt controller + +maintainers: + - Álvaro Fernández Rojas + - Jonas Gorski + +properties: + compatible: + enum: + - brcm,bcm6318-ext-intc + - brcm,bcm6345-ext-intc + + "#interrupt-cells": + const: 2 + + reg: + maxItems: 1 + + "#address-cells": + const: 0 + + interrupt-controller: true + + interrupts: + description: Specifies the interrupt line(s) in the interrupt-parent + controller node. Valid values depend on the type of parent interrupt + controller. + maxItems: 4 + + brcm,field-width: + description: Interrupt controller field width (the default is 4). + maxItems: 1 + $ref: /schemas/types.yaml#/definitions/uint32 + +required: + - "#address-cells" + - compatible + - reg + - "#interrupt-cells" + - interrupt-controller + - interrupts + +additionalProperties: false + +examples: + - | + interrupt-controller@10000018 { + #address-cells = <0>; + compatible = "brcm,bcm6345-ext-intc"; + reg = <0x10000018 0x4>; + + interrupt-parent = <&periph_intc>; + #interrupt-cells = <2>; + + interrupt-controller; + interrupts = <24>, <25>, <26>, <27>; + }; + + - | + interrupt-controller@fffe0014 { + #address-cells = <0>; + compatible = "brcm,bcm6345-ext-intc"; + reg = <0xfffe0014 0x4>; + + interrupt-controller; + #interrupt-cells = <2>; + + interrupt-parent = <&cpu_intc>; + interrupts = <3>, <4>, <5>, <6>; + + brcm,field-width = <5>; + }; From patchwork Wed Feb 24 07:56:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= X-Patchwork-Id: 12101463 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DAB6C433E6 for ; Wed, 24 Feb 2021 07:58:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8F6364EE8 for ; Wed, 24 Feb 2021 07:58:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231790AbhBXH5x (ORCPT ); Wed, 24 Feb 2021 02:57:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233811AbhBXH51 (ORCPT ); Wed, 24 Feb 2021 02:57:27 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 680BEC06178B; Tue, 23 Feb 2021 23:56:46 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id b3so919357wrj.5; Tue, 23 Feb 2021 23:56:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=P+yXxneEXdvHwqY9n5y7k6E2+3E0VOfHIjG5oNPYvkk=; b=mQ294QqjygNMY6tjgiIH4NdHxbLc/jVMo/i6E6Se8dRveywQbyE7XWSNKBNehoJpXQ FQVwDGg0HxPEsbkhLA+grWqCjwG3OqLSiKWioz1E6BXzrtfxgHnEgFZTo8ZJ3P+6ASKb FmesPIzszJTu8Ru+a6ct1K5JoicQpaHju/ikQ4iGRQy9mzFiXm5zRWU8kH9aMwwWX7zU vSjtPwxBEumfy/OrDM0+N2+i4QRa35k8FOz+AlTK1ebsPoiAh5yFL5Eq5uB7pQcCojka FWA6fAGWmNYp1ws+NFBHjb7alqGDAR6GHzjZT6eoDqgKOMBpFXoYzRkEi9pF0eh6/8Mh 0ONg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P+yXxneEXdvHwqY9n5y7k6E2+3E0VOfHIjG5oNPYvkk=; b=EMfWw/zAfT8gVMird/TcjZT+7EE8eQ8I158yxKUJyLAQMWuvHm9k29k0eNFtAlC2sz m2bnOA23xjhphW/UIFakXC/oHha9FCil6SOQhG9Cb+JosfpcK6zpvG+nbacxdVwgvW8x HwGvKYlqEwGdmyF+AFTR81gd33qUsWV16+AvE+paQhUphHWdl4m0Csu40qmoM9NNrkej GnFJbJqqE42xPzKClpS7FRdm0GFZg7mEkv7WOZcmAUkEvsXyo9DMj280csFX4NFvFxL6 k++S+t6Pe7M6XMb7dx9Wja4FG6hnfN+VaIiqCehfX4E+PtlSCUW6rtWoIJBiLy4vxbiK i4kw== X-Gm-Message-State: AOAM533QFS2fNuKCpkd3CPd8S6HjVp0r1LT7l5u4+XP9tSo0fDJckMPc jj7mZJltlwC7QGtbJO2WzQk= X-Google-Smtp-Source: ABdhPJzFrTKu/ITivPT0KfQGEqRMCyXWtMQxJleEcLgR0PAkmabxnP4vmQC3zm0k5hkXEGY30+hElw== X-Received: by 2002:a5d:4cd0:: with SMTP id c16mr30208387wrt.84.1614153405173; Tue, 23 Feb 2021 23:56:45 -0800 (PST) Received: from skynet.lan (170.red-88-1-105.dynamicip.rima-tde.net. [88.1.105.170]) by smtp.gmail.com with ESMTPSA id u7sm1954033wrt.67.2021.02.23.23.56.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Feb 2021 23:56:44 -0800 (PST) From: =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= To: Thomas Gleixner , Marc Zyngier , Rob Herring , Florian Fainelli , =?utf-8?q?Fern=C3=A1ndez_Rojas?= , Jonas Gorski , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org Subject: [PATCH v2 2/2] irqchip: add support for BCM6345 external interrupt controller Date: Wed, 24 Feb 2021 08:56:40 +0100 Message-Id: <20210224075640.20465-3-noltari@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210224075640.20465-1-noltari@gmail.com> References: <20210223204340.312-1-noltari@gmail.com> <20210224075640.20465-1-noltari@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org This interrupt controller is present on bcm63xx SoCs in order to generate interrupts based on GPIO status changes. Signed-off-by: Álvaro Fernández Rojas Signed-off-by: Jonas Gorski Reviewed-by: Florian Fainelli --- v3: no changes. v2: no changes. drivers/irqchip/Kconfig | 4 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-bcm6345-ext.c | 271 ++++++++++++++++++++++++++++++ 3 files changed, 276 insertions(+) create mode 100644 drivers/irqchip/irq-bcm6345-ext.c diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index e74fa206240a..eaa101939a34 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -113,6 +113,10 @@ config I8259 bool select IRQ_DOMAIN +config BCM6345_EXT_IRQ + bool "BCM6345 External IRQ Controller" + select IRQ_DOMAIN + config BCM6345_L1_IRQ bool select GENERIC_IRQ_CHIP diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile index c59b95a0532c..3cba65bc0aa5 100644 --- a/drivers/irqchip/Makefile +++ b/drivers/irqchip/Makefile @@ -62,6 +62,7 @@ obj-$(CONFIG_XTENSA_MX) += irq-xtensa-mx.o obj-$(CONFIG_XILINX_INTC) += irq-xilinx-intc.o obj-$(CONFIG_IRQ_CROSSBAR) += irq-crossbar.o obj-$(CONFIG_SOC_VF610) += irq-vf610-mscm-ir.o +obj-$(CONFIG_BCM6345_EXT_IRQ) += irq-bcm6345-ext.o obj-$(CONFIG_BCM6345_L1_IRQ) += irq-bcm6345-l1.o obj-$(CONFIG_BCM7038_L1_IRQ) += irq-bcm7038-l1.o obj-$(CONFIG_BCM7120_L2_IRQ) += irq-bcm7120-l2.o diff --git a/drivers/irqchip/irq-bcm6345-ext.c b/drivers/irqchip/irq-bcm6345-ext.c new file mode 100644 index 000000000000..5721ac8de295 --- /dev/null +++ b/drivers/irqchip/irq-bcm6345-ext.c @@ -0,0 +1,271 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Broadcom BCM6345 style external interrupt controller driver + * + * Copyright (C) 2021 Álvaro Fernández Rojas + * Copyright (C) 2014 Jonas Gorski + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define MAX_IRQS 4 + +#define EXTIRQ_CFG_SENSE 0 +#define EXTIRQ_CFG_STAT 1 +#define EXTIRQ_CFG_CLEAR 2 +#define EXTIRQ_CFG_MASK 3 +#define EXTIRQ_CFG_BOTHEDGE 4 +#define EXTIRQ_CFG_LEVELSENSE 5 + +struct intc_data { + struct irq_chip chip; + struct irq_domain *domain; + raw_spinlock_t lock; + + int parent_irq[MAX_IRQS]; + void __iomem *reg; + int shift; + unsigned int toggle_clear_on_ack:1; +}; + +static void bcm6345_ext_intc_irq_handle(struct irq_desc *desc) +{ + struct intc_data *data = irq_desc_get_handler_data(desc); + struct irq_chip *chip = irq_desc_get_chip(desc); + unsigned int irq = irq_desc_get_irq(desc); + unsigned int idx; + + chained_irq_enter(chip, desc); + + for (idx = 0; idx < MAX_IRQS; idx++) { + if (data->parent_irq[idx] != irq) + continue; + + generic_handle_irq(irq_find_mapping(data->domain, idx)); + } + + chained_irq_exit(chip, desc); +} + +static void bcm6345_ext_intc_irq_ack(struct irq_data *data) +{ + struct intc_data *priv = data->domain->host_data; + irq_hw_number_t hwirq = irqd_to_hwirq(data); + u32 reg; + + raw_spin_lock(&priv->lock); + reg = __raw_readl(priv->reg); + __raw_writel(reg | (1 << (hwirq + EXTIRQ_CFG_CLEAR * priv->shift)), + priv->reg); + if (priv->toggle_clear_on_ack) + __raw_writel(reg, priv->reg); + raw_spin_unlock(&priv->lock); +} + +static void bcm6345_ext_intc_irq_mask(struct irq_data *data) +{ + struct intc_data *priv = data->domain->host_data; + irq_hw_number_t hwirq = irqd_to_hwirq(data); + u32 reg; + + raw_spin_lock(&priv->lock); + reg = __raw_readl(priv->reg); + reg &= ~(1 << (hwirq + EXTIRQ_CFG_MASK * priv->shift)); + __raw_writel(reg, priv->reg); + raw_spin_unlock(&priv->lock); +} + +static void bcm6345_ext_intc_irq_unmask(struct irq_data *data) +{ + struct intc_data *priv = data->domain->host_data; + irq_hw_number_t hwirq = irqd_to_hwirq(data); + u32 reg; + + raw_spin_lock(&priv->lock); + reg = __raw_readl(priv->reg); + reg |= 1 << (hwirq + EXTIRQ_CFG_MASK * priv->shift); + __raw_writel(reg, priv->reg); + raw_spin_unlock(&priv->lock); +} + +static int bcm6345_ext_intc_set_type(struct irq_data *data, + unsigned int flow_type) +{ + struct intc_data *priv = data->domain->host_data; + irq_hw_number_t hwirq = irqd_to_hwirq(data); + bool levelsense = 0, sense = 0, bothedge = 0; + u32 reg; + + flow_type &= IRQ_TYPE_SENSE_MASK; + + if (flow_type == IRQ_TYPE_NONE) + flow_type = IRQ_TYPE_LEVEL_LOW; + + switch (flow_type) { + case IRQ_TYPE_EDGE_BOTH: + bothedge = 1; + break; + + case IRQ_TYPE_EDGE_RISING: + sense = 1; + break; + + case IRQ_TYPE_EDGE_FALLING: + break; + + case IRQ_TYPE_LEVEL_HIGH: + levelsense = 1; + sense = 1; + break; + + case IRQ_TYPE_LEVEL_LOW: + levelsense = 1; + break; + + default: + pr_err("bogus flow type combination given!\n"); + return -EINVAL; + } + + raw_spin_lock(&priv->lock); + reg = __raw_readl(priv->reg); + + if (levelsense) + reg |= 1 << (hwirq + EXTIRQ_CFG_LEVELSENSE * priv->shift); + else + reg &= ~(1 << (hwirq + EXTIRQ_CFG_LEVELSENSE * priv->shift)); + if (sense) + reg |= 1 << (hwirq + EXTIRQ_CFG_SENSE * priv->shift); + else + reg &= ~(1 << (hwirq + EXTIRQ_CFG_SENSE * priv->shift)); + if (bothedge) + reg |= 1 << (hwirq + EXTIRQ_CFG_BOTHEDGE * priv->shift); + else + reg &= ~(1 << (hwirq + EXTIRQ_CFG_BOTHEDGE * priv->shift)); + + __raw_writel(reg, priv->reg); + raw_spin_unlock(&priv->lock); + + irqd_set_trigger_type(data, flow_type); + if (flow_type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH)) + irq_set_handler_locked(data, handle_level_irq); + else + irq_set_handler_locked(data, handle_edge_irq); + + return 0; +} + +static int bcm6345_ext_intc_map(struct irq_domain *d, unsigned int irq, + irq_hw_number_t hw) +{ + struct intc_data *priv = d->host_data; + + irq_set_chip_and_handler(irq, &priv->chip, handle_level_irq); + + return 0; +} + +static const struct irq_domain_ops bcm6345_ext_domain_ops = { + .xlate = irq_domain_xlate_twocell, + .map = bcm6345_ext_intc_map, +}; + +static int __init bcm6345_ext_intc_init(struct device_node *node, + int num_irqs, int *irqs, + void __iomem *reg, int shift, + bool toggle_clear_on_ack) +{ + struct intc_data *data; + unsigned int i; + + data = kzalloc(sizeof(*data), GFP_KERNEL); + if (!data) + return -ENOMEM; + + raw_spin_lock_init(&data->lock); + + for (i = 0; i < num_irqs; i++) { + data->parent_irq[i] = irqs[i]; + + irq_set_handler_data(irqs[i], data); + irq_set_chained_handler(irqs[i], bcm6345_ext_intc_irq_handle); + } + + data->reg = reg; + data->shift = shift; + data->toggle_clear_on_ack = toggle_clear_on_ack; + + data->chip.name = "bcm6345-ext-intc"; + data->chip.irq_ack = bcm6345_ext_intc_irq_ack; + data->chip.irq_mask = bcm6345_ext_intc_irq_mask; + data->chip.irq_unmask = bcm6345_ext_intc_irq_unmask; + data->chip.irq_set_type = bcm6345_ext_intc_set_type; + + data->domain = irq_domain_add_simple(node, num_irqs, 0, + &bcm6345_ext_domain_ops, data); + if (!data->domain) { + kfree(data); + return -ENOMEM; + } + + return 0; +} + +static int __init bcm6345_ext_intc_of_init(struct device_node *node, + struct device_node *parent) +{ + int num_irqs, ret = -EINVAL; + unsigned i; + void __iomem *base; + int irqs[MAX_IRQS] = { 0 }; + u32 shift; + bool toggle_clear_on_ack = false; + + num_irqs = of_irq_count(node); + + if (!num_irqs || num_irqs > MAX_IRQS) + return -EINVAL; + + if (of_property_read_u32(node, "brcm,field-width", &shift)) + shift = 4; + + /* On BCM6318 setting CLEAR seems to continuously mask interrupts */ + if (of_device_is_compatible(node, "brcm,bcm6318-ext-intc")) + toggle_clear_on_ack = true; + + for (i = 0; i < num_irqs; i++) { + irqs[i] = irq_of_parse_and_map(node, i); + if (!irqs[i]) + return -ENOMEM; + } + + base = of_iomap(node, 0); + if (!base) + return -ENXIO; + + ret = bcm6345_ext_intc_init(node, num_irqs, irqs, base, shift, + toggle_clear_on_ack); + if (!ret) + return 0; + + iounmap(base); + + for (i = 0; i < num_irqs; i++) + irq_dispose_mapping(irqs[i]); + + return ret; +} + +IRQCHIP_DECLARE(bcm6318_ext_intc, "brcm,bcm6318-ext-intc", + bcm6345_ext_intc_of_init); +IRQCHIP_DECLARE(bcm6345_ext_intc, "brcm,bcm6345-ext-intc", + bcm6345_ext_intc_of_init);