From patchwork Thu Feb 25 09:07:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Li X-Patchwork-Id: 12103675 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1700FC433DB for ; Thu, 25 Feb 2021 09:08:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 982AE64F0E for ; Thu, 25 Feb 2021 09:08:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 982AE64F0E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=bVwFoklyPOwYXl9gYFO9XMgbtsyyY+DK+8CMTzIhEI0=; b=F3rS1y6MENRc6yidFaQgmF6Zvy NkKO+B4OqNJO3N5pYG4cz9DCilhelk1yj//cfX3y3qZTJhnUKJMqrt/fnS3J3hOh8hvP6WGEHU2ZH JRjpXVCYIC7lSkUOn7oZq6hXisEcjpxf8AXcz+L76ZdXHVak/YkjMeOuWvw0dUNlnb/rffRCzw5EW KTAGJOp1rXvwFOZF1lHAnw1dBBXyWST9W6JiTOTRGE+ujnKayfSZjaPylwxXLxegwHZbK7LeUcjpz 6kX9ywFlpliLL3nXKoFNanVMB3xGd9E0M/1V7ZCRaoywOFo6jpHVRa1UObR8dJxfIO6fQkKzjNh6q 550wE8zg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFCcS-0003vt-27; Thu, 25 Feb 2021 09:07:36 +0000 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFCcP-0003ua-4t for linux-arm-kernel@lists.infradead.org; Thu, 25 Feb 2021 09:07:34 +0000 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R191e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e01424; MF=yang.lee@linux.alibaba.com; NM=1; PH=DS; RN=7; SR=0; TI=SMTPD_---0UPXQxjx_1614244047; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0UPXQxjx_1614244047) by smtp.aliyun-inc.com(127.0.0.1); Thu, 25 Feb 2021 17:07:28 +0800 From: Yang Li To: sudeep.holla@arm.com Subject: [PATCH] regulator: add missing call to of_node_put() Date: Thu, 25 Feb 2021 17:07:26 +0800 Message-Id: <1614244046-57560-1-git-send-email-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210225_040733_436616_E030CCB0 X-CRM114-Status: UNSURE ( 9.80 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org, broonie@kernel.org, Yang Li , cristian.marussi@arm.com, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In one of the error paths of the for_each_child_of_node() loop, add missing call to of_node_put(). Fix the following coccicheck warning: ./drivers/regulator/scmi-regulator.c:343:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 347. Reported-by: Abaci Robot Signed-off-by: Yang Li Reported-by: kernel test robot Reported-by: kernel test robot --- drivers/regulator/scmi-regulator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/scmi-regulator.c b/drivers/regulator/scmi-regulator.c index 0e8b3ca..a41bb06 100644 --- a/drivers/regulator/scmi-regulator.c +++ b/drivers/regulator/scmi-regulator.c @@ -344,6 +344,7 @@ static int scmi_regulator_probe(struct scmi_device *sdev) ret = process_scmi_regulator_of_node(sdev, child, rinfo); /* abort on any mem issue */ if (ret == -ENOMEM) + of_node_put(child); return ret; }