From patchwork Fri Mar 12 00:34:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 12133409 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCB3DC433DB for ; Fri, 12 Mar 2021 00:35:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7D6D64F8E for ; Fri, 12 Mar 2021 00:35:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229791AbhCLAer (ORCPT ); Thu, 11 Mar 2021 19:34:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229578AbhCLAeU (ORCPT ); Thu, 11 Mar 2021 19:34:20 -0500 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47145C061574 for ; Thu, 11 Mar 2021 16:34:19 -0800 (PST) Received: by mail-pg1-x52a.google.com with SMTP id n10so14738240pgl.10 for ; Thu, 11 Mar 2021 16:34:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ecmGcBcPtcC0qLRj92pOo7aiI2XbXGDbepHsnlPEhKY=; b=uRnnhsFaMWAuEO+6ZLYgb7Ky3o276oe+fpImfQ7mGCqrZjRvbNC40jZz17/VKxRYmE s4LThJe/rkdzvW0lpBwXo7ONoa5gUfymb53oD8ExaiLZPnB4p6Yi+QslmdugmcyOmloa v4ZghTUyGQkQiC1vXePXjvmkmlvJbVGDgsn/fhXC3Yeyv4WX35nkSJT3qFyqHiKPnMNN dgO25n6iq+LDF4ycj+/U7wJu70ljdAnSrNwqZfvOWZLrl1rhaLXD3FqkAGKygcPtLOCs mFWhf0TN3EJF1eSgTUWQYa8Rgzfi7k9YCKLeOAVODYejJYxQWGeiwmgSXgn/rsh1fd+e QqVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=ecmGcBcPtcC0qLRj92pOo7aiI2XbXGDbepHsnlPEhKY=; b=APqGgmFF3wXmA/BoKJ24BhNfKi33tedvr0TdjVweayAT9PGZFQoGUCEbX4uRmCW3h5 WvkNd0FeCZBMvabDK1++gnxDt5nBs0Dhn4PyPWAnpCs5JgwE064pToBY6EjjMOZYCnKw SIs0MbjXhY6xYXpHaP2CsNL1PfuGUgB/fAdk32lKmDprVeZOA1EwvMLqxGqunxNwCIoZ a9X3sQzKCyvUUMBUGXUT0LejAwHIkNonuOigBoxgh57EAxSgDKDBzR6ss8VWZgHZn/4T MjDMTdXm3Xkb4sq68JeY8adJHx6hlPPf/hIsuX9licSsQU+Y5J75p34P0hhDxsor+tnu 2dvw== X-Gm-Message-State: AOAM531pmjJzXG7xlBRmC+Ids0JF3Opiwzf7bLICfVs5t5qJZQOCnLW4 ha/QHXjIt9kMQnl1oc3oNrsQhAHcri7zJg== X-Google-Smtp-Source: ABdhPJweyJCHaXbghHXDfc7eUQSBdHSgMgCaf2TV78WVhiSADU69z04oUzgwHkgQakmuC5i0vr8FxA== X-Received: by 2002:a62:92cc:0:b029:1fa:515d:808f with SMTP id o195-20020a6292cc0000b02901fa515d808fmr9791956pfd.43.1615509258719; Thu, 11 Mar 2021 16:34:18 -0800 (PST) Received: from localhost.localdomain ([45.124.203.14]) by smtp.gmail.com with ESMTPSA id y20sm3497134pfo.210.2021.03.11.16.34.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Mar 2021 16:34:18 -0800 (PST) Sender: "joel.stan@gmail.com" From: Joel Stanley To: "David S . Miller" , Jakub Kicinski Cc: Dylan Hung , netdev@vger.kernel.org, Benjamin Herrenschmidt Subject: [PATCH] ftgmac100: Restart MAC HW once Date: Fri, 12 Mar 2021 11:04:05 +1030 Message-Id: <20210312003405.439923-1-joel@jms.id.au> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Dylan Hung The interrupt handler may set the flag to reset the mac in the future, but that flag is not cleared once the reset has occurred. Fixes: 10cbd6407609 ("ftgmac100: Rework NAPI & interrupts handling") Signed-off-by: Dylan Hung Acked-by: Benjamin Herrenschmidt Reviewed-by: Joel Stanley Signed-off-by: Joel Stanley --- drivers/net/ethernet/faraday/ftgmac100.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c index 88bfe2107938..04421aec2dfd 100644 --- a/drivers/net/ethernet/faraday/ftgmac100.c +++ b/drivers/net/ethernet/faraday/ftgmac100.c @@ -1337,6 +1337,7 @@ static int ftgmac100_poll(struct napi_struct *napi, int budget) */ if (unlikely(priv->need_mac_restart)) { ftgmac100_start_hw(priv); + priv->need_mac_restart = false; /* Re-enable "bad" interrupts */ iowrite32(FTGMAC100_INT_BAD,