From patchwork Fri Mar 12 09:47:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134099 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C7CEC43381 for ; Fri, 12 Mar 2021 09:48:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E48E564FDA for ; Fri, 12 Mar 2021 09:48:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232985AbhCLJsA (ORCPT ); Fri, 12 Mar 2021 04:48:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232904AbhCLJrv (ORCPT ); Fri, 12 Mar 2021 04:47:51 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 199C9C061761 for ; Fri, 12 Mar 2021 01:47:51 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id r10-20020a05600c35cab029010c946c95easo14771711wmq.4 for ; Fri, 12 Mar 2021 01:47:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FaOSlT3H+eLXLTdCz81SgFAQniGwqDSS0DXaq2Iu+DQ=; b=KiZ4XpaI61DeKGuGWBl7FK9Y5syYuFXSX02jgJnKdo5mMroLsTF4k0qdKK4z8qu4ZE IYuzbaZXcXEehNeTOGANduXzjvCFt3O9I2VNdFxF2ubIsi216dYjkqrkYgejgQB8E7mN WsN0LksSO8bu1HYw+7f+yTDrh3T3bXFh3Rqu355eNwcQXAFPfypEwZ3j8NlR3jTWs5dh 8R9hDO+h4ciNlJCi1SKIxZ444K1JWLqmGF51CAIWK9m2E69xOVR4pxM6utG/o8lfRdva xmDhUjoVz9W66ju6i4Hym9mPMkM9FpprKMMZE0xR6LWY3PPGY6NaMRgO/qgk0zHqZJGZ 9AkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FaOSlT3H+eLXLTdCz81SgFAQniGwqDSS0DXaq2Iu+DQ=; b=sEchJdsIaJeS8NlJIKXkRKlgRD7BhOWKzVdbX5RgeCC9GN2dMT6x1B8CFlfqMbecGd sEIxauppBMDL8Bm9kgPmLFMZV39Ya4lOckck7yZKgqYlIgBfQ8ikJV+YATSkeqHThEJh r0/A8+Fumd9FvnL9ueQPY+XqZT/wW01WMZwVVRDVv16ph2CRKDp/xGUP+i902m7tMg4x bmNJ9pWohrOuPBiO23Ei7JY7YWsIQ+hN/pH6PzJ8JJOhzqk5c741pLTNH4gf8+JkjnTs JjY/Mj8bwI3i/vtRYQrDJn+8G/wGD4hQ1M//zs3ygmqSeDBbV9GVZIOqt+vmHEjRhHcQ WKyg== X-Gm-Message-State: AOAM533veZ1XbCv3Wjzv9t+Y00SYogXHf2OutpGrlzboO/OpuedhASwm lksFGeI1ivHxzYKgQbu6Jmwb3g== X-Google-Smtp-Source: ABdhPJw+ik8nZsC9jBBcKw7vvpmX8TD2loT8Bag8vlVBF2NCbKhx4t5FH5klfoUhZ+kaY21mQLE2cg== X-Received: by 2002:a7b:cf18:: with SMTP id l24mr11821999wmg.182.1615542469782; Fri, 12 Mar 2021 01:47:49 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.47.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:47:49 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , "James E.J. Bottomley" , "Martin K. Petersen" , MPT-FusionLinux.pdl@avagotech.com, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org Subject: [PATCH 01/30] scsi: mpt3sas: mpt3sas_config: Fix a bunch of potential naming doc-rot Date: Fri, 12 Mar 2021 09:47:09 +0000 Message-Id: <20210312094738.2207817-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/mpt3sas/mpt3sas_config.c:1795: warning: expecting prototype for mpt3sas_config_set_driver_trigger_pg0(). Prototype was for _config_set_driver_trigger_pg0() instead drivers/scsi/mpt3sas/mpt3sas_config.c:1929: warning: expecting prototype for mpt3sas_config_set_driver_trigger_pg1(). Prototype was for _config_set_driver_trigger_pg1() instead drivers/scsi/mpt3sas/mpt3sas_config.c:2080: warning: expecting prototype for mpt3sas_config_set_driver_trigger_pg2(). Prototype was for _config_set_driver_trigger_pg2() instead drivers/scsi/mpt3sas/mpt3sas_config.c:2240: warning: expecting prototype for mpt3sas_config_set_driver_trigger_pg3(). Prototype was for _config_set_driver_trigger_pg3() instead drivers/scsi/mpt3sas/mpt3sas_config.c:2397: warning: expecting prototype for mpt3sas_config_set_driver_trigger_pg4(). Prototype was for _config_set_driver_trigger_pg4() instead Cc: Sathya Prakash Cc: Sreekanth Reddy Cc: Suganath Prabu Subramani Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: MPT-FusionLinux.pdl@avagotech.com Cc: MPT-FusionLinux.pdl@broadcom.com Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/mpt3sas/mpt3sas_config.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_config.c b/drivers/scsi/mpt3sas/mpt3sas_config.c index 8238843523b53..55cd329089246 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_config.c +++ b/drivers/scsi/mpt3sas/mpt3sas_config.c @@ -1781,7 +1781,7 @@ mpt3sas_config_get_driver_trigger_pg0(struct MPT3SAS_ADAPTER *ioc, } /** - * mpt3sas_config_set_driver_trigger_pg0 - write driver trigger page 0 + * _config_set_driver_trigger_pg0 - write driver trigger page 0 * @ioc: per adapter object * @mpi_reply: reply mf payload returned from firmware * @config_page: contents of the config page @@ -1915,7 +1915,7 @@ mpt3sas_config_get_driver_trigger_pg1(struct MPT3SAS_ADAPTER *ioc, } /** - * mpt3sas_config_set_driver_trigger_pg1 - write driver trigger page 1 + * _config_set_driver_trigger_pg1 - write driver trigger page 1 * @ioc: per adapter object * @mpi_reply: reply mf payload returned from firmware * @config_page: contents of the config page @@ -2066,7 +2066,7 @@ mpt3sas_config_get_driver_trigger_pg2(struct MPT3SAS_ADAPTER *ioc, } /** - * mpt3sas_config_set_driver_trigger_pg2 - write driver trigger page 2 + * _config_set_driver_trigger_pg2 - write driver trigger page 2 * @ioc: per adapter object * @mpi_reply: reply mf payload returned from firmware * @config_page: contents of the config page @@ -2226,7 +2226,7 @@ mpt3sas_config_get_driver_trigger_pg3(struct MPT3SAS_ADAPTER *ioc, } /** - * mpt3sas_config_set_driver_trigger_pg3 - write driver trigger page 3 + * _config_set_driver_trigger_pg3 - write driver trigger page 3 * @ioc: per adapter object * @mpi_reply: reply mf payload returned from firmware * @config_page: contents of the config page @@ -2383,7 +2383,7 @@ mpt3sas_config_get_driver_trigger_pg4(struct MPT3SAS_ADAPTER *ioc, } /** - * mpt3sas_config_set_driver_trigger_pg4 - write driver trigger page 4 + * _config_set_driver_trigger_pg4 - write driver trigger page 4 * @ioc: per adapter object * @mpi_reply: reply mf payload returned from firmware * @config_page: contents of the config page From patchwork Fri Mar 12 09:47:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134103 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F7A8C4332B for ; Fri, 12 Mar 2021 09:48:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 454A364FE2 for ; Fri, 12 Mar 2021 09:48:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232979AbhCLJr6 (ORCPT ); Fri, 12 Mar 2021 04:47:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232915AbhCLJrw (ORCPT ); Fri, 12 Mar 2021 04:47:52 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DD1FC061574 for ; Fri, 12 Mar 2021 01:47:52 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id a18so4405986wrc.13 for ; Fri, 12 Mar 2021 01:47:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GvcOU9KB17xhaNjCrnAPnFFy7MF4/6/f5i41ACjeLUY=; b=IBfRbWkpboIyMwMp/jPVoOSWulevaUTPPqVD+jSxC3pzYsUkhwZm+8uDnHXXA6srhg Pk1j1KpiyHY4EbrBHxwnrzpNyIJQmQBeL4ouopXljRHdyBRKxr08UWUtGJ+dCYY9CCyY BS+JOSNdFRrwsdTnSelJhlI7MoRFhmF2cmB3x8n2ZUdSxlH65FOlRB2SjUkJiXRq0BIm H4MtC1k/sYeuZuyHBz5xWdn1Si6bMzyuO83gFui93EfCDY18C9td1I1aCzqckyUc9lbz 9nSm+aWvRE2s3PEZETwiFiILMSfGthwi4bVd5/Pir64o+R2219H4rJICLo9nYjvQpZYz z+pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GvcOU9KB17xhaNjCrnAPnFFy7MF4/6/f5i41ACjeLUY=; b=HBFFnUCTmMAqilfpop62NWEvTgV4x77QuVDoxx0aetghaJIFTCGj6/nmpQgX69AugI Nf8zg05ogw5rRqrFZIC2pHEZvaWjVq1WKcn40b1+mLwM26aIP8iQHBS0dVwIbD4KGIcE ZJecIKAkS9XEAJcfPJM2aIJdI8IPH3aX1StPm/ziWvuMh+mH3WDx7qym6wYQwoXOoYHJ qNsDpfW/1fVzWKaYBjbPqDZubl4giB30d+ZJ//d8q9b7/bEpSCW1vC+CCyb9seB7TGYA RpU5H7lGcS0+MGVsLEHKSFKfgGYw79WxadR47fpg7mJanQJTl5giZWdkEBzZsYaD1PQp fsYw== X-Gm-Message-State: AOAM530FYaWqis+FeISXMenFXsL+PED2bMDvMWIALfdN91ALGUCJj8tF ZAWc8tkyNvW1h1BgUzq+eK25cw== X-Google-Smtp-Source: ABdhPJyle5qhx7ikejNmByrUqCTOPH+IAyRTZ31+I8JjFcNjDJysq7mnoznoPd+Eo9N/SNCpUwTUWg== X-Received: by 2002:adf:d851:: with SMTP id k17mr13274762wrl.254.1615542471088; Fri, 12 Mar 2021 01:47:51 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.47.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:47:50 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Santosh Yaraganavi , Vinayak Holikatti , linux-scsi@vger.kernel.org Subject: [PATCH 02/30] scsi: ufs: ufshcd: Fix incorrectly named ufshcd_find_max_sup_active_icc_level() Date: Fri, 12 Mar 2021 09:47:10 +0000 Message-Id: <20210312094738.2207817-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/ufs/ufshcd.c:7142: warning: expecting prototype for ufshcd_calc_icc_level(). Prototype was for ufshcd_find_max_sup_active_icc_level() instead Cc: Alim Akhtar Cc: Avri Altman Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Santosh Yaraganavi Cc: Vinayak Holikatti Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/ufs/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index b65c2899aae41..ffbea9f51dfef 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -7146,7 +7146,7 @@ static u32 ufshcd_get_max_icc_level(int sup_curr_uA, u32 start_scan, char *buff) } /** - * ufshcd_calc_icc_level - calculate the max ICC level + * ufshcd_find_max_sup_active_icc_level - calculate the max ICC level * In case regulators are not initialized we'll return 0 * @hba: per-adapter instance * @desc_buf: power descriptor buffer to extract ICC levels from. From patchwork Fri Mar 12 09:47:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134107 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4722C43332 for ; Fri, 12 Mar 2021 09:48:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 970EF64F70 for ; Fri, 12 Mar 2021 09:48:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232994AbhCLJsA (ORCPT ); Fri, 12 Mar 2021 04:48:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232919AbhCLJrx (ORCPT ); Fri, 12 Mar 2021 04:47:53 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 482E9C061761 for ; Fri, 12 Mar 2021 01:47:53 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id f22-20020a7bc8d60000b029010c024a1407so15401199wml.2 for ; Fri, 12 Mar 2021 01:47:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QZLmH1LS3dvFu0B5FfwUETpqGDJKxfDe2SvKPVD/Hhw=; b=MWTXK+6VXn0O2eVB/e4l+XXDBvETAJFvZIMxNL0LloSGain13IcVkP/CElZ5lqO1Nc SlW+PSSG6w1xXoVYu+XrvWfAFFMeyDIa3U2KCbNQTMMsqOMorzSTxligLKNj8/UlaBUb sUj7djB/F3UCje2Uj+KuAkldupzH7JinsFwmVe7H+eOmKNE1GNiqLS/XJKWOp0ZDdFmv X4HAWMMYQHwsFE9R4YWmKWPNFkfOtWkhG2Xc48Y8GW0ujL++BG7tZ7Oyt64SBF1QA3r4 sU842jQwhH8RYAME4fNadhUfwJChJRa3zIG9S6GTkTpyG5LUqugtJcV5sazG1rupbzY0 w7Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QZLmH1LS3dvFu0B5FfwUETpqGDJKxfDe2SvKPVD/Hhw=; b=dYOHPUXjLkhPRLxz1MavYr2Pc+DjIGsy/1fRQkm92LNKsyl114iCZMpuy/evzX7vru 01nlaoUYqpHaLxlpo7jKvHDBXePGtqYHkyKnJz0Vg4wN3P/YCJquU2JdkJnIWhX/agSJ GiBNa7haoicbmWmVsCbm5sBQc0CzzJGvWSz7O3MdUv3C8YpKNEFijEutTG1VWOI2EZPY bO4uypOkOqw9DQYB0fcsI1QDHbpsHgPj1prc9ED1/cFBoyWpt6i6DWJb1lQS9tv/idNM MhzxCk2z301cFkHdop2LdR88h+G78rFSBPCzkfrcrh6UYsk84Nv1edv4LrU52UQSO4BI 8D+g== X-Gm-Message-State: AOAM533Pdemy5mIpFHJXRzq7dJeJuASc7fXqS2wOec0VPaYpdY5ZC9gT ZQCE2KeM4MeLK4kL3FoJvLY9EA== X-Google-Smtp-Source: ABdhPJwMXc1Mh4ZmwJ6pzzlAFZJucA91pXmFg8AMtYupOUOt6P+cF4qOMaacj2jZraMimgYrg1puxA== X-Received: by 2002:a1c:7916:: with SMTP id l22mr11999576wme.86.1615542472003; Fri, 12 Mar 2021 01:47:52 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.47.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:47:51 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 03/30] scsi: lpfc: lpfc_scsi: Fix a bunch of kernel-doc misdemeanours Date: Fri, 12 Mar 2021 09:47:11 +0000 Message-Id: <20210312094738.2207817-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/lpfc/lpfc_scsi.c:746: warning: expecting prototype for lpfc_release_scsi_buf(). Prototype was for lpfc_release_scsi_buf_s3() instead drivers/scsi/lpfc/lpfc_scsi.c:979: warning: expecting prototype for App checking is required for(). Prototype was for BG_ERR_CHECK() instead drivers/scsi/lpfc/lpfc_scsi.c:3701: warning: Function parameter or member 'vport' not described in 'lpfc_scsi_prep_cmnd_buf' drivers/scsi/lpfc/lpfc_scsi.c:3701: warning: Excess function parameter 'phba' description in 'lpfc_scsi_prep_cmnd_buf' drivers/scsi/lpfc/lpfc_scsi.c:3717: warning: Function parameter or member 'fcpi_parm' not described in 'lpfc_send_scsi_error_event' drivers/scsi/lpfc/lpfc_scsi.c:3717: warning: Excess function parameter 'rsp_iocb' description in 'lpfc_send_scsi_error_event' drivers/scsi/lpfc/lpfc_scsi.c:3837: warning: Function parameter or member 'fcpi_parm' not described in 'lpfc_handle_fcp_err' drivers/scsi/lpfc/lpfc_scsi.c:3837: warning: expecting prototype for lpfc_handler_fcp_err(). Prototype was for lpfc_handle_fcp_err() instead drivers/scsi/lpfc/lpfc_scsi.c:4021: warning: Function parameter or member 'wcqe' not described in 'lpfc_fcp_io_cmd_wqe_cmpl' drivers/scsi/lpfc/lpfc_scsi.c:4021: warning: Excess function parameter 'pwqeOut' description in 'lpfc_fcp_io_cmd_wqe_cmpl' drivers/scsi/lpfc/lpfc_scsi.c:4621: warning: Function parameter or member 'vport' not described in 'lpfc_scsi_prep_cmnd_buf_s3' drivers/scsi/lpfc/lpfc_scsi.c:4621: warning: Excess function parameter 'phba' description in 'lpfc_scsi_prep_cmnd_buf_s3' drivers/scsi/lpfc/lpfc_scsi.c:4698: warning: Function parameter or member 'vport' not described in 'lpfc_scsi_prep_cmnd_buf_s4' drivers/scsi/lpfc/lpfc_scsi.c:4698: warning: Excess function parameter 'phba' description in 'lpfc_scsi_prep_cmnd_buf_s4' drivers/scsi/lpfc/lpfc_scsi.c:4954: warning: expecting prototype for lpfc_taskmgmt_def_cmpl(). Prototype was for lpfc_tskmgmt_def_cmpl() instead drivers/scsi/lpfc/lpfc_scsi.c:5094: warning: expecting prototype for lpfc_poll_rearm_time(). Prototype was for lpfc_poll_rearm_timer() instead Cc: James Smart Cc: Dick Kennedy Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/lpfc/lpfc_scsi.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c index f0caf923f38c2..85f6a066de5a8 100644 --- a/drivers/scsi/lpfc/lpfc_scsi.c +++ b/drivers/scsi/lpfc/lpfc_scsi.c @@ -736,7 +736,7 @@ lpfc_get_scsi_buf(struct lpfc_hba *phba, struct lpfc_nodelist *ndlp, } /** - * lpfc_release_scsi_buf - Return a scsi buffer back to hba scsi buf list + * lpfc_release_scsi_buf_s3 - Return a scsi buffer back to hba scsi buf list * @phba: The Hba for which this call is being executed. * @psb: The scsi buffer which is being released. * @@ -974,10 +974,10 @@ lpfc_scsi_prep_dma_buf_s3(struct lpfc_hba *phba, struct lpfc_io_buf *lpfc_cmd) #define BG_ERR_TGT 0x2 /* Return BG_ERR_SWAP if swapping CSUM<-->CRC is required for error injection */ #define BG_ERR_SWAP 0x10 -/** +/* * Return BG_ERR_CHECK if disabling Guard/Ref/App checking is required for * error injection - **/ + */ #define BG_ERR_CHECK 0x20 /** @@ -3699,7 +3699,7 @@ lpfc_bg_scsi_prep_dma_buf(struct lpfc_hba *phba, struct lpfc_io_buf *lpfc_cmd) /** * lpfc_scsi_prep_cmnd_buf - Wrapper function for IOCB/WQE mapping of scsi * buffer - * @phba: The Hba for which this call is being executed. + * @vport: Pointer to vport object. * @lpfc_cmd: The scsi buffer which is going to be mapped. * @tmo: Timeout value for IO * @@ -3721,7 +3721,7 @@ lpfc_scsi_prep_cmnd_buf(struct lpfc_vport *vport, struct lpfc_io_buf *lpfc_cmd, * @phba: Pointer to hba context object. * @vport: Pointer to vport object. * @lpfc_cmd: Pointer to lpfc scsi command which reported the error. - * @rsp_iocb: Pointer to response iocb object which reported error. + * @fcpi_parm: FCP Initiator parameter. * * This function posts an event when there is a SCSI command reporting * error from the scsi device. @@ -3836,10 +3836,10 @@ lpfc_scsi_unprep_dma_buf(struct lpfc_hba *phba, struct lpfc_io_buf *psb) } /** - * lpfc_handler_fcp_err - FCP response handler + * lpfc_handle_fcp_err - FCP response handler * @vport: The virtual port for which this call is being executed. * @lpfc_cmd: Pointer to lpfc_io_buf data structure. - * @rsp_iocb: The response IOCB which contains FCP error. + * @fcpi_parm: FCP Initiator parameter. * * This routine is called to process response IOCB with status field * IOSTAT_FCP_RSP_ERROR. This routine sets result field of scsi command @@ -4023,7 +4023,7 @@ lpfc_handle_fcp_err(struct lpfc_vport *vport, struct lpfc_io_buf *lpfc_cmd, * lpfc_fcp_io_cmd_wqe_cmpl - Complete a FCP IO * @phba: The hba for which this call is being executed. * @pwqeIn: The command WQE for the scsi cmnd. - * @pwqeOut: The response WQE for the scsi cmnd. + * @wcqe: Pointer to driver response CQE object. * * This routine assigns scsi command result by looking into response WQE * status field appropriately. This routine handles QUEUE FULL condition as @@ -4619,7 +4619,7 @@ lpfc_scsi_cmd_iocb_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pIocbIn, /** * lpfc_scsi_prep_cmnd_buf_s3 - SLI-3 IOCB init for the IO - * @phba: Pointer to vport object for which I/O is executed + * @vport: Pointer to vport object. * @lpfc_cmd: The scsi buffer which is going to be prep'ed. * @tmo: timeout value for the IO * @@ -4696,7 +4696,7 @@ static int lpfc_scsi_prep_cmnd_buf_s3(struct lpfc_vport *vport, /** * lpfc_scsi_prep_cmnd_buf_s4 - SLI-4 WQE init for the IO - * @phba: Pointer to vport object for which I/O is executed + * @vport: Pointer to vport object. * @lpfc_cmd: The scsi buffer which is going to be prep'ed. * @tmo: timeout value for the IO * @@ -4953,7 +4953,7 @@ lpfc_scsi_api_table_setup(struct lpfc_hba *phba, uint8_t dev_grp) } /** - * lpfc_taskmgmt_def_cmpl - IOCB completion routine for task management command + * lpfc_tskmgmt_def_cmpl - IOCB completion routine for task management command * @phba: The Hba for which this call is being executed. * @cmdiocbq: Pointer to lpfc_iocbq data structure. * @rspiocbq: Pointer to lpfc_iocbq data structure. @@ -5098,7 +5098,7 @@ lpfc_info(struct Scsi_Host *host) } /** - * lpfc_poll_rearm_time - Routine to modify fcp_poll timer of hba + * lpfc_poll_rearm_timer - Routine to modify fcp_poll timer of hba * @phba: The Hba for which this call is being executed. * * This routine modifies fcp_poll_timer field of @phba by cfg_poll_tmo. From patchwork Fri Mar 12 09:47:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134121 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91CF3C43332 for ; Fri, 12 Mar 2021 09:49:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 786DD64F00 for ; Fri, 12 Mar 2021 09:49:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233181AbhCLJsg (ORCPT ); Fri, 12 Mar 2021 04:48:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233065AbhCLJsF (ORCPT ); Fri, 12 Mar 2021 04:48:05 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B6A0C061574 for ; Fri, 12 Mar 2021 01:47:54 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id e18so1402442wrt.6 for ; Fri, 12 Mar 2021 01:47:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8It0TlKiH23HHYeagj0RrwZW3jVqJUmFhLQQRIEz+M0=; b=I2w2lAc9bV5OeVHfiVDOYDJeo247UNTvywDVv3GJIUIDJMDZczSbdNk4298es766WF lBhQBQFDOahEKvmm3ts4zwwEfyhVQx4xObNrJg/FBlVmcsqWMBy78hUI9xXMQNgdhzEM nCzFKMSZQCHefkEtviqW1JBDMOxlmF8rUhq2oAw0yWEPgVPTN2N/ygV2sLPGgsXEtHR8 Qjcwl4zibINwl4GLyI7p0o9/7cVrhHYuD5fiNxHOXqDFHQ9GZgw4I/y9WhwKa40+8gUu Axf0pWLp9927KbAM9plRNAzFz3hef3waPSm6T0qjdoG1lhl6xc031nSHtC/0FrIeQPYg kzLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8It0TlKiH23HHYeagj0RrwZW3jVqJUmFhLQQRIEz+M0=; b=nuXqIE/98osr+YSmR02B8qJu0nA+MyvHp+2q1KfCYXOvkKB3LGa/kQXMmaKhVOhVTy vJPzrjAYF/XxdaeyJsDyNfrR2Anqn0zaUlKb5dmt44Xi2balwRVB7Xh5PUKl9pBaMPCx R9xx3jVZ4K29W7rgzBO/XOvgl++UdyNO5ooINf6W3Ih2B/1bSRgYH3py35J+M4m3RjWE 1Fqgb8EI9RC4H5B4cNlQgNFL9qL7aOcwqxUC7LdhMNl79JuNAM8WFJWzgfNGMT3tEeuh CtD5DUFO0V4zAmZaSF63KU38rq7MkQrN0U+lO9I9B2xve/YlEI/Ce484QLO9PrIZwtV8 rZzQ== X-Gm-Message-State: AOAM533ApLCx/krmpHFAa6PsMmhe51Rv9QEgbmmj+Hy/jKcYAv20+E3t +AfSEiiz5iBcRrnxGGKN1gcwXg== X-Google-Smtp-Source: ABdhPJyuE4tGtkv7eTzySF5dng9LAuNEfBhJ2l0qTSlu/wKRagVAvV+ieqATeszOy8PLnYyEXoPFaA== X-Received: by 2002:a05:6000:192:: with SMTP id p18mr12928007wrx.403.1615542472867; Fri, 12 Mar 2021 01:47:52 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.47.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:47:52 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 04/30] scsi: lpfc: lpfc_attr: Fix a bunch of misnamed functions Date: Fri, 12 Mar 2021 09:47:12 +0000 Message-Id: <20210312094738.2207817-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/lpfc/lpfc_attr.c:880: warning: expecting prototype for lpfc_state_show(). Prototype was for lpfc_link_state_show() instead drivers/scsi/lpfc/lpfc_attr.c:3834: warning: expecting prototype for lpfc_tgt_queue_depth_store(). Prototype was for lpfc_tgt_queue_depth_set() instead drivers/scsi/lpfc/lpfc_attr.c:4027: warning: expecting prototype for lpfc_topology_set(). Prototype was for lpfc_topology_store() instead drivers/scsi/lpfc/lpfc_attr.c:4481: warning: expecting prototype for lpfc_link_speed_set(). Prototype was for lpfc_link_speed_store() instead drivers/scsi/lpfc/lpfc_attr.c:4879: warning: expecting prototype for lpfc_request_firmware_store(). Prototype was for lpfc_request_firmware_upgrade_store() instead drivers/scsi/lpfc/lpfc_attr.c:5235: warning: expecting prototype for lpfc_state_show(). Prototype was for lpfc_fcp_cpu_map_show() instead Cc: James Smart Cc: Dick Kennedy Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/lpfc/lpfc_attr.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index 98594d6bc26b9..8b4c42016865f 100644 --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b/drivers/scsi/lpfc/lpfc_attr.c @@ -864,7 +864,7 @@ lpfc_option_rom_version_show(struct device *dev, struct device_attribute *attr, } /** - * lpfc_state_show - Return the link state of the port + * lpfc_link_state_show - Return the link state of the port * @dev: class converted to a Scsi_host structure. * @attr: device attribute, not used. * @buf: on return contains text describing the state of the link. @@ -3819,7 +3819,7 @@ lpfc_vport_param_init(tgt_queue_depth, LPFC_MAX_TGT_QDEPTH, LPFC_MIN_TGT_QDEPTH, LPFC_MAX_TGT_QDEPTH); /** - * lpfc_tgt_queue_depth_store: Sets an attribute value. + * lpfc_tgt_queue_depth_set: Sets an attribute value. * @vport: lpfc vport structure pointer. * @val: integer attribute value. * @@ -4004,7 +4004,7 @@ LPFC_ATTR(topology, 0, 0, 6, "Select Fibre Channel topology"); /** - * lpfc_topology_set - Set the adapters topology field + * lpfc_topology_store - Set the adapters topology field * @dev: class device that is converted into a scsi_host. * @attr:device attribute, not used. * @buf: buffer for passing information. @@ -4457,7 +4457,7 @@ static struct bin_attribute sysfs_drvr_stat_data_attr = { # Value range is [0,16]. Default value is 0. */ /** - * lpfc_link_speed_set - Set the adapters link speed + * lpfc_link_speed_store - Set the adapters link speed * @dev: Pointer to class device. * @attr: Unused. * @buf: Data buffer. @@ -4858,7 +4858,7 @@ lpfc_param_show(sriov_nr_virtfn) static DEVICE_ATTR_RW(lpfc_sriov_nr_virtfn); /** - * lpfc_request_firmware_store - Request for Linux generic firmware upgrade + * lpfc_request_firmware_upgrade_store - Request for Linux generic firmware upgrade * * @dev: class device that is converted into a Scsi_host. * @attr: device attribute, not used. @@ -5222,7 +5222,7 @@ lpfc_cq_max_proc_limit_init(struct lpfc_hba *phba, int val) static DEVICE_ATTR_RW(lpfc_cq_max_proc_limit); /** - * lpfc_state_show - Display current driver CPU affinity + * lpfc_fcp_cpu_map_show - Display current driver CPU affinity * @dev: class converted to a Scsi_host structure. * @attr: device attribute, not used. * @buf: on return contains text describing the state of the link. From patchwork Fri Mar 12 09:47:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134105 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E6EFC4332E for ; Fri, 12 Mar 2021 09:48:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D3A565004 for ; Fri, 12 Mar 2021 09:48:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232877AbhCLJsB (ORCPT ); Fri, 12 Mar 2021 04:48:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232939AbhCLJrz (ORCPT ); Fri, 12 Mar 2021 04:47:55 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 520B1C061762 for ; Fri, 12 Mar 2021 01:47:55 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id t9so1398571wrn.11 for ; Fri, 12 Mar 2021 01:47:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PrQ+7ZH8hdEcqjDJ1NufGAV5+lAKZ7pUReLcSfydwew=; b=mMwokNhJjxNU809LhihTYAds9RepOe5eVxyE8Z+0Ds2XHVQtNvJADEYpqs7Ff8fhgQ 6eEjbED6trnXLdfLDqGKqbkUXgajYwKVPGO0NfNxqZth8ytHV7tC8470j2KCMrHn3npG Hn8MLrujWL0yUpgrMJFSJwkDEsnIwAVR/LG5bANdWP3ITy5lKRUGHUpTbfpKRbn9nSCn zsw3GeDVaW/be8dLiUCMiXgYy/EUPsvd9w5GAoNgC/j8E5nZ2UelIXAzJrVryBrbW4/2 5NZDiDCXKp6/GydfiZhdn0vWnSKFTXdll6z0ODb6WFhlxw2ekYmiQCiCYViDGVa0/x39 7Giw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PrQ+7ZH8hdEcqjDJ1NufGAV5+lAKZ7pUReLcSfydwew=; b=bTbaMd8e/XTl05a8gwq7wosPg0wvAclYwBwab9CZZp8rQeSmoPE8/swp79lWSNeA7a rCTaTuh3SLnNhhMVYLaaM20Yg7dFZNKThZviKe9Z1ovXOOpudoCdK2VMrk9KedNIZN5W nh4ctNj4er3W5Vhb/z/CcNzZlBa/2/KSiuZt0+DSEkEuz5YwJCUQY+1UgQb6zToLWU7C H5bWQQQAujeXNVEW8cj03li9gPu2yNiLa5CK475sNDDvwWlrEm9sFzxLreael85dYSFm p06eSB1YXEmAWYXGhEZUC18a1o0SisoPjdIJCLLRhcF1YDHNatiKTvS2y+fXmddHQ7Tr eOFw== X-Gm-Message-State: AOAM533Cw37PLer6uiwNQAWMLGszaOWmlJlrpjFK5kDNL7/uwhAVyYR1 J9lQQMByQo8ZqgtrLlpc8l3uM0DzKLEw4g== X-Google-Smtp-Source: ABdhPJwJxrqDbaV2u+c1ECEngaI6sJkBMUGycupvuKzIBQ3A/3nJ1G9UCu2s9XtmyFZmpwfnEA8eCw== X-Received: by 2002:a05:6000:245:: with SMTP id m5mr13371283wrz.284.1615542474086; Fri, 12 Mar 2021 01:47:54 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.47.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:47:53 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 05/30] scsi: libfc: fc_rport: Fix incorrect naming of fc_rport_adisc_resp() Date: Fri, 12 Mar 2021 09:47:13 +0000 Message-Id: <20210312094738.2207817-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/libfc/fc_rport.c:1500: warning: expecting prototype for fc_rport_els_adisc_resp(). Prototype was for fc_rport_adisc_resp() instead Cc: Hannes Reinecke Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/libfc/fc_rport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c index 56003208d2e7c..cd0fb8ca2425d 100644 --- a/drivers/scsi/libfc/fc_rport.c +++ b/drivers/scsi/libfc/fc_rport.c @@ -1486,7 +1486,7 @@ static void fc_rport_enter_logo(struct fc_rport_priv *rdata) } /** - * fc_rport_els_adisc_resp() - Handler for Address Discovery (ADISC) responses + * fc_rport_adisc_resp() - Handler for Address Discovery (ADISC) responses * @sp: The sequence the ADISC response was on * @fp: The ADISC response frame * @rdata_arg: The remote port that sent the ADISC response From patchwork Fri Mar 12 09:47:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134147 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38332C4160E for ; Fri, 12 Mar 2021 09:49:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C49464FDC for ; Fri, 12 Mar 2021 09:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233206AbhCLJsm (ORCPT ); Fri, 12 Mar 2021 04:48:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233092AbhCLJsI (ORCPT ); Fri, 12 Mar 2021 04:48:08 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5538BC061762 for ; Fri, 12 Mar 2021 01:47:56 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id z2so1404545wrl.5 for ; Fri, 12 Mar 2021 01:47:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ernCjPMMVGuobH5cM6P0HSGWW9MWpSeDQW02LfHawZ0=; b=rV7xkOsGBPIFRjGq0Dz5wZSBevytx0B/6CObs78N1+1GuTNBCsrtzBaxhQmLZcYKvb +60VvIE0Tn4ZoDu+XhaL5v/ElwGTjd5q7niHw61TPEG1J27StkOX0hJfNVB2o+pReHvq iokyGUoCAoyynwsJHuaW9+CJwEFoe0QUoRNtmOlVe6b2DPM9ZrdTa7BPIORlK8q6UkqH 8FW9VlKXtNAgsKx5MmBzrKIXkmHT7VlY8ZpQLhG0lQ3i9XoavQ/XBFW8FQSnbIAV1Hgv ISyzRlJQZ33rqPLawhW9lIMILijpZMwXoF2tvWZVFiix0uXvOg+PHOtU30/DkCRvdJuI gLpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ernCjPMMVGuobH5cM6P0HSGWW9MWpSeDQW02LfHawZ0=; b=Yv71aWssKfKe0xcNRGYmTr9ERlYB19RRAERYU/pUvLKjHg2NUkhnpeSfHOz8ks57ej pLuCIvAacYyLyz0xHo73C/KgfeI4cPqSdv9pOjaqNv4yHqPvN2t6kFHxb9xoivFDLkmR SAfwEoTqpHaddIglp0sjo3fW+nUA92EbKkXcHpeGyMyQDXci4Aq4L/dy0JkAtuWN03pD K3zK21gNZ/RHfvNw7IZdnIOoQBe02dTGEwoO05c4dB6IFQ/Ade9veOQVvXq414LsR6Ix 7SbxLfQKauD4126EqDaDpQrZz5Yazcs9ygkOsM7Xmfx/g8i/7hVNdREQ5F25CFHhQs29 6+ew== X-Gm-Message-State: AOAM533V+AQj3A4oTVY498eo2+/wpWmAsJIlOz+deAXHBj6mwrezU23j vyR4/mw4ORiPfgWpN06KOaFQGw== X-Google-Smtp-Source: ABdhPJzVJfO3OjMFAJiQoXF9fqGRD7xpsM2ycwsfdQX3fW3ocsinr2i1s/BTouIeJhIBvj5gIACKKQ== X-Received: by 2002:a5d:5047:: with SMTP id h7mr13568391wrt.111.1615542475019; Fri, 12 Mar 2021 01:47:55 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:47:54 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , "James E.J. Bottomley" , "Martin K. Petersen" , MPT-FusionLinux.pdl@avagotech.com, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org Subject: [PATCH 06/30] scsi: mpt3sas: mpt3sas_transport: Fix a couple of misdocumented functions/params Date: Fri, 12 Mar 2021 09:47:14 +0000 Message-Id: <20210312094738.2207817-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/mpt3sas/mpt3sas_transport.c:71: warning: Function parameter or member 'phy' not described in '_transport_get_port_id_by_sas_phy' drivers/scsi/mpt3sas/mpt3sas_transport.c:354: warning: Function parameter or member 'port_id' not described in '_transport_expander_report_manufacture' drivers/scsi/mpt3sas/mpt3sas_transport.c:354: warning: expecting prototype for transport_expander_report_manufacture(). Prototype was for _transport_expander_report_manufacture() instead drivers/scsi/mpt3sas/mpt3sas_transport.c:684: warning: Function parameter or member 'hba_port' not described in 'mpt3sas_transport_port_add' drivers/scsi/mpt3sas/mpt3sas_transport.c:684: warning: Excess function parameter 'port' description in 'mpt3sas_transport_port_add' Cc: Sathya Prakash Cc: Sreekanth Reddy Cc: Suganath Prabu Subramani Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: MPT-FusionLinux.pdl@avagotech.com Cc: MPT-FusionLinux.pdl@broadcom.com Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/mpt3sas/mpt3sas_transport.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_transport.c b/drivers/scsi/mpt3sas/mpt3sas_transport.c index 6f47082247551..0681daee6c149 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_transport.c +++ b/drivers/scsi/mpt3sas/mpt3sas_transport.c @@ -62,7 +62,7 @@ /** * _transport_get_port_id_by_sas_phy - get zone's port id that Phy belong to - * @phy - sas_phy object + * @phy: sas_phy object * * Return Port number */ @@ -339,10 +339,11 @@ struct rep_manu_reply { }; /** - * transport_expander_report_manufacture - obtain SMP report_manufacture + * _transport_expander_report_manufacture - obtain SMP report_manufacture * @ioc: per adapter object * @sas_address: expander sas address * @edev: the sas_expander_device object + * @port_id: Port ID number * * Fills in the sas_expander_device object when SMP port is created. * @@ -671,7 +672,7 @@ _transport_sanity_check(struct MPT3SAS_ADAPTER *ioc, struct _sas_node *sas_node, * @ioc: per adapter object * @handle: handle of attached device * @sas_address: sas address of parent expander or sas host - * @port: hba port entry + * @hba_port: hba port entry * Context: This function will acquire ioc->sas_node_lock. * * Adding new port object to the sas_node->sas_port_list. From patchwork Fri Mar 12 09:47:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134111 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9E61C433DB for ; Fri, 12 Mar 2021 09:49:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B631364FB9 for ; Fri, 12 Mar 2021 09:49:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233158AbhCLJsb (ORCPT ); Fri, 12 Mar 2021 04:48:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232967AbhCLJr6 (ORCPT ); Fri, 12 Mar 2021 04:47:58 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 821C6C061763 for ; Fri, 12 Mar 2021 01:47:57 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id l12so4435512wry.2 for ; Fri, 12 Mar 2021 01:47:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c3yETdlK+zH07H8Lti8BgEvatH4uXRXgxfelJOoauw4=; b=gMeUlVmnT/5zFV9SxPaKYVCNJl29Wo3kd0S6O6UvwKxmA71n4hKbSuv0yrt6e4KnSx fR+tAXm9SPDB0SFqNona7VDk3B3p3LovUnPAXY+fLrP007ZJ8KP4CRilv6XTJ0BjPgGi UwC22kVYaaVbIiWSZoBhJi1Gc+Dtms2P7dqly+txc9g0V+vX+zz6uSTJX0HeOiYjTSPV Op5mo+mgc9zN6VEdMu/T2z/pu+KgC1wzgmaTsj2KVA5xkp+wUWOGuN1JQMgH45LnE30+ mT0pmSu8aKc4FXnw2DYwS5xFBSOymKpvGFVH7hU98IVFuwrexflYz+x2M6PfIKrur/bS O3AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c3yETdlK+zH07H8Lti8BgEvatH4uXRXgxfelJOoauw4=; b=KCyMjRDPjfaUMj8N4Y7LHHH8H8NJ++GVyAPYO6kteigvnhcfTVF57+RfnpYXG8BWfp G6NMJQ00GwD+rrOmF6myjY90KFTp+aF2NMkpLwWagK1W1YpWWvQ1zbR4DoF0hehGF5mX RsLQp8G7prxTAl97zW8mq9gzhoniwNemV3o1xCD3HiwIUODdXL6Qi8zykld8+4xUV+DY CofEL/TBFeQyZl/6jxaQNZvFrCOQoxcfa6LGNVKiS4GUZ+zr63UXMekjlqmGw7diQHsq cIn28fPIffockWJnkWcl8lSIpIS83/S/2b8sxvwtyc2QUpEjZvFMqUtH+Ms8W3KfADdX 219w== X-Gm-Message-State: AOAM531V48Clmkgi0kcd2REX97VJ6RxVBcv7t8avAu+2T1Upz6cH8g+m qTD/dM371fdEmGfhFzY9kH7hqFjrqTwP5g== X-Google-Smtp-Source: ABdhPJydAh/jbUByditLKcxVtzpjFwbYiRP+yP/8peLkoOOE9QZ85WA3IHByYefqdrPBzFZKWAqWBQ== X-Received: by 2002:adf:ea8d:: with SMTP id s13mr12915468wrm.32.1615542476229; Fri, 12 Mar 2021 01:47:56 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.47.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:47:55 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 07/30] scsi: libfc: fc_fcp: Fix misspelling of fc_fcp_destroy() Date: Fri, 12 Mar 2021 09:47:15 +0000 Message-Id: <20210312094738.2207817-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/libfc/fc_fcp.c:2255: warning: expecting prototype for fc_fcp_destory(). Prototype was for fc_fcp_destroy() instead Cc: Hannes Reinecke Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/libfc/fc_fcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c index b43b5f62ee3e3..509eacd7893d7 100644 --- a/drivers/scsi/libfc/fc_fcp.c +++ b/drivers/scsi/libfc/fc_fcp.c @@ -2248,7 +2248,7 @@ int fc_slave_alloc(struct scsi_device *sdev) EXPORT_SYMBOL(fc_slave_alloc); /** - * fc_fcp_destory() - Tear down the FCP layer for a given local port + * fc_fcp_destroy() - Tear down the FCP layer for a given local port * @lport: The local port that no longer needs the FCP layer */ void fc_fcp_destroy(struct fc_lport *lport) From patchwork Fri Mar 12 09:47:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134127 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA1B0C43619 for ; Fri, 12 Mar 2021 09:49:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C904764F00 for ; Fri, 12 Mar 2021 09:49:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233204AbhCLJsk (ORCPT ); Fri, 12 Mar 2021 04:48:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233093AbhCLJsI (ORCPT ); Fri, 12 Mar 2021 04:48:08 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CCC7C061763 for ; Fri, 12 Mar 2021 01:47:58 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id r10-20020a05600c35cab029010c946c95easo14771909wmq.4 for ; Fri, 12 Mar 2021 01:47:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z+kSFSRrtdMVZ+j5+NugdaTX8hYYEw2c6IlgmOo4rIo=; b=HOcgEfaVoDJMWGnXaPpzgoYuj5aTw+ZVk9EuklTc1mwNWSzqEN5tkcy6SK22px7l2Z IH3b6a3DKeSc6jMUyR8EiLiJSP8A8swQ8qkWg3D1lqe/3lgUEb3SaN54EwL+87/rB6BM CO+2p6eJzkxo/NXOoqirxPaMWxKAxx+bH3ejrW26ApFwYq/fK1IykgBIrxqWyTbCpbUt g4l96HdnU9mxuZgI9lIrgVc+UfeG7p0fueHRhwfc8R9vhTO7ODFY3Ou5/lpCQCl99M4Q XwkTVTUmmfZtTgzZUDSoOE3L/lTFhPPNzZlYGRU2kPjTFoT4ML1VPdCPRod00eYtXtbP MZVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z+kSFSRrtdMVZ+j5+NugdaTX8hYYEw2c6IlgmOo4rIo=; b=EMIZV1cq71jLhh4JB7PKFUCXy2YXMz7yYdTY4NHfwES09ChaKhrdXu5Qf0Lyckvggh S9oz6gFh6IYrBLRulQWzhYeOxqeG7lnyxh6mnlIy+1FRq98qiB5UXQKm50G4p5u42bkM XroVFSyY1SlmAgVCH1wzXZnLApvHPdueWiGBC/VF02EGKJAzlHF6xax4ikWJ9zjSGj06 PgsKf531OGDJWSXdXuBZwJ2D4diqimov6EHrQ2/nCGxI1Ntngtpm3CpukUFnoyAURg33 Xlg+v5GflgexxHOkst7b9hNoersgUiYeZkoIZSM9w0tJZ2LpJHekhZSPxICoU9FSMw3n OwUg== X-Gm-Message-State: AOAM530NJ4IgtXJfi8jsCLT4YhE3pZK+Sn0Ffxt7TMjQ4t3VcB9DjsDZ HOkefXSA6kYWdU4yvxb6F7MFUQ== X-Google-Smtp-Source: ABdhPJyauKNkVBNzIvCP4ejtdeK/afAqJ050OX03Yub6PLyrcVZ1HV+Ir85+FHBYND0KC3AU7EZsQA== X-Received: by 2002:a05:600c:4150:: with SMTP id h16mr12248304wmm.120.1615542477173; Fri, 12 Mar 2021 01:47:57 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.47.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:47:56 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 08/30] scsi: qla2xxx: qla_mr: Fix a couple of misnamed functions Date: Fri, 12 Mar 2021 09:47:16 +0000 Message-Id: <20210312094738.2207817-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/qla2xxx/qla_mr.c:525: warning: expecting prototype for qlafx00_warm_reset(). Prototype was for qlafx00_soc_cpu_reset() instead drivers/scsi/qla2xxx/qla_mr.c:2869: warning: expecting prototype for qlafx00x_mbx_completion(). Prototype was for qlafx00_mbx_completion() instead Cc: Nilesh Javali Cc: GR-QLogic-Storage-Upstream@marvell.com Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/qla2xxx/qla_mr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c index ca73066853255..d488ae95e149a 100644 --- a/drivers/scsi/qla2xxx/qla_mr.c +++ b/drivers/scsi/qla2xxx/qla_mr.c @@ -516,7 +516,7 @@ qlafx00_pci_config(scsi_qla_host_t *vha) } /** - * qlafx00_warm_reset() - Perform warm reset of iSA(CPUs being reset on SOC). + * qlafx00_soc_cpu_reset() - Perform warm reset of iSA(CPUs being reset on SOC). * @vha: HA context * */ @@ -2860,7 +2860,7 @@ qlafx00_async_event(scsi_qla_host_t *vha) } /** - * qlafx00x_mbx_completion() - Process mailbox command completions. + * qlafx00_mbx_completion() - Process mailbox command completions. * @vha: SCSI driver HA context * @mb0: value to be written into mailbox register 0 */ From patchwork Fri Mar 12 09:47:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134109 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD3E7C433E0 for ; Fri, 12 Mar 2021 09:49:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA04464FDA for ; Fri, 12 Mar 2021 09:49:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233159AbhCLJsd (ORCPT ); Fri, 12 Mar 2021 04:48:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232987AbhCLJsA (ORCPT ); Fri, 12 Mar 2021 04:48:00 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FDEBC061764 for ; Fri, 12 Mar 2021 01:47:59 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id n11-20020a05600c4f8bb029010e5cf86347so4235274wmq.1 for ; Fri, 12 Mar 2021 01:47:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GAfY/sW2GOLPvPNgEyR6W5v2K+OUufqzhLyZshJlkAg=; b=Egt3exAmPVcbCgA4NqY5XW32G2K6gk/0mdoD9JTRnOChzQscD1qRoSkHXbZuGLofz/ 2B1+8F0pbC9mczovOxwQz51AM6w1LLnkEwQxBi0cPZC1zhIEfL5DJ79xUOcw4tIGQoc5 hTIqG8cE1hyNZ86l/IT/umOHDbaRUJM8l9QSGXu4+9EzRT2NnRsIsPjpOsXvkveSCoNq CC6SuBW189wCoCUegHAuWgn62prxXzXMZ/cbDq9if50ofuXkJ6zSrEcihdNipgkAy5BK HtJwx0WpW/1zvX7N1HPb7SyPM+Q3AN/efuVa9YxxxrAvNta23XEc91nkRB4QFaz4fozo umrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GAfY/sW2GOLPvPNgEyR6W5v2K+OUufqzhLyZshJlkAg=; b=KI1Ml8Mc7DPZVAlghl3k+i4WZe8keJASqG1VscAXwAqKPpTs+oMJ6BJkPppjNZa0rk SffuWIT8OTDhFp1OCIoMmmV6xFQqTM32OS44BBqFFHSI8aL70lxmo44fZbxfb7JDR2op Rlywq34FE2BbfCQxJpIChwtU6lNmKH4Jb7mPw7+9My/6CC1L6AgY2kmuK4GZwzKtSsZm c8oanHs4ejAAils98Yqu5dT3kPV5fEBDVFm+CUrVVLV4mBuOEgPUNIprWgORh4zRFW3F GpXw5HEEHEgucx23Pan2G3fYmWsKLk7ZDsIcv6Sopdt+fm0zjdeoFxCIcmo1OtABe7QC xDpw== X-Gm-Message-State: AOAM532w3rFrbCL7TS/v1rceghdxYkIcHM34AsssYXv56gm3+Hcgn7g7 y4ZKTP4BQN+Bg2/64Jih9al5uME5OrBbHw== X-Google-Smtp-Source: ABdhPJy2LUYuQDQsCgd9Z0VwivR/jzGumnZAfhjGkmCBXsAHyuaneyZoFz9aVpb+yo9PZJ5p9lZQPw== X-Received: by 2002:a1c:7901:: with SMTP id l1mr12471938wme.114.1615542478104; Fri, 12 Mar 2021 01:47:58 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:47:57 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , "James E.J. Bottomley" , "Martin K. Petersen" , MPT-FusionLinux.pdl@avagotech.com, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org Subject: [PATCH 09/30] scsi: mpt3sas: mpt3sas_ctl: Fix some kernel-doc misnaming issues Date: Fri, 12 Mar 2021 09:47:17 +0000 Message-Id: <20210312094738.2207817-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/mpt3sas/mpt3sas_ctl.c:463: warning: expecting prototype for mpt3sas_ctl_reset_handler(). Prototype was for mpt3sas_ctl_pre_reset_handler() instead drivers/scsi/mpt3sas/mpt3sas_ctl.c:495: warning: expecting prototype for mpt3sas_ctl_reset_handler(). Prototype was for mpt3sas_ctl_clear_outstanding_ioctls() instead drivers/scsi/mpt3sas/mpt3sas_ctl.c:512: warning: expecting prototype for mpt3sas_ctl_reset_handler(). Prototype was for mpt3sas_ctl_reset_done_handler() instead drivers/scsi/mpt3sas/mpt3sas_ctl.c:2771: warning: expecting prototype for _ ctl_ioctl_compat(). Prototype was for _ctl_ioctl_compat() instead drivers/scsi/mpt3sas/mpt3sas_ctl.c:2789: warning: expecting prototype for _ ctl_mpt2_ioctl_compat(). Prototype was for _ctl_mpt2_ioctl_compat() instead drivers/scsi/mpt3sas/mpt3sas_ctl.c:3061: warning: expecting prototype for sas_address_show(). Prototype was for host_sas_address_show() instead drivers/scsi/mpt3sas/mpt3sas_ctl.c:3682: warning: expecting prototype for diag_trigger_scsi_show(). Prototype was for diag_trigger_mpi_show() instead drivers/scsi/mpt3sas/mpt3sas_ctl.c:3941: warning: expecting prototype for sas_ncq_io_prio_show(). Prototype was for sas_ncq_prio_enable_show() instead Cc: Sathya Prakash Cc: Sreekanth Reddy Cc: Suganath Prabu Subramani Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: MPT-FusionLinux.pdl@avagotech.com Cc: MPT-FusionLinux.pdl@broadcom.com Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/mpt3sas/mpt3sas_ctl.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_ctl.c b/drivers/scsi/mpt3sas/mpt3sas_ctl.c index 44f9a05db94e1..8717412b80794 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_ctl.c +++ b/drivers/scsi/mpt3sas/mpt3sas_ctl.c @@ -454,7 +454,7 @@ _ctl_verify_adapter(int ioc_number, struct MPT3SAS_ADAPTER **iocpp, } /** - * mpt3sas_ctl_reset_handler - reset callback handler (for ctl) + * mpt3sas_ctl_pre_reset_handler - reset callback handler (for ctl) * @ioc: per adapter object * * The handler for doing any required cleanup or initialization. @@ -486,7 +486,7 @@ void mpt3sas_ctl_pre_reset_handler(struct MPT3SAS_ADAPTER *ioc) } /** - * mpt3sas_ctl_reset_handler - clears outstanding ioctl cmd. + * mpt3sas_ctl_clear_outstanding_ioctls - clears outstanding ioctl cmd. * @ioc: per adapter object * * The handler for doing any required cleanup or initialization. @@ -503,7 +503,7 @@ void mpt3sas_ctl_clear_outstanding_ioctls(struct MPT3SAS_ADAPTER *ioc) } /** - * mpt3sas_ctl_reset_handler - reset callback handler (for ctl) + * mpt3sas_ctl_reset_done_handler - reset callback handler (for ctl) * @ioc: per adapter object * * The handler for doing any required cleanup or initialization. @@ -2759,7 +2759,7 @@ _ctl_mpt2_ioctl(struct file *file, unsigned int cmd, unsigned long arg) } #ifdef CONFIG_COMPAT /** - *_ ctl_ioctl_compat - main ioctl entry point (compat) + * _ctl_ioctl_compat - main ioctl entry point (compat) * @file: ? * @cmd: ? * @arg: ? @@ -2777,7 +2777,7 @@ _ctl_ioctl_compat(struct file *file, unsigned cmd, unsigned long arg) } /** - *_ ctl_mpt2_ioctl_compat - main ioctl entry point (compat) + * _ctl_mpt2_ioctl_compat - main ioctl entry point (compat) * @file: ? * @cmd: ? * @arg: ? @@ -3045,7 +3045,7 @@ fw_queue_depth_show(struct device *cdev, struct device_attribute *attr, static DEVICE_ATTR_RO(fw_queue_depth); /** - * sas_address_show - sas address + * host_sas_address_show - sas address * @cdev: pointer to embedded class device * @attr: ? * @buf: the buffer returned @@ -3669,7 +3669,7 @@ static DEVICE_ATTR_RW(diag_trigger_scsi); /** - * diag_trigger_scsi_show - show the diag_trigger_mpi attribute + * diag_trigger_mpi_show - show the diag_trigger_mpi attribute * @cdev: pointer to embedded class device * @attr: ? * @buf: the buffer returned @@ -3928,7 +3928,7 @@ sas_device_handle_show(struct device *dev, struct device_attribute *attr, static DEVICE_ATTR_RO(sas_device_handle); /** - * sas_ncq_io_prio_show - send prioritized io commands to device + * sas_ncq_prio_enable_show - send prioritized io commands to device * @dev: pointer to embedded device * @attr: ? * @buf: the buffer returned From patchwork Fri Mar 12 09:47:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134113 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03165C433E6 for ; Fri, 12 Mar 2021 09:49:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C898364FDC for ; Fri, 12 Mar 2021 09:49:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233167AbhCLJsd (ORCPT ); Fri, 12 Mar 2021 04:48:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233002AbhCLJsB (ORCPT ); Fri, 12 Mar 2021 04:48:01 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C363C061764 for ; Fri, 12 Mar 2021 01:48:00 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id v11so1399569wro.7 for ; Fri, 12 Mar 2021 01:48:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ulNuxr60llkoiFafxIlb+CHi87OxQ5J+B08tO2koRaI=; b=wLD8PaXskYr/2V4CFDzAJ3PEojmrvZ1xIEyZ6Jhnt/KibWadsZT5+wQ/2YL0HVLrSk SE96kMx96abgp4/G5W8rQz0jlm0YMfEybvT/Wvd1nuaqgqNUxWaajR6VtM8xV4HvEvfw Bbx/W03Tvi2yKmyrV05s6Shlf+u2jp06Wbta0PiNCk7RXTBoeDFbMKw3ABOxPrg1RTzM T1iy7YPjiO9Sul+uLBawusQd+njEVUYUYKbgz4CEruL8pCRdPbXNWz/SlhNBzM9y4aW1 NKM36rCUGigDmnm2gkR+X96I/sgHwDReXna0h9TREBV+DYvMT5HKBU4gGoAfnSeSmrMX jhPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ulNuxr60llkoiFafxIlb+CHi87OxQ5J+B08tO2koRaI=; b=t39Oe5vJUI4WWnslm9rXrge1I00X3ZI346hEiF2RmQs1OFlKAgY0PHHEe94g5eU6em l0wDnc9BIrj8T0ExOmz2xplFeS18FumqGt7ihcQFf57K0cIZFQmrVOeFqZ4prImzFOBK TvEl4ASz4oDzcW4Iiy3x3DK14EzPv7yOD6d4fSa8boN015axXqw61DYqCuIgnLW+7W7O eK6NSUYsxyHvzw4gZY5JFsiTfhAJqZ2KjC0oZdNMR00HMwVZCPrlt0p91AdkZH5CjxFd LBDoAt07BPWqRTBnpS51/kG9uKMGxRx7FBl23n/gnFTKHbeniTO6+kDsEm6HQIrotyje xP2w== X-Gm-Message-State: AOAM532gu6VEbkPk1YHZa4IjtoOgYfp8iPCC2p5H+fEvAPkTiguIjtoR lvwsBRbXBXgDXCIci+i9PlDALg== X-Google-Smtp-Source: ABdhPJxo8uCvmvswyteyIJyt3Ic0kUyiaOa1EnkhnWi0vvcbV05Oc/wdTagCI2PErKTC3uAktABG5Q== X-Received: by 2002:adf:f144:: with SMTP id y4mr13185758wro.408.1615542479341; Fri, 12 Mar 2021 01:47:59 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.47.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:47:58 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 10/30] scsi: qla2xxx: qla_nx2: Fix incorrectly named function qla8044_check_temp() Date: Fri, 12 Mar 2021 09:47:18 +0000 Message-Id: <20210312094738.2207817-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/qla2xxx/qla_nx2.c:2038: warning: expecting prototype for qla4_8xxx_check_temp(). Prototype was for qla8044_check_temp() instead Cc: Nilesh Javali Cc: GR-QLogic-Storage-Upstream@marvell.com Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/qla2xxx/qla_nx2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_nx2.c b/drivers/scsi/qla2xxx/qla_nx2.c index 68a16c95dcb77..7c413f93d53ee 100644 --- a/drivers/scsi/qla2xxx/qla_nx2.c +++ b/drivers/scsi/qla2xxx/qla_nx2.c @@ -2028,7 +2028,7 @@ qla8044_device_state_handler(struct scsi_qla_host *vha) } /** - * qla4_8xxx_check_temp - Check the ISP82XX temperature. + * qla8044_check_temp - Check the ISP82XX temperature. * @vha: adapter block pointer. * * Note: The caller should not hold the idc lock. From patchwork Fri Mar 12 09:47:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134157 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8820C28E85 for ; Fri, 12 Mar 2021 09:49:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A51D764FB9 for ; Fri, 12 Mar 2021 09:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233256AbhCLJsq (ORCPT ); Fri, 12 Mar 2021 04:48:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233120AbhCLJsQ (ORCPT ); Fri, 12 Mar 2021 04:48:16 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 903DFC061764 for ; Fri, 12 Mar 2021 01:48:01 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id v11so1399591wro.7 for ; Fri, 12 Mar 2021 01:48:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=N9wGEZYJoAIhx351pyXi5TmAw4uiOf0aUU7wFJx73AA=; b=aT+b5fgyqnDqnX7G5hdmSnKGdVhd9/KtvR4wfW6CaqISTqzo1QWxh7kdAkq/1Ibjpc qpeXdoXLK6hueG+4qGj7plD0J70Wm6rd7ElVOEdFvRCj+mkkj3PZhzhmztTfbNTphipW 028VkRDg4vGaTVotU4tB73nUGkhIrqiVKJLNMeSPqwzStwybxdzQ/9GiL1+hIqnPH/7f axRG75uF9535F3DGUbQUqCymVWkQxv4cB6m37A4LC9BW9qSUE+JQcYK3g7jHEYARZLlf gYZThZbE0Ym7c7yMJ2i7NYSIQBXiLSD673ZvEOP14ROber75e9NknV+mVPrJfy1u1Kwz 8tPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=N9wGEZYJoAIhx351pyXi5TmAw4uiOf0aUU7wFJx73AA=; b=RaymuOEcF6MHM3tT9v9kw6WJlilMnZgYYOw7BCGL/9u2eeBUAtoUjqjejJ9oTaYLtU v88cGIhfXpamnIgnNv/ZNh2Z1J7NVNvz3g9oUXs6sTKSRDxoUq3/82Yo88gO1gWvd2Di /sbpVH1UcFoVuD/1WDBUeW5nYGTrt7MnpVxhoEyp/lgAd0yjuJLJyYi1gVOs6CoJlOFt W6gh+o0Z14iqP6q60V0wkuWEYHY2cAI0ZRSqrfzS/2rjUzFtZ1W9iGd1pc3HyoirlUmL rDl+DIvlupIsl8yn/Cs/pneHqy3qMEuRIBA42CKekLo8zAQf14pb6cq8+fg6d2HZDyaf ppUQ== X-Gm-Message-State: AOAM533CIZLeEl9vGikNDYnx0disIey4Nwditueg/4CBGJj0AFXHnbds RujvGYcrvt47boYrbNq3L7gyfA== X-Google-Smtp-Source: ABdhPJy4jSKuKcRpT3rqMHJb0ZPqCblkctt5Ebx8UNzjoft9Q7wfdmHUGu0Dun5/0VYuxQw+cWMWrg== X-Received: by 2002:adf:e482:: with SMTP id i2mr13034372wrm.392.1615542480270; Fri, 12 Mar 2021 01:48:00 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.47.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:47:59 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, "James E.J. Bottomley" , "Martin K. Petersen" , Vladislav Bolkhovitin , Nathaniel Clark , "Nicholas A. Bellinger" , linux-scsi@vger.kernel.org Subject: [PATCH 11/30] scsi: qla2xxx: qla_target: Fix a couple of misdocumented functions Date: Fri, 12 Mar 2021 09:47:19 +0000 Message-Id: <20210312094738.2207817-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/qla2xxx/qla_target.c:6476: warning: expecting prototype for qla_tgt_lport_register(). Prototype was for qlt_lport_register() instead drivers/scsi/qla2xxx/qla_target.c:6546: warning: expecting prototype for qla_tgt_lport_deregister(). Prototype was for qlt_lport_deregister() instead Cc: Nilesh Javali Cc: GR-QLogic-Storage-Upstream@marvell.com Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Vladislav Bolkhovitin Cc: Nathaniel Clark Cc: "Nicholas A. Bellinger" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/qla2xxx/qla_target.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index c48daf52725d9..67c6a2710360a 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -6462,7 +6462,7 @@ static void qlt_lport_dump(struct scsi_qla_host *vha, u64 wwpn, } /** - * qla_tgt_lport_register - register lport with external module + * qlt_lport_register - register lport with external module * * @target_lport_ptr: pointer for tcm_qla2xxx specific lport data * @phys_wwpn: physical port WWPN @@ -6538,7 +6538,7 @@ int qlt_lport_register(void *target_lport_ptr, u64 phys_wwpn, EXPORT_SYMBOL(qlt_lport_register); /** - * qla_tgt_lport_deregister - Degister lport + * qlt_lport_deregister - Degister lport * * @vha: Registered scsi_qla_host pointer */ From patchwork Fri Mar 12 09:47:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134115 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F335C43381 for ; Fri, 12 Mar 2021 09:49:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBA5164FFB for ; Fri, 12 Mar 2021 09:49:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232930AbhCLJse (ORCPT ); Fri, 12 Mar 2021 04:48:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233036AbhCLJsE (ORCPT ); Fri, 12 Mar 2021 04:48:04 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E0D0C061765 for ; Fri, 12 Mar 2021 01:48:03 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id j4-20020a05600c4104b029010c62bc1e20so14792030wmi.3 for ; Fri, 12 Mar 2021 01:48:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JI6G3CFZx8fwaZ+wMXfyA1uTc9sykYtKryE0jb27AH8=; b=LvZZjQqh+hYVHovFbGfa2YimjbNcopAKf2FZ41k0JafVuhVFK5teA3JpIbZo04IirG T3FE3HwLMHe3hRd4f1e7pYFuzKcngzqClIHRJv58wKOf6YLyHr3oW4NEZFrlvIPqiAAD umvPHJzcpzO3EazANHiX3Z7AWtRY+KMq52oDleuaqE9FW91NrAZefDoeKN0dTnaSosX7 2x2qTmSphRDpvMTdnfVqbdq2Tp0ry+NQoyXkK+cxZOn14bKVik5jWKcbf0LTIfBpgqwi qvPSsYPc25e6pL72RE1CUAk1N+qZT0yk5IYUEdanwW0Ul3rymue2UDxEZXoyyu9DE5ab 7TXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JI6G3CFZx8fwaZ+wMXfyA1uTc9sykYtKryE0jb27AH8=; b=mbJr13CPrVOoYFSy2PXwxha8IxmbxeOHS++4rRKKTqKScKWPaso+4Gdyv0nUG+10FI gcafGQRisUlkZq+c5RmI+usdikrzruKNgvItIjMMSBGr18D4UjF3J7AcVWEU6Dg5p4WA izN4WVvTtNF5emtCS6XgF3F35qoMH3sJX6EWWwfacWx9HXcd+tIg6Aslv+7w6sBRIgVq 9DGWw3u2eB6EaRMn6d3SAU9Tp0dvHcbRQ0QcSsgwceDXYMVeTc1flwIzI+nEQDeJYYY2 1D+QcFZL5hhjlV9er3GpANKaCC0RI4ziKQ5+6oLncoaHk/GwfXiK69BRoSJvJ0IMjNZS 3ERA== X-Gm-Message-State: AOAM530jdWo4RAoGFF9pnQV4z9PlVZ8g6jHRHFB5HKFQmNL7rieIfd8y GulIGZ/585mmWYNERW9WQn3OSg== X-Google-Smtp-Source: ABdhPJwgu+dYkUSJIPzhrkavhgPa19SJxwU7Gw7kkrY+EIpO5oTC5zDDwsUJvZSioQsoR2R3olJXOQ== X-Received: by 2002:a1c:9817:: with SMTP id a23mr12073936wme.57.1615542482068; Fri, 12 Mar 2021 01:48:02 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.48.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:48:01 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 12/30] scsi: lpfc: lpfc_debugfs: Fix incorrectly documented function lpfc_debugfs_commonxripools_data() Date: Fri, 12 Mar 2021 09:47:20 +0000 Message-Id: <20210312094738.2207817-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/lpfc/lpfc_debugfs.c:405: warning: expecting prototype for lpfc_debugfs_common_xri_data(). Prototype was for lpfc_debugfs_commonxripools_data() instead Cc: James Smart Cc: Dick Kennedy Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/lpfc/lpfc_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c index ec5328f7f1d41..c23a535ac89ac 100644 --- a/drivers/scsi/lpfc/lpfc_debugfs.c +++ b/drivers/scsi/lpfc/lpfc_debugfs.c @@ -381,7 +381,7 @@ lpfc_debugfs_hbqinfo_data(struct lpfc_hba *phba, char *buf, int size) static int lpfc_debugfs_last_xripool; /** - * lpfc_debugfs_common_xri_data - Dump Hardware Queue info to a buffer + * lpfc_debugfs_commonxripools_data - Dump Hardware Queue info to a buffer * @phba: The HBA to gather host buffer info from. * @buf: The buffer to dump log into. * @size: The maximum amount of data to process. From patchwork Fri Mar 12 09:47:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134117 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70E67C4332E for ; Fri, 12 Mar 2021 09:49:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F47464FB9 for ; Fri, 12 Mar 2021 09:49:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233187AbhCLJsi (ORCPT ); Fri, 12 Mar 2021 04:48:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233049AbhCLJsE (ORCPT ); Fri, 12 Mar 2021 04:48:04 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41FC5C0613D7 for ; Fri, 12 Mar 2021 01:48:04 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id y124-20020a1c32820000b029010c93864955so15387224wmy.5 for ; Fri, 12 Mar 2021 01:48:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LUTl6374hjxEzzjAtH58mHOxzvcGWyfAK+Rs8bCebzw=; b=Hh6zFui7TwDn62/fwoASFc2WJnZn7cfVhnggojLiwpEHU6m48GwA0Lnx70kBF5ANG1 20F+vJb7p5+wSCdx945D/L5JHQutDAnvsfvQIvQ3nFS8dC2MhtOzyApGrceHEjti/RMb XFfHi6yUPyANab+8/0QfMzKjdkxj/iyG9YVFreuTjGV9+B0YKbHV0QmZYD2x6PFIxfcA 2mUd2ivVz9n13uBEkKatPUtdhkdjL2BZeoPc5u/DR41wJZfAm4ynWx0gLig0uR4OFZp3 JeUfFBr+fVAriffDt7K+/1352rpnWyWDUQPfVwP9SsNTVzKH3MfrTtKJOBdWpdaPQgBD 9VsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LUTl6374hjxEzzjAtH58mHOxzvcGWyfAK+Rs8bCebzw=; b=nOeMbVzuAwQuMId0GLO5QKOlVoUp5EGg92UBp3z77t5wD19FW1haP841aaycfDOQgB WDKoirJd4/EwHEt4b1G85sxbL4X/PeQ4ARMvhkqbh/qJ4bCJuUxT0jwJgZo/wgzQ7iJM rqwESJeeFEt2z658YC3o9fGTpz1qqLr8IagP4OQIJPCFj8YxdsuexRbf0alcdfiFw+WY SBYr/Cg0y2qsGZsVe9bHtRYCBio5IYeQRHoHxMGulY0QLnWvbFayJ2wEPAfa0yzyCzpG ZtYHqEJPWsMJYZE3gd8A1lOIm0WltlPz5fCJP/2IShf+gzIpSrZ6rAThT8koyu3ZC0Lb IgsA== X-Gm-Message-State: AOAM533Kv1LdN7KB2kCmfvjrxadRWKAK1fNMJf3UTnruZucFtOS8ttzf 6bEdVQCZzS7T8g0Opy1rsZ2Kjg== X-Google-Smtp-Source: ABdhPJzn/shtTEA5v/Qw1hr7rVbUOF0K5gx7TDUttgAS1sUo633Z1joLB92r7MaR0cdeyDjNVXN09g== X-Received: by 2002:a05:600c:4a06:: with SMTP id c6mr12177115wmp.35.1615542482970; Fri, 12 Mar 2021 01:48:02 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.48.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:48:02 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 13/30] scsi: lpfc: lpfc_bsg: Fix a few incorrectly named functions Date: Fri, 12 Mar 2021 09:47:21 +0000 Message-Id: <20210312094738.2207817-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/lpfc/lpfc_bsg.c:3591: warning: expecting prototype for lpfc_bsg_mbox_ext_cleanup(). Prototype was for lpfc_bsg_mbox_ext_session_reset() instead drivers/scsi/lpfc/lpfc_bsg.c:3885: warning: expecting prototype for lpfc_bsg_sli_cfg_mse_read_cmd_ext(). Prototype was for lpfc_bsg_sli_cfg_read_cmd_ext() instead drivers/scsi/lpfc/lpfc_bsg.c:4371: warning: expecting prototype for lpfc_bsg_mbox_ext_abort_req(). Prototype was for lpfc_bsg_mbox_ext_abort() instead Cc: James Smart Cc: Dick Kennedy Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/lpfc/lpfc_bsg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c index b974d39d233b8..503540cf20414 100644 --- a/drivers/scsi/lpfc/lpfc_bsg.c +++ b/drivers/scsi/lpfc/lpfc_bsg.c @@ -3580,7 +3580,7 @@ static int lpfc_bsg_check_cmd_access(struct lpfc_hba *phba, } /** - * lpfc_bsg_mbox_ext_cleanup - clean up context of multi-buffer mbox session + * lpfc_bsg_mbox_ext_session_reset - clean up context of multi-buffer mbox session * @phba: Pointer to HBA context object. * * This is routine clean up and reset BSG handling of multi-buffer mbox @@ -3869,7 +3869,7 @@ lpfc_bsg_sli_cfg_dma_desc_setup(struct lpfc_hba *phba, enum nemb_type nemb_tp, } /** - * lpfc_bsg_sli_cfg_mse_read_cmd_ext - sli_config non-embedded mailbox cmd read + * lpfc_bsg_sli_cfg_read_cmd_ext - sli_config non-embedded mailbox cmd read * @phba: Pointer to HBA context object. * @job: Pointer to the job object. * @nemb_tp: Enumerate of non-embedded mailbox command type. @@ -4360,7 +4360,7 @@ lpfc_bsg_handle_sli_cfg_mbox(struct lpfc_hba *phba, struct bsg_job *job, } /** - * lpfc_bsg_mbox_ext_abort_req - request to abort mbox command with ext buffers + * lpfc_bsg_mbox_ext_abort - request to abort mbox command with ext buffers * @phba: Pointer to HBA context object. * * This routine is for requesting to abort a pass-through mailbox command with From patchwork Fri Mar 12 09:47:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134119 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62A80C43331 for ; Fri, 12 Mar 2021 09:49:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FDF664F00 for ; Fri, 12 Mar 2021 09:49:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232850AbhCLJsf (ORCPT ); Fri, 12 Mar 2021 04:48:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233069AbhCLJsF (ORCPT ); Fri, 12 Mar 2021 04:48:05 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 138BCC061765 for ; Fri, 12 Mar 2021 01:48:05 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id o26so3398358wmc.5 for ; Fri, 12 Mar 2021 01:48:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8874Mz34yg9EJ3yZWmxIP9iMB3o9NkD0mVwqsVKhHmY=; b=o0BhCUd++tGlcXgX6faAKPu2hCqjqGs2qb816ITnEc14L07dK1WHygs8EnBtYDDsOU MwTh9vIbnLiglv1nQFzUYqPnIAz+PaclqTNvxLvOoN/g3gQCz05qCJ/e5F2o60zMyBI6 chGkjD8hPZBbvRsZ+dIiPQ7kdWA878XJsgcu0fD978dvkU2Jn8FhbUwW/BIyOK3LvwzR rzY1ry6xzObfgarnG5Ih4CyEc1CY0p4TgwFcy0gfFlO0DaB05hUhv+I5oPg7d0ma0ZZD DMEdSlISoKyiNOOehfen4oiQfx6H1U6nLLXf9EickgQTIhBvGKj96vdaZqHV+t0cZV/E qlYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8874Mz34yg9EJ3yZWmxIP9iMB3o9NkD0mVwqsVKhHmY=; b=tM6gh/mjlQX82VBZQCPkxPobH6huQqgT0RyU4ejSKRQFI1j6e5NHZRVspR+xz827OT nH6iZeQvLiRsEOcBbzz1dh4ruWxyfkVE5ePL5u5DIT5ihds8RNMnQ7F6z1Jqu22dSsq9 InekELXwKwdEWkXdcSf5TnRnqTEU9ahM3NN3o8i3PuOl7sYs04EYIiXaqSrm4A5dXPXU oytmBiXfvN99RJjnyhPTA7n0kDBmufMv+qq7LlAymdeQt5rpbJjIFF98uTDg/XZZG5dp kFzFbJJs3F0kOVJ51hLdKMF6c97Ry4j5RnmZ9p33nW8JOuatmZuGEafxEnGxVY9U1JQH 9FhA== X-Gm-Message-State: AOAM531N/vV4H8U1mxSalhMo9c+4xN6DgBExb5Mr/w57hJgOwEiq4dJS pcBby7isP/mj4f0aucYsPCb6dg== X-Google-Smtp-Source: ABdhPJxqBCiJeEamdxeuuAVeWji1bOWp989ocCw4YG2BybqIQUG3wCEW7s9DvtjCe5OkWTV9fBuTJA== X-Received: by 2002:a1c:f614:: with SMTP id w20mr12006715wmc.70.1615542483828; Fri, 12 Mar 2021 01:48:03 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.48.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:48:03 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Anil Gurumurthy , Sudarsana Kalluru , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 14/30] scsi: bfa: bfa_fcs_lport: Move a large struct from the stack onto the heap Date: Fri, 12 Mar 2021 09:47:22 +0000 Message-Id: <20210312094738.2207817-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/bfa/bfa_fcs_lport.c: In function ‘bfa_fcs_lport_fdmi_build_rhba_pyld’: drivers/scsi/bfa/bfa_fcs_lport.c:2152:1: warning: the frame size of 1200 bytes is larger than 1024 bytes [-Wframe-larger-than=] Cc: Anil Gurumurthy Cc: Sudarsana Kalluru Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/bfa/bfa_fcs_lport.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/bfa/bfa_fcs_lport.c b/drivers/scsi/bfa/bfa_fcs_lport.c index 49a14157f123c..b12afcc4b1894 100644 --- a/drivers/scsi/bfa/bfa_fcs_lport.c +++ b/drivers/scsi/bfa/bfa_fcs_lport.c @@ -1408,7 +1408,7 @@ static void bfa_fcs_lport_fdmi_rpa_response(void *fcsarg, u32 resid_len, struct fchs_s *rsp_fchs); static void bfa_fcs_lport_fdmi_timeout(void *arg); -static u16 bfa_fcs_lport_fdmi_build_rhba_pyld(struct bfa_fcs_lport_fdmi_s *fdmi, +static int bfa_fcs_lport_fdmi_build_rhba_pyld(struct bfa_fcs_lport_fdmi_s *fdmi, u8 *pyld); static u16 bfa_fcs_lport_fdmi_build_rprt_pyld(struct bfa_fcs_lport_fdmi_s *fdmi, u8 *pyld); @@ -1887,6 +1887,8 @@ bfa_fcs_lport_fdmi_send_rhba(void *fdmi_cbarg, struct bfa_fcxp_s *fcxp_alloced) bfa_fcs_lport_fdmi_build_rhba_pyld(fdmi, (u8 *) ((struct ct_hdr_s *) pyld + 1)); + if (attr_len < 0) + return; bfa_fcxp_send(fcxp, NULL, port->fabric->vf_id, port->lp_tag, BFA_FALSE, FC_CLASS_3, (len + attr_len), &fchs, @@ -1896,17 +1898,20 @@ bfa_fcs_lport_fdmi_send_rhba(void *fdmi_cbarg, struct bfa_fcxp_s *fcxp_alloced) bfa_sm_send_event(fdmi, FDMISM_EVENT_RHBA_SENT); } -static u16 +static int bfa_fcs_lport_fdmi_build_rhba_pyld(struct bfa_fcs_lport_fdmi_s *fdmi, u8 *pyld) { struct bfa_fcs_lport_s *port = fdmi->ms->port; - struct bfa_fcs_fdmi_hba_attr_s hba_attr; - struct bfa_fcs_fdmi_hba_attr_s *fcs_hba_attr = &hba_attr; + struct bfa_fcs_fdmi_hba_attr_s *fcs_hba_attr; struct fdmi_rhba_s *rhba = (struct fdmi_rhba_s *) pyld; struct fdmi_attr_s *attr; + int len; u8 *curr_ptr; - u16 len, count; - u16 templen; + u16 templen, count; + + fcs_hba_attr = kzalloc(sizeof(*fcs_hba_attr), GFP_KERNEL); + if (!fcs_hba_attr) + return -ENOMEM; /* * get hba attributes @@ -2148,6 +2153,9 @@ bfa_fcs_lport_fdmi_build_rhba_pyld(struct bfa_fcs_lport_fdmi_s *fdmi, u8 *pyld) len += ((sizeof(attr->type) + sizeof(attr->len)) * count); rhba->hba_attr_blk.attr_count = cpu_to_be32(count); + + kfree(fcs_hba_attr); + return len; } From patchwork Fri Mar 12 09:47:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134123 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFEF3C43603 for ; Fri, 12 Mar 2021 09:49:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1BF264F00 for ; Fri, 12 Mar 2021 09:49:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232988AbhCLJsj (ORCPT ); Fri, 12 Mar 2021 04:48:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233086AbhCLJsG (ORCPT ); Fri, 12 Mar 2021 04:48:06 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 121F4C061765 for ; Fri, 12 Mar 2021 01:48:06 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id 7so4443978wrz.0 for ; Fri, 12 Mar 2021 01:48:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eMNrAANtdSm/KApZn99Iy+ukBxQxfETDJsJVLnxM0ss=; b=spXmC2/JKBd/fcKoBaLN9rUOh2lrc8tlt/Qu9hmPrnaeLvL63dpxTr1rk3azNkhEJp llosrA2xyN1pBe3gTj9enA2OyaeYkUPSOl12KZuF7jtIIvQImi/x2W6oFgn9LXvkuF4u 82utRDsAJEKoRbxoQxP7mNunsoW+/4xMr6xo3QnXC9Wp5pQbqj4dCD9ENN2J6lhyXr4p 9CVAGqSGvuP1Nj3MDNGt218pVtsI0f+zbDmiHSR6Xu5zkt7oMDTUI/qu4wlh2k7Rivl5 w3ZCdNiaeo1iCB2fNiYzA6WQXnXxRfmMwJ9J65DSZnq6+LBbBu7472RsKhT30KGSxzjq zU1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eMNrAANtdSm/KApZn99Iy+ukBxQxfETDJsJVLnxM0ss=; b=gWSQNIC1IVe/fOllv/RESQO8ZVpL8uV4P4ek8ViKZe0JE+pUcRr4+KnQgfCEIPDIE9 pBinVhgQVGFr9JNzq8A7t/56SONEO+mQdR/7dTV7tYWgcyDC2jljDDwI0kit1hhZrbku MQ9klOIghyI0hYBi/kyANKPzWFx5hcioWKYWNRoCzob00dCSbAPWDpPYBGS03DTPNxnr 8+zEfuBpFdhAMAFEVozciLvAU6TqFNpZPjypiP9yB1OEQr4Am+aOSJed32Hg956PxlrY d4kMnlp0toycpLoyM/Wm/ciSrGisjNFkEWk0oMhvoEkVyXDzAATtZ5RYr+pl0GTqN9w0 bZ1g== X-Gm-Message-State: AOAM532jI8sLhBWIUdEqaK1LyFyYHJNUTwcZWRGWyR4VPt/S1ytSpSn7 3uYrcg0jfJv0BauXIT3ujTS/PQ== X-Google-Smtp-Source: ABdhPJz+tnrsV1zdhCqwNcgmv8npJAuDGV5x5Q9B4Ny0XY8vHHMg9Ea6dY2WeSjB6/3frN5TEVKzBw== X-Received: by 2002:a5d:4521:: with SMTP id j1mr12820216wra.354.1615542484778; Fri, 12 Mar 2021 01:48:04 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.48.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:48:04 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 15/30] scsi: lpfc: lpfc_nvme: Fix kernel-doc formatting issue Date: Fri, 12 Mar 2021 09:47:23 +0000 Message-Id: <20210312094738.2207817-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/lpfc/lpfc_nvme.c:2021: warning: Function parameter or member 'vport' not described in 'lpfc_nvme_create_localport' Cc: James Smart Cc: Dick Kennedy Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/lpfc/lpfc_nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c index 5fe4e93fe984e..4d78eadb65c0a 100644 --- a/drivers/scsi/lpfc/lpfc_nvme.c +++ b/drivers/scsi/lpfc/lpfc_nvme.c @@ -2002,7 +2002,7 @@ lpfc_release_nvme_buf(struct lpfc_hba *phba, struct lpfc_io_buf *lpfc_ncmd) /** * lpfc_nvme_create_localport - Create/Bind an nvme localport instance. - * @vport - the lpfc_vport instance requesting a localport. + * @vport: the lpfc_vport instance requesting a localport. * * This routine is invoked to create an nvme localport instance to bind * to the nvme_fc_transport. It is called once during driver load From patchwork Fri Mar 12 09:47:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134129 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2C7DC4321A for ; Fri, 12 Mar 2021 09:49:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B746665011 for ; Fri, 12 Mar 2021 09:49:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233192AbhCLJsi (ORCPT ); Fri, 12 Mar 2021 04:48:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233089AbhCLJsH (ORCPT ); Fri, 12 Mar 2021 04:48:07 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08DAEC061574 for ; Fri, 12 Mar 2021 01:48:07 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id k8so1400360wrc.3 for ; Fri, 12 Mar 2021 01:48:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hb0h53+N/nT00wb74f1MjjQ1bTOb0RVG4vqVQWcHEZE=; b=P9B9CY2lD1RdF3q6iypPdFIU6at6cohz33wf9IqIkmzQbrlSn4Fsuw17QK/UZKPAhP ASbDjeI+KkpcxYf6NDz/oTk3ICjql66swpNRESmOpxbPMuWlaY9vIvCZbYJpJHtEcTUn rXaHQ9sCz9SbTNaRUSJUPM0GG9XAU7z7IogPGxd9zELtdCTZ05IkfZRHSCThYER5NGqU Ho2/dJngFDhZJkpI9IoHP/P2HYJKSQmGBKRigNKIaYQ83WnLkrBBRzK9vk16ektyswNM pix6qOdIdeav+F255QcqumBdOHkhJ81O3iJqZfADq/2Xhp1zi868k8/RN+SiALY0FMej h6ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hb0h53+N/nT00wb74f1MjjQ1bTOb0RVG4vqVQWcHEZE=; b=FzFagpg4Z+xWBTHK1j2VxchTjAd3YwPyCmmiErSkChX5wyIlRw411fOP2Rm2aBCnHC JfRno/6mEsUwMx34BGsQcJlysMOX6/mqD4JBXMOXdNc/eY53xbVvIaSqy/6MyOaAtBUD Rg72Vd+5KOAQzrKCYFiYyvQExK8HuMOn7jTSfWl5lqOyflXbnLxQ7sROBWX3k3a5pwI8 7ELo1hlsQ7k30EN0k3V77m2t0Hc3vQZvSTyACH1j+1bsXchNHMsImAzN1vaDAbyWiDDJ v76h4tHM3gNyVI0VxNp3R2JAs9C/kSZFobOZEhzewCkmBMvsiAEvdwFHaOIYjqvf70es CPFw== X-Gm-Message-State: AOAM533rQrlAEsPS/qdJ8DJ6aGLv72/VOMV4ERMQpOgpPWP6ibLFKBoI Ce5x9C3C2AjeHmPykcU0JdIgtg== X-Google-Smtp-Source: ABdhPJw9hVpTqUn8hfq8z50GtH+UEJaYIa62uf4N+tcmdzYne1haCmli1AcNq2/MJJLn7bCD7XfTow== X-Received: by 2002:a05:6000:245:: with SMTP id m5mr13372111wrz.284.1615542485738; Fri, 12 Mar 2021 01:48:05 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.48.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:48:05 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Jan Kotas , linux-scsi@vger.kernel.org Subject: [PATCH 16/30] scsi: ufs: cdns-pltfrm: Supply function names for headers Date: Fri, 12 Mar 2021 09:47:24 +0000 Message-Id: <20210312094738.2207817-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/ufs/cdns-pltfrm.c:109: warning: expecting prototype for Sets HCLKDIV register value based on the core_clk(). Prototype was for cdns_ufs_set_hclkdiv() instead drivers/scsi/ufs/cdns-pltfrm.c:144: warning: wrong kernel-doc identifier on line: drivers/scsi/ufs/cdns-pltfrm.c:160: warning: wrong kernel-doc identifier on line: drivers/scsi/ufs/cdns-pltfrm.c:176: warning: wrong kernel-doc identifier on line: Cc: Alim Akhtar Cc: Avri Altman Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Stanley Chu Cc: Jan Kotas Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/ufs/cdns-pltfrm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/ufs/cdns-pltfrm.c b/drivers/scsi/ufs/cdns-pltfrm.c index 149391faa19c1..13d92043e13b0 100644 --- a/drivers/scsi/ufs/cdns-pltfrm.c +++ b/drivers/scsi/ufs/cdns-pltfrm.c @@ -100,6 +100,7 @@ static void cdns_ufs_set_l4_attr(struct ufs_hba *hba) } /** + * cdns_ufs_set_hclkdiv() * Sets HCLKDIV register value based on the core_clk * @hba: host controller instance * @@ -141,6 +142,7 @@ static int cdns_ufs_set_hclkdiv(struct ufs_hba *hba) } /** + * cdns_ufs_hce_enable_notify() * Called before and after HCE enable bit is set. * @hba: host controller instance * @status: notify stage (pre, post change) @@ -157,6 +159,7 @@ static int cdns_ufs_hce_enable_notify(struct ufs_hba *hba, } /** + * cdns_ufs_hibern8_notify() * Called around hibern8 enter/exit. * @hba: host controller instance * @cmd: UIC Command @@ -173,6 +176,7 @@ static void cdns_ufs_hibern8_notify(struct ufs_hba *hba, enum uic_cmd_dme cmd, } /** + * cdns_ufs_link_startup_notify() * Called before and after Link startup is carried out. * @hba: host controller instance * @status: notify stage (pre, post change) From patchwork Fri Mar 12 09:47:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134153 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5715DC41519 for ; Fri, 12 Mar 2021 09:49:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FC5364FF3 for ; Fri, 12 Mar 2021 09:49:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233322AbhCLJsv (ORCPT ); Fri, 12 Mar 2021 04:48:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233141AbhCLJsV (ORCPT ); Fri, 12 Mar 2021 04:48:21 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29F00C061574 for ; Fri, 12 Mar 2021 01:48:09 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id l19so3399649wmh.1 for ; Fri, 12 Mar 2021 01:48:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cAgrlXd2l1LJdhAbUiQiEGzy9+X15djTsbIgtd+mY2I=; b=lVMCHULUc5/aA9eGRFFQrjna7vIsiRzLtnqSsoC0NJMHqsv/u8vvcgXmV6Cqq8tRDa MHdCbm9U1qbzrGZJhJL3k1zKbbjt/SwoVE91G4peiMCu0bQzrQN0/lzOu7g9leTDUEi5 a8X/Y3TwSYRE6y1WsHvze5bFHmLgPq5tgSumBnDRe5iSEWaLyjPjhwWld48S/Ddp5iwG pBgnAxqhCyeoZB9+R8q2++w0gN2CP8I0ulVZNlJvcoecnG0LoGlV80vFU2P4v9Ped6+4 ash1+yOFmYD0afs62CoH6VLeKAXPSpbH9+pK54Vyi/SNC08nB+xGwthDnf0hqgNIQMee BJCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cAgrlXd2l1LJdhAbUiQiEGzy9+X15djTsbIgtd+mY2I=; b=bC2fuvWnRLFkbDDsPlf3kxi1xRInBu/RQWqDeddQCxfaPo8k2QSszNtODJDRXelcxn dSKu4quYtM4mEqN68qCMLg3QbCAbOsi8CAbzpAS3kkFuCIIsEJbvBwNHiMXoFDznD2Fa 3OHGx+3swBq8+HHI4L4yKF1rZj6zIFMUABwb/X7CGgYzBCEbt8MZTlaXoPycJm+YoyYX qFp3jcDacnQKx7SsqDSkpWUx0VcUErfsigcCh6L8BR586Hby8rWP/1GmdLbP5WhxlPcB 59NSwoJ2g8ciY5OjI7FpJkztrL6TSUaZ8UUIGcUsw0X+yx0tGIYdCEIOIqCAD/Qn/+X3 aaPA== X-Gm-Message-State: AOAM532keHn6XIwSL5avAR3p1qk85HRBKnC/WB2ue4q4kYY3sczFc0ia wNL/lrxqeegAuePAy7Q1WXcWKX0kvMyIqw== X-Google-Smtp-Source: ABdhPJxtxs+yAdlG3bLdXNsyC/3JEqEfDxibDtPZ2HJjVgqSmtWHsn8Q0+9JVZCgM1P++N0ANZzplg== X-Received: by 2002:a1c:5416:: with SMTP id i22mr12228165wmb.146.1615542486634; Fri, 12 Mar 2021 01:48:06 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.48.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:48:06 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Karen Xie , "James E.J. Bottomley" , "Martin K. Petersen" , Dimitris Michailidis , linux-scsi@vger.kernel.org Subject: [PATCH 17/30] scsi: cxgbi: cxgb3i: cxgb3i: Fix misnaming of ddp_setup_conn_digest() Date: Fri, 12 Mar 2021 09:47:25 +0000 Message-Id: <20210312094738.2207817-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/cxgbi/cxgb3i/cxgb3i.c:1189: warning: expecting prototype for cxgb3i_setup_conn_digest(). Prototype was for ddp_setup_conn_digest() instead Cc: Karen Xie Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Dimitris Michailidis Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c index 37d99357120fa..203f938fca7e5 100644 --- a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c +++ b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c @@ -1177,7 +1177,7 @@ static int ddp_setup_conn_pgidx(struct cxgbi_sock *csk, } /** - * cxgb3i_setup_conn_digest - setup conn. digest setting + * ddp_setup_conn_digest - setup conn. digest setting * @csk: cxgb tcp socket * @tid: connection id * @hcrc: header digest enabled From patchwork Fri Mar 12 09:47:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134125 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D0DCC4361B for ; Fri, 12 Mar 2021 09:49:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFA536502A for ; Fri, 12 Mar 2021 09:49:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233215AbhCLJsn (ORCPT ); Fri, 12 Mar 2021 04:48:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233100AbhCLJsJ (ORCPT ); Fri, 12 Mar 2021 04:48:09 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB113C061765 for ; Fri, 12 Mar 2021 01:48:08 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id g8so3402961wmd.4 for ; Fri, 12 Mar 2021 01:48:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KspmBqbjk4SwVrkpMki278CpteugIPA4FRqHSDe0Ld8=; b=PfGNhCuiylvRyEiNZbO3LIdrXW/jc8eL59kkSyl0fViEKSTvsMn788NKa9LkvSHVLH 4FoPEU09JiF2MA2h1DJYFfxnkP1qKskNvqzfBDULEjOXaBiPIAbd9KAsZYtf50acv42U KQO2+3lXXPHEQOnxhf8KMTySQQKLrWDgGjUc2wVPvb6+oFWCSXYxn39ljfOAxVyKSyXE LPG2cZ+0LPQPtEkZAB8jrfbqi3I59gQw1yI1y/8C4evLcB/FPOGPGcLIOA7ncUlrILxv K4hRklub2FTrgHEVXdYEhqHkl7q6ZVG2D/lAw2qpgNCXd8AZaE3yHfvnWwiPUMof3izN Sstg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KspmBqbjk4SwVrkpMki278CpteugIPA4FRqHSDe0Ld8=; b=Q55d1bCM1fXlLK8DB8Yf5BXmXCV/DcNeh0yA2CjB8a31dDJGtYjSmy2/GpouUKH69g CvMZiYKCYZuElU9D5h+tjObWUlNS11mD5W25xzOML4t3YupSPG3RWzgiOr3TeI/akikF tfx+ZaaEOe83+7V44JsQx4fNO69t+U5QRwFTLLL48OGrm0SHpRpXr/UTCwT1oLXf8PiA pnxZB9+udodvrx8CJosjg0eYt92ulB8xnM5LPg34l9L5Mo8I1TtRycL2JjCLx4oBAXbE voJTo1ESCiXKeeipNkQSKfpILquJx84DlLM3rIB8HwyDrqPUFoMnW1bmuiFaxRPRitrH xYmw== X-Gm-Message-State: AOAM533xHst8JVojkKb16B8qTubU5Pvdy7u79JfCqLwmXeEUlJjrgqYS x0b7MmtdZwmXkC6WMIXMu46fh/USNG1FSw== X-Google-Smtp-Source: ABdhPJxEJ4kH9AI7TGyWx1qdbaHektoIOh8enAFviuPK++9j/6n683lyESUY0h4BrPuidfioDst4XQ== X-Received: by 2002:a7b:c209:: with SMTP id x9mr12178799wmi.92.1615542487458; Fri, 12 Mar 2021 01:48:07 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.48.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:48:07 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Bradley Grove , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 18/30] scsi: esas2r: esas2r_log: Supply __printf(x, y) formatting for esas2r_log_master() Date: Fri, 12 Mar 2021 09:47:26 +0000 Message-Id: <20210312094738.2207817-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/esas2r/esas2r_log.c: In function ‘esas2r_log_master’: drivers/scsi/esas2r/esas2r_log.c:155:3: warning: function ‘esas2r_log_master’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] Cc: Bradley Grove Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/esas2r/esas2r_log.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/esas2r/esas2r_log.c b/drivers/scsi/esas2r/esas2r_log.c index b545798e400c4..d6c87a0bae098 100644 --- a/drivers/scsi/esas2r/esas2r_log.c +++ b/drivers/scsi/esas2r/esas2r_log.c @@ -101,6 +101,11 @@ static const char *translate_esas2r_event_level_to_kernel(const long level) } } +#pragma GCC diagnostic push +#ifndef __clang__ +#pragma GCC diagnostic ignored "-Wsuggest-attribute=format" +#endif + /* * the master logging function. this function will format the message as * outlined by the formatting string, the input device information and the @@ -170,6 +175,8 @@ static int esas2r_log_master(const long level, return 0; } +#pragma GCC diagnostic pop + /* * formats and logs a message to the system log. * From patchwork Fri Mar 12 09:47:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134131 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30138C4361A for ; Fri, 12 Mar 2021 09:49:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E05A64FFE for ; Fri, 12 Mar 2021 09:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233225AbhCLJso (ORCPT ); Fri, 12 Mar 2021 04:48:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233102AbhCLJsK (ORCPT ); Fri, 12 Mar 2021 04:48:10 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AC4CC061763 for ; Fri, 12 Mar 2021 01:48:09 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id d191so3386065wmd.2 for ; Fri, 12 Mar 2021 01:48:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c0xQIWF0LqpD3ejHYQPou8t3hq+GeNU8H9TybOS2LNw=; b=q2zFcK2T+TxsaTWb70uP9QaYJfcqs56lOphfBvEwLp5T+od0++x7jWfkS3N6zDqP1L qfrcuCzphl+61KYfIle1u5Jda0b8igwFwYOcT43OmZkc2osvqakwuqrh8ZgbURqQ9Dss jgbURjjvTli938VDvDY4rMASxyCo0HWwo9zA594QXXmhWoBLIyTmftN/B6MyNwV5OH1N Du+tn/W6mRebDhhFDV7pFhYls1ZJy4BCI+CVK73ajDwr1hAFh4sWlAvAfqVW9qUqO7Nj Z/4iGzWUVGsPv4AYDL4UDDq/gXq2fszpi9CmXMEofBKQVQatVdfrDoK5c88Oym6aosbX B1bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c0xQIWF0LqpD3ejHYQPou8t3hq+GeNU8H9TybOS2LNw=; b=K1lfQNqmYSRu6uAavGUdHOJgUCkrWF4Mxy7WlYIxCYvn0A5GRjDYtZgk8UCUjCluIQ xv2qMLaWHQ+8lY/a28tZMjkADEgpeUBndeGKqAGxl7oNOmzeSDJU3J59iPmrGfZB21uM TlNjKQBhDjV4iWNCMpp/DEk7XGo/zhVGx6AG7n9pzonhYH1djftcQaqKmexuKFN90peD HAXQ1FsYDoV0g6/xTmkqiC9t09MnW3jg0wXtTiQcHjg44M3sEVIUaudfarerzHPdSU70 RUkt90VovKvHR/MJSfixrW3gUBP2tNrle3x22P24r7wMpd6D1X+PkEUsZeGzS0P+cRp2 SCiw== X-Gm-Message-State: AOAM5320+RzJyJGMmtqgfV4NV1k4Vt4gRYlgRBfPb92IwZygliCFcztN LcxSkE7OrXjCAVqfc9FWf6JQ7JctQgz+fQ== X-Google-Smtp-Source: ABdhPJyAIadfdHvWxeWQbQwmY00KbvO0nwtdrsrc6gYF6g1mmfhjr/y+Yh6/XWzTSO/vdh+vzZH7hw== X-Received: by 2002:a05:600c:4150:: with SMTP id h16mr12249165wmm.120.1615542488358; Fri, 12 Mar 2021 01:48:08 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.48.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:48:07 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Subbu Seetharaman , Ketan Mukadam , Jitendra Bhivare , "James E.J. Bottomley" , "Martin K. Petersen" , linux-drivers@broadcom.com, linux-scsi@vger.kernel.org Subject: [PATCH 19/30] scsi: be2iscsi: be_iscsi: Fix incorrect naming of beiscsi_iface_config_vlan() Date: Fri, 12 Mar 2021 09:47:27 +0000 Message-Id: <20210312094738.2207817-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/be2iscsi/be_iscsi.c:312: warning: expecting prototype for beiscsi_set_vlan_tag(). Prototype was for beiscsi_iface_config_vlan() instead Cc: Subbu Seetharaman Cc: Ketan Mukadam Cc: Jitendra Bhivare Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-drivers@broadcom.com Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/be2iscsi/be_iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_iscsi.c b/drivers/scsi/be2iscsi/be_iscsi.c index a13c203ef7a9a..0e935c49b57bd 100644 --- a/drivers/scsi/be2iscsi/be_iscsi.c +++ b/drivers/scsi/be2iscsi/be_iscsi.c @@ -295,7 +295,7 @@ void beiscsi_iface_destroy_default(struct beiscsi_hba *phba) } /** - * beiscsi_set_vlan_tag()- Set the VLAN TAG + * beiscsi_iface_config_vlan()- Set the VLAN TAG * @shost: Scsi Host for the driver instance * @iface_param: Interface paramters * From patchwork Fri Mar 12 09:47:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134151 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B168FC2BA11 for ; Fri, 12 Mar 2021 09:49:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BE2064FB9 for ; Fri, 12 Mar 2021 09:49:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233324AbhCLJsw (ORCPT ); Fri, 12 Mar 2021 04:48:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233148AbhCLJsX (ORCPT ); Fri, 12 Mar 2021 04:48:23 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6455C061765 for ; Fri, 12 Mar 2021 01:48:10 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id d139-20020a1c1d910000b029010b895cb6f2so14778986wmd.5 for ; Fri, 12 Mar 2021 01:48:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2+AJW1JfC267V4VbkGwrESDS7kAwVhhZrAmnvaz3wpc=; b=O1HZG9pKPXhi2/2uiwV/azuDXxbonWJ0pNedzgmJEiFRhIQkSvNlPCUid4kweHF91z gIwDWMhccLBJn3mr9SNq22dYv5vjrLxtqCBbnGLnXzHjj0j/izHUjnbSUDaqtjkZip0u eKMZDX1Z+M81t7k5xu2FThyj7NIvdZCdn8GnFaVkac5N50OXJl34WlmHIUZwn0tElxUP HbU4Mle9vuxF+WHdnHO2zClocvyoCf1Pk08B0WDIKOVYiPjc1W/DurTXXurjCgUPpI0c LWBmdvyqQn00K10qB/WLDd+XY9yXUbZZ2p4Peqo1xJaKJG4IkY9Jvx8TlND1rZKFgGUr 9EJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2+AJW1JfC267V4VbkGwrESDS7kAwVhhZrAmnvaz3wpc=; b=bPNXap/8CHFdwMCS8IMFYLi9E2Euyynik1nniY6rtQPQSwF5i27Q+rPr/vfRdjze/c CffoGlANujJ7AwL0vZd3LIzxNW9fFBiL6vT+CQFssDdI0MrrmNqFOXS1mj+ABapkZRTr UhugBrJ/4ZWjRtev6jb/Y1ttejEv2teVCSQPO9RxHldSczZ4WyRxmbn0Y9/KD8i3twrf ct0DyTaay5wPeIrU8VTTpfYNiN9qo/R/pcYwnpJ9t2ytlczVMtSE38c8Cuelq1BEcWz2 soPGS4D8eKdiC5TD7ZZlkpCK1+9qdypJA2p7bUm6b/9+kLAElUK16EuGFfJMSSkjkW/S /gmg== X-Gm-Message-State: AOAM533AQ8qmNuTrX2PeRWEqLXjYhj3RL3OKPl2cogM1NwQKzl8oSkgF KIdgTRjTFmO62qZE/olsfQ0Xxw== X-Google-Smtp-Source: ABdhPJxpw/RCjE9owSu66rCtUR4c1th3a9fvVIAYqX1Lww4ZY4U3NHVX1Vlu4MN2AKV/g9QyFj9MUg== X-Received: by 2002:a05:600c:2053:: with SMTP id p19mr12224316wmg.87.1615542489224; Fri, 12 Mar 2021 01:48:09 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.48.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:48:08 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Subbu Seetharaman , Ketan Mukadam , Jitendra Bhivare , "James E.J. Bottomley" , "Martin K. Petersen" , linux-drivers@broadcom.com, linux-scsi@vger.kernel.org Subject: [PATCH 20/30] scsi: be2iscsi: be_main: Provide missing function name in header Date: Fri, 12 Mar 2021 09:47:28 +0000 Message-Id: <20210312094738.2207817-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/be2iscsi/be_main.c:4934: warning: expecting prototype for Boot flag info for iscsi(). Prototype was for BEISCSI_SYSFS_ISCSI_BOOT_FLAGS() instead Cc: Subbu Seetharaman Cc: Ketan Mukadam Cc: Jitendra Bhivare Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-drivers@broadcom.com Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/be2iscsi/be_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index 90fcddb76f46f..ab32ca535078d 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -4927,6 +4927,7 @@ void beiscsi_start_boot_work(struct beiscsi_hba *phba, unsigned int s_handle) } /** + * beiscsi_show_boot_tgt_info() * Boot flag info for iscsi-utilities * Bit 0 Block valid flag * Bit 1 Firmware booting selected From patchwork Fri Mar 12 09:47:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134159 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66CA2C28E8A for ; Fri, 12 Mar 2021 09:49:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53E7C6500E for ; Fri, 12 Mar 2021 09:49:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233336AbhCLJsx (ORCPT ); Fri, 12 Mar 2021 04:48:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232506AbhCLJsX (ORCPT ); Fri, 12 Mar 2021 04:48:23 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4660DC061762 for ; Fri, 12 Mar 2021 01:48:11 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id j4-20020a05600c4104b029010c62bc1e20so14792270wmi.3 for ; Fri, 12 Mar 2021 01:48:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hpkWY6NYMS6c87pB2jsJw8HPR329QzV5UrX12nsDj8M=; b=wEt1svJzo8LCt1CK0YkcHzEp9mzT31n/KRFxH8GBCa+ZkDK7mTCQ6/IrI1AB8LsfBs cBDOJv6enLMbaGkrhloVBpJfmQepNFtuK4DIZOeYBcEZjOxGTE1GoqZWc8b81v1JMqlL 1gpYWvaDUHBgmukaxGR26rUqjUKjKDJY/ufk0okiy0jJx3QAC3HRLhWIT8MaHT4L9PcT HL5kPw3S2/QfxNBxvOZk84oU1rXt452htkZIEK3XjCpxJdRFyRY/u3IiNJDGN0ZDebMG QKEZXA7HlQoYrNNGjSu41o/VO0OT1l3+RTDOD7XPT7VuLDDYZ3cYH0hcVhStVjv0QjWD 6b4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hpkWY6NYMS6c87pB2jsJw8HPR329QzV5UrX12nsDj8M=; b=D+WEK6FJCwDARNXroB0lbe984GdKSpJf+zfNut+15+fb1ucYFv2DElnxwl3pppYtp6 M/AZRTAKsQQKWN6X63S0idReSFHmGFENO5I8W2aU8k9rwv9QWD2fPMlQXy20Hv446GO1 hSN9YIKUvVGet9pATv9wd6NWZgAajLKwEUWqjb5ex84zYRB1DC5VEwvPoz9VA1l4bg7B c4V2yl6DCOVPjOcVDZUQ/jnjxFpJyC6jpG8JTdO3LwwKeNw8O7OV3wHQuIngxFbk3mfg Dp1LhUfcCF7gF5YTEUe6hVkXn0FIhTOiEX9UgktH3RxQgekZtKpGuYVte9YLTBlJUkTC /pmw== X-Gm-Message-State: AOAM532SdWin+kYWXA1YDOqyEHC02yDv+XCN37r5WLKZg/pP2WxzvP/o XGSH0VVUIzsSjw0vLKHX6bhpjw== X-Google-Smtp-Source: ABdhPJyEd5LCtkwHhO/7yHRdoASg3ahqLZgAspTKJEitIN2uoQg5nqmfAk/BAPZoNagBLl5bLZxTaw== X-Received: by 2002:a7b:c5c7:: with SMTP id n7mr12124569wmk.63.1615542490036; Fri, 12 Mar 2021 01:48:10 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.48.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:48:09 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Subbu Seetharaman , Ketan Mukadam , Jitendra Bhivare , "James E.J. Bottomley" , "Martin K. Petersen" , linux-drivers@broadcom.com, linux-scsi@vger.kernel.org Subject: [PATCH 21/30] scsi: be2iscsi: be_mgmt: Fix beiscsi_phys_port()'s name in header Date: Fri, 12 Mar 2021 09:47:29 +0000 Message-Id: <20210312094738.2207817-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/be2iscsi/be_mgmt.c:1270: warning: expecting prototype for beiscsi_phys_port(). Prototype was for beiscsi_phys_port_disp() instead Cc: Subbu Seetharaman Cc: Ketan Mukadam Cc: Jitendra Bhivare Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-drivers@broadcom.com Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/be2iscsi/be_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c index 0d4928567265d..462717bbb5b7e 100644 --- a/drivers/scsi/be2iscsi/be_mgmt.c +++ b/drivers/scsi/be2iscsi/be_mgmt.c @@ -1256,7 +1256,7 @@ beiscsi_adap_family_disp(struct device *dev, struct device_attribute *attr, } /** - * beiscsi_phys_port()- Display Physical Port Identifier + * beiscsi_phys_port_disp()- Display Physical Port Identifier * @dev: ptr to device not used. * @attr: device attribute, not used. * @buf: contains formatted text port identifier From patchwork Fri Mar 12 09:47:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134135 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 441C9C43142 for ; Fri, 12 Mar 2021 09:49:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EC886500B for ; Fri, 12 Mar 2021 09:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233217AbhCLJsn (ORCPT ); Fri, 12 Mar 2021 04:48:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233109AbhCLJsM (ORCPT ); Fri, 12 Mar 2021 04:48:12 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3075AC0613D9 for ; Fri, 12 Mar 2021 01:48:12 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id n11-20020a05600c4f8bb029010e5cf86347so4235591wmq.1 for ; Fri, 12 Mar 2021 01:48:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5TKoXnvIDGaG9mQ9ffqN6eqPBIG/XMBZKnS/ZHsZvNk=; b=nzyvqhhToDGBMD1H+5K71jkJajZQm+txYMxGQ0Jygup7M6VUx1LUGjKP09It0oOCra 0jncPYC+gtTyQrUAofcH0Xi3FCz/dNw8xqGdD34XErEX+nYFpwt6PkJj/Tfoan7C9rHd uJRciNGzJNNIKe/HEnpOZkGxXQkPA33K9asn+gjxCG/k+LpykVWaoRKkAWQdzJ5qqqMx Xnn060ci19tH0qQO8RZnBLQwc5qWbAkKEmlkUBHewxHrKrxJUsumZNtK2pHP8a074OrI 041a/RcbTcuA+SsMzO2KWyqxdZzFsHFekk+14M1cflenctKg3tdOFPwIARa0KPOa2567 hTFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5TKoXnvIDGaG9mQ9ffqN6eqPBIG/XMBZKnS/ZHsZvNk=; b=EBP1/AA4B4zMfnQi3g6IxfEKkSWaKObaNmeSrzJw4xNItmXOLJjgWBaE4EJnOQaC1p 60maEYHINb3hCTBdzpLzwQfLIBpytxHk3Pqd9JgAMs/gRHF4i0NtLr4m2Mv2Tc3BcBNY 2N+8u69eJw+jVt1VYISFiM6yBJg2xSDIh15g+4Pl76yhCNaAD2OKTfIeghMGJa0tt3Vt zOdvGQ1NubCQfL6ljEs+oL2VSBXz4XaScv5KC355dZexaX49OXJHKPgbqVoBs4ONwubB zvnl6GJYaTuyCaoW4Ad+2UvIa0y7u1sIZZBUOBiZKtBbWq9yNLZyG41QnP/0QqHJXVb3 Uf2w== X-Gm-Message-State: AOAM531l5jWRNx8C8fVJeeuTvtxa+6KD3SS5tIg+XgY9uzw7xMjKIBhN Ksmzj8IM27eGZybMPgqCHSDHnQ== X-Google-Smtp-Source: ABdhPJzi4MxxRcuH6p+fMpBx2PqyIGHoOa+j1FPM4XS9qEplmlHxPBSwTCTFKacVCgvcEPAdK4wZkg== X-Received: by 2002:a1c:9854:: with SMTP id a81mr11827885wme.19.1615542490888; Fri, 12 Mar 2021 01:48:10 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.48.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:48:10 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Nilesh Javali , Manish Rangankar , GR-QLogic-Storage-Upstream@marvell.com, "James E.J. Bottomley" , "Martin K. Petersen" , Anil Veerabhadrappa , Eddie Wai , QLogic-Storage-Upstream@qlogic.com, linux-scsi@vger.kernel.org Subject: [PATCH 22/30] scsi: bnx2i: bnx2i_sysfs: Fix bnx2i_set_ccell_info()'s name in description Date: Fri, 12 Mar 2021 09:47:30 +0000 Message-Id: <20210312094738.2207817-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/bnx2i/bnx2i_sysfs.c:118: warning: expecting prototype for bnx2i_get_link_state(). Prototype was for bnx2i_set_ccell_info() instead Cc: Nilesh Javali Cc: Manish Rangankar Cc: GR-QLogic-Storage-Upstream@marvell.com Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Anil Veerabhadrappa Cc: Eddie Wai Cc: QLogic-Storage-Upstream@qlogic.com Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/bnx2i/bnx2i_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bnx2i/bnx2i_sysfs.c b/drivers/scsi/bnx2i/bnx2i_sysfs.c index 3dc790089f0fc..bea00073cb7cd 100644 --- a/drivers/scsi/bnx2i/bnx2i_sysfs.c +++ b/drivers/scsi/bnx2i/bnx2i_sysfs.c @@ -104,7 +104,7 @@ static ssize_t bnx2i_show_ccell_info(struct device *dev, /** - * bnx2i_get_link_state - set command cell (HQ) size + * bnx2i_set_ccell_info - set command cell (HQ) size * @dev: device pointer * @attr: device attribute (unused) * @buf: buffer to return current SQ size parameter From patchwork Fri Mar 12 09:47:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134139 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7884BC433E0 for ; Fri, 12 Mar 2021 09:49:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5689A64FDC for ; Fri, 12 Mar 2021 09:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232999AbhCLJso (ORCPT ); Fri, 12 Mar 2021 04:48:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233110AbhCLJsN (ORCPT ); Fri, 12 Mar 2021 04:48:13 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 257DBC0613D7 for ; Fri, 12 Mar 2021 01:48:13 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id o26so3398589wmc.5 for ; Fri, 12 Mar 2021 01:48:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=im+Evr3MfJAtsbpRKrSvBZYIR3R8HYWcJI2GsyeTWRU=; b=JkPQfsdV/xUWv0SY461qfK3q2bYhcObyx+c/ou41586IJVFZfrMuJnD+5YnywTsdxD Nsi2nsbPlwBLnRKD5NTTWEkR5qafEDQ5YApC+ppPswZSr2Ady84u8j+Aw2IYnsnIM2D7 pmhbl6A2mRnLP9cheVlyVAGpxoiUgjsBNpOW3kWOFDxrK7WUwX/WTqnsmQEC+jKgnhR2 EKrb3ejNqnB+CGusyX0ZtvKO4bptFsRmyvFgiag41gveYne/umjayMmADrIb7ip/Ht7c 3gQlV+xjtHcJntAG2lTLogCBuXfPyg/m+bVoLVwMFTqc1caobdHS9A1xvtx9g8MDKqoM pIUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=im+Evr3MfJAtsbpRKrSvBZYIR3R8HYWcJI2GsyeTWRU=; b=R3iuyYZ0Ke974iKRAROHcipAC7XicpxjgcaokNqBK3EY7dg3m8j8FQUkS4XDKSxLy4 JvvpBbhcagOUVM2k0T/4TUZb0p1llaVD01UXdDo2YnGtPU4cAQ7MJ1HYV2C9aIdToewB uop2HskgzlEijnKRcE28xZm8ua8rYu0E5gh/+Y0HbV2HcC2fC7VKtVxU/pb0caSnrW9O p9tRzDuHUDHxa6oKcDNE9I2o64EcEVzm81qNDgw35dy8yKmwsml0QKstphrl3YzZ2vet J18aTBkGR2LfrHpkxhx2R0JS25XJByLEGCo6gknx5SgsRtGyLgw2G4hLjgvTnNBf6v3w lXIw== X-Gm-Message-State: AOAM531XwAaj5UQQFnwvjcCczjl0UZWkJhfYKIVmsqnzlxty4F6n4oln StJwYNAViFOOI4De9H9jhSnzLw== X-Google-Smtp-Source: ABdhPJwKraMRGttD3+ezeCjP06uDClb3A9wpDqh0KFnDAjD5VPdHwzk8UFFdiN/EBPN0oaUS/nC5qQ== X-Received: by 2002:a7b:c084:: with SMTP id r4mr12232516wmh.166.1615542491771; Fri, 12 Mar 2021 01:48:11 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.48.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:48:11 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , Bas Vermeulen , Christoph Hellwig , Brian Macy , linux-scsi@vger.kernel.org Subject: [PATCH 23/30] scsi: initio: Remove unused variable 'prev' Date: Fri, 12 Mar 2021 09:47:31 +0000 Message-Id: <20210312094738.2207817-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/initio.c: In function ‘initio_find_busy_scb’: drivers/scsi/initio.c:869:30: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable] Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Bas Vermeulen Cc: Christoph Hellwig Cc: Brian Macy Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Christoph Hellwig --- drivers/scsi/initio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c index 814acc57069dc..926a7045c2e5c 100644 --- a/drivers/scsi/initio.c +++ b/drivers/scsi/initio.c @@ -866,17 +866,16 @@ static void initio_unlink_busy_scb(struct initio_host * host, struct scsi_ctrl_b struct scsi_ctrl_blk *initio_find_busy_scb(struct initio_host * host, u16 tarlun) { - struct scsi_ctrl_blk *tmp, *prev; + struct scsi_ctrl_blk *tmp; u16 scbp_tarlun; - prev = tmp = host->first_busy; + tmp = host->first_busy; while (tmp != NULL) { scbp_tarlun = (tmp->lun << 8) | (tmp->target); if (scbp_tarlun == tarlun) { /* Unlink this SCB */ break; } - prev = tmp; tmp = tmp->next; } #if DEBUG_QUEUE From patchwork Fri Mar 12 09:47:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134133 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96265C28E82 for ; Fri, 12 Mar 2021 09:49:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A08F64F00 for ; Fri, 12 Mar 2021 09:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233241AbhCLJsp (ORCPT ); Fri, 12 Mar 2021 04:48:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233114AbhCLJsO (ORCPT ); Fri, 12 Mar 2021 04:48:14 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08BD9C0613D7 for ; Fri, 12 Mar 2021 01:48:14 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id g8so3403141wmd.4 for ; Fri, 12 Mar 2021 01:48:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l+1EJFBCtfo9l4gZLbyeXef//j2IlwdufiBKnHN8Ms4=; b=etOJppZ0N6Hc5WuXjMl/Rq7RPdhqLpqkPvoenm70t2iJLGNWCJF3hUhVcYbGHzOsaP ISlklt18zy37gZIRUD0Sh0/GoGxM0vTMfkb+dPoWq8wwXLl5BLbNZDXDUcbuohHwd6QY KazOWxWWTjHc9hdnB3RhLrNh66P5mUt1SCagZX1l/4cEEy6i7vSrNZIywzKYA4uNFIP1 OP1uo2gTEQUqR4kHhCVU9QFfvEX6kj/jBTe2TpGrrmx3Jd2Masl2xT5THLwm3I/lfCt6 +xeT/KHaQr3T/c5gX7iM+h2PWlQCUheqfYg87dPIAFHbbRkNxYkFp18sb1Zs4fDu/IOy lgpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l+1EJFBCtfo9l4gZLbyeXef//j2IlwdufiBKnHN8Ms4=; b=lAiwBEIfOVp6VrdLw96Te6VFObR0r4veCCqArcGEesnE3GUoxWDlz+/aEH9vthhYQK a6kxhpG6BUjbqkMjknTNC4d7CN37URFscIXcMHMc+sUnZGmeO1Qtp00YRQz8z4wiOyJL z9TMlwWhAeoublPfmogPFc4VGVx1y/c3YNHBIMbEPYJCItN8klv8jkqoF8e/t7wQPm+g rrGeUFSjZKInK2V0OY4Zi2gEuLssSVGEB2o9Jo5Rm8CTzKQHv2KI8LQYTQeg8fQBQL6u fiNnJCy/cE1C7yz03T2mg6n53CAXLbypdXVxSbUV0bkNPJdm7WsFlXTTZlc/s5J6cL1X v8Lg== X-Gm-Message-State: AOAM5324qUrTdvy0aERxT2+i3FI7OW13w6vaRwDFpwRHPOxTr924FHTw VRLZXHmfeOifcTns0Bw/xloB1w== X-Google-Smtp-Source: ABdhPJzMXSxiudKZzRxEjzG62a0M6Fz7KbcGhlbgRIF1Jxho9qurTmOPoLb1MMSXuRI9AFO1Pgg0uw== X-Received: by 2002:a1c:a543:: with SMTP id o64mr12229175wme.107.1615542492647; Fri, 12 Mar 2021 01:48:12 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.48.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:48:12 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , Doug Ledford , Christoph Hellwig , Alan Cox , linux-scsi@vger.kernel.org Subject: [PATCH 24/30] scsi: a100u2w: Remove unused variable 'bios_phys' Date: Fri, 12 Mar 2021 09:47:32 +0000 Message-Id: <20210312094738.2207817-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/a100u2w.c: In function ‘inia100_probe_one’: drivers/scsi/a100u2w.c:1092:8: warning: variable ‘bios_phys’ set but not used [-Wunused-but-set-variable] Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Doug Ledford Cc: Christoph Hellwig Cc: Alan Cox Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Christoph Hellwig --- drivers/scsi/a100u2w.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c index 66c514310f3c5..c99224a128f82 100644 --- a/drivers/scsi/a100u2w.c +++ b/drivers/scsi/a100u2w.c @@ -1089,7 +1089,6 @@ static int inia100_probe_one(struct pci_dev *pdev, int error = -ENODEV; u32 sz; unsigned long biosaddr; - char *bios_phys; if (pci_enable_device(pdev)) goto out; @@ -1141,7 +1140,6 @@ static int inia100_probe_one(struct pci_dev *pdev, biosaddr = host->BIOScfg; biosaddr = (biosaddr << 4); - bios_phys = phys_to_virt(biosaddr); if (init_orchid(host)) { /* Initialize orchid chip */ printk("inia100: initial orchid fail!!\n"); goto out_free_escb_array; From patchwork Fri Mar 12 09:47:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134145 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D71A7C2BA12 for ; Fri, 12 Mar 2021 09:49:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2D3D64F00 for ; Fri, 12 Mar 2021 09:49:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233343AbhCLJsx (ORCPT ); Fri, 12 Mar 2021 04:48:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233151AbhCLJsZ (ORCPT ); Fri, 12 Mar 2021 04:48:25 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0989FC0613D7 for ; Fri, 12 Mar 2021 01:48:15 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id f12so4419831wrx.8 for ; Fri, 12 Mar 2021 01:48:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/Ke6o4zu3Y1mMgZH32XDTQeE3CdSvHz52a/xHYynlH0=; b=OC9DBEziDd97rCc6RpwLUznVjblQ0eolzB8iPuqHbnfUSxb/6Qms6KQ5qz+p1oBmQw otUhqtwwQ5rZNL+UG6vunINrXd+PfdwmU8XR/wTzDd8pGrPKvn2hSEELGpm1s7gQRo5T nP/+J+8iy1BSsO4m7Db5pqkSF0oQxfOc7mflo0zQydY34SvsqVfSxRR+9K9epmzGdune fDRSrMRO6VBc7NtVfVRS1srFoYoWSMMDfc2fWGFYXe/7RgJPLkVkfd//LKS3YK4in08l znxRUkfbAxbkTjXmJyVOghF93yFsMWv/aY1Hi29jByYmAOT3kcsf66gW5axdQQKHZJDQ PiQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/Ke6o4zu3Y1mMgZH32XDTQeE3CdSvHz52a/xHYynlH0=; b=Uqg7LDy41Esh6WeovjhoTQrQsqIJ1k3Kh2dB6Hdkhas3fZqwegPAgePhg3+xrA9TVC 7R5M8Aar/U8UsTibj/1tjxXnHb9rKvCV+v7pzFZ1Hb2/ItOnRi0VMb5+aZCpWqaJc/us MgzxR1bZvtL/VPSnuSr2E4qQvTVnITRpFu1JwEXKkPt8Qu9iwikGEMrzZmQcO0ZDpKQ2 ekjp75elMYPibKxtyCTcWu/2vRf9BTk0cux9hpM2KXK5ovTq6gQsXp0Cb72mERni6a+p JoRZ/OfUqmXWj8GZLC3Y74NR9YM+oVeYsbwZximwWHqGMoR6bmLKlWvocIGdet6mMpyX 4mrA== X-Gm-Message-State: AOAM532yUkUV4aNfywEj1PYjJkivUg4axMrUUpAkAC9T56txNLOnNtB3 QKJWrgCRr38kgtdFJCvxn1Y51g== X-Google-Smtp-Source: ABdhPJwU10xDuswdcd0DJBB5bvQSHdp/5A3psb+ZircGEGbMDgJgvyr1CuBMNGbkVeqx176K6nfv5w== X-Received: by 2002:adf:a219:: with SMTP id p25mr13260335wra.400.1615542493724; Fri, 12 Mar 2021 01:48:13 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.48.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:48:13 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Oliver Neukum , Ali Akcaagac , Jamie Lenehan , "James E.J. Bottomley" , "Martin K. Petersen" , "C.L. Huang" , Erich Chen , Kurt Garloff , dc395x@twibble.org, linux-scsi@vger.kernel.org Subject: [PATCH 25/30] scsi: dc395x: Fix incorrect naming in function headers Date: Fri, 12 Mar 2021 09:47:33 +0000 Message-Id: <20210312094738.2207817-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/dc395x.c:980: warning: expecting prototype for dc395x_queue_command(). Prototype was for dc395x_queue_command_lck() instead drivers/scsi/dc395x.c:4263: warning: expecting prototype for adapter_init_host(). Prototype was for adapter_init_scsi_host() instead drivers/scsi/dc395x.c:4353: warning: Function parameter or member 'acb' not described in 'adapter_init' drivers/scsi/dc395x.c:4353: warning: Function parameter or member 'io_port_len' not described in 'adapter_init' drivers/scsi/dc395x.c:4353: warning: expecting prototype for init_adapter(). Prototype was for adapter_init() instead Cc: Oliver Neukum Cc: Ali Akcaagac Cc: Jamie Lenehan Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: "C.L. Huang" Cc: Erich Chen Cc: Kurt Garloff Cc: dc395x@twibble.org Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/dc395x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c index 3ea345c124673..e28f8931e23f8 100644 --- a/drivers/scsi/dc395x.c +++ b/drivers/scsi/dc395x.c @@ -958,7 +958,7 @@ static void build_srb(struct scsi_cmnd *cmd, struct DeviceCtlBlk *dcb, /** - * dc395x_queue_command - queue scsi command passed from the mid + * dc395x_queue_command_lck - queue scsi command passed from the mid * layer, invoke 'done' on completion * * @cmd: pointer to scsi command object @@ -4248,7 +4248,7 @@ static void adapter_init_params(struct AdapterCtlBlk *acb) /** - * adapter_init_host - Initialize the scsi host instance based on + * adapter_init_scsi_host - Initialize the scsi host instance based on * values that we have already stored in the adapter instance. There's * some mention that a lot of these are deprecated, so we won't use * them (we'll use the ones in the adapter instance) but we'll fill @@ -4336,7 +4336,7 @@ static void adapter_init_chip(struct AdapterCtlBlk *acb) /** - * init_adapter - Grab the resource for the card, setup the adapter + * adapter_init - Grab the resource for the card, setup the adapter * information, set the card into a known state, create the various * tables etc etc. This basically gets all adapter information all up * to date, initialised and gets the chip in sync with it. From patchwork Fri Mar 12 09:47:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134143 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB8D3C41621 for ; Fri, 12 Mar 2021 09:49:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCDB864FE0 for ; Fri, 12 Mar 2021 09:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233276AbhCLJsr (ORCPT ); Fri, 12 Mar 2021 04:48:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233116AbhCLJsQ (ORCPT ); Fri, 12 Mar 2021 04:48:16 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDC82C0613D8 for ; Fri, 12 Mar 2021 01:48:15 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id l11so4427965wrp.7 for ; Fri, 12 Mar 2021 01:48:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xPFThlMI/y/qW18pAnI543DROCiFDU71wLqLjBXMJAs=; b=vWEqgTD6oQYZpNz4Hu1OvSSZxt00P0xGD9TIfy49FIbvAkqx8vRrKch/at62za/YT6 4V4KRKTExIvkMZmZYIS3QtI4C4dhGcI1THNQI0SOMB5DowheGfsLWehHmPdmqOOLFjVa 9O07v3hRnNM8HijKAURKU7M52PiNWZgWEOWh3f6HJT2E3ypVayJeGPRqTQm6qgCMtkyq iYni+LSLtMPnTuYa+XE1+PjRfO4DO7MJgFSksEyP6030iVWvsIijj2CW/wzRk/rPluGO zwBxJa+wj8pDmEJsrdHPcP/PU5XtGX22Kbdi8FM5kvEKXIAiS/LncOzyK9cDyYSf/Obg Lw1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xPFThlMI/y/qW18pAnI543DROCiFDU71wLqLjBXMJAs=; b=ACA/T2Wn3qBTt+5IjRiuYTR3PisaTr2M3sZ/LtH50hcFWlpsuq6Bne/7XwPVuQQsh7 7eRorx/TwIXGuM8KKeb+NdnlK5WuaBEyo5jMR7OtSGcWrAf/EcgpIROB2IAOvKqfMJzD lrw1/2zZ5dCxmYg3IQcEV8dvXh8IIXLL+iXA6BsYXg9sJKQZ2pSiDUWumr+qclllB5tl S+Kfst/kMEehU40QZtl6xS+W12yJA0EP3w0GuT9M66VWSAEIhZslz0uVoz5qo+5bDCMN i7hjjITTH7GNX3Z9aFrIDgqQIJ6ChLZk/i58/Lm80ENptRC0YSV8nEfZVTIKBTP8mpFM R1Yw== X-Gm-Message-State: AOAM532Pa2QDyXFC4NHO7DFl30dteS7hkozJerLbIRphH9V+iuWYuulp zyOp2qi5c86QuasoPf1L0HWAkpofDnjq5g== X-Google-Smtp-Source: ABdhPJzshM/m3B1yoxb1O5Wp3hm0MJi/SrIcPq8v19/2Od7pFzDJa/Q/tmVdDZQf9HK6DIIkGVSE2w== X-Received: by 2002:adf:83c2:: with SMTP id 60mr12961301wre.386.1615542494728; Fri, 12 Mar 2021 01:48:14 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:48:14 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , Marcelo Tosatti , linux-scsi@vger.kernel.org Subject: [PATCH 26/30] scsi: atp870u: Fix naming and demote incorrect and non-conformant kernel-doc header Date: Fri, 12 Mar 2021 09:47:34 +0000 Message-Id: <20210312094738.2207817-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/atp870u.c:623: warning: expecting prototype for atp870u_queuecommand(). Prototype was for atp870u_queuecommand_lck() instead drivers/scsi/atp870u.c:724: warning: Function parameter or member 'dev' not described in 'send_s870' drivers/scsi/atp870u.c:724: warning: Function parameter or member 'c' not described in 'send_s870' drivers/scsi/atp870u.c:724: warning: Excess function parameter 'host' description in 'send_s870' Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Marcelo Tosatti Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/atp870u.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/atp870u.c b/drivers/scsi/atp870u.c index da6ca2b153d85..9d179cd15bb84 100644 --- a/drivers/scsi/atp870u.c +++ b/drivers/scsi/atp870u.c @@ -612,7 +612,7 @@ static irqreturn_t atp870u_intr_handle(int irq, void *dev_id) return IRQ_HANDLED; } /** - * atp870u_queuecommand - Queue SCSI command + * atp870u_queuecommand_lck - Queue SCSI command * @req_p: request block * @done: completion function * @@ -711,16 +711,15 @@ static int atp870u_queuecommand_lck(struct scsi_cmnd *req_p, static DEF_SCSI_QCMD(atp870u_queuecommand) -/** +/* * send_s870 - send a command to the controller - * @host: host * * On entry there is work queued to be done. We move some of that work to the * controller itself. * * Caller holds the host lock. */ -static void send_s870(struct atp_unit *dev,unsigned char c) +static void send_s870(struct atp_unit *dev, unsigned char c) { struct scsi_cmnd *workreq = NULL; unsigned int i;//,k; From patchwork Fri Mar 12 09:47:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134155 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E32F4C28E87 for ; Fri, 12 Mar 2021 09:49:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB50664FDA for ; Fri, 12 Mar 2021 09:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233293AbhCLJsr (ORCPT ); Fri, 12 Mar 2021 04:48:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233122AbhCLJsR (ORCPT ); Fri, 12 Mar 2021 04:48:17 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C72F1C0613D9 for ; Fri, 12 Mar 2021 01:48:16 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id 61so1405118wrm.12 for ; Fri, 12 Mar 2021 01:48:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jXzZsgME51o5a4S3G/qD/qZyWpfOm8qpjFIuUNjewrU=; b=RzDHHxJIrMTYsGLtnjmh448nDAU6vYH3+2i3jhfv9Yf7Bum4BYw4rNx29JA4HMXlZr GxvreTK/UTMpv2fgwZUqNITRSEtDrRDoTYeIy4i0v6XyvSUP/LXNjws7sKFl7xvHR28t L7KansPbqqzqOVIlWPwjjQAXwqyYutcuqDI1IEmGJzo6s0Rb2ryGPRrWAh6ETFs1MQKN bUsQzUYjqKkmbDQSSm3PPwkUOKIQOXogUANenFZMZAdeovFMJAsIzY9qDYnZClEuLIOB DP55HmbJ6u7ZDqmMz3fuwrgH4pvZ6bbdOOXAhc0k9pFfiP6M99cjitSgd/MMUNaG3/lZ D5iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jXzZsgME51o5a4S3G/qD/qZyWpfOm8qpjFIuUNjewrU=; b=HjYp5UbnLfZKKkl+Gn5yssMdqMrPMZGtF7JJHPduG6hZ6sJkHIike/tNlGmvGtyJ+O 2f07QvSpZ9QBpoupd7yQGS6JSNUDFNh1pxG6RdX6iMNDoZaWob5Q+vRBYFsF6Gpp0PKf XwxAF7ajZufexNLiYM58IefEqWvYJORZfi0cpxJldezXMW8UDbqgDEXm23CchRTz6CDf 2Z3tNF9BbR/67RvkJ4I0/z3jaZxfaXububLtCu3jyghMLyWHjGJANYe9RHkwOGsv/VLf SmbJykuDvR+iOfsGRNXpQhkbdVxFf7Y/vD+RIhS5Y9FC+4MjI5nMdThqsBLCq5Rkv0tk IB3Q== X-Gm-Message-State: AOAM533g4ZlzjJiRNH74XiYaW906oNVZ83uTqQz3E9FU+nXpTjyreFqG 5lig20w74KTXk9DfMQjLUQzemg== X-Google-Smtp-Source: ABdhPJxYl7bqyU5JTM3AB7hrDocTa5Yda5nTYn2IUc7mVithIahnHmSDLT/pNp3q/FF6TYv0lTQGZw== X-Received: by 2002:adf:a418:: with SMTP id d24mr12943172wra.187.1615542495551; Fri, 12 Mar 2021 01:48:15 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:48:15 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , Linux GmbH , "Leonard N. Zubkoff" , linux-scsi@vger.kernel.org Subject: [PATCH 27/30] scsi: myrs: Remove a couple of unused 'status' variables Date: Fri, 12 Mar 2021 09:47:35 +0000 Message-Id: <20210312094738.2207817-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/myrs.c: In function ‘consistency_check_show’: drivers/scsi/myrs.c:1193:16: warning: variable ‘status’ set but not used [-Wunused-but-set-variable] drivers/scsi/myrs.c: In function ‘myrs_get_resync’: drivers/scsi/myrs.c:1984:5: warning: variable ‘status’ set but not used [-Wunused-but-set-variable] Cc: Hannes Reinecke Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Linux GmbH Cc: "Leonard N. Zubkoff" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Christoph Hellwig --- drivers/scsi/myrs.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/myrs.c b/drivers/scsi/myrs.c index 4adf9ded296aa..48e399f057d5c 100644 --- a/drivers/scsi/myrs.c +++ b/drivers/scsi/myrs.c @@ -1190,7 +1190,6 @@ static ssize_t consistency_check_show(struct device *dev, struct myrs_hba *cs = shost_priv(sdev->host); struct myrs_ldev_info *ldev_info; unsigned short ldev_num; - unsigned char status; if (sdev->channel < cs->ctlr_info->physchan_present) return snprintf(buf, 32, "physical device - not checking\n"); @@ -1199,7 +1198,7 @@ static ssize_t consistency_check_show(struct device *dev, if (!ldev_info) return -ENXIO; ldev_num = ldev_info->ldev_num; - status = myrs_get_ldev_info(cs, ldev_num, ldev_info); + myrs_get_ldev_info(cs, ldev_num, ldev_info); if (ldev_info->cc_active) return snprintf(buf, 32, "checking block %zu of %zu\n", (size_t)ldev_info->cc_lba, @@ -1981,14 +1980,13 @@ myrs_get_resync(struct device *dev) struct myrs_hba *cs = shost_priv(sdev->host); struct myrs_ldev_info *ldev_info = sdev->hostdata; u64 percent_complete = 0; - u8 status; if (sdev->channel < cs->ctlr_info->physchan_present || !ldev_info) return; if (ldev_info->rbld_active) { unsigned short ldev_num = ldev_info->ldev_num; - status = myrs_get_ldev_info(cs, ldev_num, ldev_info); + myrs_get_ldev_info(cs, ldev_num, ldev_info); percent_complete = ldev_info->rbld_lba * 100; do_div(percent_complete, ldev_info->cfg_devsize); } From patchwork Fri Mar 12 09:47:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134141 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DEFBC41518 for ; Fri, 12 Mar 2021 09:49:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F068B64F00 for ; Fri, 12 Mar 2021 09:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233302AbhCLJss (ORCPT ); Fri, 12 Mar 2021 04:48:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233131AbhCLJsS (ORCPT ); Fri, 12 Mar 2021 04:48:18 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFC86C061764 for ; Fri, 12 Mar 2021 01:48:17 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id o26so3398747wmc.5 for ; Fri, 12 Mar 2021 01:48:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6g1k4NOJoIyIgRaKDu88zZvT9OX+R02WPv1Cq13vbSs=; b=GCHdIzAfYgsCay1B9SS+ZnYX0FYvTV60z5kscOccdfQV3WQUrWFvmOu2dh4+gP89WM bvP80g3F7eroGfdguGDDSx4CjsyHon4vWTUBzei/1s99cuO2eHYz98pRvVCveRwwSwZT UYokGX4YRNP/W1xJhVn7xnIXvDQXNT3mTKcbs5L8MLLRiQ/5prYIip+cmM/E3f8FCKhl UytLiD2rl+tZT9E8/edeF5IccIxaFomixfihGZWAxohzM5NqsjEn4eSj1ufE14Po8N1j ltteuMX4MDBUHBaTcngGraUBgKyxbrxHyLdhkIiDG3krqtoTR6rsQebt+C1bLmiKbJBV 3LSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6g1k4NOJoIyIgRaKDu88zZvT9OX+R02WPv1Cq13vbSs=; b=diFoeA4OrM97SCyV6uP9iRd6NtDdOwISe3755vXzGZDvynUQJVUbyy6tYpBcNUOwWZ C15UYt+w9TBK3bg0aHx1wcJeVzQ1bPhy9H1N8cpBVg/UU8uM8XVmgoFeZW6flmvfTtr8 HQuEEdwFvPey/JaCCOE8gif27fic0SS5gykcr82bhTR2IQ+wWubY9paU3ciGaCYyaYCX EaiuJC/mjWNa376kxF5rBD6fN5G/bMlk8q21RtaxZ2pyuI8uh77jx7KaiP4aY+1bwHsk J8KfiAOnJTJqW+sPQSYaLX3A1T2PNznyAOGwIjgsgcCxTzOPmh5GR4csW5DRlpz/z+MU hgGw== X-Gm-Message-State: AOAM532yO/ras6yEW6ayIqJK8kUY/SfBhzeag5oZzeqX3nBZppmSXkwy /tfg0K6Vb5vHl0HOQI9com8EYg== X-Google-Smtp-Source: ABdhPJyTjzB26opz3HQn+LVBBuiOy0UuqXf2qbpSM1j3b5m1i7Lc/kJkb4ZwVFW3xsVria9vr0PCRg== X-Received: by 2002:a1c:7916:: with SMTP id l22mr12001434wme.86.1615542496455; Fri, 12 Mar 2021 01:48:16 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.48.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:48:16 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Adam Radford , "James E.J. Bottomley" , "Martin K. Petersen" , Joel Jacobson , de Melo , Andre Hedrick , linux-scsi@vger.kernel.org Subject: [PATCH 28/30] scsi: 3w-xxxx: Remove 2 unused variables 'response_que_value' and 'tw_dev' Date: Fri, 12 Mar 2021 09:47:36 +0000 Message-Id: <20210312094738.2207817-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/3w-xxxx.c: In function ‘tw_empty_response_que’: drivers/scsi/3w-xxxx.c:463:24: warning: variable ‘response_que_value’ set but not used [-Wunused-but-set-variable] drivers/scsi/3w-xxxx.c: In function ‘tw_scsi_biosparam’: drivers/scsi/3w-xxxx.c:1345:23: warning: variable ‘tw_dev’ set but not used [-Wunused-but-set-variable] Cc: Adam Radford Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Joel Jacobson Cc: de Melo Cc: Andre Hedrick Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/3w-xxxx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/3w-xxxx.c b/drivers/scsi/3w-xxxx.c index d90b9fca4aea2..a7292883b72bc 100644 --- a/drivers/scsi/3w-xxxx.c +++ b/drivers/scsi/3w-xxxx.c @@ -460,12 +460,12 @@ static int tw_check_errors(TW_Device_Extension *tw_dev) /* This function will empty the response que */ static void tw_empty_response_que(TW_Device_Extension *tw_dev) { - u32 status_reg_value, response_que_value; + u32 status_reg_value; status_reg_value = inl(TW_STATUS_REG_ADDR(tw_dev)); while ((status_reg_value & TW_STATUS_RESPONSE_QUEUE_EMPTY) == 0) { - response_que_value = inl(TW_RESPONSE_QUEUE_REG_ADDR(tw_dev)); + inl(TW_RESPONSE_QUEUE_REG_ADDR(tw_dev)); status_reg_value = inl(TW_STATUS_REG_ADDR(tw_dev)); } } /* End tw_empty_response_que() */ @@ -1342,10 +1342,8 @@ static int tw_scsi_biosparam(struct scsi_device *sdev, struct block_device *bdev sector_t capacity, int geom[]) { int heads, sectors, cylinders; - TW_Device_Extension *tw_dev; dprintk(KERN_NOTICE "3w-xxxx: tw_scsi_biosparam()\n"); - tw_dev = (TW_Device_Extension *)sdev->host->hostdata; heads = 64; sectors = 32; From patchwork Fri Mar 12 09:47:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134149 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49AA0C433DB for ; Fri, 12 Mar 2021 09:49:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 215516501B for ; Fri, 12 Mar 2021 09:49:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233142AbhCLJsu (ORCPT ); Fri, 12 Mar 2021 04:48:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233134AbhCLJsT (ORCPT ); Fri, 12 Mar 2021 04:48:19 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5601C061761 for ; Fri, 12 Mar 2021 01:48:18 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id d139-20020a1c1d910000b029010b895cb6f2so14779234wmd.5 for ; Fri, 12 Mar 2021 01:48:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=953zZzIFTk8WBz/FuB+6aJVYCMmR1USbvaybVRbnoaU=; b=TJ235tKzTr+0UDs6L+L/8surRmTFXWS0yvtC2LBubxd2ZLncAEP5MMGOymfDsCzi/w lV4PTKQf/9gFXbxeGHmY4QWgP6OjyxuWGo9r2LPI6JIT8RavfmDo5gVb8YIWx4UuwDRz DOep/3VfSFr9pmxODIdLdSHO17wfQ7T5LW/X1omMmCkCc4vhcXJx2Hy9YGMqIELBs+GS 4CS0uxT2ITVmiRyTMgUIEHxWnkaL76PzlmMZoxRa0C4HAkqZDHrCx/BESIBMdmlKesTM vNUXNyK6M4voh7pm3voi3uI4JpuUBvvxg5f80hR0lwJwl++t1AcjU28HPB6J6d7Ts4+z q8DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=953zZzIFTk8WBz/FuB+6aJVYCMmR1USbvaybVRbnoaU=; b=CMH6spU3VboA7WjY76Ee6HuRQjjnoTpnB3Qg2FQvoHh/h9VfIgELfTabXD2eGl3+t8 m+cdNZ60t45kfKXck9p6yhNAh21hUKVK3/yAY3lHj3JJ3e28g84j1VwyG/Goi13xvGC9 lsa679nzo19KBwVMBePmP+rBsNIuwo3aRz/O1HIfJ2zl7sswdnGOvt18/5QwOm896uxK hyBgvKMqTIVkFqU84uRoOl7EUHk1gjahh+/tMeUC7fTQXcdZ/uqN1hg4ldTJuC2kh9QP fJZPJHhcwxTlPlybCtLWanPpB4UV4qJ9IPA2urPAnR6vpknz8aow8tbLwsqWfanzBy03 9zXg== X-Gm-Message-State: AOAM531NhBkLf5/o2G4cjknFAxYfYPqryxnTlvN8eA0iVH8TybT55Tq8 ggQKUY5Pi04Dn/Q0m8WhC1Hh7A== X-Google-Smtp-Source: ABdhPJxENwFbPR1Qi3QEoJE/0xy1tsf3Pt5/PaL2hx9dKdCMGSjdmCWEiKK8XLUEG9961p3Qvkfa4Q== X-Received: by 2002:a1c:7905:: with SMTP id l5mr12329070wme.181.1615542497362; Fri, 12 Mar 2021 01:48:17 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.48.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:48:16 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Adam Radford , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 29/30] scsi: 3w-9xxx: Remove a few set but unused variables Date: Fri, 12 Mar 2021 09:47:37 +0000 Message-Id: <20210312094738.2207817-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/3w-9xxx.c: In function ‘twa_empty_response_queue’: drivers/scsi/3w-9xxx.c:942:24: warning: variable ‘response_que_value’ set but not used [-Wunused-but-set-variable] drivers/scsi/3w-9xxx.c: In function ‘twa_scsi_biosparam’: drivers/scsi/3w-9xxx.c:1701:23: warning: variable ‘tw_dev’ set but not used [-Wunused-but-set-variable] drivers/scsi/3w-9xxx.c: In function ‘twa_scsiop_execute_scsi’: drivers/scsi/3w-9xxx.c:1812:22: warning: variable ‘sglist’ set but not used [-Wunused-but-set-variable] Cc: Adam Radford Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/3w-9xxx.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/3w-9xxx.c b/drivers/scsi/3w-9xxx.c index b96e82de4237d..47028f5e57abd 100644 --- a/drivers/scsi/3w-9xxx.c +++ b/drivers/scsi/3w-9xxx.c @@ -939,13 +939,13 @@ static int twa_decode_bits(TW_Device_Extension *tw_dev, u32 status_reg_value) /* This function will empty the response queue */ static int twa_empty_response_queue(TW_Device_Extension *tw_dev) { - u32 status_reg_value, response_que_value; + u32 status_reg_value; int count = 0, retval = 1; status_reg_value = readl(TW_STATUS_REG_ADDR(tw_dev)); while (((status_reg_value & TW_STATUS_RESPONSE_QUEUE_EMPTY) == 0) && (count < TW_MAX_RESPONSE_DRAIN)) { - response_que_value = readl(TW_RESPONSE_QUEUE_REG_ADDR(tw_dev)); + readl(TW_RESPONSE_QUEUE_REG_ADDR(tw_dev)); status_reg_value = readl(TW_STATUS_REG_ADDR(tw_dev)); count++; } @@ -1698,9 +1698,6 @@ static int twa_reset_sequence(TW_Device_Extension *tw_dev, int soft_reset) static int twa_scsi_biosparam(struct scsi_device *sdev, struct block_device *bdev, sector_t capacity, int geom[]) { int heads, sectors, cylinders; - TW_Device_Extension *tw_dev; - - tw_dev = (TW_Device_Extension *)sdev->host->hostdata; if (capacity >= 0x200000) { heads = 255; @@ -1809,14 +1806,11 @@ static int twa_scsiop_execute_scsi(TW_Device_Extension *tw_dev, int request_id, u32 num_sectors = 0x0; int i, sg_count; struct scsi_cmnd *srb = NULL; - struct scatterlist *sglist = NULL, *sg; + struct scatterlist *sg; int retval = 1; - if (tw_dev->srb[request_id]) { + if (tw_dev->srb[request_id]) srb = tw_dev->srb[request_id]; - if (scsi_sglist(srb)) - sglist = scsi_sglist(srb); - } /* Initialize command packet */ full_command_packet = tw_dev->command_packet_virt[request_id]; From patchwork Fri Mar 12 09:47:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134137 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 317A1C28E88 for ; Fri, 12 Mar 2021 09:49:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B36B64FDA for ; Fri, 12 Mar 2021 09:49:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233314AbhCLJsv (ORCPT ); Fri, 12 Mar 2021 04:48:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233137AbhCLJsU (ORCPT ); Fri, 12 Mar 2021 04:48:20 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C433C061764 for ; Fri, 12 Mar 2021 01:48:19 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id l19so3399945wmh.1 for ; Fri, 12 Mar 2021 01:48:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lgdjb93mQlErKIT9nxRZ2QkPnfSG57zjDQqjLAihewI=; b=htdxj4D+i1pw2qvU4uRp6Ix/OepCm6Qymczhgkv2cJLrN+tRfxGdlhW01XgsiTq2t6 aakoqfM7c9lm133dBr9xTBGvZ863g7/Ex9/PM6dvT1AjxfG/hdyCzk8Uhmv8HKxDEJo/ oCb0cvqZ/i+QlUcZPtdnUlKQapl0WIxICNpSfqZ0XR0t6RevmstZG0vuZDLVogwq2u9f RQbmuY08n6DyEXUtmVrZU4u5LKhSywmQwb+Z/u25ZKLl4R0ujczWxyzigzsjOZlkH3T4 eWy+A9nTzRbeLfgNh/wGg1n0b29G+F1RimBLKwwFnDZKyewQJvYKPWrHSHVSROZ5auT7 tmBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lgdjb93mQlErKIT9nxRZ2QkPnfSG57zjDQqjLAihewI=; b=m1Z+kWpsJlFNMbWrLtAcMOvW72p39SRhqsuta8lXH+WkswzIe+ELRe2nh8a8K3Dd25 r7mhchU0+lP/vdpb+k2BExzRJtht/JumnwskT9H/TI+7BCitFeSJwdCKzCoyERdZn5qN wd/+g5oOxwzjYu9Jldv94/OYnutroS5/FzIWsqmbwX9qmWb4etQS3jOTX1sc6be3pwb/ eEevZbGvKesRD7KgPjKc3rWwYJkkG0yuOQRCuKda7O+JvOTGjTFwdj9X0yFHTGPWPilw sqeF7s8WbPpv9jRqfGHgPeQVqGUc9wpPEi8wc41hLAQ+nhpO14Vi2x9qzpRCy2hYhZkg zVQQ== X-Gm-Message-State: AOAM530nhfaSUbHnhe5sgQm567zENJZe2DGeUPAgIUj8uRPZXmy6HZVv IlJyjqgAJhRmrLicQQxaMAC5qg== X-Google-Smtp-Source: ABdhPJxr1v3sYYoAKHmR7zf0N1dCaTQYzxbyGs1FWnrsPnQsJtaiRFFSxSOW6iKGvfU1tC/PXtmQiw== X-Received: by 2002:a1c:5416:: with SMTP id i22mr12229086wmb.146.1615542498280; Fri, 12 Mar 2021 01:48:18 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id f7sm1539536wmq.11.2021.03.12.01.48.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 01:48:17 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Adam Radford , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 30/30] scsi: 3w-sas: Remove unused variables 'sglist' and 'tw_dev' Date: Fri, 12 Mar 2021 09:47:38 +0000 Message-Id: <20210312094738.2207817-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312094738.2207817-1-lee.jones@linaro.org> References: <20210312094738.2207817-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/3w-sas.c: In function ‘twl_scsiop_execute_scsi’: drivers/scsi/3w-sas.c:298:22: warning: variable ‘sglist’ set but not used [-Wunused-but-set-variable] drivers/scsi/3w-sas.c: In function ‘twl_scsi_biosparam’: drivers/scsi/3w-sas.c:1411:23: warning: variable ‘tw_dev’ set but not used [-Wunused-but-set-variable] Cc: Adam Radford Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/3w-sas.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/3w-sas.c b/drivers/scsi/3w-sas.c index 3db0e42e9aa75..383f6f204c24b 100644 --- a/drivers/scsi/3w-sas.c +++ b/drivers/scsi/3w-sas.c @@ -295,14 +295,11 @@ static int twl_scsiop_execute_scsi(TW_Device_Extension *tw_dev, int request_id, TW_Command_Apache *command_packet; int i, sg_count; struct scsi_cmnd *srb = NULL; - struct scatterlist *sglist = NULL, *sg; + struct scatterlist *sg; int retval = 1; - if (tw_dev->srb[request_id]) { + if (tw_dev->srb[request_id]) srb = tw_dev->srb[request_id]; - if (scsi_sglist(srb)) - sglist = scsi_sglist(srb); - } /* Initialize command packet */ full_command_packet = tw_dev->command_packet_virt[request_id]; @@ -1408,9 +1405,6 @@ static int twl_reset_device_extension(TW_Device_Extension *tw_dev, int ioctl_res static int twl_scsi_biosparam(struct scsi_device *sdev, struct block_device *bdev, sector_t capacity, int geom[]) { int heads, sectors; - TW_Device_Extension *tw_dev; - - tw_dev = (TW_Device_Extension *)sdev->host->hostdata; if (capacity >= 0x200000) { heads = 255;