From patchwork Wed Mar 17 08:56:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12145117 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 389C0C433DB for ; Wed, 17 Mar 2021 08:57:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA9CE64F2B for ; Wed, 17 Mar 2021 08:57:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229490AbhCQI5Q (ORCPT ); Wed, 17 Mar 2021 04:57:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229613AbhCQI5I (ORCPT ); Wed, 17 Mar 2021 04:57:08 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53199C06175F for ; Wed, 17 Mar 2021 01:57:08 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id j7so962967wrd.1 for ; Wed, 17 Mar 2021 01:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bCbfbKrHtTJDrvzcr+wliVfv0YCW7v3SbQO0PUWBLF8=; b=wss+x1ep2vqjhxs3d2Ga+RWpFoLc/bjyYAu+FA6AznshqZuy/nPTiYdkZu4QgIKOC5 vBkAm8rposwYziRqN/fv62OqZ2nl9w0Pg0GasebAmJPIJhvHO9UXBsdoA/rEoDqVDmMi d/VsS1EibPkSYO6jKJoL0S4x5YHXx1hwbQJl5MjfiW8tKB85C9+DsOEXKsGoI8vyecNU hdv9qJIbWWH4l9HIno1dJa82tLeBqTE/L5LEM1zVp+jg+HXj03rDh21cuyap+jTHkyPX cqCqnjTHVF5AaaXZbA7sbwYg5LdltTFODr/xn5LtRDuJEGb4irDpbb0XQzYNw5Io9h9H XcLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bCbfbKrHtTJDrvzcr+wliVfv0YCW7v3SbQO0PUWBLF8=; b=rojG9Gk5sDBvqV5yVPbBPWO8YaPJylb/DEfriADgDjl4z2SuX8W/nCBPQn+W8a2rXQ cjNexmRojwGwp88eohrtfe2ad/l8RpPsOAskgmUK63/xYxBNUZb+9/sfkZxsblUf3apK HaR///m7SRgffBVdBRB4HKYGu0it9Rw674mvQePL0JnSTb3Flp2d7+GpLaSQtld9iaOc YHeC3JPevSUTKM+iBczW/yE/QjWtSovCeAThrSkpAcjQeiH6FDHeVihm+mJZ6/cDPXsb oZ+aFeIblsR4X4oled2lKdhdQ6o/e+xAZfdoz08cOcfQJgX88zKE0GdbZuFS0jS1dwXz zjIA== X-Gm-Message-State: AOAM532yTH6z/wgPxmKPQ+JcqoouBAIlYVZVi3jq1nikaQR1bxngXiUU goxl1DfhZQS7R2KPhuCGJy0MQawSGRWmxg== X-Google-Smtp-Source: ABdhPJyi8UI083o4YsH06N81QSUcZ93H3JvbS5lUgVLXwbWn1KIagf2Lg5Jzry/TpeMdFFQumC7ERA== X-Received: by 2002:adf:f908:: with SMTP id b8mr3170845wrr.184.1615971427027; Wed, 17 Mar 2021 01:57:07 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j123sm1807243wmb.1.2021.03.17.01.57.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 01:57:06 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , David Chaw , Luben Tuikov , linux-scsi@vger.kernel.org Subject: [PATCH 01/18] scsi: aic94xx: aic94xx_dump: Remove code that has been unused for at least 13 years Date: Wed, 17 Mar 2021 08:56:44 +0000 Message-Id: <20210317085701.2891231-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317085701.2891231-1-lee.jones@linaro.org> References: <20210317085701.2891231-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/aic94xx/aic94xx_dump.c:731: warning: expecting prototype for asd_dump_ddb_site(). Prototype was for asd_dump_target_ddb() instead drivers/scsi/aic94xx/aic94xx_dump.c:875: warning: expecting prototype for ads_dump_seq_state(). Prototype was for asd_dump_seq_state() instead Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: David Chaw Cc: Luben Tuikov Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/aic94xx/aic94xx_dump.c | 184 ---------------------------- 1 file changed, 184 deletions(-) diff --git a/drivers/scsi/aic94xx/aic94xx_dump.c b/drivers/scsi/aic94xx/aic94xx_dump.c index 7c4c53a54b782..47a663a39dcce 100644 --- a/drivers/scsi/aic94xx/aic94xx_dump.c +++ b/drivers/scsi/aic94xx/aic94xx_dump.c @@ -720,152 +720,6 @@ static void asd_dump_lseq_state(struct asd_ha_struct *asd_ha, int lseq) PRINT_LMIP_dword(asd_ha, lseq, DEV_PRES_TIMER_TERM_TS); } -#if 0 - -/** - * asd_dump_ddb_site -- dump a CSEQ DDB site - * @asd_ha: pointer to host adapter structure - * @site_no: site number of interest - */ -void asd_dump_target_ddb(struct asd_ha_struct *asd_ha, u16 site_no) -{ - if (site_no >= asd_ha->hw_prof.max_ddbs) - return; - -#define DDB_FIELDB(__name) \ - asd_ddbsite_read_byte(asd_ha, site_no, \ - offsetof(struct asd_ddb_ssp_smp_target_port, __name)) -#define DDB2_FIELDB(__name) \ - asd_ddbsite_read_byte(asd_ha, site_no, \ - offsetof(struct asd_ddb_stp_sata_target_port, __name)) -#define DDB_FIELDW(__name) \ - asd_ddbsite_read_word(asd_ha, site_no, \ - offsetof(struct asd_ddb_ssp_smp_target_port, __name)) - -#define DDB_FIELDD(__name) \ - asd_ddbsite_read_dword(asd_ha, site_no, \ - offsetof(struct asd_ddb_ssp_smp_target_port, __name)) - - asd_printk("DDB: 0x%02x\n", site_no); - asd_printk("conn_type: 0x%02x\n", DDB_FIELDB(conn_type)); - asd_printk("conn_rate: 0x%02x\n", DDB_FIELDB(conn_rate)); - asd_printk("init_conn_tag: 0x%04x\n", be16_to_cpu(DDB_FIELDW(init_conn_tag))); - asd_printk("send_queue_head: 0x%04x\n", be16_to_cpu(DDB_FIELDW(send_queue_head))); - asd_printk("sq_suspended: 0x%02x\n", DDB_FIELDB(sq_suspended)); - asd_printk("DDB Type: 0x%02x\n", DDB_FIELDB(ddb_type)); - asd_printk("AWT Default: 0x%04x\n", DDB_FIELDW(awt_def)); - asd_printk("compat_features: 0x%02x\n", DDB_FIELDB(compat_features)); - asd_printk("Pathway Blocked Count: 0x%02x\n", - DDB_FIELDB(pathway_blocked_count)); - asd_printk("arb_wait_time: 0x%04x\n", DDB_FIELDW(arb_wait_time)); - asd_printk("more_compat_features: 0x%08x\n", - DDB_FIELDD(more_compat_features)); - asd_printk("Conn Mask: 0x%02x\n", DDB_FIELDB(conn_mask)); - asd_printk("flags: 0x%02x\n", DDB_FIELDB(flags)); - asd_printk("flags2: 0x%02x\n", DDB2_FIELDB(flags2)); - asd_printk("ExecQ Tail: 0x%04x\n",DDB_FIELDW(exec_queue_tail)); - asd_printk("SendQ Tail: 0x%04x\n",DDB_FIELDW(send_queue_tail)); - asd_printk("Active Task Count: 0x%04x\n", - DDB_FIELDW(active_task_count)); - asd_printk("ITNL Reason: 0x%02x\n", DDB_FIELDB(itnl_reason)); - asd_printk("ITNL Timeout Const: 0x%04x\n", DDB_FIELDW(itnl_timeout)); - asd_printk("ITNL timestamp: 0x%08x\n", DDB_FIELDD(itnl_timestamp)); -} - -void asd_dump_ddb_0(struct asd_ha_struct *asd_ha) -{ -#define DDB0_FIELDB(__name) \ - asd_ddbsite_read_byte(asd_ha, 0, \ - offsetof(struct asd_ddb_seq_shared, __name)) -#define DDB0_FIELDW(__name) \ - asd_ddbsite_read_word(asd_ha, 0, \ - offsetof(struct asd_ddb_seq_shared, __name)) - -#define DDB0_FIELDD(__name) \ - asd_ddbsite_read_dword(asd_ha,0 , \ - offsetof(struct asd_ddb_seq_shared, __name)) - -#define DDB0_FIELDA(__name, _o) \ - asd_ddbsite_read_byte(asd_ha, 0, \ - offsetof(struct asd_ddb_seq_shared, __name)+_o) - - - asd_printk("DDB: 0\n"); - asd_printk("q_free_ddb_head:%04x\n", DDB0_FIELDW(q_free_ddb_head)); - asd_printk("q_free_ddb_tail:%04x\n", DDB0_FIELDW(q_free_ddb_tail)); - asd_printk("q_free_ddb_cnt:%04x\n", DDB0_FIELDW(q_free_ddb_cnt)); - asd_printk("q_used_ddb_head:%04x\n", DDB0_FIELDW(q_used_ddb_head)); - asd_printk("q_used_ddb_tail:%04x\n", DDB0_FIELDW(q_used_ddb_tail)); - asd_printk("shared_mem_lock:%04x\n", DDB0_FIELDW(shared_mem_lock)); - asd_printk("smp_conn_tag:%04x\n", DDB0_FIELDW(smp_conn_tag)); - asd_printk("est_nexus_buf_cnt:%04x\n", DDB0_FIELDW(est_nexus_buf_cnt)); - asd_printk("est_nexus_buf_thresh:%04x\n", - DDB0_FIELDW(est_nexus_buf_thresh)); - asd_printk("conn_not_active:%02x\n", DDB0_FIELDB(conn_not_active)); - asd_printk("phy_is_up:%02x\n", DDB0_FIELDB(phy_is_up)); - asd_printk("port_map_by_links:%02x %02x %02x %02x " - "%02x %02x %02x %02x\n", - DDB0_FIELDA(port_map_by_links, 0), - DDB0_FIELDA(port_map_by_links, 1), - DDB0_FIELDA(port_map_by_links, 2), - DDB0_FIELDA(port_map_by_links, 3), - DDB0_FIELDA(port_map_by_links, 4), - DDB0_FIELDA(port_map_by_links, 5), - DDB0_FIELDA(port_map_by_links, 6), - DDB0_FIELDA(port_map_by_links, 7)); -} - -static void asd_dump_scb_site(struct asd_ha_struct *asd_ha, u16 site_no) -{ - -#define SCB_FIELDB(__name) \ - asd_scbsite_read_byte(asd_ha, site_no, sizeof(struct scb_header) \ - + offsetof(struct initiate_ssp_task, __name)) -#define SCB_FIELDW(__name) \ - asd_scbsite_read_word(asd_ha, site_no, sizeof(struct scb_header) \ - + offsetof(struct initiate_ssp_task, __name)) -#define SCB_FIELDD(__name) \ - asd_scbsite_read_dword(asd_ha, site_no, sizeof(struct scb_header) \ - + offsetof(struct initiate_ssp_task, __name)) - - asd_printk("Total Xfer Len: 0x%08x.\n", SCB_FIELDD(total_xfer_len)); - asd_printk("Frame Type: 0x%02x.\n", SCB_FIELDB(ssp_frame.frame_type)); - asd_printk("Tag: 0x%04x.\n", SCB_FIELDW(ssp_frame.tag)); - asd_printk("Target Port Xfer Tag: 0x%04x.\n", - SCB_FIELDW(ssp_frame.tptt)); - asd_printk("Data Offset: 0x%08x.\n", SCB_FIELDW(ssp_frame.data_offs)); - asd_printk("Retry Count: 0x%02x.\n", SCB_FIELDB(retry_count)); -} - -/** - * asd_dump_scb_sites -- dump currently used CSEQ SCB sites - * @asd_ha: pointer to host adapter struct - */ -void asd_dump_scb_sites(struct asd_ha_struct *asd_ha) -{ - u16 site_no; - - for (site_no = 0; site_no < asd_ha->hw_prof.max_scbs; site_no++) { - u8 opcode; - - if (!SCB_SITE_VALID(site_no)) - continue; - - /* We are only interested in SCB sites currently used. - */ - opcode = asd_scbsite_read_byte(asd_ha, site_no, - offsetof(struct scb_header, - opcode)); - if (opcode == 0xFF) - continue; - - asd_printk("\nSCB: 0x%x\n", site_no); - asd_dump_scb_site(asd_ha, site_no); - } -} - -#endif /* 0 */ - /** * ads_dump_seq_state -- dump CSEQ and LSEQ states * @asd_ha: pointer to host adapter structure @@ -908,42 +762,4 @@ void asd_dump_frame_rcvd(struct asd_phy *phy, spin_unlock_irqrestore(&phy->sas_phy.frame_rcvd_lock, flags); } -#if 0 - -static void asd_dump_scb(struct asd_ascb *ascb, int ind) -{ - asd_printk("scb%d: vaddr: 0x%p, dma_handle: 0x%llx, next: 0x%llx, " - "index:%d, opcode:0x%02x\n", - ind, ascb->dma_scb.vaddr, - (unsigned long long)ascb->dma_scb.dma_handle, - (unsigned long long) - le64_to_cpu(ascb->scb->header.next_scb), - le16_to_cpu(ascb->scb->header.index), - ascb->scb->header.opcode); -} - -void asd_dump_scb_list(struct asd_ascb *ascb, int num) -{ - int i = 0; - - asd_printk("dumping %d scbs:\n", num); - - asd_dump_scb(ascb, i++); - --num; - - if (num > 0 && !list_empty(&ascb->list)) { - struct list_head *el; - - list_for_each(el, &ascb->list) { - struct asd_ascb *s = list_entry(el, struct asd_ascb, - list); - asd_dump_scb(s, i++); - if (--num <= 0) - break; - } - } -} - -#endif /* 0 */ - #endif /* ASD_DEBUG */ From patchwork Wed Mar 17 08:56:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12145119 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBACFC433E9 for ; Wed, 17 Mar 2021 08:57:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EE6A64F37 for ; Wed, 17 Mar 2021 08:57:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229634AbhCQI5S (ORCPT ); Wed, 17 Mar 2021 04:57:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229639AbhCQI5J (ORCPT ); Wed, 17 Mar 2021 04:57:09 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30DDAC061760 for ; Wed, 17 Mar 2021 01:57:09 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id o16so969826wrn.0 for ; Wed, 17 Mar 2021 01:57:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nA9wVETTE+l5uPS+DZDdIXSJ2iBKhK6p+7XSOzWKHSU=; b=IpdBPhyKk00RIO/U1dBVMIyjhNggRxNiKxQ1Ne9aLwjQov2ko42z2b8zf+M/92BgHo N5pApE/eK+0PFoBnBqxtgT6un/LSFXhA/iRRslyBIqR29bg0esYI2FXihV/fXvXUN30I 43XxadPKXofRgd9zY/tiTjp0k2UHCD0iFkMhyRlBn0p4MAHe+d8pkPfUKKIVuM6KybBc A1nSNpEiXGPu/50pqUkBoTAf7NRMuHDu2iwAE6lFShqzy8FtJAsS/3XXPmtZZQF6qf/c suOCldk6SO6n1k2Cjbb4P4EzRLMJR5TxXtz98N+rg83PMBujGKfYpD9GUBNAlFqE8nL+ oZLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nA9wVETTE+l5uPS+DZDdIXSJ2iBKhK6p+7XSOzWKHSU=; b=P5v4UqtWoJBQgGnM4G+7RMq8g4AoHGCrPvNf9EuMUEnhnNcSgQatI12AnyN/RiF+zW IReV9wv7DktW2RKZC6pZ0Vpfr3DgaNAmKVyMGc+HzvbSlgJ9jgRXCiPviw46OmQiEb/z vAUz2X9tiDapyMFlp4e7nH9Cr8ykP6VGzanqWcJHsJ0Wh+aHuJpWt7t9bCJohwrWHAEa vn2sDW6dK2MQt+2KPS1JIWLjE6x/iMljNFQnSQsAJWYVwQQGQyYMbWxVeyiP89FdOT17 HOqb1+tUCmx/M5iJKZ8wb8eA+Bt/Ju1j/OFov5iQkxvhDjFCT82sXDQGcVlknnhOx/MZ oBSA== X-Gm-Message-State: AOAM53272xNLZ347sOdGdYKFyDg3gkjQbdD6it5078FRH4GoIk3A8dt9 iSsL4cY3XTR0zyvdVy/Z9TObEQ== X-Google-Smtp-Source: ABdhPJzcfW5vsBPQIw18Etx1koK5A46+8gpgVbmzPhoOyR9LddKs/Y713OCbzU6GInd9sSgZFBiXWA== X-Received: by 2002:adf:ecca:: with SMTP id s10mr3123127wro.324.1615971427969; Wed, 17 Mar 2021 01:57:07 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j123sm1807243wmb.1.2021.03.17.01.57.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 01:57:07 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , "James E.J. Bottomley" , "Martin K. Petersen" , MPT-FusionLinux.pdl@avagotech.com, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org Subject: [PATCH 02/18] scsi: mpt3sas: mpt3sas_scs: Move a little data from the stack onto the heap Date: Wed, 17 Mar 2021 08:56:45 +0000 Message-Id: <20210317085701.2891231-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317085701.2891231-1-lee.jones@linaro.org> References: <20210317085701.2891231-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/mpt3sas/mpt3sas_scsih.c: In function ‘_scsih_scan_for_devices_after_reset’: drivers/scsi/mpt3sas/mpt3sas_scsih.c:10473:1: warning: the frame size of 1064 bytes is larger than 1024 bytes [-Wframe-larger-than=] Cc: Sathya Prakash Cc: Sreekanth Reddy Cc: Suganath Prabu Subramani Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: MPT-FusionLinux.pdl@avagotech.com Cc: MPT-FusionLinux.pdl@broadcom.com Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 38 +++++++++++++++++++--------- 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index 7bd0a57e5b928..945531e94d7e4 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -10219,8 +10219,8 @@ _scsih_scan_for_devices_after_reset(struct MPT3SAS_ADAPTER *ioc) Mpi2ExpanderPage0_t expander_pg0; Mpi2SasDevicePage0_t sas_device_pg0; Mpi26PCIeDevicePage0_t pcie_device_pg0; - Mpi2RaidVolPage1_t volume_pg1; - Mpi2RaidVolPage0_t volume_pg0; + Mpi2RaidVolPage1_t *volume_pg1; + Mpi2RaidVolPage0_t *volume_pg0; Mpi2RaidPhysDiskPage0_t pd_pg0; Mpi2EventIrConfigElement_t element; Mpi2ConfigReply_t mpi_reply; @@ -10235,6 +10235,16 @@ _scsih_scan_for_devices_after_reset(struct MPT3SAS_ADAPTER *ioc) u8 retry_count; unsigned long flags; + volume_pg0 = kzalloc(sizeof(*volume_pg0), GFP_KERNEL); + if (!volume_pg0) + return; + + volume_pg1 = kzalloc(sizeof(*volume_pg1), GFP_KERNEL); + if (!volume_pg1) { + kfree(volume_pg0); + return; + } + ioc_info(ioc, "scan devices: start\n"); _scsih_sas_host_refresh(ioc); @@ -10344,7 +10354,7 @@ _scsih_scan_for_devices_after_reset(struct MPT3SAS_ADAPTER *ioc) /* volumes */ handle = 0xFFFF; while (!(mpt3sas_config_get_raid_volume_pg1(ioc, &mpi_reply, - &volume_pg1, MPI2_RAID_VOLUME_PGAD_FORM_GET_NEXT_HANDLE, handle))) { + volume_pg1, MPI2_RAID_VOLUME_PGAD_FORM_GET_NEXT_HANDLE, handle))) { ioc_status = le16_to_cpu(mpi_reply.IOCStatus) & MPI2_IOCSTATUS_MASK; if (ioc_status != MPI2_IOCSTATUS_SUCCESS) { @@ -10352,15 +10362,15 @@ _scsih_scan_for_devices_after_reset(struct MPT3SAS_ADAPTER *ioc) ioc_status, le32_to_cpu(mpi_reply.IOCLogInfo)); break; } - handle = le16_to_cpu(volume_pg1.DevHandle); + handle = le16_to_cpu(volume_pg1->DevHandle); spin_lock_irqsave(&ioc->raid_device_lock, flags); raid_device = _scsih_raid_device_find_by_wwid(ioc, - le64_to_cpu(volume_pg1.WWID)); + le64_to_cpu(volume_pg1->WWID)); spin_unlock_irqrestore(&ioc->raid_device_lock, flags); if (raid_device) continue; if (mpt3sas_config_get_raid_volume_pg0(ioc, &mpi_reply, - &volume_pg0, MPI2_RAID_VOLUME_PGAD_FORM_HANDLE, handle, + volume_pg0, MPI2_RAID_VOLUME_PGAD_FORM_HANDLE, handle, sizeof(Mpi2RaidVolPage0_t))) continue; ioc_status = le16_to_cpu(mpi_reply.IOCStatus) & @@ -10370,17 +10380,17 @@ _scsih_scan_for_devices_after_reset(struct MPT3SAS_ADAPTER *ioc) ioc_status, le32_to_cpu(mpi_reply.IOCLogInfo)); break; } - if (volume_pg0.VolumeState == MPI2_RAID_VOL_STATE_OPTIMAL || - volume_pg0.VolumeState == MPI2_RAID_VOL_STATE_ONLINE || - volume_pg0.VolumeState == MPI2_RAID_VOL_STATE_DEGRADED) { + if (volume_pg0->VolumeState == MPI2_RAID_VOL_STATE_OPTIMAL || + volume_pg0->VolumeState == MPI2_RAID_VOL_STATE_ONLINE || + volume_pg0->VolumeState == MPI2_RAID_VOL_STATE_DEGRADED) { memset(&element, 0, sizeof(Mpi2EventIrConfigElement_t)); element.ReasonCode = MPI2_EVENT_IR_CHANGE_RC_ADDED; - element.VolDevHandle = volume_pg1.DevHandle; + element.VolDevHandle = volume_pg1->DevHandle; ioc_info(ioc, "\tBEFORE adding volume: handle (0x%04x)\n", - volume_pg1.DevHandle); + volume_pg1->DevHandle); _scsih_sas_volume_add(ioc, &element); ioc_info(ioc, "\tAFTER adding volume: handle (0x%04x)\n", - volume_pg1.DevHandle); + volume_pg1->DevHandle); } } @@ -10468,6 +10478,10 @@ _scsih_scan_for_devices_after_reset(struct MPT3SAS_ADAPTER *ioc) ioc_info(ioc, "\tAFTER adding pcie end device: handle (0x%04x), wwid(0x%016llx)\n", handle, (u64)le64_to_cpu(pcie_device_pg0.WWID)); } + + kfree(volume_pg0); + kfree(volume_pg1); + ioc_info(ioc, "\tpcie devices: pcie end devices complete\n"); ioc_info(ioc, "scan devices: complete\n"); } From patchwork Wed Mar 17 08:56:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12145125 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B75EC43381 for ; Wed, 17 Mar 2021 08:57:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE5E064E33 for ; Wed, 17 Mar 2021 08:57:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229705AbhCQI5T (ORCPT ); Wed, 17 Mar 2021 04:57:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229646AbhCQI5K (ORCPT ); Wed, 17 Mar 2021 04:57:10 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A101C061760 for ; Wed, 17 Mar 2021 01:57:10 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id x16so959983wrn.4 for ; Wed, 17 Mar 2021 01:57:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8874Mz34yg9EJ3yZWmxIP9iMB3o9NkD0mVwqsVKhHmY=; b=CKGmUYUpwZOzR8gWVNitbosI+8/vpSWLSEKNDwLKELUv3oIDgkyAcSWNJ1I5tm2Tm0 fWChB1QAcqLYtX3s55tGvEnRd6Iv3yDx2McS/qNnBUQiQunGSgSjqeRBtIgw145CVnwy E8bUdNlN5G9AbMeMHeFDezFROeobMZ/nUT6VygBS95Z1itSTFrj+z75Rt66xA6zAKE4A BMrqd5ci1eeuTE+EtSQHNoaV7LAPi7MoZpS/Q5a1yuyySHlMwqHq31SB1bnFqe2KP5r2 5g+B5Mf0WaUGL4ogMCQb3VJd65aO1QhZFG/WPap7I37mB9ezpbGlkv8svlW1drpd9hjb NEOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8874Mz34yg9EJ3yZWmxIP9iMB3o9NkD0mVwqsVKhHmY=; b=Gn78MnvTrZBx109kFD0nGTwOdipO+WYx87vro+nb5XDPMe1tuH841iLgHcApgVDAUX U2aJfJvZErGb17drf0dvtjs5f45JQ0Q03aP9WV10bgvk8L0XFDOFa6MWDSqfeFGyCAOh 5ejAEvJc3lUfxeyZ0Lpsi5xViMEvETDMOHSCoG/WItOLe9ta+UP2dG0brQ3gv8GOqg53 VVcJrpUPO/GPGtmgW9fZt6csSH0VN2X5Qz0RRtO1bMAQV/nLqD+/dG9CI2a+Fw3N+ZOY YKVDjgSjifYtAqPe44Fj0nKbFe/SdO14MNEBaST3sQkPYgahOVexkn3W3vasSN+oc40K 8lUA== X-Gm-Message-State: AOAM530WkB7hbp9PD5gmJCtLJ1rGfQifeuyPBX67W7CIpybw8bdXB3g8 gRPaHbU+qdJbwyB04ljbonFaVA== X-Google-Smtp-Source: ABdhPJwEaEN+lO1BXC85/Urtt4ByXSxTUMs35cKgWOXH1pfSrxv2rxSZ3Hld1wBvoRvtOu/5jLnYkA== X-Received: by 2002:adf:8b4e:: with SMTP id v14mr2190343wra.103.1615971429053; Wed, 17 Mar 2021 01:57:09 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j123sm1807243wmb.1.2021.03.17.01.57.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 01:57:08 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Anil Gurumurthy , Sudarsana Kalluru , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 03/18] scsi: bfa: bfa_fcs_lport: Move a large struct from the stack onto the heap Date: Wed, 17 Mar 2021 08:56:46 +0000 Message-Id: <20210317085701.2891231-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317085701.2891231-1-lee.jones@linaro.org> References: <20210317085701.2891231-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/bfa/bfa_fcs_lport.c: In function ‘bfa_fcs_lport_fdmi_build_rhba_pyld’: drivers/scsi/bfa/bfa_fcs_lport.c:2152:1: warning: the frame size of 1200 bytes is larger than 1024 bytes [-Wframe-larger-than=] Cc: Anil Gurumurthy Cc: Sudarsana Kalluru Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/bfa/bfa_fcs_lport.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/bfa/bfa_fcs_lport.c b/drivers/scsi/bfa/bfa_fcs_lport.c index 49a14157f123c..b12afcc4b1894 100644 --- a/drivers/scsi/bfa/bfa_fcs_lport.c +++ b/drivers/scsi/bfa/bfa_fcs_lport.c @@ -1408,7 +1408,7 @@ static void bfa_fcs_lport_fdmi_rpa_response(void *fcsarg, u32 resid_len, struct fchs_s *rsp_fchs); static void bfa_fcs_lport_fdmi_timeout(void *arg); -static u16 bfa_fcs_lport_fdmi_build_rhba_pyld(struct bfa_fcs_lport_fdmi_s *fdmi, +static int bfa_fcs_lport_fdmi_build_rhba_pyld(struct bfa_fcs_lport_fdmi_s *fdmi, u8 *pyld); static u16 bfa_fcs_lport_fdmi_build_rprt_pyld(struct bfa_fcs_lport_fdmi_s *fdmi, u8 *pyld); @@ -1887,6 +1887,8 @@ bfa_fcs_lport_fdmi_send_rhba(void *fdmi_cbarg, struct bfa_fcxp_s *fcxp_alloced) bfa_fcs_lport_fdmi_build_rhba_pyld(fdmi, (u8 *) ((struct ct_hdr_s *) pyld + 1)); + if (attr_len < 0) + return; bfa_fcxp_send(fcxp, NULL, port->fabric->vf_id, port->lp_tag, BFA_FALSE, FC_CLASS_3, (len + attr_len), &fchs, @@ -1896,17 +1898,20 @@ bfa_fcs_lport_fdmi_send_rhba(void *fdmi_cbarg, struct bfa_fcxp_s *fcxp_alloced) bfa_sm_send_event(fdmi, FDMISM_EVENT_RHBA_SENT); } -static u16 +static int bfa_fcs_lport_fdmi_build_rhba_pyld(struct bfa_fcs_lport_fdmi_s *fdmi, u8 *pyld) { struct bfa_fcs_lport_s *port = fdmi->ms->port; - struct bfa_fcs_fdmi_hba_attr_s hba_attr; - struct bfa_fcs_fdmi_hba_attr_s *fcs_hba_attr = &hba_attr; + struct bfa_fcs_fdmi_hba_attr_s *fcs_hba_attr; struct fdmi_rhba_s *rhba = (struct fdmi_rhba_s *) pyld; struct fdmi_attr_s *attr; + int len; u8 *curr_ptr; - u16 len, count; - u16 templen; + u16 templen, count; + + fcs_hba_attr = kzalloc(sizeof(*fcs_hba_attr), GFP_KERNEL); + if (!fcs_hba_attr) + return -ENOMEM; /* * get hba attributes @@ -2148,6 +2153,9 @@ bfa_fcs_lport_fdmi_build_rhba_pyld(struct bfa_fcs_lport_fdmi_s *fdmi, u8 *pyld) len += ((sizeof(attr->type) + sizeof(attr->len)) * count); rhba->hba_attr_blk.attr_count = cpu_to_be32(count); + + kfree(fcs_hba_attr); + return len; } From patchwork Wed Mar 17 08:56:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12145127 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50DC9C433E6 for ; Wed, 17 Mar 2021 08:57:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A16E64F4D for ; Wed, 17 Mar 2021 08:57:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229721AbhCQI5U (ORCPT ); Wed, 17 Mar 2021 04:57:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229658AbhCQI5L (ORCPT ); Wed, 17 Mar 2021 04:57:11 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F7C4C061760 for ; Wed, 17 Mar 2021 01:57:11 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id x16so960047wrn.4 for ; Wed, 17 Mar 2021 01:57:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KspmBqbjk4SwVrkpMki278CpteugIPA4FRqHSDe0Ld8=; b=f0wMl7PPI9GyJQ54AsUw33UqcpCkutaW99aa+jPQ9689zDYUS3KVhJe4WI5qMqNIMx T0XQXz/xhmwwte8hcpnLMQZ+oKFfRkIzVEL8FEwBnOEdKMnGJfJvnBWyH0gg+QjzGKkP ouulMB01hntTnTyV5ZPGOSVNs5eq3hLvrbWC0pIbQi1k8XrTnDPLHxWf5T910lB7U7+J KDirvMUvLbDFUbILI65/V2KTy4LFIZRwRoJ7tDVGrrcL/py9f30rUdnozR3ZWli9q2QY ECsn1RWJYUel/qmol5Q8F6YE9PAMhJib289eXCSDAUuSngGXnCzyFVB7uRcmtsNVfe2I i23A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KspmBqbjk4SwVrkpMki278CpteugIPA4FRqHSDe0Ld8=; b=saVyB8aVdB+sB0TOxuoiaw87ADSHchQkPMuwF+kQd5yneToXojVJEos99kmhUBDLbV M4AUCelAcLHZm2T5an00HVVHh0KnpbAlEn9awzSbJNY1mS1lbF7rACWpNM6A9U9kF48s aaM/NLxWLDxrmXhv1076fCFVEGbLoMhfKqiucyondNMt7LT0ww70xoxtkIt8tfLhLKod usIlKyAP8ACTtvkkp9bbZFfBtiyk8cZZQBv1tiDf8Yd/ndn9K+nLyCYgmcoxz6fhIwi8 2+qE2T+F12AQdn5Y37rkZfnZViI6V2GNC3l5oDDiGQ5ebdu55ptlJwo1ITmEWe/qK3XJ BtbA== X-Gm-Message-State: AOAM533EPWOkLItpgeEvkBULMhr/skeaBfZY+ccH0BgMy5UM+7meghcy 2b2jPHU6m0ZapSrxmLaXTbOzMg== X-Google-Smtp-Source: ABdhPJxiWEKbcNLmng1Gyv4HVIliU9TYFHWiylRwsZe31cecjp+u+ZiyKznNHkHuce3wCKPgTS/0Iw== X-Received: by 2002:a5d:528f:: with SMTP id c15mr3252496wrv.142.1615971429964; Wed, 17 Mar 2021 01:57:09 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j123sm1807243wmb.1.2021.03.17.01.57.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 01:57:09 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Bradley Grove , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 04/18] scsi: esas2r: esas2r_log: Supply __printf(x, y) formatting for esas2r_log_master() Date: Wed, 17 Mar 2021 08:56:47 +0000 Message-Id: <20210317085701.2891231-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317085701.2891231-1-lee.jones@linaro.org> References: <20210317085701.2891231-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/esas2r/esas2r_log.c: In function ‘esas2r_log_master’: drivers/scsi/esas2r/esas2r_log.c:155:3: warning: function ‘esas2r_log_master’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] Cc: Bradley Grove Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/esas2r/esas2r_log.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/esas2r/esas2r_log.c b/drivers/scsi/esas2r/esas2r_log.c index b545798e400c4..d6c87a0bae098 100644 --- a/drivers/scsi/esas2r/esas2r_log.c +++ b/drivers/scsi/esas2r/esas2r_log.c @@ -101,6 +101,11 @@ static const char *translate_esas2r_event_level_to_kernel(const long level) } } +#pragma GCC diagnostic push +#ifndef __clang__ +#pragma GCC diagnostic ignored "-Wsuggest-attribute=format" +#endif + /* * the master logging function. this function will format the message as * outlined by the formatting string, the input device information and the @@ -170,6 +175,8 @@ static int esas2r_log_master(const long level, return 0; } +#pragma GCC diagnostic pop + /* * formats and logs a message to the system log. * From patchwork Wed Mar 17 08:56:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12145153 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CA3BC4361A for ; Wed, 17 Mar 2021 08:58:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2BCBE64E33 for ; Wed, 17 Mar 2021 08:58:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229925AbhCQI57 (ORCPT ); Wed, 17 Mar 2021 04:57:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229725AbhCQI5V (ORCPT ); Wed, 17 Mar 2021 04:57:21 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25A6DC06175F for ; Wed, 17 Mar 2021 01:57:12 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id e9so946413wrw.10 for ; Wed, 17 Mar 2021 01:57:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bN4fpSzo8exezj3x7f+Hv5XSvvEKZvIRblLuzQg15wk=; b=xuGfcjmNoUNXdROabMzOnp0WZczjaQntC401d3z0wxWnRyuDoOC7cLATKwINdfklxQ ipodwjPR8/UKrJCUnSuLoBWX4J0+zkWPgZHwfVRFq/JCNTTTEKFlDd6wichhADg5l51h ow0XgtK2MhaMGdfWq2GJegVsAtdoTw2zrNGdL4x/VjKv6cFSUd3V3Nj5/ziTWD5p7mdx w3v/8Vp2sRo1m64T/B55BCiLrYVzuE3YIbmIEY85Y9uQjMwcTjyOrOV9mZOrXR8EBPwx EpgZzlvSTGDUvbcYNllIid91Jejxd9CJ8edLszNiRwbD5juw6PWeFdc3BPlBBmvL0dKg J5MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bN4fpSzo8exezj3x7f+Hv5XSvvEKZvIRblLuzQg15wk=; b=YvjLZY3Wu7HN0+6PxU/Whog9JnqpXahB6URvz7cjIwGgFiJLzHss0Ri8odva1rqC00 mN/SAA0fnzuJ2iW1a5kibpEhzSFn7HBycHERbm1MEvFH+A3qRT9faJiV05N3QeBkEK31 nfUIIR+0E/ZW2NImYRelWgyh5spUeKNuz3bLXkOrWc5MHxvFPXf/prZePwEsJFLcOT6X CXi7TnlzwXZPPEQfLFRAHuzrzE/wm6zdANMI9rHENi+ymDgqkZZnbRb5XdN++Kr99cXs 7n/dKpLeUlILDHcFxXRtMFoANGTSkgHXPskQU1bk6fKi/ElvF79u2tcd5sFI+mfTRs+f +f/g== X-Gm-Message-State: AOAM533ToWGfLWRTkf6jWol5jEkAE9/61ctwvrU5E0NYfp+9cqO7eg6b 8YOj2dEcvW3q8rLSfKbgDqsyJQ== X-Google-Smtp-Source: ABdhPJy5t8wI6UT8Xo/n7g49VzgKzqRcjwyHyXv4pFUXBOJOi2gYDFERdSuMSgbcsfCFzpwvQuN0ng== X-Received: by 2002:a5d:6443:: with SMTP id d3mr3287356wrw.292.1615971430935; Wed, 17 Mar 2021 01:57:10 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j123sm1807243wmb.1.2021.03.17.01.57.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 01:57:10 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Khalid Aziz , "James E.J. Bottomley" , "Martin K. Petersen" , "Leonard N. Zubkoff" , linux-scsi@vger.kernel.org Subject: [PATCH 05/18] scsi: BusLogic: Supply __printf(x, y) formatting for blogic_msg() Date: Wed, 17 Mar 2021 08:56:48 +0000 Message-Id: <20210317085701.2891231-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317085701.2891231-1-lee.jones@linaro.org> References: <20210317085701.2891231-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/scsi/BusLogic.c:51: drivers/scsi/BusLogic.c: In function ‘blogic_msg’: drivers/scsi/BusLogic.c:3591:2: warning: function ‘blogic_msg’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] Cc: Khalid Aziz Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: "Leonard N. Zubkoff" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/BusLogic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c index ccb061ab0a0ad..0ac3f713fc212 100644 --- a/drivers/scsi/BusLogic.c +++ b/drivers/scsi/BusLogic.c @@ -3578,7 +3578,7 @@ Target Requested Completed Requested Completed Requested Completed\n\ /* blogic_msg prints Driver Messages. */ - +__printf(2, 4) static void blogic_msg(enum blogic_msglevel msglevel, char *fmt, struct blogic_adapter *adapter, ...) { From patchwork Wed Mar 17 08:56:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12145149 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93A7FC432C3 for ; Wed, 17 Mar 2021 08:58:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BFD664F3C for ; Wed, 17 Mar 2021 08:58:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229912AbhCQI56 (ORCPT ); Wed, 17 Mar 2021 04:57:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229730AbhCQI5V (ORCPT ); Wed, 17 Mar 2021 04:57:21 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02892C061762 for ; Wed, 17 Mar 2021 01:57:13 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id r10-20020a05600c35cab029010c946c95easo804630wmq.4 for ; Wed, 17 Mar 2021 01:57:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QUcUbYzVq4WAbYCHC6A4U/IWUbOjJbgRMpmZlOoFPaU=; b=D0YkNBCYTamiXrgPRgqVt+oGtaNIahNih1zVi3JKpExNJovdhGEzRski9jHwxTVYsS oZsaTDTrC+reO7lrS5Vk7P4YhRpbgdpgxDPYZ311JVftUG04ixF8ZvUW9GHagMdn9Ypa 1paDvFYIvxO/+sD5a076CFTNSSaxqghBAR4e5zPEIehRkZvm6loUtHO4SW4AIbczZzad 5ozQpPUQD0HjK3zxPE+Y4on2H2VdeJ38f/opy4xsRZzgAvIoa836WgjLO6FmhIWBsIFq JFKSAxClEw4wclve1ds0Ni6hI5VcExEUynhWwogfo+xLSzBJpu66LmnGz1NS4GOd3Flj aFng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QUcUbYzVq4WAbYCHC6A4U/IWUbOjJbgRMpmZlOoFPaU=; b=bAT+VNtVZ//ZhBXd08NvbNlmS/zQmbcZ+JmgZZrVo7WJiybP8tUJWUF68p67KOUitj 5aqWZ91T6ndV4WWT3GVq4Hbk/XundgWOM8XRJSj9nNr9IN83JoQDthsoIAerhOVRZm7u gQYQvXvY5E23qk459izMPqtJOIY01H3vBqoIQWejmP5RskV19Ylnmdi5ZkiDh3awrrkq HF+jKDz1yNU5nnVW/rH6ZxqslYnsCo2EKMnaT/bxM0folxukLUeofFuJhuKzyfjN/gne 2G6EV1CAstKP42X2u/jqSmRnBanUFbvtnqatHHwfzK8l01YPdQObK760H7dSre1tQ1nT kk3w== X-Gm-Message-State: AOAM533EtTA/cll1oGHiUJFiUm7DZa518HkaGPXwXO9dJInBCkAe5hVv t1kssVHmTupJGOHhOXUwXtzugg== X-Google-Smtp-Source: ABdhPJwcugoR+ehbObpRf84pGmeg8jmjF9eXyBPY2141WPr9ws3tvsLgZGZSUPCd3OkkDPm0sai2Ww== X-Received: by 2002:a1c:7406:: with SMTP id p6mr2599861wmc.103.1615971431794; Wed, 17 Mar 2021 01:57:11 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j123sm1807243wmb.1.2021.03.17.01.57.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 01:57:11 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, GOTO Masanori , YOKOTA Hiroshi , "James E.J. Bottomley" , "Martin K. Petersen" , gotom@debian.org, linux-scsi@vger.kernel.org Subject: [PATCH 06/18] scsi: nsp32: Supply __printf(x, y) formatting for nsp32_message() Date: Wed, 17 Mar 2021 08:56:49 +0000 Message-Id: <20210317085701.2891231-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317085701.2891231-1-lee.jones@linaro.org> References: <20210317085701.2891231-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/nsp32.c: In function ‘nsp32_message’: drivers/scsi/nsp32.c:318:2: warning: function ‘nsp32_message’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] Cc: GOTO Masanori Cc: YOKOTA Hiroshi Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: gotom@debian.org Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/nsp32.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c index e44b1a0f67099..d5aa96f05bce4 100644 --- a/drivers/scsi/nsp32.c +++ b/drivers/scsi/nsp32.c @@ -309,6 +309,7 @@ static struct scsi_host_template nsp32_template = { #define NSP32_DEBUG_BUF_LEN 100 +__printf(4, 5) static void nsp32_message(const char *func, int line, char *type, char *fmt, ...) { va_list args; From patchwork Wed Mar 17 08:56:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12145151 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC967C4321A for ; Wed, 17 Mar 2021 08:58:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90F9A64F26 for ; Wed, 17 Mar 2021 08:58:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229903AbhCQI55 (ORCPT ); Wed, 17 Mar 2021 04:57:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229732AbhCQI5V (ORCPT ); Wed, 17 Mar 2021 04:57:21 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2482CC061764 for ; Wed, 17 Mar 2021 01:57:14 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id b2-20020a7bc2420000b029010be1081172so825417wmj.1 for ; Wed, 17 Mar 2021 01:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=im+Evr3MfJAtsbpRKrSvBZYIR3R8HYWcJI2GsyeTWRU=; b=DM1ORFPtKVJaRVNMisxtioWMH2mlZJEFFRCvJipOaWkDHZB63Rem+T6nvpCOVzeY8q NZp+UaPQrGC+vQ/evx+UneOrjxZMFwIJ8DWaxESSZN544FxOVNje/CsPouZ+/l/dQXRo sk0zzzGiYEjyLYjkXeYU/7UIXcKUXYvsZ7xdBHGjWi0+CnfzG7WHDINxuGoIBzUscPxc 5idmZvijQBsKN1M5I+LzcN2E4EjAN6A+YQypx3IUXAQn4ZFXfGZ2uIbqsRLAqIQM9C5x BpJmHm4lQFHacPfuWXw+Svk06up4lWy6aqB4wWxqsrFFRF874LoyFzl/4y4qQHsytKaY 8JAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=im+Evr3MfJAtsbpRKrSvBZYIR3R8HYWcJI2GsyeTWRU=; b=YU9sNBud2YtH/ao+0U0X6NVSL9VTgFHI3/KDWu9yQrElt+dMrpxrnXyZ+zB9i6VHRA Gp48bohCWAXepv4wMDrQi8+cyFiMmb+xiKMuwGO1W0PePkbYRUaLFtkR7sTrGmuU2aIG ittqScdsMDmuWOH2C/ShFcdlt1gprBd7/Zgp678Tj0HLJKQlrAj7V5Gemwe9ajKuREy7 1uiHbwkktSzucyiz73GLunfiEzMVWiU4SXgSfnw5VJJNjY16k5zL4W7eqcEwvvN2+f0k J0fg46lKn4CSXb1YJOA3kGhkqGa+YgMyDYln6G2JxqQtklcqiYzRc11RORC5UxwVmNZn PeHA== X-Gm-Message-State: AOAM530YWSUYCHSisoSbGhqFwbqDTuSjIiDit2KXogFiism5GpK2ZD7H dfYFqANKz/awMbMntju1UMjEcw== X-Google-Smtp-Source: ABdhPJz29XYZWfGQGPHyM7puMmx9SI7VFt1GZ6uHPJidpB+OMbJRhfyZHKT8jmSsGRT/UCHPsOrPBQ== X-Received: by 2002:a7b:c195:: with SMTP id y21mr2634320wmi.178.1615971432922; Wed, 17 Mar 2021 01:57:12 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j123sm1807243wmb.1.2021.03.17.01.57.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 01:57:12 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , Bas Vermeulen , Christoph Hellwig , Brian Macy , linux-scsi@vger.kernel.org Subject: [PATCH 07/18] scsi: initio: Remove unused variable 'prev' Date: Wed, 17 Mar 2021 08:56:50 +0000 Message-Id: <20210317085701.2891231-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317085701.2891231-1-lee.jones@linaro.org> References: <20210317085701.2891231-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/initio.c: In function ‘initio_find_busy_scb’: drivers/scsi/initio.c:869:30: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable] Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Bas Vermeulen Cc: Christoph Hellwig Cc: Brian Macy Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/initio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c index 814acc57069dc..926a7045c2e5c 100644 --- a/drivers/scsi/initio.c +++ b/drivers/scsi/initio.c @@ -866,17 +866,16 @@ static void initio_unlink_busy_scb(struct initio_host * host, struct scsi_ctrl_b struct scsi_ctrl_blk *initio_find_busy_scb(struct initio_host * host, u16 tarlun) { - struct scsi_ctrl_blk *tmp, *prev; + struct scsi_ctrl_blk *tmp; u16 scbp_tarlun; - prev = tmp = host->first_busy; + tmp = host->first_busy; while (tmp != NULL) { scbp_tarlun = (tmp->lun << 8) | (tmp->target); if (scbp_tarlun == tarlun) { /* Unlink this SCB */ break; } - prev = tmp; tmp = tmp->next; } #if DEBUG_QUEUE From patchwork Wed Mar 17 08:56:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12145123 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E43CC4332B for ; Wed, 17 Mar 2021 08:57:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 396BB64EE2 for ; Wed, 17 Mar 2021 08:57:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229743AbhCQI5W (ORCPT ); Wed, 17 Mar 2021 04:57:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229683AbhCQI5P (ORCPT ); Wed, 17 Mar 2021 04:57:15 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0179C061760 for ; Wed, 17 Mar 2021 01:57:14 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id y124-20020a1c32820000b029010c93864955so2908107wmy.5 for ; Wed, 17 Mar 2021 01:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l+1EJFBCtfo9l4gZLbyeXef//j2IlwdufiBKnHN8Ms4=; b=SKA3psbfj5f7Um44JGG8FKNE9H0hMuOoWt6WNZmaOG3Zqzw4HRofNMesdpsoJxVplR j4yvm5gbPpdspzpBGwdC1paXhtqKo0lblnAavll/x0LLH2fW1iJR1qnrrGGkW8i0u3R0 ibov7RikkU5XHX3MtoFuzFsbG8BD5l2If2FkQDcc3PdWALyJSxekxL62SZa53XdVWyQr Vya6eZRAf2PQ8Y0oh1GEQtFLV9Y4RAJxba+YdVg5dk2R9xbf9rPPLvsdKLIh+v/gl3LT i5FPw5F6clmJxzE8ljdyz3ZbHwm8EYKC0rEb1Pxm1Llx1B6F6drv6BmFmvYeLiNhVfRQ agAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l+1EJFBCtfo9l4gZLbyeXef//j2IlwdufiBKnHN8Ms4=; b=dKWj76UI6pKX4sMSNFXUHreIDKYQRQ5kHBe3FnMrUokGV/V8GfhoR/11R40hVBnfBP TTVyNu0ZY2vKNX1Xbe+STy19B+5GLPgok6w6fks01JGnUYtW6fEiB5FLEvpNxXl6T4Ad rYxWXl9+hGDmCMMFYOg/JrW396PQvSpeU0sUM8BK4z2YT41gp6hMG3opra4IgMld0d7o TWzpwYr5R/SXH/2136yuAn7hBv/i1oSd0C0f8HycqLnM17COI+JYmubwwfxD0J7dusIl bmU/ZOrMnlwRxS7VieK+LbHqez7lcUW+r+SyG1F6lBebSO2htmNZE/k/mQ52pF9fimkj iNIw== X-Gm-Message-State: AOAM530/zUVSv+agyK1+BpzhxRi2CbA1ez1oT1AEAC6FuIBwVeKMp6tR kKSITlM4mBh/zVN/7gPQe9h+gA== X-Google-Smtp-Source: ABdhPJz181LhBLmutFOYGnihVIaN6OavW4rkwV7VElcenpA9Qb98+4DwhdTWR24irt6eFOE5AFPGEg== X-Received: by 2002:a05:600c:210a:: with SMTP id u10mr2649152wml.147.1615971433784; Wed, 17 Mar 2021 01:57:13 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j123sm1807243wmb.1.2021.03.17.01.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 01:57:13 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , Doug Ledford , Christoph Hellwig , Alan Cox , linux-scsi@vger.kernel.org Subject: [PATCH 08/18] scsi: a100u2w: Remove unused variable 'bios_phys' Date: Wed, 17 Mar 2021 08:56:51 +0000 Message-Id: <20210317085701.2891231-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317085701.2891231-1-lee.jones@linaro.org> References: <20210317085701.2891231-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/a100u2w.c: In function ‘inia100_probe_one’: drivers/scsi/a100u2w.c:1092:8: warning: variable ‘bios_phys’ set but not used [-Wunused-but-set-variable] Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Doug Ledford Cc: Christoph Hellwig Cc: Alan Cox Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/a100u2w.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c index 66c514310f3c5..c99224a128f82 100644 --- a/drivers/scsi/a100u2w.c +++ b/drivers/scsi/a100u2w.c @@ -1089,7 +1089,6 @@ static int inia100_probe_one(struct pci_dev *pdev, int error = -ENODEV; u32 sz; unsigned long biosaddr; - char *bios_phys; if (pci_enable_device(pdev)) goto out; @@ -1141,7 +1140,6 @@ static int inia100_probe_one(struct pci_dev *pdev, biosaddr = host->BIOScfg; biosaddr = (biosaddr << 4); - bios_phys = phys_to_virt(biosaddr); if (init_orchid(host)) { /* Initialize orchid chip */ printk("inia100: initial orchid fail!!\n"); goto out_free_escb_array; From patchwork Wed Mar 17 08:56:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12145129 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 746BBC433DB for ; Wed, 17 Mar 2021 08:58:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CEF364F26 for ; Wed, 17 Mar 2021 08:58:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229849AbhCQI5t (ORCPT ); Wed, 17 Mar 2021 04:57:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbhCQI5Q (ORCPT ); Wed, 17 Mar 2021 04:57:16 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDC79C061760 for ; Wed, 17 Mar 2021 01:57:15 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id n11-20020a05600c4f8bb029010e5cf86347so4963218wmq.1 for ; Wed, 17 Mar 2021 01:57:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jXzZsgME51o5a4S3G/qD/qZyWpfOm8qpjFIuUNjewrU=; b=QGHZI5JZVjfZ5Tep79BLQwCQgui+6efCtb3xulzDRViNdHHCrKeA9iGbsam5qHCR4F gY5m3K642uohesxcMXHKjHWXIWZ47/XuEx2konxYR6T+rcJd70So+lDNa7l6dqB1HjlH Jb59p8pF15hJ14Vux6S8wVGLkwhYSy2KvTBaV3rvFufg7+1RDRd4co7Cg3XPXYe3nTK1 TMB/DOouGq0U9JhIPkGRGwF6AmwqLuBp89OlYBgvpyicBDXIyuvim0IoehV1s/5ITCHD 6l6h3aLIG/Ij/daPoiMZAWU2YtkvkbhnmbTV0/MvamzGBwm0tmlo5hZOq0zVpgCzSMvs IWgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jXzZsgME51o5a4S3G/qD/qZyWpfOm8qpjFIuUNjewrU=; b=Djco/4uN/304YSBG9tOH39vtHV65vbudr+oPXi81zlpVREnhvPzXM0DO0lBrGzKTVT HX45oECdc1G0ZPCxlSGkv3r6egnEZCFoI/J4KUeMdrAWBihenRZwsNR3qWqA00+fbV7G QEx1DeTFGIHLJ+gCge2QrAeVdUszi8zRCOkjmjdeSgyqgxPp/du8UXzCSSKdxHf85k+H s0+YiyZ8CMVpNBOB+k1gFpg7noUcxcaSRazbEZGcushP2wEu/3Md4/DI56lh9ba3Y3Tx 76AfvM5njXMvJGePexzJbFeS4KU4BS0C21/Num2aoV+14nAUOexXkgkqUGXczW2aRBwB g42g== X-Gm-Message-State: AOAM531c/TlijxFNnD9E5EImNCCrrr22a3YV/vXOX8oHX0irLtI+SM7U FzMcsXeAdPG6Af3MGU8PPiLATQ== X-Google-Smtp-Source: ABdhPJwKpTHxLaetDBDHclcEHKeMcsLIkvwLk9lByiEkCRoyiM00PiF+OHH8mHkrLiqBPZVObm6hhw== X-Received: by 2002:a1c:67d6:: with SMTP id b205mr2684189wmc.118.1615971434702; Wed, 17 Mar 2021 01:57:14 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j123sm1807243wmb.1.2021.03.17.01.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 01:57:14 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , Linux GmbH , "Leonard N. Zubkoff" , linux-scsi@vger.kernel.org Subject: [PATCH 09/18] scsi: myrs: Remove a couple of unused 'status' variables Date: Wed, 17 Mar 2021 08:56:52 +0000 Message-Id: <20210317085701.2891231-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317085701.2891231-1-lee.jones@linaro.org> References: <20210317085701.2891231-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/myrs.c: In function ‘consistency_check_show’: drivers/scsi/myrs.c:1193:16: warning: variable ‘status’ set but not used [-Wunused-but-set-variable] drivers/scsi/myrs.c: In function ‘myrs_get_resync’: drivers/scsi/myrs.c:1984:5: warning: variable ‘status’ set but not used [-Wunused-but-set-variable] Cc: Hannes Reinecke Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Linux GmbH Cc: "Leonard N. Zubkoff" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/myrs.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/myrs.c b/drivers/scsi/myrs.c index 4adf9ded296aa..48e399f057d5c 100644 --- a/drivers/scsi/myrs.c +++ b/drivers/scsi/myrs.c @@ -1190,7 +1190,6 @@ static ssize_t consistency_check_show(struct device *dev, struct myrs_hba *cs = shost_priv(sdev->host); struct myrs_ldev_info *ldev_info; unsigned short ldev_num; - unsigned char status; if (sdev->channel < cs->ctlr_info->physchan_present) return snprintf(buf, 32, "physical device - not checking\n"); @@ -1199,7 +1198,7 @@ static ssize_t consistency_check_show(struct device *dev, if (!ldev_info) return -ENXIO; ldev_num = ldev_info->ldev_num; - status = myrs_get_ldev_info(cs, ldev_num, ldev_info); + myrs_get_ldev_info(cs, ldev_num, ldev_info); if (ldev_info->cc_active) return snprintf(buf, 32, "checking block %zu of %zu\n", (size_t)ldev_info->cc_lba, @@ -1981,14 +1980,13 @@ myrs_get_resync(struct device *dev) struct myrs_hba *cs = shost_priv(sdev->host); struct myrs_ldev_info *ldev_info = sdev->hostdata; u64 percent_complete = 0; - u8 status; if (sdev->channel < cs->ctlr_info->physchan_present || !ldev_info) return; if (ldev_info->rbld_active) { unsigned short ldev_num = ldev_info->ldev_num; - status = myrs_get_ldev_info(cs, ldev_num, ldev_info); + myrs_get_ldev_info(cs, ldev_num, ldev_info); percent_complete = ldev_info->rbld_lba * 100; do_div(percent_complete, ldev_info->cfg_devsize); } From patchwork Wed Mar 17 08:56:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12145131 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C82BFC433E9 for ; Wed, 17 Mar 2021 08:58:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A233464F75 for ; Wed, 17 Mar 2021 08:58:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229877AbhCQI5x (ORCPT ); Wed, 17 Mar 2021 04:57:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229584AbhCQI5R (ORCPT ); Wed, 17 Mar 2021 04:57:17 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEA35C06174A for ; Wed, 17 Mar 2021 01:57:16 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id b2-20020a7bc2420000b029010be1081172so825519wmj.1 for ; Wed, 17 Mar 2021 01:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6g1k4NOJoIyIgRaKDu88zZvT9OX+R02WPv1Cq13vbSs=; b=hVH8+7CFeF6siiczN9gEWSrkhgR3nF4LXv4BI4Ad0JT/kkz7DTW4CeTubJyFJ9q5bm aPSvCFSUWFNTxYdf4oWBZIYNZzMP9eOxCyDRsuOlDQ8A6sDUPFmg0zdVFyubcjCos8Jl UGi4zJyEX2/JHBUj18rdFIC5n1ATFa4PcS20X8R5swmyBHtrhU01Jw2D+d44uW7m2Odd M9nYUm7zYpGHg+3d6MX0Bc0XAXIsR0zP+D+wdKSfwatOWxuz93xyV/avQkstg1NY6um0 e4Qcl6wLJZJKxcM8TYP/Xk8ZTkrZ3cPCqHI+Ok1J4IUOgJda2dbYNmdX5+LBPM5Zx20x uKsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6g1k4NOJoIyIgRaKDu88zZvT9OX+R02WPv1Cq13vbSs=; b=JHlEfvu1obOV5AO/ts57jmByzuxBRMPatgA0PxDKDLiLlfNIfk8evGN77nrKMfqlSt mrJ2cjHvkYGW1FMNo4r42PnZLI8rJsgRLTe9wWuMymt5oDgVkIT+v6YosO37HJ2R7OtW 5LvAnwCVdO2q0EW6Q4OAcTBRYK6S8K39q4JLYNBArQj4O9wSguWCW5N8o8jrS86fEIj9 yODEy+MH0rVZ8/LZaRs3Uh3XJZ3taMCmqxEYlXkVz+8yXzVjPPviN+o9J/bqhadLMuEW r4IqfwsDh1McK/EFHaQe35IUek69oEMWQJ0rJynblmxH8tk2FcYfGb3aOOqaP3LK25tm tN7A== X-Gm-Message-State: AOAM532jUlIhWDpE1l44ngluLqOF3WjNdCZEvyzGP0DX5THGUH+DQj7N qM5wyZevLKOqKJ/4ZATWd0Zs8Q== X-Google-Smtp-Source: ABdhPJyLSZWYr2mFxAPz9Gy5xkXS9CsUhB6rhcee0PrYTBO5lXZ/0AcSY4E/DXguUxbsNyTfOM+OBQ== X-Received: by 2002:a05:600c:4f10:: with SMTP id l16mr2736082wmq.46.1615971435682; Wed, 17 Mar 2021 01:57:15 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j123sm1807243wmb.1.2021.03.17.01.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 01:57:15 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Adam Radford , "James E.J. Bottomley" , "Martin K. Petersen" , Joel Jacobson , de Melo , Andre Hedrick , linux-scsi@vger.kernel.org Subject: [PATCH 10/18] scsi: 3w-xxxx: Remove 2 unused variables 'response_que_value' and 'tw_dev' Date: Wed, 17 Mar 2021 08:56:53 +0000 Message-Id: <20210317085701.2891231-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317085701.2891231-1-lee.jones@linaro.org> References: <20210317085701.2891231-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/3w-xxxx.c: In function ‘tw_empty_response_que’: drivers/scsi/3w-xxxx.c:463:24: warning: variable ‘response_que_value’ set but not used [-Wunused-but-set-variable] drivers/scsi/3w-xxxx.c: In function ‘tw_scsi_biosparam’: drivers/scsi/3w-xxxx.c:1345:23: warning: variable ‘tw_dev’ set but not used [-Wunused-but-set-variable] Cc: Adam Radford Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Joel Jacobson Cc: de Melo Cc: Andre Hedrick Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/3w-xxxx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/3w-xxxx.c b/drivers/scsi/3w-xxxx.c index d90b9fca4aea2..a7292883b72bc 100644 --- a/drivers/scsi/3w-xxxx.c +++ b/drivers/scsi/3w-xxxx.c @@ -460,12 +460,12 @@ static int tw_check_errors(TW_Device_Extension *tw_dev) /* This function will empty the response que */ static void tw_empty_response_que(TW_Device_Extension *tw_dev) { - u32 status_reg_value, response_que_value; + u32 status_reg_value; status_reg_value = inl(TW_STATUS_REG_ADDR(tw_dev)); while ((status_reg_value & TW_STATUS_RESPONSE_QUEUE_EMPTY) == 0) { - response_que_value = inl(TW_RESPONSE_QUEUE_REG_ADDR(tw_dev)); + inl(TW_RESPONSE_QUEUE_REG_ADDR(tw_dev)); status_reg_value = inl(TW_STATUS_REG_ADDR(tw_dev)); } } /* End tw_empty_response_que() */ @@ -1342,10 +1342,8 @@ static int tw_scsi_biosparam(struct scsi_device *sdev, struct block_device *bdev sector_t capacity, int geom[]) { int heads, sectors, cylinders; - TW_Device_Extension *tw_dev; dprintk(KERN_NOTICE "3w-xxxx: tw_scsi_biosparam()\n"); - tw_dev = (TW_Device_Extension *)sdev->host->hostdata; heads = 64; sectors = 32; From patchwork Wed Mar 17 08:56:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12145133 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC9CBC43381 for ; Wed, 17 Mar 2021 08:58:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B422C64F72 for ; Wed, 17 Mar 2021 08:58:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229873AbhCQI5v (ORCPT ); Wed, 17 Mar 2021 04:57:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229607AbhCQI5S (ORCPT ); Wed, 17 Mar 2021 04:57:18 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D095CC061765 for ; Wed, 17 Mar 2021 01:57:17 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id g20so991011wmk.3 for ; Wed, 17 Mar 2021 01:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=953zZzIFTk8WBz/FuB+6aJVYCMmR1USbvaybVRbnoaU=; b=fN4I7yFb3bT0agUZAuKKK9MV20bGKoUYv0gAijUMS2TNYQQvzkAoGdQgUJ3K51szki fTF8u3u60XNSbvef7u15WZrwakRolIlNMlhFEQfADUUS7mDxS1zOthkwvkOCENpM8EMo ujHu5fizvEkphyoTeyn/AA5Vf6R7sh2LH2O+vBRV+A1KZVFEQ5M9s9HPrw4Oo2gwJO4L CSS1OcRGjL4WElyE0yxy/zqZVPhbj2Cl4yKPIXj6fZQHlwNVTC9d4jC1dTD+NGJQTyBN GC9EIjopVXqh9rGgjSDv2l9hReRYQfd7tce1bQwII+m120TsKuCYZ85gtJYAOYg5zBnq YxQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=953zZzIFTk8WBz/FuB+6aJVYCMmR1USbvaybVRbnoaU=; b=fdfqu0bfwhCWBpVrbQ3WnoKgbVVd+FeNAiYyPsZwe86HBJI1QBFMfEY2vzyiyG807p WpNDLOS5j54ZHqKrdW9WCT2Cg8WhZfqNSyZpQrldhi8QeYqsNyqeMHUmaOMOpVCs1DLC FsBPIRpQc5GxcyL4LMQaQGImyDYHwlqTNVz+va5j2ykw2cYo6eU+zoxIHVxVv7A6tWXW htZ3Iy/Dbyd5Z3f6jZzyMVICEtxyGa4uGGtsPmc/lip0aLaaWF0Mw03ARqcWLrGb1Xee HcfQJzEjxGJWijpJgHU97ass2d8/2iSN+YqX9bDhsqwINrUsUvh3g7NJgCLA3Qhh9lwx 7mxA== X-Gm-Message-State: AOAM532y+qI6T/ReqlRNbv18PpUklBZ6FXa3FX56yP+OQodcJtLNlnk1 5UVXtmodQ8QNX2jl77UzB4HAfg== X-Google-Smtp-Source: ABdhPJxVE0cd3tfdS9zvh2oezWLmBGKpwJPkLXFlFaytd8aVRlYU14e2Z5bxQHn7n06CvfzPplnUtQ== X-Received: by 2002:a7b:c35a:: with SMTP id l26mr2660180wmj.104.1615971436636; Wed, 17 Mar 2021 01:57:16 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j123sm1807243wmb.1.2021.03.17.01.57.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 01:57:16 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Adam Radford , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 11/18] scsi: 3w-9xxx: Remove a few set but unused variables Date: Wed, 17 Mar 2021 08:56:54 +0000 Message-Id: <20210317085701.2891231-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317085701.2891231-1-lee.jones@linaro.org> References: <20210317085701.2891231-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/3w-9xxx.c: In function ‘twa_empty_response_queue’: drivers/scsi/3w-9xxx.c:942:24: warning: variable ‘response_que_value’ set but not used [-Wunused-but-set-variable] drivers/scsi/3w-9xxx.c: In function ‘twa_scsi_biosparam’: drivers/scsi/3w-9xxx.c:1701:23: warning: variable ‘tw_dev’ set but not used [-Wunused-but-set-variable] drivers/scsi/3w-9xxx.c: In function ‘twa_scsiop_execute_scsi’: drivers/scsi/3w-9xxx.c:1812:22: warning: variable ‘sglist’ set but not used [-Wunused-but-set-variable] Cc: Adam Radford Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/3w-9xxx.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/3w-9xxx.c b/drivers/scsi/3w-9xxx.c index b96e82de4237d..47028f5e57abd 100644 --- a/drivers/scsi/3w-9xxx.c +++ b/drivers/scsi/3w-9xxx.c @@ -939,13 +939,13 @@ static int twa_decode_bits(TW_Device_Extension *tw_dev, u32 status_reg_value) /* This function will empty the response queue */ static int twa_empty_response_queue(TW_Device_Extension *tw_dev) { - u32 status_reg_value, response_que_value; + u32 status_reg_value; int count = 0, retval = 1; status_reg_value = readl(TW_STATUS_REG_ADDR(tw_dev)); while (((status_reg_value & TW_STATUS_RESPONSE_QUEUE_EMPTY) == 0) && (count < TW_MAX_RESPONSE_DRAIN)) { - response_que_value = readl(TW_RESPONSE_QUEUE_REG_ADDR(tw_dev)); + readl(TW_RESPONSE_QUEUE_REG_ADDR(tw_dev)); status_reg_value = readl(TW_STATUS_REG_ADDR(tw_dev)); count++; } @@ -1698,9 +1698,6 @@ static int twa_reset_sequence(TW_Device_Extension *tw_dev, int soft_reset) static int twa_scsi_biosparam(struct scsi_device *sdev, struct block_device *bdev, sector_t capacity, int geom[]) { int heads, sectors, cylinders; - TW_Device_Extension *tw_dev; - - tw_dev = (TW_Device_Extension *)sdev->host->hostdata; if (capacity >= 0x200000) { heads = 255; @@ -1809,14 +1806,11 @@ static int twa_scsiop_execute_scsi(TW_Device_Extension *tw_dev, int request_id, u32 num_sectors = 0x0; int i, sg_count; struct scsi_cmnd *srb = NULL; - struct scatterlist *sglist = NULL, *sg; + struct scatterlist *sg; int retval = 1; - if (tw_dev->srb[request_id]) { + if (tw_dev->srb[request_id]) srb = tw_dev->srb[request_id]; - if (scsi_sglist(srb)) - sglist = scsi_sglist(srb); - } /* Initialize command packet */ full_command_packet = tw_dev->command_packet_virt[request_id]; From patchwork Wed Mar 17 08:56:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12145135 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AC9DC43331 for ; Wed, 17 Mar 2021 08:58:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1452164F6A for ; Wed, 17 Mar 2021 08:58:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229880AbhCQI5y (ORCPT ); Wed, 17 Mar 2021 04:57:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbhCQI5T (ORCPT ); Wed, 17 Mar 2021 04:57:19 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B545CC06174A for ; Wed, 17 Mar 2021 01:57:18 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id f22-20020a7bc8d60000b029010c024a1407so2928929wml.2 for ; Wed, 17 Mar 2021 01:57:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lgdjb93mQlErKIT9nxRZ2QkPnfSG57zjDQqjLAihewI=; b=MwCP4itucxztl9l8FkEqeHILNX3nzDKtzAzs/tgBHBSDafSTLboWBRYxz76cEG3V8x 2xPAdCZJokzSSlLfv+qzwK97CvIP36SaiFEwnjBxG2YqcnPTFOG6Y8yGU/sc93iJTImW Sf5oXGbJujAphZM9Z0eQHUk+a2N9aMmyEM0TD+JA736pUUbP4J1B/a6m2ATgyhF3av6r 9PegckNneVMjHCE/+3dm96hlEVMIKRRWWqENGlNOfKX0L4FDpm7LBalWvzUiccsqDZMU HhC7Z4Xa2Vj8iKt1skT9IvgA7GqwKfwWY1Dw/Gju/4U+Isx7ARnIEOgV0eQfxeHAvSaN lflg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lgdjb93mQlErKIT9nxRZ2QkPnfSG57zjDQqjLAihewI=; b=FYeQJ/+OWQavxxxRTrMdW4HbXk1jBIxoXsY6modd5QJNKYGCJJejA8k/7xgBE2hj29 OPfxHenrF7NK6mnodMn+Rb6XdYrnpqrFkI+iDxxFK9DI0SfDRAf/nTCIDCihHRvb46Hh jZ+KHZD+q1tzUdAHwWKmyuECLB1ea6azw+adhX9qJDlz6NE2WH/EQJVgTJO5Gy/Hejes MmlnpSf1icTB7TGjYlvSKO21YAESqal7oYoDCuWwqSKHRrYjN7d+R27aVK6/pZis1TgR 1WmmwWDKCLgDdLCVQsSlwvTBlULP99caorbkpAXag9kN/eKW13Th3pJiwulS03uONvOL gHFg== X-Gm-Message-State: AOAM532I7r6ZleNlvIIRrHoK1iIn1Nx2cPuLoYUVQnAf7tyqGkCMARNy DAZVmHL2wcETLBWfmEhPmUPeLw== X-Google-Smtp-Source: ABdhPJxll19rFgByW4rcQdYz1/5AVych4qQyQK4k9X/sQF6vr/f0gl2tfL8uDge4nac7kZTlwFpC3w== X-Received: by 2002:a05:600c:4ed1:: with SMTP id g17mr2645321wmq.67.1615971437511; Wed, 17 Mar 2021 01:57:17 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j123sm1807243wmb.1.2021.03.17.01.57.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 01:57:17 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Adam Radford , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 12/18] scsi: 3w-sas: Remove unused variables 'sglist' and 'tw_dev' Date: Wed, 17 Mar 2021 08:56:55 +0000 Message-Id: <20210317085701.2891231-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317085701.2891231-1-lee.jones@linaro.org> References: <20210317085701.2891231-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/3w-sas.c: In function ‘twl_scsiop_execute_scsi’: drivers/scsi/3w-sas.c:298:22: warning: variable ‘sglist’ set but not used [-Wunused-but-set-variable] drivers/scsi/3w-sas.c: In function ‘twl_scsi_biosparam’: drivers/scsi/3w-sas.c:1411:23: warning: variable ‘tw_dev’ set but not used [-Wunused-but-set-variable] Cc: Adam Radford Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/3w-sas.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/3w-sas.c b/drivers/scsi/3w-sas.c index 3db0e42e9aa75..383f6f204c24b 100644 --- a/drivers/scsi/3w-sas.c +++ b/drivers/scsi/3w-sas.c @@ -295,14 +295,11 @@ static int twl_scsiop_execute_scsi(TW_Device_Extension *tw_dev, int request_id, TW_Command_Apache *command_packet; int i, sg_count; struct scsi_cmnd *srb = NULL; - struct scatterlist *sglist = NULL, *sg; + struct scatterlist *sg; int retval = 1; - if (tw_dev->srb[request_id]) { + if (tw_dev->srb[request_id]) srb = tw_dev->srb[request_id]; - if (scsi_sglist(srb)) - sglist = scsi_sglist(srb); - } /* Initialize command packet */ full_command_packet = tw_dev->command_packet_virt[request_id]; @@ -1408,9 +1405,6 @@ static int twl_reset_device_extension(TW_Device_Extension *tw_dev, int ioctl_res static int twl_scsi_biosparam(struct scsi_device *sdev, struct block_device *bdev, sector_t capacity, int geom[]) { int heads, sectors; - TW_Device_Extension *tw_dev; - - tw_dev = (TW_Device_Extension *)sdev->host->hostdata; if (capacity >= 0x200000) { heads = 255; From patchwork Wed Mar 17 08:56:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12145139 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8215EC4332E for ; Wed, 17 Mar 2021 08:58:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A8BB64F7E for ; Wed, 17 Mar 2021 08:58:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229887AbhCQI5z (ORCPT ); Wed, 17 Mar 2021 04:57:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229712AbhCQI5U (ORCPT ); Wed, 17 Mar 2021 04:57:20 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB733C06174A for ; Wed, 17 Mar 2021 01:57:19 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id r15-20020a05600c35cfb029010e639ca09eso2925331wmq.1 for ; Wed, 17 Mar 2021 01:57:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Yq9LdtQSeW2MqRbyRwlDutR9JIDqTpE5NVbsv5LbNbg=; b=QTvzJqmGP9un37sPXvqhxwB1ZGU6Gv6UdUsHx+n59vzvMquKJQ2tfGP+jU7SrhDOBM my1FrkaTRKW0odxPHVtxgpvHaQTBiKTB/6cQyKinYknDEJEBThNjq++jJ96kFt35M9Cb jlYWeiKqNFKYpfkYnd/A2uCi8K/3TOxPCQpoo8q0Mu61K5JOfWesU13Bqa6HnPcoY7TK ji09IcmhD4EsXeY5NuVOn5QNTaoXawO91VkDR4tbRdpj0SGLEc+KVX4FNsyDlkj+32G6 +a+mIGKDR8YxL291V+0IGF8OTU/BMz7TGJGqcKdm0bnWhEotjGAU5xXcxA7vHdoALoWn Ts5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Yq9LdtQSeW2MqRbyRwlDutR9JIDqTpE5NVbsv5LbNbg=; b=YU6Gz5IgqfW5JsCpt/5ntrwS2NLd/SKGJbHa9eP4dKAG1H+KdvkJW8jFv+YLqPcjqN 79CIkr1F/XJcE0LTThSuKvE5tttx9N8AktP2Qx6I3GLeJexuDWFw3aPfm5eAGiclq/79 3J1XpoxcNmfx/qOkLrT6mEG7tKD+c18nM8OBSQ+kaSrp4iivp+2/rv+qrx/AGLAwsfAT cpwEDdYVq7gIUt1wF/ajcYGGdxt2bpkeLRj23RzNfRmVcFFsSMWLFTbker1uRlpUoWVY Bd+vPgK6KGDBfI/0IZUBxOM/NFD8NBiTm71UbOFy38zOEJv6axciE6bE5sjzfVo82eyJ DM5A== X-Gm-Message-State: AOAM530IRSGDL9TJx1/8ny2Xx3FDosAmET8odxcRvrJBfz9YGHB29JYG abVFbo+JR3JvKW5O6UqQd8gqBQ== X-Google-Smtp-Source: ABdhPJzg8eQxLZE3wpQ/sNOp9p0knU6tUDLEqP9qnzFhu7vqg7pKyp84jaeSsUGEV0QiBg6UN5arew== X-Received: by 2002:a7b:c1c9:: with SMTP id a9mr2543431wmj.145.1615971438410; Wed, 17 Mar 2021 01:57:18 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j123sm1807243wmb.1.2021.03.17.01.57.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 01:57:18 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, GOTO Masanori , YOKOTA Hiroshi , "James E.J. Bottomley" , "Martin K. Petersen" , gotom@debian.org, linux-scsi@vger.kernel.org Subject: [PATCH 13/18] scsi: nsp32: Remove or exclude unused variables Date: Wed, 17 Mar 2021 08:56:56 +0000 Message-Id: <20210317085701.2891231-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317085701.2891231-1-lee.jones@linaro.org> References: <20210317085701.2891231-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/nsp32.c: In function ‘nsp32_selection_autoscsi’: drivers/scsi/nsp32.c:584:17: warning: variable ‘execph’ set but not used [-Wunused-but-set-variable] drivers/scsi/nsp32.c: In function ‘nsp32_msgout_occur’: drivers/scsi/nsp32.c:1785:7: warning: variable ‘new_sgtp’ set but not used [-Wunused-but-set-variable] drivers/scsi/nsp32.c: In function ‘nsp32_analyze_sdtr’: drivers/scsi/nsp32.c:2227:20: warning: variable ‘syncnum’ set but not used [-Wunused-but-set-variable] drivers/scsi/nsp32.c:2223:20: warning: variable ‘synct’ set but not used [-Wunused-but-set-variable] drivers/scsi/nsp32.c: In function ‘nsp32_do_bus_reset’: drivers/scsi/nsp32.c:2841:17: warning: variable ‘intrdat’ set but not used [-Wunused-but-set-variable] drivers/scsi/nsp32.c: In function ‘nsp32_getprom_param’: drivers/scsi/nsp32.c:2912:11: warning: variable ‘val’ set but not used [-Wunused-but-set-variable] Cc: GOTO Masanori Cc: YOKOTA Hiroshi Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: gotom@debian.org Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/nsp32.c | 23 ++++------------------- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c index d5aa96f05bce4..54abda4d07c64 100644 --- a/drivers/scsi/nsp32.c +++ b/drivers/scsi/nsp32.c @@ -581,7 +581,6 @@ static int nsp32_selection_autoscsi(struct scsi_cmnd *SCpnt) int status; unsigned short command = 0; unsigned int msgout = 0; - unsigned short execph; int i; nsp32_dbg(NSP32_DEBUG_AUTOSCSI, "in"); @@ -605,7 +604,7 @@ static int nsp32_selection_autoscsi(struct scsi_cmnd *SCpnt) /* * clear execph */ - execph = nsp32_read2(base, SCSI_EXECUTE_PHASE); + nsp32_read2(base, SCSI_EXECUTE_PHASE); /* * clear FIFO counter to set CDBs @@ -1781,8 +1780,6 @@ static void nsp32_msgout_occur(struct scsi_cmnd *SCpnt) { nsp32_hw_data *data = (nsp32_hw_data *)SCpnt->device->host->hostdata; unsigned int base = SCpnt->device->host->io_port; - //unsigned short command; - long new_sgtp; int i; nsp32_dbg(NSP32_DEBUG_MSGOUTOCCUR, @@ -1796,14 +1793,6 @@ static void nsp32_msgout_occur(struct scsi_cmnd *SCpnt) nsp32_build_nop(SCpnt); } - /* - * Set SGTP ADDR current entry for restarting AUTOSCSI, - * because SGTP is incremented next point. - * There is few statement in the specification... - */ - new_sgtp = data->cur_lunt->sglun_paddr + - (data->cur_lunt->cur_entry * sizeof(nsp32_sgtable)); - /* * send messages */ @@ -2220,17 +2209,12 @@ static void nsp32_analyze_sdtr(struct scsi_cmnd *SCpnt) { nsp32_hw_data *data = (nsp32_hw_data *)SCpnt->device->host->hostdata; nsp32_target *target = data->cur_target; - nsp32_sync_table *synct; unsigned char get_period = data->msginbuf[3]; unsigned char get_offset = data->msginbuf[4]; int entry; - int syncnum; nsp32_dbg(NSP32_DEBUG_MSGINOCCUR, "enter"); - synct = data->synct; - syncnum = data->syncnum; - /* * If this inititor sent the SDTR message, then target responds SDTR, * initiator SYNCREG, ACKWIDTH from SDTR parameter. @@ -2838,8 +2822,8 @@ static int nsp32_eh_abort(struct scsi_cmnd *SCpnt) static void nsp32_do_bus_reset(nsp32_hw_data *data) { unsigned int base = data->BaseAddress; - unsigned short intrdat; int i; + unsigned short __maybe_unused intrdat; nsp32_dbg(NSP32_DEBUG_BUSRESET, "in"); @@ -2909,7 +2893,8 @@ static int nsp32_getprom_param(nsp32_hw_data *data) { int vendor = data->pci_devid->vendor; int device = data->pci_devid->device; - int ret, val, i; + int ret, i; + int __maybe_unused val; /* * EEPROM checking. From patchwork Wed Mar 17 08:56:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12145143 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4726C43603 for ; Wed, 17 Mar 2021 08:58:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA9B964E33 for ; Wed, 17 Mar 2021 08:58:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229921AbhCQI56 (ORCPT ); Wed, 17 Mar 2021 04:57:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229735AbhCQI5V (ORCPT ); Wed, 17 Mar 2021 04:57:21 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B86CC06174A for ; Wed, 17 Mar 2021 01:57:20 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id x16so960535wrn.4 for ; Wed, 17 Mar 2021 01:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RHS0YjWdwFJSN1VWVbYNsptYDs5Fwc3UmjtJJxuBnoI=; b=bd2kG5EPTmQJeA6t8WaOQnFRXKkDR3BMi8kDcQikR5twG4YRU3gLdOjJDKAoej7ZGL wZwGwuS6cWBS81PFhdOHVoQ7Oljwl88rHPcre4OcRLOHZwlSXHmEUJ4hSTxFOiRoBwjB QpqGk74mim16Za7N+MVQrY5SBbtJNkB28Z3/FJtEXQyY/W0FV69s/uSl74HmJxzVYUg0 NMJVuqubf2JLrHVLNaC4rW7xWh1JoWKbWJYCcTyp66H2SJpwWlqXWcvZT8Y+5Bg+9kCC efO2hQ6/rbEVfQGOW05A7XwV0Qazx5BbzjQpUtvzKfQHsdIk2BkWl9XvvlqP3FZzv7yR b1mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RHS0YjWdwFJSN1VWVbYNsptYDs5Fwc3UmjtJJxuBnoI=; b=kms5ZISL0mnU0X1RBG2on3dy/x2K7DQcnfm7Lb4ckJzkpKvqOCIfkaQSAg/drSVfPp D2zLVJR+aAoHyBFk5t+SDxmkF9AWhar5FEC0LJWQIHqezBvOPqBB0vwg/SasuaDHwsWQ 7vgFuYAqYWbIGVQRrBVTwQ+1WRDGeo6oaFJQgTl3V/LSbOOFzSHHoOHQxjaIWRDssYhL WVGxQk4gq6LmyOvUI6zGzc8ime2QiuIQcdGMleWnYEAtU+ek0yczMGg6xGFYlMaoYfCP agGNFZEaxeyj3BPfvaL6FpET0QlHy4H4D/KpSJIBs62TgAAow62LUj8qUgun5qfDrPy0 eK6A== X-Gm-Message-State: AOAM533kPiF650nXcGyzToQrkl+fYK3t8D09IOosBNxL2qGHRu+F54QP 0dFhHgLg7QlraEPTv0uB2pLrCA== X-Google-Smtp-Source: ABdhPJw7IDG/Hu+h6a5Wu25E5StVwC8pvUyd1nxG8QhvDpv4nG2qOmqcsEVTeYDANh7nkWJteGYFsQ== X-Received: by 2002:adf:ea47:: with SMTP id j7mr3121325wrn.377.1615971439380; Wed, 17 Mar 2021 01:57:19 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j123sm1807243wmb.1.2021.03.17.01.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 01:57:18 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Khalid Aziz , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 14/18] scsi: FlashPoint: Remove unused variable 'TID' from 'FlashPoint_AbortCCB()' Date: Wed, 17 Mar 2021 08:56:57 +0000 Message-Id: <20210317085701.2891231-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317085701.2891231-1-lee.jones@linaro.org> References: <20210317085701.2891231-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/FlashPoint.c: In function ‘FlashPoint_AbortCCB’: drivers/scsi/FlashPoint.c:1618:16: warning: variable ‘TID’ set but not used [-Wunused-but-set-variable] Cc: Khalid Aziz Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/FlashPoint.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c index f479c542e787c..0464e37c806a4 100644 --- a/drivers/scsi/FlashPoint.c +++ b/drivers/scsi/FlashPoint.c @@ -1615,7 +1615,6 @@ static int FlashPoint_AbortCCB(void *pCurrCard, struct sccb *p_Sccb) unsigned char thisCard; CALL_BK_FN callback; - unsigned char TID; struct sccb *pSaveSCCB; struct sccb_mgr_tar_info *currTar_Info; @@ -1652,9 +1651,6 @@ static int FlashPoint_AbortCCB(void *pCurrCard, struct sccb *p_Sccb) } else { - - TID = p_Sccb->TargID; - if (p_Sccb->Sccb_tag) { MDISABLE_INT(ioport); if (((struct sccb_card *)pCurrCard)-> From patchwork Wed Mar 17 08:56:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12145137 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A80DC43333 for ; Wed, 17 Mar 2021 08:58:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 58E2A64F9E for ; Wed, 17 Mar 2021 08:58:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229896AbhCQI54 (ORCPT ); Wed, 17 Mar 2021 04:57:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229748AbhCQI5W (ORCPT ); Wed, 17 Mar 2021 04:57:22 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87C63C0613D9 for ; Wed, 17 Mar 2021 01:57:21 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id e9so946906wrw.10 for ; Wed, 17 Mar 2021 01:57:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uknjZgyKbyTHbovaIRwNwS9vIyXMZbr0zBj7lwglxO0=; b=jyM5AtVqD1gbwSyCgL+XC69BhPp58i7rui/GQduzTndKglMY0QDRJiMINMn9pqzRI9 FacVRjketCFrOI9jkEpRwxco361TWUUJqNwJcZubfxro7ILh1mYgKldo0fvHDRPub1Z4 MMdFipRIYAGSSeixDl1jFrYrvXr90kreByWKhCz6T8h6lrvRmu3BF129zP/QUEMXWWC8 XM7pQWLyopi7Q5zrQaXQULTS9EBinMxlMAT9M1aimg8J7N0/GB33WAIK98KjRQIK7nIy mvv2pBjDOiculG/h4lyTapmXYGS2ihH5AbBRQzJsXfo2OZnD/1/AJmEGFhsbwmqzfUmv k82Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uknjZgyKbyTHbovaIRwNwS9vIyXMZbr0zBj7lwglxO0=; b=d8uTTOCjM6MBI0YJi2t/yy+DwcR3g0CqyDLzfVzVMrUIdcbZF8Vp7ovPntEkgkFCRp xgqPzZm26/nQZnM65H5xWfIH/J/u5sWfMZBuZcVdLiaesRpm0ZXdR5FcxRiY4o7HisqJ 814gz3xZML+BO6Ij2Oa0fHCxKuiu8nEjMOCSIbrT/yBBrL2/yJVaYJZn8XMEKdL8pzAc 5T2mnRkATC8DQjjwE0FdgrUE6g2ZxCq8+fg8C3N8T3wQGrOuj6/68g+FRTjiwOvENlLX qqc14vXrxwLa7NKEPc6d0Tfm7kPNX5HX86zK8mtAxdzAr9+zaDLe71nxd5w9qD5XvQmQ vpaw== X-Gm-Message-State: AOAM531Glier5Wgxh+L6jMpwF4+wabzBU6VLqDh5NYTi725scQg64K+2 hSdUhcXe2G28y69Y042jQXG9Tg== X-Google-Smtp-Source: ABdhPJx+GlNNh0KH6vMpIl5u5vhs56iee2KFJdoue8jlx2OnR2y+cQgqHzC+YWhg2AlgZ3S8cr5uPg== X-Received: by 2002:adf:e441:: with SMTP id t1mr3251524wrm.21.1615971440343; Wed, 17 Mar 2021 01:57:20 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j123sm1807243wmb.1.2021.03.17.01.57.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 01:57:19 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , Richard Hirst , c by , linux-scsi@vger.kernel.org Subject: [PATCH 15/18] scsi: sim710: Remove unused variable 'err' from sim710_init() Date: Wed, 17 Mar 2021 08:56:58 +0000 Message-Id: <20210317085701.2891231-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317085701.2891231-1-lee.jones@linaro.org> References: <20210317085701.2891231-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Take the opportunity to rework the comment a little. Fixes the following W=1 kernel build warning(s): drivers/scsi/sim710.c: In function ‘sim710_init’: drivers/scsi/sim710.c:216:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable] Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Richard Hirst Cc: c by Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/sim710.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/sim710.c b/drivers/scsi/sim710.c index 22302612e032b..e519df68d603d 100644 --- a/drivers/scsi/sim710.c +++ b/drivers/scsi/sim710.c @@ -213,21 +213,19 @@ static struct eisa_driver sim710_eisa_driver = { static int __init sim710_init(void) { - int err = -ENODEV; - #ifdef MODULE if (sim710) param_setup(sim710); #endif #ifdef CONFIG_EISA - err = eisa_driver_register(&sim710_eisa_driver); + /* + * FIXME: We'd really like to return -ENODEV if no devices have actually + * been found. However eisa_driver_register() only reports problems + * with kobject_register() so simply return success for now. + */ + eisa_driver_register(&sim710_eisa_driver); #endif - /* FIXME: what we'd really like to return here is -ENODEV if - * no devices have actually been found. Instead, the err - * above actually only reports problems with kobject_register, - * so for the moment return success */ - return 0; } From patchwork Wed Mar 17 08:56:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12145141 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FE43C4360C for ; Wed, 17 Mar 2021 08:58:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03FD264F72 for ; Wed, 17 Mar 2021 08:58:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229931AbhCQI6B (ORCPT ); Wed, 17 Mar 2021 04:58:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229683AbhCQI5W (ORCPT ); Wed, 17 Mar 2021 04:57:22 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62E98C06174A for ; Wed, 17 Mar 2021 01:57:22 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id b9so950165wrt.8 for ; Wed, 17 Mar 2021 01:57:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tIEkLMKAtbUUByHxgsDytjqimEjUNe0j+Mn0l5iX50M=; b=a+DMI4iVTnhLsQaNH5HsLRD0p4jmOwH4c+OdsIB5mhlSZImVjQj67NzOFVCvxEZiEz qf3nxfzbCn1cPpyn2nBZt1S/puwJcu3eV83BgIHeszYCACXSaS9Xm/rCAUSS3wbVSTee ggp2QrfifWznoxjMwD8BRF6HCnYJUvIJmT3GGE8GCwgFXhkpD657Iqe0qoqmXx0dFnpv X9pBn5+2cc8mMirWmY0lRKr7DehTGXhNAVJfcDLknUxKRYg/vJZkIhtqLKfgKxOmGOcs lKOa9zBBQMjwcDgfz4yQMmpgoKoHMjJJVmV3Whx0vt/OPJACLEY8ZMF0eqhq1s9fXr6L Z0hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tIEkLMKAtbUUByHxgsDytjqimEjUNe0j+Mn0l5iX50M=; b=ZvQjVnxBoJOcbzblUw3zE0BEXAD6SzzScwQYdVma2ncNsO9/zxoaXdX4tTMufKOarz l/AM4M4sYHYAVHMmtZxmiXs9jyqDmbh6+8IqjrxpXSJ0W3whgySUxIsZlUsOn2QR3lGX LUrMOdgvobYULhXmUtSWVJz6ST43fWSK42cPrH+tLPTkqK73+gPER73AiKoH95Re4j+F VooqA+y0Dx0EGcmvypjkTMyalqYI7h2Hgm8VLkmXTsI6xcIOax4I4F7QV4ukbf+x9rQx zUdRuSDS/tem0ZjZTeMJAs90AasCDS387khR/lCdn4bJsBexMdF4QlOb2KD5e2cSTBKT XSdA== X-Gm-Message-State: AOAM532SXYyuL7rOmEAc33A4jgq8V29xgCKmPXfXnw6ux2fDFq2OuL8v yHEYTSnLNO11Ecq9XjyGRZ7pSA== X-Google-Smtp-Source: ABdhPJzu9vdM0OUd6qmkmrhg8ngUL9mmunRKcl7uLbkfhxy5NL5s2Jl0Y/e3r3KTbRZAar9WWWzy/Q== X-Received: by 2002:adf:f4ce:: with SMTP id h14mr3204003wrp.257.1615971441165; Wed, 17 Mar 2021 01:57:21 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j123sm1807243wmb.1.2021.03.17.01.57.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 01:57:20 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Artur Paszkiewicz , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 16/18] scsi: isci: port: Make local function 'port_state_name()' static Date: Wed, 17 Mar 2021 08:56:59 +0000 Message-Id: <20210317085701.2891231-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317085701.2891231-1-lee.jones@linaro.org> References: <20210317085701.2891231-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/isci/port.c:65:13: warning: no previous prototype for ‘port_state_name’ [-Wmissing-prototypes] Cc: Artur Paszkiewicz Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/isci/port.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/isci/port.c b/drivers/scsi/isci/port.c index 448a8c31ba359..5a362ba76d63f 100644 --- a/drivers/scsi/isci/port.c +++ b/drivers/scsi/isci/port.c @@ -62,7 +62,7 @@ #undef C #define C(a) (#a) -const char *port_state_name(enum sci_port_states state) +static const char *port_state_name(enum sci_port_states state) { static const char * const strings[] = PORT_STATES; From patchwork Wed Mar 17 08:57:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12145145 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CD69C433DB for ; Wed, 17 Mar 2021 08:58:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69FB264E33 for ; Wed, 17 Mar 2021 08:58:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229943AbhCQI6C (ORCPT ); Wed, 17 Mar 2021 04:58:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229767AbhCQI5Y (ORCPT ); Wed, 17 Mar 2021 04:57:24 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B6C0C06175F for ; Wed, 17 Mar 2021 01:57:23 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id g25so1022079wmh.0 for ; Wed, 17 Mar 2021 01:57:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=omHoCGEAHHfzGsCXWaSPZZFL53Kydw/eMLAhlkpH1KI=; b=G22gc9eNVnSkGmoUYNFy4wacYM1Maa4UM98OSYfR32gD/HkmzQQWbgY4P4UFvjX9q5 1/K4tKYkgq+Tyz3T4Y8Mgze3tuG2JcwIvk9CWMjQuhvsY23GVjfNmJ0aem8lw+qe5UN7 FPVmfjzgOicF0uFBQf6QL3Vj1K77BtaL/xksuNliBeu5VB6q6r30sr+Bkh6BrsKtV71N UnXMXD6kbvh09KJOuR8zcUy4hvQu11++xqFYTYuhf4q1E4zbXFNqkxjwgVsmqzqHBz4Y BDz3TZqJ4293Xc0y6RflScVaLt9bBm9iP0S+qSk34h7Cz46M4A8WS6I3GSOT+Wlls5BQ vKXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=omHoCGEAHHfzGsCXWaSPZZFL53Kydw/eMLAhlkpH1KI=; b=OwDoZC7Ik5gmkOsQR0ByqYvKzWK1wupgi1utDfve1vXI5NvblIqevgone9dO410x7o NrOGPgjzIhklqdWdQde4bMzag744iVYuM/zRhhFScXOeki4zxS6lgwXEQ4v8AawbRHBx JgfcFTsCfTzv4IGQXH0p5OsgN10IIO7WyihZOLwMH8xWrNFmj5KqRZLq4s3J6m2RaXjw O4Sk1PST08OSpdp2H7Ik4j7pVq5/03MbXmYkYR1gSPNJ3+zuugc5W+/AhJDcb0K4jVk/ bDWblCGzoFnMUdb8X9gpxzGp3uJJVaJDaWh76IaUHrBrx/hrvYnQ4MoYqHChR8JwNvA/ ms8w== X-Gm-Message-State: AOAM530QrUtODP1lcToxzXv+W/9SeWb4SKXGKRL1t1NFQyoPgmUY4kp9 /2ab2x6tEmO0YgFsr6rY5H5J8g== X-Google-Smtp-Source: ABdhPJw8Ddp7YdzjeheW5smSSk4SsocDHz5sUQEXKz8atEvBpoI8V+wWuKLJ2mg9P8iILIz+DV1vuA== X-Received: by 2002:a1c:3c8a:: with SMTP id j132mr683090wma.127.1615971442290; Wed, 17 Mar 2021 01:57:22 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j123sm1807243wmb.1.2021.03.17.01.57.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 01:57:21 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Artur Paszkiewicz , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 17/18] scsi: isci: remote_device: Make local function isci_remote_device_wait_for_resume_from_abort() static Date: Wed, 17 Mar 2021 08:57:00 +0000 Message-Id: <20210317085701.2891231-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317085701.2891231-1-lee.jones@linaro.org> References: <20210317085701.2891231-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/isci/remote_device.c:1387:6: warning: no previous prototype for ‘isci_remote_device_wait_for_resume_from_abort’ [-Wmissing-prototypes] Cc: Artur Paszkiewicz Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/isci/remote_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/isci/remote_device.c b/drivers/scsi/isci/remote_device.c index c3f540b556895..b1276f7e49c89 100644 --- a/drivers/scsi/isci/remote_device.c +++ b/drivers/scsi/isci/remote_device.c @@ -1384,7 +1384,7 @@ static bool isci_remote_device_test_resume_done( return done; } -void isci_remote_device_wait_for_resume_from_abort( +static void isci_remote_device_wait_for_resume_from_abort( struct isci_host *ihost, struct isci_remote_device *idev) { From patchwork Wed Mar 17 08:57:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12145147 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D0A7C43142 for ; Wed, 17 Mar 2021 08:58:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B0B064F44 for ; Wed, 17 Mar 2021 08:58:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229739AbhCQI6D (ORCPT ); Wed, 17 Mar 2021 04:58:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229675AbhCQI5f (ORCPT ); Wed, 17 Mar 2021 04:57:35 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E759C061764 for ; Wed, 17 Mar 2021 01:57:24 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id m20-20020a7bcb940000b029010cab7e5a9fso2908706wmi.3 for ; Wed, 17 Mar 2021 01:57:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PdNAYGEf3HErZd1qMy9Fio2Q6mTHXUXt55dWtvm2uqs=; b=WEpXnUaFpXspOAzsNexbf8blhw8/xw01ijWzUfXpFPr7UPTnwZ6OxFfKC04ZgjXK0/ MUaN2LCKoMFfpwP4Pfbx4wfJ5GMJ/hMWrLGt58SC6PwP7AdaCAvSjTZ3uSSw/3vn62AH VkewkDjIA6IDYcpbqPVvwXCx8X7UNNA0176HAELpDaVeqQ5ShWuTlCvYrhtiqUpmpzPX G+VLGzB6+0rTEKKoNbzUJcdtTsQRjpHbDVceFc4foOfgV8ndulOn0n+ICOjSW/Y31a9K 9nMWfaa42Ckz4URi2hFdwcxK4k/bEo+vNfM20iwQpGiNxfD3UWFZRjZt+5uIUOObWjgZ tYHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PdNAYGEf3HErZd1qMy9Fio2Q6mTHXUXt55dWtvm2uqs=; b=Iei9zE5mRE/9kGp0e7e3631bbzwdg+0/4QJyNw+inE9Z0YBaS7BMA96j+4TCPIdeYg Ty2VK0eMwPlFLt9XFTHZOr5hfT5z7WYQCT1sFpELrxSGxyYD76QGrMSmiks4d3n0Cysb gvv4DND/Qa0f9ChmWoOv6T4pAJuuJzavtDNwZKFnM1/VdufdLjjiXI62BYXsns2UpKe5 IN7jVfv89DIOO+OjuRIMCfxH4VMZkWhi16Cnxnkfz2uW3nUSCcwP/5enjoMYXGOJoIjR 1H+SWqV3GK3l8UM5FDXf3z/QkUfDo/BiK+Ilv0zRKFJjCZOUpQN5NUR88eEa9/Hg5aPq qpXw== X-Gm-Message-State: AOAM532tcIRau6PkEm1cEfxhSKWXh1Bxy+YY2FJx4mtVLkQWUQ+mm/da VH7fEh7lMcLXUTWGVVNUD4HTIQ== X-Google-Smtp-Source: ABdhPJxllcQNzhNpec6x4Nun9qbZbU27gKPs+/PsHAY9MXuJFcbPBC54Y73ZQVMASMTBdoT731fy4g== X-Received: by 2002:a1c:7406:: with SMTP id p6mr2600517wmc.103.1615971443185; Wed, 17 Mar 2021 01:57:23 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j123sm1807243wmb.1.2021.03.17.01.57.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 01:57:22 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, GOTO Masanori , YOKOTA Hiroshi , "James E.J. Bottomley" , "Martin K. Petersen" , gotom@debian.org, linux-scsi@vger.kernel.org Subject: [PATCH 18/18] scsi: nsp32: Correct expected types in debug print formatting Date: Wed, 17 Mar 2021 08:57:01 +0000 Message-Id: <20210317085701.2891231-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210317085701.2891231-1-lee.jones@linaro.org> References: <20210317085701.2891231-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/scsi/nsp32.c: In function ‘nsp32_setup_sg_table’: drivers/scsi/nsp32.c:879:6: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘unsigned int’ [-Wformat=] drivers/scsi/nsp32.c:280:69: note: in definition of macro ‘nsp32_msg’ drivers/scsi/nsp32.c:879:52: note: format string is defined here drivers/scsi/nsp32.c: In function ‘nsp32_detect’: drivers/scsi/nsp32.c:2719:6: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘int’ [-Wformat=] drivers/scsi/nsp32.c:280:69: note: in definition of macro ‘nsp32_msg’ drivers/scsi/nsp32.c:2719:22: note: format string is defined here drivers/scsi/nsp32.c:2719:6: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 6 has type ‘int’ [-Wformat=] drivers/scsi/nsp32.c:280:69: note: in definition of macro ‘nsp32_msg’ drivers/scsi/nsp32.c:2719:28: note: format string is defined here drivers/scsi/nsp32.c: In function ‘nsp32_suspend’: drivers/scsi/nsp32.c:3267:23: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘pm_message_t’ {aka ‘struct pm_message’} [-Wformat=] drivers/scsi/nsp32.c:280:69: note: in definition of macro ‘nsp32_msg’ drivers/scsi/nsp32.c:3267:56: note: format string is defined here Cc: GOTO Masanori Cc: YOKOTA Hiroshi Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: gotom@debian.org Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/nsp32.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c index 54abda4d07c64..134bbd2d8b667 100644 --- a/drivers/scsi/nsp32.c +++ b/drivers/scsi/nsp32.c @@ -876,7 +876,7 @@ static int nsp32_setup_sg_table(struct scsi_cmnd *SCpnt) if (le32_to_cpu(sgt[i].len) > 0x10000) { nsp32_msg(KERN_ERR, - "can't transfer over 64KB at a time, size=0x%lx", le32_to_cpu(sgt[i].len)); + "can't transfer over 64KB at a time, size=0x%x", le32_to_cpu(sgt[i].len)); return FALSE; } nsp32_dbg(NSP32_DEBUG_SGLIST, @@ -2716,7 +2716,7 @@ static int nsp32_detect(struct pci_dev *pdev) res = request_region(host->io_port, host->n_io_port, "nsp32"); if (res == NULL) { nsp32_msg(KERN_ERR, - "I/O region 0x%lx+0x%lx is already used", + "I/O region 0x%x+0x%x is already used", data->BaseAddress, data->NumAddress); goto free_irq; } @@ -3264,7 +3264,8 @@ static int nsp32_suspend(struct pci_dev *pdev, pm_message_t state) { struct Scsi_Host *host = pci_get_drvdata(pdev); - nsp32_msg(KERN_INFO, "pci-suspend: pdev=0x%p, state=%ld, slot=%s, host=0x%p", pdev, state, pci_name(pdev), host); + nsp32_msg(KERN_INFO, "pci-suspend: pdev=0x%p, state.event=%x, slot=%s, host=0x%p", + pdev, state.event, pci_name(pdev), host); pci_save_state (pdev); pci_disable_device (pdev);