From patchwork Wed Mar 24 02:04:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 12160053 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47642C433DB for ; Wed, 24 Mar 2021 02:06:50 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA203619FB for ; Wed, 24 Mar 2021 02:06:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA203619FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=c0IA0NTTdFkuOCc6lnhsE7Z2lWNYeiNwTy8bGRheWX4=; b=ApvtKEb0LZ7meBVoEwIgsF/6E ZF/JIh1YrB0u0p8hUZw0ArtHZjiKiOWkDFFnZxtbKHg/LnEkFFxGPOcqzoBIXIYUMsa6Z0uMgbpwE CXtRjdWhWSMp/Z8ZYtMH7+fGZoX+SDFLBqojGN5Xk2TpsILJYECE7Ya85JXA635nJFRXFmx/GQkgN cEEhoLO3zNjbTIdIJvHld5SZIDINTfh6S1dgDJjRjk9bjsQVuv24KTWzbworkt7fypsDmpqsTY6b2 ug5yBcY9zlPgKiUoOaWZGOva2CUMF5z9e+7sqlOEwPSFM8VEvvHimNp+1AlQmHQqbarXQCaRdBTda mae0R8eUw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOstP-00G7MJ-Q3; Wed, 24 Mar 2021 02:05:07 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lOstC-00G7KR-0M for linux-arm-kernel@lists.infradead.org; Wed, 24 Mar 2021 02:04:56 +0000 Received: by mail-pf1-x434.google.com with SMTP id l3so16226499pfc.7 for ; Tue, 23 Mar 2021 19:04:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=br6Q9nB7EzUYGhvzSIch8sIAGewUeFhxJoVc038K6FM=; b=gCj9wu0DPQF3nxAjDePTGT6o/I3+3MFaoBuS0S8SRkHISCvcx2hCBGamPTxp7WSFkC yb2AgkaKXYAtLhlAABCIWTa2wJ7QKwWFeS0WDtlpZsM/3y3vCZpvdNjeczYqN1c2rDxR NhhB9N90GDPUbtPYn6wJKwLWxWw3dM6N5grf8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=br6Q9nB7EzUYGhvzSIch8sIAGewUeFhxJoVc038K6FM=; b=VrirOva3CMKvuStvmvimwTInYh9ipjIj4Zk0Szbn8V+Sw2rebUqyuElOnw4Gb2M9m7 yDbRuN0UZssgoHTEtz9Jf3B2II76uV/YX6+HVxj/P5Qz23sK62RbjL7Tyi85jRVnW6jZ KmG6fHJ5mi6yFkm+T5R32/u0k+rlZwg+G0lpivJQN2GMYyY19XVCuFJKM+uTyDiBKoz7 O+UjHwfgu2VbDGitDZbCNAzb4iQls3kvOc21beUVD2xffnuRKzMbeo03UU7CkvnSYxC0 9n2g7rLiy968OoJsi1LYjV4hc5JvQPGADTNbhHb3YWx++jPaVqWZKiMb8vScgHSfMzAA 4xSg== X-Gm-Message-State: AOAM532WlwdWwopzAek2bFg7mDT1rq3IJEIDu6MV5wQBWdYVxgBNTlF0 cnvxNIoktdmy/dPPDc2p9d2IhA== X-Google-Smtp-Source: ABdhPJya/tUfqxOxrzzqmFmGwgYqGsx9kpRcIhIF5cAHE/qmNC2FD8WYBf/aeveCHq1MxO1+5L+awg== X-Received: by 2002:aa7:8ec4:0:b029:1ee:f581:ec12 with SMTP id b4-20020aa78ec40000b02901eef581ec12mr966245pfr.0.1616551492667; Tue, 23 Mar 2021 19:04:52 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:84ac:62f7:16a8:ccc7]) by smtp.gmail.com with ESMTPSA id b3sm389441pjg.41.2021.03.23.19.04.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 19:04:52 -0700 (PDT) From: Stephen Boyd To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Jiri Olsa , Alexei Starovoitov , Jessica Yu , Evan Green , Hsin-Yi Wang , Petr Mladek , Steven Rostedt , Andy Shevchenko , Matthew Wilcox Subject: [PATCH v2 05/12] arm64: stacktrace: Use %pSb for backtrace printing Date: Tue, 23 Mar 2021 19:04:36 -0700 Message-Id: <20210324020443.1815557-6-swboyd@chromium.org> X-Mailer: git-send-email 2.31.0.291.g576ba9dcdaf-goog In-Reply-To: <20210324020443.1815557-1-swboyd@chromium.org> References: <20210324020443.1815557-1-swboyd@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210324_020454_272408_336C42B9 X-CRM114-Status: GOOD ( 15.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Let's use the new printk format to print the stacktrace entry when printing a backtrace to the kernel logs. This will include any module's build ID[1] in it so that offline/crash debugging can easily locate the debuginfo for a module via something like debuginfod[2]. Cc: Catalin Marinas Cc: Will Deacon Cc: Cc: Jiri Olsa Cc: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Cc: Petr Mladek Cc: Steven Rostedt Cc: Andy Shevchenko Cc: Matthew Wilcox Link: https://fedoraproject.org/wiki/Releases/FeatureBuildId [1] Link: https://sourceware.org/elfutils/Debuginfod.html [2] Signed-off-by: Stephen Boyd --- arch/arm64/kernel/stacktrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index ad20981dfda4..9d38da01ff98 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -129,7 +129,7 @@ NOKPROBE_SYMBOL(walk_stackframe); static void dump_backtrace_entry(unsigned long where, const char *loglvl) { - printk("%s %pS\n", loglvl, (void *)where); + printk("%s %pSb\n", loglvl, (void *)where); } void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk,