From patchwork Wed Mar 24 17:33:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161899 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3AD0C433E8 for ; Wed, 24 Mar 2021 17:35:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8506A61A22 for ; Wed, 24 Mar 2021 17:35:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237199AbhCXRej (ORCPT ); Wed, 24 Mar 2021 13:34:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237233AbhCXReP (ORCPT ); Wed, 24 Mar 2021 13:34:15 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93747C0613E0 for ; Wed, 24 Mar 2021 10:34:15 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id b16so28606357eds.7 for ; Wed, 24 Mar 2021 10:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YVoLbq8RBXUfihLEoAO2RhgjiaRVSJgl/YQpPYdz058=; b=F+iJ9M+WInt+IZa6vVqUUZZZXKjhcQ0sePVfsAX4epZi6SWJVwwuoO49lpEpWsG1B4 lKTGk75uroceeGyvtgjjYpPiujSmq/LW9HLYXMjM0earEN+yrwXDAj9NnLOb+WVywr0E OihBB1Ah5Y+zYcknMsE9vNN7NU+z3C60+eoaaYCl/YU9INj8EwOoX8ifSB03NMHEefq3 /1U3MTbAvW7ffjBahhaiMpWExcRT0HxVlOb4shQrt6UVPCrPlcrAF3Dfoa6Vx6HmEYjV 3nQXYNopEpnO8Qzbnfdkla5KC38yLS6Y+r2C9Ghawi14bY0tK9CVh7OD8mP5/Y1usLIK 4D/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YVoLbq8RBXUfihLEoAO2RhgjiaRVSJgl/YQpPYdz058=; b=reBlnvil+bic68sMvrn+3HgJDk5HtR1wPcl6zDAG1slB42ISzERr1rsFGECiyacWle 98Jwc8bA3hOo84agcztC80SrCZixq9eNOQxEdu/cvbIz1unoQktSo9MJkYigkbvZVcuB t5DOoJ0YaItIRXJdF4hElfi112626hTFtm4dtc0k98gq4Q5wweJ1L6Q+K+mz7AnNSaSS 87YGOM23VSs8gJINmZJupyVANiwfZ/F+sZE4ay9kPeKBmzV2rMkByFB0pIRiYKpikyxt N+RoUk2pRpOB+/k+DTUmIBnv8Lgbrfk5RGlc86JzsJXw4wH/oatNsv6j/q4HzNmIq1qW oTyw== X-Gm-Message-State: AOAM530FVlSgDlmaWuQ21k49nf2Ubvgz0wnifvTYopGB0X3VuPTTUidL UIrASXrW1+rWLY1X7BLA8h/gFg== X-Google-Smtp-Source: ABdhPJxRZif/QlzU41cuhZx3aHLwJ3xCFIf1WIBnnn5M/mUI6grvUz+kGd+AImbr0OB4afgXt35r3g== X-Received: by 2002:a05:6402:3587:: with SMTP id y7mr4901632edc.54.1616607254314; Wed, 24 Mar 2021 10:34:14 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:13 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , message to , linux-usb@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description Date: Wed, 24 Mar 2021 17:33:45 +0000 Message-Id: <20210324173404.66340-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/usbhid/usbkbd.c:66: warning: bad line: should be on Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: message to Cc: linux-usb@vger.kernel.org Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/usbhid/usbkbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c index d5b7a696a68c5..d0c640be8a885 100644 --- a/drivers/hid/usbhid/usbkbd.c +++ b/drivers/hid/usbhid/usbkbd.c @@ -63,7 +63,7 @@ static const unsigned char usb_kbd_keycode[256] = { * new key is pressed or a key that was pressed is released. * @led: URB for sending LEDs (e.g. numlock, ...) * @newleds: data that will be sent with the @led URB representing which LEDs - should be on + * should be on * @name: Name of the keyboard. @dev's name field points to this buffer * @phys: Physical path of the keyboard. @dev's phys field points to this * buffer From patchwork Wed Mar 24 17:33:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12161895 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A072C433E2 for ; Wed, 24 Mar 2021 17:35:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FA7C61A1F for ; Wed, 24 Mar 2021 17:35:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237233AbhCXRej (ORCPT ); Wed, 24 Mar 2021 13:34:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237245AbhCXReS (ORCPT ); Wed, 24 Mar 2021 13:34:18 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87930C0613E2 for ; Wed, 24 Mar 2021 10:34:17 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id bx7so28565049edb.12 for ; Wed, 24 Mar 2021 10:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E7/N3FVykAR22YhzUhZ15csg3vPH/3PyPAZDl2mJTyE=; b=VxIkrCxesyL14UeRs78vWlRa0oQXxXoxEI3HDGKMmeRkyUyy62wrRUC0w+4rynV6NY Ll5Rif5st8hCJyM8cC5Uk2fs4HmA72rZFok6HzR70YSH2FDLHt+9VQ2xQh/Nys9MlSxC P+PkpKSImwmZzOg3gBSgTPm8tYQidd6bJoT35BpgZHxu1t89/h/jNmRuH8LGfqALRXNj GuXNxRk90IrloCGke9ercsKjjKupoV7R3RawwgaIqClYUTfdx3wdABc4Zi84J1zQ6ErP QsDWP1QchO8lm4ioxgoQdnPwCcYH+TXz+vrXYv8VDQtcFiTAUShLkUZ8cg1+EXS+5uj2 Lhbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E7/N3FVykAR22YhzUhZ15csg3vPH/3PyPAZDl2mJTyE=; b=DYsu9mbBzNMtbv+8rkgotwIL8S/csFf9sfl95Tt2YG7iEModu0mZRIgXasvYYixZZs MSUVIio+vEeREwsaa6mVbxP2zhXTjxNsg8Orx4/NaOb1+Horcj3SCwAb2/lLEp8rLG/j oUDL7rpN7bBvFihpRSstB9OLqiSgpMsI7oIqw8goOu5I6v1qGGeuWsfatzjwVFSWKGg7 Vwl6MaaKoIZt1rb8k2R3x82GX3zVvRA+PxxvXpeJRpRYbr63zZ9CcIu9yXbBx4+/CcRM 0i3pwD+h9qQmHDb5vktMs+sohYP3AI/0zcw6n6Xyaw0FlesfSh/Vl9qaTZM2W8SkbJfa Dpow== X-Gm-Message-State: AOAM532HzSwGHofUfcDqSg19vcjog4OQSvnl4H9TatFPEfb7X8GWo0TY eJ0O7ZdccDBRWENvafvfZ+n2Ag== X-Google-Smtp-Source: ABdhPJylv30JqRZMzBDUUnpDl1vh1UfuC6zxexY7SFcPJS3j7MrLyWiG3W7ZVfKXIThRWIH3JDu2mA== X-Received: by 2002:a50:fc94:: with SMTP id f20mr4711938edq.370.1616607256236; Wed, 24 Mar 2021 10:34:16 -0700 (PDT) Received: from dell.default ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id p19sm1466367edr.57.2021.03.24.10.34.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 10:34:15 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Anssi Hannula , linux-usb@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH 08/25] HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses Date: Wed, 24 Mar 2021 17:33:47 +0000 Message-Id: <20210324173404.66340-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210324173404.66340-1-lee.jones@linaro.org> References: <20210324173404.66340-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'dev' not described in 'pidff_playback' drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'effect_id' not described in 'pidff_playback' drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'value' not described in 'pidff_playback' drivers/hid/usbhid/hid-pidff.c:512: warning: expecting prototype for value times(). Prototype was for pidff_playback() instead drivers/hid/usbhid/hid-pidff.c:1005: warning: Function parameter or member 'pidff' not described in 'pidff_find_effects' drivers/hid/usbhid/hid-pidff.c:1005: warning: Function parameter or member 'dev' not described in 'pidff_find_effects' drivers/hid/usbhid/hid-pidff.c:1005: warning: expecting prototype for Find the implemented effect types(). Prototype was for pidff_find_effects() instead Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Anssi Hannula Cc: linux-usb@vger.kernel.org Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/usbhid/hid-pidff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index fddac7c72f645..ea126c50acc3b 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -505,7 +505,7 @@ static void pidff_playback_pid(struct pidff_device *pidff, int pid_id, int n) HID_REQ_SET_REPORT); } -/** +/* * Play the effect with effect id @effect_id for @value times */ static int pidff_playback(struct input_dev *dev, int effect_id, int value) @@ -997,7 +997,7 @@ static int pidff_find_special_fields(struct pidff_device *pidff) return 0; } -/** +/* * Find the implemented effect types */ static int pidff_find_effects(struct pidff_device *pidff,